Re: [Qemu-block] [PATCH] nbd/server: attach client channel to the export's AioContext

2019-09-16 Thread Eric Blake
On 9/12/19 6:31 AM, Kevin Wolf wrote: >> >> Yes, I think locking the context during the "if (exp->blk) {" block at >> nbd/server.c:1646 should do the trick. That line number has moved over time; which function are you referring to? > > We need to be careful to avoid locking things twice, so

Re: [Qemu-block] [PATCH] nbd/server: attach client channel to the export's AioContext

2019-09-16 Thread Eric Blake
On 9/12/19 1:37 AM, Sergio Lopez wrote: >> I tried to test this patch, but even with it applied, I still got an >> aio-context crasher by attempting an nbd-server-start, nbd-server-add, >> nbd-server-stop (intentionally skipping the nbd-server-remove step) on a >> domain using iothreads, with a

Re: [Qemu-block] [PATCH] nbd/server: attach client channel to the export's AioContext

2019-09-12 Thread Kevin Wolf
Am 12.09.2019 um 12:30 hat Sergio Lopez geschrieben: > > Kevin Wolf writes: > > > Am 11.09.2019 um 23:33 hat Eric Blake geschrieben: > >> On 9/11/19 12:21 PM, Eric Blake wrote: > >> > On 9/11/19 11:15 AM, Sergio Lopez wrote: > >> >> On creation, the export's AioContext is set to the same one as

Re: [Qemu-block] [PATCH] nbd/server: attach client channel to the export's AioContext

2019-09-12 Thread Sergio Lopez
Kevin Wolf writes: > Am 11.09.2019 um 23:33 hat Eric Blake geschrieben: >> On 9/11/19 12:21 PM, Eric Blake wrote: >> > On 9/11/19 11:15 AM, Sergio Lopez wrote: >> >> On creation, the export's AioContext is set to the same one as the >> >> BlockBackend, while the AioContext in the client

Re: [Qemu-block] [PATCH] nbd/server: attach client channel to the export's AioContext

2019-09-12 Thread Kevin Wolf
Am 12.09.2019 um 12:13 hat Sergio Lopez geschrieben: > > Kevin Wolf writes: > > > Am 11.09.2019 um 18:15 hat Sergio Lopez geschrieben: > >> On creation, the export's AioContext is set to the same one as the > >> BlockBackend, while the AioContext in the client QIOChannel is left > >> untouched.

Re: [Qemu-block] [PATCH] nbd/server: attach client channel to the export's AioContext

2019-09-12 Thread Sergio Lopez
Kevin Wolf writes: > Am 11.09.2019 um 18:15 hat Sergio Lopez geschrieben: >> On creation, the export's AioContext is set to the same one as the >> BlockBackend, while the AioContext in the client QIOChannel is left >> untouched. >> >> As a result, when using data-plane,

Re: [Qemu-block] [PATCH] nbd/server: attach client channel to the export's AioContext

2019-09-12 Thread Kevin Wolf
Am 11.09.2019 um 18:15 hat Sergio Lopez geschrieben: > On creation, the export's AioContext is set to the same one as the > BlockBackend, while the AioContext in the client QIOChannel is left > untouched. > > As a result, when using data-plane, nbd_client_receive_next_request() > schedules

Re: [Qemu-block] [PATCH] nbd/server: attach client channel to the export's AioContext

2019-09-12 Thread Kevin Wolf
Am 11.09.2019 um 23:33 hat Eric Blake geschrieben: > On 9/11/19 12:21 PM, Eric Blake wrote: > > On 9/11/19 11:15 AM, Sergio Lopez wrote: > >> On creation, the export's AioContext is set to the same one as the > >> BlockBackend, while the AioContext in the client QIOChannel is left > >> untouched.

Re: [Qemu-block] [PATCH] nbd/server: attach client channel to the export's AioContext

2019-09-12 Thread Sergio Lopez
Eric Blake writes: > On 9/11/19 12:21 PM, Eric Blake wrote: >> On 9/11/19 11:15 AM, Sergio Lopez wrote: >>> On creation, the export's AioContext is set to the same one as the >>> BlockBackend, while the AioContext in the client QIOChannel is left >>> untouched. >>> >>> As a result, when using

Re: [Qemu-block] [PATCH] nbd/server: attach client channel to the export's AioContext

2019-09-11 Thread Eric Blake
On 9/11/19 4:33 PM, Eric Blake wrote: > I tried to test this patch, but even with it applied, I still got an > aio-context crasher by attempting an nbd-server-start, nbd-server-add, > nbd-server-stop (intentionally skipping the nbd-server-remove step) on a > domain using iothreads, with a

Re: [Qemu-block] [PATCH] nbd/server: attach client channel to the export's AioContext

2019-09-11 Thread Eric Blake
On 9/11/19 12:21 PM, Eric Blake wrote: > On 9/11/19 11:15 AM, Sergio Lopez wrote: >> On creation, the export's AioContext is set to the same one as the >> BlockBackend, while the AioContext in the client QIOChannel is left >> untouched. >> >> As a result, when using data-plane,

Re: [Qemu-block] [PATCH] nbd/server: attach client channel to the export's AioContext

2019-09-11 Thread Eric Blake
On 9/11/19 11:15 AM, Sergio Lopez wrote: > On creation, the export's AioContext is set to the same one as the > BlockBackend, while the AioContext in the client QIOChannel is left > untouched. > > As a result, when using data-plane, nbd_client_receive_next_request() > schedules coroutines in the