Re: [Qemu-block] [PATCH 1/1] nbd: increase maximum size of the PWRITE_ZERO request

2018-05-01 Thread Eric Blake
On 02/08/2018 07:23 AM, Edgar Kaziakhmedov wrote: Upstream NBD protocol implementation supports an efficient zero out mechanism over the wire, along with the ability to check whether a client allows using a hole. Accordingly, since PWRITE_ZERO doesn't involve any payload on the wire, increase a

Re: [Qemu-block] [PATCH 1/1] nbd: increase maximum size of the PWRITE_ZERO request

2018-02-08 Thread Edgar Kaziakhmedov
On 02/08/2018 06:55 PM, Eric Blake wrote: On 02/08/2018 09:28 AM, Edgar Kaziakhmedov wrote: We've got a potential problem.  Unless you have out-of-band communication of the maximum NBD_CMD_WRITE_ZEROES sizing (or if the NBD protocol is enhanced to advertise that as an additional piece of bl

Re: [Qemu-block] [PATCH 1/1] nbd: increase maximum size of the PWRITE_ZERO request

2018-02-08 Thread Eric Blake
On 02/08/2018 09:28 AM, Edgar Kaziakhmedov wrote: We've got a potential problem.  Unless you have out-of-band communication of the maximum NBD_CMD_WRITE_ZEROES sizing (or if the NBD protocol is enhanced to advertise that as an additional piece of block size information during NBD_OPT_GO), then

Re: [Qemu-block] [PATCH 1/1] nbd: increase maximum size of the PWRITE_ZERO request

2018-02-08 Thread Edgar Kaziakhmedov
On 02/08/2018 05:54 PM, Eric Blake wrote: On 02/08/2018 07:23 AM, Edgar Kaziakhmedov wrote: Upstream NBD protocol implementation supports an efficient zero out mechanism over the wire, along with the ability to check whether a client allows using a hole. Accordingly, since PWRITE_ZERO doesn't

Re: [Qemu-block] [PATCH 1/1] nbd: increase maximum size of the PWRITE_ZERO request

2018-02-08 Thread Eric Blake
On 02/08/2018 07:23 AM, Edgar Kaziakhmedov wrote: Upstream NBD protocol implementation supports an efficient zero out mechanism over the wire, along with the ability to check whether a client allows using a hole. Accordingly, since PWRITE_ZERO doesn't involve any payload on the wire, increase a