Re: [Qemu-block] [PATCH 2/2] iotests: add 208 nbd-server + blockdev-snapshot-sync test case

2018-03-12 Thread Max Reitz
On 2018-03-06 21:48, Stefan Hajnoczi wrote: > This test case adds an NBD server export and then invokes > blockdev-snapshot-sync, which changes the BlockDriverState node that the > NBD server's BlockBackend points to. This is an interesting scenario to > test and exercises the code path fixed by

Re: [Qemu-block] [PATCH 2/2] iotests: add 208 nbd-server + blockdev-snapshot-sync test case

2018-03-07 Thread Max Reitz
On 2018-03-07 17:43, Stefano Panella wrote: > > > On Wed, Mar 7, 2018 at 4:16 PM, Stefan Hajnoczi > wrote: >> >> On Wed, Mar 7, 2018 at 1:57 PM, Stefano Panella > wrote: >> > On Wed, Mar 7, 2018 at

Re: [Qemu-block] [PATCH 2/2] iotests: add 208 nbd-server + blockdev-snapshot-sync test case

2018-03-07 Thread Stefano Panella
On Wed, Mar 7, 2018 at 4:16 PM, Stefan Hajnoczi wrote: > > On Wed, Mar 7, 2018 at 1:57 PM, Stefano Panella wrote: > > On Wed, Mar 7, 2018 at 10:55 AM, Stefan Hajnoczi wrote: > >> > >> On Tue, Mar 6, 2018 at 11:25 PM, Stefano Panella

Re: [Qemu-block] [PATCH 2/2] iotests: add 208 nbd-server + blockdev-snapshot-sync test case

2018-03-07 Thread Max Reitz
On 2018-03-07 11:55, Stefan Hajnoczi wrote: > On Tue, Mar 6, 2018 at 11:25 PM, Stefano Panella wrote: >> I have applied this patch and when I run the following qmp commands I I do >> not see the crash anymore but there is still something wrong because only >> /root/a is opened

Re: [Qemu-block] [PATCH 2/2] iotests: add 208 nbd-server + blockdev-snapshot-sync test case

2018-03-07 Thread Stefan Hajnoczi
On Wed, Mar 7, 2018 at 1:57 PM, Stefano Panella wrote: > On Wed, Mar 7, 2018 at 10:55 AM, Stefan Hajnoczi wrote: >> >> On Tue, Mar 6, 2018 at 11:25 PM, Stefano Panella >> wrote: >> > I have applied this patch and when I run the

Re: [Qemu-block] [PATCH 2/2] iotests: add 208 nbd-server + blockdev-snapshot-sync test case

2018-03-07 Thread Stefano Panella
On Wed, Mar 7, 2018 at 10:55 AM, Stefan Hajnoczi wrote: > > On Tue, Mar 6, 2018 at 11:25 PM, Stefano Panella wrote: > > I have applied this patch and when I run the following qmp commands I I do > > not see the crash anymore but there is still something

Re: [Qemu-block] [PATCH 2/2] iotests: add 208 nbd-server + blockdev-snapshot-sync test case

2018-03-07 Thread Stefan Hajnoczi
On Tue, Mar 6, 2018 at 11:25 PM, Stefano Panella wrote: > I have applied this patch and when I run the following qmp commands I I do > not see the crash anymore but there is still something wrong because only > /root/a is opened from qemu. It looks like nbd-server-stop is also

Re: [Qemu-block] [PATCH 2/2] iotests: add 208 nbd-server + blockdev-snapshot-sync test case

2018-03-06 Thread Stefano Panella
I have applied this patch and when I run the following qmp commands I I do not see the crash anymore but there is still something wrong because only /root/a is opened from qemu. It looks like nbd-server-stop is also getting rid of the nodes added with blockdev-snapshot-sync, therfore is than not