Re: [Qemu-block] [PATCH RFC for-2.6 1/3] HBitmap: Introduce "meta" bitmap to track bit changes

2016-01-21 Thread Fam Zheng
On Thu, 01/21 13:58, Vladimir Sementsov-Ogievskiy wrote: > >>I thing now, that the same may be accomplished for BdrvDirtyBitmap, > >>all we need is return "changed" status from hb_set_between and then > >>from hbitmap_set. > >That is true, but it makes further optimizing to *really* only set the >

Re: [Qemu-block] [PATCH RFC for-2.6 1/3] HBitmap: Introduce "meta" bitmap to track bit changes

2016-01-21 Thread Vladimir Sementsov-Ogievskiy
On 30.12.2015 14:07, Fam Zheng wrote: On Wed, 12/30 13:53, Vladimir Sementsov-Ogievskiy wrote: On 07.12.2015 08:59, Fam Zheng wrote: The meta bitmap will have the same size and granularity as the tracked bitmap, and upon each bit toggle, the corresponding bit in the meta bitmap, at an identical

Re: [Qemu-block] [PATCH RFC for-2.6 1/3] HBitmap: Introduce "meta" bitmap to track bit changes

2015-12-30 Thread Vladimir Sementsov-Ogievskiy
On 30.12.2015 14:07, Fam Zheng wrote: On Wed, 12/30 13:53, Vladimir Sementsov-Ogievskiy wrote: On 07.12.2015 08:59, Fam Zheng wrote: The meta bitmap will have the same size and granularity as the tracked bitmap, and upon each bit toggle, the corresponding bit in the meta bitmap, at an identical

Re: [Qemu-block] [PATCH RFC for-2.6 1/3] HBitmap: Introduce "meta" bitmap to track bit changes

2015-12-30 Thread Fam Zheng
On Wed, 12/30 13:53, Vladimir Sementsov-Ogievskiy wrote: > On 07.12.2015 08:59, Fam Zheng wrote: > >The meta bitmap will have the same size and granularity as the tracked > >bitmap, and upon each bit toggle, the corresponding bit in the meta > >bitmap, at an identical position, will be set. > > > >

Re: [Qemu-block] [PATCH RFC for-2.6 1/3] HBitmap: Introduce "meta" bitmap to track bit changes

2015-12-30 Thread Vladimir Sementsov-Ogievskiy
On 07.12.2015 08:59, Fam Zheng wrote: The meta bitmap will have the same size and granularity as the tracked bitmap, and upon each bit toggle, the corresponding bit in the meta bitmap, at an identical position, will be set. Signed-off-by: Fam Zheng --- include/qemu/hbitmap.h | 7 +++ ut

Re: [Qemu-block] [PATCH RFC for-2.6 1/3] HBitmap: Introduce "meta" bitmap to track bit changes

2015-12-09 Thread Vladimir Sementsov-Ogievskiy
On 08.12.2015 04:31, Fam Zheng wrote: On Mon, 12/07 16:32, Vladimir Sementsov-Ogievskiy wrote: On 07.12.2015 08:59, Fam Zheng wrote: The meta bitmap will have the same size and granularity as the tracked bitmap, and upon each bit toggle, the corresponding bit in the meta bitmap, at an identical

Re: [Qemu-block] [PATCH RFC for-2.6 1/3] HBitmap: Introduce "meta" bitmap to track bit changes

2015-12-07 Thread Fam Zheng
On Mon, 12/07 16:32, Vladimir Sementsov-Ogievskiy wrote: > On 07.12.2015 08:59, Fam Zheng wrote: > >The meta bitmap will have the same size and granularity as the tracked > >bitmap, and upon each bit toggle, the corresponding bit in the meta > >bitmap, at an identical position, will be set. > > No

Re: [Qemu-block] [PATCH RFC for-2.6 1/3] HBitmap: Introduce "meta" bitmap to track bit changes

2015-12-07 Thread Vladimir Sementsov-Ogievskiy
On 07.12.2015 08:59, Fam Zheng wrote: The meta bitmap will have the same size and granularity as the tracked bitmap, and upon each bit toggle, the corresponding bit in the meta bitmap, at an identical position, will be set. No, meta bitmap should not have same granularity. If we have 16tb stor