Re: [Qemu-block] [PATCH v2 1/3] block: add bdrv_co_drain_end callback

2017-09-22 Thread Kevin Wolf
Am 22.09.2017 um 04:30 hat Fam Zheng geschrieben: > On Thu, 09/21 18:39, Manos Pitsidianakis wrote: > > On Thu, Sep 21, 2017 at 09:29:43PM +0800, Fam Zheng wrote: > > > On Thu, 09/21 16:17, Manos Pitsidianakis wrote: > > It might imply to someone that there's an assert(drv->bdrv_co_drain_begin &&

Re: [Qemu-block] [PATCH v2 1/3] block: add bdrv_co_drain_end callback

2017-09-21 Thread Fam Zheng
On Thu, 09/21 18:39, Manos Pitsidianakis wrote: > On Thu, Sep 21, 2017 at 09:29:43PM +0800, Fam Zheng wrote: > > On Thu, 09/21 16:17, Manos Pitsidianakis wrote: > > > BlockDriverState has a bdrv_do_drain() callback but no equivalent for the > > > end > > > > s/bdrv_do_drain/bdrv_co_drain/ > > >

Re: [Qemu-block] [PATCH v2 1/3] block: add bdrv_co_drain_end callback

2017-09-21 Thread Manos Pitsidianakis
On Thu, Sep 21, 2017 at 09:29:43PM +0800, Fam Zheng wrote: On Thu, 09/21 16:17, Manos Pitsidianakis wrote: BlockDriverState has a bdrv_do_drain() callback but no equivalent for the end s/bdrv_do_drain/bdrv_co_drain/ of the drain. The throttle driver (block/throttle.c) needs a way to mark

Re: [Qemu-block] [PATCH v2 1/3] block: add bdrv_co_drain_end callback

2017-09-21 Thread Fam Zheng
On Thu, 09/21 16:17, Manos Pitsidianakis wrote: > BlockDriverState has a bdrv_do_drain() callback but no equivalent for the end > of the drain. The throttle driver (block/throttle.c) needs a way to mark the > end of the drain in order to toggle io_limits_disabled correctly, thus >

Re: [Qemu-block] [PATCH v2 1/3] block: add bdrv_co_drain_end callback

2017-09-21 Thread Fam Zheng
On Thu, 09/21 16:17, Manos Pitsidianakis wrote: > BlockDriverState has a bdrv_do_drain() callback but no equivalent for the end s/bdrv_do_drain/bdrv_co_drain/ > of the drain. The throttle driver (block/throttle.c) needs a way to mark the > end of the drain in order to toggle io_limits_disabled