Re: [Qemu-block] [PATCH v3 27/39] qcow2: Update qcow2_update_snapshot_refcount() to support L2 slices

2018-02-02 Thread Alberto Garcia
On Thu 01 Feb 2018 08:26:26 PM CET, Max Reitz wrote: >> @@ -1273,12 +1276,13 @@ int qcow2_update_snapshot_refcount(BlockDriverState >> *bs, >> case QCOW2_CLUSTER_NORMAL: >> case QCOW2_CLUSTER_ZERO_ALLOC: >> if (offset_into_cluster

Re: [Qemu-block] [PATCH v3 27/39] qcow2: Update qcow2_update_snapshot_refcount() to support L2 slices

2018-02-01 Thread Max Reitz
On 2018-01-26 15:59, Alberto Garcia wrote: > qcow2_update_snapshot_refcount() increases the refcount of all > clusters of a given snapshot. In order to do that it needs to load all > its L2 tables and iterate over their entries. Since we'll be loading > L2 slices instead of full tables we need to a

Re: [Qemu-block] [PATCH v3 27/39] qcow2: Update qcow2_update_snapshot_refcount() to support L2 slices

2018-01-26 Thread Eric Blake
On 01/26/2018 08:59 AM, Alberto Garcia wrote: > qcow2_update_snapshot_refcount() increases the refcount of all > clusters of a given snapshot. In order to do that it needs to load all > its L2 tables and iterate over their entries. Since we'll be loading > L2 slices instead of full tables we need t