Re: [Qemu-block] [PATCH v4 04/12] block/nbd: Use qdict_put()

2016-10-13 Thread Kevin Wolf 
Am 28.09.2016 um 22:55 hat Max Reitz geschrieben:
> Instead of inlining this nice macro (i.e. resorting to
> qdict_put_obj(..., QOBJECT(...))), use it.
> 
> Signed-off-by: Max Reitz 

Reviewed-by: Kevin Wolf

Re: [Qemu-block] [PATCH v4 04/12] block/nbd: Use qdict_put()

2016-10-03 Thread Eric Blake 
On 09/28/2016 03:55 PM, Max Reitz wrote:
> Instead of inlining this nice macro (i.e. resorting to
> qdict_put_obj(..., QOBJECT(...))), use it.
> 
> Signed-off-by: Max Reitz 
> ---
>  block/nbd.c | 13 ++---
>  1 file changed, 6 insertions(+), 7 deletions(-)
> 

Reviewed-by: Eric Blake 

Hmm - should we have a Coccinelle script to automate this?

-- 
Eric Blake   eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org



signature.asc
Description: OpenPGP digital signature