Re: [Qemu-block] [PATCH v8 18/26] block: Add sgfnt_runtime_opts to BlockDriver

2018-02-22 Thread Alberto Garcia 
On Thu 22 Feb 2018 04:19:45 PM CET, Max Reitz wrote:
> On 2018-02-06 16:23, Alberto Garcia wrote:
>> On Mon 05 Feb 2018 04:18:27 PM CET, Max Reitz wrote:
>>> --- a/block/blkdebug.c
>>> +++ b/block/blkdebug.c
>>> @@ -886,6 +886,21 @@ static int blkdebug_reopen_prepare(BDRVReopenState 
>>> *reopen_state,
>>>  return 0;
>>>  }
>>>  
>>> +static const char *const blkdebug_sgfnt_runtime_opts[] = {
>>> +"config",
>>> +"inject-error.",
>>> +"set-state.",
>>> +"suspend.",
>> 
>> Where did this "suspend." come from?
>
> Er, well, er.
>
> After having looked at it a couple of times now, I can't see anything.
> I guess I'll remove it and hope for the best...?

My interpretation is that you saw

enum {
ACTION_INJECT_ERROR,
ACTION_SET_STATE,
ACTION_SUSPEND,
};

and assumed that "suspend" was an option (the other two are). I haven't
seen any string with the "suspend" text anywhere else in the code.

Berto

Re: [Qemu-block] [PATCH v8 18/26] block: Add sgfnt_runtime_opts to BlockDriver

2018-02-22 Thread Max Reitz 
On 2018-02-06 16:23, Alberto Garcia wrote:
> On Mon 05 Feb 2018 04:18:27 PM CET, Max Reitz wrote:
>> --- a/block/blkdebug.c
>> +++ b/block/blkdebug.c
>> @@ -886,6 +886,21 @@ static int blkdebug_reopen_prepare(BDRVReopenState 
>> *reopen_state,
>>  return 0;
>>  }
>>  
>> +static const char *const blkdebug_sgfnt_runtime_opts[] = {
>> +"config",
>> +"inject-error.",
>> +"set-state.",
>> +"suspend.",
> 
> Where did this "suspend." come from?

Er, well, er.

After having looked at it a couple of times now, I can't see anything.
I guess I'll remove it and hope for the best...?

Max



signature.asc
Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH v8 18/26] block: Add sgfnt_runtime_opts to BlockDriver

2018-02-06 Thread Alberto Garcia 
On Mon 05 Feb 2018 04:18:27 PM CET, Max Reitz wrote:
> --- a/block/blkdebug.c
> +++ b/block/blkdebug.c
> @@ -886,6 +886,21 @@ static int blkdebug_reopen_prepare(BDRVReopenState 
> *reopen_state,
>  return 0;
>  }
>  
> +static const char *const blkdebug_sgfnt_runtime_opts[] = {
> +"config",
> +"inject-error.",
> +"set-state.",
> +"suspend.",

Where did this "suspend." come from?

Berto