On Mon, Oct 10, 2016 at 11:07:09AM +0800, Xu Tian wrote: > If backing file can not open when do image rebase, flag 'ret' not > assign a non-zero value, then qemu-img process exit with code zero. > Assign value '-1' to flag 'ret' after report error message to fix > this defeat.
I suggest rewording the commit description: img_rebase() returns 0 (success) when opening the backing file fails because 'ret' isn't set. > BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1383012 > > Signed-off-by: Xu Tian <xut...@redhat.com> > --- > qemu-img.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
signature.asc
Description: PGP signature
