Re: [Qemu-block] [Qemu-devel] [PATCH] qemu-img: Improve commit invalid base message

[Max Reitz]

On 01.12.2016 03:36, Eric Blake wrote:
> On 11/30/2016 08:05 PM, Max Reitz wrote:
>> When trying to invoke qemu-img commit with a base image file name that
>> is not part of the top image's backing chain, the user receives a rather
>> plain "Base not found" error message. This is not really helpful because
>> it does not explain what "not found" means, potentially leaving the user
>> wondering why qemu cannot find a file despite it clearly existing in the
>> file system.
>>
>> Improve the error message by clarifying that "not found" means "not
>> found in the top image's backing chain".
>>
>> Reported-by: Ala Hino 
>> Signed-off-by: Max Reitz 
>> ---
>> Reported in: https://bugzilla.redhat.com/show_bug.cgi?id=1390991
>> ---
>>  qemu-img.c | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> Safe for 2.8, if the block maintainers agree.
> 
> Reviewed-by: Eric Blake 

Thanks!

I agree that it's safe, but we're at a point where only critical things
should go into the release. Getting this into 2.9 will be sufficient.

Max



signature.asc
Description: OpenPGP digital signature

Re: [Qemu-block] [Qemu-devel] [PATCH] qemu-img: Improve commit invalid base message

[Eric Blake]

On 11/30/2016 08:05 PM, Max Reitz wrote:
> When trying to invoke qemu-img commit with a base image file name that
> is not part of the top image's backing chain, the user receives a rather
> plain "Base not found" error message. This is not really helpful because
> it does not explain what "not found" means, potentially leaving the user
> wondering why qemu cannot find a file despite it clearly existing in the
> file system.
> 
> Improve the error message by clarifying that "not found" means "not
> found in the top image's backing chain".
> 
> Reported-by: Ala Hino 
> Signed-off-by: Max Reitz 
> ---
> Reported in: https://bugzilla.redhat.com/show_bug.cgi?id=1390991
> ---
>  qemu-img.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Safe for 2.8, if the block maintainers agree.

Reviewed-by: Eric Blake 

-- 
Eric Blake   eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org



signature.asc
Description: OpenPGP digital signature