Re: [Qemu-block] [Qemu-devel] [PATCH 4/4] scsi: add persistent reservation manager using qemu-pr-helper

On 19/09/2017 15:23, Paolo Bonzini wrote: > On 19/09/2017 15:12, Daniel P. Berrange wrote: >> On Tue, Sep 19, 2017 at 02:57:00PM +0200, Paolo Bonzini wrote: >>> On 19/09/2017 14:53, Daniel P. Berrange wrote: > +/* Try to reconnect while sending the CDB. */ > +for (attempts = 0;

Re: [Qemu-block] [Qemu-devel] [PATCH 4/4] scsi: add persistent reservation manager using qemu-pr-helper

On 19/09/2017 15:26, Daniel P. Berrange wrote: > On Tue, Sep 19, 2017 at 03:23:09PM +0200, Paolo Bonzini wrote: >> On 19/09/2017 15:12, Daniel P. Berrange wrote: >>> On Tue, Sep 19, 2017 at 02:57:00PM +0200, Paolo Bonzini wrote: On 19/09/2017 14:53, Daniel P. Berrange wrote: >> +/*

Re: [Qemu-block] [Qemu-devel] [PATCH 4/4] scsi: add persistent reservation manager using qemu-pr-helper

On 19/09/2017 15:12, Daniel P. Berrange wrote: > On Tue, Sep 19, 2017 at 02:57:00PM +0200, Paolo Bonzini wrote: >> On 19/09/2017 14:53, Daniel P. Berrange wrote: +/* Try to reconnect while sending the CDB. */ +for (attempts = 0; attempts < PR_MAX_RECONNECT_ATTEMPTS; attempts++)

Re: [Qemu-block] [Qemu-devel] [PATCH 4/4] scsi: add persistent reservation manager using qemu-pr-helper

On 19/09/2017 14:53, Daniel P. Berrange wrote: >> +/* Try to reconnect while sending the CDB. */ >> +for (attempts = 0; attempts < PR_MAX_RECONNECT_ATTEMPTS; attempts++) { > > I'm curious why you need to loop here. The helper daemon should be running > already, as you're not spawning it

Re: [Qemu-block] [Qemu-devel] [PATCH 4/4] scsi: add persistent reservation manager using qemu-pr-helper

On Tue, Sep 19, 2017 at 12:24:34PM +0200, Paolo Bonzini wrote: > This adds a concrete subclass of pr-manager that talks to qemu-pr-helper. > > Signed-off-by: Paolo Bonzini > --- > v1->v2: fixed string property double-free > fixed/cleaned up error handling >

Re: [Qemu-block] [Qemu-devel] [PATCH 4/4] scsi: add persistent reservation manager using qemu-pr-helper

On Tue, Sep 19, 2017 at 02:57:00PM +0200, Paolo Bonzini wrote: > On 19/09/2017 14:53, Daniel P. Berrange wrote: > >> +/* Try to reconnect while sending the CDB. */ > >> +for (attempts = 0; attempts < PR_MAX_RECONNECT_ATTEMPTS; attempts++) { > > > > I'm curious why you need to loop here.

Re: [Qemu-block] [Qemu-devel] [PATCH 4/4] scsi: add persistent reservation manager using qemu-pr-helper

On Tue, Sep 19, 2017 at 03:23:09PM +0200, Paolo Bonzini wrote: > On 19/09/2017 15:12, Daniel P. Berrange wrote: > > On Tue, Sep 19, 2017 at 02:57:00PM +0200, Paolo Bonzini wrote: > >> On 19/09/2017 14:53, Daniel P. Berrange wrote: > +/* Try to reconnect while sending the CDB. */ > +

Re: [Qemu-block] [Qemu-devel] [PATCH 4/4] scsi: add persistent reservation manager using qemu-pr-helper

On Tue, Sep 19, 2017 at 12:24:34PM +0200, Paolo Bonzini wrote: > This adds a concrete subclass of pr-manager that talks to qemu-pr-helper. > > Signed-off-by: Paolo Bonzini > --- > v1->v2: fixed string property double-free > fixed/cleaned up error handling >