Re: [Qemu-block] [Qemu-devel] [PATCH v3 17/39] qcow2: Update l2_allocate() to support L2 slices

2018-02-02 Thread Alberto Garcia
On Thu 01 Feb 2018 07:22:16 PM CET, Max Reitz wrote: > On 2018-02-01 16:43, Alberto Garcia wrote: >> On Thu 01 Feb 2018 04:23:09 PM CET, Anton Nefedov wrote: > However, I'm wondering whether this is the best approach. The old > L2 table is probably not going to be used after this function,

Re: [Qemu-block] [Qemu-devel] [PATCH v3 17/39] qcow2: Update l2_allocate() to support L2 slices

2018-02-01 Thread Max Reitz
On 2018-02-01 16:43, Alberto Garcia wrote: > On Thu 01 Feb 2018 04:23:09 PM CET, Anton Nefedov wrote: However, I'm wondering whether this is the best approach. The old L2 table is probably not going to be used after this function, so we're basically polluting the cache here. That w

Re: [Qemu-block] [Qemu-devel] [PATCH v3 17/39] qcow2: Update l2_allocate() to support L2 slices

2018-02-01 Thread Alberto Garcia
On Thu 01 Feb 2018 04:23:09 PM CET, Anton Nefedov wrote: >>> However, I'm wondering whether this is the best approach. The old >>> L2 table is probably not going to be used after this function, so >>> we're basically polluting the cache here. That was bad enough so >>> far, but now that actually

Re: [Qemu-block] [Qemu-devel] [PATCH v3 17/39] qcow2: Update l2_allocate() to support L2 slices

2018-02-01 Thread Anton Nefedov
On 1/2/2018 4:13 PM, Alberto Garcia wrote: On Wed 31 Jan 2018 09:07:48 PM CET, Max Reitz wrote: On 2018-01-26 15:59, Alberto Garcia wrote: This patch updates l2_allocate() to support the qcow2 cache returning L2 slices instead of full L2 tables. The old code simply gets an L2 table from the