Re: [Qemu-block] [RFC PATCH 06/10] block: Allow changing the backing file on reopen

2018-09-12 Thread Alberto Garcia
On Thu 21 Jun 2018 03:06:22 PM CEST, Kevin Wolf wrote: >> > Actually, do we ever use bdrv_reopen() for flags other than >> > read-only? Maybe we should get rid of that flags nonsense and >> > simply make it a bdrv_reopen_set_readonly() taking a boolean. >> >> I think that's a good idea. There's

Re: [Qemu-block] [RFC PATCH 06/10] block: Allow changing the backing file on reopen

2018-06-21 Thread Kevin Wolf
Am 20.06.2018 um 14:35 hat Alberto Garcia geschrieben: > On Wed 20 Jun 2018 12:58:55 PM CEST, Kevin Wolf wrote: > > Am 19.06.2018 um 16:20 hat Alberto Garcia geschrieben: > >> >> Wait, I think the description I gave is inaccurate: > >> >> > >> >> commit_complete() calls bdrv_drop_intermediate(),

Re: [Qemu-block] [RFC PATCH 06/10] block: Allow changing the backing file on reopen

2018-06-20 Thread Alberto Garcia
On Wed 20 Jun 2018 12:58:55 PM CEST, Kevin Wolf wrote: > Am 19.06.2018 um 16:20 hat Alberto Garcia geschrieben: >> >> Wait, I think the description I gave is inaccurate: >> >> >> >> commit_complete() calls bdrv_drop_intermediate(), and that updates the >> >> backing image name

Re: [Qemu-block] [RFC PATCH 06/10] block: Allow changing the backing file on reopen

2018-06-20 Thread Kevin Wolf
Am 19.06.2018 um 16:20 hat Alberto Garcia geschrieben: > >> Wait, I think the description I gave is inaccurate: > >> > >> commit_complete() calls bdrv_drop_intermediate(), and that updates the > >> backing image name (c->role->update_filename()). If we're doing this in > >> an intermediate node

Re: [Qemu-block] [RFC PATCH 06/10] block: Allow changing the backing file on reopen

2018-06-19 Thread Alberto Garcia
>> Wait, I think the description I gave is inaccurate: >> >> commit_complete() calls bdrv_drop_intermediate(), and that updates the >> backing image name (c->role->update_filename()). If we're doing this in >> an intermediate node then it needs to be reopened in read-write mode, >> while keeping

Re: [Qemu-block] [RFC PATCH 06/10] block: Allow changing the backing file on reopen

2018-06-19 Thread Kevin Wolf
Am 19.06.2018 um 14:27 hat Alberto Garcia geschrieben: > On Mon 18 Jun 2018 06:12:29 PM CEST, Kevin Wolf wrote: > >> >> This patch allows the user to change the backing file of an image > >> >> that is being reopened. Here's what it does: > >> >> > >> >> - In bdrv_reopen_queue_child(): if the

Re: [Qemu-block] [RFC PATCH 06/10] block: Allow changing the backing file on reopen

2018-06-19 Thread Alberto Garcia
On Mon 18 Jun 2018 06:12:29 PM CEST, Kevin Wolf wrote: >> >> This patch allows the user to change the backing file of an image >> >> that is being reopened. Here's what it does: >> >> >> >> - In bdrv_reopen_queue_child(): if the 'backing' option points to an >> >>image different from the

Re: [Qemu-block] [RFC PATCH 06/10] block: Allow changing the backing file on reopen

2018-06-18 Thread Kevin Wolf
Am 18.06.2018 um 17:06 hat Alberto Garcia geschrieben: > On Mon 18 Jun 2018 04:38:01 PM CEST, Kevin Wolf wrote: > > Am 14.06.2018 um 17:49 hat Alberto Garcia geschrieben: > >> This patch allows the user to change the backing file of an image that > >> is being reopened. Here's what it does: > >>

Re: [Qemu-block] [RFC PATCH 06/10] block: Allow changing the backing file on reopen

2018-06-18 Thread Alberto Garcia
On Mon 18 Jun 2018 04:38:01 PM CEST, Kevin Wolf wrote: > Am 14.06.2018 um 17:49 hat Alberto Garcia geschrieben: >> This patch allows the user to change the backing file of an image that >> is being reopened. Here's what it does: >> >> - In bdrv_reopen_queue_child(): if the 'backing' option

Re: [Qemu-block] [RFC PATCH 06/10] block: Allow changing the backing file on reopen

2018-06-18 Thread Kevin Wolf
Am 14.06.2018 um 17:49 hat Alberto Garcia geschrieben: > This patch allows the user to change the backing file of an image that > is being reopened. Here's what it does: > > - In bdrv_reopen_queue_child(): if the 'backing' option points to an >image different from the current backing file