Re: qemu-img create with preallocation=full and cluster-size=2M produces a bad file

2020-09-14 Thread Max Reitz
On 14.09.20 10:22, Max Reitz wrote:
> On 11.09.20 17:39, Alberto Garcia wrote:
>> On Fri 11 Sep 2020 04:55:08 PM CEST, Alberto Garcia wrote:
 $ qemu-img check prealloc_4G_2M.qcow2
 ERROR: coffset=0x180a0: copied flag must never be set for 
 compressed clusters
>>
>> I see, this was fixed recently (QEMU 5.0.0 is still affected), here is
>> the patch:
>>
>> https://git.qemu.org/?p=qemu.git;a=commitdiff;h=348fcc4f7ace1718006e646078d88c8cd8c1d97e
>>
>> I think this should also be set to qemu-stable, Kevin, Max?
> 
> Well, how do you set things to stable after the commit has been merged?
> 
> Judging from stable-process.rst, we’ll have to reply to the patch in
> question and CC qemu-stable.  So let’s do that.

On second thought, I see that the 5.0.1 stable freeze was last Thursday,
so it’s not going into 5.0.1 anyway.

Max



signature.asc
Description: OpenPGP digital signature


Re: qemu-img create with preallocation=full and cluster-size=2M produces a bad file

2020-09-14 Thread Max Reitz
On 11.09.20 17:39, Alberto Garcia wrote:
> On Fri 11 Sep 2020 04:55:08 PM CEST, Alberto Garcia wrote:
>>> $ qemu-img check prealloc_4G_2M.qcow2
>>> ERROR: coffset=0x180a0: copied flag must never be set for 
>>> compressed clusters
> 
> I see, this was fixed recently (QEMU 5.0.0 is still affected), here is
> the patch:
> 
> https://git.qemu.org/?p=qemu.git;a=commitdiff;h=348fcc4f7ace1718006e646078d88c8cd8c1d97e
> 
> I think this should also be set to qemu-stable, Kevin, Max?

Well, how do you set things to stable after the commit has been merged?

Judging from stable-process.rst, we’ll have to reply to the patch in
question and CC qemu-stable.  So let’s do that.

Max



signature.asc
Description: OpenPGP digital signature


Re: qemu-img create with preallocation=full and cluster-size=2M produces a bad file

2020-09-11 Thread Alberto Garcia
On Fri 11 Sep 2020 04:55:08 PM CEST, Alberto Garcia wrote:
>> $ qemu-img check prealloc_4G_2M.qcow2
>> ERROR: coffset=0x180a0: copied flag must never be set for 
>> compressed clusters

I see, this was fixed recently (QEMU 5.0.0 is still affected), here is
the patch:

https://git.qemu.org/?p=qemu.git;a=commitdiff;h=348fcc4f7ace1718006e646078d88c8cd8c1d97e

I think this should also be set to qemu-stable, Kevin, Max?

Berto



Re: qemu-img create with preallocation=full and cluster-size=2M produces a bad file

2020-09-11 Thread Alberto Garcia
On Fri 11 Sep 2020 04:30:45 PM CEST, Bryan S Rosenburg wrote:
> $ qemu-img --version
> qemu-img version 4.2.0 (Debian 1:4.2-3ubuntu6.4)
> Copyright (c) 2003-2019 Fabrice Bellard and the QEMU Project developers
>
> $ qemu-img create -f qcow2 prealloc_4G_2M.qcow2 4G -o 
> preallocation=full,cluster_size=2M
> Formatting 'prealloc_4G_2M.qcow2', fmt=qcow2 size=4294967296 
> cluster_size=2097152 preallocation=full lazy_refcounts=off 
> refcount_bits=16
>
> $ qemu-img check prealloc_4G_2M.qcow2
> ERROR: coffset=0x180a0: copied flag must never be set for 
> compressed clusters

I can reproduce that problem with 4.2.0 from Ubuntu but not with QEMU
3.1.0 nor with the latest master (post-5.1.0). I will investigate, it
looks like it would need a fix for Ubuntu LTS.

Berto