Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: 649ae1040db656d5775f711e0dbea4c09c6c8fe9 https://github.com/qemu/qemu/commit/649ae1040db656d5775f711e0dbea4c09c6c8fe9 Author: Gerd Hoffmann <kra...@redhat.com> Date: 2018-06-12 (Tue, 12 Jun 2018)
Changed paths: M docs/usb2.txt Log Message: ----------- usb: update docs xhci is rock solid meanwhile. So move it up in the docs and feature it as prefered usb host adapter, instead of the old shy version saying "you might want try ...". While being at it rework the text on ehci and companion controllers too. Signed-off-by: Gerd Hoffmann <kra...@redhat.com> Reviewed-by: Markus Armbruster <arm...@redhat.com> Message-id: 20180605132915.3640-1-kra...@redhat.com Commit: bf78fb1c1b61a819a47f7a1dbecf9934b9f32a0d https://github.com/qemu/qemu/commit/bf78fb1c1b61a819a47f7a1dbecf9934b9f32a0d Author: Philippe Mathieu-Daudé <f4...@amsat.org> Date: 2018-06-12 (Tue, 12 Jun 2018) Changed paths: M hw/usb/redirect.c Log Message: ----------- usb: correctly handle Zero Length Packets USB Specification Revision 2.0, §5.5.3: The Data stage of a control transfer from an endpoint to the host is complete when the endpoint does one of the following: • Has transferred exactly the amount of data specified during the Setup stage • Transfers a packet with a payload size less than wMaxPacketSize or transfers a zero-length packet" hw/usb/redirect.c:802:9: warning: Declared variable-length array (VLA) has zero size uint8_t buf[size]; ^~~~~~~~~~~ ~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Message-id: 20180604151421.23385-2-f4...@amsat.org Signed-off-by: Gerd Hoffmann <kra...@redhat.com> Commit: 62713a2e50f653162387451034f1a2490e87be88 https://github.com/qemu/qemu/commit/62713a2e50f653162387451034f1a2490e87be88 Author: Philippe Mathieu-Daudé <f4...@amsat.org> Date: 2018-06-12 (Tue, 12 Jun 2018) Changed paths: M hw/usb/dev-mtp.c Log Message: ----------- usb/dev-mtp: Fix use of uninitialized values This fixes: hw/usb/dev-mtp.c:971:5: warning: 4th function call argument is an uninitialized value trace_usb_mtp_op_get_partial_object(s->dev.addr, o->handle, o->path, c->argv[1], c->argv[2]); ^~~~~~~~~~ and: hw/usb/dev-mtp.c:981:12: warning: Assigned value is garbage or undefined offset = c->argv[1]; ^ ~~~~~~~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Message-id: 20180604151421.23385-3-f4...@amsat.org Signed-off-by: Gerd Hoffmann <kra...@redhat.com> Commit: f3d58385a6d3d82f65db602c5506e2d3d8c82394 https://github.com/qemu/qemu/commit/f3d58385a6d3d82f65db602c5506e2d3d8c82394 Author: Marc-André Lureau <marcandre.lur...@redhat.com> Date: 2018-06-12 (Tue, 12 Jun 2018) Changed paths: M hw/core/bus.c Log Message: ----------- bus: do not unref the added child bus on realize When the parent bus removes the child property, it takes care of removing the added reference, in object_finalize_child_property(). Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> Message-id: 20180531195119.22021-2-marcandre.lur...@redhat.com Signed-off-by: Gerd Hoffmann <kra...@redhat.com> Commit: 265b578c584b1a86c7028790deaa2f4392dd0a65 https://github.com/qemu/qemu/commit/265b578c584b1a86c7028790deaa2f4392dd0a65 Author: Marc-André Lureau <marcandre.lur...@redhat.com> Date: 2018-06-12 (Tue, 12 Jun 2018) Changed paths: M hw/core/qdev-properties.c M hw/core/qdev.c M hw/display/xlnx_dp.c M hw/dma/xilinx_axidma.c M hw/dma/xlnx-zdma.c M hw/i386/pc.c M hw/i386/pc_piix.c M hw/i386/pc_q35.c M hw/ipmi/ipmi.c M hw/net/xilinx_axienet.c M hw/ssi/xilinx_spips.c M include/qom/object.h M net/can/can_host.c M net/colo-compare.c M qom/object.c M target/arm/cpu.c M ui/console.c Log Message: ----------- object: fix OBJ_PROP_LINK_UNREF_ON_RELEASE ambivalence A link property can be set during creation, with object_property_add_link() and later with object_property_set_link(). add_link() doesn't add a reference to the target object, while set_link() does. Furthemore, OBJ_PROP_LINK_UNREF_ON_RELEASE flags, set during add_link, says whether a reference must be released when the property is destroyed. This can lead to leaks if the property was later set_link(), as the added reference is never released. Instead, rename OBJ_PROP_LINK_UNREF_ON_RELEASE to OBJ_PROP_LINK_STRONG and use that has an indication on how the link handle reference management in set_link(). Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> Message-id: 20180531195119.22021-3-marcandre.lur...@redhat.com Signed-off-by: Gerd Hoffmann <kra...@redhat.com> Commit: 410a096adf991ce437d4d7dabc59b6557e6d488d https://github.com/qemu/qemu/commit/410a096adf991ce437d4d7dabc59b6557e6d488d Author: Marc-André Lureau <marcandre.lur...@redhat.com> Date: 2018-06-12 (Tue, 12 Jun 2018) Changed paths: M hw/usb/dev-smartcard-reader.c Log Message: ----------- usb-ccid: fix bus leak qbus_create_inplace() creates a new reference in realize(), it must be released in unrealize(). Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> Message-id: 20180531195119.22021-4-marcandre.lur...@redhat.com Signed-off-by: Gerd Hoffmann <kra...@redhat.com> Commit: 1a3ff20e67330a15d62b00c2916e3541872103c0 https://github.com/qemu/qemu/commit/1a3ff20e67330a15d62b00c2916e3541872103c0 Author: Marc-André Lureau <marcandre.lur...@redhat.com> Date: 2018-06-12 (Tue, 12 Jun 2018) Changed paths: M tests/usb-hcd-xhci-test.c Log Message: ----------- usb-hcd-xhci-test: add a test for ccid hotplug Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> Message-id: 20180531195119.22021-5-marcandre.lur...@redhat.com Signed-off-by: Gerd Hoffmann <kra...@redhat.com> Commit: 3c969a6022438cf59de10d2dc3c58f4807788f98 https://github.com/qemu/qemu/commit/3c969a6022438cf59de10d2dc3c58f4807788f98 Author: Bandan Das <b...@redhat.com> Date: 2018-06-12 (Tue, 12 Jun 2018) Changed paths: M hw/usb/dev-mtp.c Log Message: ----------- usb-mtp: Return error on suspicious TYPE_DATA packet from initiator CID 1390604 If the initiator sends a packet with TYPE_DATA set without initiating a CMD_GET_OBJECT_INFO first, then usb_mtp_get_data can trip on a null s->data_out. Signed-off-by: Bandan Das <b...@redhat.com> Message-Id: <jpgr2m8ajfk.fsf...@linux.bootlegged.copy> Signed-off-by: Gerd Hoffmann <kra...@redhat.com> Commit: 2ab09bf2f9f55b9fb8d2de6eb2ba2a8570e268e2 https://github.com/qemu/qemu/commit/2ab09bf2f9f55b9fb8d2de6eb2ba2a8570e268e2 Author: Peter Maydell <peter.mayd...@linaro.org> Date: 2018-06-12 (Tue, 12 Jun 2018) Changed paths: M docs/usb2.txt M hw/core/bus.c M hw/core/qdev-properties.c M hw/core/qdev.c M hw/display/xlnx_dp.c M hw/dma/xilinx_axidma.c M hw/dma/xlnx-zdma.c M hw/i386/pc.c M hw/i386/pc_piix.c M hw/i386/pc_q35.c M hw/ipmi/ipmi.c M hw/net/xilinx_axienet.c M hw/ssi/xilinx_spips.c M hw/usb/dev-mtp.c M hw/usb/dev-smartcard-reader.c M hw/usb/redirect.c M include/qom/object.h M net/can/can_host.c M net/colo-compare.c M qom/object.c M target/arm/cpu.c M tests/usb-hcd-xhci-test.c M ui/console.c Log Message: ----------- Merge remote-tracking branch 'remotes/kraxel/tags/usb-20180612-pull-request' into staging usb: bug fix collection, doc update. # gpg: Signature made Tue 12 Jun 2018 11:44:17 BST # gpg: using RSA key 4CB6D8EED3E87138 # gpg: Good signature from "Gerd Hoffmann (work) <kra...@redhat.com>" # gpg: aka "Gerd Hoffmann <g...@kraxel.org>" # gpg: aka "Gerd Hoffmann (private) <kra...@gmail.com>" # Primary key fingerprint: A032 8CFF B93A 17A7 9901 FE7D 4CB6 D8EE D3E8 7138 * remotes/kraxel/tags/usb-20180612-pull-request: usb-mtp: Return error on suspicious TYPE_DATA packet from initiator usb-hcd-xhci-test: add a test for ccid hotplug usb-ccid: fix bus leak object: fix OBJ_PROP_LINK_UNREF_ON_RELEASE ambivalence bus: do not unref the added child bus on realize usb/dev-mtp: Fix use of uninitialized values usb: correctly handle Zero Length Packets usb: update docs Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Compare: https://github.com/qemu/qemu/compare/3b68de85b9b9...2ab09bf2f9f5 **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.