[Qemu-devel] MBR has broken by the installer on qemu-system-ppc

2009-12-24 Thread MICHIMURA Tadao
Hi! I'm trying to install Fedora Core 6 (ppc) using qemu-system-ppc 0.12.0. However the system doesn't boot properly with following messages because the partition table has broken. Other versions of Fedora have same problem. Do I need any tips or tricks to install Fedora Core ? >> /usr/local/bi

Re: [Qemu-devel] [PATCH v2 master, stable-0.12] Don't load options roms intended to be loaded by the bios in qemu

2009-12-24 Thread Aurelien Jarno
On Thu, Dec 24, 2009 at 08:38:32AM +0200, Avi Kivity wrote: > On 12/24/2009 02:17 AM, Aurelien Jarno wrote: > >On Tue, Dec 22, 2009 at 11:57:02AM +0200, Avi Kivity wrote: > >>The first such option rom will load at address 0, which isn't very nice, > >>and the second will report a conflict and abort

Re: [Qemu-devel] [patch] target-alpha: squashed fpu qualifiers patch

2009-12-24 Thread Aurelien Jarno
On Fri, Dec 18, 2009 at 02:09:09PM -0800, Richard Henderson wrote: > This is a squashed version of the 3 or 4 incremental patches that I > had sent out for implementing the alpha fpu instruction qualifiers. > > First of all, this patch has a lot of coding style issues. I have reported some of th

[Qemu-devel] Re: [PATCH] Makefile: Update unmodified config-devices.mak automatically

2009-12-24 Thread Michael S. Tsirkin
On Thu, Dec 24, 2009 at 04:03:17PM +0100, Juan Quintela wrote: > "Michael S. Tsirkin" wrote: > > On Thu, Dec 24, 2009 at 02:31:58PM +0100, Stefan Weil wrote: > >> Michael S. Tsirkin schrieb: > >> > On Sun, Dec 20, 2009 at 03:39:03PM +0100, Stefan Weil wrote: > >> > > >> >> This makes rebuilds a

[Qemu-devel] Re: [PATCH] write option roms in pc-bios/

2009-12-24 Thread Avi Kivity
On 12/24/2009 04:27 PM, Paolo Bonzini wrote: Wow, I wonder how it worked for me... Got it. The option roms are built in pc-bios/optionrom, but QEMU loads the ones in pc-bios. So actually I was always testing Alexander's code even though I had done a "make -B" to feel safer. :-( H

[Qemu-devel] [PATCH v2] Added 'access' option to -drive flag

2009-12-24 Thread Naphtali Sprei
The new option is: access=[rw|ro|auto] rw: open the drive's file with Read and Write permission, don't continue if failed ro: open the file only with Read permission auto: open the file with Read and Write permission, if failed, try only Read permision For compatibility reasons, the default is

[Qemu-devel] [PATCH] add "info ioapic" monitor command

2009-12-24 Thread Gleb Natapov
Knowing ioapic configuration is very useful for the poor soles how need to debug guest occasionally. Signed-off-by: Gleb Natapov diff --git a/hw/ioapic.c b/hw/ioapic.c index b0ad78f..ffbe631 100644 --- a/hw/ioapic.c +++ b/hw/ioapic.c @@ -24,6 +24,7 @@ #include "pc.h" #include "qemu-timer.h" #i

[Qemu-devel] Re: [PATCH] write option roms in pc-bios/

2009-12-24 Thread Avi Kivity
On 12/24/2009 04:27 PM, Paolo Bonzini wrote: Got it. The option roms are built in pc-bios/optionrom, but QEMU loads the ones in pc-bios. So actually I was always testing Alexander's code even though I had done a "make -B" to feel safer. :-( Ah. When things work straight off for me I al

[Qemu-devel] [PATCH] write option roms in pc-bios/

2009-12-24 Thread Paolo Bonzini
>> The gdt address calculation in linuxboot.bin is broken in two ways: first >> it loads %cs into %eax, but that instruction leaves the high bits of %eax >> undefined and we did not clear them. Secondly, we completely ignore the >> incorrect %eax, and use the undefined %ebx instead. >> >> With thes

[Qemu-devel] [PATCH] Intel CPUs starting from pentium have apic

2009-12-24 Thread Gleb Natapov
Intel CPUs starting from pentium have apic. Lets advertise it. Signed-off-by: Gleb Natapov diff --git a/target-i386/helper.c b/target-i386/helper.c index 730e396..c39a993 100644 --- a/target-i386/helper.c +++ b/target-i386/helper.c @@ -106,7 +106,7 @@ typedef struct x86_def_t { #define I486_FE

[Qemu-devel] Re: [PATCH master, stable-0.12] linuxboot: fix gdt address calculation

2009-12-24 Thread Paolo Bonzini
On 12/24/2009 02:38 PM, Avi Kivity wrote: The gdt address calculation in linuxboot.bin is broken in two ways: first it loads %cs into %eax, but that instruction leaves the high bits of %eax undefined and we did not clear them. Secondly, we completely ignore the incorrect %eax, and use the undefi

Re: [Qemu-devel] [PATCH] Added 'access' option to -drive flag

2009-12-24 Thread Naphtali Sprei
Simon Horman wrote: > On Wed, Dec 23, 2009 at 02:12:23PM +0200, Naphtali Sprei wrote: >> Added 'access' option to -drive flag >> >> The new option is: access=[rw|ro|auto] >> rw: open the drive's file with Read and Write permission, don't continue if >> failed >> ro: open the file only with Read pe

Re: [Qemu-devel] [PATCH] Add definitions for current cpu models..

2009-12-24 Thread Avi Kivity
On 12/21/2009 08:46 AM, john cooper wrote: This adds definitions for contemporary processors which may be selected via -cpu, as an alternative to the existing use of -cpu qemu64 augmented with a series of feature flags. The primary motivation was determination of a least common denominator withi

[Qemu-devel] Re: [PATCH] Makefile: Update unmodified config-devices.mak automatically

2009-12-24 Thread Michael S. Tsirkin
On Thu, Dec 24, 2009 at 02:31:58PM +0100, Stefan Weil wrote: > Michael S. Tsirkin schrieb: > > On Sun, Dec 20, 2009 at 03:39:03PM +0100, Stefan Weil wrote: > > > >> This makes rebuilds after source updates easier > >> for most users (who don't edit config-devices.mak). > >> > >> Signed-off-by: S

[Qemu-devel] [PATCH master, stable-0.12] linuxboot: fix gdt address calculation

2009-12-24 Thread Avi Kivity
The gdt address calculation in linuxboot.bin is broken in two ways: first it loads %cs into %eax, but that instruction leaves the high bits of %eax undefined and we did not clear them. Secondly, we completely ignore the incorrect %eax, and use the undefined %ebx instead. With these issues fixed,

[Qemu-devel] Re: [PATCH] Makefile: Update unmodified config-devices.mak automatically

2009-12-24 Thread Stefan Weil
Michael S. Tsirkin schrieb: > On Sun, Dec 20, 2009 at 03:39:03PM +0100, Stefan Weil wrote: > >> This makes rebuilds after source updates easier >> for most users (who don't edit config-devices.mak). >> >> Signed-off-by: Stefan Weil >> > > Sorry about missing this and not commenting earlier

[Qemu-devel] [patch] Fix a typo in 'P' packet processing for M68K.

2009-12-24 Thread Kazu Hirata
Hi, Attached is a patch to fix a typo in 'P' packet processing for M68K. Without this patch, QEMU fails to honor GDB's P packets from GDB (writing to registers) for the address registers (A0 - A7). The problem is because of an obvious typo. Notice that the second "if" condition is meant to be n

[Qemu-devel] Re: [PATCH] Add definitions for current cpu models..

2009-12-24 Thread Marcelo Tosatti
On Mon, Dec 21, 2009 at 01:46:36AM -0500, john cooper wrote: > This adds definitions for contemporary processors > which may be selected via -cpu , as an > alternative to the existing use of -cpu qemu64 > augmented with a series of feature flags. > > The primary motivation was determination of a >

Re: [Qemu-devel] [PATCH-repost] Makefile: avoid defconfig annoyance

2009-12-24 Thread Michael S. Tsirkin
On Thu, Dec 24, 2009 at 01:46:49PM +0100, Stefan Weil wrote: > Michael S. Tsirkin schrieb: > > This will be the last time you get > > 'config-devices.mak out of date' warning. > > > > We have a config-devices.mak feature, which > > makes it possile for distros to disable devices > > they do not wan

[Qemu-devel] Re: [PATCH] Makefile: Update unmodified config-devices.mak automatically

2009-12-24 Thread Michael S. Tsirkin
On Sun, Dec 20, 2009 at 03:39:03PM +0100, Stefan Weil wrote: > This makes rebuilds after source updates easier > for most users (who don't edit config-devices.mak). > > Signed-off-by: Stefan Weil Sorry about missing this and not commenting earlier. So the problem here is that it relies on keepi

[Qemu-devel] [PATCH] qemu: memory notifiers

2009-12-24 Thread Michael S. Tsirkin
This adds notifiers for phys memory changes: a set of callbacks that vhost can register and update kernel accordingly. Down the road, kvm code can be switched to use these as well instead of calling kvm code directly from exec.c as is done now. Signed-off-by: Michael S. Tsirkin --- cpu-common.h

[Qemu-devel] [PATCH] net: add API to disable/enable polling

2009-12-24 Thread Michael S. Tsirkin
When vhost is bound to a backend device, we need to stop polling it when vhost is started, and restart polling when vhost is stopped. Add an API for that for use by vhost, and implement in tap backend. Signed-off-by: Michael S. Tsirkin --- net.h |3 +++ net/tap.c |8 2 files

[Qemu-devel] [PATCHv4 2/2] virtio: add features as qdev properties

2009-12-24 Thread Michael S. Tsirkin
Add feature bits as properties to virtio. This makes it possible to e.g. define machine without indirect buffer support, which is required for 0.10 compatibility, or without hardware checksum support, which is required for 0.11 compatibility. Since default values for optional features are now set

Re: [Qemu-devel] [PATCH-repost] Makefile: avoid defconfig annoyance

2009-12-24 Thread Stefan Weil
Michael S. Tsirkin schrieb: > This will be the last time you get > 'config-devices.mak out of date' warning. > > We have a config-devices.mak feature, which > makes it possile for distros to disable devices > they do not want. However, this is annoyng > for development where you just want > to use

[Qemu-devel] [PATCHv4 1/2] qdev: add bit property type

2009-12-24 Thread Michael S. Tsirkin
This adds "bit" property type, which is a boolean stored in a 32 bit integer field, with legal values on and off. Will be used by virtio for feature bits. Signed-off-by: Michael S. Tsirkin --- hw/qdev-properties.c | 70 +- hw/qdev.h|

[Qemu-devel] [PATCHv4 0/2] qemu: properties for feature compatibility

2009-12-24 Thread Michael S. Tsirkin
Here's what I came up with for solving the problem of differences in features depending on backend. This is especially important for vhost, but it also solves the problem of difference in features in virtio between 0.12 and 0.11. This also enables migration between different backends, e.g. betwee

[Qemu-devel] [PATCH-repost] Makefile: avoid defconfig annoyance

2009-12-24 Thread Michael S. Tsirkin
This will be the last time you get 'config-devices.mak out of date' warning. We have a config-devices.mak feature, which makes it possile for distros to disable devices they do not want. However, this is annoyng for development where you just want to use the default most of the time. We want to d

Re: [Qemu-devel] [PATCH 11/19] use a bottom half to run timers

2009-12-24 Thread Paolo Bonzini
On 12/24/2009 12:25 PM, Marcelo Tosatti wrote: /* rearm timer, if not periodic */ if (t->expired) { t->expired = 0; qemu_rearm_alarm_timer(t); } -> host_alarm_handler fires, sets bh->scheduled = 1 -> qemu_mod_timer sees qemu_alarm_pending() == true an

Re: [Qemu-devel] Re: [RFC PATCH 0/8] virtio-console: Move to qdev, multiple devices, generic ports

2009-12-24 Thread Amit Shah
On (Thu) Dec 24 2009 [12:33:17], Alexander Graf wrote: > > On 24.12.2009, at 11:34, Amit Shah wrote: > > > On (Thu) Dec 24 2009 [11:28:25], Alexander Graf wrote: > >> > >> ag...@s390t27:/tmp/qemu> ./s390x-softmmu/qemu-system-s390x -enable-kvm > >> -vnc :0 -kernel /boot/image > >> Did not find P

[Qemu-devel] Re: [RFC PATCH 0/8] virtio-console: Move to qdev, multiple devices, generic ports

2009-12-24 Thread Alexander Graf
On 24.12.2009, at 11:34, Amit Shah wrote: > On (Thu) Dec 24 2009 [11:28:25], Alexander Graf wrote: >> >> ag...@s390t27:/tmp/qemu> ./s390x-softmmu/qemu-system-s390x -enable-kvm -vnc >> :0 -kernel /boot/image >> Did not find PCI bus for virtio-serial-pci >> Did not find virtio-serial-bus bus for

[Qemu-devel] Re: [RFC PATCH 0/8] virtio-console: Move to qdev, multiple devices, generic ports

2009-12-24 Thread Alexander Graf
On 24.12.2009, at 11:47, Amit Shah wrote: > On (Thu) Dec 24 2009 [11:26:00], Alexander Graf wrote: >> >> On 23.12.2009, at 20:52, Amit Shah wrote: >> >>> Hello, >>> >>> This series splits up the patches by functionality. Note, however, >>> that patches 2-6 introduce some functionality that's a

Re: [Qemu-devel] [PATCH 11/19] use a bottom half to run timers

2009-12-24 Thread Marcelo Tosatti
On Thu, Dec 24, 2009 at 11:27:06AM +0100, Paolo Bonzini wrote: > On 12/23/2009 07:37 PM, Marcelo Tosatti wrote: >> You should probably make sure the bh handling is signal safe. Perhaps >> use atomic test-and-set for bh->schedule on qemu_bh_poll, etc... > > The worst thing that can happen is that qe

[Qemu-devel] Re: [RFC PATCH 0/8] virtio-console: Move to qdev, multiple devices, generic ports

2009-12-24 Thread Amit Shah
On (Thu) Dec 24 2009 [11:26:00], Alexander Graf wrote: > > On 23.12.2009, at 20:52, Amit Shah wrote: > > > Hello, > > > > This series splits up the patches by functionality. Note, however, > > that patches 2-6 introduce some functionality that's advertised to the > > guest as having to work all

[Qemu-devel] Re: [RFC PATCH 0/8] virtio-console: Move to qdev, multiple devices, generic ports

2009-12-24 Thread Amit Shah
On (Thu) Dec 24 2009 [11:28:25], Alexander Graf wrote: > > ag...@s390t27:/tmp/qemu> ./s390x-softmmu/qemu-system-s390x -enable-kvm -vnc > :0 -kernel /boot/image > Did not find PCI bus for virtio-serial-pci > Did not find virtio-serial-bus bus for virtconsole > ^cag...@s390t27:/tmp/qemu> > ag...@s

[Qemu-devel] Re: [RFC PATCH 0/8] virtio-console: Move to qdev, multiple devices, generic ports

2009-12-24 Thread Alexander Graf
On 23.12.2009, at 20:52, Amit Shah wrote: > Hello, > > This series splits up the patches by functionality. Note, however, > that patches 2-6 introduce some functionality that's advertised to the > guest as having to work all at once or not at all. Also, the savevm > version is bumped only once b

Re: [Qemu-devel] [PATCH 11/19] use a bottom half to run timers

2009-12-24 Thread Paolo Bonzini
On 12/23/2009 07:37 PM, Marcelo Tosatti wrote: You should probably make sure the bh handling is signal safe. Perhaps use atomic test-and-set for bh->schedule on qemu_bh_poll, etc... The worst thing that can happen is that qemu_bh_poll misses the alarm bottom half, and tcg_cpu_exec exits immedi

[Qemu-devel] Re: [RFC PATCH 0/8] virtio-console: Move to qdev, multiple devices, generic ports

2009-12-24 Thread Alexander Graf
On 23.12.2009, at 20:52, Amit Shah wrote: > Hello, > > This series splits up the patches by functionality. Note, however, > that patches 2-6 introduce some functionality that's advertised to the > guest as having to work all at once or not at all. Also, the savevm > version is bumped only once b

Re: [Qemu-devel] Re: [PATCH] Always swap endianness in DBDMA

2009-12-24 Thread Alexander Graf
On 24.12.2009, at 01:08, Aurelien Jarno wrote: > On Thu, Dec 24, 2009 at 12:39:36AM +0100, Laurent Vivier wrote: >> Le mercredi 23 décembre 2009 à 10:55 +, Paul Brook a écrit : The problem is that the whole define is just plain wrong which tells me that the code is using the bswap f

[Qemu-devel] [trivial patch] Add missing newline at the end of options list

2009-12-24 Thread Michael Tokarev
In qemu-kvm this place looks even more "interesting": -runas user Change to user id user just before starting the VM. -readconfig -writeconfig read/write config file-no-kvm disable KVM hardware virtualization -no-kvm-irqchip disable KVM kernel mode PIC/IOAPIC/LAP

Re: [Qemu-devel] [PATCH] Added 'access' option to -drive flag

2009-12-24 Thread Markus Armbruster
Naphtali Sprei writes: > Added 'access' option to -drive flag > > The new option is: access=[rw|ro|auto] > rw: open the drive's file with Read and Write permission, don't continue if > failed > ro: open the file only with Read permission > auto: open the file with Read and Write permission, if f

[Qemu-devel] [PATCH V10 03/27] acpi: add acpi constants from linux header files and use them.

2009-12-24 Thread Isaku Yamahata
add acpi constants from linux header files and replace the old constants with them. The acpi constants will be used by other file. Signed-off-by: Isaku Yamahata --- hw/acpi.c | 56 +++ hw/acpi.h | 78

[Qemu-devel] [PATCH V10 05/27] acpi_piix4: remove unused variable in get_pmsts().

2009-12-24 Thread Isaku Yamahata
remove unused variable in get_pmsts(). Signed-off-by: Isaku Yamahata --- hw/acpi_piix4.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c index 53efa2a..887c82f 100644 --- a/hw/acpi_piix4.c +++ b/hw/acpi_piix4.c @@ -63,8 +63,6 @@ static

[Qemu-devel] [PATCH V10 18/27] pc: split out piix specific part from pc.c into pc_piix.c

2009-12-24 Thread Isaku Yamahata
Finally, we can safely split out the piix specific part from pc.c into pc_piix.c. Signed-off-by: Isaku Yamahata --- Makefile.target |2 +- hw/pc.c | 264 +- hw/pc.h | 33 +++ hw/pc_piix.c| 251 +++

[Qemu-devel] [PATCH V10 16/27] pc: split out basic device init from pc_init1() into pc_basic_device_init()

2009-12-24 Thread Isaku Yamahata
Split out basic device, i.e. legacy devices like floppy, initialization from pc_init1() into pc_basic_device_init(). Later it will be used. Signed-off-by: Isaku Yamahata --- hw/pc.c | 87 +++--- 1 files changed, 49 insertions(+), 38 delet

[Qemu-devel] [PATCH V10 14/27] pc: split out memory allocation from pc_init1() into pc_memory_init()

2009-12-24 Thread Isaku Yamahata
Split out memory allocation and rom/bios loading which doesn't depend on piix from pc_init1() into pc_memory_init(). Later it will be used. Signed-off-by: Isaku Yamahata --- hw/pc.c | 74 +++--- 1 files changed, 46 insertions(+), 28 delet

Re: [Qemu-devel] [PATCH 2/3] virtio-console: Add a virtio-serial bus, support for multiple devices and ports

2009-12-24 Thread Markus Armbruster
Amit Shah writes: > On (Wed) Dec 23 2009 [23:07:24], Markus Armbruster wrote: [...] >> What happens if you have both -device virtio-serial-pci and >> -virtioconsole? > > Yeah; that's not recommended. But what would happen is two buses would > get spawned and the console from -virtioconsole would

[Qemu-devel] [PATCH V10 06/27] pc: initialize ioapic before use.

2009-12-24 Thread Isaku Yamahata
The changeset of 2c8d9340203c7f19265fd4cb2341f568217a3af6 prevents isa_irq_handler() from NULL refering of IsaIrqState::ioapic. However it would be better to initialize the member before reference. Signed-off-by: Isaku Yamahata --- hw/pc.c |6 +++--- 1 files changed, 3 insertions(+), 3 delet

[Qemu-devel] [PATCH V10 10/27] pc: remove global variable rtc_state by using qemu_irq.

2009-12-24 Thread Isaku Yamahata
Remove the reference to the global variable, rtc_state, by passing function argument to cmos_init_hd(), cmos_init(). And following d9c3231019a0fbacbe15dcb26a0e3708b726af77 which uses qemu_irq for powerdown to eliminate nasty #ifdef (TARGET_xxx), this patch removes #ifdef(TARGET_I386) and global var

[Qemu-devel] [PATCH V10 02/27] acpi: split out apm register emulation from acpi.c

2009-12-24 Thread Isaku Yamahata
Split out apm register emulation for acpi.c into pc_apm.c. The apm emulation will be used later. Signed-off-by: Isaku Yamahata --- Makefile.target |4 +- hw/acpi.c | 57 ++-- hw/pc_apm.c | 85 ++

[Qemu-devel] [PATCH V10 07/27] pc, i440fx: Make smm enable/disable function i440fx independent.

2009-12-24 Thread Isaku Yamahata
make cpu_smm_update() generic to be independent on i440fx by registering a callback. Signed-off-by: Isaku Yamahata --- hw/pc.c | 18 +++--- hw/pc.h |8 +++- hw/piix_pci.c |5 - 3 files changed, 26 insertions(+), 5 deletions(-) diff --git a/hw/pc.c b/hw/

[Qemu-devel] [PATCH V10 26/27] pc_apm: remove #ifdef DEBUG.

2009-12-24 Thread Isaku Yamahata
remove #ifdef DEBUG by using macro. Signed-off-by: Isaku Yamahata --- hw/pc_apm.c | 14 -- 1 files changed, 8 insertions(+), 6 deletions(-) diff --git a/hw/pc_apm.c b/hw/pc_apm.c index f6bcd7d..e1cee96 100644 --- a/hw/pc_apm.c +++ b/hw/pc_apm.c @@ -23,6 +23,12 @@ //#define DEBU

[Qemu-devel] [PATCH V10 24/27] pc_smbus: remove #ifdef DEBUG.

2009-12-24 Thread Isaku Yamahata
remove #ifdef DEBUG by using macro. Signed-off-by: Isaku Yamahata --- hw/pc_smbus.c | 21 - 1 files changed, 12 insertions(+), 9 deletions(-) diff --git a/hw/pc_smbus.c b/hw/pc_smbus.c index 850260d..9581aba 100644 --- a/hw/pc_smbus.c +++ b/hw/pc_smbus.c @@ -37,6 +37,15 @@

[Qemu-devel] [PATCH V10 13/27] pc: split out cpu initialization from pc_init1() into pc_cpus_init().

2009-12-24 Thread Isaku Yamahata
split out cpu initialization which is piix independent from pc_init1() into pc_cpus_init(). Later it will be used. Signed-off-by: Isaku Yamahata --- hw/pc.c | 32 +++- 1 files changed, 19 insertions(+), 13 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index 0929b50..

[Qemu-devel] [PATCH V10 25/27] acpi_piix4: remove #ifdef DEBUG.

2009-12-24 Thread Isaku Yamahata
removed #ifdef DEBUG by using macro. Signed-off-by: Isaku Yamahata --- hw/acpi_piix4.c | 54 ++ 1 files changed, 18 insertions(+), 36 deletions(-) diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c index 59a4d0f..aa63f0e 100644 --- a/hw/acpi_pii

[Qemu-devel] [PATCH V10 08/27] pc: make an unnecessary global variable, pit, local.

2009-12-24 Thread Isaku Yamahata
remove unnecessary global static variables, pit. Make it local. Signed-off-by: Isaku Yamahata --- hw/pc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index 00f4efa..93d0ce4 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -66,7 +66,6 @@ static fdctrl_t *fl

[Qemu-devel] [PATCH V10 01/27] acpi: split out pc smbus routines from acpi.c into pc_smbus.c

2009-12-24 Thread Isaku Yamahata
Split out pc smbus routines from acpi.c into pc_smbus.c and use it. The split out smbus emulation will be used later. Signed-off-by: Isaku Yamahata --- Makefile.target |2 + hw/acpi.c | 164 +++ hw/pc_smbus.c | 178 +++

[Qemu-devel] [PATCH V10 23/27] pci hotadd, acpi_piix4: remove global variables.

2009-12-24 Thread Isaku Yamahata
remove global variables, gpe and pci0_status by moving them into PIIX4PMState. Signed-off-by: Isaku Yamahata --- hw/acpi_piix4.c | 71 +- hw/pc.h |1 - hw/pc_piix.c|1 - 3 files changed, 38 insertions(+), 35 deletions(-)

[Qemu-devel] [PATCH V10 15/27] pc: split out vga initialization from pc_init1() into pc_vga_init().

2009-12-24 Thread Isaku Yamahata
Split out vga initialization which is independent of piix from pc_init1() as pc_vga_init(). Later it will be used. Signed-off-by: Isaku Yamahata --- hw/pc.c | 41 +++-- 1 files changed, 23 insertions(+), 18 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index

[Qemu-devel] [PATCH V10 20/27] rtc: make rtc_xxx accept/return ISADevice instead of RTCState.

2009-12-24 Thread Isaku Yamahata
To match rtc_xxx with qdev, make rtc_xxx accept and return ISADevice instead of RTCState. Signed-off-by: Isaku Yamahata --- hw/mc146818rtc.c | 26 +++--- hw/mc146818rtc.h |8 hw/mips_jazz.c |1 + hw/mips_malta.c |3 ++- hw/mips_r4k.c|3 ++- h

[Qemu-devel] [PATCH V10 09/27] pc: remove a global variable, floppy_controller.

2009-12-24 Thread Isaku Yamahata
Remove a global variable, floppy_controller. Since it is unnecessarily global, make it local and pass it as a function argument. Signed-off-by: Isaku Yamahata --- hw/pc.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index 93d0ce4..9bee55c 1006

[Qemu-devel] [PATCH V10 22/27] pci hotplug: add argument to pci hot plug callback.

2009-12-24 Thread Isaku Yamahata
The argument will be used later to remove global variable. Signed-off-by: Isaku Yamahata --- hw/acpi_piix4.c |6 +++--- hw/pci.c|8 +--- hw/pci.h|4 ++-- 3 files changed, 10 insertions(+), 8 deletions(-) diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c index 008373

[Qemu-devel] [PATCH V10 04/27] acpi: split acpi.c into the common part and the piix4 part.

2009-12-24 Thread Isaku Yamahata
Split acpi.c into the common part and the piix4 specific part. The common part will be used later. Signed-off-by: Isaku Yamahata --- Makefile.target |4 +- hw/acpi.c | 557 --- hw/{acpi.c => acpi_piix4.c} | 172 +

[Qemu-devel] [PATCH V10 00/27] split out piix specific part from pc emulator and some clean ups

2009-12-24 Thread Isaku Yamahata
Anthony. Can you please merge those patches as Gerd has agreed with the direction of this patch series. Gerd, can you provide acked-by or reviewed-by for patches you like? patch series description: This is the preparation patch for q35 chipset and PCIE support. This patch series is for spliting o

[Qemu-devel] [PATCH V10 21/27] acpi_piix4: qdevfy.

2009-12-24 Thread Isaku Yamahata
qdevfy acpi_piix4. Signed-off-by: Isaku Yamahata --- hw/acpi_piix4.c | 56 ++ 1 files changed, 43 insertions(+), 13 deletions(-) diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c index 2d12da7..0083731 100644 --- a/hw/acpi_piix4.c +++ b/hw/acpi

[Qemu-devel] [PATCH V10 27/27] mc146818rtc: remove #ifdef DEBUG_CMOS.

2009-12-24 Thread Isaku Yamahata
remove #ifdef DEBUG_CMOS by using macro. Signed-off-by: Isaku Yamahata --- hw/mc146818rtc.c | 18 ++ 1 files changed, 10 insertions(+), 8 deletions(-) diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c index 1eb991c..0e1dc07 100644 --- a/hw/mc146818rtc.c +++ b/hw/mc146818rtc.c @

[Qemu-devel] [PATCH V10 19/27] pc: move rtc declarations from pc.h into a dedicated header file.

2009-12-24 Thread Isaku Yamahata
Move rtc_xxx declarations from pc.h into mc146818rtc.h. Signed-off-by: Isaku Yamahata --- hw/mc146818rtc.h | 10 ++ hw/pc.h | 10 ++ 2 files changed, 12 insertions(+), 8 deletions(-) create mode 100644 hw/mc146818rtc.h diff --git a/hw/mc146818rtc.h b/hw/mc146818rtc

[Qemu-devel] [PATCH V10 17/27] pc: split out pci device init from pc_init1() into pc_pci_device_init()

2009-12-24 Thread Isaku Yamahata
Split out pci device initialization from pc_init1() into pc_pci_device_init(). and removed unnecessary braces. Signed-off-by: Isaku Yamahata --- hw/pc.c | 35 +++ 1 files changed, 19 insertions(+), 16 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index 3c01df8..0

[Qemu-devel] [PATCH V10 11/27] pc: introduce a function to allocate cpu irq.

2009-12-24 Thread Isaku Yamahata
Introduce a function, pc_allocate_cpu_irq(), to allocate cpu irq in order to make pic_irq_request() piix independent. Later piix code will be split out to another file keeping pic_irq_request() static. Signed-off-by: Isaku Yamahata --- hw/pc.c |7 ++- 1 files changed, 6 insertions(+), 1

[Qemu-devel] [PATCH V10 12/27] pc: make pc_init1() not refer ferr_irq directly.

2009-12-24 Thread Isaku Yamahata
By introducing a registering function, make pc_init1() not refer to ferr_irq directly in order to make ferr_irq piix independent. Later pc_init1() will be split out into another file keeping ferr_irq static. Signed-off-by: Isaku Yamahata --- hw/pc.c |8 +++- hw/pc.h |2 ++ 2 files ch