Re: [Qemu-devel] [PATCH 1/6] pc: add machine type for 0.12

2010-01-12 Thread Anthony Liguori
On 01/12/2010 11:10 AM, Gerd Hoffmann wrote: On 01/11/10 20:50, Anthony Liguori wrote: On 01/08/2010 08:25 AM, Gerd Hoffmann wrote: Add a new machine type for qemu 0.12. Also fixup the 0.11 machine type: msi for virtio-blk-pci was enabled after the 0.11 release, so turn it off in the 0.11

[Qemu-devel] Advise on updating SeaBIOS in stable

2010-01-12 Thread Anthony Liguori
Hi, I'm ready to cut another qemu stable release and I'm contemplating whether to update to 0.5.1 in stable. Generally speaking, we try to limit stable to bug fixes and changes that aren't user visible. 0.5.1 looks like a point on the master branch as opposed to a separate branch. I

Re: [Qemu-devel] [PATCH 0/9] PPC NewWorld fixery v3

2010-01-12 Thread Blue Swirl
On Tue, Jan 12, 2010 at 11:58 AM, Alexander Graf ag...@suse.de wrote: I'm trying to get the PPC64 system emulation target working finally. While doing so, I ran into several issues, all related to PCI this time. This patchset fixes all the PCI config space access and PCI interrupt mapping

Re: [Qemu-devel] [PATCHv7 3/3] virtio: add features as qdev properties

2010-01-12 Thread Michael S. Tsirkin
On Tue, Jan 12, 2010 at 07:09:27PM +0100, Christoph Hellwig wrote: This patch causes 100% reproducible boot panics in a Linux guest using virtio. My qemu command line is: /opt/qemu/bin/qemu-system-x86_64 \ -m 1500 \ -enable-kvm \ -drive

[Qemu-devel] Re: [PATCH 0/5] tcg-sparc improvements

2010-01-12 Thread Blue Swirl
On Mon, Jan 11, 2010 at 7:22 PM, Richard Henderson r...@twiddle.net wrote: As noticed elsewhere on the list mulu2_i32 is missing.  Which led me to notice that add2_i32 and sub2_i32 were also missing and also led me to notice that division was incorrectly implemented. My initial implementation

Re: [Qemu-devel] [PATCH 4/9] PPC: Include dump of lspci -nn on real G5

2010-01-12 Thread Blue Swirl
On Tue, Jan 12, 2010 at 11:58 AM, Alexander Graf ag...@suse.de wrote: To ease debugging and to know what we're lacking, I found it really useful to have an lspci dump of a real U3 based G5 around. So I added a comment for it. If people don't think it's important enough to include this

Re: [Qemu-devel] [PATCH 0/9] PPC NewWorld fixery v3

2010-01-12 Thread Alexander Graf
On 12.01.2010, at 20:45, Blue Swirl wrote: On Tue, Jan 12, 2010 at 11:58 AM, Alexander Graf ag...@suse.de wrote: I'm trying to get the PPC64 system emulation target working finally. While doing so, I ran into several issues, all related to PCI this time. This patchset fixes all the PCI

Re: [Qemu-devel] [PATCH 4/9] PPC: Include dump of lspci -nn on real G5

2010-01-12 Thread Alexander Graf
On 12.01.2010, at 21:16, Blue Swirl wrote: On Tue, Jan 12, 2010 at 11:58 AM, Alexander Graf ag...@suse.de wrote: To ease debugging and to know what we're lacking, I found it really useful to have an lspci dump of a real U3 based G5 around. So I added a comment for it. If people don't think

Re: [Qemu-devel] [PATCH] virtio-net: mac property is mandatory

2010-01-12 Thread Anthony Liguori
On 01/12/2010 12:50 PM, Michael S. Tsirkin wrote: Mac feature bit isn't going to work as all network cards already have a 'mac' property to set the mac address. Remove it from mask and add in get_features. Reported-by: Gerd Hoffmannkra...@redhat.com Signed-off-by: Michael S.

Re: [Qemu-devel] [PATCH 1/2] kvm: Use kvm-kmod headers if available

2010-01-12 Thread Anthony Liguori
On 01/12/2010 12:53 PM, Jan Kiszka wrote: Since kvm-kmod-2.6.32.2 we have an alternative source for recent KVM kernel headers. Use it when available and not overruled by --kerneldir. Signed-off-by: Jan Kiszkajan.kis...@siemens.com Applied all. Thanks. Regards, Anthony Liguori ---

Re: [Qemu-devel] [PATCH 1/6] pc: add machine type for 0.12

2010-01-12 Thread Gerd Hoffmann
On 01/12/10 20:36, Anthony Liguori wrote: Can you rebase this series to stable and submit? I rebased myself but one of the rom loader patches didn't apply and I'm concerned we're missing a previous patch here. If you can take a look, I'd appreciate it. It is a missing patch indeed. After

Re: [Qemu-devel] [PATCH 4/9] PPC: Include dump of lspci -nn on real G5

2010-01-12 Thread Blue Swirl
On Tue, Jan 12, 2010 at 8:35 PM, Alexander Graf ag...@suse.de wrote: On 12.01.2010, at 21:16, Blue Swirl wrote: On Tue, Jan 12, 2010 at 11:58 AM, Alexander Graf ag...@suse.de wrote: To ease debugging and to know what we're lacking, I found it really useful to have an lspci dump of a real

Re: [Qemu-devel] [PATCH 4/9] PPC: Include dump of lspci -nn on real G5

2010-01-12 Thread Alexander Graf
On 12.01.2010, at 21:43, Blue Swirl wrote: On Tue, Jan 12, 2010 at 8:35 PM, Alexander Graf ag...@suse.de wrote: On 12.01.2010, at 21:16, Blue Swirl wrote: On Tue, Jan 12, 2010 at 11:58 AM, Alexander Graf ag...@suse.de wrote: To ease debugging and to know what we're lacking, I found it

Re: [Qemu-devel] [PATCH 0/9] PPC NewWorld fixery v3

2010-01-12 Thread Blue Swirl
On Tue, Jan 12, 2010 at 8:34 PM, Alexander Graf ag...@suse.de wrote: On 12.01.2010, at 20:45, Blue Swirl wrote: On Tue, Jan 12, 2010 at 11:58 AM, Alexander Graf ag...@suse.de wrote: I'm trying to get the PPC64 system emulation target working finally. While doing so, I ran into several

[Qemu-devel] Re: [PATCH 1/2] kvm: Use kvm-kmod headers if available

2010-01-12 Thread Jan Kiszka
Doug Goldstein wrote: On Tue, Jan 12, 2010 at 12:53 PM, Jan Kiszka jan.kis...@siemens.com wrote: Since kvm-kmod-2.6.32.2 we have an alternative source for recent KVM kernel headers. Use it when available and not overruled by --kerneldir. Would it be possible to turn this into a configure

[Qemu-devel] Re: [RFC 0/7]: Add VNC connect/disconnect events

2010-01-12 Thread Luiz Capitulino
On Mon, 11 Jan 2010 13:55:19 + Daniel P. Berrange berra...@redhat.com wrote: So perhaps we should declare that the lifecycle is - CONNECT (provide IP / port details) - AUTHENTICATED (provide IP / port details + authenticated ID details eg x509 dname, or

Re: [Qemu-devel] [PATCH 9/9] PPC: Add USB per default on U3

2010-01-12 Thread Andreas Färber
Am 12.01.2010 um 12:58 schrieb Alexander Graf: Linux with CONFIG_PPC64 doesn't support ADB devices anymore, so we have to use USB for keyboard and mouse. This patch enables USB per default on U3 and adds a virtual keyboard and mouse there. Wasn't the PowerMac G3 bluewhite (Yosemite)

Re: [Qemu-devel] [PATCH 9/9] PPC: Add USB per default on U3

2010-01-12 Thread Alexander Graf
On 12.01.2010, at 22:54, Andreas Färber wrote: Am 12.01.2010 um 12:58 schrieb Alexander Graf: Linux with CONFIG_PPC64 doesn't support ADB devices anymore, so we have to use USB for keyboard and mouse. This patch enables USB per default on U3 and adds a virtual keyboard and mouse

Re: [Qemu-devel] [PATCHv7 3/3] virtio: add features as qdev properties

2010-01-12 Thread Christoph Hellwig
On Tue, Jan 12, 2010 at 09:50:55PM +0200, Michael S. Tsirkin wrote: So the issue is that wrong block size (0x) was passed to guest. Would it make sense to add some sanity checking in virtio-blk to make it not crash but fail in probe? Which block size values are sane? Yes, I'll cook

Re: [Qemu-devel] [PATCH 0/9] PPC NewWorld fixery v3

2010-01-12 Thread Alexander Graf
On 12.01.2010, at 21:52, Blue Swirl wrote: On Tue, Jan 12, 2010 at 8:34 PM, Alexander Graf ag...@suse.de wrote: On 12.01.2010, at 20:45, Blue Swirl wrote: On Tue, Jan 12, 2010 at 11:58 AM, Alexander Graf ag...@suse.de wrote: I'm trying to get the PPC64 system emulation target working

Re: [Qemu-devel] Re: [RFC 0/7]: Add VNC connect/disconnect events

2010-01-12 Thread Anthony Liguori
On 01/12/2010 03:28 PM, Luiz Capitulino wrote: On Mon, 11 Jan 2010 13:55:19 + Daniel P. Berrangeberra...@redhat.com wrote: So perhaps we should declare that the lifecycle is - CONNECT (provide IP / port details) - AUTHENTICATED (provide IP / port details + authenticated

[Qemu-devel] Re: [PATCH-RFC 01/13] virtio: export virtqueue structure

2010-01-12 Thread Anthony Liguori
On 01/11/2010 11:16 AM, Michael S. Tsirkin wrote: vhost needs physical addresses for ring so expose that structure. Signed-off-by: Michael S. Tsirkinm...@redhat.com I think accessor functions might make more sense. Regards, Anthony Liguori

[Qemu-devel] Re: [PATCH-RFC 02/13] kvm: add API to set ioeventfd

2010-01-12 Thread Anthony Liguori
On 01/11/2010 11:17 AM, Michael S. Tsirkin wrote: Signed-off-by: Michael S. Tsirkinm...@redhat.com --- kvm-all.c | 24 kvm.h |3 +++ 2 files changed, 27 insertions(+), 0 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index a312654..aa00119 100644 ---

[Qemu-devel] Re: [PATCH-RFC 03/13] virtio: add iofd/irqfd support

2010-01-12 Thread Anthony Liguori
On 01/11/2010 11:17 AM, Michael S. Tsirkin wrote: Add binding API to set iofd/irqfd support. Will be used by vhost. Signed-off-by: Michael S. Tsirkinm...@redhat.com --- hw/virtio.c | 13 ++--- hw/virtio.h |4 2 files changed, 14 insertions(+), 3 deletions(-) diff --git

Re: [Qemu-devel] [PATCH] [tftp] Handle TFTP ERROR from client

2010-01-12 Thread Thomas Horsten
2010/1/11 Anthony Liguori anth...@codemonkey.ws: On 01/07/2010 11:01 AM, Thomas Horsten wrote: ...The patch from Milan Plzik to return after sending OACK is also required for a complete fix. Applied. Thanks. Thanks. It appears that the patch Milan submitted was missed (probably because it

[Qemu-devel] Re: [PATCH-RFC 09/13] tap: add vhost/vhostfd options

2010-01-12 Thread Anthony Liguori
On 01/11/2010 11:22 AM, Michael S. Tsirkin wrote: Looks like order got mixed up: vhost_net header is added by a follow-up patch. Will be fixed in the next revision. Signed-off-by: Michael S. Tsirkinm...@redhat.com --- net.c |8 net/tap.c | 29

[Qemu-devel] Re: [PATCH-RFC 09/13] tap: add vhost/vhostfd options

2010-01-12 Thread Anthony Liguori
On 01/11/2010 11:22 AM, Michael S. Tsirkin wrote: Looks like order got mixed up: vhost_net header is added by a follow-up patch. Will be fixed in the next revision. Signed-off-by: Michael S. Tsirkinm...@redhat.com --- net.c |8 net/tap.c | 29

[Qemu-devel] Re: [PATCH-RFC 11/13] vhost net support

2010-01-12 Thread Anthony Liguori
On 01/11/2010 11:23 AM, Michael S. Tsirkin wrote: This adds vhost net support in qemu. Will be tied to tap device and virtio later. Raw backend is currently missing, will be worked on/submitted separately. Signed-off-by: Michael S. Tsirkinm...@redhat.com Hit send too quick.. here it is.

Re: [Qemu-devel] [PATCH] [tftp] Handle TFTP ERROR from client

2010-01-12 Thread Anthony Liguori
On 01/12/2010 04:38 PM, Thomas Horsten wrote: 2010/1/11 Anthony Liguorianth...@codemonkey.ws: On 01/07/2010 11:01 AM, Thomas Horsten wrote: ...The patch from Milan Plzik to return after sending OACK is also required for a complete fix. Applied. Thanks.

[Qemu-devel] Re: Advise on updating SeaBIOS in stable

2010-01-12 Thread Kevin O'Connor
On Tue, Jan 12, 2010 at 01:43:47PM -0600, Anthony Liguori wrote: Hi, I'm ready to cut another qemu stable release and I'm contemplating whether to update to 0.5.1 in stable. Generally speaking, we try to limit stable to bug fixes and changes that aren't user visible. 0.5.1 looks like a

Re: [Qemu-devel] Static analysis using clang on the x86_64 target

2010-01-12 Thread Amit Shah
On (Tue) Jan 12 2010 [19:35:08], Blue Swirl wrote: On Tue, Jan 12, 2010 at 6:13 PM, Amit Shah amit.s...@redhat.com wrote: Hello, Here's a run of the clang analyzer on qemu sources for the x86_64 target. See http://amitshah.fedorapeople.org/clang-output/2010-01-12-9/ for the

Re: [Qemu-devel] Static analysis using clang on the x86_64 target

2010-01-12 Thread Amit Shah
On (Tue) Jan 12 2010 [22:01:15], malc wrote: Both audio.c issues are wrong, dma/sb16 is of useless operation variety nevertheless the fix is pushed, hopefuly clang shouldn't complain about them anymore. Yes, the count went down to 95 from 98 after your commits. There are a few false

<    1   2