Re: [Qemu-devel] Qemu does not pass pressed caps lock to client

2010-02-12 Thread Kevin Wolf
Am 11.02.2010 22:13, schrieb Shahar Havivi: Qemu have a hack for capslock that is not working with Ubuntu. attached patch that fix it, as describe in this bug: https://bugs.launchpad.net/qemu/+bug/427612 Signed-off-by: Shahar Havivi shah...@gmail.com --- sdl.c |7 --- 1 files

[Qemu-devel] Re: [PATCH] arm host: Fix linker warning (m68k targets)

2010-02-12 Thread Stefan Weil
Stefan Weil schrieb: Compilation of m68k-softmmu or m68k-linux-user on arm host (or cross compilation for arm) results in a linker warning: LINK m68k-softmmu/qemu-system-m68k m68k-dis.o: warning: definition of `floatformat_ieee_single_little' overriding common arm-dis.o: warning: common is

[Qemu-devel] [PATCH] mingw32: Enable C99/POSIX format strings

2010-02-12 Thread Stefan Weil
Starting with mingw32-runtime 3.15, C99/POSIX format strings (%zu, %lld, ...) are supported by defining __USE_MINGW_ANSI_STDIO=1. As QEMU uses such format strings, unconditionally define this macro. It won't hurt on older revisions of mingw32-runtime. Tested with manually installed

Re: [Qemu-devel] [PATCH v0 00/21]: Monitor: improve handlers error handling

2010-02-12 Thread Markus Armbruster
Anthony Liguori anth...@codemonkey.ws writes: On 02/11/2010 10:57 AM, Markus Armbruster wrote: Yes, that's a sensible argument. It's also quite impractical at this time. In fact, I had the same idea, and dropped it like a hot potato when I realized how much code we'd have to touch for it.

[Qemu-devel] Re: [PATCH v4] block: more read-only changes, related to backing files

2010-02-12 Thread Kevin Wolf
Am 09.02.2010 11:44, schrieb Naphtali Sprei: This version includes handling the case the backing file cannot be re-opened Open backing file read-only where possible Upgrade backing file to read-write during commit, back to read-only after commit If upgrade fail, back to read-only. If

[Qemu-devel] [RFC] Documentation: Create qemu-doc.html with makeinfo instead of html2texi

2010-02-12 Thread Stefan Weil
Hello, today, html documentation is created using texi2html. makeinfo can also create html output which looks different. I think it looks better, but try it yourself: texi2html (old): http://wiki.qemu.org/download/qemu-doc.html makeinfo (new): http://www.weilnetz.de/qemu-doc.html (single file)

[Qemu-devel] Re: [PATCH] virtio-spec: document MSI-X

2010-02-12 Thread Michael S. Tsirkin
On Fri, Feb 12, 2010 at 08:17:55PM +1030, Rusty Russell wrote: On Fri, 12 Feb 2010 03:52:36 am Michael S. Tsirkin wrote: This documents MSI-X support in virtio. Signed-off-by: Michael S. Tsirkin m...@redhat.com Wow, great! I reworked one paragraph for better grammar. Mainly adding

Re: [Qemu-devel] Qemu does not pass pressed caps lock to client

2010-02-12 Thread Kevin Wolf
Am 12.02.2010 12:09, schrieb Shahar Havivi: It's not true that SDL is not sending up event like the comment say, On Fedora 12 it behave like a toggle button, first press/release will send caps-down event second press/release send caps-up event On Ubuntu 9.10 it work like any other key,

[Qemu-devel] Re: Qemu does not pass pressed caps lock to client

2010-02-12 Thread Paolo Bonzini
On 02/12/2010 12:09 PM, Shahar Havivi wrote: It's not true that SDL is not sending up event like the comment say, On Fedora 12 it behave like a toggle button, first press/release will send caps-down event second press/release send caps-up event On Ubuntu 9.10 it work like any other key, i.e.

Re: [Qemu-devel] Heads up: glibc preadv emulation breaks qemu on older kernels

2010-02-12 Thread Christoph Hellwig
On Thu, Feb 11, 2010 at 07:06:08PM +, Richard W.M. Jones wrote: One interesting thing is that qemu has its own preadv emulation (which does the emulation correctly), but this is never used because qemu never gets ENOSYS back from preadv. At this point the amount of bugs in the glibc

[Qemu-devel] Re: [PATCH] pci: introduce get_info_quirk callback.

2010-02-12 Thread Michael S. Tsirkin
On Fri, Feb 12, 2010 at 11:31:34AM +0900, Isaku Yamahata wrote: This patch fixes 525e05147d5a3bdc08caa422d108c1ef71b584b5 by introducing device specific get_info_quirk callback. It wrongly assumes that pci host bridge class device has header type of pci-pci bridge. But this isn't always true.

[Qemu-devel] Re: [PATCH] pci: introduce get_info_quirk callback.

2010-02-12 Thread Isaku Yamahata
On Fri, Feb 12, 2010 at 02:54:59PM +0200, Michael S. Tsirkin wrote: On Fri, Feb 12, 2010 at 11:31:34AM +0900, Isaku Yamahata wrote: This patch fixes 525e05147d5a3bdc08caa422d108c1ef71b584b5 by introducing device specific get_info_quirk callback. It wrongly assumes that pci host bridge class

[Qemu-devel] Re: [PATCH] virtio-serial: pci: Allow MSI to be disabled

2010-02-12 Thread Michael S. Tsirkin
On Fri, Feb 12, 2010 at 06:52:38PM +0530, Amit Shah wrote: Michael noted we don't allow disabling of MSI for the virtio-serial-pci device. Fix that. Signed-off-by: Amit Shah amit.s...@redhat.com CC: Michael S. Tsirkin m...@redhat.com How about using a symbolic constant for -1? We have

[Qemu-devel] [PATCH] virtio-serial: don't set MULTIPORT for 1 port dev

2010-02-12 Thread Michael S. Tsirkin
Since commit 98b19252cf1bd97c54bc4613f3537c5ec0aae263, all serial devices declare MULTIPORT feature. To allow 0.12 compatibility, we should clear this when max_nr_ports is 1. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/virtio-serial-bus.c |6 -- 1 files changed, 4

Re: [Qemu-devel] Heads up: glibc preadv emulation breaks qemu on older kernels

2010-02-12 Thread malc
On Fri, 12 Feb 2010, Christoph Hellwig wrote: On Thu, Feb 11, 2010 at 07:06:08PM +, Richard W.M. Jones wrote: One interesting thing is that qemu has its own preadv emulation (which does the emulation correctly), but this is never used because qemu never gets ENOSYS back from preadv.

Re: [Qemu-devel] Heads up: glibc preadv emulation breaks qemu on older kernels

2010-02-12 Thread Christoph Hellwig
On Fri, Feb 12, 2010 at 04:49:23PM +0300, malc wrote: On Fri, 12 Feb 2010, Christoph Hellwig wrote: On Thu, Feb 11, 2010 at 07:06:08PM +, Richard W.M. Jones wrote: One interesting thing is that qemu has its own preadv emulation (which does the emulation correctly), but this is never

[Qemu-devel] Re: [PATCH] virtio-serial: don't set MULTIPORT for 1 port dev

2010-02-12 Thread Amit Shah
On (Fri) Feb 12 2010 [15:42:14], Michael S. Tsirkin wrote: Since commit 98b19252cf1bd97c54bc4613f3537c5ec0aae263, all serial devices declare MULTIPORT feature. To allow 0.12 compatibility, we should clear this when max_nr_ports is 1. In addition to this, setting max_nr_ports to 1 is needed

Re: [Qemu-devel] Re: Qemu does not pass pressed caps lock to client

2010-02-12 Thread Anthony Liguori
On 02/12/2010 06:39 AM, Paolo Bonzini wrote: /* There are two versions around of a Debian patch that changes the way Caps Lock and Num Lock are handled. The first version by default sends only one of the KeyDown/KeyUp events, unless SDL_DISABLE_LOCK_KEYS is present in

Re: [Qemu-devel] Heads up: glibc preadv emulation breaks qemu on older kernels

2010-02-12 Thread Anthony Liguori
On 02/12/2010 07:50 AM, Christoph Hellwig wrote: On Fri, Feb 12, 2010 at 04:49:23PM +0300, malc wrote: On Fri, 12 Feb 2010, Christoph Hellwig wrote: On Thu, Feb 11, 2010 at 07:06:08PM +, Richard W.M. Jones wrote: One interesting thing is that qemu has its own preadv

Re: [Qemu-devel] [PATCH 0/15][RFC] New PCI interfaces

2010-02-12 Thread Blue Swirl
On Wed, Feb 10, 2010 at 11:13 PM, Anthony Liguori anth...@codemonkey.ws wrote: On 02/10/2010 02:41 PM, Richard Henderson wrote: On 02/10/2010 11:29 AM, Anthony Liguori wrote: void *pci_memory_map(PCIDevice *dev, pcibus_t addr, pcibus_t *plen, int is_write); void pci_memory_unmap(PCIDevice

[Qemu-devel] QError conversion problems: putting errors in context

2010-02-12 Thread Markus Armbruster
Our QError conversions were pretty straightforward so far. For example, when we found monitor_printf(mon, device is not removable\n); in eject_device(), we created the obvious QError class for it: #define QERR_DEVICE_NOT_REMOVABLE \ { 'class': 'DeviceNotRemovable', 'data':

Re: [Qemu-devel] Re: Qemu does not pass pressed caps lock to client

2010-02-12 Thread Paolo Bonzini
On 02/12/2010 04:15 PM, Anthony Liguori wrote: So basically, Debian carries a hacked version of SDL that changes the key press behaviour? Yes, the patch was submitted to not change the default but the maintainer thought he knew better. Or confused an == with a != more likely. That's a

[Qemu-devel] [PATCH] add usermode NPTL support for i386

2010-02-12 Thread matthieu castet
Hi, this patch try to add usermode NPTL support for i386. Note that this patch need review because I don't know if I did the right thing removing the cpu_reset in the clone path. Matthieu diff --git a/configure b/configure index 0a84b0e..69ccb13 100755 --- a/configure +++ b/configure @@

[Qemu-devel] Re: sparc32 fix spurious dma interrupts

2010-02-12 Thread Artyom Tarasenko
2010/2/10 Artyom Tarasenko atar4q...@googlemail.com: Don't raise interrupt when not enabled. Don't set DMA_INTR bit spuriously. Don't print misleading debug messages Raise IRQ when not raising any. Haven't noticed that these were introduced recently. Shall we revert

Re: [Qemu-devel] Re: Qemu does not pass pressed caps lock to client

2010-02-12 Thread Anthony Liguori
On 02/12/2010 12:17 PM, Paolo Bonzini wrote: On 02/12/2010 04:15 PM, Anthony Liguori wrote: So basically, Debian carries a hacked version of SDL that changes the key press behaviour? Yes, the patch was submitted to not change the default but the maintainer thought he knew better. Or

Re: [Qemu-devel] Heads up: glibc preadv emulation breaks qemu on older kernels

2010-02-12 Thread Richard W.M. Jones
On Fri, Feb 12, 2010 at 11:28:57AM -0600, Anthony Liguori wrote: I think a configure option would be in order. Forever avoiding glibc is probably a bit extreme. I think a configure option won't work. The issue here was that the binary is being installed on a machine with an older kernel.

Re: [Qemu-devel] Heads up: glibc preadv emulation breaks qemu on older kernels

2010-02-12 Thread Avi Kivity
On 02/12/2010 07:28 PM, Anthony Liguori wrote: On 02/12/2010 07:50 AM, Christoph Hellwig wrote: On Fri, Feb 12, 2010 at 04:49:23PM +0300, malc wrote: On Fri, 12 Feb 2010, Christoph Hellwig wrote: On Thu, Feb 11, 2010 at 07:06:08PM +, Richard W.M. Jones wrote: One interesting thing is

[Qemu-devel] Re: sparc32 fix spurious dma interrupts

2010-02-12 Thread Blue Swirl
On Thu, Feb 11, 2010 at 12:40 AM, Artyom Tarasenko atar4q...@googlemail.com wrote: Don't raise interrupt when not enabled. Don't set DMA_INTR bit spuriously. Don't print misleading debug messages Raise IRQ when not raising any. This breaks most of my Linux tests. *BSD are unaffected. For

Re: [Qemu-devel] [PATCH 3/6] Fix last page errors in page_set_flags and page_check_range.

2010-02-12 Thread Blue Swirl
On Fri, Feb 12, 2010 at 12:57 AM, Richard Henderson r...@twiddle.net wrote: The addr end comparison prevents the last page from being iterated; an iteration based on length avoids this problem. Please make separate patches for unrelated changes. Now the essence of the patch is very hard to

Re: [Qemu-devel] [PATCH 1/6] Move TARGET_PHYS_ADDR_SPACE_BITS to target-*/cpu.h.

2010-02-12 Thread Blue Swirl
On Fri, Feb 12, 2010 at 12:20 AM, Richard Henderson r...@twiddle.net wrote: Removes a set of ifdefs from exec.c. Introduce TARGET_VIRT_ADDR_SPACE_BITS for all targets other than Alpha.  This will be used for page_find_alloc, which is supposed to be using virtual addresses in the first place.

[Qemu-devel] Re: [PATCH] pci: introduce get_info_quirk callback.

2010-02-12 Thread Blue Swirl
On Fri, Feb 12, 2010 at 3:34 PM, Isaku Yamahata yamah...@valinux.co.jp wrote: On Fri, Feb 12, 2010 at 02:54:59PM +0200, Michael S. Tsirkin wrote: On Fri, Feb 12, 2010 at 11:31:34AM +0900, Isaku Yamahata wrote: This patch fixes 525e05147d5a3bdc08caa422d108c1ef71b584b5 by introducing device

[Qemu-devel] [PATCH] Fix hanging user monitor when using balloon command

2010-02-12 Thread Adam Litke
Hi Anthony. I wonder if there was a problem when importing my async command handler patchset. Since the 'balloon' command completes immediately, it must call the completion callback before returning. That call was missing but is added by the patch below. diff --git a/monitor.c b/monitor.c index

Re: [Qemu-devel] [PATCH 3/6] Fix last page errors in page_set_flags and page_check_range.

2010-02-12 Thread Richard Henderson
On 02/12/2010 11:47 AM, Blue Swirl wrote: Please make separate patches for unrelated changes. Now the essence of the patch is very hard to see. Also pure formatting changes are not very useful. Is this just about page_get_flags, or was there some other pure formatting change to which you

Re: [Qemu-devel] [PATCH 1/6] Move TARGET_PHYS_ADDR_SPACE_BITS to target-*/cpu.h.

2010-02-12 Thread Richard Henderson
On 02/12/2010 12:01 PM, Blue Swirl wrote: +#ifdef TARGET_ABI32 +# define TARGET_VIRT_ADDR_SPACE_BITS 32 +#else +# define TARGET_VIRT_ADDR_SPACE_BITS 64 +#endif I'd suppose this change applies to all targets with ABI32, not just PPC. Indeed. Odd that sparc32plus didn't yield errors building,

Re: [Qemu-devel] [PATCH 3/6] Fix last page errors in page_set_flags and page_check_range.

2010-02-12 Thread Blue Swirl
On Fri, Feb 12, 2010 at 10:16 PM, Richard Henderson r...@twiddle.net wrote: On 02/12/2010 11:47 AM, Blue Swirl wrote: Please make separate patches for unrelated changes. Now the essence of the patch is very hard to see. Also pure formatting changes are not very useful. Is this just about

Re: [Qemu-devel] Re: Qemu does not pass pressed caps lock to client

2010-02-12 Thread Dustin Kirkland
On Fri, 2010-02-12 at 12:44 -0600, Anthony Liguori wrote: On 02/12/2010 12:17 PM, Paolo Bonzini wrote: On 02/12/2010 04:15 PM, Anthony Liguori wrote: So basically, Debian carries a hacked version of SDL that changes the key press behaviour? Yes, the patch was submitted to not change

[Qemu-devel] Re: [PATCH] Fix hanging user monitor when using balloon command

2010-02-12 Thread Anthony Liguori
On 02/12/2010 02:14 PM, Adam Litke wrote: Hi Anthony. I wonder if there was a problem when importing my async command handler patchset. Since the 'balloon' command completes immediately, it must call the completion callback before returning. That call was missing but is added by the patch

[Qemu-devel] [PATCH] Fix hanging user monitor when using balloon command

2010-02-12 Thread Adam Litke
Arghh... Adding missing S-O-B Hi Anthony. I wonder if there was a problem when importing my async command handler patchset. Since the 'balloon' command completes immediately, it must call the completion callback before returning. That call was missing but is added by the patch below.

[Qemu-devel] Re: QError conversion problems: putting errors in context

2010-02-12 Thread Anthony Liguori
Hi Markus, On 02/12/2010 11:48 AM, Markus Armbruster wrote: Our QError conversions were pretty straightforward so far. For example, when we found monitor_printf(mon, device is not removable\n); in eject_device(), we created the obvious QError class for it: #define

[Qemu-devel] Re: sparc32 fix spurious dma interrupts

2010-02-12 Thread Artyom Tarasenko
2010/2/12 Blue Swirl blauwir...@gmail.com: On Thu, Feb 11, 2010 at 12:40 AM, Artyom Tarasenko atar4q...@googlemail.com wrote: Don't raise interrupt when not enabled. Don't set DMA_INTR bit spuriously. Don't print misleading debug messages Raise IRQ when not raising any. This breaks most of

[Qemu-devel] Re: QError conversion problems: putting errors in context

2010-02-12 Thread Luiz Capitulino
On Fri, 12 Feb 2010 15:39:07 -0600 Anthony Liguori aligu...@linux.vnet.ibm.com wrote: Hi Markus, On 02/12/2010 11:48 AM, Markus Armbruster wrote: Our QError conversions were pretty straightforward so far. For example, when we found monitor_printf(mon, device is not

Re: [Qemu-devel] [PULL] qemu: pci fix

2010-02-12 Thread Blue Swirl
Thanks, pulled. On Tue, Feb 9, 2010 at 1:39 PM, Michael S. Tsirkin m...@redhat.com wrote: The following changes since commit e8105ebb94bf8c79c8ee8a66df5e8dfaabbfdbe1:  Paolo Bonzini (1):        vl.c: avoid preprocessor directives in a printf call are available in the git repository at:  

[Qemu-devel] Re: [PATCH 1/3] qemu-kvm: Wrap phys_ram_dirty with additional inline functions.

2010-02-12 Thread Avi Kivity
On 02/12/2010 04:08 AM, OHMURA Kei wrote: Why do you need a counter? It may be sufficient to set a single bit. This reduces the memory overhead and perhaps cache thrashing. Thanks for looking into this. I agree with your opinion. Our motivation here is to skip traveling when the dirty

[Qemu-devel] Re: sparc32 fix spurious dma interrupts

2010-02-12 Thread Blue Swirl
On Sat, Feb 13, 2010 at 12:32 AM, Artyom Tarasenko atar4q...@googlemail.com wrote: 2010/2/12 Blue Swirl blauwir...@gmail.com: On Thu, Feb 11, 2010 at 12:40 AM, Artyom Tarasenko atar4q...@googlemail.com wrote: Don't raise interrupt when not enabled. Don't set DMA_INTR bit spuriously. Don't