Re: [Qemu-devel] [PATCH 1/2] Detect and use GCC atomic builtins for locking

2010-02-20 Thread Loïc Minier
NB: Addition of these builtins was prompted by qemu failing to build on armel in Ubuntu; this is because we default to Thumb 2 mode which doesn't have the assembly instructions in question.

Re: [Qemu-devel] [PATCH 1/2] Detect and use GCC atomic builtins for locking

2010-02-20 Thread malc
On Sat, 20 Feb 2010, Lo?c Minier wrote: NB: Addition of these builtins was prompted by qemu failing to build on armel in Ubuntu; this is because we default to Thumb 2 mode which doesn't have the assembly instructions in question.

[Qemu-devel] [PATCH] terminal attributes is not restored when using /dev/tty monitor

2010-02-20 Thread Shahar Havivi
when exiting qemu that run with -monitor /dev/tty, the launching terminal get weird behaviour because no restore terminals action has taken. added chr_close and register atexit() code for tty devices (like stdio does) Signed-off-by: Shahar Havivi shah...@redhat.com --- qemu-char.c | 14

Re: [Qemu-devel] [PATCH] target-sparc: fix --enable-debug build

2010-02-20 Thread Blue Swirl
On 2/19/10, Jay Foad jay.f...@gmail.com wrote: On Linux/x86, configuring with --enable-debug, I get: CCsparc64-linux-user/translate.o /home/foad/git/qemu/target-sparc/translate.c: In function ‘gen_load_trap_state_at_tl’: /home/foad/git/qemu/target-sparc/translate.c:1684: error:

Re: [Qemu-devel] [PATCH] tcg: fix assertion with --enable-debug

2010-02-20 Thread Blue Swirl
On 2/19/10, Jay Foad jay.f...@gmail.com wrote: After configuring with --enable-debug on Linux/x86, I get: f...@foad-ubuntu:~/qemu/objdir-git$ qemu-alpha /dev/null qemu-alpha: /home/foad/git/qemu/tcg/tcg.c:1055: tcg_add_target_add_op_defs: Assertion `tcg_op_defs[op].used' failed. Aborted

Re: [Qemu-devel] [PATCH 1/2] Detect and use GCC atomic builtins for locking

2010-02-20 Thread Loïc Minier
On Sat, Feb 20, 2010, malc wrote: For instance this: http://sources.redhat.com/ml/libc-alpha/2005-06/msg00112.html The builtins are too coarse grained and will do more stuff than strictly necessary. Is this the case of the builtins I'm proposing to use? We could ask for new ones without

[Qemu-devel] Re: [PATCH 0/7] tcg-sparc improvements, v2

2010-02-20 Thread Blue Swirl
Thanks, applied all. On 2/19/10, Richard Henderson r...@twiddle.net wrote: Changes since v1: * Add comments for all optional instructions that aren't implemented on each architecture, as requested. * Rebase vs master. r~ Richard Henderson (7): tcg-sparc: Implement neg.

Re: [Qemu-devel] [PATCH] target-sparc: fix --enable-debug build

2010-02-20 Thread Jay Foad
Yes, except for the Signed-off-by: line. Do I need to resend it for that? And if so, does that make it PATCH v2 (even though the patch hasn't changed)? Or can I just put the fixed Signed-off-by: line in a reply? Thanks, Jay.

Re: [Qemu-devel] [PATCH] target-sparc: fix --enable-debug build

2010-02-20 Thread Blue Swirl
On 2/20/10, Jay Foad jay.f...@gmail.com wrote: Yes, except for the Signed-off-by: line. Do I need to resend it for that? And if so, does that make it PATCH v2 (even though the patch hasn't changed)? Or can I just put the fixed Signed-off-by: line in a reply? I'd suppose you'd also want

[Qemu-devel] [PATCH v2] tcg: fix assertion with --enable-debug

2010-02-20 Thread Jay Foad
On 32-bit hosts op_qemu_ld32s is unused. Remove it to fix the following assertion failure: qemu-alpha: tcg/tcg.c:1055: tcg_add_target_add_op_defs: Assertion `tcg_op_defs[op].used' failed. Signed-off-by: Jay Foad jay.f...@gmail.com --- tcg/tcg-opc.h |5 - 1 files changed, 0

Re: [Qemu-devel] [PATCH v2] tcg: fix assertion with --enable-debug

2010-02-20 Thread Blue Swirl
Thanks, applied. On 2/20/10, Jay Foad jay.f...@gmail.com wrote: On 32-bit hosts op_qemu_ld32s is unused. Remove it to fix the following assertion failure: qemu-alpha: tcg/tcg.c:1055: tcg_add_target_add_op_defs: Assertion `tcg_op_defs[op].used' failed. Signed-off-by: Jay Foad

[Qemu-devel] [PATCH v2] target-sparc: fix --enable-debug build

2010-02-20 Thread Jay Foad
Use 32-bit arithmetic for the address offset calculation to fix a build failure on 32-bit hosts. Signed-off-by: Jay Foad jay.f...@gmail.com --- target-sparc/translate.c | 22 +++--- 1 files changed, 11 insertions(+), 11 deletions(-) diff --git a/target-sparc/translate.c

Re: [Qemu-devel] [PATCH v2] target-sparc: fix --enable-debug build

2010-02-20 Thread Blue Swirl
Thanks, applied. On 2/20/10, Jay Foad jay.f...@gmail.com wrote: Use 32-bit arithmetic for the address offset calculation to fix a build failure on 32-bit hosts. Signed-off-by: Jay Foad jay.f...@gmail.com --- target-sparc/translate.c | 22 +++--- 1 files changed, 11

Re: [Qemu-devel] [PATCH] terminal attributes is not restored when using /dev/tty monitor

2010-02-20 Thread David S. Ahern
On 02/20/2010 01:30 AM, Shahar Havivi wrote: when exiting qemu that run with -monitor /dev/tty, the launching terminal get weird behaviour because no restore terminals action has taken. added chr_close and register atexit() code for tty devices (like stdio does) Signed-off-by: Shahar

[Qemu-devel] [PATCH] rewrote timer implementation for rtl8139.

2010-02-20 Thread Frediano Ziglio
Add a QEMU timer only when needed (timeout status not set, timeout irq wanted and timer set). This patch is required for Darwin. Patch has been tested under FreeBSD, Darwin and Linux. --- hw/rtl8139.c | 139 +++--- 1 files changed, 84

Re: [Qemu-devel] [PATCH] rewrote timer implementation for rtl8139.

2010-02-20 Thread Frediano Ziglio
2010/2/20 Igor Kovalenko igor.v.kovale...@gmail.com: On Sat, Feb 20, 2010 at 2:26 AM, Anthony Liguori anth...@codemonkey.ws wrote: On 02/19/2010 04:22 PM, Alexander Graf wrote: On 19.02.2010, at 22:50, Anthony Liguori wrote: On 02/16/2010 02:35 AM, Frediano Ziglio wrote: Add a QEMU

Re: [Qemu-devel] [PATCH] terminal attributes is not restored when using /dev/tty monitor

2010-02-20 Thread Shahar Havivi
On Sat, Feb 20, 2010 at 08:18:54AM -0700, David S. Ahern wrote: Date: Sat, 20 Feb 2010 08:18:54 -0700 From: David S. Ahern daah...@cisco.com To: Shahar Havivi shah...@redhat.com CC: qemu-devel@nongnu.org, Dor Laor dl...@redhat.com Subject: Re: [Qemu-devel] [PATCH] terminal attributes is not

Re: [Qemu-devel] Re: [PATCH 0/3] qcow2: Rewrite alloc_refcount_block

2010-02-20 Thread Anthony Liguori
On 02/19/2010 07:49 PM, Juan Quintela wrote: Anthony Liguorianth...@codemonkey.ws wrote: On 02/15/2010 10:19 AM, Kevin Wolf wrote: The current implementation of alloc_refcount_block and grow_refcount_table has fundamental problems regarding error handling. There are some places

Re: [Qemu-devel] [PATCH] terminal attributes is not restored when using /dev/tty monitor

2010-02-20 Thread Anthony Liguori
On 02/20/2010 09:18 AM, David S. Ahern wrote: On 02/20/2010 01:30 AM, Shahar Havivi wrote: when exiting qemu that run with -monitor /dev/tty, the launching terminal get weird behaviour because no restore terminals action has taken. added chr_close and register atexit() code for tty devices

Re: [Qemu-devel] [PATCH] rewrote timer implementation for rtl8139.

2010-02-20 Thread Anthony Liguori
On 02/20/2010 10:06 AM, Frediano Ziglio wrote: Add a QEMU timer only when needed (timeout status not set, timeout irq wanted and timer set). This patch is required for Darwin. Patch has been tested under FreeBSD, Darwin and Linux. This is missing a Signed-off-by. Regards, Anthony

[Qemu-devel] Fun with sparc (was Re: qemu-ppc can't run static uClibc binaries.)

2010-02-20 Thread Rob Landley
On Thursday 18 February 2010 05:21:16 Artyom Tarasenko wrote: 2010/2/17 Rob Landley r...@landley.net: But it does imply that qemu is capable of decently running _something_ on sparc, so the problems I'm seeing are more likely to be uClibc or toolchain issues. qemu-sparc can decently run

[Qemu-devel] [PATCH] rewrote timer implementation for rtl8139.

2010-02-20 Thread Frediano Ziglio
Add a QEMU timer only when needed (timeout status not set, timeout irq wanted and timer set). This patch is required for Darwin. Patch has been tested under FreeBSD, Darwin and Linux. --- hw/rtl8139.c | 139 +++--- 1 files changed, 84

[Qemu-devel] Re: Fun with sparc (was Re: qemu-ppc can't run static uClibc binaries.)

2010-02-20 Thread Blue Swirl
On 2/20/10, Rob Landley r...@landley.net wrote: On Thursday 18 February 2010 05:21:16 Artyom Tarasenko wrote: 2010/2/17 Rob Landley r...@landley.net: But it does imply that qemu is capable of decently running _something_ on sparc, so the problems I'm seeing are more likely to be uClibc

[Qemu-devel] [PATCH] rewrote timer implementation for rtl8139.

2010-02-20 Thread Frediano Ziglio
Add a QEMU timer only when needed (timeout status not set, timeout irq wanted and timer set). This patch is required for Darwin. Patch has been tested under FreeBSD, Darwin and Linux. Signed-off-by: Frediano Ziglio fredd...@gmail.com --- hw/rtl8139.c | 139

Re: [Qemu-devel] [PATCH 1/2] Detect and use GCC atomic builtins for locking

2010-02-20 Thread malc
On Sat, 20 Feb 2010, Lo?c Minier wrote: On Sat, Feb 20, 2010, malc wrote: For instance this: http://sources.redhat.com/ml/libc-alpha/2005-06/msg00112.html The builtins are too coarse grained and will do more stuff than strictly necessary. Is this the case of the builtins I'm

[Qemu-devel] [PATCH] target-mips: fix CpU exception for coprocessor 0

2010-02-20 Thread Nathan Froyd
When we signal a CpU exception for coprocessor 0, we should indicate that it's for coprocessor 0 instead of coprocessor 1. Signed-off-by: Nathan Froyd froy...@codesourcery.com --- target-mips/translate.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[Qemu-devel] [PATCH] target-mips: fix ROTR and DROTR by zero

2010-02-20 Thread Nathan Froyd
Signed-off-by: Nathan Froyd froy...@codesourcery.com --- target-mips/translate.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/target-mips/translate.c b/target-mips/translate.c index dfea6f6..de5ac18 100644 --- a/target-mips/translate.c +++ b/target-mips/translate.c

[Qemu-devel] Re: Fun with sparc (was Re: qemu-ppc can't run static uClibc binaries.)

2010-02-20 Thread Rob Landley
On Saturday 20 February 2010 11:34:44 Blue Swirl wrote: On 2/20/10, Rob Landley r...@landley.net wrote: I don't understand what's going wrong here. Did the kernel break on sparc sometime between 2.6.18 and 2.6.32 and nobody noticed? Is sparc using software emulated floating point at the

Re: [Qemu-devel] [PATCH] terminal attributes is not restored when using /dev/tty monitor

2010-02-20 Thread Shahar Havivi
On Sat, Feb 20, 2010 at 11:03:41AM -0600, Anthony Liguori wrote: Date: Sat, 20 Feb 2010 11:03:41 -0600 From: Anthony Liguori anth...@codemonkey.ws To: David S. Ahern daah...@cisco.com Cc: Dor Laor dl...@redhat.com, Shahar Havivi shah...@redhat.com, qemu-devel@nongnu.org Subject: Re:

[Qemu-devel] [PATCH 1/3] tcg-hppa: Fix const errors in hppa-dis.c.

2010-02-20 Thread Richard Henderson
--- hppa-dis.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hppa-dis.c b/hppa-dis.c index 9d96d72..49f99c8 100644 --- a/hppa-dis.c +++ b/hppa-dis.c @@ -576,7 +576,7 @@ struct pa_opcode const char *name; unsigned long int match; /* Bits that must be

[Qemu-devel] [PATCH 2/3] tcg-hppa: Fix 64-bit argument ordering.

2010-02-20 Thread Richard Henderson
--- tcg/tcg.c | 12 +++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index e6a1caf..32345cc 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -596,7 +596,17 @@ void tcg_gen_callN(TCGContext *s, TCGv_ptr func, unsigned int flags,

[Qemu-devel] [PATCH 0/3] Get tcg-hppa working

2010-02-20 Thread Richard Henderson
Tested on debian/parisc (pa8600, 32-bit), and is good enough to run the linux-user-test-0.3 binaries for arm, armeb, i386, mips, mipsel, sh4, and sh4eb. It still fails for ppc and sparc userland; that'll take more debugging. I had a go at sparc-test-0.2, since that's the only one that reliably

Re: [Qemu-devel] [PATCH 0/3] Get tcg-hppa working

2010-02-20 Thread Stuart Brady
On Sat, Feb 20, 2010 at 11:47:52AM -0800, Richard Henderson wrote: Tested on debian/parisc (pa8600, 32-bit), and is good enough to run the linux-user-test-0.3 binaries for arm, armeb, i386, mips, mipsel, sh4, and sh4eb. It still fails for ppc and sparc userland; that'll take more debugging.

[Qemu-devel] Re: Fun with sparc (was Re: qemu-ppc can't run static uClibc binaries.)

2010-02-20 Thread Artyom Tarasenko
2010/2/20 Blue Swirl blauwir...@gmail.com: On 2/20/10, Rob Landley r...@landley.net wrote: On Thursday 18 February 2010 05:21:16 Artyom Tarasenko wrote:   2010/2/17 Rob Landley r...@landley.net:   But it does imply that qemu is capable of decently running _something_ on   sparc, so the

Re: [Qemu-devel] [PATCH 0/3] Get tcg-hppa working

2010-02-20 Thread malc
On Sat, 20 Feb 2010, Stuart Brady wrote: On Sat, Feb 20, 2010 at 11:47:52AM -0800, Richard Henderson wrote: Tested on debian/parisc (pa8600, 32-bit), and is good enough to run the linux-user-test-0.3 binaries for arm, armeb, i386, mips, mipsel, sh4, and sh4eb. It still fails for ppc and

[Qemu-devel] Re: Fun with sparc (was Re: qemu-ppc can't run static uClibc binaries.)

2010-02-20 Thread Blue Swirl
On 2/20/10, Rob Landley r...@landley.net wrote: On Saturday 20 February 2010 11:34:44 Blue Swirl wrote: On 2/20/10, Rob Landley r...@landley.net wrote: I don't understand what's going wrong here. Did the kernel break on sparc sometime between 2.6.18 and 2.6.32 and nobody noticed? Is

[Qemu-devel] Re: Fun with sparc (was Re: qemu-ppc can't run static uClibc binaries.)

2010-02-20 Thread Artyom Tarasenko
2010/2/20 Rob Landley r...@landley.net: On Saturday 20 February 2010 11:34:44 Blue Swirl wrote: On 2/20/10, Rob Landley r...@landley.net wrote:  I don't understand what's going wrong here.  Did the kernel break on sparc sometime between 2.6.18 and 2.6.32 and nobody noticed?  Is sparc using

[Qemu-devel] Re: Fun with sparc (was Re: qemu-ppc can't run static uClibc binaries.)

2010-02-20 Thread Blue Swirl
On 2/20/10, Artyom Tarasenko atar4q...@googlemail.com wrote: 2010/2/20 Blue Swirl blauwir...@gmail.com: On 2/20/10, Rob Landley r...@landley.net wrote: On Thursday 18 February 2010 05:21:16 Artyom Tarasenko wrote: 2010/2/17 Rob Landley r...@landley.net: But it does imply that

Re: [Qemu-devel] [PATCH 0/3] Get tcg-hppa working

2010-02-20 Thread Stuart Brady
On Sun, Feb 21, 2010 at 12:54:46AM +0300, malc wrote: On Sat, 20 Feb 2010, Stuart Brady wrote: The qemu_ld / qemu_st cleanup strikes me as something that would be appropriate for some other TCG targets too, once this has been applied. Care to point out what this cleanup is, my HPPA-fu is

Re: [Qemu-devel] [PATCH 0/3] Get tcg-hppa working

2010-02-20 Thread Richard Henderson
On 02/20/2010 01:54 PM, malc wrote: The qemu_ld / qemu_st cleanup strikes me as something that would be appropriate for some other TCG targets too, once this has been applied. Care to point out what this cleanup is, my HPPA-fu is around zero. Split out a tlb_read function from

Re: [Qemu-devel] [PATCH 0/3] Get tcg-hppa working

2010-02-20 Thread malc
On Sat, 20 Feb 2010, Richard Henderson wrote: On 02/20/2010 01:54 PM, malc wrote: The qemu_ld / qemu_st cleanup strikes me as something that would be appropriate for some other TCG targets too, once this has been applied. Care to point out what this cleanup is, my HPPA-fu is around

Re: [Qemu-devel] [PATCH 0/3] Get tcg-hppa working

2010-02-20 Thread malc
On Sat, 20 Feb 2010, Stuart Brady wrote: On Sun, Feb 21, 2010 at 12:54:46AM +0300, malc wrote: On Sat, 20 Feb 2010, Stuart Brady wrote: The qemu_ld / qemu_st cleanup strikes me as something that would be appropriate for some other TCG targets too, once this has been applied. Care

Re: [Qemu-devel] [PATCH 0/3] Get tcg-hppa working

2010-02-20 Thread Richard Henderson
On 02/20/2010 02:22 PM, malc wrote: Ah, so i already half did it, good to know. I stole several good ideas from the ppc64 port. ;-) That one and using indexed loads to handle GUEST_BASE. r~

[Qemu-devel] Re: Fun with sparc (was Re: qemu-ppc can't run static uClibc binaries.)

2010-02-20 Thread Rob Landley
On Saturday 20 February 2010 15:59:31 Blue Swirl wrote: I've got 2.6.32 booting to a command prompt (albeit with serial console and intentionall restricted set of hardware). But then it misbehaves. I'll try getting 2.6.18 to build with a known .config, and then bisect forward if that

[Qemu-devel] SeaBIOS error with Juniper FreeBSD kernel

2010-02-20 Thread Brandon Bennett
When booting a Juniper JunOS kernel (FreeBSD based) I am getting a panic: unkown/reserved trap error immediately after the kernel loads. If i use an older pc-bios with the '-bios' option everything works so it seems to be an issue with the SeaBios. With #DEBUG_BIOS enabled in hw/pc.c here is what

Re: [Qemu-devel] SeaBIOS error with Juniper FreeBSD kernel

2010-02-20 Thread Kevin O'Connor
On Sat, Feb 20, 2010 at 05:23:59PM -0700, Brandon Bennett wrote: When booting a Juniper JunOS kernel (FreeBSD based) I am getting a panic: unkown/reserved trap error immediately after the kernel loads. If i use an older pc-bios with the '-bios' option everything works so it seems to be an