[Qemu-devel] Re: [PATCH] qemu-img rebase: Add -f option

2010-03-03 Thread Juan Quintela
Kevin Wolf kw...@redhat.com wrote: Allow the user to specify the format of the image to rebase. Signed-off-by: Kevin Wolf kw...@redhat.com Acked-by: Juan Quintela quint...@redhat.com This is needed to use rebase with qcow2 images on block devices.

Re: [Qemu-devel] [PATCH] qemu-img: Fix error Unknown option 'size' when using host_device format

2010-03-03 Thread Kevin Wolf
Am 02.03.2010 19:52, schrieb Bitti: qemu-kvm-0.11.0 When I run: sudo qemu-img convert ubuntu-kvm/disk0.qcow2 -O host_device /dev/vg01/vm_test I get this: Unknown option 'size' Ubuntu Bug: https://bugs.launchpad.net/ubuntu/+source/qemu-kvm/+bug/460542 Signed-off-by: Bitti

[Qemu-devel] Re: [PATCHv3 17/20] eepro100: New function for reading command block

2010-03-03 Thread Michael S. Tsirkin
On Tue, Mar 02, 2010 at 10:37:57PM +0100, Stefan Weil wrote: Move code which reads the command block to the new function read_cb. The patch also fixes some endianess issues related to the command block and moves declarations of local variables to the beginning of the block. Signed-off-by:

[Qemu-devel] Re: [PATCHv3 19/20] eepro100: Remove C++ comments

2010-03-03 Thread Michael S. Tsirkin
On Tue, Mar 02, 2010 at 10:37:59PM +0100, Stefan Weil wrote: C++ comments are unwanted, so this is fixed here. * Replace C++ comments by C comments. * Put code which was deactivated by a C++ comment in #if 0...#endif. Signed-off-by: Stefan Weil w...@mail.berlios.de It would be nice to

[Qemu-devel] Re: [PATCHv3 08/20] eepro100: Add device descriptions

2010-03-03 Thread Michael S. Tsirkin
On Tue, Mar 02, 2010 at 10:37:48PM +0100, Stefan Weil wrote: Add descriptions for all devices. These descriptions are shown when users call qemu -device ? Signed-off-by: Stefan Weil w...@mail.berlios.de I still think descriptive names should also mention eepro100. ---

[Qemu-devel] Re: [PATCH 05/20] eepro100: Add all supported devices to pci.c

2010-03-03 Thread Michael S. Tsirkin
On Sun, Feb 21, 2010 at 10:08:49PM +0100, Stefan Weil wrote: Michael S. Tsirkin schrieb: On Sun, Feb 14, 2010 at 05:16:14PM +0100, Stefan Weil wrote: All eepro100 devices work with drivers which only use basic features. They were tested with gpxe boot. Signed-off-by: Stefan

[Qemu-devel] Re: [PATCHv3 01/20] eepro100: Fix compiler errors from debug messages

2010-03-03 Thread Michael S. Tsirkin
Applied the series except patch 5. Thanks! -- MST

[Qemu-devel] [PATCH] eepro100: address pci todo's, use pci_set_xx

2010-03-03 Thread Michael S. Tsirkin
eepro100 uses macros which rely on a specific local variable name (pci_conf) which is scary. Some of the uses are wrong or unnecessary, remove them. The rest are small in number, open-code them using pci_set_xx functions. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- The following is

[Qemu-devel] [PATCH 00/10] FORTIFY_SOURCE followup

2010-03-03 Thread Juan Quintela
Hi This series make: - all block *_create() functions return -errno instead of -1 - this makes that we can end writting errno/error at bdrv_create() callers (qemu-img) - once there found a double free problem in the error handling of vmdk, fixed it. - slirp: also check that system() was able

[Qemu-devel] [PATCH 01/10] cow: return errno instead of -1

2010-03-03 Thread Juan Quintela
Remove not needed ret = 0 assignment. Signed-off-by: Juan Quintela quint...@redhat.com --- block/cow.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/block/cow.c b/block/cow.c index 3733385..97e9745 100644 --- a/block/cow.c +++ b/block/cow.c @@ -224,7 +224,7 @@

[Qemu-devel] [PATCH 02/10] slirp: check system() success

2010-03-03 Thread Juan Quintela
we shouldn't call W*() macros until we check that fork worked. Signed-off-by: Juan Quintela quint...@redhat.com --- net/slirp.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/slirp.c b/net/slirp.c index 317cca7..7f846ec 100644 --- a/net/slirp.c +++ b/net/slirp.c @@

[Qemu-devel] [PATCH 03/10] qcow2: return errno instead of -1

2010-03-03 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- block/qcow2.c | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index bf8170e..5b6dad9 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -851,7 +851,7 @@ static int

[Qemu-devel] [PATCH 04/10] qcow: return errno instead of -1

2010-03-03 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- block/qcow.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/block/qcow.c b/block/qcow.c index 003db1e..c619984 100644 --- a/block/qcow.c +++ b/block/qcow.c @@ -766,7 +766,7 @@ static int qcow_create(const char

[Qemu-devel] [PATCH 05/10] vmdk: return errno instead of -1

2010-03-03 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- block/vmdk.c | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 56c28a0..5b1d197 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -740,7 +740,7 @@ static int vmdk_create(const

[Qemu-devel] [PATCH 06/10] vl: exit if we are not able to write into the pipe

2010-03-03 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- vl.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/vl.c b/vl.c index db7a178..119c7e4 100644 --- a/vl.c +++ b/vl.c @@ -5745,6 +5745,7 @@ int main(int argc, char **argv, char **envp) uint8_t status = 1;

[Qemu-devel] [PATCH 07/10] vmdk: make vmdk_snapshot_create return -errno

2010-03-03 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- block/vmdk.c | 79 ++--- 1 files changed, 58 insertions(+), 21 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 5b1d197..67a690e 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@

[Qemu-devel] [PATCH 08/10] vmdk: fix double free

2010-03-03 Thread Juan Quintela
fail_gd error case would also free rgd_buf that was already freed Signed-off-by: Juan Quintela quint...@redhat.com --- block/vmdk.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 67a690e..819c1c9 100644 --- a/block/vmdk.c +++

[Qemu-devel] [PATCH 09/10] vmdk: share cleanup code

2010-03-03 Thread Juan Quintela
cleanup code is identical for error/success cases. Only difference are goto labels. Signed-off-by: Juan Quintela quint...@redhat.com --- block/vmdk.c | 13 - 1 files changed, 4 insertions(+), 9 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 819c1c9..007fca4 100644

[Qemu-devel] [PATCH 10/10] block: print errno on error

2010-03-03 Thread Juan Quintela
Now that we changed all create calls to return errno, just print it. Signed-off-by: Juan Quintela quint...@redhat.com --- qemu-img.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 0c9f2d4..f6c40fb 100644 --- a/qemu-img.c +++ b/qemu-img.c

[Qemu-devel] [PULL] eepro100

2010-03-03 Thread Michael S. Tsirkin
The following changes since commit 55b1e61f640bb2cf3bed0b4cc6d4ba1326c625d9: Samuel Thibault (1): (curses) Use more descriptive values are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/qemu.git for_anthony Stefan Weil (19): eepro100: Fix

Re: [Qemu-devel] [PATCH 3/4] Fix signal handling for ColdFire

2010-03-03 Thread Richard Henderson
+float64sc_fpregs[2]; /* room for two fp registers */ ... -int f_fpcntl[3]; -int f_fpregs[8*3]; +uint32_t f_fpcntl[3]; +float64f_fpregs[8]; Surely these float64 uses are incorrect. The kernel uses 3*int at both of these places, which matches up with the 96-bit

[Qemu-devel] Re: [PATCH 05/20] eepro100: Add all supported devices to pci.c

2010-03-03 Thread Gerd Hoffmann
On 03/03/10 12:51, Michael S. Tsirkin wrote: On Sun, Feb 21, 2010 at 10:08:49PM +0100, Stefan Weil wrote: static const char * const pci_nic_models[] = { ne2k_pci, +i82550, i82551, +i82557a, i82557b, +i82557c, +i82558a, +i82558b, +i82559a, +

Re: [Qemu-devel] [PATCH 3/4] Fix signal handling for ColdFire

2010-03-03 Thread Maxim Kuvyrkov
On 3/3/10 4:17 PM, Richard Henderson wrote: + float64 sc_fpregs[2]; /* room for two fp registers */ ... - int f_fpcntl[3]; - int f_fpregs[8*3]; + uint32_t f_fpcntl[3]; + float64 f_fpregs[8]; Surely these float64 uses are incorrect. The kernel uses 3*int at both of these places, which

[Qemu-devel] Re: [PATCH 05/20] eepro100: Add all supported devices to pci.c

2010-03-03 Thread Michael S. Tsirkin
On Wed, Mar 03, 2010 at 02:31:53PM +0100, Gerd Hoffmann wrote: On 03/03/10 12:51, Michael S. Tsirkin wrote: On Sun, Feb 21, 2010 at 10:08:49PM +0100, Stefan Weil wrote: static const char * const pci_nic_models[] = { ne2k_pci, +i82550, i82551, +i82557a, i82557b,

[Qemu-devel] Re: [PATCH 06/10] vl: exit if we are not able to write into the pipe

2010-03-03 Thread Kevin Wolf
Am 03.03.2010 13:06, schrieb Juan Quintela: Signed-off-by: Juan Quintela quint...@redhat.com --- vl.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/vl.c b/vl.c index db7a178..119c7e4 100644 --- a/vl.c +++ b/vl.c @@ -5745,6 +5745,7 @@ int main(int argc, char

[Qemu-devel] Re: [PATCH 06/10] vl: exit if we are not able to write into the pipe

2010-03-03 Thread Juan Quintela
Kevin Wolf kw...@redhat.com wrote: Am 03.03.2010 13:06, schrieb Juan Quintela: Signed-off-by: Juan Quintela quint...@redhat.com --- vl.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/vl.c b/vl.c index db7a178..119c7e4 100644 --- a/vl.c +++ b/vl.c @@ -5745,6

[Qemu-devel] Re: [PATCH 10/10] block: print errno on error

2010-03-03 Thread Kevin Wolf
Am 03.03.2010 13:07, schrieb Juan Quintela: Now that we changed all create calls to return errno, just print it. Signed-off-by: Juan Quintela quint...@redhat.com --- qemu-img.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index

Re: [Qemu-devel] Re: [PATCHv2 10/12] tap: add vhost/vhostfd options

2010-03-03 Thread Anthony Liguori
On 03/02/2010 04:41 PM, Paul Brook wrote: The new function I'm proposing has the following semantics: - it always returns a persistent mapping - it never bounces - it will only fail if the mapping isn't ram So you're assuming that virtio rings are in ram that is not hot-pluggable As

[Qemu-devel] Re: Another VNC crash, qemu-kvm-0.12.3

2010-03-03 Thread Anthony Liguori
On 03/01/2010 12:14 PM, Chris Webb wrote: We've just seen another VNC related qemu-kvm crash, this time an arithmetic exception at vnc.c:1424 in the newly release qemu-kvm 0.12.3. [...] 1423 if (vs-absolute) { 1424 kbd_mouse_event(x * 0x7FFF / (ds_get_width(vs-ds) - 1),

[Qemu-devel] [PATCH] qemu-kvm: avoid strlen of NULL pointer

2010-03-03 Thread Jens Osterkamp
If the user wants to create a chardev of type socket but forgets to give a host= option, qemu_opt_get returns NULL. This NULL pointer is then fed into strlen a few lines below without a check which results in a segfault. This fixes it. Signed-off-by: Jens Osterkamp j...@linux.vnet.ibm.com ---

[Qemu-devel] Re: [PATCH 10/10] block: print errno on error

2010-03-03 Thread Paolo Bonzini
diff --git a/qemu-img.c b/qemu-img.c index 0c9f2d4..f6c40fb 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -374,7 +374,7 @@ static int img_create(int argc, char **argv) } else if (ret == -EFBIG) { error(The image size is too large for file format '%s', fmt); }

Re: [Qemu-devel] Re: [PATCHv2 10/12] tap: add vhost/vhostfd options

2010-03-03 Thread Paul Brook
That sounds like it's likely to come back and bite you. The guest has no idea which areas of ram happen to be contiguous on the host. Practically speaking, with target-i386 anything that is contiguous in guest physical memory is contiguous in the host address space provided it's ram.

[Qemu-devel] [PATCH] Build usb-ohci for PCs

2010-03-03 Thread Kevin Wolf
The OHCI emulation isn't obviously broken and there are people who want to use it. Let's build it by default so that it can be enabled via -device. Signed-off-by: Kevin Wolf kw...@redhat.com --- default-configs/i386-softmmu.mak |2 ++ default-configs/x86_64-softmmu.mak |2 ++ 2 files

[Qemu-devel] [PATCH] qemu-nbd: Fix wrong description in qemu-nbd.texi

2010-03-03 Thread Ryota Ozaki
-c option needs argument dev but it's missing now. This patch fixes it. Signed-off-by: Ryota Ozaki ozaki.ry...@gmail.com --- qemu-nbd.texi |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-nbd.texi b/qemu-nbd.texi index ef13b34..44996cc 100644 --- a/qemu-nbd.texi

[Qemu-devel] Re: [PATCH v4 03/10] x86: Extend validity of cpu_is_bsp

2010-03-03 Thread Gleb Natapov
On Mon, Mar 01, 2010 at 06:17:22PM +0100, Jan Kiszka wrote: As we hard-wire the BSP to CPU 0 anyway and cpuid_apic_id equals cpu_index, cpu_is_bsp can also be based on the latter directly. This will help an early user of it: KVM while initializing mp_state. Signed-off-by: Jan Kiszka

[Qemu-devel] Re: [PATCH 10/10] block: print errno on error

2010-03-03 Thread Juan Quintela
Paolo Bonzini pbonz...@redhat.com wrote: diff --git a/qemu-img.c b/qemu-img.c index 0c9f2d4..f6c40fb 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -374,7 +374,7 @@ static int img_create(int argc, char **argv) } else if (ret == -EFBIG) { error(The image size is too

Re: [Qemu-devel] Re: [PATCHv2 10/12] tap: add vhost/vhostfd options

2010-03-03 Thread Marcelo Tosatti
On Wed, Mar 03, 2010 at 08:15:15AM -0600, Anthony Liguori wrote: On 03/02/2010 04:41 PM, Paul Brook wrote: The new function I'm proposing has the following semantics: - it always returns a persistent mapping - it never bounces - it will only fail if the mapping isn't ram So you're assuming

[Qemu-devel] [PATCHv4 00/12] vhost-net: upstream integration

2010-03-03 Thread Michael S. Tsirkin
Here's a patchset with vhost support for upstream qemu, rebased to latest bits, and with all comments I'm aware of addressed. Please consider for merging. Anthony, if you are still deliberating some issues, maybe the series can be merged partially? This will at least reduce the amount of noise

[Qemu-devel] [PATCHv4 01/12] tap: add interface to get device fd

2010-03-03 Thread Michael S. Tsirkin
Will be used by vhost to attach/detach to backend. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- net/tap.c |7 +++ net/tap.h |2 ++ 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/net/tap.c b/net/tap.c index 7a7320c..fc59fd4 100644 --- a/net/tap.c +++

[Qemu-devel] [PATCHv4 02/12] kvm: add API to set ioeventfd

2010-03-03 Thread Michael S. Tsirkin
Comment on kvm usage: rather than require users to do if (kvm_enabled()) and/or ifdefs, this patch adds an API that, internally, is defined to stub function on non-kvm build, and checks kvm_enabled for non-kvm run. While rest of qemu code still uses if (kvm_enabled()), I think this approach is

[Qemu-devel] [PATCHv4 04/12] virtio: add notifier support

2010-03-03 Thread Michael S. Tsirkin
Add binding API to set host/guest notifiers. Will be used by vhost. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/virtio.c |5 - hw/virtio.h |3 +++ 2 files changed, 7 insertions(+), 1 deletions(-) diff --git a/hw/virtio.c b/hw/virtio.c index 7c020a3..1f5e7be 100644 ---

[Qemu-devel] [PATCHv4 05/12] virtio: add APIs for queue fields

2010-03-03 Thread Michael S. Tsirkin
vhost needs physical addresses for ring and other queue fields, so add APIs for these. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/virtio.c | 76 +++ hw/virtio.h | 15 +++- 2 files changed, 90 insertions(+), 1

[Qemu-devel] [PATCHv4 03/12] notifier: event notifier implementation

2010-03-03 Thread Michael S. Tsirkin
event notifiers are slightly generalized eventfd descriptors. Current implementation depends on eventfd because vhost is the only user, and vhost depends on eventfd anyway, but a stub is provided for non-eventfd case. We'll be able to further generalize this when another user comes along and we

[Qemu-devel] [PATCHv4 06/12] virtio: add set_status callback

2010-03-03 Thread Michael S. Tsirkin
vhost net backend needs to be notified when frontend status changes. Add a callback, similar to set_features. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/s390-virtio-bus.c |2 +- hw/syborg_virtio.c |2 +- hw/virtio-pci.c |5 +++-- hw/virtio.h |9

[Qemu-devel] [PATCHv4 07/12] virtio: move typedef to qemu-common

2010-03-03 Thread Michael S. Tsirkin
make it possible to use type without header include Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/virtio.h |1 - qemu-common.h |1 + 2 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/virtio.h b/hw/virtio.h index 58b06bf..6f2fab0 100644 --- a/hw/virtio.h +++

[Qemu-devel] [PATCHv4 08/12] virtio-pci: fill in notifier support

2010-03-03 Thread Michael S. Tsirkin
Support host/guest notifiers in virtio-pci. The last one only with kvm, that's okay because vhost relies on kvm anyway. Note on kvm usage: kvm ioeventfd API is implemented on non-kvm systems as well, this is the reason we don't need if (kvm_enabled()) around it. Signed-off-by: Michael S. Tsirkin

[Qemu-devel] [PATCHv4 09/12] vhost: vhost net support

2010-03-03 Thread Michael S. Tsirkin
This adds vhost net device support in qemu. Will be tied to tap device and virtio by following patches. Raw backend is currently missing, will be worked on/submitted separately. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- Makefile.target |2 + configure | 36 +++

[Qemu-devel] [PATCHv4 10/12] tap: add vhost/vhostfd options

2010-03-03 Thread Michael S. Tsirkin
This adds vhost binary option to tap, to enable vhost net accelerator. Default is off for now, we'll be able to make default on long term when we know it's stable. vhostfd option can be used by management, to pass in the fd. Assigning vhostfd implies vhost=on. Signed-off-by: Michael S. Tsirkin

[Qemu-devel] [PATCHv4 11/12] tap: add API to retrieve vhost net header

2010-03-03 Thread Michael S. Tsirkin
will be used by virtio-net for vhost net support Signed-off-by: Michael S. Tsirkin m...@redhat.com --- net/tap.c |7 +++ net/tap.h |3 +++ 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/net/tap.c b/net/tap.c index 19c4fa2..35c05d7 100644 --- a/net/tap.c +++

[Qemu-devel] [PATCHv4 12/12] virtio-net: vhost net support

2010-03-03 Thread Michael S. Tsirkin
This connects virtio-net to vhost net backend. The code is structured in a way analogous to what we have with vnet header capability in tap. We start/stop backend on driver start/stop as well as on save and vm start (for migration). Signed-off-by: Michael S. Tsirkin m...@redhat.com ---

Re: [Qemu-devel] Possible invalid emulation of rex.W-prefixed far jump

2010-03-03 Thread malc
3On Mon, 1 Mar 2010, Brad Spengler wrote: Hi all, I'm writing to report a possible bug in the qemu emulation of rex.W-prefixed far jumps. It affects far jumps of this type with both rip-relative and absolute addresses. Looks like it's a bug indeed, here's a test case: .data

[Qemu-devel] Re: [PATCH] configure: Fix wrong stderr redirection

2010-03-03 Thread Juan Quintela
Stefan Weil w...@mail.berlios.de wrote: Signed-off-by: Stefan Weil w...@mail.berlios.de Ouch. good catch. Acked-by: Juan Quintela quint...@redhat.com --- configure |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index dfe3e42..a14aba7

[Qemu-devel] Re: [PATCH 05/20] eepro100: Add all supported devices to pci.c

2010-03-03 Thread Stefan Weil
Michael S. Tsirkin schrieb: On Wed, Mar 03, 2010 at 02:31:53PM +0100, Gerd Hoffmann wrote: On 03/03/10 12:51, Michael S. Tsirkin wrote: On Sun, Feb 21, 2010 at 10:08:49PM +0100, Stefan Weil wrote: static const char * const pci_nic_models[] = { ne2k_pci, + i82550, i82551, + i82557a,

[Qemu-devel] [PATCH 10/17] virtio-9p: Implement P9_TCREATE

2010-03-03 Thread Anthony Liguori
Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Gautham R Shenoy e...@in.ibm.com Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- hw/virtio-9p-local.c | 80 +++ hw/virtio-9p.c | 267 +- 2

[Qemu-devel] [PATCH 04/17] virtio-9p: Implement P9_TSTAT

2010-03-03 Thread Anthony Liguori
This get the mount to work on the guest [ki...@linux.vnet.ibm.com: malloc to qemu_malloc conversion] Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Gautham R Shenoy e...@in.ibm.com Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- hw/virtio-9p-local.c |7

[Qemu-devel] [PATCH 02/17] vrtio-9p: Implement P9_TVERSION for 9P

2010-03-03 Thread Anthony Liguori
[ki...@linux.vnet.ibm.com: malloc to qemu_malloc coversion] Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- hw/virtio-9p.c | 263 +++- 1 files changed, 262 insertions(+), 1

[Qemu-devel] [PATCH 08/17] virtio-9p: Implement P9_TCLUNK

2010-03-03 Thread Anthony Liguori
This patch gets ls -al to work Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- hw/virtio-9p.c | 16 ++-- 1 files changed, 14 insertions(+), 2 deletions(-) diff --git a/hw/virtio-9p.c b/hw/virtio-9p.c index

[Qemu-devel] [PATCH 01/17] vitio-9p: Add a virtio 9p device to qemu

2010-03-03 Thread Anthony Liguori
This patch doesn't implement the 9p protocol handling code. It add a simple device which dump the protocl data Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- Makefile.target |1 + hw/virtio-9p-debug.c | 442

[Qemu-devel] [PATCH 06/17] virtio-9p: Implement P9_TOPEN

2010-03-03 Thread Anthony Liguori
Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Gautham R Shenoy e...@in.ibm.com Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- hw/virtio-9p-local.c | 12 hw/virtio-9p.c | 141 -- 2 files changed,

[Qemu-devel] [PATCH 05/17] virtio-9p: Implement P9_TWALK

2010-03-03 Thread Anthony Liguori
Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Gautham R Shenoy e...@in.ibm.com Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- hw/virtio-9p-local.c | 12 +++ hw/virtio-9p.c | 219 +- 2 files changed,

[Qemu-devel] [PATCH 00/17][RFC] virtio-9p: paravirtual filesystem passthrough

2010-03-03 Thread Anthony Liguori
This patch series adds a paravirtual file system passthrough mechanism to QEMU based on the 9P protocol. This an RFC series with a few known issues. Right now, all I/O is implemented in the VCPU thread. We've modified the protocol handlers so that we can support dispatch I/O in a thread pool

[Qemu-devel] [PATCH 03/17] virtio-9p: Implement P9_TATTACH

2010-03-03 Thread Anthony Liguori
Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- Makefile.target |2 +- hw/virtio-9p-local.c | 84 +++ hw/virtio-9p.c | 155 +++---

[Qemu-devel] [PATCH 16/17] virtio-9p: Add support for hardlink

2010-03-03 Thread Anthony Liguori
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com link count for files and directories are encoded as a tagged string in the extension field for a .u protocol extension. Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- hw/virtio-9p.c |3 +++ 1 files changed, 3

[Qemu-devel] [PATCH 07/17] virtio-9p: Implement P9_TREAD

2010-03-03 Thread Anthony Liguori
Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Venkateswararao Jujjuri jv...@linux.vnet.ibm.com Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- hw/virtio-9p-local.c | 37 hw/virtio-9p.c | 253

[Qemu-devel] [PATCH 17/17] Implement sync support in 9p server

2010-03-03 Thread Anthony Liguori
From: M. Mohan Kumar mo...@in.ibm.com When wstat is called with stat field values set to 'don't touch' pattern, 9p Server interprets it as a request to guarantee that the contents of the associated file are committed to stable storage before the Rwstat message is returned. Implement this feature

[Qemu-devel] [PATCH 14/17] virtio-9p: Add multiple mount point support

2010-03-03 Thread Anthony Liguori
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com This patch add a mount tag name in 9p config space. This tag should uniquely identify the mount point and should be used in the mount command as the device name Qemu command line for specifying 9p share directory now becomes -device

[Qemu-devel] [PATCH 11/17] virtio-9p: Implement P9_TWSTAT

2010-03-03 Thread Anthony Liguori
This gets file and directory creation to work Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Gautham R Shenoy e...@in.ibm.com Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- hw/virtio-9p-local.c | 42 + hw/virtio-9p.c | 236

[Qemu-devel] [PATCH 00/17][RFC] virtio-9p: paravirtual filesystem passthrough

2010-03-03 Thread Anthony Liguori
This is a refresh of an older series

[Qemu-devel] [PATCH 13/17] virtio-9p: Implement P9_TFLUSH

2010-03-03 Thread Anthony Liguori
Don't do anything special for flush Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- hw/virtio-9p.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/virtio-9p.c b/hw/virtio-9p.c index

[Qemu-devel] [PATCH 09/17] virtio-9p: Implement P9_TWRITE

2010-03-03 Thread Anthony Liguori
This gets write to file to work Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Venkateswararao Jujjuri jv...@linux.vnet.ibm.com Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- hw/virtio-9p-local.c |7 hw/virtio-9p.c | 97

[Qemu-devel] [PATCH 12/17] virtio-9p: Implement P9_TREMOVE

2010-03-03 Thread Anthony Liguori
This gets file deletion to work [mo...@in.ibm.com: Fix truncate to use the relative path] Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Gautham R Shenoy e...@in.ibm.com Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- hw/virtio-9p-local.c |7 ++

[Qemu-devel] [PATCH 15/17] virtio-9p: Use little endian format on virtio

2010-03-03 Thread Anthony Liguori
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com We need to use platform independent data format as part of protocol data. 9P uses little endian format on wire Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- hw/virtio-9p.c | 34 +++--- 1

[Qemu-devel] Re: [PATCHv3 19/20] eepro100: Remove C++ comments

2010-03-03 Thread Stefan Weil
Michael S. Tsirkin schrieb: On Tue, Mar 02, 2010 at 10:37:59PM +0100, Stefan Weil wrote: C++ comments are unwanted, so this is fixed here. * Replace C++ comments by C comments. * Put code which was deactivated by a C++ comment in #if 0...#endif. Signed-off-by: Stefan Weil

[Qemu-devel] Re: [PATCHv3 19/20] eepro100: Remove C++ comments

2010-03-03 Thread Michael S. Tsirkin
On Wed, Mar 03, 2010 at 08:15:09PM +0100, Stefan Weil wrote: Michael S. Tsirkin schrieb: On Tue, Mar 02, 2010 at 10:37:59PM +0100, Stefan Weil wrote: C++ comments are unwanted, so this is fixed here. * Replace C++ comments by C comments. * Put code which was deactivated by a C++ comment

Re: [Qemu-devel] [PATCH 04/17] virtio-9p: Implement P9_TSTAT

2010-03-03 Thread malc
On Wed, 3 Mar 2010, Anthony Liguori wrote: This get the mount to work on the guest [ki...@linux.vnet.ibm.com: malloc to qemu_malloc conversion] Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Gautham R Shenoy e...@in.ibm.com Signed-off-by: Aneesh Kumar K.V

Re: [Qemu-devel] Intel PXA270 System-on-chip emulation in QEMU

2010-03-03 Thread andrzej zaborowski
On 3 March 2010 18:24, Taimoor Mirza mooni_mi...@hotmail.com wrote: Can you tell me name of any platform which is emulated in QEMU and I can run my USB device application on it? I mean I want to haveĀ board(emulated in QEMU) behaving as a mass storage device (running mass storage application).

Re: [Qemu-devel] [PATCH] tcg: fix build on 32-bit hppa, ppc and sparc hosts

2010-03-03 Thread Stuart Brady
On Mon, Feb 22, 2010 at 05:35:16PM +0100, Stefan Weil wrote: Maybe my comment applies also to the change in tcg/hppa/tcg-target.c, but I tested only ppc (using cross compilation). HPPA host support is 32-bit only for the time being, as there isn't even a 64-bit userspace for HPPA, yet, and

[Qemu-devel] Re: [PATCH v4 03/10] x86: Extend validity of cpu_is_bsp

2010-03-03 Thread Jan Kiszka
Gleb Natapov wrote: On Mon, Mar 01, 2010 at 06:17:22PM +0100, Jan Kiszka wrote: As we hard-wire the BSP to CPU 0 anyway and cpuid_apic_id equals cpu_index, cpu_is_bsp can also be based on the latter directly. This will help an early user of it: KVM while initializing mp_state. Signed-off-by:

Re: [Qemu-devel] Re: EHCI support in QEMU

2010-03-03 Thread Jan Kiszka
David S. Ahern wrote: On 03/03/2010 04:21 AM, Niels de Vos wrote: On Tue, Mar 2, 2010 at 10:48 AM, Kevin Wolf kw...@redhat.com wrote: Am 01.03.2010 22:17, schrieb Jan Kiszka: Niels de Vos wrote: If someone is interested in this partially ported patch, I'm happy to share, but it will at least

Re: [Qemu-devel] Re: EHCI support in QEMU

2010-03-03 Thread David S. Ahern
On 03/03/2010 04:47 PM, Jan Kiszka wrote: Thanks for your work, David and Niels! I assume that David based this on Niels' patch, so there is nothing to be merged? David's version built for me, so I pushed git://git.kiszka.org/qemu.git ehci So far it's supposed to be a reference

[Qemu-devel] Re: [PATCH 2/4] KVM: Rework VCPU state writeback API

2010-03-03 Thread Marcelo Tosatti
On Tue, Mar 02, 2010 at 11:29:10PM -0300, Marcelo Tosatti wrote: On Tue, Mar 02, 2010 at 05:31:09PM +0100, Jan Kiszka wrote: Marcelo Tosatti wrote: On Tue, Mar 02, 2010 at 09:00:04AM +0100, Jan Kiszka wrote: Marcelo Tosatti wrote: On Mon, Mar 01, 2010 at 07:10:30PM +0100, Jan Kiszka

[Qemu-devel] Re: [PATCH 2/4] KVM: Rework VCPU state writeback API

2010-03-03 Thread Kevin O'Connor
On Thu, Mar 04, 2010 at 01:21:12AM -0300, Marcelo Tosatti wrote: The regression seems to be caused by seabios commit d7e998f. Kevin, the failure can be seen on the attached screenshot, which happens on the first reboot of WinXP 32 installation (after copying files etc). Sorry - I also noticed

[Qemu-devel] qemu on Solaris

2010-03-03 Thread Seth G
Hi, I just sent a fair amount of time trying to figure out problems with the qemu build and resulting binary. The first problem (which is no longer a problem due to the shell OpenSolaris uses) was that `sh' was used in rules.mak to perform commands -- I had a /bin/sh that was not

Re: [Qemu-devel] qemu on Solaris

2010-03-03 Thread Jonathan Kalbfeld
Hey Seth, Do you know if it builds on Sparc at all? On Oracle Solaris ;) jonathan On Wed, Mar 3, 2010 at 6:24 PM, Seth G seth.goldb...@sun.com wrote: Hi, I just sent a fair amount of time trying to figure out problems with the qemu build and resulting binary. The first problem (which

Re: [Qemu-devel] qemu on Solaris

2010-03-03 Thread Seth Goldberg
Quoting Jonathan Kalbfeld, who wrote the following on Wed, 3 Mar 2010: Hey Seth, Do you know if it builds on Sparc at all? On Oracle Solaris ;) Yes, with the below caveats, it does build and operate on SPARC as well :). --S jonathan On Wed, Mar 3, 2010 at 6:24 PM, Seth G

[Qemu-devel] Re: [PATCH v4 03/10] x86: Extend validity of cpu_is_bsp

2010-03-03 Thread Gleb Natapov
On Thu, Mar 04, 2010 at 12:34:22AM +0100, Jan Kiszka wrote: Gleb Natapov wrote: On Mon, Mar 01, 2010 at 06:17:22PM +0100, Jan Kiszka wrote: As we hard-wire the BSP to CPU 0 anyway and cpuid_apic_id equals cpu_index, cpu_is_bsp can also be based on the latter directly. This will help an