[Qemu-devel] [ARM] SYS_GET_CMDLINE handling

2010-04-09 Thread Christophe LYON
Hello, I am facing a problem when using qemu-arm, when the target code uses the SYS_GET_CMDLINE semi-hosting call. Indeed, in arm-semi.c (line ~376), args are read from ts-info-host_argv, which in turn has been initialised much earlier in linuxload.c:load_exec with the value of target_argv.

[Qemu-devel] Weird thing happen when the VM is stop! (0.12.3)

2010-04-09 Thread Jun Koi
Hi, I found something very funny happening with 0.12.3: it seems the VM is still running even I already stopped it. Here is how I verified that: Boot any OS (I checked with Windows XP and Ubuntu) with 0.12.3, and stop it any time after it booted up. Use stop command on monitor interface. Now

[Qemu-devel] [STABLE][PULL 00/10] Patches for 0.12.4

2010-04-09 Thread Kevin Wolf
Hi Aurelien, I went through the patches that were committed recently, either written by me or concerning block stuff (most of them are both). I came up with this list of patches that should go into 0.12.4. The first half of them is contained in current master (you'll see the cherry-pick line in

[Qemu-devel] [STABLE][PATCH 01/10] json-parser: Fix segfault on malformed input

2010-04-09 Thread Kevin Wolf
If the parser fails to parse the key in parse_pair, it will access a NULL pointer. A simple way to trigger this is sending {foo} via QMP. This patch turns the segfault into a syntax error reply. Signed-off-by: Kevin Wolf kw...@redhat.com Signed-off-by: Aurelien Jarno aurel...@aurel32.net (cherry

[Qemu-devel] [STABLE][PATCH 02/10] block: avoid creating too large iovecs in multiwrite_merge

2010-04-09 Thread Kevin Wolf
From: Christoph Hellwig h...@lst.de If we go over the maximum number of iovecs support by syscall we get back EINVAL from the kernel which translate to I/O errors for the guest. Add a MAX_IOV defintion for platforms that don't have it. For now we use the same 1024 define that's used on Linux

[Qemu-devel] [STABLE][PATCH 06/10] block: Fix multiwrite error handling

2010-04-09 Thread Kevin Wolf
When two requests of the same multiwrite batch fail, the callback of all requests in that batch were called twice. This could have any kind of nasty effects, in my case it lead to use after free and eventually a segfault. Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c |2 +- 1 files

[Qemu-devel] [STABLE][PATCH 05/10] scsi-disk: fix buffer overflow

2010-04-09 Thread Kevin Wolf
From: Gerd Hoffmann kra...@redhat.com In case s-version is shorter than 4 bytes we overflow the memcpy src buffer. Fix it by clearing the target buffer, then copy only the amount of bytes we actually have. Signed-off-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Anthony Liguori

[Qemu-devel] [STABLE][PATCH 03/10] qcow2: Factor next_refcount_table_size out

2010-04-09 Thread Kevin Wolf
When the refcount table grows, it doesn't only grow by one entry but reserves some space for future refcount blocks. The algorithm to calculate the number of entries stays the same with the fixes, so factor it out before replacing the rest. As Juan suggested take the opportunity to simplify the

[Qemu-devel] [STABLE][PATCH 04/10] qcow2: Rewrite alloc_refcount_block/grow_refcount_table

2010-04-09 Thread Kevin Wolf
The current implementation of alloc_refcount_block and grow_refcount_table has fundamental problems regarding error handling. There are some places where an I/O error means that the image is going to be corrupted. I have found that the only way to fix this is to completely rewrite the thing. In

[Qemu-devel] [STABLE][PATCH 10/10] qcow2: Remove request from in-flight list after error

2010-04-09 Thread Kevin Wolf
If we complete a request with a failure we need to remove it from the list of requests that are in flight. If we don't do it, the next time the same AIOCB is used for a cluster allocation it will create a loop in the list and qemu will hang in an endless loop. Signed-off-by: Kevin Wolf

[Qemu-devel] [STABLE][PATCH 09/10] qcow2: Don't ignore immediate read/write failures

2010-04-09 Thread Kevin Wolf
Returning -EIO is far from optimal, but at least it's an error code. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 4ae8f19..f6f8980 100644 --- a/block/qcow2.c +++

[Qemu-devel] [STABLE][PATCH 08/10] block: Fix multiwrite memory leak in error case

2010-04-09 Thread Kevin Wolf
Previously multiwrite_user_cb was never called if a request in the multiwrite batch failed right away because it did set mcb-error immediately. Make it look more like a normal callback to fix this. Reported-by: Juan Quintela quint...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com ---

[Qemu-devel] [STABLE][PATCH 07/10] block: Fix error code in multiwrite for immediate failures

2010-04-09 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c index 06e22a6..d537d10 100644 --- a/block.c +++ b/block.c @@ -1758,10 +1758,10 @@ int bdrv_aio_multiwrite(BlockDriverState *bs, BlockRequest *reqs,

[Qemu-devel] [PATCH] pci: fix pci_find_bus().

2010-04-09 Thread Isaku Yamahata
When looking down child bus, it looked parent bridge's bus number. It should look child bridge's. Cc: Blue Swirl blauwir...@gmail.com Cc: Michael S. Tsirkin m...@redhat.com Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/pci.c |4 ++-- 1 files changed, 2 insertions(+), 2

[Qemu-devel] [PATCH] pci: fix pci_find_space()

2010-04-09 Thread Isaku Yamahata
pci capability must be in PCI space. It can't lay in PCIe extended config space. Cc: Michael S. Tsirkin m...@redhat.com Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/pci.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index

[Qemu-devel] [PATCH] Cleanup dead code

2010-04-09 Thread Jun Koi
This patch removes some dead code in exec.c Signed-off-by: Jun Koi junkoi2...@gmail.com diff --git a/exec.c b/exec.c index 76163aa..43366ac 100644 --- a/exec.c +++ b/exec.c @@ -2884,15 +2884,12 @@ void *qemu_get_ram_ptr(ram_addr_t addr) (typically a TLB entry) back to a ram offset. */

Re: [Qemu-devel] [PATCH 01/14] Add new data type for fprintf like function pointers

2010-04-09 Thread Stefan Weil
Aurelien Jarno schrieb: On Mon, Mar 29, 2010 at 09:16:52PM +0200, Stefan Weil wrote: The compiler should check the arguments for these functions. gcc can do this, but only if the function pointer's prototype includes the __attribute__ flag. As the necessary declaration is a bit lengthy, we

[Qemu-devel] [PATCH -V4 00/21] virtio-9p: paravirtual file system passthrough

2010-04-09 Thread Aneesh Kumar K.V
This patch series adds VirtFS to QEMU. VirtFS is code named for a 9P filesystem server in QEMU enabling paravirtual filesystem pass-trhough between KVM host and guest. VirtFS is intended to offer an alternative to using NFS/CIFS to share host filesystems on guest and provides better

[Qemu-devel] [PATCH -V4 05/21] virtio-9p: Add minimal set of FileOperations

2010-04-09 Thread Aneesh Kumar K.V
From: Anthony Liguori aligu...@us.ibm.com Add minimal set of FileOperations and the corresponding implementations for local fstype. These will be required for the FID management patches later on. [aneesh.ku...@linux.vnet.ibm.com: rpath fix ] Signed-off-by: Anthony Liguori aligu...@us.ibm.com

[Qemu-devel] [PATCH -V4 01/21] virtio-9p: Create a commandline option -fsdev

2010-04-09 Thread Aneesh Kumar K.V
From: Gautham R Shenoy e...@in.ibm.com This patch creates a new command line option named -fsdev to hold any file system specific information. The option will currently hold the following attributes: -fsdev fstype id=id,path=path_to_share where fstype: Type of the file system. id: Identifier

[Qemu-devel] [PATCH -V4 03/21] virtio-9p: pdu processing support.

2010-04-09 Thread Aneesh Kumar K.V
From: Anthony Liguori aligu...@us.ibm.com Add helpers to process the PDUs. [ki...@linux.vnet.ibm.com: malloc to qemu_malloc coversion] Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- hw/virtio-9p-debug.h |7 ++

[Qemu-devel] [PATCH -V4 02/21] virtio-9p: Add a virtio 9p device to qemu

2010-04-09 Thread Aneesh Kumar K.V
From: Anthony Liguori aligu...@us.ibm.com This patch doesn't implement the 9p protocol handling code. It adds a simple device which dump the protocol data. [jv...@linux.vnet.ibm.com: Little-Endian to host format conversion] [aneesh.ku...@linux.vnet.ibm.com: Multiple-mounts support]

[Qemu-devel] [PATCH -V4 04/21] virtio-9p: Add string manipulation support.

2010-04-09 Thread Aneesh Kumar K.V
From: Anthony Liguori aligu...@us.ibm.com Add helpers to do string manipulation. Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- hw/virtio-9p.c | 127 1 files

[Qemu-devel] [PATCH -V4 07/21] virtio-9p: Add stat and mode related helper functions.

2010-04-09 Thread Aneesh Kumar K.V
From: Anthony Liguori aligu...@us.ibm.com Add helpers to obtain file stat and mode details. Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- hw/virtio-9p.c | 186 1

[Qemu-devel] [PATCH -V4 10/21] virtio-9p: Add P9_TATTACH support.

2010-04-09 Thread Aneesh Kumar K.V
From: Anthony Liguori aligu...@us.ibm.com Implement P9_TATTACH support. Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- hw/virtio-9p.c | 33 +++-- 1 files changed, 31 insertions(+), 2

[Qemu-devel] [PATCH -V4 06/21] virtio-9p: Add fid and qid management support.

2010-04-09 Thread Aneesh Kumar K.V
From: Anthony Liguori aligu...@us.ibm.com Helper APIs for FID and QID management. Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- hw/virtio-9p.c | 123 1 files

[Qemu-devel] [PATCH -V4 08/21] virtio-9p: Add sg helper functions

2010-04-09 Thread Aneesh Kumar K.V
From: Anthony Liguori aligu...@us.ibm.com Add scatter-gather helper functions. Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- hw/virtio-9p.c | 53 + 1 files changed, 53

[Qemu-devel] [PATCH -V4 11/21] virtio-9p: Add P9_TSTAT support

2010-04-09 Thread Aneesh Kumar K.V
From: Anthony Liguori aligu...@us.ibm.com Implement P9_TSTAT support. This get the mount to work on the guest. [ki...@linux.vnet.ibm.com: malloc to qemu_malloc conversion] Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com ---

[Qemu-devel] [PATCH -V4 14/21] virtio-9p: Add P9_TREAD support

2010-04-09 Thread Aneesh Kumar K.V
From: Anthony Liguori aligu...@us.ibm.com Implement P9_TREAD support. Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- hw/file-op-9p.h |6 ++ hw/virtio-9p-local.c | 37 hw/virtio-9p.c | 234

[Qemu-devel] [PATCH -V4 09/21] virtio-9p: Add P9_TVERSION support

2010-04-09 Thread Aneesh Kumar K.V
From: Anthony Liguori aligu...@us.ibm.com Implement P9_TVERSION support. [sripat...@in.ibm.com: Handle unknown 9P versions as per the standards] Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- hw/virtio-9p.c | 15

[Qemu-devel] [PATCH -V4 12/21] virtio-9p: Add P9_TWALK support

2010-04-09 Thread Aneesh Kumar K.V
From: Anthony Liguori aligu...@us.ibm.com Implement P9_TWALK support. Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- hw/virtio-9p.c | 173 +++- 1 files changed, 171

[Qemu-devel] [PATCH -V4 15/21] virtio-9p: Add P9_TCLUNK support

2010-04-09 Thread Aneesh Kumar K.V
From: Anthony Liguori aligu...@us.ibm.com Implement P9_TCLUNK support. This patch gets `ls -al` to work. Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- hw/virtio-9p.c | 16 ++-- 1 files changed, 14

[Qemu-devel] [PATCH -V4 16/21] virtio-9p: Add P9_TWRITE support

2010-04-09 Thread Aneesh Kumar K.V
From: Anthony Liguori aligu...@us.ibm.com Implement P9_TWRITE support. This gets write to file to work Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- hw/file-op-9p.h |1 + hw/virtio-9p-local.c |7 +++

[Qemu-devel] [PATCH -V4 17/21] virtio-9p: Add P9_TCREATE support

2010-04-09 Thread Aneesh Kumar K.V
From: Anthony Liguori aligu...@us.ibm.com Implement P9_TCREATE support. [jv...@linux.vnet.ibm.com: strdup to qemu_strdup conversion] Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- hw/file-op-9p.h |8 ++

[Qemu-devel] [PATCH -V4 20/21] virtio-9p: Add P9_TFLUSH support

2010-04-09 Thread Aneesh Kumar K.V
From: Anthony Liguori aligu...@us.ibm.com Don't do anything special for flush. Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- hw/virtio-9p.c | 35 ++- 1 files changed, 2 insertions(+), 33

[Qemu-devel] [PATCH -V4 19/21] virtio-9p: Add P9_TREMOVE support.

2010-04-09 Thread Aneesh Kumar K.V
From: Anthony Liguori aligu...@us.ibm.com Implement P9_TREMOVE support. This gets file deletion to work. [mo...@in.ibm.com: Fix truncate to use the relative path] Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com ---

[Qemu-devel] [PATCH -V4 13/21] virtio-9p: Add P9_TOPEN support.

2010-04-09 Thread Aneesh Kumar K.V
From: Anthony Liguori aligu...@us.ibm.com Implement P9_TOPEN support. Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- hw/file-op-9p.h |2 + hw/virtio-9p-local.c | 12 hw/virtio-9p.c | 153

[Qemu-devel] [PATCH -V4 21/21] virtio-9p: Create a syntactic shortcut for the file-system pass-thru

2010-04-09 Thread Aneesh Kumar K.V
From: Gautham R Shenoy e...@in.ibm.com Currently the commandline to create a virtual-filesystem pass-through between the guest and the host is as follows: #qemu -fsdev fstype,id=ID,path=path/to/share \ -device virtio-9p-pci,fsdev=ID,mount_tag=tag \ This patch provides a syntactic short-cut

[Qemu-devel] [PATCH -V4 18/21] virtio-9p: Add P9_TWSTAT support

2010-04-09 Thread Aneesh Kumar K.V
From: Anthony Liguori aligu...@us.ibm.com Implement P9_TWSTAT support. This gets file and directory creation to work. [jv...@linux.vnet.ibm.com: strdup to qemu_strdup conversion] [aneesh.ku...@linux.vnet.ibm.com: v9fs_fix_path] Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by:

Re: [Qemu-devel] [RFC PATCH 1/7] devicetree: Add 8k instead of double dtb size when reserving extra memory

2010-04-09 Thread Paul Brook
If a small 'seed' dtb file is loaded into qemu and then heavily modified (say for runtime population of all the device nodes), then 2x the dtb size turns out not to be very much. This patch changes the device tree loading code to add a fixed 8k of additional space to the dtb buffer. In

Re: [Qemu-devel] [RFC PATCH 0/7] QEMU patches to generate FDT from qdevs

2010-04-09 Thread Paul Brook
Hi everyone, This is an experimental set of patches for populating the flattened device tree (fdt) data from the actual set of qdevs in the platform. I'm not expecting this to get merged anytime soon, but I wanted to get it out there to solicit comments. My target for this is testing

[Qemu-devel] [PATCH][STABLE] Add qerror message if the 'change' target filename can't be opened

2010-04-09 Thread Ryan Harper
Currently when using the change command to switch the file in the cd drive the command doesn't complain if the file doesn't exit or can't be opened and the drive keeps the existing image. This patch adds a qerror_report call to print a message out indicating the failure. This error message can

Re: [Qemu-devel] [GSoC 2010] Pass-through filesystem support.

2010-04-09 Thread Luiz Capitulino
On Thu, 8 Apr 2010 18:01:01 +0200 Mohammed Gamal m.gamal...@gmail.com wrote: Hi, Now that Cam is almost done with his ivshmem patches, I was thinking of another idea for GSoC which is improving the pass-though filesystems. I've got some questions on that: 1- What does the community prefer

Re: [Qemu-devel] Weird thing happen when the VM is stop! (0.12.3)

2010-04-09 Thread Luiz Capitulino
On Fri, 9 Apr 2010 18:32:21 +0900 Jun Koi junkoi2...@gmail.com wrote: Hi, I found something very funny happening with 0.12.3: it seems the VM is still running even I already stopped it. Here is how I verified that: Boot any OS (I checked with Windows XP and Ubuntu) with 0.12.3, and stop

[Qemu-devel] Libvirt debug API

2010-04-09 Thread Chris Lalancette
Hello, In response to a lot of the talk of qemud lately on qemu-devel, the libvirt community would like to put forward a proposal to help enable debug/advanced options when using various hypervisors. The goals of this API are: 1) To enable more rapid access to hypervisor features before

[Qemu-devel] why VNC server running on `::1:5901' ?

2010-04-09 Thread Hayfeng Lee
hi,folks. I'm a newbie for qemu.AND now I use the qemu to emulate windows xp ,But ,when I type the commandline qemu -hda hda.img -boot d Error happens. The scene is : omy...@ubuntu:~$ sudo qemu -hda hda.img -boot d VNC server running on `::1:5901'---just show this line.And then nothing

[Qemu-devel] 64-bit Guest With kqemu

2010-04-09 Thread Gordan Bobic
Hi, Has the issue with running 64-bit guests on 64-bit hosts with kqemu ever been resolved? I have seen numerous bug reports relating to the error kqemu: aborting: Unexpected exception 0x0d in monitor space when running 64-bit guests. I haven't seen any patches to resolve the problem,

[Qemu-devel] Re: [libvirt] Libvirt debug API

2010-04-09 Thread Daniel P. Berrange
On Fri, Apr 09, 2010 at 09:41:39AM -0400, Chris Lalancette wrote: Hello, In response to a lot of the talk of qemud lately on qemu-devel, the libvirt community would like to put forward a proposal to help enable debug/advanced options when using various hypervisors. The goals of this API

Re: [Qemu-devel] [PATCH] tcp/mips: Change TCG_AREG0 (fp - s0)

2010-04-09 Thread Richard Henderson
On 04/09/2010 12:36 AM, Stefan Weil wrote: * Add fp to list of reserved registers. This is unnecessary. The register is not a frame pointer within tcg generated code. It's available for use as a call-saved register. r~

Re: [Qemu-devel] [RFC PATCH 0/7] QEMU patches to generate FDT from qdevs

2010-04-09 Thread Grant Likely
On Fri, Apr 9, 2010 at 6:07 AM, Paul Brook p...@codesourcery.com wrote: Hi everyone, This is an experimental set of patches for populating the flattened device tree (fdt) data from the actual set of qdevs in the platform. I'm not expecting this to get merged anytime soon, but I wanted to get

Re: [Qemu-devel] [RFC PATCH 1/7] devicetree: Add 8k instead of double dtb size when reserving extra memory

2010-04-09 Thread Grant Likely
On Fri, Apr 9, 2010 at 6:00 AM, Paul Brook p...@codesourcery.com wrote: If a small 'seed' dtb file is loaded into qemu and then heavily modified (say for runtime population of all the device nodes), then 2x the dtb size turns out not to be very much. This patch changes the device tree loading

[Qemu-devel] [PATCH] tcp/mips: Change TCG_AREG0 (fp - s0)

2010-04-09 Thread Stefan Weil
Register fp (frame pointer) is a bad choice for compilations without optimisation, because the compiler makes heavy use of this register (so the resulting code crashes). Register s0 had been used for TCG_AREG1 in earlier releases, but was no longer used and is now free for TCG_AREG0. The

Re: [Qemu-devel] [RFC PATCH 0/7] QEMU patches to generate FDT from qdevs

2010-04-09 Thread Paul Brook
On Fri, Apr 9, 2010 at 6:07 AM, Paul Brook p...@codesourcery.com wrote: Hi everyone, This is an experimental set of patches for populating the flattened device tree (fdt) data from the actual set of qdevs in the platform. I'm not expecting this to get merged anytime soon, but I wanted

[Qemu-devel] race condition when exec'ing qemu -incoming followed by monitor cont

2010-04-09 Thread Laine Stump
(Please forgive (and correct!) any inaccuracies in my description of qemu's workings - I've only recently started looking at it directly, rather than through the lens of libvirt) libvirt implements a domain restore operation by: 0) start with a previously saved domain image in a file 1) open

Re: [Qemu-devel] Weird thing happen when the VM is stop! (0.12.3)

2010-04-09 Thread Jun Koi
On Fri, Apr 9, 2010 at 10:20 PM, Luiz Capitulino lcapitul...@redhat.com wrote: On Fri, 9 Apr 2010 18:32:21 +0900 Jun Koi junkoi2...@gmail.com wrote: Hi, I found something very funny happening with 0.12.3: it seems the VM is still running even I already stopped it. Here is how I verified

[Qemu-devel] [PATCH] microblaze: fix build on Ubuntu Hardy

2010-04-09 Thread Thomas Monjalon
From: Thomas Monjalon tho...@monjalon.net Using GCC-4.2.4-1ubuntu4, there were 3 warnings: microblaze-dis.c:829: warning: format '%04x' expects type 'unsigned int', but argument 4 has type 'long unsigned int' microblaze-dis.c:962: warning: format '%04x' expects type 'unsigned

[Qemu-devel] Re: [PATCH] microblaze: fix build on Ubuntu Hardy

2010-04-09 Thread Paolo Bonzini
On 04/09/2010 05:31 PM, Thomas Monjalon wrote: Paolo Bonzini wrote: On 04/09/2010 12:22 AM, Thomas Monjalon wrote: Using GCC-4.2.4-1ubuntu4, there were 3 warnings. The last two are correct, but what was the first error? If it was a shadowed declaration as it seems to be, the solution is to

[Qemu-devel] Re: race condition when exec'ing qemu -incoming followed by monitor cont

2010-04-09 Thread Paolo Bonzini
On 04/09/2010 06:03 PM, Laine Stump wrote: Can someone provide any insight on why it is possible to start the CPUs in the domain before the incoming migration is complete, and what we can do (other than blindly sleeping) to prevent this? I would say it's a bug in QEMU, and it has to be fixed

Re: [Qemu-devel] [RFC PATCH 0/7] QEMU patches to generate FDT from qdevs

2010-04-09 Thread Grant Likely
On Fri, Apr 9, 2010 at 9:57 AM, Paul Brook p...@codesourcery.com wrote: On Fri, Apr 9, 2010 at 6:07 AM, Paul Brook p...@codesourcery.com wrote: Hi everyone, This is an experimental set of patches for populating the flattened device tree (fdt) data from the actual set of qdevs in the

Re: [Qemu-devel] [PATCH 2/2] block: Convert bdrv_first to QTAILQ

2010-04-09 Thread Kevin Wolf
Am 09.04.2010 16:22, schrieb Stefan Hajnoczi: Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- block.c | 44 +++- block_int.h |3 ++- 2 files changed, 25 insertions(+), 22 deletions(-) diff --git a/block.c b/block.c index

Re: [Qemu-devel] race condition when exec'ing qemu -incoming followed by monitor cont

2010-04-09 Thread Laine Stump
On 04/09/2010 12:03 PM, Laine Stump wrote: (Please forgive (and correct!) any inaccuracies in my description of qemu's workings - I've only recently started looking at it directly, rather than through the lens of libvirt) libvirt implements a domain restore operation by: 0) start with a

Re: [Qemu-devel] [PATCH 11/18] tcg/arm: add bswap ops

2010-04-09 Thread Aurelien Jarno
On Fri, Apr 09, 2010 at 12:32:04AM +0100, Paul Brook wrote: +static inline void tcg_out_bswap32(TCGContext *s, int cond, int rd, int rn) +#else +/* This code only uses one temporary register. There is probably + a faster way to do that with more temporary registers. */ You can

Re: [Qemu-devel] [GSoC 2010] Pass-through filesystem support.

2010-04-09 Thread jvrao
Luiz Capitulino wrote: On Thu, 8 Apr 2010 18:01:01 +0200 Mohammed Gamal m.gamal...@gmail.com wrote: Hi, Now that Cam is almost done with his ivshmem patches, I was thinking of another idea for GSoC which is improving the pass-though filesystems. I've got some questions on that: 1- What

Re: [Qemu-devel] [PATCH 1/2] block: Do not export bdrv_first

2010-04-09 Thread Kevin Wolf
Am 09.04.2010 16:22, schrieb Stefan Hajnoczi: The bdrv_first linked list of BlockDriverStates is currently extern so that block migration can iterate the list. However, since there is already a bdrv_iterate() function there is no need to expose bdrv_first. Signed-off-by: Stefan Hajnoczi

Re: [Qemu-devel] [GSoC 2010] Pass-through filesystem support.

2010-04-09 Thread Mohammed Gamal
On Fri, Apr 9, 2010 at 7:11 PM, jvrao jv...@linux.vnet.ibm.com wrote: Luiz Capitulino wrote: On Thu, 8 Apr 2010 18:01:01 +0200 Mohammed Gamal m.gamal...@gmail.com wrote: Hi, Now that Cam is almost done with his ivshmem patches, I was thinking of another idea for GSoC which is improving the

[Qemu-devel] Re: [PATCH 01/22] QObject API: add qdict_to_qstring() function

2010-04-09 Thread Luiz Capitulino
On Thu, 8 Apr 2010 17:16:18 -0300 Miguel Di Ciurcio Filho miguel.fi...@gmail.com wrote: This is a helper function that converts a QDict to a QString, using the format: key1=value1 SPACE key2=value2 SPACE key3=value3 Handy for debugging and other things. Signed-off-by: Miguel Di

[Qemu-devel] Re: [PATCH 19/22] net: socket: replace qemu_format_nic_info_str by qemu_format_nic_info_dict

2010-04-09 Thread Luiz Capitulino
On Thu, 8 Apr 2010 17:16:36 -0300 Miguel Di Ciurcio Filho miguel.fi...@gmail.com wrote: Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- net/socket.c | 47 ++- 1 files changed, 34 insertions(+), 13 deletions(-) diff --git

[Qemu-devel] Re: [PATCH 20/22] net: tap: replace qemu_format_nic_info_str by info_dict

2010-04-09 Thread Luiz Capitulino
On Thu, 8 Apr 2010 17:16:37 -0300 Miguel Di Ciurcio Filho miguel.fi...@gmail.com wrote: Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- net/tap-win32.c |9 ++--- net/tap.c | 18 +- 2 files changed, 19 insertions(+), 8 deletions(-) diff

[Qemu-devel] Re: [PATCH 22/22] monitor/net: Convert do_info_network() to QObject/QMP

2010-04-09 Thread Luiz Capitulino
On Thu, 8 Apr 2010 17:16:39 -0300 Miguel Di Ciurcio Filho miguel.fi...@gmail.com wrote: Each device is represented by a QDict. The returned QObject is a QList of all devices. This commit slightly changes the monitor output when 'info network' is used. Signed-off-by: Miguel Di Ciurcio

[Qemu-devel] Re: [PATCH 02/22] net: replace qemu_nic_format_info_str and VLANClientState-info_str by QDicts

2010-04-09 Thread Luiz Capitulino
On Thu, 8 Apr 2010 17:16:19 -0300 Miguel Di Ciurcio Filho miguel.fi...@gmail.com wrote: There is no standard format when formatting info_str, so it is difficult to extract information and transmit it over QMP. This patch changes info_str from a simple string to a QDict. Patches that

[Qemu-devel] Re: [PATCH 0/22] Convert do_info_network() to QObject/QMP

2010-04-09 Thread Luiz Capitulino
On Thu, 8 Apr 2010 17:16:17 -0300 Miguel Di Ciurcio Filho miguel.fi...@gmail.com wrote: The VLANClientState structure has the member info_str, a simple string that is filled with information about NIC devices and used on monitor calls. There is no coherent formatting of this string by all

[Qemu-devel] Re: [PATCH 05/22] net: eepro100: replace qemu_format_nic_info_str by qemu_format_nic_info_dict

2010-04-09 Thread Luiz Capitulino
On Thu, 8 Apr 2010 17:16:22 -0300 Miguel Di Ciurcio Filho miguel.fi...@gmail.com wrote: Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- hw/eepro100.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/eepro100.c b/hw/eepro100.c index

[Qemu-devel] Re: [PATCH 18/22] net: slirp: replace qemu_format_nic_info_str by qemu_format_nic_info_dict

2010-04-09 Thread Luiz Capitulino
On Thu, 8 Apr 2010 17:16:35 -0300 Miguel Di Ciurcio Filho miguel.fi...@gmail.com wrote: Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- net/slirp.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/net/slirp.c b/net/slirp.c index

Re: [Qemu-devel] Weird thing happen when the VM is stop! (0.12.3)

2010-04-09 Thread Marcelo Tosatti
On Sat, Apr 10, 2010 at 01:12:27AM +0900, Jun Koi wrote: On Fri, Apr 9, 2010 at 10:20 PM, Luiz Capitulino lcapitul...@redhat.com wrote: On Fri, 9 Apr 2010 18:32:21 +0900 Jun Koi junkoi2...@gmail.com wrote: Hi, I found something very funny happening with 0.12.3: it seems the VM is

Re: [Qemu-devel] race condition when exec'ing qemu -incoming followed by monitor cont

2010-04-09 Thread Daniel P. Berrange
On Fri, Apr 09, 2010 at 12:03:54PM -0400, Laine Stump wrote: (Please forgive (and correct!) any inaccuracies in my description of qemu's workings - I've only recently started looking at it directly, rather than through the lens of libvirt) libvirt implements a domain restore operation by:

Re: [Qemu-devel] [PATCH 2/2] block: Convert bdrv_first to QTAILQ

2010-04-09 Thread Stefan Hajnoczi
On Fri, Apr 9, 2010 at 5:47 PM, Kevin Wolf kw...@redhat.com wrote: @@ -545,13 +542,15 @@ void bdrv_close(BlockDriverState *bs)  void bdrv_delete(BlockDriverState *bs)  { -    BlockDriverState **pbs; +    BlockDriverState *bs1; -    pbs = bdrv_first; -    while (*pbs != bs *pbs != NULL)

[Qemu-devel] Re: [libvirt] Libvirt debug API

2010-04-09 Thread Chris Lalancette
On 04/09/2010 10:27 AM, Daniel P. Berrange wrote: The concept of command line monitor is something that is QEMU specific and thus is not suitable for the primary XML schema. IMHO, this needs to be done as a separate schema, linked in via an XML namespace. For example domain type='kvm'

Re: [Qemu-devel] [6531] toplevel: remove error handling from qemu_malloc() callers ( Avi Kivity)

2010-04-09 Thread Stefan Weil
Anthony Liguori schrieb: Revision: 6531 http://svn.sv.gnu.org/viewvc/?view=revroot=qemurevision=6531 Author: aliguori Date: 2009-02-05 22:06:18 + (Thu, 05 Feb 2009) Log Message: --- toplevel: remove error handling from qemu_malloc() callers (Avi Kivity) Signed-off-by: Avi

[Qemu-devel] [PATCH] m68k: Fix compiler warning (fprintf format string)

2010-04-09 Thread Stefan Weil
When argument checking is enabled, gcc throws this error: error: format not a string literal and no format arguments The patch rewrites the statement to satisfy the compiler. It also removes a type cast which is not needed. Signed-off-by: Stefan Weil w...@mail.berlios.de --- m68k-dis.c |6

[Qemu-devel] [PATCH] sh4: Fix compiler warning (fprintf format string)

2010-04-09 Thread Stefan Weil
When argument checking is enabled, gcc throws this error: error: format not a string literal and no format arguments The patch rewrites the statement to satisfy the compiler. Signed-off-by: Stefan Weil w...@mail.berlios.de --- sh4-dis.c |4 ++-- 1 files changed, 2 insertions(+), 2

[Qemu-devel] [PATCH] sparc: Fix compiler warning (fprintf format string)

2010-04-09 Thread Stefan Weil
When argument checking is enabled, gcc throws this error: error: format not a string literal and no format arguments The patch rewrites the statement to satisfy the compiler. Signed-off-by: Stefan Weil w...@mail.berlios.de --- sparc-dis.c |2 +- 1 files changed, 1 insertions(+), 1

Re: [Qemu-devel] Re: [libvirt] Libvirt debug API

2010-04-09 Thread Jamie Lokier
Daniel P. Berrange wrote: I think this alteration of existing args is fr too complex fragile, and way overkill. Would it not be simpler, for the target audience, for the config to contain a one-line shell script to transform particular matched arguments in any way that's wanted? If the

[Qemu-devel] Re: [libvirt] Libvirt debug API

2010-04-09 Thread Eric Blake
On 04/09/2010 07:41 AM, Chris Lalancette wrote: Caveats: 3) Application developers will be strongly discouraged from using this API because of the above 2 issues. To help in this, the API's will be in a separate library that developers will explicitly have to link to, and it will have a

[Qemu-devel] [PATCH] arm: Fix compiler warning (fprintf format string)

2010-04-09 Thread Stefan Weil
When argument checking is enabled, gcc throws this error: error: format not a string literal and no format arguments The patch rewrites the statement to satisfy the compiler. Signed-off-by: Stefan Weil w...@mail.berlios.de --- arm-dis.c |8 1 files changed, 4 insertions(+), 4

Re: [Qemu-devel] [GSoC 2010] Pass-through filesystem support.

2010-04-09 Thread Jamie Lokier
Mohammed Gamal wrote: 2- With respect to CIFS. I wonder how the shares are supposed to be exposed to the guest. Should the Samba server be modified to be able to use unix domain sockets instead of TCP ports and then QEMU communicating on these sockets. With that approach, how should the guest

Re: [libvirt] [Qemu-devel] Re: Libvirt debug API

2010-04-09 Thread Eric Blake
On 04/09/2010 03:06 PM, Jamie Lokier wrote: Daniel P. Berrange wrote: I think this alteration of existing args is fr too complex fragile, and way overkill. Would it not be simpler, for the target audience, for the config to contain a one-line shell script to transform particular

Re: [Qemu-devel] [PATCH v3 0/5] Move stuff out of vl.c

2010-04-09 Thread Aurelien Jarno
On Thu, Apr 01, 2010 at 07:57:07PM +0200, Paolo Bonzini wrote: v2-v3 - re-rebased - salvage some cleanups made while trying to compile balloon.c once, but do not do it because it breaks (I have patches to do it also for vl.o, but they are ugly!) Thanks, all applied. Paolo Bonzini (5):

Re: [Qemu-devel] General information about the QEMU project

2010-04-09 Thread Aurelien Jarno
On Tue, Apr 06, 2010 at 01:14:17PM +0200, lok...@gmail.com wrote: Hi I am searching for some informations about QEMU. 1. Currently it's possible to compile and run QEMU under Windows. Is there a fixed support for Windows platforms (as Host)? Or is it possible that newer releases only

Re: [Qemu-devel] [PATCH 6/6] [S390] Add firmware code

2010-04-09 Thread Aurelien Jarno
On Thu, Apr 01, 2010 at 06:42:41PM +0200, Alexander Graf wrote: This patch adds a firmware blob to the S390 target. The blob is a simple implementation of a virtio client that tries to read the second stage bootloader from sectors described as of offset 0x20 in the MBR. In combination with

Re: [Qemu-devel] [PATCH 5/6] [S390] Implement virtio reset

2010-04-09 Thread Aurelien Jarno
On Thu, Apr 01, 2010 at 06:42:40PM +0200, Alexander Graf wrote: The guest may issue a RESET command for virtio. So far we didn't bother to implement it, but with my new bootloader we actually need it for Linux to get back to a safe state. Thanks, applied. Signed-off-by: Alexander Graf

Re: [Qemu-devel] [PATCH] lsi: fix segfault in lsi_command_complete

2010-04-09 Thread Aurelien Jarno
On Mon, Mar 29, 2010 at 03:42:57PM +0200, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann kra...@redhat.com Thanks, applied. --- hw/lsi53c895a.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/lsi53c895a.c b/hw/lsi53c895a.c index a332401..525f3ca 100644

Re: [Qemu-devel] why VNC server running on `::1:5901' ?

2010-04-09 Thread Aurelien Jarno
On Fri, Apr 09, 2010 at 09:44:51PM +0800, Hayfeng Lee wrote: hi,folks. I'm a newbie for qemu.AND now I use the qemu to emulate windows xp ,But ,when I type the commandline qemu -hda hda.img -boot d Error happens. The scene is : omy...@ubuntu:~$ sudo qemu -hda hda.img -boot d VNC server

Re: [Qemu-devel] [PATCH] Remove magic numbers for VNC message IDs from code

2010-04-09 Thread Aurelien Jarno
On Wed, Mar 31, 2010 at 06:20:43PM +0100, Daniel P. Berrange wrote: The code processing incoming sending outgoing messages from/to clients used embedded magic numbers for all message IDs. This made the code a little hard to follow. Add constants in the vnc.h header file for all message IDs

Re: [Qemu-devel] [STABLE][PULL 00/10] Patches for 0.12.4

2010-04-09 Thread Aurelien Jarno
On Fri, Apr 09, 2010 at 11:46:18AM +0200, Kevin Wolf wrote: Hi Aurelien, I went through the patches that were committed recently, either written by me or concerning block stuff (most of them are both). I came up with this list of patches that should go into 0.12.4. The first half of them is

Re: [Qemu-devel] [PATCH] Documentation: Update chapter on installation

2010-04-09 Thread Aurelien Jarno
On Sun, Mar 28, 2010 at 11:50:19AM +0200, Stefan Weil wrote: * Replace broken links by link to QEMU wiki. * Separate sections for Linux / Windows / Mac OS X are no longer needed: the wiki link will provide additional links, so we don't need them here. * Add hint for (Open) Solaris.

Re: [Qemu-devel] [PATCH 4/6] Always notify consumers of char devices if they're open

2010-04-09 Thread Aurelien Jarno
On Thu, Apr 01, 2010 at 06:42:39PM +0200, Alexander Graf wrote: When using virtio-console on s390, the input doesn't work. The root of the problem is rather simple. What happens is the following: 1) create character device for stdio 2) char device is done creating, sends OPENED event

[Qemu-devel] Re: [PATCH] tcp/mips: Change TCG_AREG0 (fp - s0)

2010-04-09 Thread Aurelien Jarno
On Fri, Apr 09, 2010 at 05:28:40PM +0200, Stefan Weil wrote: Register fp (frame pointer) is a bad choice for compilations without optimisation, because the compiler makes heavy use of this register (so the resulting code crashes). Register s0 had been used for TCG_AREG1 in earlier releases,

Re: [Qemu-devel] [PATCHv2] Avoid page_set_flags() assert in qemu-user host page protection code

2010-04-09 Thread Aurelien Jarno
On Wed, Mar 31, 2010 at 11:00:36PM +0200, Juergen Lock wrote: V2 that uses endaddr = end-of-guest-address-space if !h2g_valid(endaddr) after I found out that indeed works; and also disables the FreeBSD 6.x /compat/linux/proc/self/maps fallback because it can return partial lines if (at least I

Re: [Qemu-devel] [PATCH] target-mips: Fix format specifiers for fpu_fprintf

2010-04-09 Thread Aurelien Jarno
On Thu, Apr 01, 2010 at 11:05:14PM +0200, Stefan Weil wrote: In the previous patch which introduced fprintf_function to allow parameter checking by gcc some compiler warnings remained unfixed. These warnings are fixed here. Thanks applied. Signed-off-by: Stefan Weil w...@mail.berlios.de

Re: [Qemu-devel] [PATCH] block: Fix multiwrite error handling

2010-04-09 Thread Aurelien Jarno
On Thu, Apr 01, 2010 at 10:48:44PM +0200, Kevin Wolf wrote: When two requests of the same multiwrite batch fail, the callback of all requests in that batch were called twice. This could have any kind of nasty effects, in my case it lead to use after free and eventually a segfault.

  1   2   >