Re: [Qemu-devel] Re: QEMU-KVM and video performance

2010-04-22 Thread Gerhard Wiesinger
On Wed, 21 Apr 2010, Avi Kivity wrote: On 04/21/2010 09:50 PM, Gerhard Wiesinger wrote: I don't think changing VGA window is a problem because there are 500.000-1Mio changes/s possible. 1MB/s, 500k-1M changes/s Coincidence? Is it taking a page fault or trap on every write? To

Re: [Qemu-devel] Re: QEMU-KVM and video performance

2010-04-22 Thread Gerhard Wiesinger
On Wed, 21 Apr 2010, Jamie Lokier wrote: Gerhard Wiesinger wrote: Hmmm. I'm very new to QEMU and KVM but at least accessing the virtual HW of QEMU even from KVM must be possible (e.g. memory and port accesses are done on nearly every virtual device) and therefore I'm ending in C code in the

Re: [SeaBIOS] [Qemu-devel] QEMU regression problems

2010-04-22 Thread Gerhard Wiesinger
On Wed, 21 Apr 2010, Kevin O'Connor wrote: On Wed, Apr 21, 2010 at 09:16:54PM +0200, Gerhard Wiesinger wrote: On Mon, 19 Apr 2010, Kevin O'Connor wrote: SeaBIOS will lock parts of ram from 0xc-0xf so that the option roms aren't writable. I wonder if that is confusing qemm when it

Re: [Qemu-devel] Re: QEMU-KVM and video performance

2010-04-22 Thread Avi Kivity
On 04/22/2010 08:37 AM, Gerhard Wiesinger wrote: On Wed, 21 Apr 2010, Avi Kivity wrote: On 04/21/2010 09:14 PM, Gerhard Wiesinger wrote: Can you explain which code files/functions of KVM is involved in handling VGA memory window and page switching through the port write to the VGA window

Re: [Qemu-devel] Re: [PATCH] flush TB on singlestep command

2010-04-22 Thread Jan Kiszka
Stefan Weil wrote: Jan Kiszka schrieb: Alexander Graf wrote: On 21.04.2010, at 12:04, Jun Koi wrote: On Tue, Apr 20, 2010 at 8:44 PM, Alexander Graf ag...@suse.de wrote: On 20.04.2010, at 13:38, Jan Kiszka wrote: Alexander Graf wrote: On 20.04.2010,

Re: [Qemu-devel] Re: QEMU-KVM and video performance

2010-04-22 Thread Avi Kivity
On 04/22/2010 09:04 AM, Gerhard Wiesinger wrote: On Wed, 21 Apr 2010, Avi Kivity wrote: On 04/21/2010 09:50 PM, Gerhard Wiesinger wrote: I don't think changing VGA window is a problem because there are 500.000-1Mio changes/s possible. 1MB/s, 500k-1M changes/s Coincidence? Is it taking

[Qemu-devel] [PATCH] audio/sdlaudio: remove unused variable

2010-04-22 Thread Serge Ziryukin
Remove unused 'shift' variable spotted by clang. Also clean up aud_to_sdlfmt which used to get the value of shift. --- audio/sdlaudio.c | 11 ++- 1 files changed, 2 insertions(+), 9 deletions(-) diff --git a/audio/sdlaudio.c b/audio/sdlaudio.c index 8e7e5cb..c353016 100644 ---

Re: [Qemu-devel] [PATCH][STABLE] block: Free iovec arrays allocated by multiwrite_merge()

2010-04-22 Thread Kevin Wolf
Am 21.04.2010 21:35, schrieb Stefan Hajnoczi: A new iovec array is allocated when creating a merged write request. This patch ensures that the iovec array is deleted in addition to its qiov owner. Reported-by: Leszek Urbanski tyg...@moo.pl Signed-off-by: Stefan Hajnoczi

[Qemu-devel] [PATCH] audio/alsa: fix comparison between requested and obtained formats

2010-04-22 Thread Serge Ziryukin
Trivial patch which uses aud_to_alsafmt to fix comparison between alsa and internal audio pcm format enum. --- audio/alsaaudio.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/audio/alsaaudio.c b/audio/alsaaudio.c index 88344ff..d784476 100644 --- a/audio/alsaaudio.c

[Qemu-devel] Re: [stable] [PATCH] tun: orphan an skb on tx

2010-04-22 Thread Greg KH
On Wed, Apr 21, 2010 at 02:35:57PM +0300, Michael S. Tsirkin wrote: On Tue, Apr 13, 2010 at 05:59:44PM +0300, Michael S. Tsirkin wrote: The following situation was observed in the field: tap1 sends packets, tap2 does not consume them, as a result tap1 can not be closed. This happens because

Re: [Qemu-devel] [RFC PATCH 00/20] Kemari for KVM v0.1

2010-04-22 Thread Dor Laor
On 04/21/2010 08:57 AM, Yoshiaki Tamura wrote: Hi all, We have been implementing the prototype of Kemari for KVM, and we're sending this message to share what we have now and TODO lists. Hopefully, we would like to get early feedback to keep us in the right direction. Although advanced

[Qemu-devel] [PATCH] give some useful error messages when tap open fails

2010-04-22 Thread Michael Tokarev
In net/tap-linux.c, when manipulation of /dev/net/tun fails, it prints (with fprintf) something like this: warning: could not open /dev/net/tun: no virtual network emulation this has 2 issues: 1) it is not a warning really, it's a fatal error (kvm exits after that), 2) there's no indication

Re: [Qemu-devel] Re: Bug#573439: qemu-kvm: fail to set hdd serial number

2010-04-22 Thread Michael Tokarev
11.03.2010 18:34, Michael Tokarev wrote: [] On version 0.12.3, -drive serial=XXX option does not work. Below patch fixes it. 'serial' is pointer, not array. --- qemu-kvm-0.12.3+dfsg/vl.c 2010-02-26 11:34:00.0 +0900 +++ qemu-kvm-0.12.3+dfsg.old/vl.c 2010-03-11 02:26:00.134217787

Re: [Qemu-devel] [PATCH] give some useful error messages when tap open fails

2010-04-22 Thread Markus Armbruster
Michael Tokarev m...@tls.msk.ru writes: In net/tap-linux.c, when manipulation of /dev/net/tun fails, it prints (with fprintf) something like this: warning: could not open /dev/net/tun: no virtual network emulation this has 2 issues: 1) it is not a warning really, it's a fatal error (kvm

Re: [Qemu-devel] Locking block devices for concurrent access?

2010-04-22 Thread Michael Tokarev
Ping? ;) What's the current state and/or a roadmap? Thanks! 17.03.2010 22:49, Michael Tokarev wrote: I remember quite long discussion about this issue a while back. But unfortunately, a) I can't find it now, and b) as far as I remember, there was no definitive solution presented at that time.

[Qemu-devel] Re: [PATCH] win32: Avoid compiler warning (WIN32_LEAN_AND_MEAN redefined)

2010-04-22 Thread Paolo Bonzini
On 04/21/2010 10:13 PM, Stefan Weil wrote: Stefan Weil schrieb: configure adds the macro WIN32_LEAN_AND_MEAN to QEMU_CFLAGS, and SDL_syswm.h defines it, too. This results in a compiler warning (redefinition of WIN32_LEAN_AND_MEAN in SDL_syswm.h. That warning prevents compilations for win32

Re: [Qemu-devel] [RFC PATCH 00/20] Kemari for KVM v0.1

2010-04-22 Thread Yoshiaki Tamura
Dor Laor wrote: On 04/21/2010 08:57 AM, Yoshiaki Tamura wrote: Hi all, We have been implementing the prototype of Kemari for KVM, and we're sending this message to share what we have now and TODO lists. Hopefully, we would like to get early feedback to keep us in the right direction. Although

Re: [Qemu-devel] Problem with QEMU on KVM

2010-04-22 Thread Gerd Hoffmann
Hi, Had also a look at ps2.c/ps2.h, pckbd.c: There were no changes which could explain such a behaviour. Also keyboard is very strange which switches to CAPS LOCK (shift state) very unmotivated. Hmm. Recent qemu tries hard to make sure vncviewer and guest capslock/numlock state are in

Re: [Qemu-devel] [PATCH] audio/sdlaudio: remove unused variable

2010-04-22 Thread malc
On Thu, 22 Apr 2010, Serge Ziryukin wrote: Remove unused 'shift' variable spotted by clang. Also clean up aud_to_sdlfmt which used to get the value of shift. --- audio/sdlaudio.c | 11 ++- 1 files changed, 2 insertions(+), 9 deletions(-) The patch submission lacks a sign off.

Re: [Qemu-devel] [PATCH v2] qcow2: Fix creation of large images

2010-04-22 Thread Christoph Hellwig
On Mon, Apr 19, 2010 at 03:21:21PM +0200, Kevin Wolf wrote: qcow_create2 assumes that the new image will only need one cluster for its refcount table initially. Obviously that's not true any more when the image is big enough (exact value depends on the cluster size). This patch calculates

[Qemu-devel] [PATCH] audio/sdlaudio: remove unused variable

2010-04-22 Thread Serge Ziryukin
Remove unused 'shift' variable spotted by clang. Also clean up aud_to_sdlfmt which used to get the value of shift. Signed-off-by: Serge Ziryukin ftrvxm...@gmail.com --- audio/sdlaudio.c | 11 ++- 1 files changed, 2 insertions(+), 9 deletions(-) diff --git a/audio/sdlaudio.c

Re: [Qemu-devel] [PATCH] audio/sdlaudio: remove unused variable

2010-04-22 Thread malc
On Thu, 22 Apr 2010, Serge Ziryukin wrote: Remove unused 'shift' variable spotted by clang. Also clean up aud_to_sdlfmt which used to get the value of shift. Applied. Thank you. -- mailto:av1...@comtv.ru

Re: [Qemu-devel] [RFC PATCH 00/20] Kemari for KVM v0.1

2010-04-22 Thread Dor Laor
On 04/22/2010 01:35 PM, Yoshiaki Tamura wrote: Dor Laor wrote: On 04/21/2010 08:57 AM, Yoshiaki Tamura wrote: Hi all, We have been implementing the prototype of Kemari for KVM, and we're sending this message to share what we have now and TODO lists. Hopefully, we would like to get early

Re: [Qemu-devel] [RFC PATCH 00/20] Kemari for KVM v0.1

2010-04-22 Thread Yoshiaki Tamura
2010/4/22 Takuya Yoshikawa yoshikawa.tak...@oss.ntt.co.jp: (2010/04/22 19:35), Yoshiaki Tamura wrote: A trivial one would we to : - do X online snapshots/sec I currently don't have good numbers that I can share right now. Snapshots/sec depends on what kind of workload is running, and if

Re: [Qemu-devel] [RFC PATCH 00/20] Kemari for KVM v0.1

2010-04-22 Thread Yoshiaki Tamura
2010/4/22 Dor Laor dl...@redhat.com: On 04/22/2010 01:35 PM, Yoshiaki Tamura wrote: Dor Laor wrote: On 04/21/2010 08:57 AM, Yoshiaki Tamura wrote: Hi all, We have been implementing the prototype of Kemari for KVM, and we're sending this message to share what we have now and TODO lists.

[Qemu-devel] Re: [PATCH 04/22] savevm: do_loadvm(): Always resume the VM

2010-04-22 Thread Luiz Capitulino
On Wed, 21 Apr 2010 17:42:54 +0200 Kevin Wolf kw...@redhat.com wrote: Am 21.04.2010 17:39, schrieb Juan Quintela: Luiz Capitulino lcapitul...@redhat.com wrote: 2. Don't keep the VM paused when recovery is possible If you can fix that, it's ok to me: I'll drop this and the next patch.

Re: [Qemu-devel] [PATCH 07/22] qemu-error: Introduce get_errno_string()

2010-04-22 Thread Luiz Capitulino
On Wed, 21 Apr 2010 19:13:16 +0200 Markus Armbruster arm...@redhat.com wrote: Daniel P. Berrange berra...@redhat.com writes: On Wed, Apr 21, 2010 at 12:12:14PM -0300, Luiz Capitulino wrote: On Wed, 21 Apr 2010 18:42:38 +0400 (MSD) malc av1...@comtv.ru wrote: On Wed, 21 Apr 2010,

[Qemu-devel] Re: [PATCH 18/22] savevm: Convert do_delvm() to QObject, QError

2010-04-22 Thread Luiz Capitulino
On Wed, 21 Apr 2010 16:18:18 +0200 Kevin Wolf kw...@redhat.com wrote: Am 20.04.2010 23:09, schrieb Luiz Capitulino: Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qemu-monitor.hx |3 ++- savevm.c| 14 ++ sysemu.h|2 +- 3 files

Re: [Qemu-devel] [PATCH] fix curses update

2010-04-22 Thread Bernhard Kauer
Hi, I believe this issue has come up before with a similar patch but well i've submitted such a patch more than two years ago. Unfortunatelly it got never applied, so that I have to patch my Qemu on every update... someone checked their ncurses and they didn't see the same issue. I just

Re: [Qemu-devel] KVM call minutes for Apr 20

2010-04-22 Thread Rick Vernam
On Tuesday 20 April 2010 09:15:36 Chris Wright wrote: call agenda - send out a bit earlier - cancel call if no agenda 0.12.4 - expect when Anthony is back online For planning purposes, is there a ballpark time line? I do not know the nature of Anthony's absence; my deepest apology if my

[Qemu-devel] Re: [PATCH 18/22] savevm: Convert do_delvm() to QObject, QError

2010-04-22 Thread Kevin Wolf
Am 22.04.2010 15:48, schrieb Luiz Capitulino: On Wed, 21 Apr 2010 16:18:18 +0200 Kevin Wolf kw...@redhat.com wrote: Am 20.04.2010 23:09, schrieb Luiz Capitulino: Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qemu-monitor.hx |3 ++- savevm.c| 14 ++

Re: [Qemu-devel] Re: [PATCH] win32: Avoid compiler warning (WIN32_LEAN_AND_MEAN redefined)

2010-04-22 Thread Richard Henderson
On 04/22/2010 03:11 AM, Paolo Bonzini wrote: There is #define WIN32_LEAN_AND_MEAN in SDL_syswm.h and -DWIN32_LEAN_AND_MEAN in configure, so that should be okay. -DFOO = #define FOO 1 -DFOO= = #define FOO r~

[Qemu-devel] Compile Qemu on Windows?

2010-04-22 Thread Jun Koi
Hi, I want to compile Qemu on Windows (then run it there). Is there any instruction on how to do that? (I googled around, to no avail) Many thanks, Jun

Re: [Qemu-devel] Compile Qemu on Windows?

2010-04-22 Thread Roy Tam
2010/4/22 Jun Koi junkoi2...@gmail.com: Hi, I want to compile Qemu on Windows (then run it there). Is there any instruction on how to do that? (I googled around, to no avail) You will need MinGW(latest stable one), GCC (I use GCC 3.4.5, included in MinGW), binutils, make, MSYS (for MSYS

Re: [Qemu-devel] [RFC PATCH 00/20] Kemari for KVM v0.1

2010-04-22 Thread Takuya Yoshikawa
(2010/04/22 19:35), Yoshiaki Tamura wrote: A trivial one would we to : - do X online snapshots/sec I currently don't have good numbers that I can share right now. Snapshots/sec depends on what kind of workload is running, and if the guest was almost idle, there will be no snapshots in 5sec.

[Qemu-devel] Patches in bug tracker also sent to mailing list?

2010-04-22 Thread Kraai, Matt
Hi, I've submitted two trivial patches against QEMU in its bug tracker: https://bugs.launchpad.net/qemu/+bug/568053 https://bugs.launchpad.net/qemu/+bug/568442 Is this sufficient or should I also submit them to the mailing list? Matt

[Qemu-devel] Wiki unable to confirm email address

2010-04-22 Thread Kraai, Matt
Hi, When I try to confirm my email address on the QEMU wiki, it displays the following error: QEMU could not send your confirmation mail. Please check your e-mail address for invalid characters. Mailer returned: mailer error The email address I used is matt.kr...@amo.abbott.com,

Re: [Qemu-devel] [RFC PATCH 00/20] Kemari for KVM v0.1

2010-04-22 Thread Jamie Lokier
Yoshiaki Tamura wrote: Dor Laor wrote: On 04/21/2010 08:57 AM, Yoshiaki Tamura wrote: Event tapping is the core component of Kemari, and it decides on which event the primary should synchronize with the secondary. The basic assumption here is that outgoing I/O operations are idempotent,

Re: [Qemu-devel] Compile Qemu on Windows?

2010-04-22 Thread jvrao
Roy Tam wrote: 2010/4/22 Jun Koi junkoi2...@gmail.com: Hi, I want to compile Qemu on Windows (then run it there). Is there any instruction on how to do that? (I googled around, to no avail) You will need MinGW(latest stable one), GCC (I use GCC 3.4.5, included in MinGW), binutils, make,

Re: [Qemu-devel] Patches in bug tracker also sent to mailing list?

2010-04-22 Thread Brian Jackson
On Thursday 22 April 2010 09:44:33 Kraai, Matt wrote: Hi, I've submitted two trivial patches against QEMU in its bug tracker: https://bugs.launchpad.net/qemu/+bug/568053 https://bugs.launchpad.net/qemu/+bug/568442 Is this sufficient or should I also submit them to the

Re: [Qemu-devel] Patches in bug tracker also sent to mailing list?

2010-04-22 Thread Dustin Kirkland
On Thu, Apr 22, 2010 at 9:44 AM, Kraai, Matt matt.kr...@amo.abbott.com wrote: I’ve submitted two trivial patches against QEMU in its bug tracker: https://bugs.launchpad.net/qemu/+bug/568053 https://bugs.launchpad.net/qemu/+bug/568442 Is this sufficient or should I also submit them to the

Re: [Qemu-devel] KVM call minutes for Apr 20

2010-04-22 Thread Anthony Liguori
On 04/22/2010 09:27 AM, Rick Vernam wrote: On Tuesday 20 April 2010 09:15:36 Chris Wright wrote: call agenda - send out a bit earlier - cancel call if no agenda 0.12.4 - expect when Anthony is back online For planning purposes, is there a ballpark time line? I do not know the nature

[Qemu-devel] [PATCH] Update usb-linux to handle maximum of 16k transfers.

2010-04-22 Thread David Ahern
Update usb-linux to handle maximum of 16k transfers. The 16k limit is imposed by USBFS. EHCI allows up to 20k per request. USBFS cannot be increased to 20k due to constraints on memory use (wants contiguous memory in allocations that are powers of 2). This change breaks large requests from a host

Re: [Qemu-devel] Wiki unable to confirm email address

2010-04-22 Thread Anthony Liguori
On 04/22/2010 09:52 AM, Kraai, Matt wrote: Hi, When I try to confirm my email address on the QEMU wiki, it displays the following error: QEMU could not send your confirmation mail. Please check your e-mail address for invalid characters. Mailer returned: mailer error The email

Re: [Qemu-devel] Locking block devices for concurrent access?

2010-04-22 Thread Anthony Liguori
On 03/17/2010 02:49 PM, Michael Tokarev wrote: I remember quite long discussion about this issue a while back. But unfortunately, a) I can't find it now, and b) as far as I remember, there was no definitive solution presented at that time. So I thought it's Ok to ask again to get more

Re: [Qemu-devel] Re: [libvirt] Libvirt debug API

2010-04-22 Thread Anthony Liguori
On 04/09/2010 09:27 AM, Daniel P. Berrange wrote: On Fri, Apr 09, 2010 at 09:41:39AM -0400, Chris Lalancette wrote: Hello, In response to a lot of the talk of qemud lately on qemu-devel, the libvirt community would like to put forward a proposal to help enable debug/advanced options

Re: [libvirt] [Qemu-devel] Re: Libvirt debug API

2010-04-22 Thread Anthony Liguori
On 04/12/2010 07:23 AM, Jamie Lokier wrote: Daniel Veillard wrote: On Sun, Apr 11, 2010 at 11:17:38PM +0100, Jamie Lokier wrote: It's not that hard to write this for trivial extra options: emulator/bin/sh -c 'qemu $0 $@ -extra-flag'/emulator (if that works). That

Re: [Qemu-devel] Re: [libvirt] Libvirt debug API

2010-04-22 Thread Anthony Liguori
On 04/12/2010 10:20 AM, Luiz Capitulino wrote: On Fri, 9 Apr 2010 15:27:17 +0100 Daniel P. Berrangeberra...@redhat.com wrote: On Fri, Apr 09, 2010 at 09:41:39AM -0400, Chris Lalancette wrote: Hello, In response to a lot of the talk of qemud lately on qemu-devel, the libvirt

Re: [Qemu-devel] [PATCH 2/2] VirtIO RNG

2010-04-22 Thread Ian Molton
Gerd Hoffmann wrote: Hi, * the SIZE property patch:Msg-Id:4bb206b9.80...@collabora.co.uk Fine with me. \o/ So should I re-post that patch, or can I count on that being folded into mainline ? * the socket reconnect patch: Msg-Id:4b18055b.1030...@collabora.co.uk Not sure yet.

Re: [Qemu-devel] Re: [libvirt] Libvirt debug API

2010-04-22 Thread Anthony Liguori
On 04/22/2010 01:45 PM, Anthony Liguori wrote: Which in turn, could be embedded as: domain type='kvm' xmlns:qemu='http://qemu.org/schemas/qemu/1.0' namemyguest/name ... qemu:cpudef nameOperon_G3/name level5/level vendorAuthenticAMD/vendor /qemu:cpudef /domain With respect to injecting QMP

Re: [Qemu-devel] Locking block devices for concurrent access?

2010-04-22 Thread Richard W.M. Jones
On Thu, Apr 22, 2010 at 01:36:30PM -0500, Anthony Liguori wrote: I think we got to the point where there was general agreement on the usefulness of lock=read|write but where there was still some contention was on this whole notion of lock=exclusive|shared. I believe Richard Jones was

[Qemu-devel] Re: [RFC PATCH 01/20] Modify DIRTY_FLAG value and introduce DIRTY_IDX to use as indexes of bit-based phys_ram_dirty.

2010-04-22 Thread Anthony Liguori
Hi, On 04/21/2010 12:57 AM, Yoshiaki Tamura wrote: Replaces byte-based phys_ram_dirty bitmap with four (MASTER, VGA, CODE, MIGRATION) bit-based phys_ram_dirty bitmap. On allocation, it sets all bits in the bitmap. It uses ffs() to convert DIRTY_FLAG to DIRTY_IDX. Modifies wrapper functions

[Qemu-devel] Re: [RFC PATCH 05/20] Introduce put_vector() and get_vector to QEMUFile and qemu_fopen_ops().

2010-04-22 Thread Anthony Liguori
On 04/21/2010 12:57 AM, Yoshiaki Tamura wrote: QEMUFile currently doesn't support writev(). For sending multiple data, such as pages, using writev() should be more efficient. Signed-off-by: Yoshiaki Tamuratamura.yoshi...@lab.ntt.co.jp Is there performance data that backs this up? Since

[Qemu-devel] Re: [RFC PATCH 07/20] Introduce qemu_put_vector() and qemu_put_vector_prepare() to use put_vector() in QEMUFile.

2010-04-22 Thread Anthony Liguori
On 04/21/2010 12:57 AM, Yoshiaki Tamura wrote: For fool proof purpose, qemu_put_vector_parepare should be called before qemu_put_vector. Then, if qemu_put_* functions except this is called after qemu_put_vector_prepare, program will abort(). Signed-off-by: Yoshiaki

[Qemu-devel] Re: [RFC PATCH 10/20] Introduce skip_header parameter to qemu_loadvm_state() so that it can be called iteratively without reading the header.

2010-04-22 Thread Anthony Liguori
On 04/21/2010 12:57 AM, Yoshiaki Tamura wrote: Signed-off-by: Yoshiaki Tamuratamura.yoshi...@lab.ntt.co.jp I think the more appropriate thing to do is have qemu_savevm_state_complete() not write QEMU_VM_EOF when doing a continuous live migration. You would then want qemu_loadvm_state()

[Qemu-devel] Re: [RFC PATCH 08/20] Introduce RAMSaveIO and use cpu_physical_memory_get_dirty_range() to check multiple dirty pages.

2010-04-22 Thread Anthony Liguori
On 04/21/2010 12:57 AM, Yoshiaki Tamura wrote: Introduce RAMSaveIO to use writev for saving ram blocks, and modifies ram_save_block() and ram_save_remaining() to use cpu_physical_memory_get_dirty_range() to check multiple dirty and non-dirty pages at once. Signed-off-by: Yoshiaki

[Qemu-devel] Re: [RFC PATCH 14/20] Upgrade QEMU_FILE_VERSION from 3 to 4, and introduce qemu_savevm_state_all().

2010-04-22 Thread Anthony Liguori
On 04/21/2010 12:57 AM, Yoshiaki Tamura wrote: Make a 32bit entry after QEMU_VM_FILE_VERSION to recognize whether the transfered data is QEMU_VM_FT_MODE or QEMU_VM_LIVE_MIGRATION_MODE. I'd rather you encapsulate the current protocol as opposed to extending it with a new version. You

Re: [Qemu-devel] [PATCH 0/2] [RFC] 64-bit io paths

2010-04-22 Thread Blue Swirl
On 4/20/10, Richard Henderson r...@twiddle.net wrote: Step 1 to implementing alpha-softmmu is to properly handle 64-bit I/O operations. Tristan Gingold managed a hack where he buffered half of the I/O operation in the host bridge; I think that's not something we want to encourage. I'm a

[Qemu-devel] Re: [RFC PATCH 15/20] Introduce FT mode support to configure.

2010-04-22 Thread Anthony Liguori
On 04/21/2010 12:57 AM, Yoshiaki Tamura wrote: Signed-off-by: Yoshiaki Tamuratamura.yoshi...@lab.ntt.co.jp No need for this. Regards, Anthony Liguori --- configure |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/configure b/configure index

[Qemu-devel] Re: [RFC PATCH 19/20] Insert do_event_tap() to virtio-{blk, net}, comment out assert() on cpu_single_env temporally.

2010-04-22 Thread Anthony Liguori
On 04/21/2010 12:57 AM, Yoshiaki Tamura wrote: do_event_tap() is inserted to functions which actually fire outputs. By synchronizing VMs before outputs are fired, we can failover to the receiver upon failure. To save VM continuously, comment out assert() on cpu_single_env temporally.

Re: [Qemu-devel] [PATCH 2/2] target-ppc: fix interrupt vectors for MPC603 and e300

2010-04-22 Thread Hollis Blanchard
On Wed, Apr 21, 2010 at 5:36 AM, Alexander Graf ag...@suse.de wrote: Thomas Monjalon wrote: Alexander Graf wrote: --- a/target-ppc/translate_init.c +++ b/target-ppc/translate_init.c @@ -2853,7 +2853,16 @@ static void init_excp_603 (CPUPPCState *env)     env-excp_vectors[POWERPC_EXCP_SMI]    

[Qemu-devel] Re: [RFC PATCH 00/20] Kemari for KVM v0.1

2010-04-22 Thread Anthony Liguori
On 04/21/2010 12:57 AM, Yoshiaki Tamura wrote: Hi all, We have been implementing the prototype of Kemari for KVM, and we're sending this message to share what we have now and TODO lists. Hopefully, we would like to get early feedback to keep us in the right direction. Although advanced

Re: [Qemu-devel] [PATCH 0/2] [RFC] 64-bit io paths

2010-04-22 Thread Richard Henderson
On 04/22/2010 12:38 PM, Blue Swirl wrote: Subpages are used when there are several devices on the same page. It's needed for at least Sparc32. That's fine. Subwidth (with NULL) is used mainly to indicate that the device does not accept accesses in some access widths. Sparc32 and Sparc64 need

Re: [Qemu-devel] Locking block devices for concurrent access?

2010-04-22 Thread Michael Tokarev
22.04.2010 23:21, Richard W.M. Jones wrote: On Thu, Apr 22, 2010 at 01:36:30PM -0500, Anthony Liguori wrote: I think we got to the point where there was general agreement on the usefulness of lock=read|write but where there was still some contention was on this whole notion of

Re: [Qemu-devel] [PATCH 0/2] [RFC] 64-bit io paths

2010-04-22 Thread Blue Swirl
On 4/22/10, Richard Henderson r...@twiddle.net wrote: On 04/22/2010 12:38 PM, Blue Swirl wrote: Subpages are used when there are several devices on the same page. It's needed for at least Sparc32. That's fine. Subwidth (with NULL) is used mainly to indicate that the device does

Re: [Qemu-devel] virtio block device and sysfs

2010-04-22 Thread Marc Haber
Hi, On Mon, Mar 22, 2010 at 10:22:14AM -0400, john cooper wrote: Marc Haber wrote: On Tue, Mar 09, 2010 at 03:34:07PM -0600, Anthony Liguori wrote: On 03/06/2010 04:42 PM, Marc Haber wrote: My goal is to have a possibility to give a speaking name to any block device handed into a guest

Re: [Qemu-devel] virtio block device and sysfs

2010-04-22 Thread Marc Haber
Hi, On Mon, Mar 22, 2010 at 03:14:48PM +, Paul Brook wrote: John attempted this and it was reverted because the implementation exhausted the PCI config space. I don't understand that. Existig hardware devices dump much more of their data such as vendor and model type information

Re: [Qemu-devel] [RFC PATCH 00/20] Kemari for KVM v0.1

2010-04-22 Thread Anthony Liguori
On 04/22/2010 08:16 AM, Yoshiaki Tamura wrote: 2010/4/22 Dor Laordl...@redhat.com: On 04/22/2010 01:35 PM, Yoshiaki Tamura wrote: Dor Laor wrote: On 04/21/2010 08:57 AM, Yoshiaki Tamura wrote: Hi all, We have been implementing the prototype of Kemari for KVM, and

Re: [Qemu-devel] [RFC PATCH 00/20] Kemari for KVM v0.1

2010-04-22 Thread Dor Laor
On 04/22/2010 04:16 PM, Yoshiaki Tamura wrote: 2010/4/22 Dor Laordl...@redhat.com: On 04/22/2010 01:35 PM, Yoshiaki Tamura wrote: Dor Laor wrote: On 04/21/2010 08:57 AM, Yoshiaki Tamura wrote: Hi all, We have been implementing the prototype of Kemari for KVM, and we're sending this

Re: [Qemu-devel] virtio block device and sysfs

2010-04-22 Thread john cooper
Marc Haber wrote: Hi, On Mon, Mar 22, 2010 at 10:22:14AM -0400, john cooper wrote: Marc Haber wrote: It the serial number can be alphanumeric, that would be great to have. It is simply a string of 20 characters, which AFAICT has its roots in the ATA S/N convention along with many other

Re: [Qemu-devel] [PATCH 2/2] VirtIO RNG

2010-04-22 Thread Jamie Lokier
Ian Molton wrote: It might make sense to have the reconnect logic in the egd chardev backend then, thereby obsoleting the socket reconnect patch. Im not sure I agree there... surely there are other things which would benefit from generic socket reconnection support (virtio-rng cant be the

Re: [Qemu-devel] [PATCH 0/2] [RFC] 64-bit io paths

2010-04-22 Thread Richard Henderson
On 04/22/2010 01:01 PM, Blue Swirl wrote: This is also fine. Although by using NULL all you'd get is a qemu null pointer dereference; I suppose this might get caught and translated to an cpu exception, but I think it would be preferable long-term to be more explicit about this and fill in

[Qemu-devel] Commit 9c9bb6c89d4 breaks code execution from flash

2010-04-22 Thread Michael Walle
Hi Jan, your commit Optimize consecutive CFI02 writes by remapping memory lazily breaks the code execution from flash. If you write to the flash, the flash will switch into I/O mode. Now if code is executed from this flash, a cpu_abort will be raised (Trying to execute code outside RAM or

[Qemu-devel] [PATCH 0/2] cmd646: amend bmdma issue fix

2010-04-22 Thread Igor V. Kovalenko
Hi! The following series are not picked from mailing list, so this is a resend. Short history is that original fix for cmd646 bmdma issue was done by reverting pci_dev removal from driver. That was a quick workaround and later Juan was kind enough to improve driver code. Patches on the list: -

[Qemu-devel] [PATCH 1/2] cmd646: pass pci_dev as it needs it

2010-04-22 Thread Igor V. Kovalenko
From: Igor V. Kovalenko igor.v.kovale...@gmail.com Instead of doing tricks to get the pci_dev, just pass it in the 1st place. Patch is a bit longer that reverting the pci_dev field, but it states more clearly (IMHO) what we are doing. It also fixes the bm test, now that you told me that -unit

[Qemu-devel] [PATCH 2/2] cmd646: fix abort due to changed opaque pointer for ioport read

2010-04-22 Thread Igor V. Kovalenko
From: Igor V. Kovalenko igor.v.kovale...@gmail.com We cannot install different opaque pointer for read and write of the same i/o address. - handle zero address in bmdma_writeb_common and install the same opaque pointer for both read and write access. Signed-off-by: Igor V. Kovalenko

[Qemu-devel] [PATCH 1/2] QError: vl.c messages

2010-04-22 Thread Leandro Dorileo
Added new messages to be used(initially) on vl.c Signed-off-by: Leandro Dorileo ldori...@gmail.com --- qerror.c | 33 + qerror.h | 18 ++ 2 files changed, 51 insertions(+), 0 deletions(-) diff --git a/qerror.c b/qerror.c index 8d885cd..92c8047

[Qemu-devel] [PATCH 2/2] QError: vl.c drive_init porting

2010-04-22 Thread Leandro Dorileo
Port of vl.c drive_init to QError API. Signed-off-by: Leandro Dorileo ldori...@gmail.com --- vl.c | 39 +-- 1 files changed, 17 insertions(+), 22 deletions(-) diff --git a/vl.c b/vl.c index e58441b..5be8516 100644 --- a/vl.c +++ b/vl.c @@ -853,31 +853,29 @@

[Qemu-devel] [PATCH] Remove IO_MEM_SUBWIDTH.

2010-04-22 Thread Richard Henderson
Greatly simplify the subpage implementation by not supporting multiple devices at the same address at different widths. We don't need full copies of mem_read/mem_write/opaque for each address, only a single index back into the main io_mem_* arrays. Signed-off-by: Richard Henderson

Re: [Qemu-devel] [RFC PATCH 00/20] Kemari for KVM v0.1

2010-04-22 Thread Yoshiaki Tamura
Jamie Lokier wrote: Yoshiaki Tamura wrote: Dor Laor wrote: On 04/21/2010 08:57 AM, Yoshiaki Tamura wrote: Event tapping is the core component of Kemari, and it decides on which event the primary should synchronize with the secondary. The basic assumption here is that outgoing I/O operations

[Qemu-devel] [PATCH] linux-user: Remove ELFLOAD32.

2010-04-22 Thread Richard Henderson
The ABI-specific types used by linux_binprm and image_info are different after forcing TARGET_ABI32 on. Which means that the parameters that load_elf_binary_multi sees are not those that loader_exec passed. This is inherently broken and is more trouble than it's worth fixing. Signed-off-by:

[Qemu-devel] [PATCH]Make sd card spi mode to support write operation

2010-04-22 Thread 乔崇
0001-accroding-sdcard-spi-protocal-should-at-least-wait-8.patch: accroding sdcard spi protocal,should at least wait 8 spi clk,before response. 0002-make-sd-card-spi-mode-to-support-write.patch make sd card spi mode to support write. -- 乔崇 qiaochong.ac.cn 龙芯技术服务中心 office:010-62600855-108

[Qemu-devel] Re: [RFC PATCH 00/20] Kemari for KVM v0.1

2010-04-22 Thread Yoshiaki Tamura
Anthony Liguori wrote: On 04/21/2010 12:57 AM, Yoshiaki Tamura wrote: Hi all, We have been implementing the prototype of Kemari for KVM, and we're sending this message to share what we have now and TODO lists. Hopefully, we would like to get early feedback to keep us in the right direction.

Re: [Qemu-devel] [RFC PATCH 00/20] Kemari for KVM v0.1

2010-04-22 Thread Yoshiaki Tamura
Anthony Liguori wrote: On 04/22/2010 08:16 AM, Yoshiaki Tamura wrote: 2010/4/22 Dor Laordl...@redhat.com: On 04/22/2010 01:35 PM, Yoshiaki Tamura wrote: Dor Laor wrote: On 04/21/2010 08:57 AM, Yoshiaki Tamura wrote: Hi all, We have been implementing the prototype of Kemari for KVM, and

[Qemu-devel] Re: [RFC PATCH 01/20] Modify DIRTY_FLAG value and introduce DIRTY_IDX to use as indexes of bit-based phys_ram_dirty.

2010-04-22 Thread Yoshiaki Tamura
Anthony Liguori wrote: Hi, On 04/21/2010 12:57 AM, Yoshiaki Tamura wrote: Replaces byte-based phys_ram_dirty bitmap with four (MASTER, VGA, CODE, MIGRATION) bit-based phys_ram_dirty bitmap. On allocation, it sets all bits in the bitmap. It uses ffs() to convert DIRTY_FLAG to DIRTY_IDX.

[Qemu-devel] Re: [RFC PATCH 15/20] Introduce FT mode support to configure.

2010-04-22 Thread Yoshiaki Tamura
Anthony Liguori wrote: On 04/21/2010 12:57 AM, Yoshiaki Tamura wrote: Signed-off-by: Yoshiaki Tamuratamura.yoshi...@lab.ntt.co.jp No need for this. OK. Regards, Anthony Liguori --- configure | 8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/configure

[Qemu-devel] Re: [RFC PATCH 14/20] Upgrade QEMU_FILE_VERSION from 3 to 4, and introduce qemu_savevm_state_all().

2010-04-22 Thread Yoshiaki Tamura
Anthony Liguori wrote: On 04/21/2010 12:57 AM, Yoshiaki Tamura wrote: Make a 32bit entry after QEMU_VM_FILE_VERSION to recognize whether the transfered data is QEMU_VM_FT_MODE or QEMU_VM_LIVE_MIGRATION_MODE. I'd rather you encapsulate the current protocol as opposed to extending it with a new

[Qemu-devel] Re: [RFC PATCH 05/20] Introduce put_vector() and get_vector to QEMUFile and qemu_fopen_ops().

2010-04-22 Thread Yoshiaki Tamura
Anthony Liguori wrote: On 04/21/2010 12:57 AM, Yoshiaki Tamura wrote: QEMUFile currently doesn't support writev(). For sending multiple data, such as pages, using writev() should be more efficient. Signed-off-by: Yoshiaki Tamuratamura.yoshi...@lab.ntt.co.jp Is there performance data that

[Qemu-devel] Re: [RFC PATCH 07/20] Introduce qemu_put_vector() and qemu_put_vector_prepare() to use put_vector() in QEMUFile.

2010-04-22 Thread Yoshiaki Tamura
Anthony Liguori wrote: On 04/21/2010 12:57 AM, Yoshiaki Tamura wrote: For fool proof purpose, qemu_put_vector_parepare should be called before qemu_put_vector. Then, if qemu_put_* functions except this is called after qemu_put_vector_prepare, program will abort(). Signed-off-by: Yoshiaki

[Qemu-devel] Qemu Development

2010-04-22 Thread Ehsan Ul haq
Hi, I am new to Qemu development,I want to know how can I open Qemu source code as a complete project.How can I add new features in Qemu source code. Thanks,

[Qemu-devel] Re: [RFC PATCH 10/20] Introduce skip_header parameter to qemu_loadvm_state() so that it can be called iteratively without reading the header.

2010-04-22 Thread Yoshiaki Tamura
Anthony Liguori wrote: On 04/21/2010 12:57 AM, Yoshiaki Tamura wrote: Signed-off-by: Yoshiaki Tamuratamura.yoshi...@lab.ntt.co.jp I think the more appropriate thing to do is have qemu_savevm_state_complete() not write QEMU_VM_EOF when doing a continuous live migration. You would then want

[Qemu-devel] Re: [RFC PATCH 19/20] Insert do_event_tap() to virtio-{blk, net}, comment out assert() on cpu_single_env temporally.

2010-04-22 Thread Yoshiaki Tamura
Anthony Liguori wrote: On 04/21/2010 12:57 AM, Yoshiaki Tamura wrote: do_event_tap() is inserted to functions which actually fire outputs. By synchronizing VMs before outputs are fired, we can failover to the receiver upon failure. To save VM continuously, comment out assert() on cpu_single_env

[Qemu-devel] One more thing about block device locking

2010-04-22 Thread Michael Tokarev
While I'm reviewing a thread about block device locking, here's another data point which were not touched before, as far as I remember. It is related. What I'm talking is - when fsck/mkfs/... family of programs are run against a mounted (or in use by other means) device, they warn you about

Re: [Qemu-devel] [RFC PATCH 00/20] Kemari for KVM v0.1

2010-04-22 Thread Yoshiaki Tamura
Dor Laor wrote: On 04/22/2010 04:16 PM, Yoshiaki Tamura wrote: 2010/4/22 Dor Laordl...@redhat.com: On 04/22/2010 01:35 PM, Yoshiaki Tamura wrote: Dor Laor wrote: On 04/21/2010 08:57 AM, Yoshiaki Tamura wrote: Hi all, We have been implementing the prototype of Kemari for KVM, and we're