Re: [Qemu-devel] Re: QEMU-KVM and video performance

2010-05-12 Thread Gerhard Wiesinger
On Mon, 10 May 2010, Avi Kivity wrote: On 05/09/2010 10:35 PM, Gerhard Wiesinger wrote: For 256 color more the first priority is to find out why direct mapping is not used. I'd suggest tracing the code that makes this decision (in hw/*vga.c) and seeing if it's right or not. I think

Re: [Qemu-devel] [RFC][MIPS][PATCH 3/6] Initial support of VIA IDE controller used by fulong mini pc

2010-05-12 Thread Markus Armbruster
Blue Swirl blauwir...@gmail.com writes: On 5/11/10, Markus Armbruster arm...@redhat.com wrote: Blue Swirl blauwir...@gmail.com writes: On 5/9/10, chen huacai zltjiang...@gmail.com wrote: This patch add initial support of VIA IDE controller used by fulong mini pc Signed-off-by:

[Qemu-devel] [PATCH 0/6] MIPS: Initial support for fulong (Loongson-2E based) mini pc.

2010-05-12 Thread chen huacai
This series of patches are for qemu master branch. They make qemu initially support fulong (Loongson-2E based) mini pc, a new type of MIPS machine. Usage: 1, Load PMON as bios, and then load OS in PMON shell qemu-system-mips64el -M fulong2e -bios pmon_fulong2e.bin -hda /root/hda.img 2,

Re: [Qemu-devel] [PATCH 0/2] Enable qemu block layer to not flush

2010-05-12 Thread Stefan Hajnoczi
Why add a nop AIO operation instead of setting BlockDriverState-enable_write_cache to zero? In that case no write cache would be reported to the guest (just like cache=writethrough). Stefan

[Qemu-devel] [PATCH 1/6] MIPS: Initial support of bonito north bridge used by fulong mini pc

2010-05-12 Thread chen huacai
Signed-off-by: Huacai Chen zltjiang...@gmail.com --- Makefile.target |1 + default-configs/mips64el-softmmu.mak |1 + hw/bonito.c | 950 ++ hw/mips.h|3 + 4 files changed, 955

[Qemu-devel] [PATCH v2 0/2] Drop pci_add and pci_del from QMP

2010-05-12 Thread Markus Armbruster
See PATCH 1/1 for rationale. v2: Cover pci_del, better commit message, rebased (no conflicts) Markus Armbruster (2): Revert PCI: Convert pci_device_hot_add() to QObject Revert monitor: Convert do_pci_device_hot_remove() to QObject hw/pci-hotplug.c | 51

[Qemu-devel] [PATCH v2 2/2] Revert monitor: Convert do_pci_device_hot_remove() to QObject

2010-05-12 Thread Markus Armbruster
We don't want pci_del in QMP. Use device_del instead. This reverts commit 6848d827162fea039f2658414a4adb6164a4f9b0. Conflicts: hw/pci-hotplug.c sysemu.h Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/pci-hotplug.c |5 ++--- qemu-monitor.hx |3 +-- sysemu.h

[Qemu-devel] [PATCH v2 1/2] Revert PCI: Convert pci_device_hot_add() to QObject

2010-05-12 Thread Markus Armbruster
Short story: We don't want pci_add in QMP. Long story follows. pci_add can do two things: * Hot plug a PCI NIC. device_add is more general. * Hot plug a PCI disk controller, and a drive connected to it. The controller is either virtio-blk-pci (if=virtio) or lsi53c895a (if=scsi). With

[Qemu-devel] [PATCH 3/6] MIPS: Initial support of VIA IDE controller used by fulong mini pc

2010-05-12 Thread chen huacai
Signed-off-by: Huacai Chen zltjiang...@gmail.com --- Makefile.objs|1 + default-configs/mips64el-softmmu.mak |1 + hw/ide.h |1 + hw/ide/via.c | 185 ++ 4 files changed, 188

[Qemu-devel] [PATCH 2/6] MIPS: Initial support of vt82686b south bridge used by fulong mini pc

2010-05-12 Thread chen huacai
Signed-off-by: Huacai Chen zltjiang...@gmail.com --- Makefile.target |2 +- hw/pc.h |7 + hw/pci_ids.h|8 + hw/vt82c686.c | 786 +++ 4 files changed, 802 insertions(+), 1 deletions(-) create mode 100644 hw/vt82c686.c

[Qemu-devel] [PATCH 4/6] MIPS: Initial support of VIA USB controller used by fulong mini pc

2010-05-12 Thread chen huacai
Signed-off-by: Huacai Chen zltjiang...@gmail.com --- hw/usb-uhci.c | 30 ++ hw/usb-uhci.h |1 + 2 files changed, 31 insertions(+), 0 deletions(-) diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c index 624d55b..5fd5388 100644 --- a/hw/usb-uhci.c +++ b/hw/usb-uhci.c @@

Re: [Qemu-devel] [PATCH 0/2] Enable qemu block layer to not flush

2010-05-12 Thread Jamie Lokier
Stefan Hajnoczi wrote: Why add a nop AIO operation instead of setting BlockDriverState-enable_write_cache to zero? In that case no write cache would be reported to the guest (just like cache=writethrough). Hmm. If the guest sees write cache absent, that prevents changing the cache policy on

[Qemu-devel] Re: Commit 9c9bb6c89d4 breaks code execution from flash

2010-05-12 Thread Jan Kiszka
Michael Walle wrote: [sorry didn't see the CC to the mailinglist] Am Friday 23 April 2010 09:23:49 schrieb Jan Kiszka: Michael Walle wrote: Hi Jan, your commit Optimize consecutive CFI02 writes by remapping memory lazily breaks the code execution from flash. If you write to the flash,

[Qemu-devel] Re: [PATCHv2] Support for booting from virtio disks

2010-05-12 Thread Avi Kivity
On 05/11/2010 03:31 PM, Gleb Natapov wrote: On Tue, May 11, 2010 at 11:19:07AM +0300, Avi Kivity wrote: On 05/10/2010 06:48 PM, Anthony Liguori wrote: On 05/10/2010 03:11 AM, Gleb Natapov wrote: This patch adds native support for booting from virtio disks to Seabios.

[Qemu-devel] Re: [PATCHv2] Support for booting from virtio disks

2010-05-12 Thread Gleb Natapov
On Wed, May 12, 2010 at 10:22:59AM +0300, Avi Kivity wrote: On 05/11/2010 03:31 PM, Gleb Natapov wrote: On Tue, May 11, 2010 at 11:19:07AM +0300, Avi Kivity wrote: On 05/10/2010 06:48 PM, Anthony Liguori wrote: On 05/10/2010 03:11 AM, Gleb Natapov wrote: This patch adds native support for

Re: [Qemu-devel] Re: [PATCH 2/2] Add flush=off parameter to -drive

2010-05-12 Thread Jamie Lokier
Paul Brook wrote: Paul Brook wrote: cache=none: No host caching. Reads and writes both go directly to underlying storage. Useful to avoid double-caching. cache=writethrough Reads are cached. Writes go directly to underlying storage. Useful for

Re: [Qemu-devel] Re: QEMU-KVM and video performance

2010-05-12 Thread Jamie Lokier
Gerhard Wiesinger wrote: On Wed, 21 Apr 2010, Jamie Lokier wrote: Gerhard Wiesinger wrote: Hmmm. I'm very new to QEMU and KVM but at least accessing the virtual HW of QEMU even from KVM must be possible (e.g. memory and port accesses are done on nearly every virtual device) and therefore

[Qemu-devel] [PATCH] doc: Update info blockstats, qdm, and roms

2010-05-12 Thread Stefan Hajnoczi
The info blockstats documentation was copy-pasted as info block instead of info blockstats. The documentation for info qdm and info roms is missing. This patch resolves these issues in qemu-monitor.hx. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- qemu-monitor.hx |6 +-

[Qemu-devel] [RFC PATCH 1/2] close all the block drivers before the qemu process exits

2010-05-12 Thread MORITA Kazutaka
This patch calls the close handler of the block driver before the qemu process exits. This is necessary because the sheepdog block driver releases the lock of VM images in the close handler. Signed-off-by: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp --- block.c | 11 +++ block.h

[Qemu-devel] [RFC PATCH 0/2] Sheepdog: distributed storage system for QEMU

2010-05-12 Thread MORITA Kazutaka
Hi all, This patch adds a block driver for Sheepdog distributed storage system. Please consider for inclusion. Sheepdog is a distributed storage system for QEMU. It provides highly available block level storage volumes to VMs like Amazon EBS. Sheepdog features are: - No node in the cluster is

[Qemu-devel] [RFC PATCH 2/2] block: add sheepdog driver for distributed storage support

2010-05-12 Thread MORITA Kazutaka
Sheepdog is a distributed storage system for QEMU. It provides highly available block level storage volumes to VMs like Amazon EBS. This patch adds a qemu block driver for Sheepdog. Sheepdog features are: - No node in the cluster is special (no metadata node, no control node, etc) - Linear

Re: [Qemu-devel] Re: QEMU-KVM and video performance

2010-05-12 Thread Avi Kivity
On 05/12/2010 09:14 AM, Gerhard Wiesinger wrote: On Mon, 10 May 2010, Avi Kivity wrote: On 05/09/2010 10:35 PM, Gerhard Wiesinger wrote: For 256 color more the first priority is to find out why direct mapping is not used. I'd suggest tracing the code that makes this decision (in

Re: [Qemu-devel] [PATCH] doc: Update info blockstats, qdm, and roms

2010-05-12 Thread Markus Armbruster
Stefan Hajnoczi stefa...@linux.vnet.ibm.com writes: The info blockstats documentation was copy-pasted as info block instead of info blockstats. The documentation for info qdm and info roms is missing. This patch resolves these issues in qemu-monitor.hx. Signed-off-by: Stefan Hajnoczi

Re: [Qemu-devel] [RFC][MIPS][PATCH 1/6] Initial support of bonito north bridge used by fulong mini pc

2010-05-12 Thread yajin
Bonito north bridge is built on FPGA now, VENDOR_ID/DEVICE_ID are  temporary value so I didn't put them in pci_ids.h In that case, perhaps the code should be committed after the design has stabilized a bit more? In fact, the FPGA north bridge is very stable. It has been shipped in many

Re: [Qemu-devel] [RFC PATCH 0/2] Sheepdog: distributed storage system for QEMU

2010-05-12 Thread Kevin Wolf
Am 12.05.2010 12:46, schrieb MORITA Kazutaka: Hi all, This patch adds a block driver for Sheepdog distributed storage system. Please consider for inclusion. Sheepdog is a distributed storage system for QEMU. It provides highly available block level storage volumes to VMs like Amazon

[Qemu-devel] [PATCH] block: Remove special case for vvfat

2010-05-12 Thread Kevin Wolf
The special case doesn't really us buy anything. Without it vvfat works more consistently as a protocol. We get raw on top of vvfat now, which works just as well as using vvfat directly. Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c |5 - 1 files changed, 0 insertions(+), 5

[Qemu-devel] Re: Another SIGFPE in display code, now in cirrus

2010-05-12 Thread Stefano Stabellini
On Mon, 10 May 2010, Avi Kivity wrote: On 05/10/2010 10:41 AM, Avi Kivity wrote: On 05/06/2010 11:07 PM, Michael Tokarev wrote: There was a bug recently fixed in vnc code. Apparently there's something similar in the cirrus emulation as well. Here it triggers _always_ (including old

[Qemu-devel] Re: Another SIGFPE in display code, now in cirrus

2010-05-12 Thread Avi Kivity
On 05/12/2010 03:20 PM, Stefano Stabellini wrote: On Mon, 10 May 2010, Avi Kivity wrote: On 05/10/2010 10:41 AM, Avi Kivity wrote: On 05/06/2010 11:07 PM, Michael Tokarev wrote: There was a bug recently fixed in vnc code. Apparently there's something similar in the cirrus

Re: [Qemu-devel] [PATCH 0/2] Enable qemu block layer to not flush

2010-05-12 Thread Jamie Lokier
Stefan Hajnoczi wrote: On Wed, May 12, 2010 at 10:42 AM, Jamie Lokier ja...@shareable.org wrote: Stefan Hajnoczi wrote: Why add a nop AIO operation instead of setting BlockDriverState-enable_write_cache to zero?  In that case no write cache would be reported to the guest (just like

[Qemu-devel] Re: [PATCHv2] Support for booting from virtio disks

2010-05-12 Thread Kevin O'Connor
On Wed, May 12, 2010 at 10:22:59AM +0300, Avi Kivity wrote: On 05/11/2010 03:31 PM, Gleb Natapov wrote: Real BIOS can do that because it enumerates all bootable devices, attach name for each one of them and then asks user to configure boot order using names it attached to devices. In our case

[Qemu-devel] [PATCH 1/2] Use ram_bytes_remaining() where possible

2010-05-12 Thread Pierre Riteau
Signed-off-by: Pierre Riteau pierre.rit...@irisa.fr --- arch_init.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch_init.c b/arch_init.c index cfc03ea..cf6b7b0 100644 --- a/arch_init.c +++ b/arch_init.c @@ -235,7 +235,7 @@ int ram_save_live(Monitor *mon, QEMUFile

[Qemu-devel] [PATCH 2/2] migration: Fix calculation of bytes_transferred

2010-05-12 Thread Pierre Riteau
When a page with all identical bytes is transferred, it is counted as a full page (TARGET_PAGE_SIZE) although only one byte is actually sent. Fix this by changing ram_save_block() to return the number of bytes sent instead of a boolean value. This makes bandwidth estimation, and consequently

[Qemu-devel] Qemu-KVM with 3x IDE HDD + CDROM not working

2010-05-12 Thread Peter Lieven
Hi Qemu/KVM Devel Team, if I create a VM with more than 2 harddisks and a CDROM Image and want to boot from CDROM this is not working. From my understanding at least 3 IDE Drives + 1 IDE CDROM should work. cmdline: /usr/bin/qemu-kvm-0.12.4 -net none -drive

Re: [Qemu-devel] Re: Qemu-KVM Livate Migration 0.12.2 - 0.12.3/4 broken?

2010-05-12 Thread Peter Lieven
Hi, I can confirm that reverting this patch makes Live Migration from 0.12.2 to 0.12.4 again possible. Br, Peter Juan Quintela wrote: Peter Lieven p...@dlh.net wrote: Hi Qemu/KVM Devel Team, Live Migration from a 0.12.2 qemu-kvm to a 0.12.3 (and 0.12.4) does not work: load of migration

qemu-kvm hangs if multipath device is queing (was: Re: [Qemu-devel] Qemu-KVM 0.12.3 and Multipath - Assertion)

2010-05-12 Thread Peter Lieven
Hi Kevin, here we go. I created a blocking multipath device (interrupted all paths). qemu-kvm hangs with 100% cpu. also monitor is not responding. If I restore at least one path, the vm is continueing. BR, Peter ^C Program received signal SIGINT, Interrupt. 0x7fd8a6aaea94 in

Re: [Qemu-devel] [RFC PATCH 1/2] close all the block drivers before the qemu process exits

2010-05-12 Thread Christoph Hellwig
On Wed, May 12, 2010 at 07:46:52PM +0900, MORITA Kazutaka wrote: This patch calls the close handler of the block driver before the qemu process exits. This is necessary because the sheepdog block driver releases the lock of VM images in the close handler. Signed-off-by: MORITA Kazutaka

[Qemu-devel] [PATCH v2] doc: Update monitor info subcommands

2010-05-12 Thread Stefan Hajnoczi
The info blockstats documentation was copy-pasted as info block instead of info blockstats. The documentation for commands, jit, numa, qdm, and roms is missing. This patch resolves these issues in qemu-monitor.hx. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- v2: * commands,

[Qemu-devel] Re: Another SIGFPE in display code, now in cirrus

2010-05-12 Thread Avi Kivity
On 05/12/2010 04:45 PM, Stefano Stabellini wrote: Note it's just during mode changes. During normal operation I'm sure the pitches are equal. The source blt pitch as set by the driver is always equal to the display pitch (apart from the case reported above). However

[Qemu-devel] [PATCH 2/3 v2] dmg: use pread

2010-05-12 Thread Christoph Hellwig
Use pread instead of lseek + read in preparation of using the qemu block API. Note that dmg actually uses the implicit file offset a lot in dmg_open, and we had to replace it with an offset variable. Signed-off-by: Christoph Hellwig h...@lst.de Index: qemu-kevin/block/dmg.c

[Qemu-devel] Re: [RFC PATCH 1/2] close all the block drivers before the qemu process exits

2010-05-12 Thread Avi Kivity
On 05/12/2010 01:46 PM, MORITA Kazutaka wrote: This patch calls the close handler of the block driver before the qemu process exits. This is necessary because the sheepdog block driver releases the lock of VM images in the close handler. How do you handle abnormal termination? -- Do not

[Qemu-devel] [PATCH 3/3 v2] dmg: use qemu block API

2010-05-12 Thread Christoph Hellwig
Use bdrv_pwrite to access the backing device instead of pread, and convert the driver to implementing the bdrv_open method which gives it an already opened BlockDriverState for the underlying device. Dmg actually does an lseek to a negative offset in the open routine, which we replace with offset

Re: [Qemu-devel] [PATCH] doc: Update info blockstats, qdm, and roms

2010-05-12 Thread Stefan Hajnoczi
On Wed, May 12, 2010 at 12:16 PM, Markus Armbruster arm...@redhat.com wrote: A few more items are still missing: commands (QMP only, it's a no-op in the human monitor, I hate that), jit, numa.  Would you mind documenting as well? Resent as v2 with commands, jit, and numa added. Stefan

[Qemu-devel] Re: [PATCH 3/3] target-sparc: Inline some generation of carry for ADDX/SUBX.

2010-05-12 Thread Richard Henderson
The new code doesn't update dc-cc_op, shouldn't that happen if the condition codes are changed? For example 'addx' in the sequence 'addcc; addxcc; addx;' should need the C flag from the second addxcc, not from first addcc. Oops, yes, that needs updating too. Will fix. r~

Re: [Qemu-devel] [PATCH v2] doc: Update monitor info subcommands

2010-05-12 Thread Markus Armbruster
Stefan Hajnoczi stefa...@linux.vnet.ibm.com writes: The info blockstats documentation was copy-pasted as info block instead of info blockstats. The documentation for commands, jit, numa, qdm, and roms is missing. This patch resolves these issues in qemu-monitor.hx. Looks good, thanks!

Re: [Qemu-devel] [PATCH 2/3] target-sparc: Simplify ICC generation; fix ADDX carry generation.

2010-05-12 Thread Richard Henderson
On 05/11/2010 02:31 PM, Artyom Tarasenko wrote: Nack. It looks like you reverted carry generation to the previous (broken) behavior. Oh? I suppose I should go back and look at the logs, but the way it's written there sure seems to match 5.1.5.1 of the sparcv9 manual: You'll only get carry into

[Qemu-devel] Re: [PATCH] virtio-serial-bus: fix ports_map allocation on init

2010-05-12 Thread Amit Shah
On (Wed) May 12 2010 [17:50:02], Alon Levy wrote: Fix for too small allocation to ports_map Signed-off-by: Alon Levy al...@redhat.com ACK Amit

Re: [Qemu-devel] [PATCH 2/3] target-sparc: Simplify ICC generation; fix ADDX carry generation.

2010-05-12 Thread Richard Henderson
On 05/11/2010 02:31 PM, Artyom Tarasenko wrote: Nack. It looks like you reverted carry generation to the previous (broken) behavior. Perhaps you could point out the change I'm reverting? I don't see any change to the actual computation of the flags since

[Qemu-devel] Re: [PATCH 2/2] Add flush=off parameter to -drive

2010-05-12 Thread Alexander Graf
Kevin Wolf wrote: Am 10.05.2010 23:51, schrieb Alexander Graf: Usually the guest can tell the host to flush data to disk. In some cases we don't want to flush though, but try to keep everything in cache. So let's add a new parameter to -drive that allows us to set the flushing behavior

Re: [Qemu-devel] [PATCH 2/3] target-sparc: Simplify ICC generation; fix ADDX carry generation.

2010-05-12 Thread Artyom Tarasenko
2010/5/12 Richard Henderson r...@twiddle.net: On 05/11/2010 02:31 PM, Artyom Tarasenko wrote: Nack. It looks like you reverted carry generation to the previous (broken) behavior. Oh?  I suppose I should go back and look at the logs, but the way it's written there sure seems to match 5.1.5.1

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-12 Thread Cam Macdonell
On Tue, May 11, 2010 at 12:13 PM, Avi Kivity a...@redhat.com wrote: On 05/11/2010 08:05 PM, Anthony Liguori wrote: On 05/11/2010 11:39 AM, Cam Macdonell wrote: Most of the people I hear from who are using my patch are using a peer model to share data between applications (simulations, JVMs,

[Qemu-devel] Re: [PATCH 2/2] Add flush=off parameter to -drive

2010-05-12 Thread Kevin Wolf
Am 12.05.2010 17:05, schrieb Alexander Graf: Kevin Wolf wrote: Am 10.05.2010 23:51, schrieb Alexander Graf: Usually the guest can tell the host to flush data to disk. In some cases we don't want to flush though, but try to keep everything in cache. So let's add a new parameter to -drive

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-12 Thread Avi Kivity
On 05/12/2010 06:32 PM, Cam Macdonell wrote: We can tunnel its migration data through qemu. Of course, gathering its dirty bitmap will be interesting. DSM may be the way to go here (we can even live migrate qemu through DSM: share the guest address space and immediately start running on the

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-12 Thread Avi Kivity
On 05/10/2010 07:48 PM, Cam Macdonell wrote: On Mon, May 10, 2010 at 10:40 AM, Avi Kivitya...@redhat.com wrote: On 05/10/2010 06:41 PM, Cam Macdonell wrote: What would happen to any data written to the BAR before the the handshake completed? I think it would disappear.

[Qemu-devel] Re: [PATCH 2/2] Add flush=off parameter to -drive

2010-05-12 Thread Alexander Graf
Am 12.05.2010 um 17:36 schrieb Kevin Wolf kw...@redhat.com: Am 12.05.2010 17:05, schrieb Alexander Graf: Kevin Wolf wrote: Am 10.05.2010 23:51, schrieb Alexander Graf: Usually the guest can tell the host to flush data to disk. In some cases we don't want to flush though, but try to keep

[Qemu-devel] Re: Another SIGFPE in display code, now in cirrus

2010-05-12 Thread Stefano Stabellini
On Wed, 12 May 2010, Avi Kivity wrote: I suggest to start using the display pitch (with the proper sign) instead of cirrus_blt_srcpitch in cirrus_do_copy at least when cirrus_blt_srcpitch doesn't have a proper value. Why switch from one bug to the other? It's perfectly possible

[Qemu-devel] Re: [PATCH 1/6] MIPS: Initial support of bonito north bridge used by fulong mini pc

2010-05-12 Thread Stefan Weil
Am 12.05.2010 10:50, schrieb chen huacai: Signed-off-by: Huacai Chenzltjiang...@gmail.com --- Makefile.target |1 + default-configs/mips64el-softmmu.mak |1 + hw/bonito.c | 950 ++ hw/mips.h

Re: [Qemu-devel] Re: Webcam solution for QEMU

2010-05-12 Thread David Ahern
On 05/09/2010 08:28 PM, Natalia Portillo wrote: Hello Arnon, Hola Albert, Wouldn't be easier to implement a custom video capture device? You can always emulate a simple one, like (to say) OV511 webcam, and feed that emulated device with video taken from any V4L2/DirectShow/BDA supported

[Qemu-devel] Re: Another SIGFPE in display code, now in cirrus

2010-05-12 Thread Avi Kivity
On 05/12/2010 06:57 PM, Stefano Stabellini wrote: On Wed, 12 May 2010, Avi Kivity wrote: I suggest to start using the display pitch (with the proper sign) instead of cirrus_blt_srcpitch in cirrus_do_copy at least when cirrus_blt_srcpitch doesn't have a proper value. Why switch

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-12 Thread Cam Macdonell
On Wed, May 12, 2010 at 9:49 AM, Avi Kivity a...@redhat.com wrote: On 05/10/2010 07:48 PM, Cam Macdonell wrote: On Mon, May 10, 2010 at 10:40 AM, Avi Kivitya...@redhat.com  wrote: On 05/10/2010 06:41 PM, Cam Macdonell wrote: What would happen to any data written to the BAR before the

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-12 Thread Avi Kivity
On 05/12/2010 07:14 PM, Cam Macdonell wrote: Why can't we complete initialization before exposing the card and BAR? Seems to be the simplest solution. Looking at it more closely, you're right, the fds for shared memory/eventfds are received in a fraction of a second, so that's why I

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-12 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: One of the most important missing feature in QMP today is its supported commands documentation. The plan is to make it part of self-description support, however self-description is a big task we have been postponing for a long time now and

[Qemu-devel] Re: Another SIGFPE in display code, now in cirrus

2010-05-12 Thread Stefano Stabellini
On Wed, 12 May 2010, Avi Kivity wrote: I guess even a src blt pitch of 0 could be useful there, however in practice I think the only rop function that was written with this case in mind has: dstpitch -= bltwidth; srcpitch -= bltwidth; if (dstpitch 0 || srcpitch 0) { /* is

[Qemu-devel] Re: [PATCH v2 0/2] Drop pci_add and pci_del from QMP

2010-05-12 Thread Luiz Capitulino
On Wed, 12 May 2010 10:52:59 +0200 Markus Armbruster arm...@redhat.com wrote: See PATCH 1/1 for rationale. v2: Cover pci_del, better commit message, rebased (no conflicts) Markus Armbruster (2): Revert PCI: Convert pci_device_hot_add() to QObject Revert monitor: Convert

[Qemu-devel] Re: Another SIGFPE in display code, now in cirrus

2010-05-12 Thread Avi Kivity
On 05/12/2010 07:55 PM, Stefano Stabellini wrote: 3CEh index 26h W(R/W): BLT Source Pitch (5426 +) bit 0-11 (5426-28) Number of bytes in a scanline at the source. 0-12 (5429 +) do if the source BLT is supposed to be the number of bytes in a scanline at

Re: [Qemu-devel] Re: Another SIGFPE in display code, now in cirrus

2010-05-12 Thread Jamie Lokier
Stefano Stabellini wrote: On Wed, 12 May 2010, Avi Kivity wrote: It's useful if you have a one-line horizontal pattern you want to propagate all over. It might be useful all right, but it is not entirely clear what the hardware should do in this situation from the documentation we have,

Re: [Qemu-devel] [PATCH 2/3] target-sparc: Simplify ICC generation; fix ADDX carry generation.

2010-05-12 Thread Richard Henderson
On 05/12/2010 08:18 AM, Artyom Tarasenko wrote: It is last year, but 3e6ba503400c34cbe0f9ad6e289921688bf303a3 The page 108 of the SPARC Version 8 Architecture Manual describes that addcc and addxcc shall compute carry flag the same way. The page 110 claims the same about subcc

Re: [Qemu-devel] [PATCH] [S390] Remove warning in tcg stub (tcg_out_reloc)

2010-05-12 Thread Aurelien Jarno
On Tue, May 11, 2010 at 09:50:34PM +0200, Alexander Graf wrote: Am 11.05.2010 um 19:26 schrieb Richard Henderson r...@twiddle.net: On 05/11/2010 09:47 AM, Stefan Weil wrote: Won't you get another warning about unreachable code because tcg_abort never returns? We don't enable that warning.

[Qemu-devel] [PATCH 1/3] Revert Monitor: Return before exiting with 'quit'

2010-05-12 Thread Luiz Capitulino
This reverts commit 0e8d2b5575938b8876a3c4bb66ee13c5d306fb6d. Next commits will do the same thing in a better way. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c |3 +-- sysemu.h |2 -- vl.c | 18 -- 3 files changed, 1 insertions(+), 22

[Qemu-devel] [PATCH 3/3] Monitor: Return before exiting with 'quit'

2010-05-12 Thread Luiz Capitulino
This is a new version of the (now reverted) following commit: 0e8d2b5575938b8876a3c4bb66ee13c5d306fb6d The 'quit' Monitor command (implemented by do_quit()) calls exit() directly, this is problematic under QMP because QEMU exits before having a chance to send the ok response. Clients don't know

[Qemu-devel] [PATCH 0/3]: Monitor: Better fix for 'quit' return

2010-05-12 Thread Luiz Capitulino
Right after when 0e8d2b55 was merged, Paolo suggested using qemu_system_shutdown_request() instead of adding yet another 'system request' operation. This series implements his suggestion, passes my tests :)

[Qemu-devel] [PATCH 2/3] target-sparc: Simplify ICC generation.

2010-05-12 Thread Richard Henderson
Use int32 types instead of target_ulong when computing ICC. This simplifies the generated code for 32-bit host and 64-bit guest. Use the same simplified expressions for ICC as were already used for XCC in carry flag generation. Simplify the ADD carry generation to not consider a possible

[Qemu-devel] [PATCH 0/3] Fix ADDX compilation plus improvements, v2

2010-05-12 Thread Richard Henderson
Changes v1-v2: * Fix ADDX carry generation properly, i.e. use the previous ADD ICC carry computation for ADDX ICC and XCC. * Tidy PSR generators wrt CODING_STYLE, other minor improvements. * Set CC_OP properly in patch 3. r~ Richard Henderson (3): target-sparc: Fix compilation

[Qemu-devel] [PATCH 3/3] target-sparc: Inline some generation of carry for ADDX/SUBX.

2010-05-12 Thread Richard Henderson
Computing carry is trivial for some inputs. By avoiding an external function call, we generate near-optimal code for the common cases of add+addx (double-word arithmetic) and cmp+addx (a setcc pattern). Signed-off-by: Richard Henderson r...@twiddle.net --- target-sparc/helper.h|2 +-

[Qemu-devel] [PATCH 1/3] target-sparc: Fix compilation with --enable-debug.

2010-05-12 Thread Richard Henderson
Return a target_ulong from compute_C_icc to match the width of the users. Signed-off-by: Richard Henderson r...@twiddle.net --- target-sparc/helper.h|2 +- target-sparc/op_helper.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target-sparc/helper.h

[Qemu-devel] [PATCH 2/3] sysemu: Export 'no_shutdown'

2010-05-12 Thread Luiz Capitulino
It's a global variable already, do_quit() will use it. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- sysemu.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/sysemu.h b/sysemu.h index fcfccdf..58c9733 100644 --- a/sysemu.h +++ b/sysemu.h @@ -128,6 +128,7 @@

[Qemu-devel] [PATCH] block/vdi: Fix image opening and creation for odd disk sizes

2010-05-12 Thread Stefan Weil
The fix is based on a patch from Kevin Wolf. Here his comment: The number of blocks needs to be rounded up to cover all of the virtual hard disk. Without this fix, we can't even open our own images if their size is not a multiple of the block size. While Kevin's patch addressed vdi_create, my

Re: [Qemu-devel] Re: Another SIGFPE in display code, now in cirrus

2010-05-12 Thread Stefano Stabellini
On Wed, 12 May 2010, Jamie Lokier wrote: Stefano Stabellini wrote: On Wed, 12 May 2010, Avi Kivity wrote: It's useful if you have a one-line horizontal pattern you want to propagate all over. It might be useful all right, but it is not entirely clear what the hardware should do

[Qemu-devel] [PATCH] target-sparc: Fix wrong printf argument

2010-05-12 Thread Stefan Weil
cpu_get_ccr() returns a target_ulong, so a type cast is needed to avoid wrong output on big endian hosts. We could also use TARGET_FMT_lx, but that would print 8 instead of 2 digits. Cc: Blue Swirl blauwir...@gmail.com Signed-off-by: Stefan Weil w...@mail.berlios.de --- target-sparc/helper.c |

[Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read

2010-05-12 Thread Jan Kiszka
Alexander Graf wrote: Jan Kiszka wrote: Alexander Graf wrote: Jan Kiszka wrote: Move the buffer flush from mux_chr_read to mux_chr_can_read. While the latter is called periodically, the former will only be invoked when new characters arrive at the back-end. This caused problems to

[Qemu-devel] Re: [PATCH] block/vdi: Fix image opening and creation for odd disk sizes

2010-05-12 Thread Kevin Wolf
Am 12.05.2010 20:25, schrieb Stefan Weil: The fix is based on a patch from Kevin Wolf. Here his comment: The number of blocks needs to be rounded up to cover all of the virtual hard disk. Without this fix, we can't even open our own images if their size is not a multiple of the block size.

[Qemu-devel] Re: [PPC] Can't boot iso images

2010-05-12 Thread Blue Swirl
On 5/11/10, Alexander Graf ag...@suse.de wrote: Howdy, While trying to boot an openSUSE 11.1 iso I always get /packages/elf-loader is missing. Apparently that bug was fixed in a more recent version of OpenBIOS. According to git log the version in pc-bios is r721. Could we please pull

Re: [Qemu-devel] [PATCH 2/2] all vga: fail graicefully when vga ports are taken

2010-05-12 Thread Blue Swirl
On 5/11/10, Gerd Hoffmann kra...@redhat.com wrote: Try to pci hotplug a vga card, watch qemu die with hw_error(). This patch fixes it. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/cirrus_vga.c |3 +++ hw/vga-pci.c|3 +++ hw/vmware_vga.c |3 +++ 3 files

Re: [Qemu-devel] [RFC] tcg/interpreter: Add TCG + interpreter for bytecode (virtual machine)

2010-05-12 Thread Stefan Weil
Am 28.09.2009 18:50, schrieb Stefan Weil: Hello The patch following this mail adds a new code generator to qemu. It includes a README file with more details. Comments and contributions to complete it are welcome. Regards Stefan Weil Hello, The latest version of the TCG interpreter (TCI)

Re: [Qemu-devel] Re: Another SIGFPE in display code, now in cirrus

2010-05-12 Thread Michael Tokarev
12.05.2010 22:11, Stefano Stabellini wrote: On Wed, 12 May 2010, Jamie Lokier wrote: Stefano Stabellini wrote: On Wed, 12 May 2010, Avi Kivity wrote: It's useful if you have a one-line horizontal pattern you want to propagate all over. It might be useful all right, but it is not entirely

[Qemu-devel] Re: [PATCH v2] Fix -device help and documentation

2010-05-12 Thread Stefan Weil
Am 11.05.2010 14:02, schrieb Markus Armbruster: Commit 6616b2ad reverted commit 40ea285c. Looks like a mismerge to me. Signed-off-by: Markus Armbrusterarm...@redhat.com --- v2: rebased (v1 fell through the cracks apparently) qemu-options.hx | 15 ++- 1 files changed, 6

[Qemu-devel] Re: [PATCH] target-sparc: Fix wrong printf argument

2010-05-12 Thread Blue Swirl
Thanks, applied. Another solution would have been to change the return value to uint32_t. On 5/12/10, Stefan Weil w...@mail.berlios.de wrote: cpu_get_ccr() returns a target_ulong, so a type cast is needed to avoid wrong output on big endian hosts. We could also use TARGET_FMT_lx, but that

[Qemu-devel] [PATCH] target-i386: Avoid kvm related compiler error

2010-05-12 Thread Stefan Weil
Some versions of kvm.h (debian lenny) define KVM_CAP_VCPU_EVENTS without defining KVM_VCPUEVENT_VALID_NMI_PENDING or KVM_VCPUEVENT_VALID_SIPI_VECTOR. Without the patch, compilation fails: CCx86_64-softmmu/kvm.o /qemu/target-i386/kvm.c: In function 'kvm_put_vcpu_events':

[Qemu-devel] Re: ehci fixes

2010-05-12 Thread Jan Kiszka
Vincent Palatin wrote: Dear developers, While using the EHCI patchset, I have found 2 minor issues. So, I send in this email thread 2 fix proposals. Thanks, merged both and pushed an updated ehci branch. Jan signature.asc Description: OpenPGP digital signature

[Qemu-devel] Migration failure from AMD to Intel

2010-05-12 Thread Tomoe Sugihara
Hi, Does anyone have any idea on a issue that I have regarding VM migration from AMD to Intel host? When the guest is migrated from AMD host and right after it starts on Intel host, qemu process crashes with log messages like below. Looks like, when the guest is loaded on its network, it is

[Qemu-devel] Re: [RFC PATCH 1/2] close all the block drivers before the qemu process exits

2010-05-12 Thread MORITA Kazutaka
At Thu, 13 May 2010 05:16:35 +0900, MORITA Kazutaka wrote: On 2010/05/12 23:28, Avi Kivity wrote: On 05/12/2010 01:46 PM, MORITA Kazutaka wrote: This patch calls the close handler of the block driver before the qemu process exits. This is necessary because the sheepdog block driver

[Qemu-devel] [PATCH resend 2/6] MIPS: Initial support of vt82686b south bridge used by fulong mini pc

2010-05-12 Thread Huacai Chen
resend by git send-email to avoid line-wrapping Signed-off-by: Huacai Chen zltjiang...@gmail.com --- Makefile.target |2 +- hw/pc.h |7 + hw/pci_ids.h|8 + hw/vt82c686.c | 786 +++ 4 files changed, 802 insertions(+),

Re: [Qemu-devel] [RFC] tcg/interpreter: Add TCG + interpreter for bytecode (virtual machine)

2010-05-12 Thread Jun Koi
On Tue, Sep 29, 2009 at 1:50 AM, Stefan Weil w...@mail.berlios.de wrote: Hello The patch following this mail adds a new code generator to qemu. It includes a README file with more details. Comments and contributions to complete it are welcome. Could you compare the performance of TCG and

[Qemu-devel] [PATCH resend 4/6] MIPS: Initial support of VIA USB controller used by fulong mini pc

2010-05-12 Thread Huacai Chen
resend by git send-email to avoid line-wrapping Signed-off-by: Huacai Chen zltjiang...@gmail.com --- hw/usb-uhci.c | 30 ++ hw/usb-uhci.h |1 + 2 files changed, 31 insertions(+), 0 deletions(-) diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c index 624d55b..5fd5388

Re: [Qemu-devel] [PATCH] linux-user: rlimit conversion between host and target.

2010-05-12 Thread Richard Henderson
On 04/11/2010 12:07 PM, takas...@ops.dti.ne.jp wrote: rlim_t conversion between host and target added. Otherwise there are some incorrect case like - RLIM_INFINITY on 32bit target - 64bit host. - RLIM_INFINITY on 64bit host - mips and sparc target ? - Big value(for 32bit target) on 64bit

[Qemu-devel] [PATCH 0/2] Enable qemu block layer to not flush v2

2010-05-12 Thread Alexander Graf
Thanks to recent improvements, qemu flushes guest data to disk when the guest tells us to do so. This is great if we care about data consistency on host disk failures. In cases where we don't it just creates additional overhead for no net win. One such use case is the building of appliances in

[Qemu-devel] Re: S390 TCG target

2010-05-12 Thread Richard Henderson
Reference: http://lists.gnu.org/archive/html/qemu-devel/2009-12/msg01954.html static const int tcg_target_call_iarg_regs[] = { +TCG_REG_R2, +TCG_REG_R3, +TCG_REG_R4, +TCG_REG_R5, }; R6 is also an argument register. +static void tcg_out_e3(TCGContext* s, int op, int r1,

[Qemu-devel] [PATCH resend 1/6] MIPS: Initial support of bonito north bridge used by fulong mini pc

2010-05-12 Thread Huacai Chen
resend by git send-email to avoid line-wrapping Signed-off-by: Huacai Chen zltjiang...@gmail.com --- Makefile.target |1 + default-configs/mips64el-softmmu.mak |1 + hw/bonito.c | 950 ++ hw/mips.h

[Qemu-devel] [PATCH 02/12] kvm: set cpu_single_env around KVM_RUN ioctl

2010-05-12 Thread Marcelo Tosatti
Zero cpu_single_env before leaving global lock protection, and restore on return. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com --- kvm-all.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index

[Qemu-devel] [PATCH 2/2] Add cache=volatile parameter to -drive

2010-05-12 Thread Alexander Graf
Usually the guest can tell the host to flush data to disk. In some cases we don't want to flush though, but try to keep everything in cache. So let's add a new cache value to -drive that allows us to set the cache policy to most aggressive, disabling flushes. We call this mode volatile, as guest

Re: [Qemu-devel] [PATCH] [S390] Remove warning in tcg stub (tcg_out_reloc)

2010-05-12 Thread Alexander Graf
On 12.05.2010, at 19:28, Aurelien Jarno wrote: On Tue, May 11, 2010 at 09:50:34PM +0200, Alexander Graf wrote: Am 11.05.2010 um 19:26 schrieb Richard Henderson r...@twiddle.net: On 05/11/2010 09:47 AM, Stefan Weil wrote: Won't you get another warning about unreachable code because

  1   2   >