[Qemu-devel] Re: [PATCH 1/1] Add -version-simple argument, printing only version number.

2010-05-16 Thread Jes Sorensen
On 05/14/10 15:21, Anthony Liguori wrote: > On 05/13/2010 03:32 AM, jes.soren...@redhat.com wrote: >> From: Jes Sorensen >> >> Add -version-simple argument for QEMU, printing just the version >> number, without any supporting text. > > I'm not a huge fan of the name. It was the lesser evil I coul

Re: [Qemu-devel] [PATCH 3/8] Add QBuffer

2010-05-16 Thread Avi Kivity
On 05/17/2010 03:12 AM, Anthony Liguori wrote: On Sun, May 16, 2010 at 12:38 PM, Jamie Lokier wrote: Anthony Liguori wrote: Instead of encoding just as a string, it would be a good idea to encode it as something like: {'__class__': 'base64', 'data': ...} Is there a benefit

[Qemu-devel] [PATCH 2/2] [block]: Add SG_IO device check in refresh_total_sectors()

2010-05-16 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds a special case check for scsi-generic devices in refresh_total_sectors() to skip the subsequent BlockDriver->bdrv_getlength() that will be returning -ESPIPE from block/raw-posic.c:raw_getlength() for BlockDriverState->sg=1 devices. Signed-off-by: Nichol

[Qemu-devel] [PATCH 1/2] [block]: Make find_image_format() return 'raw' BlockDriver for SG_IO devices

2010-05-16 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds a special BlockDriverState->sg check in block.c:find_image_format() after bdrv_file_open() -> block/raw-posix.c:hdev_open() has been called to determine if we are dealing with a Linux host scsi-generic device. The patch then returns the BlockDriver * fr

[Qemu-devel] [PATCH 0/2] Fix scsi-generic breakage in upstream qemu-kvm.git

2010-05-16 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Greetings, Attached are the updated patches following hch's comments to fix scsi-generic device breakage with find_image_format() and refresh_total_sectors(). These are being resent as the last attachments where in MBOX format from git-format-patch. Signed-off-by: Nic

[Qemu-devel] Re: [PATCH 2/2] [block]: Skip refresh_total_sectors() for scsi-generic devices

2010-05-16 Thread Nicholas A. Bellinger
On Sun, 2010-05-16 at 15:30 +0200, Christoph Hellwig wrote: > On Sat, May 15, 2010 at 06:30:59AM -0700, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger > > > > This patch adds a BlockDriverState->sg check in block.c:bdrv_common_open() > > to skip the new refresh_total_sectors() call onc

[Qemu-devel] Re: [PATCH 1/2] [block]: Fix scsi-generic breakage in find_image_format()

2010-05-16 Thread Nicholas A. Bellinger
On Sun, 2010-05-16 at 15:29 +0200, Christoph Hellwig wrote: > On Sat, May 15, 2010 at 06:30:52AM -0700, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger > > > > This patch adds a special BlockDriverState->sg check in > > block.c:find_image_format() > > after bdrv_file_open() -> block/ra

Re: [Qemu-devel] [PATCH 3/8] Add QBuffer

2010-05-16 Thread Anthony Liguori
On Sun, May 16, 2010 at 12:38 PM, Jamie Lokier wrote: > Anthony Liguori wrote: >> Instead of encoding just as a string, it would be a good idea to encode >> it as something like: >> >> {'__class__': 'base64', 'data': ...} > > Is there a benefit to the class indirection, over simply a keyword?: > >

[Qemu-devel] Re: Qemu-KVM Livate Migration 0.12.2 -> 0.12.3/4 broken?

2010-05-16 Thread Juan Quintela
Jan Kiszka wrote: > Juan Quintela wrote: >> Lack of "proper" subsections. IDE is something like: >> >> const VMStateDescription vmstate_ide_drive = { >> .version_id = 4, >> >> } >> >> static const VMStateDescription vmstate_bmdma = { >> .name = "ide bmdma", >> .version_id = 4,

Re: [Qemu-devel] Re: [PATCH 0/2] pckbd improvements

2010-05-16 Thread Blue Swirl
On 5/16/10, Jamie Lokier wrote: > Blue Swirl wrote: > > On 5/16/10, Paolo Bonzini wrote: > > > On 05/15/2010 11:49 AM, Blue Swirl wrote: > > > > > > > In 2/2, A20 logic changes a bit but I doubt any guest would be broken > > > > if A20 line written through I/O port 92 couldn't be read via i8

[Qemu-devel] Re: Qemu-KVM Livate Migration 0.12.2 -> 0.12.3/4 broken?

2010-05-16 Thread Juan Quintela
Avi Kivity wrote: > On 05/16/2010 05:42 PM, Juan Quintela wrote: >> >>> Any idea why it fails? And how to fix it? >>> >> Lack of "proper" subsections. IDE is something like: >> >> const VMStateDescription vmstate_ide_drive = { >> .version_id = 4, >> >> } >> >> static const VMStat

Re: [Qemu-devel] [PATCH] My patches

2010-05-16 Thread Andreas Färber
Hello, Am 16.05.2010 um 18:19 schrieb C.W. Betts: These are my following patches to contribute to Qemu. Included in the patch: * ignore missing libuuid on Darwin: libSystem has the needed functions in it. * quiet warning about no prototype for qemu_main when building Cocoa. * fixes handleEve

[Qemu-devel] Re: Qemu-KVM Livate Migration 0.12.2 -> 0.12.3/4 broken?

2010-05-16 Thread Jan Kiszka
Juan Quintela wrote: > Lack of "proper" subsections. IDE is something like: > > const VMStateDescription vmstate_ide_drive = { > .version_id = 4, > > } > > static const VMStateDescription vmstate_bmdma = { > .name = "ide bmdma", > .version_id = 4, > ... > } > > const VMStateDes

[Qemu-devel] Re: [PATCH 3/8] Add QBuffer

2010-05-16 Thread Jan Kiszka
Jamie Lokier wrote: > Anthony Liguori wrote: >> Instead of encoding just as a string, it would be a good idea to encode >> it as something like: >> >> {'__class__': 'base64', 'data': ...} > > Is there a benefit to the class indirection, over simply a keyword?: > > {'__base64__': ...} > > __clas

Re: [Qemu-devel] Re: [PATCH 0/2] pckbd improvements

2010-05-16 Thread Jamie Lokier
Blue Swirl wrote: > On 5/16/10, Paolo Bonzini wrote: > > On 05/15/2010 11:49 AM, Blue Swirl wrote: > > > > > In 2/2, A20 logic changes a bit but I doubt any guest would be broken > > > if A20 line written through I/O port 92 couldn't be read via i8042. > > > The reverse (write using i8042 and read

Re: [Qemu-devel] [PATCH 3/8] Add QBuffer

2010-05-16 Thread Jamie Lokier
Anthony Liguori wrote: > Instead of encoding just as a string, it would be a good idea to encode > it as something like: > > {'__class__': 'base64', 'data': ...} Is there a benefit to the class indirection, over simply a keyword?: {'__base64__': ...} __class__ seems to suggest much more than i

[Qemu-devel] [PATCH] My patches

2010-05-16 Thread C.W. Betts
These are my following patches to contribute to Qemu. Included in the patch: * ignore missing libuuid on Darwin: libSystem has the needed functions in it. * quiet warning about no prototype for qemu_main when building Cocoa. * fixes handleEvent: warning in Cocoa.m * use <> other than "" in qemu-thr

Re: [Qemu-devel] [PATCH] virtio-blk: Avoid zeroing every request structure

2010-05-16 Thread Stefan Hajnoczi
On Sun, May 16, 2010 at 2:25 PM, Christoph Hellwig wrote: > On Fri, May 14, 2010 at 10:52:30PM +0100, Stefan Hajnoczi wrote: >> diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c >> index b05d15e..d270225 100644 >> --- a/hw/virtio-blk.c >> +++ b/hw/virtio-blk.c >> @@ -105,8 +105,10 @@ static void virt

[Qemu-devel] Re: Qemu-KVM Livate Migration 0.12.2 -> 0.12.3/4 broken?

2010-05-16 Thread Avi Kivity
On 05/16/2010 05:42 PM, Juan Quintela wrote: Any idea why it fails? And how to fix it? Lack of "proper" subsections. IDE is something like: const VMStateDescription vmstate_ide_drive = { .version_id = 4, } static const VMStateDescription vmstate_bmdma = { .name = "ide

[Qemu-devel] Re: Qemu-KVM Livate Migration 0.12.2 -> 0.12.3/4 broken?

2010-05-16 Thread Juan Quintela
Avi Kivity wrote: > On 05/12/2010 02:11 AM, Juan Quintela wrote: >> Peter Lieven wrote: >> >>> Hi Qemu/KVM Devel Team, >>> >>> Live Migration from a 0.12.2 qemu-kvm to a 0.12.3 (and 0.12.4) >>> does not work: "load of migration failed" >>> >>> Is there any way to find out, why exactly it fail

[Qemu-devel] [PATCH B/AB] Remove NO_CPU_IO_DEFS

2010-05-16 Thread Blue Swirl
Signed-off-by: Blue Swirl --- target-i386/cpu.h |2 -- target-ppc/cpu.h |2 -- target-sparc/cpu.h |2 -- tcg/tcg.c |1 - translate-all.c|1 - 5 files changed, 0 insertions(+), 8 deletions(-) diff --git a/target-i386/cpu.h b/target-i386/cpu.h index 548ab80..740

[Qemu-devel] [PATCH A/AB] Fix NO_CPU_IO_DEFS usage

2010-05-16 Thread Blue Swirl
Signed-off-by: Blue Swirl --- target-alpha/cpu.h |2 ++ target-arm/cpu.h|4 target-cris/cpu.h |2 ++ target-i386/cpu.h |4 ++-- target-m68k/cpu.h |8 ++-- target-microblaze/cpu.h |2 ++ target-mips/cpu.h |4 target-ppc

[Qemu-devel] [PATCH 0/AB] Fix or remove NO_CPU_IO_DEFS

2010-05-16 Thread Blue Swirl
NO_CPU_IO_DEFS seems to be bitrotten and only a few targets use it. I think we should either fix it or remove it. Blue Swirl (1): Fix NO_CPU_IO_DEFS usage target-alpha/cpu.h |2 ++ target-arm/cpu.h|4 target-cris/cpu.h |2 ++ target-i386/cpu.h |4

[Qemu-devel] Re: [PATCH 2/2] [block]: Skip refresh_total_sectors() for scsi-generic devices

2010-05-16 Thread Christoph Hellwig
On Sat, May 15, 2010 at 06:30:59AM -0700, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > This patch adds a BlockDriverState->sg check in block.c:bdrv_common_open() > to skip the new refresh_total_sectors() call once we know we are working with > a scsi-generic device. > > We go ahea

[Qemu-devel] Re: [PATCH 1/2] [block]: Fix scsi-generic breakage in find_image_format()

2010-05-16 Thread Christoph Hellwig
On Sat, May 15, 2010 at 06:30:52AM -0700, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > This patch adds a special BlockDriverState->sg check in > block.c:find_image_format() > after bdrv_file_open() -> block/raw-posix.c:hdev_open() has been called to > determine > if we are dealin

Re: [Qemu-devel] [PATCH] virtio-blk: Avoid zeroing every request structure

2010-05-16 Thread Christoph Hellwig
On Fri, May 14, 2010 at 10:52:30PM +0100, Stefan Hajnoczi wrote: > diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c > index b05d15e..d270225 100644 > --- a/hw/virtio-blk.c > +++ b/hw/virtio-blk.c > @@ -105,8 +105,10 @@ static void virtio_blk_flush_complete(void *opaque, int > ret) > > static Virt

Re: [Qemu-devel] [PATCH] block: fix aio_flush segfaults for read-only protocols (e.g. curl)

2010-05-16 Thread Christoph Hellwig
On Sun, May 16, 2010 at 02:59:57PM +0300, Avi Kivity wrote: > Not all block format drivers expose an io_flush method (reasonable for > read-only protocols), so calling io_flush there will immediately segfault. > > Fix by checking for the method's existence before calling it. Looks good, Reviewe

[Qemu-devel] Re: Qemu-KVM Livate Migration 0.12.2 -> 0.12.3/4 broken?

2010-05-16 Thread Avi Kivity
On 05/12/2010 02:11 AM, Juan Quintela wrote: Peter Lieven wrote: Hi Qemu/KVM Devel Team, Live Migration from a 0.12.2 qemu-kvm to a 0.12.3 (and 0.12.4) does not work: "load of migration failed" Is there any way to find out, why exactly it fails? I have a lot of VMs running on 0.12.2 and w

[Qemu-devel] [PATCH] block: fix aio_flush segfaults for read-only protocols (e.g. curl)

2010-05-16 Thread Avi Kivity
Not all block format drivers expose an io_flush method (reasonable for read-only protocols), so calling io_flush there will immediately segfault. Fix by checking for the method's existence before calling it. Signed-off-by: Avi Kivity --- aio.c |4 +++- 1 files changed, 3 insertions(+), 1 de

[Qemu-devel] Re: [PATCH 3/8] Add QBuffer

2010-05-16 Thread Avi Kivity
On 05/16/2010 01:16 PM, Paolo Bonzini wrote: On 05/16/2010 11:50 AM, Avi Kivity wrote: On 05/16/2010 12:37 PM, Paolo Bonzini wrote: On 05/15/2010 07:31 PM, Avi Kivity wrote: On 05/15/2010 11:59 AM, Jan Kiszka wrote: Is this __class__ stuff documented anywhere? Not yet. Also, we should clar

[Qemu-devel] Re: [PATCH 0/2] pckbd improvements

2010-05-16 Thread Blue Swirl
On 5/16/10, Paolo Bonzini wrote: > On 05/15/2010 11:49 AM, Blue Swirl wrote: > > > In 2/2, A20 logic changes a bit but I doubt any guest would be broken > > if A20 line written through I/O port 92 couldn't be read via i8042. > > The reverse (write using i8042 and read port 92) will work. > > > >

[Qemu-devel] Re: [PATCH 7/8] Add QLIST_INSERT_TAIL

2010-05-16 Thread Jan Kiszka
Paolo Bonzini wrote: > On 05/14/2010 03:20 PM, Jan Kiszka wrote: >> As the QLIST has not tail pointer, this requires list walking. Still >> useful when lists are short or insertion time doesn't matter. > > True, but why not switch to QTAIL instead? Would be more invasive, but I can do so if it's

[Qemu-devel] Re: [PATCH 3/8] Add QBuffer

2010-05-16 Thread Paolo Bonzini
On 05/16/2010 11:50 AM, Avi Kivity wrote: On 05/16/2010 12:37 PM, Paolo Bonzini wrote: On 05/15/2010 07:31 PM, Avi Kivity wrote: On 05/15/2010 11:59 AM, Jan Kiszka wrote: Is this __class__ stuff documented anywhere? Not yet. Also, we should clarify the proposed private extension section th

[Qemu-devel] Re: [PATCH 3/8] Add QBuffer

2010-05-16 Thread Jan Kiszka
Avi Kivity wrote: > On 05/16/2010 12:37 PM, Paolo Bonzini wrote: >> On 05/15/2010 07:31 PM, Avi Kivity wrote: >>> On 05/15/2010 11:59 AM, Jan Kiszka wrote: > Is this __class__ stuff documented anywhere? > Not yet. Also, we should clarify the proposed private extension section

[Qemu-devel] Re: [PATCH 3/8] Add QBuffer

2010-05-16 Thread Jan Kiszka
Avi Kivity wrote: > On 05/15/2010 11:59 AM, Jan Kiszka wrote: >> >>> Is this __class__ stuff documented anywhere? >>> >>> >> Not yet. Also, we should clarify the proposed private extension section >> that only "__some_key" is reserved for downstream, not >> '__some_other_key__' (i.e. downstre

[Qemu-devel] Re: [PATCH] Put dependency files in proper subdir

2010-05-16 Thread Juan Quintela
Jan Kiszka wrote: > From: Jan Kiszka > > This seems to resolve subtle breakages of our build system: > > Dependency files generated for targets like 'dir/foo.o' were saved as > 'foo.d'. Now, if there was also a target 'foo.o', one of the dependency > file was overwritten. Concrete example: libhw*

[Qemu-devel] Re: [PATCH 3/8] Add QBuffer

2010-05-16 Thread Avi Kivity
On 05/16/2010 12:37 PM, Paolo Bonzini wrote: On 05/15/2010 07:31 PM, Avi Kivity wrote: On 05/15/2010 11:59 AM, Jan Kiszka wrote: Is this __class__ stuff documented anywhere? Not yet. Also, we should clarify the proposed private extension section that only "__some_key" is reserved for downst

[Qemu-devel] Re: [PATCH] Clean libhw subdirs as well

2010-05-16 Thread Juan Quintela
Jan Kiszka wrote: > From: Jan Kiszka > > Signed-off-by: Jan Kiszka > --- > Makefile.hw |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/Makefile.hw b/Makefile.hw > index be35359..b9181ab 100644 > --- a/Makefile.hw > +++ b/Makefile.hw > @@ -18,7 +18,7 @@ all: $(hw-o

[Qemu-devel] Re: [PATCH] Clean libhw subdirs as well

2010-05-16 Thread Paolo Bonzini
On 05/15/2010 01:03 PM, Jan Kiszka wrote: From: Jan Kiszka Signed-off-by: Jan Kiszka --- Makefile.hw |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.hw b/Makefile.hw index be35359..b9181ab 100644 --- a/Makefile.hw +++ b/Makefile.hw @@ -18,7 +18,7 @@ all: $(h

[Qemu-devel] Re: [PATCH] Put dependency files in proper subdir

2010-05-16 Thread Paolo Bonzini
On 05/15/2010 01:03 PM, Jan Kiszka wrote: From: Jan Kiszka This seems to resolve subtle breakages of our build system: Dependency files generated for targets like 'dir/foo.o' were saved as 'foo.d'. Now, if there was also a target 'foo.o', one of the dependency file was overwritten. Concrete exa

[Qemu-devel] Re: [PATCH 0/2] pckbd improvements

2010-05-16 Thread Paolo Bonzini
On 05/15/2010 11:49 AM, Blue Swirl wrote: In 2/2, A20 logic changes a bit but I doubt any guest would be broken if A20 line written through I/O port 92 couldn't be read via i8042. The reverse (write using i8042 and read port 92) will work. Why take the risk? PaolO

[Qemu-devel] Re: [PATCH 7/8] Add QLIST_INSERT_TAIL

2010-05-16 Thread Paolo Bonzini
On 05/14/2010 03:20 PM, Jan Kiszka wrote: As the QLIST has not tail pointer, this requires list walking. Still useful when lists are short or insertion time doesn't matter. True, but why not switch to QTAIL instead? Paolo

[Qemu-devel] Re: [PATCH 3/8] Add QBuffer

2010-05-16 Thread Paolo Bonzini
On 05/15/2010 07:31 PM, Avi Kivity wrote: On 05/15/2010 11:59 AM, Jan Kiszka wrote: Is this __class__ stuff documented anywhere? Not yet. Also, we should clarify the proposed private extension section that only "__some_key" is reserved for downstream, not '__some_other_key__' (i.e. downstrea

Re: [Qemu-devel] [PATCH 0/3] mingw32 compile fixes

2010-05-16 Thread Blue Swirl
On 5/16/10, Stefan Weil wrote: > Am 15.05.2010 22:49, schrieb Blue Swirl: > > > > Hi, > > > > With this mingw32 compiler: > > > > $ i586-mingw32msvc-gcc -v > > Using built-in specs. > > Target: i586-mingw32msvc > > Configured with: > > > /tmp/buildd/gcc-mingw32-4.4.2/build-tree/gcc-4.4.2/configure

[Qemu-devel] Re: [SeaBIOS] [PATCHv2] Support for booting from virtio disks

2010-05-16 Thread Gleb Natapov
On Thu, May 13, 2010 at 07:49:40PM +0300, Avi Kivity wrote: > On 05/10/2010 06:58 PM, Anthony Liguori wrote: > >>Isn't this problem unrelated to this patch? I mean if I start qemu with > >>two ide devices can I specify from qemu command line which one I want to > >>boot from? > > > >That's sort of

Re: [Qemu-devel] [PATCH 0/2] fix HelenOS illegal instruction issue on sparc64

2010-05-16 Thread Blue Swirl
Thanks, applied both. On 5/16/10, Igor V. Kovalenko wrote: > The following series fix a couple of typos in sparc target which cause > illegal instruction issue booting HelenOS on sparc64. > > --- > > Igor V. Kovalenko (2): > sparc64: fix mmu demap operand typo > sparc64: fix TT_WOT