2010/6/24 Alex Williamson alex.william...@redhat.com:
Ok, new approach. I'm going to attempt to extract myself for the
canonical device path approach, because we're missing too many pieces
to make that work. Instead, I'll take Anthony's advice and try to
simplify. We still want a unique
On 06/24/2010 06:42 AM, Alex Williamson wrote:
Allows us to compress the protocol a bit by setting a flag on the
offset which indicates we're still working within the same block
as last time. That way we can avoid sending the block name for
every page. Suggested by Anthony Liguori.
On 06/24/2010 06:42 AM, Alex Williamson wrote:
if (flags RAM_SAVE_FLAG_COMPRESS) {
-uint8_t ch = qemu_get_byte(f);
-memset(qemu_get_ram_ptr(addr), ch, TARGET_PAGE_SIZE);
+void *host;
+uint8_t ch;
+
+if (version_id == 3) {
+
Note to qemu-devel: this issue is qemu-kvm only.
Hao, Xudong xudong@intel.com writes:
When assign one PCI device, qemu fail to parse the command line:
qemu-system_x86 -smp 2 -m 1024 -hda /path/to/img -pcidevice host=00:19.0
Error:
qemu-system-x86_64: Parameter 'id' expects an identifier
Timothy Jones one.timothy.jo...@gmail.com writes:
With some digging around I found out that the qemu hangs in
usb_host_claim_interfaces, which is caused by screwed up usb
descriptor. The device reports the following:
(gdb) p dev-descr_len
$21 = 50
(gdb) p /x dev-descr...@50
$23 = {0x18,
I can reproduce this in qemu-kvm 0.12.50.
Most likely a problem with the e1000 driver in QEMU. Funny thing is the
guest seems to be able to obtain it's IP address via DHCP, then stops
communicating.
--
nic e1000 network interface does not work with 32-bit windows 2003r2 with sp2
poison TARGET_ARCH for compile once object
to prevent those ifdef from creeping in again.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
Makefile.objs |9 +
poison-arch.h | 25 +
poison.h | 16 +---
3 files changed, 35
On Wed, Jun 23, 2010 at 10:41:13PM -0600, Alex Williamson wrote:
This works great for PCI since a segment:bus:dev.fn uniquely
describes a global address. No need to traverse up the qdev tree.
PCI segment support is a placeholder for compatibility once we
support multiple segments.
On Thu, Jun 24, 2010 at 08:48:42AM +0900, Isaku Yamahata wrote:
On Wed, Jun 23, 2010 at 01:41:57PM +0300, Michael S. Tsirkin wrote:
I will try to find a bit of time to rearrange the code in pci.c a bit,
but this can come afterwards.
I'd like to move pci_bridge_xxx into pci_bridge.c because
Eh. Well. I'm a bit surprised that you won't allow forward slashes if
you try to parse a path. It's actually a quite common character in the
Linux world. Even other Unixes use it for separating components of a
path. And since people use it so much, it should be as easy as possible
to actually give
On (Wed) Jun 23 2010 [12:51:18], Michael S. Tsirkin wrote:
We were requesting too much when checking buffer
length: size already includes host header length.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
hw/virtio-net.c | 20 +++-
1 files changed, 11
On Thu, Jun 24, 2010 at 02:12:13PM +0530, Amit Shah wrote:
On (Wed) Jun 23 2010 [12:51:18], Michael S. Tsirkin wrote:
We were requesting too much when checking buffer
length: size already includes host header length.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
On 06/23/10 16:44, Amit Shah wrote:
qemu-config.c doesn't contain any target-specific code, and the
TARGET_I386 conditional code didn't get compiled as a result. Removing
this enables the driftfix parameter for rtc.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
qemu-config.c |2 --
On 06/24/2010 09:14 AM, Isaku Yamahata wrote:
Sorry, I sent out the old patch. Here is the right one.
Subject: [PATCH] poison TARGET_arch for compile once.
poison TARGET_arch for compile once object
to prevent those ifdef from creeping in again.
Why do you need to split poison.h? Are there
This set of patches enables trace visualization control
via the QEMU monitor. It is based on trace infrastructure posted
upstream :
( http://lists.gnu.org/archive/html/qemu-devel/2010-05/msg02407.html )
This patchset adds monitor commands :
- info trace : to view current contents of the trace
Change type 'TraceEvent' to 'TraceEventID'
Signed-off-by: Prerna Saxena pre...@linux.vnet.ibm.com
---
simpletrace.c | 12 ++--
tracetool | 12 ++--
2 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/simpletrace.c b/simpletrace.c
index 2fec4d3..b488380 100644
Monitor command 'info trace' to display contents of trace buffer
Signed-off-by: Prerna Saxena pre...@linux.vnet.ibm.com
---
configure |3 +++
monitor.c | 12
qemu-monitor.hx |4
simpletrace.c | 12
tracetool |1 +
5 files
This patch adds support for dynamically enabling/disabling of trace events.
This is done by internally maintaining each trace event's state, and
permitting logging of data from a trace event only if it is in an
'active' state.
Monitor commands added :
1) info trace-events: to view
On Tue, Jun 15, 2010 at 9:00 AM, Amit Shah amit.s...@redhat.com wrote:
Commit 50e32ea8f31035877decc10f1075aa0e619e09cb changed the behaviour
for the return type of net_client_init() when a nic type with no init
method was specified. 'none' is one such nic type. Instead of returning
0, which
Muelli: I agree that a help message about quoting pathnames would be
useful. Please work with the upstream mailing list to do so. A small
patch to qemu-monitor.hx should suffice, but you'll need to interact with
the qemu-devel@nongnu.org mailing list.
** Changed in: qemu-kvm (Ubuntu)
On Thu, 2010-06-24 at 15:02 +0900, Yoshiaki Tamura wrote:
Hi Alex,
Is there additional overhead to save rams introduce by this series?
If so, how much?
Yes, there is overhead, but it's typically quite small. If I migrate a
1G VM immediately after I boot to a login prompt (lots of zero
On Thu, 2010-06-24 at 16:39 +0900, Isaku Yamahata wrote:
On Wed, Jun 23, 2010 at 10:41:13PM -0600, Alex Williamson wrote:
This works great for PCI since a segment:bus:dev.fn uniquely
describes a global address. No need to traverse up the qdev tree.
PCI segment support is a placeholder for
On Thu, 2010-06-24 at 07:51 +0200, Paolo Bonzini wrote:
@@ -377,26 +398,11 @@ int ram_load(QEMUFile *f, void *opaque, int
version_id)
} else if (flags RAM_SAVE_FLAG_PAGE) {
void *host;
-if (version_id == 3) {
+if (version_id == 3)
On Thu, Jun 24, 2010 at 04:49:30PM +0530, Prerna Saxena wrote:
This set of patches enables trace visualization control
via the QEMU monitor. It is based on trace infrastructure posted
upstream :
( http://lists.gnu.org/archive/html/qemu-devel/2010-05/msg02407.html )
This patchset adds
On Thu, 2010-06-24 at 09:04 -0600, Alex Williamson wrote:
On Thu, 2010-06-24 at 15:02 +0900, Yoshiaki Tamura wrote:
Hi Alex,
Is there additional overhead to save rams introduce by this series?
If so, how much?
Yes, there is overhead, but it's typically quite small. If I migrate a
We were requesting too much when checking buffer
length: size already includes host header length.
Further, we should not exit if we get a packet that
is too long, since this might not be under control
of the guest. Just drop the packet.
Red Hat bz 591494
Signed-off-by: Michael S. Tsirkin
We were requesting too much when checking buffer
length: size already includes host header length.
Further, we should not exit if we get a packet that
is too long, since this might not be under control
of the guest. Just drop the packet.
Red Hat bz 591494
Signed-off-by: Michael S. Tsirkin
On 06/23/10 22:45, TJ wrote:
-- Forwarded message --
From: Timothy Jones one.timothy.jo...@gmail.com
Date: Wed, Jun 23, 2010 at 9:07 PM
Subject: Guest OS hangs on usb_add
To: qemu-devel@nongnu.org
With some digging around I found out that the qemu hangs in
Does boot succeed if you add
-net nic,model=rtl8139
to your qemu-system-arm arguments?
** Also affects: qemu
Importance: Undecided
Status: New
--
qemu-system-arm crashed with SIGSEGV in subpage_register()
https://bugs.launchpad.net/bugs/571432
You received this bug notification
On 06/24/10 13:59, David S. Ahern wrote:
On 06/23/10 22:45, TJ wrote:
-- Forwarded message --
From: Timothy Jones one.timothy.jo...@gmail.com
Date: Wed, Jun 23, 2010 at 9:07 PM
Subject: Guest OS hangs on usb_add
To: qemu-devel@nongnu.org
With some digging around I
This is a small patch to sligtly intelligentify usb device and
config descriptor parsing and to handle bug with certain usb
device reporting device desriptor length as 0x18 (instead of 18)
---
hw/usb.h|5 +
usb-linux.c | 36 +---
2 files changed, 26
On 06/15/2010 11:05 AM, Gerd Hoffmann wrote:
Hi,
This patch series features the linux fbdev display driver and a few
more patches the fbdev driver depends on. Most of the patches have been
on the list before. If you wondered what they are good for -- here is
the big picture ;)
As
On 06/24/2010 12:14 AM, Isaku Yamahata wrote:
QEMU_CFLAGS+=-I$(SRC_PATH)/linux-user
-I$(SRC_PATH)/linux-user/$(TARGET_ABI_DIR)
obj-y = main.o syscall.o strace.o mmap.o signal.o thunk.o \
- elfload.o linuxload.o uaccess.o gdbstub.o cpu-uname.o \
- qemu-malloc.o
+ elfload.o
On 06/24/10 02:42, Markus Armbruster wrote:
A botched up patch is often a pretty effective way to get somebody to
fix the thing correctly.
OK, I gave it a shot and sent it to the list. Shoulda prolly added a disclaimer
in case it blows something up ;)
-TJ
libdis, libdis-user and qemu-options.def are generated
directories / files and should be ignored by git.
Signed-off-by: Stefan Weil w...@mail.berlios.de
---
.gitignore |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/.gitignore b/.gitignore
index fdfe2f0..ce66ed5 100644
mingw32 does not define EPROTONOSUPPORT (which is used by
migration.c and maybe future patches), so add a
definition which uses a supported errno value.
Signed-off-by: Stefan Weil w...@mail.berlios.de
---
qemu-os-win32.h |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git
Am 12.06.2010 16:07, schrieb Stefan Weil:
mingw32 does not include function ffs.
Commit c6d29ad6e24533cc3762e1d654275607e1d03058 added a
declaration for ffs, but an implementation was missing.
For compilations with optimization, the compiler creates
inline code, so the implementation is not
A missing key is not an error.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
qdict.c |6 +++---
qdict.h |2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/qdict.c b/qdict.c
index 175bc17..c974d6f 100644
--- a/qdict.c
+++ b/qdict.c
@@ -272,16 +272,16 @@
Current QMP's client argument checker code is more complex than it should be
and has a flaw: it ignores unknown arguments.
This series solves both problems by introducing a new, simple and ultra-poweful
argument checker. This wasn't trivial to get right due to the number of errors
combinations,
This commit introduces the second (and last) part of QMP's new
argument checker.
The job is done by check_client_args_type(), it iterates over
the client's argument qdict and for for each argument it checks
if it exists and if its type is valid.
It's important to observe the following changes
Historically, user monitor arguments beginning with '-' (eg. '-f')
were passed as integers down to handlers.
I've maintained this behavior in the new monitor because we didn't
have a boolean type at the very beginning of QMP. Today we have it
and this behavior is causing trouble to QMP's argument
Current QMP's argument checker is more complex than it should be
and has (at least) one serious bug: it ignores unknown arguments.
To solve both problems we introduce a new argument checker. It's
added on top of the existing one, so that there are no regressions
during the transition.
This
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
check-qdict.c | 31 +++
1 files changed, 31 insertions(+), 0 deletions(-)
diff --git a/check-qdict.c b/check-qdict.c
index 1b070f4..6afce5a 100644
--- a/check-qdict.c
+++ b/check-qdict.c
@@ -194,6 +194,36 @@
Let's call a 'hash' only what is returned by our hash function,
anything else is a 'bucket'.
This helps avoiding confusion with regard to how we traverse
our table.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
check-qdict.c |2 +-
qdict.c | 24
Previous two commits added qmp_check_client_args(), which
fully replaces this code and is way better.
It's important to note that the new checker doesn't support
the '/' arg type. As we don't have any of those handlers
converted to QMP, this is just dead code.
Signed-off-by: Luiz Capitulino
It's composed of functions qdict_first() and qdict_next(), plus
functions to access QDictEntry values.
This API was suggested by Markus Armbruster arm...@redhat.com and
it offers full control over the iteration process.
The usage is simple, the following example prints all keys in 'qdict'
(it's
Next commit will introduce a new QDict iteration API which
returns QDictEntry entries, but we don't want users to directly
access its members since QDictEntry should be private to QDict.
In the near future this kind of data type will be turned into a
forward reference.
Signed-off-by: Luiz
Previous commit added qmp_check_input_obj(), it does all the
checking we need.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
monitor.c | 19 +--
1 files changed, 1 insertions(+), 18 deletions(-)
diff --git a/monitor.c b/monitor.c
index fab553a..b68b464 100644
---
This is similar to qmp_check_client_args(), but it checks if
the input object follows the specification (QMP/qmp-spec.txt
section 2.3).
As we're limited to three keys, the work here is quite simple:
we iterate over the input object, checking each time if the
current argument complies to the
Drop a unneeded label and QDECREF() call.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
monitor.c | 14 ++
1 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/monitor.c b/monitor.c
index b68b464..e38a3a4 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4227,7
On Thu, 24 Jun 2010 18:33:26 -0300
Luiz Capitulino lcapitul...@redhat.com wrote:
Current QMP's client argument checker code is more complex than it should be
and has a flaw: it ignores unknown arguments.
This series solves both problems by introducing a new, simple and
ultra-poweful
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
qdict.c | 18 ++
qdict.h |1 +
2 files changed, 19 insertions(+), 0 deletions(-)
diff --git a/qdict.c b/qdict.c
index a28a0a9..dee0fb4 100644
--- a/qdict.c
+++ b/qdict.c
@@ -308,6 +308,24 @@ int64_t
On Tue, Jun 15, 2010 at 5:04 AM, Avi Kivity a...@redhat.com wrote:
On 06/11/2010 08:31 PM, Cam Macdonell wrote:
On Mon, Apr 19, 2010 at 10:41 AM, Cam Macdonellc...@cs.ualberta.ca
wrote:
Hi,
I'm trying to use a 64-bit BAR for my shared memory device. In simply
changing the memory type
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
qerror.c |4
qerror.h |3 +++
2 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/qerror.c b/qerror.c
index cce1e7b..2f6f590 100644
--- a/qerror.c
+++ b/qerror.c
@@ -177,6 +177,10 @@ static const QErrorStringTable
** Changed in: qemu-kvm (Ubuntu)
Status: New = Incomplete
--
qemu-system-arm crashed with SIGSEGV in subpage_register()
https://bugs.launchpad.net/bugs/571432
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
Status in QEMU: New
Work-around: -device pci-assign,host=00:19.1
OK, this new way can work when create guest with static assignment.
But how to hot add a pci device to guest? the old hot add command pci_add
pci_addr=auto host host=00:19.0 has the same parse error.
BTW: if we use add -net none in qemu command, guest
Alex Williamson wrote:
On Thu, 2010-06-24 at 09:04 -0600, Alex Williamson wrote:
On Thu, 2010-06-24 at 15:02 +0900, Yoshiaki Tamura wrote:
Hi Alex,
Is there additional overhead to save rams introduce by this series?
If so, how much?
Yes, there is overhead, but it's typically quite small.
On Thu, 24 Jun 2010 12:49:56 pm Ryan Harper wrote:
Using Rusty's suggestion I've respun the patch removing the special copy
function. I've tested this patch in a guest kernel with and without qemu
supplying serial numbers for the block devices and it's working as expected.
When qemu supplies
poison TARGET_xxx for compile once object
to prevent those ifdef from creeping in again.
didn't poison env which is used as function argument as void *env.
Although it would be possible to sort it out, for now just not poison it.
qemu-malloc.c didn't compile, so I make it non compile-once for
Hao, Xudong xudong@intel.com writes:
Work-around: -device pci-assign,host=00:19.1
OK, this new way can work when create guest with static assignment.
But how to hot add a pci device to guest? the old hot add command pci_add
pci_addr=auto host host=00:19.0 has the same parse error.
60 matches
Mail list logo
