[Qemu-devel] Personalhandbok

2010-07-06 Thread DokuMera Nyhetsbrev
Om du har problem med att läsa detta e-postmeddelande, klicka här (http://www.anp.se/newsletterweb/777270/444059437941455D4B7142445C43) för en webb-version. Vårt nyhetsbrev skickas automatiskt till våra kunder och intressenter. Vill du inte ha detta nyhetsbrev framöver, klicka här för att

[Qemu-devel] Latest git version fails to compile on Linux host

2010-07-06 Thread Nigel Horne
./configure --enable-linux-aio --enable-io-thread --enable-kvm make ... /home/njh/src/qemu/cpus.c:532: error: ‘exit_request’ undeclared (first use in this function) /home/njh/src/qemu/cpus.c:532: error: (Each undeclared identifier is reported only once /home/njh/src/qemu/cpus.c:532: error: for

[Qemu-devel] [PATCH] Fix io-thread build breakage of a88790a14f

2010-07-06 Thread Jan Kiszka
Nigel Horne wrote: ./configure --enable-linux-aio --enable-io-thread --enable-kvm make ... /home/njh/src/qemu/cpus.c:532: error: ‘exit_request’ undeclared (first use in this function) /home/njh/src/qemu/cpus.c:532: error: (Each undeclared identifier is reported only once

[Qemu-devel] [PATCH 1/1] Include sys/mman.h before qemu-options.h

2010-07-06 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com The result of parsing qemu-options.def depends on whehter or not MAP_POPULATE is defined, so make sure to include sys/mman.h before including qemu-options.h. Reported by Frank Arnold. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-posix.c

[Qemu-devel] [PATCH 0/1] Fix qemu-options enum (repost)

2010-07-06 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Hi, I think this one got lost in the noise last week. It's needed to resolve the issue where the qemu-options enum gets skewed when MAP_POPULATE isn't defined. Please apply, having our cmdline option parsing go wrong isn't good. Cheers, Jes Jes

[Qemu-devel] [PATCH] scsi: Fix SCSI bus reset

2010-07-06 Thread Jan Kiszka
When the controller raises the SCSI reset line, we have to perform the requested reset on all disks attached to the controller's bus. Moreover, reset is edge triggered, so avoid repeating it if the line was already high. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- hw/lsi53c895a.c | 15

[Qemu-devel] [RFC v2][PATCH][Tracing] Fix build errors for target i386-linux-user

2010-07-06 Thread Prerna Saxena
On Thu, 1 Jul 2010 10:18:41 +0100 Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: On Wed, Jun 30, 2010 at 09:11:45PM +0530, Prerna Saxena wrote: [PATCH 1/1] Move definitions of monitor command handlers (do_info_trace, do_info_all_trace_events) to monitor.c. This removes build errors for

[Qemu-devel] Re: [RFC v2][PATCH][Tracing] Fix build errors for target i386-linux-user

2010-07-06 Thread Stefan Hajnoczi
On Tue, Jul 06, 2010 at 01:34:17PM +0530, Prerna Saxena wrote: On Thu, 1 Jul 2010 10:18:41 +0100 Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: On Wed, Jun 30, 2010 at 09:11:45PM +0530, Prerna Saxena wrote: [PATCH 1/1] Move definitions of monitor command handlers (do_info_trace,

Re: [Qemu-devel] [PATCH 1/2] qemu-img check: Distinguish different kinds of errors

2010-07-06 Thread MORITA Kazutaka
At Fri, 2 Jul 2010 19:14:59 +0200, Kevin Wolf wrote: People think that their images are corrupted when in fact there are just some leaked clusters. Differentiating several error cases should make the messages more comprehensible. Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c

Re: [Qemu-devel] [PATCH 1/2] qemu-img check: Distinguish different kinds of errors

2010-07-06 Thread Kevin Wolf
Am 06.07.2010 12:51, schrieb MORITA Kazutaka: At Fri, 2 Jul 2010 19:14:59 +0200, Kevin Wolf wrote: People think that their images are corrupted when in fact there are just some leaked clusters. Differentiating several error cases should make the messages more comprehensible.

[Qemu-devel] [PATCH v2 1/2] qemu-img check: Distinguish different kinds of errors

2010-07-06 Thread Kevin Wolf
People think that their images are corrupted when in fact there are just some leaked clusters. Differentiating several error cases should make the messages more comprehensible. Signed-off-by: Kevin Wolf kw...@redhat.com --- v2: - Call bdrv_delete in -ENOTSUP case, too block.c| 10

[Qemu-devel] [PATCH] pci: pass bridge update to secondary bus

2010-07-06 Thread Michael S. Tsirkin
bridge config write should trigger updates on the secondary bus. never on the primary bus. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- Compile-tested only. Isaku Yamahata, could you review this please? You wrote the code, and you seem to have some bridged setups. hw/pci.c |4 +++-

[Qemu-devel] [PATCH v2 08/13] scsi: Error locations for -drive if=scsi device initialization

2010-07-06 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/scsi-bus.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c index b84b9b9..d69c74c 100644 --- a/hw/scsi-bus.c +++ b/hw/scsi-bus.c @@ -102,19 +102,23 @@ SCSIDevice

[Qemu-devel] [PATCH v2 01/13] blockdev: Clean up how readonly persists across virtual media change

2010-07-06 Thread Markus Armbruster
Since commit cb4e5f8e, monitor command change makes the new media readonly iff the type hint is BDRV_TYPE_CDROM, i.e. the drive was created with media=cdrom. The intention is to avoid changing a block device's read-only-ness. However, BDRV_TYPE_CDROM is only a hint. It is currently sufficent

[Qemu-devel] [PATCH v2 11/13] ide: Make ide_init_drive() return success

2010-07-06 Thread Markus Armbruster
It still always succeeds. The next commits will add failures. Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/ide/core.c | 13 + hw/ide/internal.h |4 ++-- hw/ide/qdev.c |4 +++- 3 files changed, 14 insertions(+), 7 deletions(-) diff --git

[Qemu-devel] [PATCH v2 12/13] ide: Reject readonly drives unless CD-ROM

2010-07-06 Thread Markus Armbruster
drive_init() doesn't permit option readonly for if=ide, but that's worthless: we get it via if=none and -device. Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/ide/core.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index

[Qemu-devel] [PATCH v2 06/13] scsi: Reject unimplemented error actions

2010-07-06 Thread Markus Armbruster
drive_init() doesn't permit rerror for if=scsi, but that's worthless: we get it via if=none and -device. Moreover, scsi-generic doesn't support werror. Since drive_init() doesn't catch that, option werror was silently ignored even with if=scsi. Wart: unlike drive_init(), we don't reject the

[Qemu-devel] [PATCH v2 09/13] ide: Improve error messages

2010-07-06 Thread Markus Armbruster
Use error_report(), because it points to the error location. Reword tried to assign twice messages to make it clear that we're complaining about the unit property. Report invalid unit property instead of failing silently. Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/ide/qdev.c |

[Qemu-devel] [PATCH v2 07/13] error: New qemu_opts_loc_restore()

2010-07-06 Thread Markus Armbruster
Needed for decent error locations when complaining about options outside of qemu_opts_foreach(). That one sets the location already. Signed-off-by: Markus Armbruster arm...@redhat.com --- qemu-option.c |5 + qemu-option.h |1 + 2 files changed, 6 insertions(+), 0 deletions(-) diff

[Qemu-devel] [PATCH v2 10/13] ide: Replace IDEState members is_cdrom, is_cf by drive_kind

2010-07-06 Thread Markus Armbruster
The two aren't independent variables. Make that obvious. Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/ide/core.c | 40 hw/ide/internal.h |5 +++-- hw/ide/macio.c |2 +- hw/ide/microdrive.c |2 +- 4 files changed,

[Qemu-devel] [PATCH v2 04/13] fdc: Reject unimplemented error actions

2010-07-06 Thread Markus Armbruster
drive_init() doesn't permit them for if=floppy, but that's worthless: we get them via if=none and -global. This can make device initialization fail. Since all callers of fdctrl_init_isa() ignore its value, change it to die instead of returning failure. Without this, some callers would ignore

[Qemu-devel] [PATCH v2 02/13] block migration: Fix test for read-only drive

2010-07-06 Thread Markus Armbruster
init_blk_migration_it() skips drives with type hint BDRV_TYPE_CDROM. The intention is to skip read-only drives. However, BDRV_TYPE_CDROM is only a hint. It is currently sufficent for read-only. But it's not necessary, and it may not remain sufficient. Use bdrv_is_read_only() instead.

[Qemu-devel] [PATCH v2 05/13] qdev: Don't hw_error() in qdev_init_nofail()

2010-07-06 Thread Markus Armbruster
Some of the failures are internal errors, and hw_error() is okay then. But the common way to fail is bad user input, e.g. -global isa-fdc.driveA=foo where drive foo has an unsupported rerror value. exit(1) instead. Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/qdev.c |6 --

[Qemu-devel] [PATCH 0/8] Split ide-drive and scsi-disk qdevs, and more

2010-07-06 Thread Markus Armbruster
This patch series is about purging the type hint from the block layer. My previous series cleaned up improper uses it. Remaining uses are info block and qdevs ide-drive, scsidisk. Remove the type hint from info block. Its value is unreliable anyway. ide-drive and scsi-disk can either act as

[Qemu-devel] [PATCH v2 00/13] Still more block related fixes and cleanups

2010-07-06 Thread Markus Armbruster
I'm working on cleanly separating block device host and guest parts. I'd like to route all this work through Kevin's block tree. This is still just preliminaries. This patch series is based available at git://repo.or.cz/qemu/armbru.git tag block-fixes-2-v2: this series, based on tag

[Qemu-devel] [PATCH v2 03/13] raw-posix: Fix test for host CD-ROM

2010-07-06 Thread Markus Armbruster
raw_pread_aligned() retries up to two times if the block device backs a virtual CD-ROM (a drive with media=cdrom and if=ide, scsi, xen or none). This makes no sense. Whether retrying reads can correct read errors can only depend on what we're reading, not on how the result gets used. We need to

[Qemu-devel] [PATCH 3/8] ide scsi virtio-blk: Reject empty drives unless media is removable

2010-07-06 Thread Markus Armbruster
Disks without media make no sense. For SCSI, a Linux guest kernel complains during boot. I didn't try other combinations. scsi-generic doesn't need the additional check, because it already requires bdrv_is_sg(), which fails without media. Signed-off-by: Markus Armbruster arm...@redhat.com ---

[Qemu-devel] [PATCH 8/8] block: Remove type hint

2010-07-06 Thread Markus Armbruster
No users left. bdrv_set_type_hint() can make the media removable by side effect. Make that explicit. Signed-off-by: Markus Armbruster arm...@redhat.com --- block.c | 12 block.h |5 - block_int.h |1 - blockdev.c |4 ++-- 4 files changed, 2 insertions(+),

[Qemu-devel] [PATCH 7/8] blockdev: Store -drive option media in DriveInfo

2010-07-06 Thread Markus Armbruster
Use it instead of bdrv_get_type_hint() to pick HD vs. CD for IDE, SCSI and XEN drives. Signed-off-by: Markus Armbruster arm...@redhat.com --- blockdev.c |1 + blockdev.h |1 + hw/ide/core.c |3 +-- hw/ide/qdev.c | 10 -- hw/scsi-disk.c |4

[Qemu-devel] Re: [PATCH 1/2] pci/bridge: allocate PCIBus dynamically for PCIBridge.

2010-07-06 Thread Michael S. Tsirkin
On Fri, Jul 02, 2010 at 11:30:11AM +0900, Isaku Yamahata wrote: allocate PCIBus dynamically for PCIBridge and bug fix of pci_unregister_secondary_bus(). could you make the bugfix a separate patch please? This is a preparation for splitting out pci_bridge functions. Since PCIBus is private to

[Qemu-devel] [PATCH 4/8] block QMP: Drop query-block member type (type= in info block)

2010-07-06 Thread Markus Armbruster
Its value is unreliable: a block device used as floppy has type floppy if created with if=floppy, but type hd if created with if=none. That's because with if=none, the type is at best a declaration of intent: the drive can be connected to any guest device. Its type is really the guest device's

[Qemu-devel] [PATCH 1/8] virtio-pci: Check for virtio_blk_init() failure

2010-07-06 Thread Markus Armbruster
It can't actually fail now, but the next commit will change that. s390_virtio_blk_init() already checks for failure, but virtio_blk_init_pci() doesn't. Fix that. Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/virtio-pci.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)

[Qemu-devel] Re: [PATCH 08/11] ide: Replace IDEState members is_cdrom, is_cf by drive_kind

2010-07-06 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 30.06.2010 13:55, schrieb Markus Armbruster: The two aren't independent variables. Make that obvious. Signed-off-by: Markus Armbruster arm...@redhat.com Can we please call the constant IDE_CDROM or something else that is easy to distinguish? With

[Qemu-devel] [PATCH 2/8] virtio-blk: Fix virtio-blk-s390 to require drive

2010-07-06 Thread Markus Armbruster
Move the check from virtio_blk_init_pci(), where it protects only virtio-blk-pci, to virtio_blk_init(). Without that, virtio-blk-s390 initializes without a drive. I figure that can lead to null pointer dereferences. Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/virtio-blk.c |6

[Qemu-devel] [PATCH 5/8] ide: Split qdev ide-drive into ide-hd and ide-cd

2010-07-06 Thread Markus Armbruster
Disk vs. CD needs to be in qdev, because it belongs to the drive's guest part. Keep ide-drive for backward compatibility. Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/ide/core.c | 11 +--- hw/ide/internal.h |2 +- hw/ide/qdev.c | 72

[Qemu-devel] [PATCH 6/8] scsi: Split qdev scsi-disk into scsi-hd and scsi-cd

2010-07-06 Thread Markus Armbruster
Disk vs. CD needs to be in qdev, because it belongs to the drive's guest part. Keep scsi-disk for backward compatibility. Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/scsi-disk.c | 117 +++ 1 files changed, 91 insertions(+), 26

[Qemu-devel] Re: Reg. trace infrastructure

2010-07-06 Thread Stefan Hajnoczi
On Mon, Jul 05, 2010 at 10:39:19PM +0530, Sripathi Kodi wrote: Hi Stefan, Prerna, I pulled down QEMU tracing code from git://repo.or.cz/qemu/stefanha.git and tried to use it to trace something in virtio-9p code. I don't have any knowledge of how traces are implemented and I just went with

[Qemu-devel] Re: [PATCH 08/11] ide: Replace IDEState members is_cdrom, is_cf by drive_kind

2010-07-06 Thread Kevin Wolf
Am 06.07.2010 14:38, schrieb Markus Armbruster: Kevin Wolf kw...@redhat.com writes: Am 30.06.2010 13:55, schrieb Markus Armbruster: The two aren't independent variables. Make that obvious. Signed-off-by: Markus Armbruster arm...@redhat.com Can we please call the constant IDE_CDROM or

[Qemu-devel] [Bug 600589] Re: xchg r8,rax treated as nop

2010-07-06 Thread Jes Sorensen
Per rth's reply to qemu-devel, fix has been pushed into upstream as of July 1st, commit 7418027ea4fec276455abd4291558bc58a0a7ba7 If problem reappears, please reopen or open a new bug. Closing ** Changed in: qemu Status: New = Fix Committed -- xchg r8,rax treated as nop

Re: [Qemu-devel] KVM Call agenda for July 6th

2010-07-06 Thread Anthony Liguori
On 07/05/2010 09:05 AM, Luiz Capitulino wrote: On Mon, 05 Jul 2010 14:45:23 +0200 Juan Quintelaquint...@redhat.com wrote: Please send in any agenda items you are interested in covering. - 0.13 release I was hoping to do -rc0 before the holiday but that didn't happen so I'm

Re: [Qemu-devel] KVM Call agenda for July 6th

2010-07-06 Thread Anthony Liguori
On 07/05/2010 11:52 PM, Alex Williamson wrote: On Mon, 2010-07-05 at 11:05 -0300, Luiz Capitulino wrote: On Mon, 05 Jul 2010 14:45:23 +0200 Juan Quintelaquint...@redhat.com wrote: Please send in any agenda items you are interested in covering. - 0.13 release -

[Qemu-devel] Re: KVM Call agenda for July 6th

2010-07-06 Thread Anthony Liguori
On 07/05/2010 07:45 AM, Juan Quintela wrote: Please send in any agenda items you are interested in covering. If we have a lack of agenda items I'll cancel the week's call. I've got a lot to catch up on after the mini-holiday so I'd rather skip the call unless there's a pressing agenda

Re: [Qemu-devel] KVM Call agenda for July 6th

2010-07-06 Thread Kevin Wolf
Am 06.07.2010 15:26, schrieb Anthony Liguori: On 07/05/2010 09:05 AM, Luiz Capitulino wrote: On Mon, 05 Jul 2010 14:45:23 +0200 Juan Quintelaquint...@redhat.com wrote: Please send in any agenda items you are interested in covering. - 0.13 release I was hoping to do -rc0

Re: [Qemu-devel] KVM Call agenda for July 6th

2010-07-06 Thread Anthony Liguori
On 07/06/2010 08:37 AM, Kevin Wolf wrote: Am 06.07.2010 15:26, schrieb Anthony Liguori: On 07/05/2010 09:05 AM, Luiz Capitulino wrote: On Mon, 05 Jul 2010 14:45:23 +0200 Juan Quintelaquint...@redhat.com wrote: Please send in any agenda items you are interested in

Re: [Qemu-devel] KVM Call agenda for July 6th

2010-07-06 Thread Alex Williamson
On Tue, 2010-07-06 at 08:26 -0500, Anthony Liguori wrote: On 07/05/2010 11:52 PM, Alex Williamson wrote: On Mon, 2010-07-05 at 11:05 -0300, Luiz Capitulino wrote: On Mon, 05 Jul 2010 14:45:23 +0200 Juan Quintelaquint...@redhat.com wrote: Please send in any agenda items

Re: [Qemu-devel] KVM Call agenda for July 6th

2010-07-06 Thread Kevin Wolf
Am 06.07.2010 15:53, schrieb Anthony Liguori: On 07/06/2010 08:37 AM, Kevin Wolf wrote: Am 06.07.2010 15:26, schrieb Anthony Liguori: On 07/05/2010 09:05 AM, Luiz Capitulino wrote: On Mon, 05 Jul 2010 14:45:23 +0200 Juan Quintelaquint...@redhat.com wrote: Please send

[Qemu-devel] Re: [PATCH v2 00/13] Still more block related fixes and cleanups

2010-07-06 Thread Kevin Wolf
Am 06.07.2010 14:08, schrieb Markus Armbruster: I'm working on cleanly separating block device host and guest parts. I'd like to route all this work through Kevin's block tree. This is still just preliminaries. This patch series is based available at git://repo.or.cz/qemu/armbru.git tag

Re: [Qemu-devel] Tracing: outstanding tasks

2010-07-06 Thread Stefan Hajnoczi
I have now moved the roadmap onto the wiki because it becomes hard to get a sense of the status from an email thread: http://wiki.qemu.org/Features/Tracing/Roadmap Stefan

[Qemu-devel] linux-user threading/gomp issue (with testcase for qemu-arm)

2010-07-06 Thread Jan-Simon Möller
Hi all ! I stumbled over https://computing.llnl.gov/tutorials/pthreads/samples/join.c and tried to run it with qemu-arm (gcc-arm -lm -lc -lpthread -o join join.c; qemu-arm ./join ). qemu-arm from 9f5a1fae7ee1a7c66462e5b8e9d21552d4dc5027 compiled with: ./configure --prefix=/usr \

[Qemu-devel] [Bug 601946] Re: [Feature request] qemu-img multi-threaded compressed image conversion

2010-07-06 Thread Jes Sorensen
Hi, The problem is that it is more than just the compression that is the problem, with modern cpus disk speed is a problem, and compression is often stream based. For now there isn't enough valid data that this qualifies as a bug/rfe. If you decide to try and implement it, and provide data

[Qemu-devel] patching qemu 0.9.0

2010-07-06 Thread Bryan Wilwerding
I have a 0.9.0 qemu package that was modified by a research project. I would like to upgrade this qemu package. Where I can find a patch for 0.9.0 to qemu 0.10 and higher? Regards, ding329

[Qemu-devel] KVM call minutes for July 6

2010-07-06 Thread Juan Quintela
Today was a short call as Anthony didn't attend. - Jes reminded people that Linux Plumbers deadline is July 19th - Qemu 0.13 (from the agenda, we didn't discuss it without Anthony). List of patches missing commit/comment/review from Anthony. We decided to send to the list an initial list, and

[Qemu-devel] [Bug 584121] Re: migration always fails on 32bit qemu-kvm-0.12+ (sigsegv)

2010-07-06 Thread Anthony Liguori
** Changed in: qemu Status: Incomplete = Confirmed -- migration always fails on 32bit qemu-kvm-0.12+ (sigsegv) https://bugs.launchpad.net/bugs/584121 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. Status in QEMU: Confirmed Bug

[Qemu-devel] [Bug 601946] Re: [Feature request] qemu-img multi-threaded compressed image conversion

2010-07-06 Thread Коренберг Марк
1. during benchmark I used iotop and just top. qemu-img is eating all my cpu (3.07 Ghz) and disk streaming was at low speeds. 2. Writing on disk in ext4 is cached very strongly, so writing in 4 streams is not the problem. 3. For example, 7z give huge speed increase in when compressing in

[Qemu-devel] Re: [PATCH v6] block: add sheepdog driver for distributed storage support

2010-07-06 Thread Kevin Wolf
Am 20.06.2010 22:01, schrieb MORITA Kazutaka: Sheepdog is a distributed storage system for QEMU. It provides highly available block level storage volumes to VMs like Amazon EBS. This patch adds a qemu block driver for Sheepdog. Sheepdog features are: - No node in the cluster is special (no

Re: [Qemu-devel] KVM Call agenda for July 6th

2010-07-06 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 06.07.2010 15:53, schrieb Anthony Liguori: On 07/06/2010 08:37 AM, Kevin Wolf wrote: Am 06.07.2010 15:26, schrieb Anthony Liguori: On 07/05/2010 09:05 AM, Luiz Capitulino wrote: On Mon, 05 Jul 2010 14:45:23 +0200 Juan

Re: [Qemu-devel] KVM Call agenda for July 6th

2010-07-06 Thread Kevin Wolf
Am 06.07.2010 17:19, schrieb Markus Armbruster: Kevin Wolf kw...@redhat.com writes: Am 06.07.2010 15:53, schrieb Anthony Liguori: On 07/06/2010 08:37 AM, Kevin Wolf wrote: Am 06.07.2010 15:26, schrieb Anthony Liguori: On 07/05/2010 09:05 AM, Luiz Capitulino wrote: On Mon, 05

Re: [Qemu-devel] KVM call minutes for July 6

2010-07-06 Thread Cam Macdonell
On Tue, Jul 6, 2010 at 8:46 AM, Juan Quintela quint...@redhat.com wrote: Today was a short call as Anthony didn't attend. - Jes reminded people that Linux Plumbers deadline is July 19th - Qemu 0.13 (from the agenda, we didn't discuss it without Anthony). List of patches missing

[Qemu-devel] [PULL 00/17] Block patches

2010-07-06 Thread Kevin Wolf
The following changes since commit 734003e6153b3552b9406ef598a1e67aac4a899e: Anthony Liguori (1): Merge remote branch 'kwolf/for-anthony' into staging are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Kevin Wolf (2): qemu-img check:

Re: [Qemu-devel] KVM Call agenda for July 6th

2010-07-06 Thread Anthony Liguori
On 07/06/2010 10:27 AM, Kevin Wolf wrote: Any chance to get the next series (Split ide-drive and scsi-disk qdevs, and more) as well? 1-3/8 are bug fixes, and 4/8 removes unreliable information from info block; wanted in .13. 5-8/8 could be punted to .14. If it's purely bug fixes, I

[Qemu-devel] [PATCH 06/17] raw-posix: Fix test for host CD-ROM

2010-07-06 Thread Kevin Wolf
From: Markus Armbruster arm...@redhat.com raw_pread_aligned() retries up to two times if the block device backs a virtual CD-ROM (a drive with media=cdrom and if=ide, scsi, xen or none). This makes no sense. Whether retrying reads can correct read errors can only depend on what we're reading,

[Qemu-devel] [PATCH 01/17] qemu-img check: Distinguish different kinds of errors

2010-07-06 Thread Kevin Wolf
People think that their images are corrupted when in fact there are just some leaked clusters. Differentiating several error cases should make the messages more comprehensible. Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c| 10 ++-- block.h| 10 - qemu-img.c |

[Qemu-devel] [PATCH 03/17] Add virtio disk identification support

2010-07-06 Thread Kevin Wolf
From: john cooper john.coo...@redhat.com This patch adds the final missing bits for support of passing a serial/id string to a virtio-blk guest driver. The guest-side component already exists in the virtio driver, and has recently been reworked by Ryan to export a /sys interface for retrieval of

[Qemu-devel] [PATCH 04/17] blockdev: Clean up how readonly persists across virtual media change

2010-07-06 Thread Kevin Wolf
From: Markus Armbruster arm...@redhat.com Since commit cb4e5f8e, monitor command change makes the new media readonly iff the type hint is BDRV_TYPE_CDROM, i.e. the drive was created with media=cdrom. The intention is to avoid changing a block device's read-only-ness. However, BDRV_TYPE_CDROM is

[Qemu-devel] [PATCH 02/17] qcow2/vdi: Change check to distinguish error cases

2010-07-06 Thread Kevin Wolf
This distinguishes between harmless leaks and real corruption. Hopefully users better understand what qemu-img check wants to tell them. Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c|3 +- block/qcow2-refcount.c | 120 ++--

[Qemu-devel] [PATCH 11/17] scsi: Error locations for -drive if=scsi device initialization

2010-07-06 Thread Kevin Wolf
From: Markus Armbruster arm...@redhat.com Signed-off-by: Markus Armbruster arm...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- hw/scsi-bus.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c index b84b9b9..d69c74c 100644 ---

[Qemu-devel] [PATCH 08/17] qdev: Don't hw_error() in qdev_init_nofail()

2010-07-06 Thread Kevin Wolf
From: Markus Armbruster arm...@redhat.com Some of the failures are internal errors, and hw_error() is okay then. But the common way to fail is bad user input, e.g. -global isa-fdc.driveA=foo where drive foo has an unsupported rerror value. exit(1) instead. Signed-off-by: Markus Armbruster

[Qemu-devel] [PATCH 07/17] fdc: Reject unimplemented error actions

2010-07-06 Thread Kevin Wolf
From: Markus Armbruster arm...@redhat.com drive_init() doesn't permit them for if=floppy, but that's worthless: we get them via if=none and -global. This can make device initialization fail. Since all callers of fdctrl_init_isa() ignore its value, change it to die instead of returning failure.

[Qemu-devel] [PATCH 10/17] error: New qemu_opts_loc_restore()

2010-07-06 Thread Kevin Wolf
From: Markus Armbruster arm...@redhat.com Needed for decent error locations when complaining about options outside of qemu_opts_foreach(). That one sets the location already. Signed-off-by: Markus Armbruster arm...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- qemu-option.c |5

[Qemu-devel] [PATCH 17/17] block: add sheepdog driver for distributed storage support

2010-07-06 Thread Kevin Wolf
From: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp Sheepdog is a distributed storage system for QEMU. It provides highly available block level storage volumes to VMs like Amazon EBS. This patch adds a qemu block driver for Sheepdog. Sheepdog features are: - No node in the cluster is special

[Qemu-devel] [PATCH 16/17] ide: Reject invalid CHS geometry

2010-07-06 Thread Kevin Wolf
From: Markus Armbruster arm...@redhat.com drive_init() doesn't permit invalid CHS for if=ide, but that's worthless: we get it via if=none and -device. Signed-off-by: Markus Armbruster arm...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- hw/ide/core.c | 12 1 files

Re: [Qemu-devel] [PATCH 1/1] Include sys/mman.h before qemu-options.h

2010-07-06 Thread Anthony Liguori
On 07/06/2010 03:50 AM, jes.soren...@redhat.com wrote: From: Jes Sorensenjes.soren...@redhat.com The result of parsing qemu-options.def depends on whehter or not MAP_POPULATE is defined, so make sure to include sys/mman.h before including qemu-options.h. Reported by Frank Arnold.

[Qemu-devel] [PATCH 14/17] ide: Make ide_init_drive() return success

2010-07-06 Thread Kevin Wolf
From: Markus Armbruster arm...@redhat.com It still always succeeds. The next commits will add failures. Signed-off-by: Markus Armbruster arm...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- hw/ide/core.c | 13 + hw/ide/internal.h |4 ++-- hw/ide/qdev.c |

Re: [Qemu-devel] [PATCH] scsi: Fix SCSI bus reset

2010-07-06 Thread Anthony Liguori
On 07/06/2010 03:58 AM, Jan Kiszka wrote: When the controller raises the SCSI reset line, we have to perform the requested reset on all disks attached to the controller's bus. Moreover, reset is edge triggered, so avoid repeating it if the line was already high. Signed-off-by: Jan

[Qemu-devel] [Bug 601946] Re: [Feature request] qemu-img multi-threaded compressed image conversion

2010-07-06 Thread Jan-Simon Möller
There're also projects like http://compression.ca/pbzip2/ . We'll be facing more and more cores per cpu, so we should use these techniques. -- [Feature request] qemu-img multi-threaded compressed image conversion https://bugs.launchpad.net/bugs/601946 You received this bug notification because

Re: [Qemu-devel] [PATCH 00/23][PULL]: QMP/Monitor queue

2010-07-06 Thread Anthony Liguori
On 07/01/2010 02:21 PM, Luiz Capitulino wrote: Hi Anthony, The following QMP/Monitor patches have been sent to the list and look good to me. I also did some basic testing on them. Most of these changes are bug fixes, the only exception is my new argument checker series, which is a complete

[Qemu-devel] [Bug 543478] Re: qemus pmemsave doesn't accept / in filename

2010-07-06 Thread Muelli
Here's a patch against qemu from git that prints the offending characters, helping the user to understand what's going on. I can't deal with qemu-devel myself, it's way too noisy. But Ubuntu might want to take that patch or push it upstream. ** Patch added: Patch which prints the errorneous

Re: [Qemu-devel] [PATCH v2 01/16] Remove uses of ram.last_offset (aka last_ram_offset)

2010-07-06 Thread Anthony Liguori
On 06/25/2010 12:08 PM, Alex Williamson wrote: We currently need this either to allocate the next ram_addr_t for a new block, or for total memory to be migrated. Both of which we can calculate without need of this to keep us in a contiguous address space. Signed-off-by: Alex

Re: [Qemu-devel] [PATCH] make rtc alatm work

2010-07-06 Thread Anthony Liguori
On 07/05/2010 03:36 AM, Gleb Natapov wrote: Convert alarm time from BCD if needed before comparing with current time. Signed-off-by: Gleb Natapovg...@redhat.com Applied. Thanks. Regards, Anthony Liguori diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c index c3459bf..2b91fa8 100644

Re: [Qemu-devel] [PATCH] Fix io-thread build breakage of a88790a14f

2010-07-06 Thread Anthony Liguori
On 07/06/2010 03:49 AM, Jan Kiszka wrote: Nigel Horne wrote: ./configure --enable-linux-aio --enable-io-thread --enable-kvm make ... /home/njh/src/qemu/cpus.c:532: error: ‘exit_request’ undeclared (first use in this function) /home/njh/src/qemu/cpus.c:532: error: (Each undeclared identifier

Re: [Qemu-devel] [PATCH][RESEND] qdev-properties: Fix (u)intXX parsers

2010-07-06 Thread Anthony Liguori
On 06/18/2010 11:27 AM, Kevin Wolf wrote: scanf calls must not use PRI constants, they have probably the wrong size and corrupt memory. We could replace them by SCN ones, but strtol is simpler than scanf here anyway. While at it, also fix the parsers to reject garbage after the number (4096xyz

Re: [Qemu-devel] [PATCH] Fix io-thread build breakage of a88790a14f

2010-07-06 Thread Jan Kiszka
Anthony Liguori wrote: On 07/06/2010 03:49 AM, Jan Kiszka wrote: Nigel Horne wrote: ./configure --enable-linux-aio --enable-io-thread --enable-kvm make ... /home/njh/src/qemu/cpus.c:532: error: ‘exit_request’ undeclared (first use in this function) /home/njh/src/qemu/cpus.c:532:

[Qemu-devel] [Bug 602336] [NEW] bad network performance with 10Gbit

2010-07-06 Thread zerocoolx
Public bug reported: Hello, I have trouble with the network performance inside my virtual machines. I don't know if this is realy a bug, but I didn't find a solution for this problem in other forums or maillists. My KVM-Host machine is connected to a 10Gbit Network. All interfaces are

[Qemu-devel] [PATCH] pc: Avoid registering zero sized memory

2010-07-06 Thread Alex Williamson
No need to call cpu_register_physical_memory() for a zero sized area. Signed-off-by: Alex Williamson alex.william...@redhat.com --- hw/pc.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index a96187f..58dea57 100644 --- a/hw/pc.c +++ b/hw/pc.c

[Qemu-devel] [Bug 543478] Re: qemus pmemsave doesn't accept / in filename

2010-07-06 Thread Brian Murray
** Tags added: patch -- qemus pmemsave doesn't accept / in filename https://bugs.launchpad.net/bugs/543478 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. Status in QEMU: Invalid Status in “qemu-kvm” package in Ubuntu: Incomplete Bug

Re: [Qemu-devel] patching qemu 0.9.0

2010-07-06 Thread Natalia Portillo
Hi, El 06/07/2010, a las 15:41, Bryan Wilwerding escribió: I have a 0.9.0 qemu package that was modified by a research project. I would like to upgrade this qemu package. Where I can find a patch for 0.9.0 to qemu 0.10 and higher? You can use the git to obtain a patch between two

Re: [Qemu-devel] patching qemu 0.9.0

2010-07-06 Thread Anthony Liguori
On 07/06/2010 11:42 AM, Natalia Portillo wrote: Hi, El 06/07/2010, a las 15:41, Bryan Wilwerding escribió: I have a 0.9.0 qemu package that was modified by a research project. I would like to upgrade this qemu package. Where I can find a patch for 0.9.0 to qemu 0.10 and higher?

[Qemu-devel] Re: [PATCH 4/8] block QMP: Drop query-block member type (type= in info block)

2010-07-06 Thread Kevin Wolf
Am 06.07.2010 14:37, schrieb Markus Armbruster: Its value is unreliable: a block device used as floppy has type floppy if created with if=floppy, but type hd if created with if=none. That's because with if=none, the type is at best a declaration of intent: the drive can be connected to any

Re: [Qemu-devel] [PULL 00/17] Block patches

2010-07-06 Thread Anthony Liguori
On 07/06/2010 10:33 AM, Kevin Wolf wrote: The following changes since commit 734003e6153b3552b9406ef598a1e67aac4a899e: Anthony Liguori (1): Merge remote branch 'kwolf/for-anthony' into staging Pulled. Thanks. Regards, Anthony Liguori are available in the git repository at:

Re: [Qemu-devel] [PATCH] Makefile: Fix compilation for non-standard host kernel path

2010-07-06 Thread Anthony Liguori
On 07/02/2010 06:15 AM, Prerna Saxena wrote: Set up host kernel include paths specified by --kerneldir When host kernel headers are placed in non-standard paths, the KVM_CFLAGS are presently invoked only for a few .c files (kvm*.c,vhost*.c) and not for other files like machine.c, cpus.c

[Qemu-devel] [PATCH 1/3] trace: Document programmatically enabling/disabling trace events

2010-07-06 Thread Stefan Hajnoczi
The simple trace backend exports a function that can be used to programmatically enable/disable trace events at runtime. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- This applies to the tracing branch at: http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/tracing-dev

[Qemu-devel] [PATCH 3/3] trace: Flush trace buffer on exit

2010-07-06 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- This applies to the tracing branch at: http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/tracing-dev simpletrace.c | 23 +++ 1 files changed, 15 insertions(+), 8 deletions(-) diff --git

[Qemu-devel] [PATCH 2/3] trace: Conform to QEMU coding style

2010-07-06 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- This applies to the tracing branch at: http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/tracing-dev simpletrace.c | 21 ++--- tracetool |3 ++- 2 files changed, 16 insertions(+), 8 deletions(-)

[Qemu-devel] [PATCH 2/2] QMP: Require 'use_unstable' arg for capabilities negotiation

2010-07-06 Thread Luiz Capitulino
This helps ensuring two things: 1. An initial warning on client writers playing with current QMP 2. Clients using unstable QMP will break when we declare QMP stable and drop that argument Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- QMP/README |2 +- QMP/qmp-shell |

[Qemu-devel] [PATCH 0/2]: QMP: ensure we will break unstable clients

2010-07-06 Thread Luiz Capitulino
First patch is a small README update, important change is in second patch. Thanks.

[Qemu-devel] Re: [PATCH v2 02/13] block migration: Fix test for read-only drive

2010-07-06 Thread Christoph Hellwig
Ok, Reviewed-by: Christoph Hellwig h...@lst.de

[Qemu-devel] Re: [PATCH v2 03/13] raw-posix: Fix test for host CD-ROM

2010-07-06 Thread Christoph Hellwig
On Tue, Jul 06, 2010 at 02:08:46PM +0200, Markus Armbruster wrote: * Any drive backed by host_floppy now retries. I would really prefer not to change the behaviour for this case, it'll just confuse people looking at the history when finally removing this hack.

[Qemu-devel] Re: [PATCH v2 04/13] fdc: Reject unimplemented error actions

2010-07-06 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig h...@lst.de

[Qemu-devel] Re: [PATCH v2 06/13] scsi: Reject unimplemented error actions

2010-07-06 Thread Christoph Hellwig
On Tue, Jul 06, 2010 at 02:08:49PM +0200, Markus Armbruster wrote: drive_init() doesn't permit rerror for if=scsi, but that's worthless: we get it via if=none and -device. Moreover, scsi-generic doesn't support werror. Since drive_init() doesn't catch that, option werror was silently

[Qemu-devel] Re: [PATCH v2 07/13] error: New qemu_opts_loc_restore()

2010-07-06 Thread Christoph Hellwig
On Tue, Jul 06, 2010 at 02:08:50PM +0200, Markus Armbruster wrote: Needed for decent error locations when complaining about options outside of qemu_opts_foreach(). That one sets the location already. Ok.

  1   2   >