[Qemu-devel] [PATCH] Correct use of ! and

2010-08-21 Thread Blue Swirl
Combining bitwise AND and logical NOT is suspicious. Fixed by this Coccinelle script: // From http://article.gmane.org/gmane.linux.kernel/646367 @@ expression E1,E2; @@ ( !E1 !E2 | - !E1 E2 + !(E1 E2) ) Signed-off-by: Blue Swirl blauwir...@gmail.com --- Maybe the middle hunk should be

Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments

2010-08-21 Thread Markus Armbruster
Blue Swirl blauwir...@gmail.com writes: On Fri, Aug 20, 2010 at 6:44 PM, Blue Swirl blauwir...@gmail.com wrote: On Fri, Aug 20, 2010 at 1:47 PM, Markus Armbruster arm...@redhat.com wrote: Anthony Liguori anth...@codemonkey.ws writes: To be perfectly honest, we have enough hard problems to

Re: [Qemu-devel] [PATCH] qdev: Reset hotplugged devices

2010-08-21 Thread Markus Armbruster
Anthony Liguori anth...@codemonkey.ws writes: On 08/20/2010 11:14 AM, Markus Armbruster wrote: The real problem is how we do reset. We shouldn't register a reset handler for every qdev device but rather register a single reset handler that walks the device tree and calls reset on every

Re: [Qemu-devel] segfault due to missing qdev_create()?

2010-08-21 Thread Markus Armbruster
Hollis Blanchard hol...@penguinppc.org writes: I am able to run qemu with the following commandline: /usr/local/bin/qemu-system-ppcemb -enable-kvm -kernel uImage.bamboo -nographic -M bamboo ppc440-angstrom-linux.img However, when I try to use virtio instead, I get this segfault:

Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments

2010-08-21 Thread Blue Swirl
On Sat, Aug 21, 2010 at 9:54 AM, Markus Armbruster arm...@redhat.com wrote: Blue Swirl blauwir...@gmail.com writes: On Fri, Aug 20, 2010 at 6:44 PM, Blue Swirl blauwir...@gmail.com wrote: On Fri, Aug 20, 2010 at 1:47 PM, Markus Armbruster arm...@redhat.com wrote: Anthony Liguori

Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments

2010-08-21 Thread Markus Armbruster
Blue Swirl blauwir...@gmail.com writes: On Sat, Aug 21, 2010 at 9:54 AM, Markus Armbruster arm...@redhat.com wrote: Blue Swirl blauwir...@gmail.com writes: On Fri, Aug 20, 2010 at 6:44 PM, Blue Swirl blauwir...@gmail.com wrote: On Fri, Aug 20, 2010 at 1:47 PM, Markus Armbruster

Re: [Qemu-devel] [PATCH] Correct use of ! and

2010-08-21 Thread Markus Armbruster
Blue Swirl blauwir...@gmail.com writes: Combining bitwise AND and logical NOT is suspicious. Fixed by this Coccinelle script: // From http://article.gmane.org/gmane.linux.kernel/646367 @@ expression E1,E2; @@ ( !E1 !E2 | - !E1 E2 + !(E1 E2) ) Signed-off-by: Blue Swirl

[Qemu-devel] patch: use correct output format in wm8750_set_format()

2010-08-21 Thread Austin English
Looks like a typo. Found when compiling with gcc 4.6, which sets -Werror=unused-but-set-variable. Please cc me on any replies. -- -Austin diff --git a/hw/wm8750.c b/hw/wm8750.c index ce43c23..4c864e4 100644 --- a/hw/wm8750.c +++ b/hw/wm8750.c @@ -223,7 +223,7 @@ static void

Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments

2010-08-21 Thread Blue Swirl
On Sat, Aug 21, 2010 at 12:24 PM, Markus Armbruster arm...@redhat.com wrote: Blue Swirl blauwir...@gmail.com writes: On Sat, Aug 21, 2010 at 9:54 AM, Markus Armbruster arm...@redhat.com wrote: Blue Swirl blauwir...@gmail.com writes: On Fri, Aug 20, 2010 at 6:44 PM, Blue Swirl

[Qemu-devel] [Bug 621780] [NEW] 160 unused but set variables in QEMU

2010-08-21 Thread austin_is
Public bug reported: I use gcc from SVN on my desktop: aus...@midna:~/gits/qemu$ gcc -v Using built-in specs. COLLECT_GCC=gcc COLLECT_LTO_WRAPPER=/usr/local/libexec/gcc/x86_64-unknown-linux-gnu/4.6.0/lto-wrapper Target: x86_64-unknown-linux-gnu Configured with: ./configure

[Qemu-devel] [Bug 621780] Re: 160 unused but set variables in QEMU

2010-08-21 Thread austin_is
Forgot to add, this is with git head, commit cc597832119dd1504f1c1536bb5f903d8970af2a. -- 160 unused but set variables in QEMU https://bugs.launchpad.net/bugs/621780 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. Status in QEMU: New

[Qemu-devel] [Bug 621780] Re: 160 unused but set variables in QEMU

2010-08-21 Thread austin_is
** Attachment added: make.txt https://bugs.launchpad.net/bugs/621780/+attachment/1508292/+files/make.txt -- 160 unused but set variables in QEMU https://bugs.launchpad.net/bugs/621780 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH - V3] Port codes from qemu-kvm to support booting from SCSI disk image

2010-08-21 Thread Kevin O'Connor
On Fri, Aug 20, 2010 at 09:39:10AM -0500, Anthony Liguori wrote: On 08/20/2010 09:09 AM, Gerd Hoffmann wrote: Been there, tried that. It isn't *that* easy. The PCI ID in the option rom header doesn't match the PCI ID of the emulated lsi, so seabios refuses to load it from the rom bar.

Re: [Qemu-devel] [PATCH] Correct use of ! and

2010-08-21 Thread Blue Swirl
On Sat, Aug 21, 2010 at 1:19 PM, Markus Armbruster arm...@redhat.com wrote: Blue Swirl blauwir...@gmail.com writes: Combining bitwise AND and logical NOT is suspicious. Fixed by this Coccinelle script: // From http://article.gmane.org/gmane.linux.kernel/646367 @@ expression E1,E2; @@ (  

Re: [Qemu-devel] [PATCH] qdev: Reset hotplugged devices

2010-08-21 Thread Anthony Liguori
On 08/21/2010 05:07 AM, Markus Armbruster wrote: diff --git a/vl.c b/vl.c index b3e3676..5de1688 100644 --- a/vl.c +++ b/vl.c @@ -2968,6 +2968,9 @@ int main(int argc, char **argv, char **envp) } qemu_system_reset(); + +qemu_register_reset((void *)qbus_reset_all,

Re: [Qemu-devel] qemu-system-arm aborted

2010-08-21 Thread Chih-Min Chao
2010/8/21 S W s...@hotmail.co.jp Hi there I made an ARM Linux2.6.10 image(zImage) and I tried to run it on QEMU using the following command. qemu-system-arm -kernel zImage -nographic I got an error message like: CPU #0: R00= R01=0113 R02=0100 R03= R04=

[Qemu-devel] [Bug 621950] [NEW] qemu not able to run 64 bit OS when -enable-kvm is used with a 64 bit processor

2010-08-21 Thread bhasker
Public bug reported: Hi, The host processor is a 64 bit processor (as below) When I run the emulated mode of 64 bit (full emulation) I can run the 64 bit OS fine. when I start using -enable-kvm, I get error message that Your CPU does not support long mode. Use a 32bit distribution. trying

[Qemu-devel] [Bug 621950] Re: qemu not able to run 64 bit OS when -enable-kvm is used with a 64 bit processor

2010-08-21 Thread Anthony Liguori
Because you're using a 32-bit OS in the host. ** Changed in: qemu Status: New = Invalid -- qemu not able to run 64 bit OS when -enable-kvm is used with a 64 bit processor https://bugs.launchpad.net/bugs/621950 You received this bug notification because you are a member of qemu- devel-ml,

[Qemu-devel] [PATCH] fat_chksum(): fix access above array bounds

2010-08-21 Thread Loïc Minier
Signed-off-by: Loïc Minier loic.min...@linaro.org --- block/vvfat.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block/vvfat.c b/block/vvfat.c index 6d61c2e..365332a 100644 --- a/block/vvfat.c +++ b/block/vvfat.c @@ -512,7 +512,7 @@ static inline uint8_t

[Qemu-devel] [PATCH] block: Make BSG detection more sane in hdev_open()

2010-08-21 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Greetings hch, tomo and Co, This patch changes the Linux BSG backstore detect logic in hdev_open() in order to determine when to actually set 'bs-sg = BDS_BSG;' by obtaining the BSG major from a SysFS attribute in /sys/class/bsg/$H:C:T:L/dev, instead

[Qemu-devel] Re: [PATCH] block: Make BSG detection more sane in hdev_open()

2010-08-21 Thread Nicholas A. Bellinger
On Sat, 2010-08-21 at 16:01 -0700, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org Greetings hch, tomo and Co, This patch changes the Linux BSG backstore detect logic in hdev_open() in order to determine when to actually set 'bs-sg = BDS_BSG;' by obtaining the

[Qemu-devel] qemu-system-arm icp_control error

2010-08-21 Thread S W
Hi I am testing an ARM Linux 2.6.10 Image(zImage). When I run qemu-system-arm -kernel zImage -nographic the following error happened. Could anybody give what is wrong? Thanks Terry qemu: hardware error: icp_control_write: Bad offset 7fffe8 CPU #0: R00= R01=0113