[Qemu-devel] [PATCH] Use gcc warning flag -Wnested-externs, fix warnings

2010-09-04 Thread Blue Swirl
If the compiler supports the warning flag -Wnested-externs, use it. Fix the only warning by moving the xml_builtin declaration to a more proper place. Signed-off-by: Blue Swirl --- configure |2 +- feature_to_c.sh |1 - gdbstub.c |1 - gdbstub.h |3 +++ 4 files

Re: [Qemu-devel] [PATCH 1/5] Suppress some gcc warnings with -Wtype-limits

2010-09-04 Thread malc
On Sat, 4 Sep 2010, Blue Swirl wrote: > On Sat, Sep 4, 2010 at 5:57 PM, andrzej zaborowski wrote: > > On 4 September 2010 19:21, Blue Swirl wrote: > >> On Sat, Sep 4, 2010 at 4:44 PM, andrzej zaborowski > >> wrote: > >>> On 4 September 2010 18:14, Blue Swirl wrote: > On Sat, Sep 4, 2010

Re: [Qemu-devel] [PATCH 1/5] Suppress some gcc warnings with -Wtype-limits

2010-09-04 Thread Blue Swirl
On Sat, Sep 4, 2010 at 8:30 PM, andrzej zaborowski wrote: > Hi, > > On 4 September 2010 21:45, Blue Swirl wrote: >> On Sat, Sep 4, 2010 at 5:57 PM, andrzej zaborowski wrote:  -    if (event < 0 || event >= BLKDBG_EVENT_MAX) {  +    if ((int)event < 0 || event >= BLKDBG_EVENT_MAX) { >>>

Re: [Qemu-devel] [PATCH 1/5] Suppress some gcc warnings with -Wtype-limits

2010-09-04 Thread andrzej zaborowski
Hi, On 4 September 2010 21:45, Blue Swirl wrote: > On Sat, Sep 4, 2010 at 5:57 PM, andrzej zaborowski wrote: >>>  -    if (event < 0 || event >= BLKDBG_EVENT_MAX) { >>>  +    if ((int)event < 0 || event >= BLKDBG_EVENT_MAX) { >> Is the behaviour incorrect for some values, or is it not correct C?

[Qemu-devel] [PATCH] Use gcc warning flag -Wempty-body, fix warnings

2010-09-04 Thread Blue Swirl
If the compiler supports the warning flag -Wempty-body, use it. Adjust the code to avoid the warnings. Signed-off-by: Blue Swirl --- configure |2 +- hw/omap_i2c.c |5 +++-- hw/omap_mmc.c |5 +++-- hw/pxa2xx.c |5 +++-- hw/soc_dma.c |5 +++-- targe

[Qemu-devel] [PATCH] Use a few more gcc warning flags

2010-09-04 Thread Blue Swirl
If the compiler supports the following warning flags, use them: -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wmissing-include-dirs -Wclobbered Currently, these flags don't produce any warnings. Signed-off-by: Blue Swirl --- configure |5 - 1 files changed, 4 inserti

Re: [Qemu-devel] [PATCH 1/5] Suppress some gcc warnings with -Wtype-limits

2010-09-04 Thread Blue Swirl
On Sat, Sep 4, 2010 at 5:57 PM, andrzej zaborowski wrote: > On 4 September 2010 19:21, Blue Swirl wrote: >> On Sat, Sep 4, 2010 at 4:44 PM, andrzej zaborowski wrote: >>> On 4 September 2010 18:14, Blue Swirl wrote: On Sat, Sep 4, 2010 at 3:40 PM, andrzej zaborowski wrote: > On 4

Re: [Qemu-devel] [PATCH 1/5] Suppress some gcc warnings with -Wtype-limits

2010-09-04 Thread andrzej zaborowski
On 4 September 2010 19:21, Blue Swirl wrote: > On Sat, Sep 4, 2010 at 4:44 PM, andrzej zaborowski wrote: >> On 4 September 2010 18:14, Blue Swirl wrote: >>> On Sat, Sep 4, 2010 at 3:40 PM, andrzej zaborowski >>> wrote: On 4 September 2010 16:17, Blue Swirl wrote: > Add various casts,

Re: [Qemu-devel] [PATCH 1/5] Suppress some gcc warnings with -Wtype-limits

2010-09-04 Thread Blue Swirl
On Sat, Sep 4, 2010 at 4:44 PM, andrzej zaborowski wrote: > On 4 September 2010 18:14, Blue Swirl wrote: >> On Sat, Sep 4, 2010 at 3:40 PM, andrzej zaborowski wrote: >>> On 4 September 2010 16:17, Blue Swirl wrote: Add various casts, adjust types etc. to make the warnings with gcc fla

Re: [Qemu-devel] [PATCH 1/5] Suppress some gcc warnings with -Wtype-limits

2010-09-04 Thread andrzej zaborowski
On 4 September 2010 18:14, Blue Swirl wrote: > On Sat, Sep 4, 2010 at 3:40 PM, andrzej zaborowski wrote: >> On 4 September 2010 16:17, Blue Swirl wrote: >>> Add various casts, adjust types etc. to make the warnings with >>> gcc flag -Wtype-limits disappear. >>> >>> Signed-off-by: Blue Swirl >>>

Re: [Qemu-devel] [PATCH 1/5] Suppress some gcc warnings with -Wtype-limits

2010-09-04 Thread Blue Swirl
On Sat, Sep 4, 2010 at 3:40 PM, andrzej zaborowski wrote: > On 4 September 2010 16:17, Blue Swirl wrote: >> Add various casts, adjust types etc. to make the warnings with >> gcc flag -Wtype-limits disappear. >> >> Signed-off-by: Blue Swirl >> --- >>  block/blkdebug.c      |    2 +- >>  hw/mips_f

Re: [Qemu-devel] [PATCH 4/5] pxa2xx: fix SSSR TFN logic

2010-09-04 Thread Blue Swirl
On Sat, Sep 4, 2010 at 3:30 PM, andrzej zaborowski wrote: > Hi, > > On 4 September 2010 16:17, Blue Swirl wrote: >> Fix SSSR TFN logic: TX FIFO is never filled, so it is always in >> underrun condition if SSP is enabled. > > As far as I see this doesn't make any change when the port is enabled? >

Re: [Qemu-devel] [PATCH 1/5] Suppress some gcc warnings with -Wtype-limits

2010-09-04 Thread andrzej zaborowski
On 4 September 2010 16:17, Blue Swirl wrote: > Add various casts, adjust types etc. to make the warnings with > gcc flag -Wtype-limits disappear. > > Signed-off-by: Blue Swirl > --- >  block/blkdebug.c      |    2 +- >  hw/mips_fulong2e.c    |    2 +- >  hw/omap1.c            |    2 +- >  hw/ppc4

[Qemu-devel] [PATCH v3] blkverify: Add block driver for verifying I/O

2010-09-04 Thread Stefan Hajnoczi
The blkverify block driver makes investigating image format data corruption much easier. A raw image initialized with the same contents as the test image (e.g. qcow2 file) must be provided. The raw image mirrors read/write operations and is used to verify that data read from the test image is cor

[Qemu-devel] [PATCH v3] blkverify: Add block driver for verifying I/O

2010-09-04 Thread Stefan Hajnoczi
The blkverify block driver makes investigating image format data corruption much easier. A raw image initialized with the same contents as the test image (e.g. qcow2 file) must be provided. The raw image mirrors read/write operations and is used to verify that data read from the test image is cor

Re: [Qemu-devel] [PATCH 4/5] pxa2xx: fix SSSR TFN logic

2010-09-04 Thread andrzej zaborowski
Hi, On 4 September 2010 16:17, Blue Swirl wrote: > Fix SSSR TFN logic: TX FIFO is never filled, so it is always in > underrun condition if SSP is enabled. As far as I see this doesn't make any change when the port is enabled? How does it fix the logic then? Cheers

Re: [Qemu-devel] [PATCH v2] blkverify: Add block driver for verifying I/O

2010-09-04 Thread Stefan Hajnoczi
I need to fix a build error in this patch. Sorry for the noise, will send v3. Stefan

Re: [Qemu-devel] Unmaintained QEMU builds

2010-09-04 Thread Andreas Färber
Am 17.08.2010 um 21:56 schrieb Anthony Liguori: I think we have a lot of dump-and-run features in QEMU whereas someone writes the patches to implement something and then disappears. Often time, the feature is not generally useful so the code just rots. I think an awful lot of the PPC boar

[Qemu-devel] [PATCH 5/5] Use gcc warning flag -Wtype-limits

2010-09-04 Thread Blue Swirl
If the compiler supports the warning flag -Wtype-limits, use it. Signed-off-by: Blue Swirl --- configure |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure b/configure index 146dac0..47bbe39 100755 --- a/configure +++ b/configure @@ -138,7 +138,7 @@ QEMU_CFLAGS="

[Qemu-devel] [PATCH 3/5] MIPS: fix yield handling

2010-09-04 Thread Blue Swirl
The parameter for yield should be handled as signed integer for the comparisons to have any effect. This also fixes a gcc warning with -Wtype-limits. Signed-off-by: Blue Swirl --- target-mips/op_helper.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/target-mips/op_

[Qemu-devel] [PATCH 2/5] PPC: Suppress gcc warnings with -Wtype-limits

2010-09-04 Thread Blue Swirl
The hack added by c5b76b381081680633e2e0a91216507430409fb2 was not enough to fix warnings with gcc flag -Wtype-limits. Add a new macro to fix both problems. Signed-off-by: Blue Swirl --- target-ppc/op_helper.c | 50 1 files changed, 25 insertion

[Qemu-devel] [PATCH 4/5] pxa2xx: fix SSSR TFN logic

2010-09-04 Thread Blue Swirl
Fix SSSR TFN logic: TX FIFO is never filled, so it is always in underrun condition if SSP is enabled. This also fixes a gcc warning with -Wtype-limits. Signed-off-by: Blue Swirl --- hw/pxa2xx.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/pxa2xx.c b/hw/pxa2

[Qemu-devel] [PATCH 1/5] Suppress some gcc warnings with -Wtype-limits

2010-09-04 Thread Blue Swirl
Add various casts, adjust types etc. to make the warnings with gcc flag -Wtype-limits disappear. Signed-off-by: Blue Swirl --- block/blkdebug.c |2 +- hw/mips_fulong2e.c|2 +- hw/omap1.c|2 +- hw/ppc405_boards.c| 23 +-- hw/ppc_newworld.

[Qemu-devel] [PATCH 0/5] Suppress GCC warnings with -Wtype-limits, fix some bugs too

2010-09-04 Thread Blue Swirl
3/5 and 4/5 may fix a real bug. 5/5 enables the flag if supported. Blue Swirl (5): Suppress some gcc warnings with -Wtype-limits PPC: Suppress gcc warnings with -Wtype-limits MIPS: fix yield handling pxa2xx: fix SSSR TFN logic Use gcc warning flag -Wtype-limits block/blkdebug.c

Re: [Qemu-devel] Re: Unmaintained QEMU builds

2010-09-04 Thread Andreas Färber
Am 18.08.2010 um 10:31 schrieb Paolo Bonzini: On 08/17/2010 09:56 PM, Anthony Liguori wrote: If Paolo's Win32 threads get merged, would there be other reasons against continuing Win32 support? I think a better question would be, should we even bother with thread wrappers? If we drop win32 sup

Re: [Qemu-devel] Unmaintained QEMU builds

2010-09-04 Thread Andreas Färber
Am 17.08.2010 um 21:56 schrieb Anthony Liguori: I think my point is that Win32 is a "never to be finished feature". Every time I've ever tried to use it, it's a short period of time before it seg faults. I have a hard time believing that anyone is using it seriously. No "serious" Windows

Re: [Qemu-devel] [PATCH] vnc: use bswapNN() rather than bswap_NN()

2010-09-04 Thread Blue Swirl
Thanks, applied. On Sun, Aug 8, 2010 at 9:54 AM, Izumi Tsutsui wrote: > bswap_NN() variants are not always available in CONFIG_MACHINE_BSWAP_H case > and bswapNN() are public APIs in "bswap.h". > > Signed-off-by: Izumi Tsutsui > --- >  ui/vnc-enc-tight.c |    8 >  1 files changed, 4 ins

Re: [Qemu-devel] [PATCH] virtio-9p: Make sure -virtfs option works correctly

2010-09-04 Thread Blue Swirl
Thanks, applied. On Thu, Sep 2, 2010 at 4:17 PM, Aneesh Kumar K.V wrote: > When making copy of arguments we were doing partial copy > > Signed-off-by: Aneesh Kumar K.V > --- >  vl.c |    4 ++-- >  1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/vl.c b/vl.c > index 9f7358e..df11

Re: [Qemu-devel] [PATCH] Fix ivshmem build on 32-bit hosts

2010-09-04 Thread Blue Swirl
Thanks, applied. On Sun, Aug 29, 2010 at 9:43 AM, Avi Kivity wrote: > stat() fields can be more or less anything depending on configuration, cast > explicitly to uint64_t to avoid printf() format mismatches. > > Signed-off-by: Avi Kivity > --- >  hw/ivshmem.c |    7 --- >  1 files changed, 4

Re: [Qemu-devel] [PATCH] vnc: tight: remove unused variable

2010-09-04 Thread Blue Swirl
Thanks, applied. On Sat, Aug 28, 2010 at 8:24 PM, Serge Ziryukin wrote: > Signed-off-by: Serge Ziryukin > --- >  ui/vnc-enc-tight.c |    2 -- >  1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c > index c4c9c3b..6ee10f9 100644 > --- a/ui/vn

Re: [Qemu-devel] [PATCH] hw/ivshmem.c don't check for negative values on unsigned data types

2010-09-04 Thread Blue Swirl
Thanks, applied. On Mon, Aug 30, 2010 at 10:31 AM, wrote: > From: Jes Sorensen > > There is no need to check for dest < 0 or vector >= 0 as both are > uint16_t. > > This should fix problems with broken build with aggressive compiler > flags. Reported by Xudong Hao > > Signed-off-by: Jes Sorens

[Qemu-devel] Re: [PATCH 0/6] bugs from gcc warning fixes v3

2010-09-04 Thread Blue Swirl
Thanks, applied all. On Tue, Aug 31, 2010 at 7:30 AM, wrote: > From: Jes Sorensen > > Hi, > > Given the contention of the previous patch set, this is a stripped > down version that doesn't have any of the parts included that got > people up in arms. Lets at least start out getting the real bugs

[Qemu-devel] Re: [PATCH 2/7] pci: memory access API and IOMMU support

2010-09-04 Thread Blue Swirl
On Thu, Sep 2, 2010 at 9:49 AM, Michael S. Tsirkin wrote: > On Thu, Sep 02, 2010 at 11:40:58AM +0300, Eduard - Gabriel Munteanu wrote: >> On Thu, Sep 02, 2010 at 08:28:26AM +0300, Michael S. Tsirkin wrote: >> > On Sat, Aug 28, 2010 at 05:54:53PM +0300, Eduard - Gabriel Munteanu wrote: >> > > PCI d

[Qemu-devel] [PATCH v2] blkverify: Add block driver for verifying I/O

2010-09-04 Thread Stefan Hajnoczi
The blkverify block driver makes investigating image format data corruption much easier. A raw image initialized with the same contents as the test image (e.g. qcow2 file) must be provided. The raw image mirrors read/write operations and is used to verify that data read from the test image is cor

Re: [Qemu-devel] "sh: can't access tty; job control turned off" on Linux/SPARC w/ QEMU

2010-09-04 Thread Blue Swirl
2010/9/2 권영수 > > > > I am currently working on QEMU emulating Linux/SPARC. > > > > I have compiled QEMU-0.12.5 and downloaded sparc-test-0.2.tar.gz > > from qemu.org website. > > > > 1. > > > > When I have executed “qemu-g” which boots Linux/SPARC, the window > > appears but finally it generates t