Re: [Qemu-devel] PowerPC code generation and the program counter

2010-09-13 Thread Alexander Graf
On 13.09.2010, at 06:51, Stu Grossman wrote: I've been using qemu-12.4 to trace accesses to non-existent addresses, but I've found that the PC is incorrect when cpu_abort() is called from within the unassigned memory helper routines (unassigned_mem_read[bwl] and unassigned_mem_write[bwl]).

[Qemu-devel] Re: [PATCH 1/3] block: allow migration to work with image files

2010-09-13 Thread Kevin Wolf
Am 11.09.2010 16:04, schrieb Anthony Liguori: Image files have two types of data: immutable data that describes things like image size, backing files, etc. and mutable data that includes offset and reference count tables. Today, image formats aggressively cache mutable data to improve

[Qemu-devel] Re: [PATCH 3/3] disk: don't read from disk until the guest starts

2010-09-13 Thread Kevin Wolf
Am 11.09.2010 16:04, schrieb Anthony Liguori: This fixes a couple nasty problems relating to live migration. 1) When dealing with shared storage with weak coherence (i.e. NFS), even if we re-read, we may end up with undesired caching. By delaying any reads until we absolutely have to,

Re: [Qemu-devel] [Bug 636315] [NEW] configure and build errors on Solaris 10 due to /bin/sh usage

2010-09-13 Thread Michael Tokarev
13.09.2010 01:05, Blue Swirl wrote: On Sun, Sep 12, 2010 at 5:58 PM, Andreas Färber andreas.faer...@web.de wrote: Am 12.09.2010 um 19:47 schrieb Blue Swirl: On Sun, Sep 12, 2010 at 5:35 PM, Andreas Färber andreas.faer...@web.de wrote: Am 12.09.2010 um 19:22 schrieb Blue Swirl: What is

Re: [Qemu-devel] virtio block device and sysfs

2010-09-13 Thread Marc Haber
Hi John and Ryan, On Tue, Jun 29, 2010 at 01:33:33PM -0500, Ryan Harper wrote: We've got a sysfs 'serial' attribute for virtio-blk devices upstream[1]. I've got udev support for using this attribute to create disk/by-id (and a fix for by-path) symlinks[2]. All that remains is to re-spin/post

[Qemu-devel] Re: [PATCH] trace: Fix user emulator dependency on trace objects

2010-09-13 Thread Stefan Hajnoczi
On Sun, Sep 12, 2010 at 05:21:36PM +0200, Andreas Färber wrote: On a clean build, after generating trace.h, make would recurse into *-*-user without a clue how to build ../trace.o (added to $(obj-y) in Makefile.target) since its generation rule is in the main Makefile. The softmmus are

Re: [Qemu-devel] [RFC] qed: Add QEMU Enhanced Disk format

2010-09-13 Thread Kevin Wolf
Am 10.09.2010 21:33, schrieb Anthony Liguori: On 09/10/2010 12:42 PM, Kevin Wolf wrote: It bounces all buffers still and I still think it's synchronous (although Kevin would know better). Yes, it does bounce the buffers, though I'm looking into this anyway because you raised concerns

Re: [Qemu-devel] [RFC] qed: Add QEMU Enhanced Disk format

2010-09-13 Thread Kevin Wolf
Am 12.09.2010 17:56, schrieb Avi Kivity: To me, the biggest burden in qcow2 is thinking through how you deal with shared resources. Because you can block for a long period of time during write operations, it's not enough to just carry a mutex during all metadata operations. You have to

[Qemu-devel] [PATCH] Introduce DPRINTF() macro and convert serial printf() calls to DPRINTF()'s

2010-09-13 Thread Michal Novotny
Hi, this is the patch to introduce DPRINTF() macro as used in the rest of the qemu source files for printing debug messages when the debugging macro is set (i.e. the debugging is enabled) - e.g. as used in LSI SCSI controller implementation. Signed-off-by: Michal Novotny minov...@redhat.com ---

Re: [Qemu-devel] [RFC] qed: Add QEMU Enhanced Disk format

2010-09-13 Thread Kevin Wolf
Am 12.09.2010 19:09, schrieb Anthony Liguori: For a 1PB disk image with qcow2, the reference count table is 128GB. For a 1TB image, the reference count table is 128MB. For a 128GB image, the reference table is 16MB which is why we get away with it today. This is physical size. If you have

Re: [Qemu-devel] [RFC] qed: Add QEMU Enhanced Disk format

2010-09-13 Thread Avi Kivity
On 09/13/2010 01:28 PM, Kevin Wolf wrote: Anytime you grow the freelist with qcow2, you have to write a brand new freelist table and update the metadata synchronously to point to a new version of it. That means for a 1TB image, you're potentially writing out 128MB of data just to allocate a

[Qemu-devel] Re: [PATCH] Introduce DPRINTF() macro and convert serial printf() calls to DPRINTF()'s

2010-09-13 Thread Paolo Bonzini
On 09/13/2010 01:18 PM, Michal Novotny wrote: Hi, this is the patch to introduce DPRINTF() macro as used in the rest of the qemu source files for printing debug messages when the debugging macro is set (i.e. the debugging is enabled) - e.g. as used in LSI SCSI controller implementation.

Re: [Qemu-devel] [RFC] qed: Add QEMU Enhanced Disk format

2010-09-13 Thread Kevin Wolf
Am 13.09.2010 13:34, schrieb Avi Kivity: On 09/13/2010 01:28 PM, Kevin Wolf wrote: Anytime you grow the freelist with qcow2, you have to write a brand new freelist table and update the metadata synchronously to point to a new version of it. That means for a 1TB image, you're potentially

[Qemu-devel] Re: [PATCH v3] Introduce qemu_madvise()

2010-09-13 Thread Alexander Graf
Blue Swirl wrote: On Sun, Sep 12, 2010 at 12:55 PM, Andreas Färber andreas.faer...@web.de wrote: From: Andreas Färber afaer...@opensolaris.org vl.c has a Sun-specific hack to supply a prototype for madvise(), but the call site has apparently moved to arch_init.c. Haiku doesn't

Re: [Qemu-devel] [PATCH] Introduce DPRINTF() macro and convert serial printf() calls to DPRINTF()'s

2010-09-13 Thread Edgar E. Iglesias
On Mon, Sep 13, 2010 at 01:18:27PM +0200, Michal Novotny wrote: Hi, this is the patch to introduce DPRINTF() macro as used in the rest of the qemu source files for printing debug messages when the debugging macro is set (i.e. the debugging is enabled) - e.g. as used in LSI SCSI controller

Re: [Qemu-devel] [PATCH] Introduce DPRINTF() macro and convert serial printf() calls to DPRINTF()'s

2010-09-13 Thread Michal Novotny
On 09/13/2010 02:07 PM, Edgar E. Iglesias wrote: On Mon, Sep 13, 2010 at 01:18:27PM +0200, Michal Novotny wrote: Hi, this is the patch to introduce DPRINTF() macro as used in the rest of the qemu source files for printing debug messages when the debugging macro is set (i.e. the debugging is

[Qemu-devel] [STABLE 0.13][PULL 00/13] Block fixes for stable-0.13

2010-09-13 Thread Kevin Wolf
The following changes since commit 72230c523bda18d4dd2f7d16f96cc59e8fbbd6c9: Update version for 0.13.0-rc1 (2010-08-31 08:19:23 -0500) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-stable-0.13 Bernhard Kohl (6): scsi-disk: fix the mode data length field

[Qemu-devel] [STABLE 0.13][PATCH 03/13] scsi-disk: respect the page control (PC) field in the MODE SENSE command

2010-09-13 Thread Kevin Wolf
From: Bernhard Kohl bernhard.k...@nsn.com The page control (PC) field defines the type of mode parameter values to be returned in the mode pages: PC=0 : Current values PC=1 : Changeable values PC=2 : Default values PC=3 : Saved values The current implementation always returns the same type of

[Qemu-devel] [STABLE 0.13][PATCH 02/13] scsi-disk: fix the mode data header returned by the MODE SENSE(10) command

2010-09-13 Thread Kevin Wolf
From: Bernhard Kohl bernhard.k...@nsn.com The header for the MODE SENSE(10) command is 8 bytes long. Signed-off-by: Bernhard Kohl bernhard.k...@nsn.com Signed-off-by: Kevin Wolf kw...@redhat.com (cherry picked from commit ce512ee115b20bfc8a562d528a3f14eeff9ddf64) --- hw/scsi-disk.c | 38

[Qemu-devel] [STABLE 0.13][PATCH 08/13] qemu-img convert: Use cache=unsafe for output image

2010-09-13 Thread Kevin Wolf
If qemu-img crashes during the conversion, the user will throw away the broken output file anyway and start over. So no need to be too cautious. Signed-off-by: Kevin Wolf kw...@redhat.com (cherry picked from commit 1bd8e175580a87c7b9e6791faca7626f9bc3ceeb) --- qemu-img.c |3 ++- 1 files

[Qemu-devel] [STABLE 0.13][PATCH 01/13] scsi-disk: fix the mode data length field returned by the MODE SENSE command

2010-09-13 Thread Kevin Wolf
From: Bernhard Kohl bernhard.k...@nsn.com The MODE DATA LENGTH field indicates the length in bytes of the following data that is available to be transferred. The mode data length does not include the number of bytes in the MODE DATA LENGTH field. Signed-off-by: Bernhard Kohl

[Qemu-devel] [STABLE 0.13][PATCH 11/13] vvfat: Fix segfault on write to read-only disk

2010-09-13 Thread Kevin Wolf
From: Kevin Wolf m...@kevin-wolf.de vvfat tries to set the readonly flag in its open function, but nowadays this is overwritted with the readonly=... command line option. Check in bdrv_write if the vvfat was opened read-only and return an error in this case. Without this check, vvfat tries to

[Qemu-devel] [STABLE 0.13][PATCH 06/13] scsi-disk: fix the check of the DBD bit in the MODE SENSE command

2010-09-13 Thread Kevin Wolf
From: Bernhard Kohl bernhard.k...@nsn.com The DBD bit does not work as expected. SCSI-Spec: http://ldkelley.com/SCSI2/SCSI2/SCSI2-08.html#8.2.10 A disable block descriptors (DBD) bit of zero indicates that the target may return zero or more block descriptors in the returned MODE SENSE data (see

[Qemu-devel] [STABLE 0.13][PATCH 13/13] vvfat: Use cache=unsafe

2010-09-13 Thread Kevin Wolf
From: Kevin Wolf m...@kevin-wolf.de The qcow file used for write support in vvfat is a temporary file, so we can use cache=unsafe there. Without this, write support is just too slow to be of any use. Signed-off-by: Kevin Wolf m...@kevin-wolf.de (cherry picked from commit

[Qemu-devel] [STABLE 0.13][PATCH 04/13] scsi-disk: fix the block descriptor returned by the MODE SENSE command

2010-09-13 Thread Kevin Wolf
From: Bernhard Kohl bernhard.k...@nsn.com The block descriptor contains the number of blocks, not the highest LBA. Real hard disks return 0 if the number of blocks exceed the maximum 0xFF. SCSI-Spec: http://ldkelley.com/SCSI2/SCSI2/SCSI2-08.html#8.3.3 The number of blocks field specifies the

Re: [Qemu-devel] [PATCH] Introduce DPRINTF() macro and convert serial printf() calls to DPRINTF()'s

2010-09-13 Thread Edgar E. Iglesias
On Mon, Sep 13, 2010 at 02:37:26PM +0200, Michal Novotny wrote: On 09/13/2010 02:07 PM, Edgar E. Iglesias wrote: On Mon, Sep 13, 2010 at 01:18:27PM +0200, Michal Novotny wrote: Hi, this is the patch to introduce DPRINTF() macro as used in the rest of the qemu source files for

[Qemu-devel] [STABLE 0.13][PATCH 09/13] block: Fix BDRV_O_CACHE_MASK

2010-09-13 Thread Kevin Wolf
BDRV_O_CACHE_MASK should have been extended when cache=unsafe introduced a new flag BDRV_O_NO_FLUSH. There are currently no users that would change their behaviour because of this, but let's clean it up before things break. Signed-off-by: Kevin Wolf kw...@redhat.com (cherry picked from commit

[Qemu-devel] [STABLE 0.13][PATCH 12/13] vvfat: Fix double free for opening the image rw

2010-09-13 Thread Kevin Wolf
From: Kevin Wolf m...@kevin-wolf.de Allocation and deallocation of bs-opaque is not in the control of a block driver. Therefore it should not set bs-opaque to a data structure used by another bs, or closing the image will lead to a double free. Signed-off-by: Kevin Wolf m...@kevin-wolf.de

[Qemu-devel] [STABLE 0.13][PATCH 05/13] scsi-disk: return CHECK CONDITION for unknown page codes in the MODE SENSE command

2010-09-13 Thread Kevin Wolf
From: Bernhard Kohl bernhard.k...@nsn.com SCSI-Spec: http://ldkelley.com/SCSI2/SCSI2/SCSI2-08.html#8.2.10 An initiator may request any one or all of the supported mode pages from a target. If an initiator issues a MODE SENSE command with a page code value not implemented by the target, the target

[Qemu-devel] [STABLE 0.13][PATCH 10/13] qcow2: Remove unnecessary flush after L2 write

2010-09-13 Thread Kevin Wolf
When a new cluster was allocated, we only need a flush after the write to the L2 table if it was a COW and we need to decrease the refcounts of the old clusters. Signed-off-by: Kevin Wolf kw...@redhat.com (cherry picked from commit 7ec5e6a4ca43494949465f9f9f3d9e4c7c620503) ---

Re: [Qemu-devel] [RFC] qed: Add QEMU Enhanced Disk format

2010-09-13 Thread Anthony Liguori
On 09/13/2010 06:03 AM, Kevin Wolf wrote: The real reason why it's not the same story is that a qcow3 would be backwards compatible. Old images would just work as qcow3 by changing the version number in the header. Even if they are on a block device. Even if they are encrypted. Even if they are

Re: [Qemu-devel] [RFC] qed: Add QEMU Enhanced Disk format

2010-09-13 Thread Anthony Liguori
On 09/13/2010 06:28 AM, Kevin Wolf wrote: Anytime you grow the freelist with qcow2, you have to write a brand new freelist table and update the metadata synchronously to point to a new version of it. That means for a 1TB image, you're potentially writing out 128MB of data just to allocate a new

Re: [Qemu-devel] [RFC] qed: Add QEMU Enhanced Disk format

2010-09-13 Thread Anthony Liguori
On 09/13/2010 06:48 AM, Kevin Wolf wrote: Am 13.09.2010 13:34, schrieb Avi Kivity: On 09/13/2010 01:28 PM, Kevin Wolf wrote: Anytime you grow the freelist with qcow2, you have to write a brand new freelist table and update the metadata synchronously to point to a new

[Qemu-devel] [Bug 608107] Re: ppc fails to clear MSR_POW when incurring exception

2010-09-13 Thread till
I'm afraid I don't understand. My the problem and fix doesn't address mtmsr at all. It just makes sure MSR_POW is cleared in MSR when an exception occurs. Do you mean MSR_POW should masked from MSR before saving it to SRR1? That's already taken care of (target-ppc/helper.c:2074 [qemu-0.12.4]).

Re: [Qemu-devel] [RFC] qed: Add QEMU Enhanced Disk format

2010-09-13 Thread Kevin Wolf
Am 13.09.2010 15:07, schrieb Anthony Liguori: On 09/13/2010 06:03 AM, Kevin Wolf wrote: The real reason why it's not the same story is that a qcow3 would be backwards compatible. Old images would just work as qcow3 by changing the version number in the header. Even if they are on a block

[Qemu-devel] Re: [PATCH 1/3] block: allow migration to work with image files

2010-09-13 Thread Anthony Liguori
On 09/13/2010 03:21 AM, Kevin Wolf wrote: Am 11.09.2010 16:04, schrieb Anthony Liguori: Image files have two types of data: immutable data that describes things like image size, backing files, etc. and mutable data that includes offset and reference count tables. Today, image formats

[Qemu-devel] Re: [PATCH 3/3] disk: don't read from disk until the guest starts

2010-09-13 Thread Anthony Liguori
On 09/13/2010 03:32 AM, Kevin Wolf wrote: Am 11.09.2010 16:04, schrieb Anthony Liguori: This fixes a couple nasty problems relating to live migration. 1) When dealing with shared storage with weak coherence (i.e. NFS), even if we re-read, we may end up with undesired caching. By

[Qemu-devel] Re: [PATCH 3/3] disk: don't read from disk until the guest starts

2010-09-13 Thread Anthony Liguori
On 09/13/2010 08:39 AM, Kevin Wolf wrote: Yeah, one of the key design points of live migration is to minimize the number of failure scenarios where you lose a VM. If someone typed the wrong command line or shared storage hasn't been mounted yet and we delay failure until live migration is in

[Qemu-devel] [PATCH] serial: Update parameters after load

2010-09-13 Thread Michal Novotny
Hi, this is the patch to update serial port parameters after guest is already loaded. Signed-off-by: Michal Novotnyminov...@redhat.com --- hw/serial.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/serial.c b/hw/serial.c index 49431b2..bf74876 100644 ---

[Qemu-devel] Re: [PATCH 3/3] disk: don't read from disk until the guest starts

2010-09-13 Thread Kevin Wolf
Am 13.09.2010 15:42, schrieb Anthony Liguori: On 09/13/2010 08:39 AM, Kevin Wolf wrote: Yeah, one of the key design points of live migration is to minimize the number of failure scenarios where you lose a VM. If someone typed the wrong command line or shared storage hasn't been mounted yet

[Qemu-devel] Re: [PATCH] Use a Linux-style MAINTAINERS file

2010-09-13 Thread Blue Swirl
On Thu, Sep 9, 2010 at 9:18 PM, Anthony Liguori aligu...@us.ibm.com wrote: I make no claims that this is accurate or exhaustive but I think it's a reasonable place to start. As the file mentions, the purpose of this file is to give contributors information about who they can go to with

[Qemu-devel] Re: [PATCH] Use a Linux-style MAINTAINERS file

2010-09-13 Thread Michael S. Tsirkin
On Thu, Sep 09, 2010 at 04:18:37PM -0500, Anthony Liguori wrote: +Devices +--- +Virtio +M: Anthony Liguori aligu...@us.ibm.com +S: Supported +F: hw/virtio* You can add myself here, I'm happy to answer questions and help get patches merged. -- MST

[Qemu-devel] Re: [PATCH] Use a Linux-style MAINTAINERS file

2010-09-13 Thread Magnus Damm
Hi Anthony, On Fri, Sep 10, 2010 at 10:59 PM, Anthony Liguori aligu...@linux.vnet.ibm.com wrote: Hi Magnus, On 09/10/2010 03:25 AM, Magnus Damm wrote: On Fri, Sep 10, 2010 at 6:18 AM, Anthony Liguorialigu...@us.ibm.com  wrote:  SH4 -  shix.c                  ? -  r2d.c                  

[Qemu-devel] [PATCH] virtio-9p: open should not return EBADF

2010-09-13 Thread Sripathi Kodi
When 9P server fails to create a file due to permission problems it should return EPERM. However the current 9P2000.L code returns EBADF. EBADF is NOT a valid return value from open() call. The problem is because we do not preserve the errno variable properly. If the file open had failed, the

Re: [Qemu-devel] Re: [PATCH 3/3] disk: don't read from disk until the guest starts

2010-09-13 Thread Anthony Liguori
On 09/13/2010 09:13 AM, Kevin Wolf wrote: I think the only real advantage is that we fix NFS migration, right? That's the one that we know about, yes. The rest is not a specific scenario, but a strong feeling that having an image opened twice at the same time feels dangerous. We've

Re: [Qemu-devel] virtio block device and sysfs

2010-09-13 Thread Ryan Harper
* Marc Haber mh+qemu-de...@zugschlus.de [2010-09-13 03:56]: Hi John and Ryan, On Tue, Jun 29, 2010 at 01:33:33PM -0500, Ryan Harper wrote: We've got a sysfs 'serial' attribute for virtio-blk devices upstream[1]. I've got udev support for using this attribute to create disk/by-id (and a

[Qemu-devel] KVM call agenda for Sept 14

2010-09-13 Thread Chris Wright
Please send in any agenda items you are interested in covering. thanks, -chris

[Qemu-devel] Re: KVM call agenda for Sept 14

2010-09-13 Thread Anthony Liguori
On 09/13/2010 10:59 AM, Chris Wright wrote: Please send in any agenda items you are interested in covering. 1) 0.13.0 I'll be collecting patches for the next 24 hours so if there are fixes you care about, please ping me between now and then. http://wiki.qemu.org/Releases/0.13.0

Re: [Qemu-devel] [PATCH] Use a Linux-style MAINTAINERS file

2010-09-13 Thread Anderson Lizardo
On Thu, Sep 9, 2010 at 5:18 PM, Anthony Liguori aligu...@us.ibm.com wrote: +M86K Machines +- +mcf5208 +M: Paul Brook p...@codesourcery.com +S: Maintained +F: hw/mcf5208.c Just wondering... Is there a M86K or is it a typo from M68K (warning: I know nothing of this machine).

Re: [Qemu-devel] Issue with compiling qemu-0.13.0.-rc1

2010-09-13 Thread Adhyas Avasthi
Anthony Are you sure that this error is because the make version is not similar to yours? As I said, I cannot even make the rc1 image. The last stable image I can make is qemu-0.12.5 Even 0.12.5 also gives the make output initially that says could not find -include but continues to build without

Re: [Qemu-devel] Issue with compiling qemu-0.13.0.-rc1

2010-09-13 Thread Anthony Liguori
On 09/13/2010 12:47 PM, Adhyas Avasthi wrote: Anthony Are you sure that this error is because the make version is not similar to yours? As I said, I cannot even make the rc1 image. The last stable image I can make is qemu-0.12.5 Even 0.12.5 also gives the make output initially that says could

Re: [Qemu-devel] [PATCH] trace: Fix user emulator dependency on trace objects

2010-09-13 Thread Stefan Weil
Am 12.09.2010 17:21, schrieb Andreas Färber: On a clean build, after generating trace.h, make would recurse into *-*-user without a clue how to build ../trace.o (added to $(obj-y) in Makefile.target) since its generation rule is in the main Makefile. The softmmus are seemingly unaffected

[Qemu-devel] [PATCH] linux-user: Fix type m86k - m68k

2010-09-13 Thread Stefan Weil
Replace m86k_sim_stat by m68k_sim_stat. Cc: Riku Voipio riku.voi...@iki.fi Signed-off-by: Stefan Weil w...@mail.berlios.de --- linux-user/m68k-sim.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/linux-user/m68k-sim.c b/linux-user/m68k-sim.c index 64d3b23..d5926ee

Re: [Qemu-devel] [PATCH] Use a Linux-style MAINTAINERS file

2010-09-13 Thread Stefan Weil
Am 09.09.2010 23:18, schrieb Anthony Liguori: I make no claims that this is accurate or exhaustive but I think it's a reasonable place to start. As the file mentions, the purpose of this file is to give contributors information about who they can go to with questions about a particular piece of

Re: [Qemu-devel] [PATCH] Use a Linux-style MAINTAINERS file

2010-09-13 Thread Stefan Weil
Am 13.09.2010 19:32, schrieb Anderson Lizardo: On Thu, Sep 9, 2010 at 5:18 PM, Anthony Liguorialigu...@us.ibm.com wrote: +M86K Machines +- +mcf5208 +M: Paul Brookp...@codesourcery.com +S: Maintained +F: hw/mcf5208.c Just wondering... Is there a M86K or is it a typo from

Re: [Qemu-devel] [PATCH 1/5] use qemu_blockalign consistently

2010-09-13 Thread Stefan Hajnoczi
On Sun, Sep 12, 2010 at 10:42 PM, Christoph Hellwig h...@lst.de wrote: Use qemu_blockalign for all allocations in the block layer.  This allows increasing the required alignment, which is need to support O_DIRECT on devices with large block sizes. Signed-off-by: Christoph Hellwig h...@lst.de

[Qemu-devel] [PATCH] Remove wrong semicolon in macro definition

2010-09-13 Thread Stefan Weil
Macros normally should not end with a semicolon, otherwise their usage results in two statements where only one statement was expected. Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/serial.c |4 ++-- tests/cris/check_swap.c |2 +- 2 files changed, 3 insertions(+), 3

Re: [Qemu-devel] Re: [PATCH 3/3] disk: don't read from disk until the guest starts

2010-09-13 Thread Stefan Hajnoczi
On Mon, Sep 13, 2010 at 3:13 PM, Kevin Wolf kw...@redhat.com wrote: Am 13.09.2010 15:42, schrieb Anthony Liguori: On 09/13/2010 08:39 AM, Kevin Wolf wrote: Yeah, one of the key design points of live migration is to minimize the number of failure scenarios where you lose a VM.  If someone typed

Re: [Qemu-devel] [PATCH] hpet: check no_hpet when adding fw_cfg entry.

2010-09-13 Thread Gleb Natapov
On Mon, Sep 06, 2010 at 02:01:24PM +0200, Gerd Hoffmann wrote: We should only pass the hpet config entry in case we actually create a hpet device. No we should pass it always. If no hpets are present hpet_cfg will have appropriate info. Signed-off-by: Gerd Hoffmann kra...@redhat.com ---

Re: [Qemu-devel] Issue with compiling qemu-0.13.0.-rc1

2010-09-13 Thread Adhyas Avasthi
Alright, so I updated the version of make to what you have(3.81 GNU Make built for x86_64-redhat-linux-gnu) When I build the RC1 image now, I get a bunch of compile time errors (different than what I saw before). Reproduced below. Not sure if this is because RC1 code has issues or something to do

Re: [Qemu-devel] Issue with compiling qemu-0.13.0.-rc1

2010-09-13 Thread Anthony Liguori
On 09/13/2010 02:51 PM, Adhyas Avasthi wrote: Alright, so I updated the version of make to what you have(3.81 GNU Make built for x86_64-redhat-linux-gnu) What OS are you running? When I build the RC1 image now, I get a bunch of compile time errors (different than what I saw before).

Re: [Qemu-devel] Issue with compiling qemu-0.13.0.-rc1

2010-09-13 Thread Adhyas Avasthi
The OS is RedHat Thanks, Adhyas

Re: [Qemu-devel] Issue with compiling qemu-0.13.0.-rc1

2010-09-13 Thread Anthony Liguori
On 09/13/2010 02:57 PM, Adhyas Avasthi wrote: The OS is RedHat What version? Regards, Anthony Liguori Thanks, Adhyas

[Qemu-devel] [PATCH 1/2] Add support for gcc format attribute gnu_printf

2010-09-13 Thread Stefan Weil
Since version 4.4.x, gcc supports additional format attributes. __attribute__ ((format (gnu_printf, 1, 2))) should be used instead of __attribute__ ((format (printf, 1, 2)) because QEMU always uses standard format strings (even with mingw32). For older compilers, we simply define

Re: [Qemu-devel] Re: [PATCH 3/3] disk: don't read from disk until the guest starts

2010-09-13 Thread Kevin Wolf
Am 13.09.2010 21:29, schrieb Stefan Hajnoczi: On Mon, Sep 13, 2010 at 3:13 PM, Kevin Wolf kw...@redhat.com wrote: Am 13.09.2010 15:42, schrieb Anthony Liguori: On 09/13/2010 08:39 AM, Kevin Wolf wrote: Yeah, one of the key design points of live migration is to minimize the number of failure

[Qemu-devel] [PATCH 2/3] qcow2: Avoid bounce buffers for AIO read requests

2010-09-13 Thread Kevin Wolf
qcow2 used to use bounce buffers for any AIO requests. This does not only imply unnecessary copying, but also unbounded allocations which should be avoided. This patch removes bounce buffers from the normal AIO read path, and constrains them to a constant size for encrypted images.

[Qemu-devel] [PATCH 0/3] qcow2: Avoid bounce buffers

2010-09-13 Thread Kevin Wolf
Kevin Wolf (3): cutils: qemu_iovec_copy and qemu_iovec_memset qcow2: Avoid bounce buffers for AIO read requests qcow2: Avoid bounce buffers for AIO write requests block/qcow2-cluster.c |8 +++- block/qcow2.c | 115 ++---

[Qemu-devel] [PATCH RFC] dma_rw.h (was Re: [PATCH 0/7] AMD IOMMU emulation patchset v4)

2010-09-13 Thread Michael S. Tsirkin
So I think the following will give the idea of what an API might look like that will let us avoid the scary hacks in e.g. the ide layer and other generic layers that need to do DMA, without either binding us to pci, adding more complexity with callbacks, or losing type safety with casts and void*.

[Qemu-devel] [PATCH 1/3] cutils: qemu_iovec_copy and qemu_iovec_memset

2010-09-13 Thread Kevin Wolf
This adds two functions that work on QEMUIOVectors and will be used by the next qcow2 patches. Signed-off-by: Kevin Wolf kw...@redhat.com --- cutils.c | 50 +- qemu-common.h |3 +++ 2 files changed, 44 insertions(+), 9 deletions(-) diff

[Qemu-devel] [PATCH 3/3] qcow2: Avoid bounce buffers for AIO write requests

2010-09-13 Thread Kevin Wolf
qcow2 used to use bounce buffers for any AIO requests. This does not only imply unnecessary copying, but also unbounded allocations which should be avoided. This patch removes bounce buffers from the normal AIO write path. Encrypted images continue to use a bounce buffer, however with constant

Re: [Qemu-devel] Issue with compiling qemu-0.13.0.-rc1

2010-09-13 Thread Adhyas Avasthi
Seems like my toolchain set up was not proper. Resolved the build environment and it seems to build RC1 (target x86_64-softmmu) for me now. Will let you know if I can repro the issue again. I will try to build the other targets now. - Adhyas

Re: [Qemu-devel] Re: [PATCH 3/3] disk: don't read from disk until the guest starts

2010-09-13 Thread Anthony Liguori
On 09/13/2010 03:03 PM, Kevin Wolf wrote: Am 13.09.2010 21:29, schrieb Stefan Hajnoczi: On Mon, Sep 13, 2010 at 3:13 PM, Kevin Wolfkw...@redhat.com wrote: Am 13.09.2010 15:42, schrieb Anthony Liguori: On 09/13/2010 08:39 AM, Kevin Wolf wrote: Yeah, one of the key

Re: [Qemu-devel] [PATCH RFC] dma_rw.h (was Re: [PATCH 0/7] AMD IOMMU emulation patchset v4)

2010-09-13 Thread Anthony Liguori
On 09/13/2010 03:01 PM, Michael S. Tsirkin wrote: So I think the following will give the idea of what an API might look like that will let us avoid the scary hacks in e.g. the ide layer and other generic layers that need to do DMA, without either binding us to pci, adding more complexity with

Re: [Qemu-devel] Stable patch tracking

2010-09-13 Thread Miguel Di Ciurcio Filho
On Sun, Sep 12, 2010 at 11:02 AM, Avi Kivity a...@redhat.com wrote:  On 09/12/2010 03:42 PM, Avi Kivity wrote:  On 09/12/2010 03:04 PM, Anthony Liguori wrote: Can the captcha for logged in users be removed? Can you be more specific about what you're seeing? There should only be a captcha

[Qemu-devel] Re: [PATCH] [RFC] Add support for a USB audio device model

2010-09-13 Thread Amos Kong
On Fri, Sep 10, 2010 at 02:47:56PM -0700, H. Peter Anvin wrote: I discovered that none of the audio device models supported by current Qemu/KVM appear to be supported out of the box on Win7 64 bit (AC97 works fine on 32 bit). The most logical ways to fix that would be to add a long-term

[Qemu-devel] [PATCH] [slirp] Accept packets with TTL=1

2010-09-13 Thread Hervé Poussineau
Packets with TTL=1 may be directed to local network (DHCP/DNS servers for example), so don't discard them This is required by old versions of NetBSD which send DHCP DISCOVER packets with TTL=1 Signed-off-by: Hervé Poussineau hpous...@reactos.org --- slirp/ip_input.c |2 +- 1 files changed,

[Qemu-devel] [PATCH] [slirp] Make ARP replies at least 64 bytes long

2010-09-13 Thread Hervé Poussineau
IEEE 802.3 standard requires Ethernet frames to be at least 64 bytes long. If it is not the case, they will be considered as runt frames, and may be ignored by netcard and/or OS Signed-off-by: Hervé Poussineau hpous...@reactos.org --- slirp/slirp.c | 12 1 files changed, 8

[Qemu-devel] Re: [PATCH] [RFC] Add support for a USB audio device model

2010-09-13 Thread H. Peter Anvin
On 09/13/2010 01:53 PM, Amos Kong wrote: # patch -p1 /tmp/usb-audio.patch # ./configure ... ... preadv supportyes fdatasync yes uuid support no vhost-net support no Trace backend nop Trace output file trace-pid ./configure: 2276: Bad substitution What shell is

[Qemu-devel] Re: [PATCH] [RFC] Add support for a USB audio device model

2010-09-13 Thread H. Peter Anvin
On 09/13/2010 01:53 PM, Amos Kong wrote: # patch -p1 /tmp/usb-audio.patch # ./configure ... ... preadv supportyes fdatasync yes uuid support no vhost-net support no Trace backend nop Trace output file trace-pid ./configure: 2276: Bad substitution diff --git

[Qemu-devel] Ramadan heureux mon cher?

2010-09-13 Thread Madame amaka
As-Salamu alaikum Je souhaite au nom d'Allah que j'ai le droit de la personne qui Assit moi, je suis Madame amaka Conte, l'une des épouses de la veuve Gen.Allasana Conte l'ancien président de la République de Guinée, en Afrique de l'Ouest, qui est mort au pouvoir , l'an dernier, Décembre 23,

[Qemu-devel] [RFC v4] Introduce qemu_madvise()

2010-09-13 Thread Andreas Färber
From: Andreas Färber afaer...@opensolaris.org vl.c has a Sun-specific hack to supply a prototype for madvise(), but the call site has apparently moved to arch_init.c. Haiku doesn't implement madvise() in favor of posix_madvise(). OpenBSD and Solaris 10 don't implement posix_madvise() but

Re: [Qemu-devel] [Bug 636315] [NEW] configure and build errors on Solaris 10 due to /bin/sh usage

2010-09-13 Thread Andreas Färber
Am 13.09.2010 um 10:49 schrieb Michael Tokarev: 13.09.2010 01:05, Blue Swirl wrote: On Sun, Sep 12, 2010 at 5:58 PM, Andreas Färber andreas.faer...@web.de wrote: Am 12.09.2010 um 19:47 schrieb Blue Swirl: diff --git a/tracetool b/tracetool index 534cc70..c7582bf 100755 --- a/tracetool +++

Re: [Qemu-devel] [PATCH] Introduce DPRINTF() macro and convert serial printf() calls to DPRINTF()'s

2010-09-13 Thread Andreas Färber
Am 13.09.2010 um 14:37 schrieb Michal Novotny: I'm having git 1.7.0.1 and it's saying that send-email it doesn't know send-email [1] [1] This is what I'm having: $ git send-email 0001-dprintf-implementation.patch --to minov...@redhat.com git: 'send-email' is not a git command. See 'git

[Qemu-devel] Re: [PATCH] [RFC] Add support for a USB audio device model

2010-09-13 Thread Amos Kong
On Mon, Sep 13, 2010 at 02:04:57PM -0700, H. Peter Anvin wrote: On 09/13/2010 01:53 PM, Amos Kong wrote: # patch -p1 /tmp/usb-audio.patch # ./configure ... ... preadv supportyes fdatasync yes uuid support no vhost-net support no Trace backend nop Trace

[Qemu-devel] [PATCH] linux-user: mmap_reserve() not controlled by RESERVED_VA

2010-09-13 Thread amateur
mmap_reserve() should be called only when RESERVED_VA is enabled. Otherwise, unmaped virtual address space will never be reusable. This bug will exhaust virtual address space in extreme conditions. diff --git a/linux-user/mmap.c b/linux-user/mmap.c index e10a6ef..50748a2 100644 ---

[Qemu-devel] Commit 5f30fa18ad043a841fe9f0c3917ac60f2519ebd1 breaks debugging 64 bit guests

2010-09-13 Thread Ted Harkington
Hello, I have been trying to figure out why I cannot debug a 64 bit kernel of my own invention. I launch qemu-system-x86_64 with the -s -S flags, we also specify -cpu core2duo -vga std and a -hda with an ext2 FS holding our multiboot kernel and GRUB2. When I try to set breakpoints and continue

[Qemu-devel] Re: [PATCH] [RFC] Add support for a USB audio device model

2010-09-13 Thread H. Peter Anvin
On 09/13/2010 06:37 PM, Amos Kong wrote: Hello Peter, What shell is your /bin/sh? dash, It's fine when using bash, I suggest to use a common way. Yes, I'll fix it. I've heard wonderful music (guest:win7), but mixed with a litte noise, not so fluent. The following debug msg is