Re: [Qemu-devel] [PATCH 03/10] ide: add support for ide extenders

2010-11-17 Thread Gerd Hoffmann
Hi, +/* This struct represents a device that uses an IDE bus, but requires + * modifications to how it works. An example is AHCI. */ +struct IDEExtender { +TransferStartFunc *transfer_start_fn; +IRQSetFunc *irq_set_fn; +DMAStartFunc *dma_start_fn; +}; Hmm, I'd call that

Re: [Qemu-devel] [PATCH 04/10] ide: enable preallocated sg lists

2010-11-17 Thread Gerd Hoffmann
Hi, +if (s-sg_third_party) { +/* We've already parsed the guest RAM PRDT. + * This is essential for AHCI, where the PRDT is in a different + * format than in IDE BMDMA. + */ +memcpy((uint8_t *)prd,

Re: [Qemu-devel] [PATCH 08/10] ahci: add ahci emulation

2010-11-17 Thread Gerd Hoffmann
Hi, +static AHCIState *ahci_new(void) +{ +int i; + +static int pci_ahci_init(PCIDevice *dev) +{ +d-ahci = ahci_new(); +d-ahci-irq = d-card.irq[0]; +return 0; +} Hmm, no bus registered anywhere. Dunno whenever it makes sense to register ide bus(es) here or whenever we

Re: [Qemu-devel] [PATCH 04/10] ide: enable preallocated sg lists

2010-11-17 Thread Stefan Hajnoczi
On Wed, Nov 17, 2010 at 1:05 AM, Alexander Graf ag...@suse.de wrote: @@ -535,12 +543,25 @@ static int dma_buf_rw(BMDMAState *bm, int is_write)         if (bm-cur_prd_len == 0) {             /* end of table (with a fail safe of one page) */             if (bm-cur_prd_last || -                

Re: [Qemu-devel] [PATCH v2 2/2] RAM API: Make use of it for x86 PC

2010-11-17 Thread Gleb Natapov
On Tue, Nov 16, 2010 at 02:24:06PM -0700, Alex Williamson wrote: On Tue, 2010-11-16 at 08:58 -0600, Anthony Liguori wrote: On 11/01/2010 10:14 AM, Alex Williamson wrote: Register the actual VM RAM using the new API Signed-off-by: Alex Williamsonalex.william...@redhat.com ---

[Qemu-devel] cpu_register_physical_memory_offset()

2010-11-17 Thread 依峰听海
i am confused about the function cpu_register_physical_memory_offset(). in this function, cpu register a segment of GPA to RAM or to a device. Now, i want to write two new function ,one is cpu_register_physical_memory_offset_to_RAM() and the other is

Re: [Qemu-devel] [PATCH v3 2/4] switch stdvga to pci vgabios

2010-11-17 Thread Avi Kivity
On 11/03/2010 01:56 PM, Gerd Hoffmann wrote: Make stdvga provide the new vgabios binary (with pcibios support) using the PCI option rom bar. Seabios will happily load it from there. The new vga bios will also lookup the framebuffer address in pci config space, so the magic bochs lfb @

[Qemu-devel] [PATCH v3 0/2] Type-safe ioport callbacks

2010-11-17 Thread Avi Kivity
A not-so-recent qemu - qemu-kvm merge broke cpu hotplug without the compiler complaining because of the type-unsafeness of the ioport callbacks. This patchset adds a type-safe variant of ioport callbacks and coverts a sample ioport. Converting the other 300-odd registrations is left as an

[Qemu-devel] [PATCH v3 2/2] piix4 acpi: convert io BAR to type-safe ioport callbacks

2010-11-17 Thread Avi Kivity
Acked-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Avi Kivity a...@redhat.com --- hw/acpi_piix4.c | 55 ++- 1 files changed, 22 insertions(+), 33 deletions(-) diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c index f549089..173d781

[Qemu-devel] [PATCH v3 1/2] Type-safe ioport callbacks

2010-11-17 Thread Avi Kivity
The current ioport callbacks are not type-safe, in that they accept an opaque pointer as an argument whose type must match the argument to the registration function; this is not checked by the compiler. This patch adds an alternative that is type-safe. Instead of an opaque argument, both

Re: [Qemu-devel] [PATCH v3 2/4] switch stdvga to pci vgabios

2010-11-17 Thread Gerd Hoffmann
Hi, This is a guest visible change... does it need -M 0.13 support? Yes, it will. I have a patch in flight which actually adds the 0.13 machine type, when this is merged I can add compat properties to handle this. Will live migration from 0.13 to 0.14 work? Hmm. Guess we probably

Re: [Qemu-devel] [PATCH 2/3] vnc: support password expire

2010-11-17 Thread Gerd Hoffmann
Hi, Having an expiration policy builtin to QEMU (as opposed to libvirt) seems like the wrong place. IMHO it doesn't build policy into qemu. It is still up to libvirt (or the management app building on top of libvirt) to decide if and when the password will expire. Except if you want to

Re: [Qemu-devel] Re: [PATCH v2 0/4] use new vgabios.

2010-11-17 Thread Gerd Hoffmann
On 11/16/10 15:51, Anthony Liguori wrote: On 11/01/2010 11:03 AM, Gerd Hoffmann wrote: On 10/15/10 12:02, Gerd Hoffmann wrote: This patch series will put the new vgabios into use for stdvga and vmware_vga. The vgabios patches have been posted a while ago, they are also also available from

Re: [Qemu-devel] [PATCH v4 0/3]: QMP: Human Monitor passthrough

2010-11-17 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: Simple example: - { execute: human-monitor-command, arguments: { command-line: print /i 10+25 } } - { return: 35\r\n } Please, check individual patches for details. Also note that this series depends on the script improvements one. Also,

[Qemu-devel] [PATCH] vgabios update: handle compatibility with older qemu versions

2010-11-17 Thread Gerd Hoffmann
As pointed out by avi the vgabios update is guest-visible and thus has migration implications. One change is that the vga has a valid pci rom bar now. We already have a pci bus property to enable/disable the rom bar and we'll load the bios via fw_cfg as fallback for the no-rom-bar case. So we

Re: [Qemu-devel] [PATCH 0/4] usb-ccid (v6)

2010-11-17 Thread Alon Levy
ping? On Tue, Nov 09, 2010 at 02:22:06PM +0200, Alon Levy wrote: This patchset adds three new devices, usb-ccid, ccid-card-passthru and ccid-card-emulated, providing a CCID bus, a simple passthru protocol implementing card requiring a client, and a standalone emulated card. v5-v6 changes:

Re: [Qemu-devel] [PATCH 1/2] Add a DTrace tracing backend targetted for SystemTAP compatability

2010-11-17 Thread Daniel P. Berrange
On Tue, Nov 16, 2010 at 09:46:20AM -0600, Anthony Liguori wrote: On 11/08/2010 01:33 PM, Daniel P. Berrange wrote: This introduces a new tracing backend that targets the SystemTAP implementation of DTrace userspace tracing. The core functionality should be applicable and standard across any

Re: [Qemu-devel] [PATCH 1/2] Add a DTrace tracing backend targetted for SystemTAP compatability

2010-11-17 Thread Daniel P. Berrange
On Tue, Nov 16, 2010 at 06:54:57PM +, Peter Maydell wrote: On 16 November 2010 18:10, Anthony Liguori anth...@codemonkey.ws wrote: On 11/16/2010 11:43 AM, Peter Maydell wrote: Unfortunately these commits: 2834c3e Add support for generating a systemtap tapset static probes 4addb11 Add

[Qemu-devel] Re: [PATCH][RESEND] char: Flush read buffer in mux_chr_can_read

2010-11-17 Thread Jan Kiszka
Am 17.11.2010 12:55, Alexander Graf wrote: On 17.11.2010, at 11:18, Jan Kiszka wrote: Am 19.10.2010 17:04, Jan Kiszka wrote: Move the buffer flush from mux_chr_read to mux_chr_can_read. While the latter is called periodically, the former will only be invoked when new characters arrive at

[Qemu-devel] Re: [PATCH 1/7] qbus: add functions to walk both devices and busses

2010-11-17 Thread Paolo Bonzini
On 11/17/2010 05:50 AM, Isaku Yamahata wrote: +/* Returns 0 to walk children, 0 to terminate walk, 0 to skip walk. */ Shouldn't this be the other way round according to the code ( 0 to terminate, 0 to skip children)? +/* Returns 0 if either devfn or busfn terminate walk, 0 otherwise.

[Qemu-devel] [PATCH] s390: compile fixes

2010-11-17 Thread Alexander Graf
The s390 target doesn't compile out of the box anymore. This patch fixes all the obvious glitches that got introduced in the last few weeks. Signed-off-by: Alexander Graf ag...@suse.de --- hw/s390-virtio-bus.h |2 ++ hw/s390-virtio.c |1 + target-s390x/kvm.c |2 +-

[Qemu-devel] Re: [PATCH][RESEND] char: Flush read buffer in mux_chr_can_read

2010-11-17 Thread Alexander Graf
On 17.11.2010, at 12:58, Jan Kiszka wrote: Am 17.11.2010 12:55, Alexander Graf wrote: On 17.11.2010, at 11:18, Jan Kiszka wrote: Am 19.10.2010 17:04, Jan Kiszka wrote: Move the buffer flush from mux_chr_read to mux_chr_can_read. While the latter is called periodically, the former will

[Qemu-devel] Re: [PATCH v9 1/8] pci: revise pci command register initialization

2010-11-17 Thread Michael S. Tsirkin
On Wed, Nov 17, 2010 at 11:03:14AM +0900, Isaku Yamahata wrote: On Tue, Nov 16, 2010 at 12:50:19PM +0200, Michael S. Tsirkin wrote: On Tue, Nov 16, 2010 at 05:26:05PM +0900, Isaku Yamahata wrote: This patch cleans up command register initialization with comments. It also fixes the

Re: [Qemu-devel] [PATCH v2 3/3] trace: enable all events by default

2010-11-17 Thread Lluís
Stefan Hajnoczi writes: If you don't get around to it I'll do it sometime but I'm short on time right now. Wanted to let you know in case you're waiting for more discussion on this thread. Sure, don't worry. I do not have enough time right now either, so I'll tell you if I start to implement

Re: [Qemu-devel] [PATCH 08/10] ahci: add ahci emulation

2010-11-17 Thread Alexander Graf
On 17.11.2010, at 10:08, Gerd Hoffmann wrote: Hi, +static AHCIState *ahci_new(void) +{ +int i; + +static int pci_ahci_init(PCIDevice *dev) +{ +d-ahci = ahci_new(); +d-ahci-irq = d-card.irq[0]; +return 0; +} Hmm, no bus registered anywhere. Dunno whenever it

[Qemu-devel] [PATCH] qemu-user: Translate getsockopt level option

2010-11-17 Thread Jamie Lentin
In setsockopt, the socket level options are translated to the hosts' architecture before the real syscall is called, e.g. TARGET_SO_TYPE - SO_TYPE. This patch does the same with getsockopt. Tested on a x86 host emulating MIPS. Without it:- $ grep getsockopt host.strace 31311 getsockopt(3,

Re: [Qemu-devel] [PATCH v4 0/3]: QMP: Human Monitor passthrough

2010-11-17 Thread Luiz Capitulino
On Wed, 17 Nov 2010 11:27:31 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: Simple example: - { execute: human-monitor-command, arguments: { command-line: print /i 10+25 } } - { return: 35\r\n } Please, check individual patches

Re: [Qemu-devel] [RFC PATCH v2 2/4] Add block-queue

2010-11-17 Thread Stefan Hajnoczi
On Fri, Nov 5, 2010 at 6:38 PM, Kevin Wolf kw...@redhat.com wrote: Instead of directly executing writes and fsyncs, queue them and execute them asynchronously. What makes this interesting is that we can delay syncs and if multiple syncs occur, we can merge them into one bdrv_flush. The

[Qemu-devel] [PATCH 5/7] QMP: Introduce Human Monitor passthrough command

2010-11-17 Thread Luiz Capitulino
This command allows QMP clients to execute HMP commands. Please, check the documentation added to the qmp-commands.hx file for additional details about the interface and its limitations. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c | 38

[Qemu-devel] [PATCH 1/7] QMP: Revamp the Python class example

2010-11-17 Thread Luiz Capitulino
This commit simplifies and fixes a number of problems in the Python QEMUMonitorProtocol example class. It's almost a rewrite and it DOES BREAK the qmp-shell script (which is going to be fixed in the next commit). However, I'm not going to split this in different commits because it could get up

[Qemu-devel] [PATCH 2/7] QMP: Revamp the qmp-shell script

2010-11-17 Thread Luiz Capitulino
This commit updates the qmp-shell script to use the new interface introduced by the last commit. Additionally, the following fixes/features are also introduced: o TCP sockets support o Update/add documentation o Simple command-line completion o Fix a number of unhandled errors

Re: [Qemu-devel] [PATCH] spice: add qxl device

2010-11-17 Thread Gerd Hoffmann
Hi, These headers shouldn't be needed. This file also needs a copyright.diff --git a/hw/qxl-render.c b/hw/qxl-render.c Does QXL have a specification? The spice protocol has a specification (slightly outdated though). http://www.spice-space.org/docs/spice_protocol.pdf That covers the

[Qemu-devel] [PATCH 3/7] QMP: Drop vm-info example script

2010-11-17 Thread Luiz Capitulino
It's broken and not really useful, let's just drop it. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- QMP/README |5 + QMP/vm-info | 33 - 2 files changed, 1 insertions(+), 37 deletions(-) delete mode 100755 QMP/vm-info diff --git

[Qemu-devel] [PATCH 4/7] qemu-char: Introduce Memory driver

2010-11-17 Thread Luiz Capitulino
This driver handles in-memory chardev operations. That's, all writes to this driver are stored in an internal buffer and it doesn't talk to the external world in any way. Right now it's very simple: it supports only writes. But it can be easily extended to support more operations. This is going

[Qemu-devel] [PATCH 6/7] QMP/qmp-shell: Introduce HMP mode

2010-11-17 Thread Luiz Capitulino
In which qmp-shell will exclusively use the HMP passthrough feature, this is useful for testing. Example: # ./qmp-shell -H qmp-sock Welcome to the HMP shell! Connected to QEMU 0.13.50 (QEMU) info network VLAN 0 devices: user.0: net=10.0.2.0, restricted=n

[Qemu-devel] Re: [PATCH] spice: add qxl device

2010-11-17 Thread Gerd Hoffmann
On 11/16/10 18:43, Michael S. Tsirkin wrote: On Tue, Nov 02, 2010 at 02:34:58PM +0100, Gerd Hoffmann wrote: +if (ram_size 32 * 1024 * 1024) +ram_size = 32 * 1024 * 1024; +vga_common_init(vga, ram_size); +vga_init(vga); +register_ioport_write(0x3c0,

Re: [Qemu-devel] [RFC PATCH v2 2/4] Add block-queue

2010-11-17 Thread Kevin Wolf
Am 17.11.2010 13:43, schrieb Stefan Hajnoczi: On Fri, Nov 5, 2010 at 6:38 PM, Kevin Wolf kw...@redhat.com wrote: Instead of directly executing writes and fsyncs, queue them and execute them asynchronously. What makes this interesting is that we can delay syncs and if multiple syncs occur, we

Re: [Qemu-devel] [PATCH 08/10] ahci: add ahci emulation

2010-11-17 Thread Gerd Hoffmann
Hi, Hmm, no bus registered anywhere. Dunno whenever it makes sense to register ide bus(es) here or whenever we should create a new sata bus. I'm not sure I understand this comment :). The ahci controller should register one or more busses where you can hook up devices to via -device.

[Qemu-devel] Re: [PATCH] spice: add qxl device

2010-11-17 Thread Michael S. Tsirkin
On Wed, Nov 17, 2010 at 02:28:21PM +0100, Gerd Hoffmann wrote: On 11/16/10 18:43, Michael S. Tsirkin wrote: On Tue, Nov 02, 2010 at 02:34:58PM +0100, Gerd Hoffmann wrote: +if (ram_size 32 * 1024 * 1024) +ram_size = 32 * 1024 * 1024; +vga_common_init(vga,

[Qemu-devel] [PATCH 0/2] Re: [PATCH v9 5/8] pcie/aer: helper functions for pcie aer capability

2010-11-17 Thread Michael S. Tsirkin
On Tue, Nov 16, 2010 at 05:26:09PM +0900, Isaku Yamahata wrote: This patch implements helper functions for pcie aer capability which will be used later. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp OK, I applied this and tried to get rid of recursion, and clean up some whitespace and

[Qemu-devel] [PATCH 1/2] pcie_aer: get rid of recursion

2010-11-17 Thread Michael S. Tsirkin
Added some TODOs: they are trivial but omitted here to make the patch logic as transparent as possible. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/pcie_aer.c | 48 +++- 1 files changed, 31 insertions(+), 17 deletions(-) diff --git

[Qemu-devel] [PATCH 2/2] pcie_aer: complete unwinding recursion

2010-11-17 Thread Michael S. Tsirkin
Open-code functions created in the previous patch, to make code more compact and clear. Detcted and documented what looks like a bug in code that becomes apparent from this refactoring. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/pcie_aer.c | 80

[Qemu-devel] Re: [PATCH comment tweaked] msix: allow byte and word reading from mmio

2010-11-17 Thread Michael S. Tsirkin
On Tue, Nov 16, 2010 at 05:43:06PM +0100, Bernhard Kohl wrote: Am 16.11.2010 14:14, schrieb m...@redhat.com: Although explicitly disallowed by the PCI spec, some guests read a single byte or word from mmio. Likely a guest OS bug, but I have an OS which reads single bytes and it works fine on

[Qemu-devel] Re: [PATCH comment tweaked] msix: allow byte and word reading from mmio

2010-11-17 Thread Michael S. Tsirkin
On Tue, Nov 16, 2010 at 05:43:06PM +0100, Bernhard Kohl wrote: Am 16.11.2010 14:14, schrieb m...@redhat.com: Although explicitly disallowed by the PCI spec, some guests read a single byte or word from mmio. Likely a guest OS bug, but I have an OS which reads single bytes and it works fine on

[Qemu-devel] Re: [PATCH v9 0/8] pcie port switch emulators

2010-11-17 Thread Michael S. Tsirkin
On Tue, Nov 16, 2010 at 05:26:04PM +0900, Isaku Yamahata wrote: Now v9 of pcie aer patch series. I dropped qmp patch to inject aer error because it will depends on Gleb's openfirmware path patches. Once his patches are merged, the glue patch will be respined. Patch description: The patch

[Qemu-devel] Re: [PATCH] spice: add qxl device

2010-11-17 Thread Gerd Hoffmann
Hi, +qxl0 = qxl; What happens when this device is then removed? Better don't try ... Better prevent it then? How can I do that? The primary vga can't be hot-unplugged in qemu. Not only because the qxl0 pointer would point into nowhere in this case, but also because you

[Qemu-devel] [Bug 673613] Re: ARM semihosting SYS_GET_CMDLINE does not return arguments

2010-11-17 Thread Wolfgang Schildbach
diff --git a/arm-semi.c b/arm-semi.c index 0687b03..53b40e4 100644 --- a/arm-semi.c +++ b/arm-semi.c @@ -373,45 +373,48 @@ uint32_t do_arm_semihosting(CPUState *env) #ifdef CONFIG_USER_ONLY /* Build a commandline from the original argv. */ { -char **arg =

[Qemu-devel] Re: [PATCH comment tweaked] msix: allow byte and word reading from mmio

2010-11-17 Thread Bernhard Kohl
Am 17.11.2010 15:12, schrieb ext Michael S. Tsirkin: On Tue, Nov 16, 2010 at 05:43:06PM +0100, Bernhard Kohl wrote: Am 16.11.2010 14:14, schrieb m...@redhat.com: Although explicitly disallowed by the PCI spec, some guests read a single byte or word from mmio. Likely a guest OS bug,

[Qemu-devel] [PATCH v4 0/4] virtio: Use ioeventfd for virtqueue notify

2010-11-17 Thread Stefan Hajnoczi
The v4 version includes: * Simpler start/stop ioeventfd mechanism using bool ioeventfd_started state * Support for migration * Handle deassign race condition to avoid dropping a virtqueue kick * Add missing kvm_enabled() check to kvm_has_many_ioeventfds() * Documentation updates for qdev

[Qemu-devel] [PATCH v4 2/4] virtio-pci: Use ioeventfd for virtqueue notify

2010-11-17 Thread Stefan Hajnoczi
Virtqueue notify is currently handled synchronously in userspace virtio. This prevents the vcpu from executing guest code while hardware emulation code handles the notify. On systems that support KVM, the ioeventfd mechanism can be used to make virtqueue notify a lightweight exit by deferring

[Qemu-devel] [PATCH v4 3/4] virtio-pci: Don't use ioeventfd on old kernels

2010-11-17 Thread Stefan Hajnoczi
There used to be a limit of 6 KVM io bus devices inside the kernel. On such a kernel, don't use ioeventfd for virtqueue host notification since the limit is reached too easily. This ensures that existing vhost-net setups (which always use ioeventfd) have ioeventfds available so they can continue

[Qemu-devel] [PATCH v4 4/4] docs: Document virtio PCI -device ioeventfd=on|off

2010-11-17 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- docs/qdev-device-use.txt |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/docs/qdev-device-use.txt b/docs/qdev-device-use.txt index f252c8e..85feda7 100644 --- a/docs/qdev-device-use.txt +++

[Qemu-devel] [PATCH v4 1/4] virtio-pci: Rename bugs field to flags

2010-11-17 Thread Stefan Hajnoczi
The VirtIOPCIProxy bugs field is currently used to enable workarounds for older guests. Rename it to flags so that other per-device behavior can be tracked. A later patch uses the flags field to remember whether ioeventfd should be used for virtqueue host notification. Signed-off-by: Stefan

Re: [Qemu-devel] [PATCH 0/1] [PULL] qemu-kvm.git uq/master queue

2010-11-17 Thread Anthony Liguori
On 11/05/2010 07:44 PM, Marcelo Tosatti wrote: The following changes since commit d33ea50a958b2e050d2b28e5f17e3b55e91c6d74: scsi-disk: Fix immediate failure of bdrv_aio_* (2010-11-04 13:54:37 +0100) Pulled. Thanks. Regards, Anthony Liguori are available in the git repository at:

[Qemu-devel] Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-17 Thread Kevin O'Connor
On Tue, Nov 16, 2010 at 09:22:45AM +0200, Gleb Natapov wrote: On Mon, Nov 15, 2010 at 09:52:19PM -0500, Kevin O'Connor wrote: I also have an ulterior motive here. If the boot order is exposed as a newline separated list via an entry in QEMU_CFG_FILE_DIR, then this becomes free for coreboot

Re: [Qemu-devel] [RFC PATCH v2 2/4] Add block-queue

2010-11-17 Thread Stefan Hajnoczi
On Wed, Nov 17, 2010 at 1:41 PM, Kevin Wolf kw...@redhat.com wrote: Am 17.11.2010 13:43, schrieb Stefan Hajnoczi: A typical sequence in qcow2 (simple cluster allocation) looks like this: 1. Update refcount table 2. bdrv_flush 3. Update L2 entry If we delay the operation and get three of

Re: [Qemu-devel] [RFC PATCH v2 2/4] Add block-queue

2010-11-17 Thread Stefan Hajnoczi
On Wed, Nov 17, 2010 at 1:41 PM, Kevin Wolf kw...@redhat.com wrote: Am 17.11.2010 13:43, schrieb Stefan Hajnoczi: A typical sequence in qcow2 (simple cluster allocation) looks like this: 1. Update refcount table 2. bdrv_flush 3. Update L2 entry If we delay the operation and get three of

[Qemu-devel] Re: [PATCH comment tweaked] msix: allow byte and word reading from mmio

2010-11-17 Thread Michael S. Tsirkin
On Wed, Nov 17, 2010 at 05:12:12PM +0100, Bernhard Kohl wrote: I will fix the guest and inform you after testing. Then we can skip this patch. OK, that's best,

[Qemu-devel] Re: [PATCH] spice: add qxl device

2010-11-17 Thread Michael S. Tsirkin
On Wed, Nov 17, 2010 at 04:20:45PM +0100, Gerd Hoffmann wrote: Hi, +qxl0 = qxl; What happens when this device is then removed? Better don't try ... Better prevent it then? How can I do that? The primary vga can't be hot-unplugged in qemu. Not only because the qxl0

[Qemu-devel] [PATCHv6 00/16] boot order specification

2010-11-17 Thread Gleb Natapov
I am using open firmware naming scheme to specify device path names. In this version: added SCSI bus support. Pass boot order list as file to firmware. Names look like this on pci machine: /p...@i0cf8/i...@1,1/dr...@1/d...@0 /p...@i0cf8/i...@1/f...@03f1/flo...@1

[Qemu-devel] [PATCHv6 04/16] Add get_fw_dev_path callback to ISA bus in qdev.

2010-11-17 Thread Gleb Natapov
Use device ioports to create unique device path. Signed-off-by: Gleb Natapov g...@redhat.com --- hw/isa-bus.c | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/hw/isa-bus.c b/hw/isa-bus.c index c0ac7e9..c423c1b 100644 --- a/hw/isa-bus.c +++ b/hw/isa-bus.c

[Qemu-devel] [PATCHv6 01/16] Introduce fw_name field to DeviceInfo structure.

2010-11-17 Thread Gleb Natapov
Add fw_name to DeviceInfo to use in device path building. In contrast to name fw_name should refer to functionality device provides instead of particular device model like name does. Signed-off-by: Gleb Natapov g...@redhat.com --- hw/fdc.c|1 + hw/ide/isa.c|1 + hw/ide/qdev.c

[Qemu-devel] [PATCHv6 02/16] Introduce new BusInfo callback get_fw_dev_path.

2010-11-17 Thread Gleb Natapov
New get_fw_dev_path callback will be used for build device path usable by firmware in contrast to qdev qemu internal device path. Signed-off-by: Gleb Natapov g...@redhat.com --- hw/qdev.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/qdev.h b/hw/qdev.h index

[Qemu-devel] [PATCHv6 09/16] Record which USBDevice USBPort belongs too.

2010-11-17 Thread Gleb Natapov
Ports on root hub will have NULL here. This is needed to reconstruct path from device to its root hub to build device path. Signed-off-by: Gleb Natapov g...@redhat.com --- hw/usb-bus.c |3 ++- hw/usb-hub.c |2 +- hw/usb-musb.c |2 +- hw/usb-ohci.c |2 +- hw/usb-uhci.c |2 +-

[Qemu-devel] [PATCHv6 10/16] Add get_dev_path callback for usb bus.

2010-11-17 Thread Gleb Natapov
Signed-off-by: Gleb Natapov g...@redhat.com --- hw/usb-bus.c | 42 ++ 1 files changed, 42 insertions(+), 0 deletions(-) diff --git a/hw/usb-bus.c b/hw/usb-bus.c index 256b881..8b4583c 100644 --- a/hw/usb-bus.c +++ b/hw/usb-bus.c @@ -5,11 +5,13 @@

[Qemu-devel] [PATCHv6 07/16] Add get_dev_path callback for system bus.

2010-11-17 Thread Gleb Natapov
Prints out mmio or pio used to access child device. Signed-off-by: Gleb Natapov g...@redhat.com --- hw/pci_host.c |2 ++ hw/sysbus.c | 30 ++ hw/sysbus.h |4 3 files changed, 36 insertions(+), 0 deletions(-) diff --git a/hw/pci_host.c

[Qemu-devel] [PATCHv6 08/16] Add get_fw_dev_path callback for pci bus.

2010-11-17 Thread Gleb Natapov
Signed-off-by: Gleb Natapov g...@redhat.com --- hw/pci.c | 108 - 1 files changed, 85 insertions(+), 23 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 438c0d1..8514e15 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -43,12 +43,14 @@

[Qemu-devel] [PATCHv6 13/16] Change fw_cfg_add_file() to get full file path as a parameter.

2010-11-17 Thread Gleb Natapov
Change fw_cfg_add_file() to get full file path as a parameter instead of building one internally. Two reasons for that. First caller may need to know how file is named. Second this moves policy of file naming out from fw_cfg. Platform may want to use more then two levels of directories for

[Qemu-devel] [PATCHv6 06/16] Add get_fw_dev_path callback to IDE bus.

2010-11-17 Thread Gleb Natapov
Signed-off-by: Gleb Natapov g...@redhat.com --- hw/ide/qdev.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/hw/ide/qdev.c b/hw/ide/qdev.c index 88ff657..01a181b 100644 --- a/hw/ide/qdev.c +++ b/hw/ide/qdev.c @@ -24,9 +24,12 @@ /*

[Qemu-devel] [PATCHv6 15/16] Add notifier that will be called when machine is fully created.

2010-11-17 Thread Gleb Natapov
Action that depends on fully initialized device model should register with this notifier chain. Signed-off-by: Gleb Natapov g...@redhat.com --- sysemu.h |2 ++ vl.c | 15 +++ 2 files changed, 17 insertions(+), 0 deletions(-) diff --git a/sysemu.h b/sysemu.h index

[Qemu-devel] [PATCHv6 12/16] Add bootindex parameter to net/block/fd device

2010-11-17 Thread Gleb Natapov
If bootindex is specified on command line a string that describes device in firmware readable way is added into sorted list. Later this list will be passed into firmware to control boot order. Signed-off-by: Gleb Natapov g...@redhat.com --- block_int.h |4 +++- hw/e1000.c |4

[Qemu-devel] [PATCHv6 05/16] Store IDE bus id in IDEBus structure for easy access.

2010-11-17 Thread Gleb Natapov
Signed-off-by: Gleb Natapov g...@redhat.com --- hw/ide/cmd646.c |4 ++-- hw/ide/internal.h |3 ++- hw/ide/isa.c |2 +- hw/ide/piix.c |4 ++-- hw/ide/qdev.c |3 ++- hw/ide/via.c |4 ++-- 6 files changed, 11 insertions(+), 9 deletions(-) diff --git

[Qemu-devel] [PATCHv6 03/16] Keep track of ISA ports ISA device is using in qdev.

2010-11-17 Thread Gleb Natapov
Store all io ports used by device in ISADevice structure. Signed-off-by: Gleb Natapov g...@redhat.com --- hw/cs4231a.c |1 + hw/fdc.c |3 +++ hw/gus.c |4 hw/ide/isa.c |2 ++ hw/isa-bus.c | 25 + hw/isa.h |4

[Qemu-devel] [PATCHv6 14/16] Add bootindex for option roms.

2010-11-17 Thread Gleb Natapov
Extend -option-rom command to have additional parameter ,bootindex=. Signed-off-by: Gleb Natapov g...@redhat.com --- hw/loader.c| 16 +++- hw/loader.h|8 hw/multiboot.c |3 ++- hw/ne2000.c|2 +- hw/nseries.c |4 ++-- hw/palm.c |6

[Qemu-devel] [PATCHv6 16/16] Pass boot device list to firmware.

2010-11-17 Thread Gleb Natapov
Signed-off-by: Gleb Natapov g...@redhat.com --- hw/fw_cfg.c | 14 ++ sysemu.h|1 + vl.c| 48 3 files changed, 63 insertions(+), 0 deletions(-) diff --git a/hw/fw_cfg.c b/hw/fw_cfg.c index 7b9434f..20a816f 100644

Re: [Qemu-devel] [PATCH] s390: compile fixes

2010-11-17 Thread Stefan Weil
Am 17.11.2010 13:01, schrieb Alexander Graf: The s390 target doesn't compile out of the box anymore. This patch fixes all the obvious glitches that got introduced in the last few weeks. Signed-off-by: Alexander Graf ag...@suse.de --- hw/s390-virtio-bus.h | 2 ++ hw/s390-virtio.c | 1 +

[Qemu-devel] Re: [PATCH] spice: add qxl device

2010-11-17 Thread Gerd Hoffmann
Hi, Better don't try ... Better prevent it then? How can I do that? Question still stands: Is there some way to disable hotplug for certain pci devices? How does this work btw? Only one vga adapter can drive the legacy vga ports, right? Is there some way to enable/disable this

Re: [Qemu-devel] [PATCH] s390: compile fixes

2010-11-17 Thread Alexander Graf
On 17.11.2010, at 18:07, Stefan Weil wrote: Am 17.11.2010 13:01, schrieb Alexander Graf: The s390 target doesn't compile out of the box anymore. This patch fixes all the obvious glitches that got introduced in the last few weeks. Signed-off-by: Alexander Graf ag...@suse.de ---

[Qemu-devel] [Bug 673613] Re: ARM semihosting SYS_GET_CMDLINE does not return arguments

2010-11-17 Thread Wolfgang Schildbach
Hi Peter, Is this what you had in mind? -- ARM semihosting SYS_GET_CMDLINE does not return arguments https://bugs.launchpad.net/bugs/673613 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. Status in QEMU: New Bug description: I have

[Qemu-devel] Re: [PATCH] spice: add qxl device

2010-11-17 Thread Michael S. Tsirkin
On Wed, Nov 17, 2010 at 06:02:39PM +0100, Gerd Hoffmann wrote: Hi, Better don't try ... Better prevent it then? How can I do that? Question still stands: Is there some way to disable hotplug for certain pci devices? Not sure. It's really a work-around bug, maybe it's better to

[Qemu-devel] Re: [PATCH v4 0/4] virtio: Use ioeventfd for virtqueue notify

2010-11-17 Thread Michael S. Tsirkin
On Wed, Nov 17, 2010 at 04:19:25PM +, Stefan Hajnoczi wrote: The v4 version includes: * Simpler start/stop ioeventfd mechanism using bool ioeventfd_started state * Support for migration * Handle deassign race condition to avoid dropping a virtqueue kick * Add missing kvm_enabled()

Re: [Qemu-devel] [PATCH] Force object directory use

2010-11-17 Thread Blue Swirl
On Tue, Nov 16, 2010 at 10:37 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 16 November 2010 21:59, Blue Swirl blauwir...@gmail.com wrote: If the user attempts to run 'configure' in the source tree, create an object directory and configure that instead. Rename topmost Makefile to

[Qemu-devel] Re: [PATCH v2] Force object directory use

2010-11-17 Thread Blue Swirl
On Wed, Nov 17, 2010 at 8:00 PM, Paolo Bonzini pbonz...@redhat.com wrote: On 11/17/2010 08:15 PM, Blue Swirl wrote: If the user attempts to run 'configure' in the source tree, create an object directory and configure that instead. Rename topmost Makefile to Makefile.top. Add a new Makefile,

[Qemu-devel] Re: [PATCH v2] Force object directory use

2010-11-17 Thread Paolo Bonzini
On 11/17/2010 08:15 PM, Blue Swirl wrote: If the user attempts to run 'configure' in the source tree, create an object directory and configure that instead. Rename topmost Makefile to Makefile.top. Add a new Makefile, which is only used when user attempts to run 'make' in the source tree.

Re: [Qemu-devel] Re: [PATCH v4 0/4] virtio: Use ioeventfd for virtqueue notify

2010-11-17 Thread Stefan Hajnoczi
On Wed, Nov 17, 2010 at 6:01 PM, Michael S. Tsirkin m...@redhat.com wrote: On Wed, Nov 17, 2010 at 04:19:25PM +, Stefan Hajnoczi wrote: The v4 version includes:  * Simpler start/stop ioeventfd mechanism using bool ioeventfd_started state  * Support for migration  * Handle deassign race

Re: [Qemu-devel] Re: [PATCH v4 0/4] virtio: Use ioeventfd for virtqueue notify

2010-11-17 Thread Michael S. Tsirkin
On Wed, Nov 17, 2010 at 08:38:25PM +, Stefan Hajnoczi wrote: On Wed, Nov 17, 2010 at 6:01 PM, Michael S. Tsirkin m...@redhat.com wrote: On Wed, Nov 17, 2010 at 04:19:25PM +, Stefan Hajnoczi wrote: The v4 version includes:  * Simpler start/stop ioeventfd mechanism using bool

Re: [Qemu-devel] Re: [PATCH v4 0/4] virtio: Use ioeventfd for virtqueue notify

2010-11-17 Thread Stefan Hajnoczi
On Wed, Nov 17, 2010 at 8:49 PM, Michael S. Tsirkin m...@redhat.com wrote: On Wed, Nov 17, 2010 at 08:38:25PM +, Stefan Hajnoczi wrote: On Wed, Nov 17, 2010 at 6:01 PM, Michael S. Tsirkin m...@redhat.com wrote: On Wed, Nov 17, 2010 at 04:19:25PM +, Stefan Hajnoczi wrote: The v4

[Qemu-devel] [PATCH] ceph/rbd block driver for qemu-kvm (v8)

2010-11-17 Thread Christian Brunner
Here is another update for the ceph storage driver. It includes changes for the annotations Stefan made last week and a bit more things Sage discovered while looking over the driver again. I really hope that this time we are not only close, but have reached a quality that everyone is satisfied

Re: [Qemu-devel] [RFC][PATCH v3 07/21] virtproxy: add read handler for communication channel

2010-11-17 Thread Michael Roth
On 11/16/2010 05:17 PM, Anthony Liguori wrote: Except, in virtproxy, the fact that Alice cannot talk to Joe blocks Mary from talking to Bob which creates a dead lock. To be honest, there's no simple solution. This is a classic queuing problem. You need some form of congestion control to fix

[Qemu-devel] Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-17 Thread Blue Swirl
2010/11/16 Gleb Natapov g...@redhat.com: On Tue, Nov 16, 2010 at 06:30:19PM +, Blue Swirl wrote: Perhaps the FW path should use device class names if no name is specified. What do you mean by device class name. We can do something like this: if (dev-child_bus.lh_first)        return

[Qemu-devel] Re: [PATCH v2] Force object directory use

2010-11-17 Thread Paolo Bonzini
On 11/17/2010 09:08 PM, Blue Swirl wrote: It's not simplification but to unify the build system. Some people make changes to Makefiles and then test their changes without an object directory, these may then break the build for those who use it. This has happened several times already. Hopefully

[Qemu-devel] Re: [patch] fix scsi-generic

2010-11-17 Thread adq
I'll have a go at resurrecting it; I wasn't sure if there was any interest before. On 12 November 2010 10:00, Paolo Bonzini pbonz...@redhat.com wrote: On 08/09/2010 01:51 AM, adq wrote: Figured out what the problem is - READ DVD STRUCTURE has its xfer length in an unexpected place, so

Re: [Qemu-devel] Re: [PATCH v2] Force object directory use

2010-11-17 Thread Peter Maydell
On 17 November 2010 22:39, Paolo Bonzini pbonz...@redhat.com wrote: On 11/17/2010 09:08 PM, Blue Swirl wrote: It's not simplification but to unify the build system. Some people make changes to Makefiles and then test their changes without an object directory, these may then break the build for

[Qemu-devel] Re: [patch] fix scsi-generic

2010-11-17 Thread adq
On 12 November 2010 10:00, Paolo Bonzini pbonz...@redhat.com wrote: On 08/09/2010 01:51 AM, adq wrote: Figured out what the problem is - READ DVD STRUCTURE has its xfer length in an unexpected place, so hw/scsi-bus.c retrieves completely the wrong value for the transfer length. Attached

Re: [Qemu-devel] [PATCH v2 2/2] RAM API: Make use of it for x86 PC

2010-11-17 Thread Anthony Liguori
On 11/16/2010 03:24 PM, Alex Williamson wrote: On Tue, 2010-11-16 at 08:58 -0600, Anthony Liguori wrote: On 11/01/2010 10:14 AM, Alex Williamson wrote: Register the actual VM RAM using the new API Signed-off-by: Alex Williamsonalex.william...@redhat.com --- hw/pc.c | 12

[Qemu-devel] Re: [PATCH v2] Force object directory use

2010-11-17 Thread Paolo Bonzini
On 11/18/2010 12:05 AM, Peter Maydell wrote: It may be unified but it's pretty much unlike every other build system I've ever seen. If you want another approach you could do what glibc does (IIRC), which is to just give an error message if you invoke configure in the source directory

Re: [Qemu-devel] Re: [PATCH v2] Force object directory use

2010-11-17 Thread Anthony Liguori
On 11/17/2010 04:39 PM, Paolo Bonzini wrote: On 11/17/2010 09:08 PM, Blue Swirl wrote: It's not simplification but to unify the build system. Some people make changes to Makefiles and then test their changes without an object directory, these may then break the build for those who use it. This

Re: [Qemu-devel] [PATCH 1/2] Add a DTrace tracing backend targetted for SystemTAP compatability

2010-11-17 Thread Anthony Liguori
On 11/17/2010 05:35 AM, Daniel P. Berrange wrote: On Tue, Nov 16, 2010 at 09:46:20AM -0600, Anthony Liguori wrote: On 11/08/2010 01:33 PM, Daniel P. Berrange wrote: This introduces a new tracing backend that targets the SystemTAP implementation of DTrace userspace tracing. The core

[Qemu-devel] [Bug 427612] Re: does not pass pressed caps lock to client

2010-11-17 Thread Benjamin Drung
I am reopening the bug for qemu-kvm, because the patch was dropped in 0.12.4+noroms-0ubuntu1. ** Changed in: qemu-kvm (Ubuntu) Status: Fix Released = New -- does not pass pressed caps lock to client https://bugs.launchpad.net/bugs/427612 You received this bug notification because you are

[Qemu-devel] [Bug 427612] Re: does not pass pressed caps lock to client

2010-11-17 Thread Benjamin Drung
I modified qemu-kvm to show what keys it receives (patch attached). I am using the German NEO layout and I get one press and one release event. Here's the output, if I first press 'caps lock' and then '#':

  1   2   >