[Qemu-devel] [PATCH v3 02/21] kvm: Drop return value of kvm_cpu_exec

2011-01-04 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com It is not used, it is not needed, so let's remove it. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- kvm-all.c |6 ++ kvm-stub.c |4 ++-- kvm.h |2 +- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/kvm-all.c

[Qemu-devel] [PATCH v3 07/21] kvm: x86: Prepare kvm_get_mp_state for in-kernel irqchip

2011-01-04 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com This code path will not yet be taken as we still lack in-kernel irqchip support. But qemu-kvm can already make use of it and drop its own mp_state access services. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- target-i386/kvm.c |3 +++ 1 files

[Qemu-devel] [PATCH v3 00/21] [uq/master] Prepare for more qemu-kvm merging

2011-01-04 Thread Jan Kiszka
Next round, addressing review comments and new findings: - new: Flush coalesced mmio buffer on IO window exits - new: Do not use qemu_fair_mutex in kvm mode - new: Implicitly clear nmi_injected/pending on reset - new: Fix !CONFIG_KVM_PARA build - reworked: Read kvmclock only once per stopped

[Qemu-devel] [PATCH v3 06/21] kvm: x86: Align kvm_arch_put_registers code with comment

2011-01-04 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com The ordering doesn't matter in this case, but better keep it consistent. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- target-i386/kvm.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/target-i386/kvm.c

[Qemu-devel] [PATCH v3 03/21] kvm: Stop on all fatal exit reasons

2011-01-04 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com Ensure that we stop the guest whenever we face a fatal or unknown exit reason. If we stop, we also have to enforce a cpu loop exit. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- kvm-all.c | 15 +++ target-i386/kvm.c |4

[Qemu-devel] [PATCH v3 16/21] kvm: Drop smp_cpus argument from init functions

2011-01-04 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com No longer used. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- kvm-all.c |4 ++-- kvm-stub.c |2 +- kvm.h |4 ++-- target-i386/kvm.c |2 +- target-ppc/kvm.c |2 +- target-s390x/kvm.c |2 +-

[Qemu-devel] [PATCH v3 05/21] x86: Optionally dump code bytes on cpu_dump_state

2011-01-04 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com Introduce the cpu_dump_state flag CPU_DUMP_CODE and implement it for x86. This writes out the code bytes around the current instruction pointer. Make use of this feature in KVM to help debugging fatal vm exits. Signed-off-by: Jan Kiszka

[Qemu-devel] [PATCH v3 10/21] kvm: x86: Refactor msr_star/hsave_pa setup and checks

2011-01-04 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com Simplify kvm_has_msr_star/hsave_pa to booleans and push their one-time initialization into kvm_arch_init. Also handle potential errors of that setup procedure. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- target-i386/kvm.c | 47

[Qemu-devel] [PATCH v3 21/21] kvm: x86: Implicitly clear nmi_injected/pending on reset

2011-01-04 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com All CPUX86State variables before CPU_COMMON are automatically cleared on reset. Reorder nmi_injected and nmi_pending to avoid having to touch them explicitly. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- target-i386/cpu.h |6 --

[Qemu-devel] [PATCH v3 01/21] kvm: Fix coding style violations

2011-01-04 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com No functional changes. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- kvm-all.c | 139 ++-- 1 files changed, 79 insertions(+), 60 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index

[Qemu-devel] [PATCH v3 19/21] kvm: Flush coalesced mmio buffer on IO window exits

2011-01-04 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com We must flush pending mmio writes if we leave kvm_cpu_exec for an IO window. Otherwise we risk to loose those requests when migrating to a different host during that window. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- kvm-all.c |4 ++-- 1

[Qemu-devel] [PATCH v3 13/21] kvm: Eliminate KVMState arguments

2011-01-04 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com QEMU supports only one VM, so there is only one kvm_state per process, and we gain nothing passing a reference to it around. Eliminate any need to refer to it outside of kvm-all.c. Signed-off-by: Jan Kiszka jan.kis...@siemens.com CC: Alexander Graf

[Qemu-devel] [PATCH v3 08/21] kvm: x86: Remove redundant mp_state initialization

2011-01-04 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com kvm_arch_reset_vcpu initializes mp_state, and that function is invoked right after kvm_arch_init_vcpu. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- target-i386/kvm.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH v3 04/21] kvm: Improve reporting of fatal errors

2011-01-04 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com Report KVM_EXIT_UNKNOWN, KVM_EXIT_FAIL_ENTRY, and KVM_EXIT_EXCEPTION with more details to stderr. The latter two are so far x86-only, so move them into the arch-specific handler. Integrate the Intel real mode warning on KVM_EXIT_FAIL_ENTRY that qemu-kvm

[Qemu-devel] Re: [PATCH v2 00/17] [uq/master] Prepare for more qemu-kvm merging

2011-01-04 Thread Jan Kiszka
Am 03.01.2011 17:09, Avi Kivity wrote: On 01/03/2011 10:32 AM, Jan Kiszka wrote: All previously sent patches against current uq combined, some smaller tweaks applied, and 4 new patches added. Major news is support for using up to 16M BIOSes and optional code dump for cpu_dump_state. Those

[Qemu-devel] [PATCH v3 11/21] kvm: x86: Reset paravirtual MSRs

2011-01-04 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com Make sure to write the cleared MSR_KVM_SYSTEM_TIME, MSR_KVM_WALL_CLOCK, and MSR_KVM_ASYNC_PF_EN to the kernel state so that a freshly booted guest cannot be disturbed by old values. Signed-off-by: Jan Kiszka jan.kis...@siemens.com CC: Glauber Costa

[Qemu-devel] [PATCH v3 09/21] kvm: x86: Fix xcr0 reset mismerge

2011-01-04 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com For unknown reasons, xcr0 reset ended up in kvm_arch_update_guest_debug on upstream merge. Fix this and also remove the misleading comment (1 is THE reset value). Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- target-i386/kvm.c |3 +-- 1 files

[Qemu-devel] [PATCH v3 12/21] kvm: x86: Drop MCE MSRs write back restrictions

2011-01-04 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com There is no need to restrict writing back MCE MSRs to reset or full state updates as setting their values has no side effects. Signed-off-by: Jan Kiszka jan.kis...@siemens.com CC: Huang Ying ying.hu...@intel.com --- target-i386/kvm.c | 12

[Qemu-devel] [PATCH v3 14/21] kvm: x86: Fix !CONFIG_KVM_PARA build

2011-01-04 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com If we lack kvm_para.h, MSR_KVM_ASYNC_PF_EN is not defined. The change in kvm_arch_init_vcpu is just for consistency reasons. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- target-i386/kvm.c |8 1 files changed, 4 insertions(+), 4

[Qemu-devel] [PATCH v3 18/21] kvm: x86: Rework identity map and TSS setup for larger BIOS sizes

2011-01-04 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com In order to support loading BIOSes 256K, reorder the code, adjusting the base if the kernel supports moving the identity map. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- target-i386/kvm.c | 63

[Qemu-devel] [PATCH v3 15/21] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-04 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com If kvmclock is used, which implies the kernel supports it, register a kvmclock device with the sysbus. Its main purpose is to save and restore the kernel state on migration, but this will also allow to visualize it one day. Signed-off-by: Jan Kiszka

[Qemu-devel] Re: [PATCH v2 00/17] [uq/master] Prepare for more qemu-kvm merging

2011-01-04 Thread Avi Kivity
On 01/04/2011 10:42 AM, Jan Kiszka wrote: Sounds really frightening... this glue code is a real breeding ground for subtle bugs and merge problems. ...and that's why we are more than late with unifying it into a single code base. After that upcoming cleanup round we will have three major

[Qemu-devel] [PATCH v3 20/21] kvm: Do not use qemu_fair_mutex

2011-01-04 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com The imbalance in the hold time of qemu_global_mutex only exists in TCG mode. In contrast to TCG VCPUs, KVM drops the global lock during guest execution. We already avoid touching the fairness lock from the IO-thread in KVM mode, so also stop using it from

[Qemu-devel] [PATCH v3 17/21] kvm: Consolidate must-have capability checks

2011-01-04 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com Instead of splattering the code with #ifdefs and runtime checks for capabilities we cannot work without anyway, provide central test infrastructure for verifying their availability both at build and runtime. Signed-off-by: Jan Kiszka jan.kis...@siemens.com

[Qemu-devel] Re: [Bug 638955] Re: emulated netcards don't work with recent sunos kernel

2011-01-04 Thread Stefan Hajnoczi
On Mon, Jan 3, 2011 at 1:40 PM, daniel pecka 638...@bugs.launchpad.net wrote: is this issue dead ?? can i do something for help to fix it? I believe no one has investigated this issue since my last comment. Someone with time and interest in Solaris needs to step up to debug this problem. DTrace

[Qemu-devel] [Bug 532733] Re: apt/dpkg in qemu-system-arm hangs if a big task is installed

2011-01-04 Thread Oliver Grawert
this bug has nothing to do with mono at all, please do not confuse it with the (already open and already commented) mono tasks. this bug is about qemu hanging if a big task of packages is installed, even if there are no mono packages among them. note in the initial logs that it hangs in various

[Qemu-devel] [Bug 638955] Re: emulated netcards don't work with recent sunos kernel

2011-01-04 Thread daniel pecka
okay Stefan .. thanks, i poked several people and trying to learn up how netstack works .. i have no experience with programming drivers .. i hope that we'll fix it soon cuz it's very bad that we're unable to use kvm|qemu regards, daniel -- You received this bug notification because you are a

[Qemu-devel] [PATCH] Close Gdb stub connection in gdb_exit

2011-01-04 Thread Fabien Chouteau
On Windows, this is required to flush the remaining data in the IO stream, otherwise Gdb do not receive the last packet. Signed-off-by: Fabien Chouteau chout...@adacore.com --- gdbstub.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index

[Qemu-devel] Re: [PATCH] ioeventfd: minor fixups

2011-01-04 Thread Stefan Hajnoczi
On Mon, Jan 03, 2011 at 06:38:53PM +0200, Michael S. Tsirkin wrote: On Wed, Dec 29, 2010 at 04:52:46PM +0200, Michael S. Tsirkin wrote: This is on top of the ioeventfd patches, and fixes two potential issues when ioeventfd is mixed with vhost-net: - ioeventfd could start running then get

Re: [Qemu-devel] HELP PLEASE! Consecutive runs of qemu-user

2011-01-04 Thread Stefan Weil
Am 01.01.2011 22:31, schrieb Stefano Bonifazi: Hi! First of all Happy new year to everybody! :) Wish you all to realize all your dreams! :) I edited QEMU user, more exactly qemu-ppc launching the main function (inside main.c) from another c function I created, passing it the appropriate

[Qemu-devel] Re: [PATCH 09/21] Introduce event-tap.

2011-01-04 Thread Yoshiaki Tamura
2010/11/29 Stefan Hajnoczi stefa...@gmail.com: On Thu, Nov 25, 2010 at 6:06 AM, Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp wrote: event-tap controls when to start FT transaction, and provides proxy functions to called from net/block devices.  While FT transaction, it queues up net/block

[Qemu-devel] Re: [PATCH v3 11/21] kvm: x86: Reset paravirtual MSRs

2011-01-04 Thread Glauber Costa
On Tue, 2011-01-04 at 09:32 +0100, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com Make sure to write the cleared MSR_KVM_SYSTEM_TIME, MSR_KVM_WALL_CLOCK, and MSR_KVM_ASYNC_PF_EN to the kernel state so that a freshly booted guest cannot be disturbed by old values. Signed-off-by:

[Qemu-devel] Re: [PATCH v3 15/21] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-04 Thread Glauber Costa
On Tue, 2011-01-04 at 09:32 +0100, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com If kvmclock is used, which implies the kernel supports it, register a kvmclock device with the sysbus. Its main purpose is to save and restore the kernel state on migration, but this will also allow

[Qemu-devel] Re: [PATCH 09/21] Introduce event-tap.

2011-01-04 Thread Stefan Hajnoczi
On Tue, Jan 4, 2011 at 11:02 AM, Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp wrote: After doing some heavy load tests, I realized that we have to take a hybrid approach to replay for now.  This is because when a device moves to the next state (e.g. virtio decreases inuse) is different

[Qemu-devel] Re: [PATCH 09/21] Introduce event-tap.

2011-01-04 Thread Michael S. Tsirkin
On Tue, Jan 04, 2011 at 08:02:54PM +0900, Yoshiaki Tamura wrote: 2010/11/29 Stefan Hajnoczi stefa...@gmail.com: On Thu, Nov 25, 2010 at 6:06 AM, Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp wrote: event-tap controls when to start FT transaction, and provides proxy functions to called

[Qemu-devel] Re: [PATCH v3 15/21] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-04 Thread Jan Kiszka
Am 04.01.2011 12:08, Glauber Costa wrote: On Tue, 2011-01-04 at 09:32 +0100, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com If kvmclock is used, which implies the kernel supports it, register a kvmclock device with the sysbus. Its main purpose is to save and restore the kernel

[Qemu-devel] Re: [PATCH v3 15/21] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-04 Thread Glauber Costa
On Tue, 2011-01-04 at 12:34 +0100, Jan Kiszka wrote: Am 04.01.2011 12:08, Glauber Costa wrote: On Tue, 2011-01-04 at 09:32 +0100, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com If kvmclock is used, which implies the kernel supports it, register a kvmclock device with the

[Qemu-devel] [[PATCH][RESEND]] virtio-serial-bus: Bump up control vq descriptors to min. required

2011-01-04 Thread Amit Shah
The current default of 16 buffers for the control vq is too small for the default max_nr_ports of 32. We can get more entries in there, example when asking the guest to add max. allowed ports. Default to using the minimum required (next power of 2) of the max_nr_ports in use. Signed-off-by:

[Qemu-devel] Re: [PATCH v3 15/21] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-04 Thread Jan Kiszka
Am 04.01.2011 12:43, Glauber Costa wrote: On Tue, 2011-01-04 at 12:34 +0100, Jan Kiszka wrote: Am 04.01.2011 12:08, Glauber Costa wrote: On Tue, 2011-01-04 at 09:32 +0100, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com If kvmclock is used, which implies the kernel supports it,

[Qemu-devel] UHCI idle detection

2011-01-04 Thread Stefan Hajnoczi
CPU utilization is a known issue with UHCI emulation. I spent a short time poking around the code and USB specifications trying to come up with a way to detect idle periods where we don't need to poll the frame list at 1000 Hz. I was hoping to find a solution to detect an idle UHCI state, i.e. a

[Qemu-devel] Re: [PATCH v3 15/21] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-04 Thread Glauber Costa
On Tue, 2011-01-04 at 12:45 +0100, Jan Kiszka wrote: Am 04.01.2011 12:43, Glauber Costa wrote: On Tue, 2011-01-04 at 12:34 +0100, Jan Kiszka wrote: Am 04.01.2011 12:08, Glauber Costa wrote: On Tue, 2011-01-04 at 09:32 +0100, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com If

[Qemu-devel] Re: UHCI idle detection

2011-01-04 Thread Gerd Hoffmann
On 01/04/11 12:48, Stefan Hajnoczi wrote: CPU utilization is a known issue with UHCI emulation. I spent a short time poking around the code and USB specifications trying to come up with a way to detect idle periods where we don't need to poll the frame list at 1000 Hz. Check out

Re: [Qemu-devel] Re: [PATCH 09/21] Introduce event-tap.

2011-01-04 Thread Yoshiaki Tamura
2011/1/4 Michael S. Tsirkin m...@redhat.com: On Tue, Jan 04, 2011 at 08:02:54PM +0900, Yoshiaki Tamura wrote: 2010/11/29 Stefan Hajnoczi stefa...@gmail.com: On Thu, Nov 25, 2010 at 6:06 AM, Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp wrote: event-tap controls when to start FT

[Qemu-devel] [PATCH 0/4] [RESEND] [REBASE] Auto-document qdev devices

2011-01-04 Thread Amit Shah
Hello, This is yet another rebase of the patchset I'd sent earlier. Changes: - fixups and new strings for the bootorder patches - new string for the discard property for block devices. The usual notes apply: this is just the start, just getting the framework in place and a few examples so

[Qemu-devel] [PATCH 2/4] virtio-serial: Add description fields for qdev properties

2011-01-04 Thread Amit Shah
Document the parameters for the virtserialport and virtioconsole devices. Example: $ ./x86_64-softmmu/qemu-system-x86_64 -device virtserialport,? virtserialport.nr=uint32, The 'number' for the port for \ predictable port numbers. Use this to spawn ports if you \ plan to migrate the guest.

[Qemu-devel] [PATCH 4/4] block_int.h: Provide documentation for common block qdev properties

2011-01-04 Thread Amit Shah
Document the options common to all block devices. This comes from Kevin. Signed-off-by: Amit Shah amit.s...@redhat.com CC: Kevin Wolf kw...@redhat.com --- block_int.h | 20 1 files changed, 12 insertions(+), 8 deletions(-) diff --git a/block_int.h b/block_int.h index

[Qemu-devel] [PATCH 3/4] net.h: Add description fields for qdev properites

2011-01-04 Thread Amit Shah
This results in an output like: $ ./x86_64-softmmu/qemu-system-x86_64 -device virtio-net-pci,? ... virtio-net-pci.mac=macaddr, The MAC address for the NIC. virtio-net-pci.vlan=vlan, The VLAN to associate the NIC with. virtio-net-pci.netdev=netdev, The peer net device to associate with this

[Qemu-devel] Re: UHCI idle detection

2011-01-04 Thread Stefan Hajnoczi
On Tue, Jan 4, 2011 at 12:13 PM, Gerd Hoffmann kra...@redhat.com wrote: On 01/04/11 12:48, Stefan Hajnoczi wrote: CPU utilization is a known issue with UHCI emulation.  I spent a short time poking around the code and USB specifications trying to come up with a way to detect idle periods where

[Qemu-devel] [PATCH] multiboot: Fix upper memory size in multiboot info

2011-01-04 Thread Kevin Wolf
The upper memory size field should exclude the first MB of RAM. Signed-off-by: Kevin Wolf m...@kevin-wolf.de --- hw/multiboot.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/multiboot.c b/hw/multiboot.c index 7cc3055..0d2bfb4 100644 --- a/hw/multiboot.c +++

Re: [Qemu-devel] Re: [PATCH 09/21] Introduce event-tap.

2011-01-04 Thread Michael S. Tsirkin
On Tue, Jan 04, 2011 at 09:20:53PM +0900, Yoshiaki Tamura wrote: 2011/1/4 Michael S. Tsirkin m...@redhat.com: On Tue, Jan 04, 2011 at 08:02:54PM +0900, Yoshiaki Tamura wrote: 2010/11/29 Stefan Hajnoczi stefa...@gmail.com: On Thu, Nov 25, 2010 at 6:06 AM, Yoshiaki Tamura

Re: [Qemu-devel] Re: [PATCH 09/21] Introduce event-tap.

2011-01-04 Thread Yoshiaki Tamura
2011/1/4 Michael S. Tsirkin m...@redhat.com: On Tue, Jan 04, 2011 at 09:20:53PM +0900, Yoshiaki Tamura wrote: 2011/1/4 Michael S. Tsirkin m...@redhat.com: On Tue, Jan 04, 2011 at 08:02:54PM +0900, Yoshiaki Tamura wrote: 2010/11/29 Stefan Hajnoczi stefa...@gmail.com: On Thu, Nov 25, 2010

[Qemu-devel] Re: UHCI idle detection

2011-01-04 Thread Gerd Hoffmann
Hi, Windows guests needs some registry hackery and Linux guests some udev rules to enable remote wakeup permanently. That commit inspired me to look at UHCI. If the solution requires modifying the guest then it is not widely useful. Well, long-term this shouldn't be a big issue. I

[Qemu-devel] Re: UHCI idle detection

2011-01-04 Thread Anthony Liguori
On 01/04/2011 07:43 AM, Gerd Hoffmann wrote: Hi, Windows guests needs some registry hackery and Linux guests some udev rules to enable remote wakeup permanently. That commit inspired me to look at UHCI. If the solution requires modifying the guest then it is not widely useful. Well,

[Qemu-devel] Re: UHCI idle detection

2011-01-04 Thread Gerd Hoffmann
On 01/04/11 14:49, Anthony Liguori wrote: On 01/04/2011 07:43 AM, Gerd Hoffmann wrote: Hi, Windows guests needs some registry hackery and Linux guests some udev rules to enable remote wakeup permanently. That commit inspired me to look at UHCI. If the solution requires modifying the guest

[Qemu-devel] Re: Role of qemu_fair_mutex

2011-01-04 Thread Anthony Liguori
On 01/03/2011 04:01 AM, Avi Kivity wrote: On 01/03/2011 11:46 AM, Jan Kiszka wrote: Hi, at least in kvm mode, the qemu_fair_mutex seems to have lost its function of balancing qemu_global_mutex access between the io-thread and vcpus. It's now only taken by the latter, isn't it? This and the

[Qemu-devel] Re: UHCI idle detection

2011-01-04 Thread Anthony Liguori
On 01/04/2011 08:16 AM, Gerd Hoffmann wrote: On 01/04/11 14:49, Anthony Liguori wrote: On 01/04/2011 07:43 AM, Gerd Hoffmann wrote: Hi, Windows guests needs some registry hackery and Linux guests some udev rules to enable remote wakeup permanently. That commit inspired me to look at UHCI.

[Qemu-devel] Re: Role of qemu_fair_mutex

2011-01-04 Thread Avi Kivity
On 01/04/2011 04:17 PM, Anthony Liguori wrote: On 01/03/2011 04:01 AM, Avi Kivity wrote: On 01/03/2011 11:46 AM, Jan Kiszka wrote: Hi, at least in kvm mode, the qemu_fair_mutex seems to have lost its function of balancing qemu_global_mutex access between the io-thread and vcpus. It's now

Re: [Qemu-devel] KVM call agenda for Jan 4

2011-01-04 Thread Jes Sorensen
On 01/03/11 11:57, Juan Quintela wrote: Please send any agenda items you are interested in covering. thanks, Juan. Do we have anything for the agenda yet? Jes

Re: [Qemu-devel] KVM call agenda for Jan 4

2011-01-04 Thread Anthony Liguori
On 01/04/2011 08:31 AM, Jes Sorensen wrote: On 01/03/11 11:57, Juan Quintela wrote: Please send any agenda items you are interested in covering. thanks, Juan. Do we have anything for the agenda yet? I could use the extra hour to catch up from the Holiday (as I assume a lot

[Qemu-devel] [PATCH 4/5] Reopen files after migration

2011-01-04 Thread Juan Quintela
We need to invalidate the Read Cache on the destination, otherwise we have corruption. Easy way to reproduce it is: - create an qcow2 images - start qemu on destination of migration (qemu -incoming tcp:...) - start qemu on source of migration and do one install. - migrate at the end of

[Qemu-devel] [PATCH 2/5] blockdev: don't leak id on removal

2011-01-04 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- blockdev.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/blockdev.c b/blockdev.c index d7add36..da619ad 100644 --- a/blockdev.c +++ b/blockdev.c @@ -115,6 +115,7 @@ void drive_uninit(DriveInfo *dinfo)

[Qemu-devel] [PATCH 3/5] blockdev: release resources in the error case

2011-01-04 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- blockdev.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/blockdev.c b/blockdev.c index da619ad..f9bb659 100644 --- a/blockdev.c +++ b/blockdev.c @@ -467,7 +467,7 @@ DriveInfo *drive_init(QemuOpts *opts, int

[Qemu-devel] [PATCH 0/5] Fix migration with NFS iscsi/Fiber channel

2011-01-04 Thread Juan Quintela
Hi This patch set creates infrastructure to invalidate buffers on migration target machine. The best way to see the problems is: # create a new qcow2 image qemu-img create -f qcow2 foo.img # start the destination host qemu path=foo.img # start the source host with one installation qemu

[Qemu-devel] [PATCH 5/5] drive_open: Add invalidate option for block devices

2011-01-04 Thread Juan Quintela
Linux allows to invalidate block devices. This is needed for the incoming migration part. Signed-off-by: Juan Quintela quint...@redhat.com --- block.h |2 ++ block/raw-posix.c | 24 blockdev.c|9 + 3 files changed, 31 insertions(+), 4

[Qemu-devel] [PATCH 1/5] migration: exit with error code

2011-01-04 Thread Juan Quintela
exits due to errors should end with error code 1, not zero or negative. Signed-off-by: Juan Quintela quint...@redhat.com --- migration.c |2 +- vl.c|2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/migration.c b/migration.c index e5ba51c..a8b65e5 100644 ---

Re: [Qemu-devel] Re: [PATCH 09/21] Introduce event-tap.

2011-01-04 Thread Michael S. Tsirkin
On Tue, Jan 04, 2011 at 10:45:13PM +0900, Yoshiaki Tamura wrote: 2011/1/4 Michael S. Tsirkin m...@redhat.com: On Tue, Jan 04, 2011 at 09:20:53PM +0900, Yoshiaki Tamura wrote: 2011/1/4 Michael S. Tsirkin m...@redhat.com: On Tue, Jan 04, 2011 at 08:02:54PM +0900, Yoshiaki Tamura wrote:

[Qemu-devel] Re: KVM call agenda for Jan 4

2011-01-04 Thread Juan Quintela
Juan Quintela quint...@redhat.com wrote: Please send any agenda items you are interested in covering. By popular request, this call got cancelled O:-) Later, Juan. thanks, Juan. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to

Re: [Qemu-devel] KVM call agenda for Jan 4

2011-01-04 Thread Jes Sorensen
On 01/04/11 15:33, Anthony Liguori wrote: On 01/04/2011 08:31 AM, Jes Sorensen wrote: On 01/03/11 11:57, Juan Quintela wrote: Please send any agenda items you are interested in covering. thanks, Juan. Do we have anything for the agenda yet? I could use the extra hour to

[Qemu-devel] Re: Role of qemu_fair_mutex

2011-01-04 Thread Anthony Liguori
On 01/04/2011 08:27 AM, Avi Kivity wrote: On 01/04/2011 04:17 PM, Anthony Liguori wrote: On 01/03/2011 04:01 AM, Avi Kivity wrote: On 01/03/2011 11:46 AM, Jan Kiszka wrote: Hi, at least in kvm mode, the qemu_fair_mutex seems to have lost its function of balancing qemu_global_mutex access

[Qemu-devel] [PATCH] Add VMX cpuid feature to qemu64

2011-01-04 Thread Nadav Har'El
This patch adds the VMX cpuid feature to the default qemu64 CPU type. If KVM doesn't support this feature (i.e., nested VMX is not in the code, or not enabled) it will mask out this bit. Note that other relevant CPU types, such as core2duo already correctly include the VMX feature, and qemu64

[Qemu-devel] Re: Role of qemu_fair_mutex

2011-01-04 Thread Avi Kivity
On 01/04/2011 04:55 PM, Anthony Liguori wrote: When the TCG thread, it needs to let the IO thread run for at least one iteration. Coordinating the execution of the IO thread such that it's guaranteed to run at least once and then having it drop the qemu mutex long enough for the TCG

[Qemu-devel] [PATCH v2 1/8] softfloat: remove HPPA specific code

2011-01-04 Thread Aurelien Jarno
We don't have any HPPA target, so let's remove HPPA specific code. It can be re-added when someone adds an HPPA target. Signed-off-by: Aurelien Jarno aurel...@aurel32.net Reviewed-by: Peter Maydell peter.mayd...@linaro.org --- fpu/softfloat-specialize.h |6 +- 1 files changed, 1

[Qemu-devel] (no subject)

2011-01-04 Thread Aurelien Jarno
This patch series start by a cleanup to remove dead HPPA code and fix a few inconsistencies. The following patch implement implement correct NaN propagation rules for MIPS and PowerPC, following commit 3 54f211b1a49a7387929e22d6e63849fcba48f8a. Changes from v1: - Add softfloat: use bits32 instead

[Qemu-devel] [PATCH v2 3/8] softfloat: rename *IsNaN variables to *IsQuietNaN

2011-01-04 Thread Aurelien Jarno
Similarly to what has been done in commit 185698715dfb18c82ad2a5dbc169908602d43e81 rename the misnamed *IsNaN variables into *IsQuietNaN. Signed-off-by: Aurelien Jarno aurel...@aurel32.net --- fpu/softfloat-specialize.h | 36 1 files changed, 20

[Qemu-devel] [PATCH v2 4/8] softfloat: fix float{32, 64}_maybe_silence_nan() for MIPS

2011-01-04 Thread Aurelien Jarno
On targets that define sNaN with the sNaN bit as one, simply clearing this bit may correspond to an infinite value. Convert it to a default NaN if SNAN_BIT_IS_ONE, as it corresponds to the MIPS implementation, the only emulated CPU with SNAN_BIT_IS_ONE. When other CPU of this type are added, this

[Qemu-devel] [PATCH v2 5/8] softfloat: add float{x80, 128}_maybe_silence_nan()

2011-01-04 Thread Aurelien Jarno
Add float{x80,128}_maybe_silence_nan() functions, they will be need by propagateFloat{x80,128}NaN(). Signed-off-by: Aurelien Jarno aurel...@aurel32.net Reviewed-by: Peter Maydell peter.mayd...@linaro.org --- fpu/softfloat-specialize.h | 46

[Qemu-devel] [PATCH v2 2/8] softfloat: use bits32 instead of uint32

2011-01-04 Thread Aurelien Jarno
Use bits32 instead of uint32 when manipulating floating point values directly for consistency reasons. Signed-off-by: Aurelien Jarno aurel...@aurel32.net --- fpu/softfloat-native.c |4 ++-- fpu/softfloat-specialize.h |6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff

[Qemu-devel] [PATCH v2 8/8] target-ppc: Implement correct NaN propagation rules

2011-01-04 Thread Aurelien Jarno
Implement the correct NaN propagation rules for ARM targets by providing an appropriate pickNaN function. Also fix the #ifdef tests for default NaN definition, the correct name is TARGET_PPC instead of TARGET_POWERPC. Cc: Alexander Graf ag...@suse.de Signed-off-by: Aurelien Jarno

[Qemu-devel] [PATCH v2 6/8] softfloat: use float{32, 64, x80, 128}_maybe_silence_nan()

2011-01-04 Thread Aurelien Jarno
Use float{32,64,x80,128}_maybe_silence_nan() instead of toggling the sNaN bit manually. This allow per target implementation of sNaN to qNaN conversion. Signed-off-by: Aurelien Jarno aurel...@aurel32.net --- fpu/softfloat-specialize.h | 59 1 files

[Qemu-devel] [PATCH v2 7/8] target-mips: Implement correct NaN propagation rules

2011-01-04 Thread Aurelien Jarno
Implement the correct NaN propagation rules for MIPS targets by providing an appropriate pickNaN function. Signed-off-by: Aurelien Jarno aurel...@aurel32.net --- fpu/softfloat-specialize.h | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v2 8/8] target-ppc: Implement correct NaN propagation rules

2011-01-04 Thread Peter Maydell
On 4 January 2011 15:15, Aurelien Jarno aurel...@aurel32.net wrote: Implement the correct NaN propagation rules for ARM targets by providing an appropriate pickNaN function. I think you mean PPC targets :-) -- PMM

Re: [Qemu-devel] [PATCH v2 8/8] target-ppc: Implement correct NaN propagation rules

2011-01-04 Thread Aurelien Jarno
Peter Maydell a écrit : On 4 January 2011 15:15, Aurelien Jarno aurel...@aurel32.net wrote: Implement the correct NaN propagation rules for ARM targets by providing an appropriate pickNaN function. I think you mean PPC targets :-) Yes, cut and paste... -- Aurelien Jarno

[Qemu-devel] Re: Role of qemu_fair_mutex

2011-01-04 Thread Anthony Liguori
On 01/04/2011 09:12 AM, Avi Kivity wrote: On 01/04/2011 04:55 PM, Anthony Liguori wrote: When the TCG thread, it needs to let the IO thread run for at least one iteration. Coordinating the execution of the IO thread such that it's guaranteed to run at least once and then having it drop

Re: [Qemu-devel] Re: [PATCH] Fix segfault with ram_size 4095M without kvm

2011-01-04 Thread Ryan Harper
* Aurelien Jarno aurel...@aurel32.net [2010-12-25 16:37]: On Wed, Dec 08, 2010 at 04:27:45PM -0200, Luiz Capitulino wrote: On Wed, 08 Dec 2010 12:23:12 -0600 Anthony Liguori aligu...@linux.vnet.ibm.com wrote: On 12/08/2010 12:01 PM, Luiz Capitulino wrote: Currently, x86_64-softmmu

Re: [Qemu-devel] [PATCH v2 2/8] softfloat: use bits32 instead of uint32

2011-01-04 Thread Peter Maydell
On 4 January 2011 15:15, Aurelien Jarno aurel...@aurel32.net wrote: Use bits32 instead of uint32 when manipulating floating point values directly for consistency reasons. I'm not convinced this patch is particularly worthwhile, especially since Andreas is working on a patchset which will

Re: [Qemu-devel] Re: UHCI idle detection

2011-01-04 Thread Alexander Graf
On 04.01.2011, at 15:22, Anthony Liguori wrote: On 01/04/2011 08:16 AM, Gerd Hoffmann wrote: On 01/04/11 14:49, Anthony Liguori wrote: On 01/04/2011 07:43 AM, Gerd Hoffmann wrote: Hi, Windows guests needs some registry hackery and Linux guests some udev rules to enable remote wakeup

Re: [Qemu-devel] [PATCH] Add VMX cpuid feature to qemu64

2011-01-04 Thread Alexander Graf
On 04.01.2011, at 16:06, Nadav Har'El wrote: This patch adds the VMX cpuid feature to the default qemu64 CPU type. If KVM doesn't support this feature (i.e., nested VMX is not in the code, or not enabled) it will mask out this bit. qemu64 defines capabilities that qemu emulates. Qemu does

Re: [Qemu-devel] [PATCH 2/2] ARM: wire up the softfloat flush_input_to_zero flag

2011-01-04 Thread Aurelien Jarno
On Mon, Jan 03, 2011 at 04:48:54PM +, Peter Maydell wrote: Wire up the new softfloat support for flushing input denormals to zero on ARM. The FPSCR FZ bit enables flush-to-zero for both inputs and outputs, but the reporting of when inputs are flushed to zero is via a separate IDC bit

Re: [Qemu-devel] [PATCH 1/2] softfloat: Implement flushing input denormals to zero

2011-01-04 Thread Aurelien Jarno
On Mon, Jan 03, 2011 at 04:48:53PM +, Peter Maydell wrote: Add support to softfloat for flushing input denormal float32 and float64 to zero. softfloat's existing 'flush_to_zero' flag only flushes denormals to zero on output. Some CPUs need input denormals to be flushed before processing as

Re: [Qemu-devel] [PATCH v2 3/8] softfloat: rename *IsNaN variables to *IsQuietNaN

2011-01-04 Thread Peter Maydell
On 4 January 2011 15:15, Aurelien Jarno aurel...@aurel32.net wrote: Similarly to what has been done in commit 185698715dfb18c82ad2a5dbc169908602d43e81 rename the misnamed *IsNaN variables into *IsQuietNaN. Signed-off-by: Aurelien Jarno aurel...@aurel32.net Reviewed-by: Peter Maydell

Re: [Qemu-devel] [PATCH v2 6/8] softfloat: use float{32, 64, x80, 128}_maybe_silence_nan()

2011-01-04 Thread Peter Maydell
On 4 January 2011 15:15, Aurelien Jarno aurel...@aurel32.net wrote: Use float{32,64,x80,128}_maybe_silence_nan() instead of toggling the sNaN bit manually. This allow per target implementation of sNaN to qNaN conversion. Signed-off-by: Aurelien Jarno aurel...@aurel32.net Reviewed-by: Peter

Re: [Qemu-devel] (no subject)

2011-01-04 Thread Peter Maydell
On 4 January 2011 15:15, Aurelien Jarno aurel...@aurel32.net wrote: This patch series start by a cleanup to remove dead HPPA code and fix a few inconsistencies. The following patch implement implement correct NaN propagation rules for MIPS and PowerPC, following commit 3

Re: [Qemu-devel] [PATCH v2 2/8] softfloat: use bits32 instead of uint32

2011-01-04 Thread Aurelien Jarno
On Tue, Jan 04, 2011 at 03:51:37PM +, Peter Maydell wrote: On 4 January 2011 15:15, Aurelien Jarno aurel...@aurel32.net wrote: Use bits32 instead of uint32 when manipulating floating point values directly for consistency reasons. I'm not convinced this patch is particularly worthwhile,

Re: [Qemu-devel] (no subject)

2011-01-04 Thread Aurelien Jarno
On Tue, Jan 04, 2011 at 04:06:13PM +, Peter Maydell wrote: On 4 January 2011 15:15, Aurelien Jarno aurel...@aurel32.net wrote: This patch series start by a cleanup to remove dead HPPA code and fix a few inconsistencies. The following patch implement implement correct NaN propagation

Re: [Qemu-devel] [PATCH 2/2] ARM: wire up the softfloat flush_input_to_zero flag

2011-01-04 Thread Peter Maydell
On 4 January 2011 15:58, Aurelien Jarno aurel...@aurel32.net wrote: On Mon, Jan 03, 2011 at 04:48:54PM +, Peter Maydell wrote: -    i = vfp_exceptbits_to_host((val 8) 0x1f); +    i = vfp_exceptbits_to_host(val); This change looks correct (using the flag instead of the enable bit), but

Re: [Qemu-devel] [PATCH v2 2/8] softfloat: use bits32 instead of uint32

2011-01-04 Thread Peter Maydell
On 4 January 2011 16:11, Aurelien Jarno aurel...@aurel32.net wrote: On Tue, Jan 04, 2011 at 03:51:37PM +, Peter Maydell wrote:  int float32_is_quiet_nan( float32 a1 )  {     float32u u; -    uint64_t a; +    bits32 a;     u.f = a1;     a = u.i;     return ( 0xFF80 ( a1 )

Re: [Qemu-devel] [PATCH] ioeventfd: minor fixups

2011-01-04 Thread Stefan Hajnoczi
On Wed, Dec 29, 2010 at 2:52 PM, Michael S. Tsirkin m...@redhat.com wrote: I'll probably split this patch in two, and merge into the appropriate patches in the ioeventfd series. Compile-tested only so far, would appreciate feedback/test reports. virtio-ioeventfd works as expected. diff

Re: [Qemu-devel] [PATCH] ioeventfd: minor fixups

2011-01-04 Thread Michael S. Tsirkin
On Tue, Jan 04, 2011 at 04:57:43PM +, Stefan Hajnoczi wrote: On Wed, Dec 29, 2010 at 2:52 PM, Michael S. Tsirkin m...@redhat.com wrote: I'll probably split this patch in two, and merge into the appropriate patches in the ioeventfd series. Compile-tested only so far, would appreciate

[Qemu-devel] [Bug 638955] Re: emulated netcards don't work with recent sunos kernel

2011-01-04 Thread Stefan Weil
Hi Daniel, I just tried a newer version of the indiana iso image (http://dlc-origin.openindiana.org/isos/148/oi-dev-148-x86.iso) with latest qemu (not qemu-kvm) on a debian amd64 linux host, and I had no problems with networking (ssh from qemu's emulated indiana host to physical linux host).

Re: [Qemu-devel] [PATCH v2 6/6] SPARCV8 asr17 register support.

2011-01-04 Thread Blue Swirl
On Mon, Jan 3, 2011 at 2:07 PM, Fabien Chouteau chout...@adacore.com wrote: Signed-off-by: Fabien Chouteau chout...@adacore.com ---  target-sparc/cpu.h       |    1 +  target-sparc/helper.c    |    3 ++-  target-sparc/translate.c |   10 ++  3 files changed, 13 insertions(+), 1

  1   2   >