Re: [Qemu-devel] [PATCH 2/6] spice: client migration.

2011-01-11 Thread Gerd Hoffmann
Hi, This way the user doesn't have to say spice/vnc again after already having set it once at command line. Doesn't fly. You can activate *both* vnc and spice, and in that case management has to send two client_migrate_info commands, one for spice and one for vnc. Also this is

[Qemu-devel] [PATCH 0/7] usb-ccid (v14)

2011-01-11 Thread Alon Levy
This patchset adds three new devices, usb-ccid, ccid-card-passthru and ccid-card-emulated, providing a CCID bus, a simple passthru protocol implementing card requiring a client, and a standalone emulated card. It also introduces a new directory libcaccard with CAC card emulation, CAC is a type of

[Qemu-devel] [PATCH 0/7] usb-ccid (v15)

2011-01-11 Thread Alon Levy
This patchset adds three new devices, usb-ccid, ccid-card-passthru and ccid-card-emulated, providing a CCID bus, a simple passthru protocol implementing card requiring a client, and a standalone emulated card. It also introduces a new directory libcaccard with CAC card emulation, CAC is a type of

[Qemu-devel] [PATCH 1/7] usb-ccid: add CCID bus

2011-01-11 Thread Alon Levy
A CCID device is a smart card reader. It is a USB device, defined at [1]. This patch introduces the usb-ccid device that is a ccid bus. Next patches will introduce two card types to use it, a passthru card and an emulated card. [1]

[Qemu-devel] [PATCH 0/7] usb-ccid (v15)

2011-01-11 Thread Alon Levy
This patchset adds three new devices, usb-ccid, ccid-card-passthru and ccid-card-emulated, providing a CCID bus, a simple passthru protocol implementing card requiring a client, and a standalone emulated card. It also introduces a new directory libcaccard with CAC card emulation, CAC is a type of

[Qemu-devel] [PATCH 6/6] ccid: configure: add --enable-smartcard and --disable-smartcard

2011-01-11 Thread Alon Levy
--- configure | 28 ++-- 1 files changed, 18 insertions(+), 10 deletions(-) diff --git a/configure b/configure index 4567057..ebc8250 100755 --- a/configure +++ b/configure @@ -748,6 +748,10 @@ for opt do ;; --enable-rbd) rbd=yes ;; + --disable-smartcard)

[Qemu-devel] [PATCH 5/7] ccid: add docs

2011-01-11 Thread Alon Levy
Add documentation for the usb-ccid device and accompanying two card devices, ccid-card-emulated and ccid-card-passthru. --- docs/ccid.txt | 135 + 1 files changed, 135 insertions(+), 0 deletions(-) create mode 100644 docs/ccid.txt diff

[Qemu-devel] [PATCH 2/7] ccid: add passthru card device

2011-01-11 Thread Alon Levy
The passthru ccid card is a device sitting on the usb-ccid bus and using a chardevice to communicate with a remote device using the VSCard protocol defined in libcacard/vscard_common.h Usage docs available in following patch in docs/ccid.txt Signed-off-by: Alon Levy al...@redhat.com ---

Re: [Qemu-devel] Does qemu support cortex a8 and cortex a9 now?

2011-01-11 Thread David Turner
Yes, they do :-) use -cpu cortex-a8 or -cpu cortex-a9 when launching qemu-system-arm On Tue, Jan 11, 2011 at 4:27 AM, Fan Chongbin-B32609 b32...@freescale.comwrote: Hi, guys Does qemu support cortex a8 and cortex a9 now? If not, is there any plan for them? BR Jerry

[Qemu-devel] [PATCH 4/7] ccid: add ccid-card-emulated device (v2)

2011-01-11 Thread Alon Levy
This devices uses libcacard (internal) to emulate a smartcard conforming to the CAC standard. It attaches to the usb-ccid bus. Usage instructions (example command lines) are in the following patch in docs/ccid.txt. It uses libcacard which uses nss, so it can work with both hw cards and

RE: [Qemu-devel] Does qemu support cortex a8 and cortex a9 now?

2011-01-11 Thread Fan Chongbin-B32609
Does qemu support cortex a9 multicore? If not, is there any plan for them? BR Jerry From: David Turner [mailto:di...@google.com] Sent: 2011年1月11日 16:49 To: Fan Chongbin-B32609 Cc: qemu-devel@nongnu.org Subject: Re: [Qemu-devel] Does qemu support cortex a8 and cortex a9 now? Yes, they do :-)

[Qemu-devel] [PATCH 6/7] ccid: configure: add --enable/disable and nss only disable

2011-01-11 Thread Alon Levy
add --enable-smartcard and --disable-smartcard flags, and let the nss check only disable building the ccid-card-emulated device, since both the usb-ccid and ccid-card-passthru don't depend on it. --- Makefile.objs |3 ++- Makefile.target |2 +- configure | 39

Re: [Qemu-devel] [PATCH 6/6] ccid: configure: add --enable-smartcard and --disable-smartcard

2011-01-11 Thread Alon Levy
On Tue, Jan 11, 2011 at 10:42:38AM +0200, Alon Levy wrote: --- configure | 28 ++-- 1 files changed, 18 insertions(+), 10 deletions(-) [snip] Another oops, not a good morning. Ignore this patch, the real 6/7 will be arriving momentarily. (forgot to clear the

[Qemu-devel] [PATCH 1/7] usb-ccid: add CCID bus

2011-01-11 Thread Alon Levy
A CCID device is a smart card reader. It is a USB device, defined at [1]. This patch introduces the usb-ccid device that is a ccid bus. Next patches will introduce two card types to use it, a passthru card and an emulated card. [1]

Re: [Qemu-devel] [PATCH 6/7] lan9118: fix a buffer overflow

2011-01-11 Thread Markus Armbruster
Peter Maydell peter.mayd...@linaro.org writes: On 10 January 2011 15:50, Blue Swirl blauwir...@gmail.com wrote: On Mon, Jan 10, 2011 at 12:45 PM, Markus Armbruster arm...@redhat.com wrote: Covers all the obvious accesses except for a couple of s-eeprom[addr] in lan9118_eeprom_cmd().  addr

Re: [Qemu-devel] [PATCH 0/7] usb-ccid (v14)

2011-01-11 Thread Alon Levy
On Tue, Jan 11, 2011 at 10:38:06AM +0200, Alon Levy wrote: This patchset adds three new devices, usb-ccid, ccid-card-passthru and ccid-card-emulated, providing a CCID bus, a simple passthru protocol implementing card requiring a client, and a standalone emulated card. [snip] Sorry about the

Re: [Qemu-devel] Re: [PATCH 26/35] kvm: Eliminate KVMState arguments

2011-01-11 Thread Avi Kivity
On 01/10/2011 10:11 PM, Anthony Liguori wrote: On 01/08/2011 02:47 AM, Jan Kiszka wrote: OK, but I don't want to argue about the ioeventfd API. So let's put this case aside. :) I often reply too quickly without explaining myself. Let me use ioeventfd as an example to highlight why KVMState

Re: [Qemu-devel] Re: [PATCH 26/35] kvm: Eliminate KVMState arguments

2011-01-11 Thread Avi Kivity
On 01/10/2011 10:23 PM, Anthony Liguori wrote: I don't see how ioapic, pit, or pic have a system scope. They are not bound to any CPU like the APIC which you may have in mind. And none of the above interact with KVM. They're implemented by kvm. What deeper interaction do you have in mind?

[Qemu-devel] [PATCH v3 4/4] virtio-serial: Don't copy over guest buffer to host

2011-01-11 Thread Amit Shah
When the guest writes something to a host, we copied over the entire buffer first into the host and then processed it. Do away with that, it could result in a malicious guest causing a DoS on the host. Reported-by: Paul Brook p...@codesourcery.com Signed-off-by: Amit Shah amit.s...@redhat.com

[Qemu-devel] [PATCH v3 2/4] virtio-console: Remove unnecessary braces

2011-01-11 Thread Amit Shah
Remove unnecessary braces around a case statement. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/virtio-console.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/hw/virtio-console.c b/hw/virtio-console.c index d7fe68b..d0b9354 100644 --- a/hw/virtio-console.c

[Qemu-devel] [PATCH v3 3/4] virtio-serial-bus: separate out discard logic in a separate function

2011-01-11 Thread Amit Shah
Instead of combining flush logic into the discard case and not discard case, have one function doing discard case. This will help later when adding flow control logic to the do_flush_queued_data() function. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/virtio-serial-bus.c | 47

Re: [Qemu-devel] Re: phys_page_find bug?

2011-01-11 Thread Artyom Tarasenko
On Mon, Jan 10, 2011 at 10:39 PM, Blue Swirl blauwir...@gmail.com wrote: On Mon, Jan 10, 2011 at 3:57 AM, Bob Breuer breu...@mc.net wrote: Blue Swirl wrote: On Mon, Nov 8, 2010 at 6:55 PM, Artyom Tarasenko atar4q...@gmail.com wrote: On Fri, May 7, 2010 at 6:26 PM, Artyom Tarasenko

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-11 Thread Markus Armbruster
Jan Kiszka jan.kis...@web.de writes: Am 10.01.2011 22:06, Jan Kiszka wrote: kvmclock should be created with kvm_state as a parameter and kvm_vm_ioctl() is passed the stored reference. Taking a global reference to kvm_state in machine_init is not a bad thing, obviously the machine

Re: [Qemu-devel] [PATCH] qdev: Fix printout of bit device properties with bit index = 8

2011-01-11 Thread Markus Armbruster
di...@google.com writes: From: David 'Digit' Turner di...@google.com Signed-off-by: David 'Digit' Turner di...@google.com --- hw/qdev-properties.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c index 9219cd7..d5d9591

[Qemu-devel] [PATCH v3 1/4] virtio-console: Factor out common init between console and generic ports

2011-01-11 Thread Amit Shah
The initialisation for generic ports and console ports is similar. Factor out the parts that are the same in a different function that can be called from each of the initfns. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/virtio-console.c | 31 ++- 1 files

[Qemu-devel] [PATCH v3 0/4] virtio-serial: Trivial fixes, don't copy buffers to host

2011-01-11 Thread Amit Shah
Hi, This patch series converts virtio-serial-bus to use the guest buffers instead of copying over guest data to the host, as suggested by Paul. In addition, there are some trivial fixes and code re-arrangement to the virtio-console and virtio-serial code for the upcoming flow control series.

[Qemu-devel] [Bug 686613] Re: USB MSD are not marked as removable

2011-01-11 Thread Stefan Hajnoczi
One side-effect of setting this bit is that Windows Auto-Run will work if RMB=0 but not work if RMB=0 should read but not work if RMB=1. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/686613 Title:

[Qemu-devel] [Bug 686613] Re: USB MSD are not marked as removable

2011-01-11 Thread Stefan Hajnoczi
danpb has mentioned that Linux gets this information from SCSI INQUIRY response. So it's up to the USB Mass Storage Device to decide whether or not it wants to have a removable medium. The SCSI INQUIRY RMB (removable medium bit) tends to be set on modern USB Mass Storage Devices. Of course they

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-11 Thread Gerd Hoffmann
Hi, Actually, there is already a channel to pass pointers to qdev devices: the pointer property hack. I'm not sure we should contribute to its user base or take the chance for a cleanup, but we are not alone with this requirement. Point below remains valid, though. It is considered

[Qemu-devel] [PATCH 7/7] ccid: add qdev description strings

2011-01-11 Thread Alon Levy
--- hw/ccid-card-emulated.c |1 + hw/ccid-card-passthru.c |1 + hw/usb-ccid.c |1 + 3 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/ccid-card-emulated.c b/hw/ccid-card-emulated.c index 5531ce1..5e85e8e 100644 --- a/hw/ccid-card-emulated.c +++

[Qemu-devel] [PATCH 01/19] Make QEMUFile buf expandable, and introduce qemu_realloc_buffer() and qemu_clear_buffer().

2011-01-11 Thread Yoshiaki Tamura
Currently buf size is fixed at 32KB. It would be useful if it could be flexible. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- hw/hw.h |2 ++ savevm.c | 20 +++- 2 files changed, 21 insertions(+), 1 deletions(-) diff --git a/hw/hw.h b/hw/hw.h index

[Qemu-devel] [PATCH 19/19] migration: add a parser to accept FT migration incoming mode.

2011-01-11 Thread Yoshiaki Tamura
The option looks like, -incoming protocol:address:port,ft_mode Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- migration.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/migration.c b/migration.c index 6e22d2a..4aa7fdf 100644 --- a/migration.c

[Qemu-devel] [PATCH 13/19] net: insert event-tap to qemu_send_packet() and qemu_sendv_packet_async().

2011-01-11 Thread Yoshiaki Tamura
event-tap function is called only when it is on. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- net.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/net.c b/net.c index 9ba5be2..1176124 100644 --- a/net.c +++ b/net.c @@ -36,6 +36,7 @@ #include

[Qemu-devel] [PATCH 03/19] Introduce skip_header parameter to qemu_loadvm_state().

2011-01-11 Thread Yoshiaki Tamura
Introduce skip_header parameter to qemu_loadvm_state() so that it can be called iteratively without reading the header. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- migration.c |2 +- savevm.c| 24 +--- sysemu.h|2 +- 3 files changed, 15

[Qemu-devel] [PATCH 14/19] block: insert event-tap to bdrv_aio_writev() and bdrv_aio_flush().

2011-01-11 Thread Yoshiaki Tamura
event-tap function is called only when it is on, and requests sent from device emulators. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- block.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index ff2795b..85bd8b8 100644

[Qemu-devel] [PATCH 12/19] Insert event_tap_mmio() to cpu_physical_memory_rw() in exec.c.

2011-01-11 Thread Yoshiaki Tamura
Record mmio write event to replay it upon failover. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- exec.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/exec.c b/exec.c index 49c28b1..4a171cc 100644 --- a/exec.c +++ b/exec.c @@ -33,6 +33,7 @@

[Qemu-devel] [PATCH 04/19] qemu-char: export socket_set_nodelay().

2011-01-11 Thread Yoshiaki Tamura
Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- qemu-char.c |2 +- qemu_socket.h |1 + 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index edc9ad6..737d347 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2116,7 +2116,7 @@ static

[Qemu-devel] [PATCH 11/19] ioport: insert event_tap_ioport() to ioport_write().

2011-01-11 Thread Yoshiaki Tamura
Record ioport event to replay it upon failover. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- ioport.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/ioport.c b/ioport.c index aa4188a..74aebf5 100644 --- a/ioport.c +++ b/ioport.c @@ -27,6 +27,7 @@

[Qemu-devel] [PATCH 00/19] Kemari for KVM v0.2.3

2011-01-11 Thread Yoshiaki Tamura
Hi, This patch series is a revised version of Kemari for KVM, which applied comments for the previous post. The current code is based on qemu.git 05bf441eb69a813d3893174d54faa6afa8c0d39b. The changes from v0.2.2 - v0.2.3 are: - queue async net requests without copying (MST) -- if not async,

[Qemu-devel] [PATCH 10/19] Call init handler of event-tap at main() in vl.c.

2011-01-11 Thread Yoshiaki Tamura
Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- vl.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/vl.c b/vl.c index 8bbb785..9faeb27 100644 --- a/vl.c +++ b/vl.c @@ -162,6 +162,7 @@ int main(int argc, char **argv) #include qemu-queue.h #include

[Qemu-devel] [PATCH 08/19] savevm: introduce util functions to control ft_trans_file from savevm layer.

2011-01-11 Thread Yoshiaki Tamura
To utilize ft_trans_file function, savevm needs interfaces to be exported. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- hw/hw.h |5 ++ savevm.c | 148 ++ 2 files changed, 153 insertions(+), 0 deletions(-) diff

[Qemu-devel] [PATCH 17/19] migration-tcp: modify tcp_accept_incoming_migration() to handle ft_mode, and add a hack not to close fd when ft_mode is enabled.

2011-01-11 Thread Yoshiaki Tamura
When ft_mode is set in the header, tcp_accept_incoming_migration() sets ft_trans_incoming() as a callback, and call qemu_file_get_notify() to receive FT transaction iteratively. We also need a hack no to close fd before moving to ft_transaction mode, so that we can reuse the fd for it.

[Qemu-devel] [PATCH 3/3] virtio-console: Enable port throttling when chardev is slow to consume data

2011-01-11 Thread Amit Shah
When a chardev indicates it can't accept more data, we tell the virtio-serial code to stop sending us any more data till we tell otherwise. This helps in guests continuing to run normally while the vq keeps getting full and eventually the guest stops queueing more data. As soon as the chardev

[Qemu-devel] [PATCH 15/19] savevm: introduce qemu_savevm_trans_{begin, commit}.

2011-01-11 Thread Yoshiaki Tamura
Introduce qemu_savevm_state_{begin,commit} to send the memory and device info together, while avoiding cancelling memory state tracking. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- savevm.c | 88 ++ sysemu.h |

[Qemu-devel] [PATCH 05/19] vl.c: add deleted flag for deleting the handler.

2011-01-11 Thread Yoshiaki Tamura
Make deleting handlers robust against deletion of any elements in a handler by using a deleted flag like in file descriptors. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- vl.c | 13 + 1 files changed, 9 insertions(+), 4 deletions(-) diff --git a/vl.c b/vl.c

[Qemu-devel] [PATCH 07/19] Introduce fault tolerant VM transaction QEMUFile and ft_mode.

2011-01-11 Thread Yoshiaki Tamura
This code implements VM transaction protocol. Like buffered_file, it sits between savevm and migration layer. With this architecture, VM transaction protocol is implemented mostly independent from other existing code. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp Signed-off-by:

[Qemu-devel] [PATCH 16/19] migration: introduce migrate_ft_trans_{put, get}_ready(), and modify migrate_fd_put_ready() when ft_mode is on.

2011-01-11 Thread Yoshiaki Tamura
Introduce migrate_ft_trans_put_ready() which kicks the FT transaction cycle. When ft_mode is on, migrate_fd_put_ready() would open ft_trans_file and turn on event_tap. To end or cancel FT transaction, ft_mode and event_tap is turned off. migrate_ft_trans_get_ready() is called to receive ack

[Qemu-devel] [PATCH 18/19] Introduce -k option to enable FT migration mode (Kemari).

2011-01-11 Thread Yoshiaki Tamura
When -k option is set to migrate command, it will turn on ft_mode to start FT migration mode (Kemari). Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- hmp-commands.hx |7 --- migration.c |3 +++ qmp-commands.hx |7 --- 3 files changed, 11 insertions(+), 6

[Qemu-devel] [PATCH 02/19] Introduce read() to FdMigrationState.

2011-01-11 Thread Yoshiaki Tamura
Currently FdMigrationState doesn't support read(), and this patch introduces it to get response from the other side. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- migration-tcp.c | 15 +++ migration.c | 12 migration.h |3 +++ 3 files

[Qemu-devel] [PATCH 06/19] virtio: decrement last_avail_idx with inuse before saving.

2011-01-11 Thread Yoshiaki Tamura
For regular migration inuse == 0 always as requests are flushed before save. However, event-tap log when enabled introduces an extra queue for requests which is not being flushed, thus the last inuse requests are left in the event-tap queue. Move the last_avail_idx value sent to the remote back

[Qemu-devel] [PATCH 09/19] Introduce event-tap.

2011-01-11 Thread Yoshiaki Tamura
event-tap controls when to start FT transaction, and provides proxy functions to called from net/block devices. While FT transaction, it queues up net/block requests, and flush them when the transaction gets completed. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp Signed-off-by:

[Qemu-devel] [PATCH 2/5] char: Introduce char_set/remove_fd_handlers()

2011-01-11 Thread Amit Shah
Introduce a char-specific wrapper to qemu_set_fd_handler functions. This wrapper is useful to add / remove a write handler easily. Write handlers are only used when the backend is blocked and cannot receive any more input. Signed-off-by: Amit Shah amit.s...@redhat.com --- qemu-char.c | 64

[Qemu-devel] [PATCH 3/5] char: Add framework for a 'write unblocked' callback

2011-01-11 Thread Amit Shah
The char layer can let users know that the driver will block on further input. For users interested in not blocking, they can assign a function pointer that will be called back when the driver becomes writable. This patch just adds the function pointers to the CharDriverState structure, future

[Qemu-devel] [PATCH 1/5] char: Add a QemuChrHandlers struct to initialise chardev handlers

2011-01-11 Thread Amit Shah
Instead of passing each handler in the qemu_add_handlers() function, create a struct of handlers that can be passed to the function instead. Signed-off-by: Amit Shah amit.s...@redhat.com --- gdbstub.c|9 +++-- hw/debugcon.c|2 +- hw/escc.c|9

[Qemu-devel] [PATCH] ioeventfd: error handling cleanup

2011-01-11 Thread Michael S. Tsirkin
- Don't return status from start/stop functions where it's ignored - report errors to make debugging easier - assert on unexpected failures - don't disable notifiers on error so that we'll retry when guest driver restarts Signed-off-by: Michael S. Tsirkin m...@redhat.com -- Stefan, could you

[Qemu-devel] [PATCH 0/3] virtio-serial: Flow control

2011-01-11 Thread Amit Shah
Hello, This patchset adds support for virtio-serial flow control. This is a rework of the method used earlier. The new method doesn't copy over the entire guest buffers to host, instead it uses the guest buffer and adds some state to the port struct. save/restore support for the new state is

[Qemu-devel] [PATCH v9 0/5] char: Add support for nonblocking writes

2011-01-11 Thread Amit Shah
Hello, This version of the series adds proper handling of nonblocking when the backend managed to flush out some data but not all (ret 0 ret len). Just the unix/tcp backends have been updated to be nonblocking, but it's easy to add support to the other backends, as the last patch in the

Re: [Qemu-devel] [PATCH] Avoid divide by zero when there is no block device to migrate

2011-01-11 Thread Kevin Wolf
Am 25.12.2010 21:52, schrieb Pierre Riteau: When block migration is requested and no read-write block device is present, a divide by zero exception is triggered because total_sector_sum equals zero. Signed-off-by: Pierre Riteau pierre.rit...@irisa.fr Maybe in this case we should generate an

[Qemu-devel] [PATCH 1/3] virtio-serial: Let virtio-serial-bus know if all data was consumed

2011-01-11 Thread Amit Shah
The have_data() API to hand off guest data to apps using virtio-serial so far assumed all the data was consumed. Relax this assumption. Future commits will allow for incomplete writes. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/virtio-console.c |4 ++-- hw/virtio-serial.h |7

[Qemu-devel] [PATCH 4/5] char: Update send_all() to handle nonblocking chardev write requests

2011-01-11 Thread Amit Shah
The send_all function is modified to return to the caller in case the driver cannot handle any more data. It returns -EAGAIN or WSAEWOULDBLOCK on non-Windows and Windows platforms respectively. This is only done when the caller sets a callback function handler indicating it's not interested in

[Qemu-devel] [PATCH 3/6] spice: MAINTAINERS update

2011-01-11 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- MAINTAINERS |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 59effc7..25103dd 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -383,6 +383,14 @@ S: Odd Fixes F: gdbstub* F: gdb-xml/

[Qemu-devel] [PATCH 1/6] add migration state change notifiers

2011-01-11 Thread Gerd Hoffmann
This patch adds functions to register and unregister notifiers for migration state changes and a function to query the migration state. The notifier is called on every state change. Once after establishing a new migration object (which is in active state then) and once when the state changes from

[Qemu-devel] [PATCH 5/6] spice/qxl: zap spice 0.4 migration compatibility bits

2011-01-11 Thread Gerd Hoffmann
Live migration from and to spice 0.4 qxl devices isn't going to work. Rip out the bits which attempt to support that. Zap the subsection logic which is obsolete now. Bumb the version to make a clean cut. This should obviously go in before 0.14 is released. Signed-off-by: Gerd Hoffmann

[Qemu-devel] [PATCH 2/3] virtio-serial: Add support for flow control

2011-01-11 Thread Amit Shah
This commit lets apps signal an incomplete write. When that happens, stop stop sending out any more data to the app and wait for it to unthrottle the port. This involves storing some extra state in the port struct. This state will have to be migrated along in a new subsection. That's an item

[Qemu-devel] [PULL v2 0/6] spice patch queue

2011-01-11 Thread Gerd Hoffmann
Hi, Here is a bunch of spice patches accumuled this year, they all have been on the list for review. [ v2: rewrite the spice client migration in a way that allows vnc to easily join the party later on ] please pull, Gerd Alon Levy (1): spice: add chardev (v4) Gerd Hoffmann (4):

[Qemu-devel] [PATCH 2/6] spice: client migration.

2011-01-11 Thread Gerd Hoffmann
Handle spice client migration, i.e. inform a spice client connected about the new host and connection parameters, so it can move over the connection automatically. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hmp-commands.hx | 20 qmp-commands.hx | 35

[Qemu-devel] [PATCH 4/6] vnc/spice: fix never and now expire_time

2011-01-11 Thread Gerd Hoffmann
From: Marc-André Lureau marcandre.lur...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- monitor.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/monitor.c b/monitor.c index 9d6d2d4..6f5ee14 100644 --- a/monitor.c +++ b/monitor.c @@ -1136,9 +1136,9 @@

[Qemu-devel] Re: [PATCH 2/7] tcg-ppc: Implement deposit operation.

2011-01-11 Thread malc
On Mon, 10 Jan 2011, Richard Henderson wrote: Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/ppc/tcg-target.c | 17 - tcg/ppc/tcg-target.h |1 + 2 files changed, 17 insertions(+), 1 deletions(-) diff --git a/tcg/ppc/tcg-target.c b/tcg/ppc/tcg-target.c

[Qemu-devel] Tracking unfreed tcg temps

2011-01-11 Thread Peter Maydell
The ARM target-arm/translate.c file has some code in it which tries to track the number of TCG temporaries allocated during translation of an ARM instruction and complain if they are not freed by the end of that instruction. So new_tmp() allocates a temp with tcg_temp_new_i32() and increments the

Re: [Qemu-devel] [PATCH] do_snapshot_blkdev() error on missing snapshot_file argument

2011-01-11 Thread Kevin Wolf
Am 06.01.2011 17:02, schrieb jes.soren...@redhat.com: From: Jes Sorensen jes.soren...@redhat.com Current code does not support snapshot internally to the running image. Error in case no snapshot_file is specified. Signed-off-by: Jes Sorensen jes.soren...@redhat.com Thanks, applied to the

[Qemu-devel] [PATCH 6/6] spice: add chardev (v4)

2011-01-11 Thread Gerd Hoffmann
From: Alon Levy al...@redhat.com Adding a chardev backend for spice, where spice determines what to do with it based on the name attribute given during chardev creation. For usage by spice vdagent in conjunction with a properly named virtio-serial device, and future smartcard channel usage.

Re: [Qemu-devel] Re: KVM call agenda for Jan 11

2011-01-11 Thread Kevin Wolf
Am 10.01.2011 14:32, schrieb Juan Quintela: Juan Quintela quint...@redhat.com wrote: Juan Quintela quint...@redhat.com wrote: Now sent it to the right kvm list. Sorry for the second sent. Please send any agenda items you are interested in covering. - KVM Forum 2011 (Jes). thanks, Juan.

[Qemu-devel] [PATCH 2/6] spice/vnc: client migration.

2011-01-11 Thread Gerd Hoffmann
Handle spice client migration, i.e. inform a spice client connected about the new host and connection parameters, so it can move over the connection automatically. The monitor command has a not-yet used protocol argument simliar to set_password and expire_password commands. This allows to add a

[Qemu-devel] [PATCH 5/5] char: Equip the unix/tcp backend to handle nonblocking writes

2011-01-11 Thread Amit Shah
Now that the infrastructure is in place to return -EAGAIN to callers, individual char drivers can set their update_fd_handlers() function to set or remove an fd's write handler. This handler checks if the driver became writable. A generic callback routine is used for unblocking writes and

[Qemu-devel] RFC: QMP event notification for disk media eject

2011-01-11 Thread Luiz Capitulino
Hi there, I need feedback on a new QMP event. Problem === There's no way for a management tool to detect that a guest OS has ejected the media in a CDROM or Floppy disk drive (I'm discarding polling, because it's undesirable at best). The end result is that the management tool can get

[Qemu-devel] Re: RFC: QMP event notification for disk media eject

2011-01-11 Thread Kevin Wolf
Am 11.01.2011 14:11, schrieb Luiz Capitulino: Hi there, I need feedback on a new QMP event. Problem === There's no way for a management tool to detect that a guest OS has ejected the media in a CDROM or Floppy disk drive (I'm discarding polling, because it's undesirable at best).

Re: [Qemu-devel] [PATCH] Make strtosz() return int64_t instead of ssize_t

2011-01-11 Thread Kevin Wolf
Am 05.01.2011 11:41, schrieb jes.soren...@redhat.com: From: Jes Sorensen jes.soren...@redhat.com strtosz() needs to return a 64 bit type even on 32 bit architectures. Otherwise qemu-img will fail to create disk images = 2GB Signed-off-by: Jes Sorensen jes.soren...@redhat.com Thanks,

[Qemu-devel] Re: [PATCH 2/6] spice: client migration.

2011-01-11 Thread Gerd Hoffmann
On 01/11/11 13:08, Gerd Hoffmann wrote: Handle spice client migration, i.e. inform a spice client connected about the new host and connection parameters, so it can move over the connection automatically. Oops, scratch that, old patch file still lying around and the new one got another name

[Qemu-devel] Re: [PATCH 5/5] char: Equip the unix/tcp backend to handle nonblocking writes

2011-01-11 Thread Paolo Bonzini
On 01/11/2011 12:10 PM, Amit Shah wrote: +char_set_fd_handlers(s-fd, tcp_chr_read_poll, tcp_chr_read, + char_write_unblocked, chr, poll_out); Would the 4th parameter always be char_write_unblocked? If so, what about making it hidden within char_set_fd_handlers

[Qemu-devel] Re: KVM call agenda for Jan 11

2011-01-11 Thread Juan Quintela
Kevin Wolf kw...@redhat.com wrote: Am 10.01.2011 14:32, schrieb Juan Quintela: Juan Quintela quint...@redhat.com wrote: Juan Quintela quint...@redhat.com wrote: Now sent it to the right kvm list. Sorry for the second sent. Please send any agenda items you are interested in covering. -

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-11 Thread Anthony Liguori
On 01/11/2011 03:31 AM, Markus Armbruster wrote: Jan Kiszkajan.kis...@web.de writes: Am 10.01.2011 22:06, Jan Kiszka wrote: kvmclock should be created with kvm_state as a parameter and kvm_vm_ioctl() is passed the stored reference. Taking a global reference to kvm_state in

Re: [Qemu-devel] Re: [PATCH 26/35] kvm: Eliminate KVMState arguments

2011-01-11 Thread Anthony Liguori
On 01/11/2011 03:01 AM, Avi Kivity wrote: On 01/10/2011 10:23 PM, Anthony Liguori wrote: I don't see how ioapic, pit, or pic have a system scope. They are not bound to any CPU like the APIC which you may have in mind. And none of the above interact with KVM. They're implemented by kvm.

Re: [Qemu-devel] Re: [PATCH 26/35] kvm: Eliminate KVMState arguments

2011-01-11 Thread Alexander Graf
On 11.01.2011, at 15:00, Anthony Liguori wrote: On 01/11/2011 03:01 AM, Avi Kivity wrote: On 01/10/2011 10:23 PM, Anthony Liguori wrote: I don't see how ioapic, pit, or pic have a system scope. They are not bound to any CPU like the APIC which you may have in mind. And none of the above

[Qemu-devel] Re: RFC: QMP event notification for disk media eject

2011-01-11 Thread Anthony Liguori
On 01/11/2011 07:11 AM, Luiz Capitulino wrote: Hi there, I need feedback on a new QMP event. Problem === There's no way for a management tool to detect that a guest OS has ejected the media in a CDROM or Floppy disk drive (I'm discarding polling, because it's undesirable at best). The

Re: [Qemu-devel] Re: [PATCH 26/35] kvm: Eliminate KVMState arguments

2011-01-11 Thread Anthony Liguori
On 01/11/2011 08:06 AM, Alexander Graf wrote: On 11.01.2011, at 15:00, Anthony Liguori wrote: On 01/11/2011 03:01 AM, Avi Kivity wrote: On 01/10/2011 10:23 PM, Anthony Liguori wrote: I don't see how ioapic, pit, or pic have a system scope. They are not bound

Re: [Qemu-devel] RFC: QMP event notification for disk media eject

2011-01-11 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: Hi there, I need feedback on a new QMP event. Problem === There's no way for a management tool to detect that a guest OS has ejected the media in a CDROM or Floppy disk drive (I'm discarding polling, because it's undesirable at best).

[Qemu-devel] Re: [PATCH 1/5] char: Add a QemuChrHandlers struct to initialise chardev handlers

2011-01-11 Thread Gerd Hoffmann
On 01/11/11 12:10, Amit Shah wrote: Instead of passing each handler in the qemu_add_handlers() function, create a struct of handlers that can be passed to the function instead. Nice cleanup. Acked-by: Gerd Hoffmann kra...@redhat.com cheers, Gerd

Re: [Qemu-devel] Re: [PATCH 26/35] kvm: Eliminate KVMState arguments

2011-01-11 Thread Avi Kivity
On 01/11/2011 04:00 PM, Anthony Liguori wrote: On 01/11/2011 03:01 AM, Avi Kivity wrote: On 01/10/2011 10:23 PM, Anthony Liguori wrote: I don't see how ioapic, pit, or pic have a system scope. They are not bound to any CPU like the APIC which you may have in mind. And none of the above

Re: [Qemu-devel] Re: [PATCH 26/35] kvm: Eliminate KVMState arguments

2011-01-11 Thread Avi Kivity
On 01/11/2011 04:09 PM, Anthony Liguori wrote: Disadvantages: 1) you lose migration / savevm between KVM and non-KVM VMs This doesn't work today and it's never worked. KVM exposes things that TCG cannot emulate (like pvclock). If you run kvm without pvclock, or implement pvclock in qemu,

Re: [Qemu-devel] Re: [PATCH 26/35] kvm: Eliminate KVMState arguments

2011-01-11 Thread Alexander Graf
On 11.01.2011, at 15:09, Anthony Liguori wrote: On 01/11/2011 08:06 AM, Alexander Graf wrote: On 11.01.2011, at 15:00, Anthony Liguori wrote: On 01/11/2011 03:01 AM, Avi Kivity wrote: On 01/10/2011 10:23 PM, Anthony Liguori wrote: I don't see how ioapic, pit, or pic have

Re: [Qemu-devel] Re: RFC: QMP event notification for disk media eject

2011-01-11 Thread Markus Armbruster
Anthony Liguori anth...@codemonkey.ws writes: On 01/11/2011 07:11 AM, Luiz Capitulino wrote: Hi there, I need feedback on a new QMP event. Problem === There's no way for a management tool to detect that a guest OS has ejected the media in a CDROM or Floppy disk drive (I'm

Re: [Qemu-devel] Re: [PATCH 26/35] kvm: Eliminate KVMState arguments

2011-01-11 Thread Anthony Liguori
On 01/11/2011 08:18 AM, Avi Kivity wrote: On 01/11/2011 04:00 PM, Anthony Liguori wrote: On 01/11/2011 03:01 AM, Avi Kivity wrote: On 01/10/2011 10:23 PM, Anthony Liguori wrote: I don't see how ioapic, pit, or pic have a system scope. They are not bound to any CPU like the APIC which you may

Re: [Qemu-devel] Re: [PATCH 26/35] kvm: Eliminate KVMState arguments

2011-01-11 Thread Anthony Liguori
On 01/11/2011 08:22 AM, Avi Kivity wrote: On 01/11/2011 04:09 PM, Anthony Liguori wrote: Disadvantages: 1) you lose migration / savevm between KVM and non-KVM VMs This doesn't work today and it's never worked. KVM exposes things that TCG cannot emulate (like pvclock). If you run kvm

[Qemu-devel] Re: [PATCH 2/5] char: Introduce char_set/remove_fd_handlers()

2011-01-11 Thread Gerd Hoffmann
On 01/11/11 12:10, Amit Shah wrote: Introduce a char-specific wrapper to qemu_set_fd_handler functions. This wrapper is useful to add / remove a write handler easily. Write handlers are only used when the backend is blocked and cannot receive any more input. I'd suggest to add flags to

[Qemu-devel] Re: [PATCH 3/5] char: Add framework for a 'write unblocked' callback

2011-01-11 Thread Gerd Hoffmann
Hi, @@ -60,6 +60,9 @@ struct CharDriverState { IOEventHandler *chr_event; IOCanReadHandler *chr_can_read; IOReadHandler *chr_read; +IOHandler *chr_write_unblocked; +void (*update_fd_handlers)(struct CharDriverState *chr, + bool

Re: [Qemu-devel] Re: KVM call agenda for Jan 11

2011-01-11 Thread Anthony Liguori
On 01/11/2011 07:41 AM, Juan Quintela wrote: Kevin Wolfkw...@redhat.com wrote: Am 10.01.2011 14:32, schrieb Juan Quintela: Juan Quintelaquint...@redhat.com wrote: Juan Quintelaquint...@redhat.com wrote: Now sent it to the right kvm list. Sorry for the second sent.

[Qemu-devel] [PATCH] audio: Fix support for multiple soft output voices.

2011-01-11 Thread digit
From: David 'Digit' Turner di...@google.com This patch fixes a minor bug that prevent audio emulation from working properly when several soft output voices are opened. The symptom was that as long as one active soft voice was empty, it prevented any output from any other voice. More precisely,

Re: [Qemu-devel] Re: [PATCH 26/35] kvm: Eliminate KVMState arguments

2011-01-11 Thread Avi Kivity
On 01/11/2011 04:28 PM, Anthony Liguori wrote: On 01/11/2011 08:18 AM, Avi Kivity wrote: On 01/11/2011 04:00 PM, Anthony Liguori wrote: On 01/11/2011 03:01 AM, Avi Kivity wrote: On 01/10/2011 10:23 PM, Anthony Liguori wrote: I don't see how ioapic, pit, or pic have a system scope. They are

Re: [Qemu-devel] Re: [PATCH 26/35] kvm: Eliminate KVMState arguments

2011-01-11 Thread Avi Kivity
On 01/11/2011 04:36 PM, Anthony Liguori wrote: They need to use the same device id then. And if they share code, that indicates that they need to be the same device even more. No, it really doesn't :-) Cirrus VGA and std VGA share a lot of code. But that doesn't mean that we treat them as

[Qemu-devel] Re: [PATCH] ioeventfd: error handling cleanup

2011-01-11 Thread Stefan Hajnoczi
On Tue, Jan 11, 2011 at 01:49:18PM +0200, Michael S. Tsirkin wrote: - Don't return status from start/stop functions where it's ignored - report errors to make debugging easier - assert on unexpected failures - don't disable notifiers on error so that we'll retry when guest driver restarts

  1   2   >