Re: [Qemu-devel] Slow PXE boot in qemu.git (fast in qemu-kvm.git)

2011-04-12 Thread Luiz Capitulino
On Fri, 08 Apr 2011 19:50:57 -0500 Anthony Liguori anth...@codemonkey.ws wrote: On 04/08/2011 06:25 PM, Luiz Capitulino wrote: Hi there, Summary: - PXE boot in qemu.git (HEAD f124a41) is quite slow, more than 5 minutes. Got the problem with e1000, virtio and rtl8139.

Re: [Qemu-devel] [PATCH v2 0/3] io-thread optimizations

2011-04-12 Thread Paolo Bonzini
On 04/11/2011 10:27 PM, Jan Kiszka wrote: These patches were posted before. They bring down the overhead of the io-thread mode for TCG here, specifically when emulating SMP. The major change in this version, besides rebasing, is the exclusion of KVM from the main loop polling optimization.

Re: [Qemu-devel] Slow PXE boot in qemu.git (fast in qemu-kvm.git)

2011-04-12 Thread Avi Kivity
On 04/12/2011 03:39 AM, Anthony Liguori wrote: would say let it rest in peace. But maybe it points to a generic issues that is just magnified by non-threaded mode. If it's most probably an architectural deficit of non-io-thread mode, I If gpxe is spinning waiting for I/O to complete, that's

Re: [Qemu-devel] [PATCH 2/2 V7] qemu, qmp: add inject-nmi qmp command

2011-04-12 Thread Avi Kivity
On 04/11/2011 08:15 PM, Blue Swirl wrote: On Mon, Apr 11, 2011 at 10:01 AM, Markus Armbrusterarm...@redhat.com wrote: Avi Kivitya...@redhat.com writes: On 04/08/2011 12:41 AM, Anthony Liguori wrote: And it's a good thing to have, but exposing this as the only API to do something as

Re: [Qemu-devel] To O_EXCL or not to O_EXCL open host_cdrom

2011-04-12 Thread Daniel P. Berrange
On Fri, Apr 08, 2011 at 12:33:27PM +0100, Stefan Hajnoczi wrote: Amit and I were discussing the pros and cons of using O_EXCL to open host CD-ROM devices on IRC but this discussion could benefit from more input. Linux block devices (like /dev/sr0 CD-ROMs) can be opened with O_EXCL and only

[Qemu-devel] [PATCH] unicore32: add necessry headers in linux-user/unicore32 for unicore32 support

2011-04-12 Thread Guan Xuetao
Rebase on the master branch of qemu. Signed-off-by: Guan Xuetao g...@mprc.pku.edu.cn --- configure| 11 +++- cpu-exec.c | 12 - default-configs/unicore32-linux-user.mak |1 + elf.h|2

Re: [Qemu-devel] To O_EXCL or not to O_EXCL open host_cdrom

2011-04-12 Thread Kevin Wolf
Am 12.04.2011 09:52, schrieb Daniel P. Berrange: - If the -drive specification has readonly=on (thus O_RDONLY to open(2) call) , I expect QEMU (or the kernel) to forbid the eject command on the host CDROM. This should prevent two guests interfering seriously with each other. So I

Re: [Qemu-devel] Slow PXE boot in qemu.git (fast in qemu-kvm.git)

2011-04-12 Thread Paolo Bonzini
On 04/11/2011 10:18 PM, Jan Kiszka wrote: At least Windows should no longer we a functional blocker thanks to Paolo's work. What's left now is icount. I also have had patches ready for a while, I'll send them out. Paolo

Re: [Qemu-devel] To O_EXCL or not to O_EXCL open host_cdrom

2011-04-12 Thread Daniel P. Berrange
On Tue, Apr 12, 2011 at 10:10:44AM +0200, Kevin Wolf wrote: Am 12.04.2011 09:52, schrieb Daniel P. Berrange: - If the -drive specification has readonly=on (thus O_RDONLY to open(2) call) , I expect QEMU (or the kernel) to forbid the eject command on the host CDROM. This should

[Qemu-devel] [Bug 754591] Re: NIC doesn't work when it had been used before

2011-04-12 Thread Yongjie Ren
hot-plug NIC doesn't have this issue. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/754591 Title: NIC doesn't work when it had been used before Status in QEMU: New Bug description:

[Qemu-devel] [Bug 730441] Re: NIC doesn't work with pci=nomsi in grub.conf

2011-04-12 Thread Yongjie Ren
** Changed in: qemu Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/730441 Title: NIC doesn't work with pci=nomsi in grub.conf Status in QEMU: Fix

Re: [Qemu-devel] [PATCH] unicore32: add necessry headers in linux-user/unicore32 for unicore32 support

2011-04-12 Thread Guan Xuetao
Sorry for typo in subject. I will resend the whole patch set at once. Guan -Original Message- From: Guan Xuetao [mailto:g...@mprc.pku.edu.cn] Sent: Tuesday, April 12, 2011 4:05 PM To: 'Blue Swirl' Cc: 'qemu-devel@nongnu.org' Subject: [PATCH] unicore32: add necessry headers in

[Qemu-devel] [PATCHv3 0/3] unicore32: add unicore32-linux-user support for qemu 0.14

2011-04-12 Thread Guan Xuetao
The patch set adds new unicore32-linux-user support for qemu-stable-0.14 Patch 1 adds target-unicore32 directory Patch 2 adds linux-user/unicore32 directory Patch 3 adds necessary modifications for other files V2-V3: rebase on master branch of qemu V1 - V2: changed by advice from

[Qemu-devel] [PATCHv3 2/3] unicore32: add necessry headers in linux-user/unicore32 for unicore32 support

2011-04-12 Thread Guan Xuetao
Signed-off-by: Guan Xuetao g...@mprc.pku.edu.cn --- linux-user/unicore32/syscall.h | 55 + linux-user/unicore32/syscall_nr.h| 371 ++ linux-user/unicore32/target_signal.h | 26 +++ linux-user/unicore32/termbits.h |2 + 4 files changed,

[Qemu-devel] [PATCHv3 3/3] unicore32: necessary modifications for other files to support unicore32

2011-04-12 Thread Guan Xuetao
Signed-off-by: Guan Xuetao g...@mprc.pku.edu.cn --- configure| 11 +++- cpu-exec.c | 12 - default-configs/unicore32-linux-user.mak |1 + elf.h|2 + fpu/softfloat-specialize.h

[Qemu-devel] [PATCH v3 0/4] Fix -icount with iothread

2011-04-12 Thread Paolo Bonzini
This series finally fixes -icount with iothread and avoids deadlocks due to the vm_clock not making progress when the VM is stopped. The crux of the fix is in patch 1, while patch 2 implements the clock warping that fixes deadlocks in v2. Clock warping uses the nanosecond resolution rt_clock

[Qemu-devel] [PATCH v3 4/4] qemu_next_deadline should not consider host-time timers

2011-04-12 Thread Paolo Bonzini
It is purely for icount-based virtual timers. And now that we got the code right, rename the function to clarify the intended scope. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- cpus.c |4 ++-- qemu-timer.c | 13 - qemu-timer.h |2 +- 3 files changed, 7

[Qemu-devel] [PATCH v3 2/4] enable vm_clock to warp in the iothread+icount case

2011-04-12 Thread Paolo Bonzini
The previous patch however is not enough, because if the virtual CPU goes to sleep waiting for a future timer interrupt to wake it up, qemu deadlocks. The timer interrupt never comes because time is driven by icount, but the vCPU doesn't run any insns. You could say that VCPUs should never go to

[Qemu-devel] [PATCH v3 1/4] really fix -icount in the iothread case

2011-04-12 Thread Paolo Bonzini
The correct fix for -icount is to consider the biggest difference between iothread and non-iothread modes. In the traditional model, CPUs run _before_ the iothread calls select (or WaitForMultipleObjects for Win32). In the iothread model, CPUs run while the iothread isn't holding the mutex, i.e.

[Qemu-devel] [PATCH v3 3/4] Revert wrong fixes for -icount in the iothread case

2011-04-12 Thread Paolo Bonzini
This reverts commits 225d02cd and c9f7383c. While some parts of the latter could be saved, I preferred a smooth, complete revert. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qemu-timer.c | 66 +++-- 1 files changed, 36

Re: [Qemu-devel] [PATCH] fix acpi regression

2011-04-12 Thread Isaku Yamahata
On Tue, Apr 12, 2011 at 01:13:15PM +0800, Wen Congyang wrote: This bug is introduced by commit 23910d3f. Oh, Thanks. Good catch. I agree with the first hunk. But what is the second hunk for? The GPE STS register is W1C. (NULL check and 0xff masking is okay. it's a bit redundant, though) From

Re: [Qemu-devel] [PATCH v2 1/2] rbd: use the higher level librbd instead of just librados

2011-04-12 Thread Stefan Hajnoczi
On Tue, Apr 12, 2011 at 1:18 AM, Josh Durgin josh.dur...@dreamhost.com wrote: On 04/08/2011 01:43 AM, Stefan Hajnoczi wrote: On Mon, Mar 28, 2011 at 04:15:57PM -0700, Josh Durgin wrote: librbd stacks on top of librados to provide access to rbd images. Using librbd simplifies the qemu code,

Re: [Qemu-devel] [PATCH] fix acpi regression

2011-04-12 Thread Wen Congyang
At 04/12/2011 04:48 PM, Isaku Yamahata Write: On Tue, Apr 12, 2011 at 01:13:15PM +0800, Wen Congyang wrote: This bug is introduced by commit 23910d3f. Oh, Thanks. Good catch. I agree with the first hunk. But what is the second hunk for? The GPE STS register is W1C. (NULL check and 0xff

Re: [Qemu-devel] To O_EXCL or not to O_EXCL open host_cdrom

2011-04-12 Thread Stefan Hajnoczi
On Tue, Apr 12, 2011 at 9:19 AM, Daniel P. Berrange berra...@redhat.com wrote: On Tue, Apr 12, 2011 at 10:10:44AM +0200, Kevin Wolf wrote: Am 12.04.2011 09:52, schrieb Daniel P. Berrange:  - If the -drive specification has  readonly=on (thus O_RDONLY to    open(2) call) , I expect QEMU (or

Re: [Qemu-devel] [PATCH] fix acpi regression

2011-04-12 Thread Isaku Yamahata
On Tue, Apr 12, 2011 at 05:08:18PM +0800, Wen Congyang wrote: At 04/12/2011 04:48 PM, Isaku Yamahata Write: On Tue, Apr 12, 2011 at 01:13:15PM +0800, Wen Congyang wrote: This bug is introduced by commit 23910d3f. Oh, Thanks. Good catch. I agree with the first hunk. But what is the

Re: [Qemu-devel] [PATCH v3 0/4] Fix -icount with iothread

2011-04-12 Thread Jan Kiszka
On 2011-04-12 10:44, Paolo Bonzini wrote: This series finally fixes -icount with iothread and avoids deadlocks due to the vm_clock not making progress when the VM is stopped. The crux of the fix is in patch 1, while patch 2 implements the clock warping that fixes deadlocks in v2. Clock

Re: [Qemu-devel] [PATCH] fix acpi regression

2011-04-12 Thread Wen Congyang
At 04/12/2011 05:20 PM, Isaku Yamahata Write: On Tue, Apr 12, 2011 at 05:08:18PM +0800, Wen Congyang wrote: At 04/12/2011 04:48 PM, Isaku Yamahata Write: On Tue, Apr 12, 2011 at 01:13:15PM +0800, Wen Congyang wrote: This bug is introduced by commit 23910d3f. Oh, Thanks. Good catch. I agree

[Qemu-devel] [PATCH v2 0/6] atapi: Implement 'media' subcommand for GESN

2011-04-12 Thread Amit Shah
The GET_EVENT_STATUS_NOTIFICATION ATAPI command is listed as a mandatory command in the spec but we don't really implement it any of its sub-commands. The commit message for the last commit explains why implementing just the media subcommand is helpful and how it goes a long way in getting guests

[Qemu-devel] [PATCH v2 1/6] atapi: Allow GESN after media change

2011-04-12 Thread Amit Shah
After a media change, the only commands allowed from the guest were REQUEST_SENSE and INQUIRY. The guest may also issue GET_EVENT_STATUS_NOTIFICATION commands to get media changed notification. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/ide/core.c | 19 +-- 1 files

[Qemu-devel] [PATCH v2 2/6] atapi: Move GET_EVENT_STATUS_NOTIFICATION command handling to its own function

2011-04-12 Thread Amit Shah
This makes the code more readable. Also, there's a block like: if () { ... } else { ... } Split that into if () { ... return; } ... Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/ide/core.c | 37 - 1 files changed, 24 insertions(+), 13

[Qemu-devel] [PATCH v2 3/6] atapi: GESN: Spin off No Event Available handling into own function

2011-04-12 Thread Amit Shah
Handle GET_EVENT_STATUS_NOTIFICATION's No Event Available status in its own function. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/ide/core.c | 21 +++-- 1 files changed, 15 insertions(+), 6 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index d71bc41..c5913d8

[Qemu-devel] [PATCH v2 4/6] atapi: GESN: Use structs for commonly-used field types

2011-04-12 Thread Amit Shah
Instead of using magic numbers, use structs that are more descriptive of the fields being used. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/ide/core.c | 15 +-- 1 files changed, 13 insertions(+), 2 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index

[Qemu-devel] [PATCH v2 6/6] atapi: Save / load the new GESN event states during migration

2011-04-12 Thread Amit Shah
Add a new subsection to save and restore the events state for the GET_EVENT_STATUS_NOTIFICATION command. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/ide/core.c | 22 ++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c

[Qemu-devel] [PATCH v2 5/6] atapi: GESN: implement 'media' subcommand

2011-04-12 Thread Amit Shah
Implement the 'media' sub-command of the GET_EVENT_STATUS_NOTIFICATION command. This helps us report tray open, tray closed, no media, media present states to the guest. Newer Linux kernels (2.6.38+) rely on this command to revalidate discs after media change. This patch also sends out tray

[Qemu-devel] [PATCH V2] fix acpi regression

2011-04-12 Thread Wen Congyang
This bug is introduced by commit 23910d3f. Signed-off-by: Wen Congyang we...@cn.fujitsu.com --- hw/acpi.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/acpi.c b/hw/acpi.c index e372474..ad40fb4 100644 --- a/hw/acpi.c +++ b/hw/acpi.c @@ -355,7 +355,7 @@ static

[Qemu-devel] [PATCH] Add dd-style SIGUSR1 progress reporting

2011-04-12 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com This introduces support for dd-style progress reporting, if the user hasn't specified -p to report progress. If sent a SIGUSR1, qemu-img will report current progress for commands that support progress reporting. Signed-off-by: Jes Sorensen

[Qemu-devel] [Bug 757702] Re: Undefined instruction exception starts at offset 0x8 instead of 0x4

2011-04-12 Thread Peter Maydell
I can't reproduce this (either with current trunk or with qemu 0.14.0 release version). Also, if we were directing UNDEF exceptions to the SVC entry point I think it would cause fairly obvious breakage of Linux guests. I'm going to attach the test program I used to confirm that we are correctly

[Qemu-devel] [Bug 757702] Re: Undefined instruction exception starts at offset 0x8 instead of 0x4

2011-04-12 Thread Peter Maydell
** Attachment added: test program (source) https://bugs.launchpad.net/qemu/+bug/757702/+attachment/2023202/+files/undef-exc.s -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/757702 Title:

[Qemu-devel] [Bug 757702] Re: Undefined instruction exception starts at offset 0x8 instead of 0x4

2011-04-12 Thread Peter Maydell
** Attachment added: test program (ELF binary) https://bugs.launchpad.net/qemu/+bug/757702/+attachment/2023214/+files/undef-exc.axf -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/757702 Title:

Re: [Qemu-devel] [PATCH v2 0/3] pc-bios: Use iPXE ROMs

2011-04-12 Thread Stefan Hajnoczi
On Mon, Apr 11, 2011 at 9:10 PM, Alex Williamson alex.william...@redhat.com wrote: On Mon, 2011-04-11 at 13:57 -0600, Alex Williamson wrote: On Mon, 2011-04-11 at 14:48 -0500, Anthony Liguori wrote: On 04/11/2011 02:35 PM, Alex Williamson wrote: This series replaces our current gPXE based

Re: [Qemu-devel] [PATCH V2] fix acpi regression

2011-04-12 Thread Isaku Yamahata
Thank you. Looks good. On Tue, Apr 12, 2011 at 05:27:44PM +0800, Wen Congyang wrote: This bug is introduced by commit 23910d3f. Signed-off-by: Wen Congyang we...@cn.fujitsu.com --- hw/acpi.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/acpi.c

[Qemu-devel] [Bug 757702] Re: Undefined instruction exception starts at offset 0x8 instead of 0x4

2011-04-12 Thread Peter Maydell
ARMv7a has lot of undefined instruction from its instruction opcode space. This undefined instructions are very useful for replacing sensitive non-priviledged instructions of guest operating systems (virtualization). PS: please don't use arbitrary UNDEF instruction patterns for this (the one

Re: [Qemu-devel] [PATCH 04/11] Move generic or OS function declarations to qemu-common.h

2011-04-12 Thread Jes Sorensen
On 04/08/11 22:45, Blue Swirl wrote: Move generic or OS related function declarations and macro TFR to qemu-common.h. While moving, also add #include winsock2.h to fix a recent mingw32 build breakage. Signed-off-by: Blue Swirl blauwir...@gmail.com --- qemu-common.h | 21

Re: [Qemu-devel] [PATCH v2 1/6] atapi: Allow GESN after media change

2011-04-12 Thread Kevin Wolf
Am 12.04.2011 11:27, schrieb Amit Shah: After a media change, the only commands allowed from the guest were REQUEST_SENSE and INQUIRY. The guest may also issue GET_EVENT_STATUS_NOTIFICATION commands to get media changed notification. Signed-off-by: Amit Shah amit.s...@redhat.com ---

Re: [Qemu-devel] [PATCH] vmstate: fix varrays with uint32_t indexes

2011-04-12 Thread Stefan Hajnoczi
On Mon, Apr 11, 2011 at 3:01 PM, Amos Kong ak...@redhat.com wrote: VARRAY_UINT32 only exists in vmstate_load_state(), but not in vmstate_save_state(). CC: Juan Quintela quint...@redhat.com Signed-off-by: Amos Kong ak...@redhat.com ---  savevm.c |    2 ++  1 files changed, 2 insertions(+),

Re: [Qemu-devel] [PATCH v2 4/6] atapi: GESN: Use structs for commonly-used field types

2011-04-12 Thread Kevin Wolf
Am 12.04.2011 11:27, schrieb Amit Shah: Instead of using magic numbers, use structs that are more descriptive of the fields being used. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/ide/core.c | 15 +-- 1 files changed, 13 insertions(+), 2 deletions(-) diff --git

Re: [Qemu-devel] [Bug 757702] Re: Undefined instruction exception starts at offset 0x8 instead of 0x4

2011-04-12 Thread Anup Patel
Hi, You are right, I have deliberately used an instruction from a permanently UNDEF space. I have used this instruction because thats this are the only UNDEF instructions with maximum payload of 20 bits. Also, the instruction 0xec019800 does not belong to STC instruction space. GNU object dump

Re: [Qemu-devel] [PATCH v2 5/6] atapi: GESN: implement 'media' subcommand

2011-04-12 Thread Kevin Wolf
Am 12.04.2011 11:27, schrieb Amit Shah: Implement the 'media' sub-command of the GET_EVENT_STATUS_NOTIFICATION command. This helps us report tray open, tray closed, no media, media present states to the guest. Newer Linux kernels (2.6.38+) rely on this command to revalidate discs after

Re: [Qemu-devel] [PATCH v2 6/6] atapi: Save / load the new GESN event states during migration

2011-04-12 Thread Kevin Wolf
Am 12.04.2011 11:27, schrieb Amit Shah: Add a new subsection to save and restore the events state for the GET_EVENT_STATUS_NOTIFICATION command. Signed-off-by: Amit Shah amit.s...@redhat.com Looks good, but I think it should be merged into patch 5, so that there are no commits for which

Re: [Qemu-devel] [Bug 757702] Re: Undefined instruction exception starts at offset 0x8 instead of 0x4

2011-04-12 Thread Anup Patel
Hi The correct command to launch qemu will be: ./qemu-system-arm -s -S -M realview-pb-a8 -serial stdio -kernel arm_test.elf Sorry, for mistake in previous mail. --Anup On Tue, Apr 12, 2011 at 3:48 PM, Anup Patel anuppatelinvinci...@gmail.comwrote: Hi, You are right, I have deliberately used

[Qemu-devel] [Bug 757702] Re: Undefined instruction exception starts at offset 0x8 instead of 0x4

2011-04-12 Thread Peter Maydell
Also, the instruction 0xec019800 does not belong to STC instruction space. Yes it does. STC encoding A1 is: cond:4 110 p u d w 0 rn:4 crd:4 coproc:4 imm:8 For STC the combination of P=0 U=0 D=0 W=0 is UNDEFINED, but it's still in STC space. This is not permanently UNDEF, it might be allocated

Re: [Qemu-devel] [Bug 757702] Re: Undefined instruction exception starts at offset 0x8 instead of 0x4

2011-04-12 Thread Anup Patel
Actually, the undefined instruction that I have used is documented as undefined at two places in ARM Instruction Set Encoding section of ARMv7a reference manual: 1. Refer Table A5-22 Supervisor Call, and coprocessor instructions 2. Refer A8.6.188 STC, STC2 So you see one can easily get confused

Re: [Qemu-devel] [Bug 757702] Re: Undefined instruction exception starts at offset 0x8 instead of 0x4

2011-04-12 Thread Anup Patel
Also, in the test case hits 0x8 after encountering UNDEF instruction at 0x100058. The test case is not broken it failed in initialization sequence itself. PS: I had download most recent version of QEMU 0.14.0 and build it my self. On Tue, Apr 12, 2011 at 4:33 PM, Anup Patel

[Qemu-devel] [Bug 757702] Re: Undefined instruction exception starts at offset 0x8 instead of 0x4

2011-04-12 Thread Peter Maydell
Sorry, I didn't notice the footnote in table A5-22; I see what you mean now. It's still not permanently-UNDEF space though and you'd really be better off using that instead. In any case, qemu does properly UNDEF the instruction so this is a bit of a diversion. -- You received this bug

[Qemu-devel] [PATCH v3 0/5] atapi: Implement 'media' subcommand for GESN

2011-04-12 Thread Amit Shah
The GET_EVENT_STATUS_NOTIFICATION ATAPI command is listed as a mandatory command in the spec but we don't really implement it any of its sub-commands. The commit message for the last commit explains why implementing just the media subcommand is helpful and how it goes a long way in getting guests

[Qemu-devel] [PATCH v3 1/5] atapi: Allow GET_EVENT_STATUS_NOTIFICATION after media change

2011-04-12 Thread Amit Shah
After a media change, the only commands allowed from the guest were REQUEST_SENSE and INQUIRY. The guest may also issue GET_EVENT_STATUS_NOTIFICATION commands to get media changed notification. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/ide/core.c | 20 ++-- 1 files

[Qemu-devel] [PATCH v3 2/5] atapi: Move GET_EVENT_STATUS_NOTIFICATION command handling to its own function

2011-04-12 Thread Amit Shah
This makes the code more readable. Also, there's a block like: if () { ... } else { ... } Split that into if () { ... return; } ... Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/ide/core.c | 37 - 1 files changed, 24 insertions(+), 13

[Qemu-devel] [PATCH v3 3/5] atapi: GESN: Use structs for commonly-used field types

2011-04-12 Thread Amit Shah
Instead of using magic numbers, use structs that are more descriptive of the fields being used. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/ide/core.c | 22 +- 1 files changed, 17 insertions(+), 5 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index

[Qemu-devel] [PATCH v3 4/5] atapi: GESN: Standardise event response handling for future additions

2011-04-12 Thread Amit Shah
Handle GET_EVENT_STATUS_NOTIFICATION's No Event Available response in a generic way so that future additions to the code to handle other response types is easier. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/ide/core.c | 24 +++- 1 files changed, 19 insertions(+), 5

[Qemu-devel] [PATCH v3 5/5] atapi: GESN: implement 'media' subcommand

2011-04-12 Thread Amit Shah
Implement the 'media' sub-command of the GET_EVENT_STATUS_NOTIFICATION command. This helps us report tray open, tray closed, no media, media present states to the guest. Newer Linux kernels (2.6.38+) rely on this command to revalidate discs after media change. This patch also sends out tray

[Qemu-devel] [Bug 757702] Re: Undefined instruction exception starts at offset 0x8 instead of 0x4

2011-04-12 Thread Peter Maydell
Also, in the test case hits 0x8 after encountering UNDEF instruction at 0x100058. So if you run qemu like this: qemu-system-arm -M realview-pb-a8 -serial stdio -kernel arm_test.elf -s -S and run arm-none-gnueabi-gdb with no arguments and in gdb type these commands: (gdb) target remote :1234

Re: [Qemu-devel] [Bug 757702] Re: Undefined instruction exception starts at offset 0x8 instead of 0x4

2011-04-12 Thread Anup Patel
I see 0x0008 (). I am using qemu-0.14.0.tar.gz available for QEMU Downloads. --Anup On Tue, Apr 12, 2011 at 5:12 PM, Peter Maydell peter.mayd...@linaro.orgwrote: Also, in the test case hits 0x8 after encountering UNDEF instruction at 0x100058. So if you run qemu like this:

Re: [Qemu-devel] [Bug 757702] Re: Undefined instruction exception starts at offset 0x8 instead of 0x4

2011-04-12 Thread Anup Patel
Try this out one last time. I am sure you will be able to replicate the problem. Run qemu like this: qemu-system-arm -M realview-pb-a8 -serial stdio -kernel arm_test.elf -s -S and run arm-none-gnueabi-gdb with no arguments and in gdb type these commands: (gdb) target remote :1234 Remote

Re: [Qemu-devel] [PATCH 4/4] qemu-timer: Fix timers for w32

2011-04-12 Thread Jan Kiszka
On 2011-04-11 19:21, Stefan Weil wrote: Am 11.04.2011 09:36, schrieb Paolo Bonzini: On 04/10/2011 08:28 PM, Stefan Weil wrote: Commit 68c23e5520e8286d79d96ab47c0ea722ceb75041 removed the multimedia timer, but this timer is needed for certain Linux kernels. Otherwise Linux boot stops with this

Re: [Qemu-devel] [PATCH 4/4] qemu-timer: Fix timers for w32

2011-04-12 Thread Paolo Bonzini
On 04/12/2011 02:36 PM, Jan Kiszka wrote: I see the same bug here with two XP hosts and also tried both timer variants of current QEMU (without a difference). I don't get the bug when running on a Linux host using wine. Passing no_timer_check to the Linux guest should work around the issue as

[Qemu-devel] [PATCH 0/2] ARM: Detect FP tininess before rounding

2011-04-12 Thread Peter Maydell
Softfloat supports two kinds of FP tininess detection: before and after rounding (corresponding to the two behaviours permitted by IEEE754). The ARM architecture mandates detection before rounding, so set the flag appropriately. I had to add a setter function for this, since there wasn't one

Re: [Qemu-devel] [PATCH 4/4] qemu-timer: Fix timers for w32

2011-04-12 Thread Jan Kiszka
On 2011-04-12 14:40, Paolo Bonzini wrote: On 04/12/2011 02:36 PM, Jan Kiszka wrote: I see the same bug here with two XP hosts and also tried both timer variants of current QEMU (without a difference). I don't get the bug when running on a Linux host using wine. Passing no_timer_check to

Re: [Qemu-devel] [PATCH v3 4/5] atapi: GESN: Standardise event response handling for future additions

2011-04-12 Thread Kevin Wolf
Am 12.04.2011 13:43, schrieb Amit Shah: Handle GET_EVENT_STATUS_NOTIFICATION's No Event Available response in a generic way so that future additions to the code to handle other response types is easier. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/ide/core.c | 24

Re: [Qemu-devel] KVM call agenda for April 12

2011-04-12 Thread Juan Quintela
Juan Quintela quint...@trasno.org wrote: Please, send in any agenda items you are interested in covering. Later, Juan. As there is no agenda items posted, today call is just cancelled. Enjoy, Juan.

[Qemu-devel] [PATCH 0/2] StrongARM/Sharp Zaurus SL-5500 support

2011-04-12 Thread Dmitry Eremin-Solenikov
Hello, please review next try for my StrongARM patches. SA has been enhanced in the areas of RTC and UART drivers: I've added register bit names and used them instead of various magic bits/bitmasks. -- With best wishes Dmitry

[Qemu-devel] [PATCH 2/2] Basic implementation of Sharp Zaurus SL-5500 collie PDA

2011-04-12 Thread Dmitry Eremin-Solenikov
Add very basic implementation of collie PDA emulation. The system lacks LoCoMo and graphics/sound emulation. Linux kernel boots up to mounting rootfs (theoretically it can be provided in pflash images). Signed-off-by: Dmitry Eremin-Solenikov dbarysh...@gmail.com --- Makefile.target |1 +

[Qemu-devel] [PATCH 1/2] Implement basic part of SA-1110/SA-1100

2011-04-12 Thread Dmitry Eremin-Solenikov
Basic implementation of DEC/Intel SA-1100/SA-1110 chips emulation. Implemented: - IRQs - GPIO - PPC - RTC - UARTs (no IrDA/etc.) - OST reused from pxa25x Everything else is TODO (esp. PM/idle/sleep!) - see the todo in the hw/strongarm.c V4: * use bitnames to access RTC and UART registers

[Qemu-devel] [PATCH V3 0/8] Qemu Trusted Platform Module (TPM) integration

2011-04-12 Thread Stefan Berger
The following series of patches adds a TPM (Trusted Platform Module) TIS (TPM Interface Spec) interface to Qemu and with that provides means to access a backend implementing the actual TPM functionality. This frontend enables for example Linux's TPM TIS (tpm_tis) driver. I am also posting the

[Qemu-devel] [PATCH V3 4/8] Add tpm_tis driver to build process

2011-04-12 Thread Stefan Berger
The TPM interface (tpm_tis) needs to be explicitly enabled via ./configure --enable-tpm. This patch also restricts the building of the TPM support to i386 and x86_64 targets since both backends I know of, the Xen backend and the libtpms-based backend, will likely only be available for these

[Qemu-devel] [PATCH V3 8/8] Add block storage support for libtpms based TPM backend

2011-04-12 Thread Stefan Berger
This patch supports the storage of TPM persisten state. The TPM creates state of varying size, depending for example how many keys are loaded into it a a certain time. The worst-case sizes of the different blobs the TPM can write have been pre-calculated and this value is used to determine the

[Qemu-devel] [PATCH V3 2/8] Add TPM (frontend) hardware interface (TPM TIS) to Qemu

2011-04-12 Thread Stefan Berger
This patch adds the main code of the TPM frontend driver, the TPM TIS interface, to Qemu. The code is largely based on my previous implementation for Xen but has been significantly extended to meet the standard's requirements, such as the support for changing of localities and all the

[Qemu-devel] [PATCH V3 7/8] Implementation of the libtpms-based backend

2011-04-12 Thread Stefan Berger
This patch provides the glue for the TPM TIS interface (frontend) to the libtpms that provides the actual TPM functionality. Some details: This part of the patch provides support for the spawning of a thread that will interact with the libtpms-based TPM. It expects a signal from the frontend to

[Qemu-devel] [PATCH V3 1/8] Support for TPM command line options

2011-04-12 Thread Stefan Berger
This patch adds support for TPM command line options. The command line supported here (considering the libtpms based backend) are ./qemu-... -tpm type=type,path=path to blockstorage file, and ./qemu-... -tpm ? where the latter works similar to -soundhw ? and shows a list of available TPM

[Qemu-devel] [PATCH V3 6/8] Add a TPM backend skeleton implementation

2011-04-12 Thread Stefan Berger
This patch provides a TPM backend skelteon implementation. It doesn't do anything but it compiles. v3: - in tpm_builtin.c all functions prefixed with tpm_builtin_ - build the builtin TPM driver available at this point; it returns a failure response message for every command - do not try

[Qemu-devel] [PATCH V3 5/8] Add a debug register

2011-04-12 Thread Stefan Berger
This patch uses the possibility to add a vendor-specific register and adds a debug register useful for dumping the internal state. This register is only active in a debug build (#define DEBUG_TIS). v3: - all output goes to stderr Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com ---

[Qemu-devel] [PATCH V3 3/8] Add persistent state handling to TPM TIS frontend driver

2011-04-12 Thread Stefan Berger
This patch adds support for handling of persistent state to the TPM TIS frontend. The currently used buffer is determined (can only be in currently active locality and either be a read or a write buffer) and only that buffer's content is stored. The reverse is done when the state is restored from

[Qemu-devel] [PATCH 2/2] target-arm: Detect tininess before rounding for FP operations

2011-04-12 Thread Peter Maydell
The ARM architecture mandates that we detect tininess before rounding, so set the softfloat fp_status up appropriately. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-arm/helper.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/target-arm/helper.c

[Qemu-devel] [PATCH 1/2] softfloat: Add setter function for tininess detection mode

2011-04-12 Thread Peter Maydell
Add a setter function for the underflow tininess detection mode, in line with the similar functions for other parts of the float status structure. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- fpu/softfloat.h |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v3 3/5] atapi: GESN: Use structs for commonly-used field types

2011-04-12 Thread Markus Armbruster
Amit Shah amit.s...@redhat.com writes: Instead of using magic numbers, use structs that are more descriptive of the fields being used. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/ide/core.c | 22 +- 1 files changed, 17 insertions(+), 5 deletions(-) diff

Re: [Qemu-devel] [PATCH v3 0/4] Fix -icount with iothread

2011-04-12 Thread Paolo Bonzini
On 04/12/2011 11:26 AM, Jan Kiszka wrote: On 2011-04-12 10:44, Paolo Bonzini wrote: This series finally fixes -icount with iothread and avoids deadlocks due to the vm_clock not making progress when the VM is stopped. The crux of the fix is in patch 1, while patch 2 implements the clock warping

[Qemu-devel] [PATCH V4 3/8] Add public get_rsdp function

2011-04-12 Thread Stefan Berger
This patch adds a global get_rsdp() function call and refactors find_resume_vector() to call it. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- src/acpi.c | 12 ++-- src/acpi.h |1 + 2 files changed, 11 insertions(+), 2 deletions(-) Index: seabios/src/acpi.c

[Qemu-devel] [PATCH V4 5/8] Support for BIOS interrupt handler

2011-04-12 Thread Stefan Berger
This patch implements the TCG BIOS interrupt handler 1ah. It is for example used by trusted grub. This patch adds an implementation of SHA1 (following NIST specs., IETF RFC 3147 and Wikipedia) for speeding up measurements of code. Trusted Grub for example makes use of this interface and measures

[Qemu-devel] [PATCH V4 0/8] Add TPM support to SeaBIOS

2011-04-12 Thread Stefan Berger
The following set of patches add TPM and Trusted Computing support to SeaBIOS. In particular the patches add: - a TPM driver for the Qemu's TPM TIS emulation (not yet in Qemu git) - ACPI support for the TPM device (SSDT table) - ACPI support for measurement logging (TCPA table) - Support for

[Qemu-devel] [PATCH V4 4/8] Implementation of the TCG BIOS extensions

2011-04-12 Thread Stefan Berger
This patch implements the main part of the TCG BIOS extensions. It provides the following functionality: - initialization of the TCPA ACPI table used for logging of measurements - initialization of the TPM by sending a sequence of commands to it - proper setup of the TPM once the BIOS hands over

[Qemu-devel] [PATCH V4 1/8] Add an implementation for a TPM TIS driver

2011-04-12 Thread Stefan Berger
This patch adds an implementation of a TPM TIS driver for the TPM TIS emulation supported by Qemu (patches posted, not in git yet). Usage of the driver is broken up into several functions. The driver is cleanly separated from the rest of the code through an interface holding pointers to the

[Qemu-devel] [PATCH V4 7/8] Add a menu for TPM control

2011-04-12 Thread Stefan Berger
This patch provides an addtional menu entry that enables the user to control certain aspects of the TPM. If a working TPM has been detected, the top level BIOS menu will look like this: Press F12 for boot menu. Press F11 to TPM menu. Upon pressing F11 the TPM menu will be shown: 1. Enable TPM

[Qemu-devel] [PATCH V4 2/8] Provide ACPI SSDT table for TPM device + S3 resume support

2011-04-12 Thread Stefan Berger
This patch provides ACPI support for the TPM device. It probes for the TPM device and only if a TPM device is found then the TPM's SSDT and TCPA table are created. This patch also connects them to the RSDT. Since the logging area in the TCPA table requires 64kb, the memory reserved for ACPI

[Qemu-devel] [PATCH V4 8/8] Optional tests for the TIS interface

2011-04-12 Thread Stefan Berger
This patch adds an optional test suite (CONFIG_TIS_TEST) for the TIS interface to SeaBIOS. If compiled into the BIOS, it can be invoked through the TPM-specific menu item 8. 1. Enable TPM 2. Disable TPM 3. Activate TPM 4. Deactivate TPM 5. Clear ownership 6. Allow installation of owner 7. Prevent

[Qemu-devel] [PATCH V4 6/8] Add measurement code to the BIOS

2011-04-12 Thread Stefan Berger
This patch adds invocactions of functions that measure various parts of the code and data through various parts of the BIOS code. It follows TCG specifications on what needs to be measured. It also adds the implementation of the called functions. Reference for what needs to be measured can be

Re: [Qemu-devel] [PATCH v3 0/7] Let boards state maximum RAM limits in QEMUMachine struct

2011-04-12 Thread Jes Sorensen
On 04/04/11 19:26, Peter Maydell wrote: On 4 April 2011 15:53, Jes Sorensen jes.soren...@redhat.com wrote: I understand that what you are proposing seems to work well enough for your problem at hand. What I am saying is that adding a mechanism like that, can cause problems for adding a more

Re: [Qemu-devel] [PATCH v3 0/7] Let boards state maximum RAM limits in QEMUMachine struct

2011-04-12 Thread Jes Sorensen
On 04/04/11 18:54, Blue Swirl wrote: On Mon, Apr 4, 2011 at 5:53 PM, Jes Sorensen jes.soren...@redhat.com wrote: I understand that what you are proposing seems to work well enough for your problem at hand. What I am saying is that adding a mechanism like that, can cause problems for adding a

Re: [Qemu-devel] [PATCH v3 4/5] atapi: GESN: Standardise event response handling for future additions

2011-04-12 Thread Amit Shah
On (Tue) 12 Apr 2011 [15:09:33], Kevin Wolf wrote: Am 12.04.2011 13:43, schrieb Amit Shah: Handle GET_EVENT_STATUS_NOTIFICATION's No Event Available response in a generic way so that future additions to the code to handle other response types is easier. Signed-off-by: Amit Shah

Re: [Qemu-devel] [PATCH v3 3/5] atapi: GESN: Use structs for commonly-used field types

2011-04-12 Thread Amit Shah
On (Tue) 12 Apr 2011 [15:10:39], Markus Armbruster wrote: Amit Shah amit.s...@redhat.com writes: Instead of using magic numbers, use structs that are more descriptive of the fields being used. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/ide/core.c | 22

Re: [Qemu-devel] [PATCH v3 4/5] atapi: GESN: Standardise event response handling for future additions

2011-04-12 Thread Kevin Wolf
Am 12.04.2011 15:59, schrieb Amit Shah: On (Tue) 12 Apr 2011 [15:09:33], Kevin Wolf wrote: Am 12.04.2011 13:43, schrieb Amit Shah: Handle GET_EVENT_STATUS_NOTIFICATION's No Event Available response in a generic way so that future additions to the code to handle other response types is easier.

[Qemu-devel] [PATCH v4 0/5] atapi: Implement 'media' subcommand for GESN

2011-04-12 Thread Amit Shah
The GET_EVENT_STATUS_NOTIFICATION ATAPI command is listed as a mandatory command in the spec but we don't really implement it any of its sub-commands. The commit message for the last commit explains why implementing just the media subcommand is helpful and how it goes a long way in getting guests

  1   2   3   >