Re: [Qemu-devel] [virt-tools-list] Virt Tools Survey: What to do about virt-clone

2011-05-11 Thread Juerg Haefliger
(a) Is cloning guests useful for you or not?  Often or infrequently? I don't 'clone' in the strict sense of the word. I create a base raw OS image and provide that image to other users as a common starting point for them to setup their guests. I don't care about the XML definition, just the raw

Re: [Qemu-devel] [PATCH 1/2] usb-linux: fix device path aka physical port handling

2011-05-11 Thread Markus Armbruster
Good stuff, just a few questions. Gerd Hoffmann kra...@redhat.com writes: The device path isn't just a number. It specifies the physical port the device is connected to and in case the device is connected via usb hub you'll have two numbers there, like this: 5.1. The first specifies the

Re: [Qemu-devel] adding search to dhcp

2011-05-11 Thread Stefan Hajnoczi
On Tue, May 10, 2011 at 6:40 PM, Carl Karsten c...@personnelware.com wrote: I would expect the syntax to look like this: qemu -hda 1.qcow2 -net nick -net user,hostname=qemu,search=example.com,sales.example.com Comma escaping is needed but it seems like a reasonable feature to me. Stefan

Re: [Qemu-devel] [PATCH] Add warmup phase for live migration of large memory apps

2011-05-11 Thread Stefan Hajnoczi
On Wed, May 11, 2011 at 8:58 AM, Shribman, Aidan aidan.shrib...@sap.com wrote: From: Aidan Shribman aidan.shrib...@sap.com [PATCH] Add warmup phase for live migration of large memory apps By invoking migrate -w url we initiate a background live-migration transferring of dirty pages

Re: [Qemu-devel] -net PCI bus order reversed since 1.14.0

2011-05-11 Thread Rob Landley
On 05/10/2011 02:51 AM, Rob Landley wrote: Until recently, -net options used to add interfaces to linux in the same order they went on the command line, so the first one you listed on the qemu command line would become eth0, the second -net became eth1, and so on. Now they're added in

Re: [Qemu-devel] [PATCH] Add AACI audio playback support to the ARM Versatile/PB platform

2011-05-11 Thread Paul Brook
The PL041 driver provides an interface to an ACLink bus. The LM4549 driver emulates a DAC connected on the ACLink bus. Only audio playback is implemented. Shouldn't this be shared with the other AC97 devices? Paul

[Qemu-devel] [PATCH 2/2] coroutine: add check-coroutine automated tests

2011-05-11 Thread Stefan Hajnoczi
To run automated tests for coroutines: make check-coroutine ./check-coroutine On success the program terminates with exit status 0. On failure an error message is written to stderr and the program exits with exit status 1. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com ---

[Qemu-devel] [PATCH 0/2] Coroutines for better asynchronous programming

2011-05-11 Thread Stefan Hajnoczi
QEMU is event-driven and suffers when blocking operations are performed because VM execution may be stopped until the operation completes. Therefore many operations that could block are performed asynchronously and a callback is invoked when the operation has completed. This allows QEMU to

[Qemu-devel] [PATCH 1/2] coroutine: introduce coroutines

2011-05-11 Thread Stefan Hajnoczi
From: Kevin Wolf kw...@redhat.com Asynchronous code is becoming very complex. At the same time synchronous code is growing because it is convenient to write. Sometimes duplicate code paths are even added, one synchronous and the other asynchronous. This patch introduces coroutines which allow

Re: [Qemu-devel] adding search to dhcp

2011-05-11 Thread Markus Armbruster
Stefan Hajnoczi stefa...@gmail.com writes: On Tue, May 10, 2011 at 6:40 PM, Carl Karsten c...@personnelware.com wrote: I would expect the syntax to look like this: qemu -hda 1.qcow2 -net nick -net user,hostname=qemu,search=example.com,sales.example.com Comma escaping is needed but it seems

Re: [Qemu-devel] [PATCH 1/2] coroutine: introduce coroutines

2011-05-11 Thread Kevin Wolf
Am 11.05.2011 12:15, schrieb Stefan Hajnoczi: From: Kevin Wolf kw...@redhat.com Asynchronous code is becoming very complex. At the same time synchronous code is growing because it is convenient to write. Sometimes duplicate code paths are even added, one synchronous and the other

Re: [Qemu-devel] Bug #757654: UHCI fails to signal stall response patch

2011-05-11 Thread Jan Vesely
glad I could help the original bug report is here: https://bugs.launchpad.net/qemu/+bug/757654 should I update it? or will it be updated when the patch reaches master? j. On Mon, May 9, 2011 at 1:43 PM, Gerd Hoffmann kra...@redhat.com wrote: On 05/09/11 12:16, Jan Vesely wrote: UHCI host

Re: [Qemu-devel] [PATCH uq/master V2] kvm: Add CPUID support for VIA CPU

2011-05-11 Thread Avi Kivity
On 05/10/2011 11:02 AM, BrillyWu wrote: From: BrillyWubrill...@viatech.com.cn When KVM is running on VIA CPU with host cpu's model, the feautures of VIA CPU will be passed into kvm guest by calling the CPUID instruction for Centaur. Applied, thanks. -- error compiling committee.c: too many

Re: [Qemu-devel] [PATCH 1/2] coroutine: introduce coroutines

2011-05-11 Thread Paolo Bonzini
On 05/11/2011 12:15 PM, Stefan Hajnoczi wrote: +#ifdef __i386__ +asm volatile( +mov %%esp, %%ebx; +mov %0, %%esp; +pushl %1; +call _trampoline; +mov %%ebx, %%esp; +: : r (co-stack + co-stack_size), r (co) : ebx +); This is incomplete, it

Re: [Qemu-devel] [PATCH 1/2] coroutine: introduce coroutines

2011-05-11 Thread Kevin Wolf
Am 11.05.2011 14:04, schrieb Paolo Bonzini: On 05/11/2011 12:15 PM, Stefan Hajnoczi wrote: +#ifdef __i386__ +asm volatile( +mov %%esp, %%ebx; +mov %0, %%esp; +pushl %1; +call _trampoline; +mov %%ebx, %%esp; +: : r (co-stack +

Re: [Qemu-devel] [PATCH 1/2] coroutine: introduce coroutines

2011-05-11 Thread Anthony Liguori
On 05/11/2011 05:15 AM, Stefan Hajnoczi wrote: From: Kevin Wolfkw...@redhat.com Asynchronous code is becoming very complex. At the same time synchronous code is growing because it is convenient to write. Sometimes duplicate code paths are even added, one synchronous and the other asynchronous.

Re: [Qemu-devel] [PATCH 1/2] coroutine: introduce coroutines

2011-05-11 Thread Paolo Bonzini
On 05/11/2011 02:36 PM, Anthony Liguori wrote: So the only Linux host we support is x86?? We can't reasonably do this IMHO. If we're going to go this route, we should at least fall back to setcontext for the sake of portability. That was: diff --git a/coroutine-win32.c b/coroutine-win32.c

Re: [Qemu-devel] [PATCH 1/2] coroutine: introduce coroutines

2011-05-11 Thread Anthony Liguori
On 05/11/2011 07:04 AM, Paolo Bonzini wrote: On 05/11/2011 12:15 PM, Stefan Hajnoczi wrote: +#ifdef __i386__ + asm volatile( + mov %%esp, %%ebx; + mov %0, %%esp; + pushl %1; + call _trampoline; + mov %%ebx, %%esp; + : : r (co-stack + co-stack_size), r (co) : ebx + ); This is incomplete, it

Re: [Qemu-devel] [PATCH 1/2] coroutine: introduce coroutines

2011-05-11 Thread Paolo Bonzini
On 05/11/2011 02:51 PM, Anthony Liguori wrote: How about a generic thread fallback? That's what we do in gtk-vnc and it solves the portability issue in a very robust way. A very slow way, too (on Windows at least if you use qemu_cond...). Paolo

Re: [Qemu-devel] [PATCH 1/2] coroutine: introduce coroutines

2011-05-11 Thread Stefan Hajnoczi
On Wed, May 11, 2011 at 1:46 PM, Paolo Bonzini pbonz...@redhat.com wrote: On 05/11/2011 02:36 PM, Anthony Liguori wrote: diff --git a/coroutine-win32.c b/coroutine-win32.c Kevin: This reminds me that I did not run ./check-coroutine on win32. If you are able to run it in your environment that

Re: [Qemu-devel] [PATCH 1/2] coroutine: introduce coroutines

2011-05-11 Thread Kevin Wolf
Am 11.05.2011 14:36, schrieb Anthony Liguori: On 05/11/2011 05:15 AM, Stefan Hajnoczi wrote: From: Kevin Wolfkw...@redhat.com Asynchronous code is becoming very complex. At the same time synchronous code is growing because it is convenient to write. Sometimes duplicate code paths are even

Re: [Qemu-devel] [PATCH 1/2] coroutine: introduce coroutines

2011-05-11 Thread Anthony Liguori
On 05/11/2011 07:52 AM, Paolo Bonzini wrote: On 05/11/2011 02:51 PM, Anthony Liguori wrote: How about a generic thread fallback? That's what we do in gtk-vnc and it solves the portability issue in a very robust way. A very slow way, too (on Windows at least if you use qemu_cond...). That

[Qemu-devel] [PATCH 2/5] spice: enable thread support

2011-05-11 Thread Gerd Hoffmann
The spice locking fixes cherry-picked from master need qemu mutexes. Enable CONFIG_THREAD when enabling spice so they get linked in. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- configure |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/configure b/configure index

[Qemu-devel] [PATCH 4/5] spice: don't call displaystate callbacks from spice server context.

2011-05-11 Thread Gerd Hoffmann
This patch moves the displaystate callback calls for setting the cursor and the mouse pointer from spice server to qemu (iothread) context. This allows us to simplify locking. Signed-off-by: Gerd Hoffmann kra...@redhat.com (cherry picked from commit 075360945860ad9bdd491921954b383bf762b0e5) ---

[Qemu-devel] [PATCH 5/5] spice: drop obsolete iothread locking

2011-05-11 Thread Gerd Hoffmann
We don't use qemu internals from spice server context any more. Thus we don't also need to grab the iothread mutex from spice server context. And we don't have to temporarely release the lock to avoid deadlocks. Drop all the calls. Signed-off-by: Gerd Hoffmann kra...@redhat.com (cherry picked

[Qemu-devel] [STABLE PULL] spice: locking fixes

2011-05-11 Thread Gerd Hoffmann
Hi, Here are the spice locking fixes backported to the 0.14 stable branch. please pull, Gerd The following changes since commit 56a60dd6d619877e9957ba06b92d2f276e3c229d: Version 0.14.1 (2011-05-04 13:50:56 -0500) are available in the git repository at:

[Qemu-devel] [PATCH 3/5] spice: don't create updates in spice server context.

2011-05-11 Thread Gerd Hoffmann
This patch moves the creation of spice screen updates from the spice server context to qemu iothread context (display refresh timer to be exact). This way we avoid accessing qemu internals (display surface) from spice thread context which in turn allows us to simplify locking. Signed-off-by:

[Qemu-devel] [PATCH 1/5] Make spice dummy functions inline to fix calls not checking return values

2011-05-11 Thread Gerd Hoffmann
From: Jes Sorensen jes.soren...@redhat.com qemu_spice_set_passwd() and qemu_spice_set_pw_expire() dummy functions needs to be inline, in order to handle the case where they are called without checking the return value. Signed-off-by: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Gerd

Re: [Qemu-devel] [PATCH] Add warmup phase for live migration of large memory apps

2011-05-11 Thread Anthony Liguori
On 05/11/2011 02:58 AM, Shribman, Aidan wrote: From: Aidan Shribmanaidan.shrib...@sap.com [PATCH] Add warmup phase for live migration of large memory apps By invoking migrate -wurl we initiate a background live-migration transferring of dirty pages continuously until invocation of migrate_end

Re: [Qemu-devel] [PATCH 1/2] coroutine: introduce coroutines

2011-05-11 Thread Paolo Bonzini
On 05/11/2011 03:05 PM, Anthony Liguori wrote: A very slow way, too (on Windows at least if you use qemu_cond...). That doesn't mean you can't do a fiber implementation for Windows... but having a highly portable fallback is a good thing. I agree but where would you place it, since QEMU is

Re: [Qemu-devel] [PATCH 1/2] coroutine: introduce coroutines

2011-05-11 Thread Daniel P. Berrange
On Wed, May 11, 2011 at 03:45:39PM +0200, Paolo Bonzini wrote: On 05/11/2011 03:05 PM, Anthony Liguori wrote: A very slow way, too (on Windows at least if you use qemu_cond...). That doesn't mean you can't do a fiber implementation for Windows... but having a highly portable fallback is a

Re: [Qemu-devel] Add option to disable Cocoa on Mac OS X

2011-05-11 Thread Peter Maydell
On 7 May 2011 12:40, Alexander Graf ag...@suse.de wrote: So I suppose the only thing missing is a --disable-cocoa option, yup. I've just noticed that some of the code in block/raw-posix.c uses the CONFIG_COCOA #define to gate whether to do MacOSX specific handling of CDROMs and so on. I'm not a

Re: [Qemu-devel] [PATCH] Add warmup phase for live migration of large memory apps

2011-05-11 Thread Shribman, Aidan
-Original Message- From: Anthony Liguori [mailto:anth...@codemonkey.ws] Sent: Wednesday, May 11, 2011 4:35 PM To: Shribman, Aidan Cc: qemu-devel@nongnu.org Subject: Re: [Qemu-devel] [PATCH] Add warmup phase for live migration of large memory apps On 05/11/2011 02:58 AM,

Re: [Qemu-devel] adding search to dhcp

2011-05-11 Thread Carl Karsten
On Wed, May 11, 2011 at 6:01 AM, Markus Armbruster arm...@redhat.com wrote: Stefan Hajnoczi stefa...@gmail.com writes: On Tue, May 10, 2011 at 6:40 PM, Carl Karsten c...@personnelware.com wrote: I would expect the syntax to look like this: qemu -hda 1.qcow2 -net nick -net

Re: [Qemu-devel] adding search to dhcp

2011-05-11 Thread Stefan Hajnoczi
On Wed, May 11, 2011 at 4:22 PM, Carl Karsten c...@personnelware.com wrote: On Wed, May 11, 2011 at 6:01 AM, Markus Armbruster arm...@redhat.com wrote: Stefan Hajnoczi stefa...@gmail.com writes: On Tue, May 10, 2011 at 6:40 PM, Carl Karsten c...@personnelware.com wrote: I would expect the

[Qemu-devel] [PATCH] Add an isa device for SGA

2011-05-11 Thread Glauber Costa
This patch adds a dummy legacy ISA device whose responsibility is to deploy sgabios, an option rom for a serial graphics adapter. The proposal is that this device is always-on when -nographics, but can otherwise be enable in any setup when -device sga is used. Signed-off-by: Glauber Costa

Re: [Qemu-devel] TCG: AREG0 removal planning

2011-05-11 Thread Blue Swirl
On Wed, May 11, 2011 at 12:28 AM, Paul Brook p...@codesourcery.com wrote: TCG uses a fixed global register (AREG0) to which points to currently used CPUState, also known as 'env'. Using a fixed register has the downsides that the register must be reserved by TCG for generated code and by the

Re: [Qemu-devel] TCG: AREG0 removal planning

2011-05-11 Thread Blue Swirl
On Wed, May 11, 2011 at 12:58 AM, Richard Henderson r...@twiddle.net wrote: On 05/10/2011 01:54 PM, Blue Swirl wrote: TCG the generator backend -AREG0 is used for qemu_ld/st ops for TLB access. It should be possible for the translators to pass instead a pointer to either CPUState or directly

Re: [Qemu-devel] TCG: AREG0 removal planning

2011-05-11 Thread Blue Swirl
On Wed, May 11, 2011 at 1:57 AM, Paul Brook p...@codesourcery.com wrote: While we're at it, let us change things a bit further to allow guest byte-swap load/store insns to be implemented more efficiently.  For instance, currently a sparc load_asr (little-endian), as emulated on an x86 host,

Re: [Qemu-devel] [PATCH] Add AACI audio playback support to the ARM Versatile/PB platform

2011-05-11 Thread Mathieu Sonet
Paul Brook wrote: The PL041 driver provides an interface to an ACLink bus. The LM4549 driver emulates a DAC connected on the ACLink bus. Only audio playback is implemented. Shouldn't this be shared with the other AC97 devices? Paul I organized the code in 3 different drivers (PL041 = ACLink

Re: [Qemu-devel] TCG: AREG0 removal planning

2011-05-11 Thread Lluís
Blue Swirl writes: On Wed, May 11, 2011 at 12:28 AM, Paul Brook p...@codesourcery.com wrote: In practice generated code probably accesses CPUState often enough that a dedicated register isn't a bad idea.  My guess is that eliminating it from C code gets us almost all of the useful benefit.  

Re: [Qemu-devel] [PATCH 1/2] coroutine: introduce coroutines

2011-05-11 Thread Stefan Weil
Am 11.05.2011 12:15, schrieb Stefan Hajnoczi: From: Kevin Wolf kw...@redhat.com Asynchronous code is becoming very complex. At the same time synchronous code is growing because it is convenient to write. Sometimes duplicate code paths are even added, one synchronous and the other asynchronous.

Re: [Qemu-devel] TCG: AREG0 removal planning

2011-05-11 Thread Blue Swirl
On Wed, May 11, 2011 at 9:39 PM, Lluís xscr...@gmx.net wrote: Blue Swirl writes: On Wed, May 11, 2011 at 12:28 AM, Paul Brook p...@codesourcery.com wrote: In practice generated code probably accesses CPUState often enough that a dedicated register isn't a bad idea.  My guess is that

Re: [Qemu-devel] [virt-tools-list] Virt Tools Survey: What to do about virt-clone

2011-05-11 Thread Alexander Boström
On tis, 2011-05-10 at 12:56 +0100, Richard W.M. Jones wrote: Fedora -- In theory you can just write a file /.unconfigured in the root, and Perhaps this could also be triggered by a change in the system UUID (see dmidecode). Store the UUID in a file during kickstart/firstboot and check

Re: [Qemu-devel] [PATCH] Add an isa device for SGA

2011-05-11 Thread Jan Kiszka
On 2011-05-11 19:11, Glauber Costa wrote: This patch adds a dummy legacy ISA device whose responsibility is to deploy sgabios, an option rom for a serial graphics adapter. The proposal is that this device is always-on when -nographics, but can otherwise be enable in any setup when -device sga

[Qemu-devel] [PATCH] vfio: Fixup uiommu sharing

2011-05-11 Thread Alex Williamson
When setting up a vfio device, we can either create a new iommu domain for each device, or use an iommu domain shared between multiple devices. In the first case, we open /dev/uiommu for each device and pass the new file descriptor for each device's VFIO_DOMAIN_SET ioctl. For the latter, we use

Re: [Qemu-devel] adding search to dhcp

2011-05-11 Thread Jan Kiszka
On 2011-05-11 18:08, Stefan Hajnoczi wrote: On Wed, May 11, 2011 at 4:22 PM, Carl Karsten c...@personnelware.com wrote: On Wed, May 11, 2011 at 6:01 AM, Markus Armbruster arm...@redhat.com wrote: Stefan Hajnoczi stefa...@gmail.com writes: On Tue, May 10, 2011 at 6:40 PM, Carl Karsten

Re: [Qemu-devel] [PATCH] Add an isa device for SGA

2011-05-11 Thread Glauber de Oliveira Costa
- Original Message - From: Jan Kiszka jan.kis...@web.de To: Glauber Costa glom...@redhat.com Cc: k...@vger.kernel.org, aligu...@us.ibm.com, mtosa...@redhat.com, qemu-devel@nongnu.org, a...@redhat.com Sent: Wednesday, May 11, 2011 5:00:10 PM Subject: Re: [PATCH] Add an isa device

Re: [Qemu-devel] adding search to dhcp

2011-05-11 Thread Michael Tokarev
12.05.2011 00:49, Jan Kiszka пишет: On 2011-05-11 18:08, Stefan Hajnoczi wrote: On Wed, May 11, 2011 at 4:22 PM, Carl Karsten c...@personnelware.com wrote: On Wed, May 11, 2011 at 6:01 AM, Markus Armbruster arm...@redhat.com wrote: Stefan Hajnoczi stefa...@gmail.com writes: On Tue, May 10,

[Qemu-devel] [PULL] PPC patch queue

2011-05-11 Thread Alexander Graf
Hi, This is my current PPC patch queue containing all the collected PPC work for Qemu so far. Please pull. Alex The following changes since commit 0225e254ae81c5638463cda8f5730f31619113b6: Stefan Weil (1): usb-linux: Add missing break statement are available in the git repository at:

Re: [Qemu-devel] s390x: fix memory detection for guests 64GB

2011-05-11 Thread Alexander Graf
On 10.05.2011, at 14:49, Christian Borntraeger wrote: Alex, the s390 memory detection has a 16bit field that specifies the amount of increments. This patch adopts the memory size to always fit into that scheme. This also fixes virtio detection for these guests, since the descriptor page

Re: [Qemu-devel] s390x: change mapping base to allow guests 2GB

2011-05-11 Thread Alexander Graf
On 10.05.2011, at 14:49, Christian Borntraeger wrote: Alex, the current s390x qemu memory layout is 0x100: guest start 0x8000: qemu binary which limits the amount of available memory to 2GB. This patch moves the guest pages to 32GB to not collide with the binary and to leave

Re: [Qemu-devel] [PATCH v4 5/5] hpet 'driftfix': add code in hpet_timer() to compensate delayed callbacks and coalesced interrupts

2011-05-11 Thread Zachary Amsden
On 05/09/2011 12:03 AM, Ulrich Obergfell wrote: Loss of periodic timer interrupts caused by delayed callbacks and by interrupt coalescing is compensated by gradually injecting additional interrupts during subsequent timer intervals, starting at a rate of one additional interrupt per interval.

[Qemu-devel] -net interface association behavior change in current -git.

2011-05-11 Thread Rob Landley
In 1.14.0, if I did this: qemu -net nic,blah -net user -net nic,blah -net tun,blah Then the first nic would be -net user, and the second nic would be -net tun.In current -git, -net user attaches to the second interface and -net tun attaches to the first, I.E. the order is reversed. Either

[Qemu-devel] [PATCH] Add warmup phase for live migration of large memory apps

2011-05-11 Thread Shribman, Aidan
From: Aidan Shribman aidan.shrib...@sap.com [PATCH] Add warmup phase for live migration of large memory apps By invoking migrate -w url we initiate a background live-migration transferring of dirty pages continuously until invocation of migrate_end which attempts to complete the live migration