Re: [Qemu-devel] [PATCH 05/18] ide: Turn debug messages into assertions

2011-05-27 Thread Kevin Wolf
Am 26.05.2011 23:12, schrieb Luiz Capitulino: On Thu, 19 May 2011 14:33:19 +0200 Kevin Wolf kw...@redhat.com wrote: These printfs aren't really debug messages, but clearly indicate a bug if they ever become effective. Then we have a bug somewhere, starting a VM with: # qemu -hda

Re: [Qemu-devel] [PATCH v6 0/4] rbd improvements

2011-05-27 Thread Kevin Wolf
Am 27.05.2011 01:07, schrieb Josh Durgin: This patchset moves the complexity of the rbd format into librbd and adds truncation support. Changes since v5: * compare full string, not prefix, with conf in 2/4 * when truncate fails, just return librbd's error Changes since v4: * fixed

Re: [Qemu-devel] [PATCH 5/6] Do constant folding for shift operations.

2011-05-27 Thread Paolo Bonzini
On 05/26/2011 09:14 PM, Blue Swirl wrote: x = (int32_t)x (int32_t)y; This expression has an implementation-defined behavior accroding to C99 6.5.7 so we decided to emulate signed shifts by hand. Technically, yes. In practice, no. GCC, ICC, LLVM, MSVC all know what the user

Re: [Qemu-devel] [PATCH] host-pcc: enable building with -m32 or -m64

2011-05-27 Thread Paolo Bonzini
On 05/26/2011 09:00 PM, Stefan Berger wrote: With the below patch I can build either ppc (-m32) or ppc64 (-m64) versions of Qemu (on a ppc64 host) when passing these compiler flags via 'configure ... --extra-cflags=-m32'. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- configure |

[Qemu-devel] KVM guest doesn't recongize its network with NAT mode

2011-05-27 Thread Ryan Wang
Hi all, I created one guest on Ubuntu 10.10 using the following command: (using default network) = sudo virt-install --connect qemu:///system -n ubuntu-10.10-guest -r 1024 --vcpus=1 -c /tmp/ubuntu-10.10-desktop-i386.iso --os-type=linux

Re: [Qemu-devel] [PATCH v5 01/25] scsi: add tracing of scsi requests

2011-05-27 Thread Stefan Hajnoczi
On Thu, May 26, 2011 at 9:20 PM, Blue Swirl blauwir...@gmail.com wrote: On Thu, May 26, 2011 at 1:56 PM, Paolo Bonzini pbonz...@redhat.com wrote: Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Christoph Hellwig h...@lst.de ---  hw/scsi-bus.c |    6 ++  trace-events  |    6

Re: [Qemu-devel] [PATCH 00/12] target-s390x: Several small fixes

2011-05-27 Thread Alexander Graf
On 27.05.2011, at 06:59, Stefan Weil wrote: Am 26.05.2011 23:48, schrieb Andreas Färber: Am 26.05.2011 um 00:17 schrieb Alexander Graf: On 26.05.2011, at 00:10, Peter Maydell wrote: On 25 May 2011 21:25, Stefan Weil w...@mail.berlios.de wrote: Feel free to combine patches if larger

Re: [Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in configure

2011-05-27 Thread Marc-Antoine Perennou
Any chance to get this reviewed/applied any time soon ? It currently does not build without it with gcc 4.6.0 On 29 April 2011 17:59, Marc-Antoine Perennou marc-anto...@perennou.com wrote: pulse/simple.h does not include stdlib.h We cannot use NULL since it may not be defined Use 0 instead

[Qemu-devel] [PATCH] blockdbg: Fix Bottom Half deletion

2011-05-27 Thread Kevin Wolf
You can only delete a BH in its BH handler if you don't call a nested qemu_bh_poll afterwards (the nested one would free the BH and the outer one segfaults when returning from the BH handler). To avoid this situation, first call the callback and only then delete the BH. Signed-off-by: Kevin Wolf

[Qemu-devel] [PULL] virtio-serial updates

2011-05-27 Thread Amit Shah
Hello, Please pull to get virtio-serial cleanups from Markus and a move to bh for flushing out throttled data from Alon. (git mirror might take some time to sync). The following changes since commit aa29141d84d58171c2d219f0a4b599bd76fb2e37: Merge remote-tracking branch 'kraxel/CVE-2011-1751'

Re: [Qemu-devel] [PATCH] Fix a number of unused-but-set-variable warnings (new with gcc-4.6)

2011-05-27 Thread Amit Shah
On (Tue) 03 May 2011 [13:03:40], Hans de Goede wrote: --- target-i386/kvm.c |4 ++-- tcg/tcg.c |4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) Thanks; just got hit by this. However, there are a couple of whitespace issues: --- a/tcg/tcg.c +++ b/tcg/tcg.c @@

[Qemu-devel] [PATCH] qemu-iotest: test 005, don't run on raw

2011-05-27 Thread Feiran Zheng
Patch on qemu-iotest. 005, test of creating 5TB images, not practical on raw format, so not run on it. Signed-off-by: Fam Zheng famc...@gmail.com --- 005 |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/005 b/005 index 74537db..e086b6f 100755 --- a/005 +++ b/005 @@

Re: [Qemu-devel] [PATCH] qemu-iotest: test 005, don't run on raw

2011-05-27 Thread Christoph Hellwig
On Fri, May 27, 2011 at 06:45:03PM +0800, Feiran Zheng wrote: Patch on qemu-iotest. 005, test of creating 5TB images, not practical on raw format, so not run on it. It's perfectly fine on raw, just try it.

Re: [Qemu-devel] [PATCH] qemu-iotest: test 005, don't run on raw

2011-05-27 Thread Feiran Zheng
Does this mean one must have that large fs space? On Fri, May 27, 2011 at 6:47 PM, Christoph Hellwig h...@lst.de wrote: On Fri, May 27, 2011 at 06:45:03PM +0800, Feiran Zheng wrote: Patch on qemu-iotest. 005, test of creating 5TB images, not practical on raw format, so not run on it. It's

Re: [Qemu-devel] [PATCH] qemu-iotest: test 005, don't run on raw

2011-05-27 Thread Christoph Hellwig
On Fri, May 27, 2011 at 06:48:49PM +0800, Feiran Zheng wrote: Does this mean one must have that large fs space? No.

Re: [Qemu-devel] block bug: tray status is not updated (and/or guest ignores it)

2011-05-27 Thread Amit Shah
On (Thu) 26 May 2011 [15:29:29], Luiz Capitulino wrote: I'm testing with qemu.git (HEAD aa29141d84d), procedure: 1. Start a VM with: # qemu -hda disks/test.img -enable-kvm -m 1G -cdrom Fedora-14-x86_64-DVD.iso 2. Then inside the guest run: # eject /dev/sr0 mount /dev/sr0 /mnt

Re: [Qemu-devel] block bug: tray status is not updated (and/or guest ignores it)

2011-05-27 Thread Amit Shah
On (Fri) 27 May 2011 [17:01:35], Amit Shah wrote: On (Thu) 26 May 2011 [15:29:29], Luiz Capitulino wrote: I'm testing with qemu.git (HEAD aa29141d84d), procedure: 1. Start a VM with: # qemu -hda disks/test.img -enable-kvm -m 1G -cdrom Fedora-14-x86_64-DVD.iso 2. Then

[Qemu-devel] [PATCH 1/2] tcg/tcg-op.h: Fix prototypes for ld/st functions on 64 bit hosts

2011-05-27 Thread Peter Maydell
The prototypes for the ld/st functions on a 64 bit host declared the address parameter as a TCGv_i64 rather than a TCGv_ptr. This worked OK (since the two are aliases), but needs to be fixed to allow extension of TCG type debugging to i64/i32/ptr mismatches. Signed-off-by: Peter Maydell

[Qemu-devel] [PATCH 2/2] tcg: If DEBUG_TCGV, distinguish TCGv_ptr from TCGv_i32/TCGv_i64

2011-05-27 Thread Peter Maydell
When compiling with DEBUG_TCGV enabled, make the TCGv_ptr type distinct from TCGv_i32/TCGv_i64. This means that using an i32 or i64 TCG op to manipulate a TCGv_ptr will always be detected at compile time, rather than only if compiling on a host system with the other word size. NB: the tcg_add_ptr

[Qemu-devel] [PATCH 0/2] tcg: If DEBUG_TCGV, distinguish TCGv_ptr from TCGv_i32/TCGv_i64

2011-05-27 Thread Peter Maydell
This patch series enhances the type checking of TCG values done when compiling with debugging enabled, so that it can detect confusion of TCGv_ptr values with whichever of TCGv_i32 and TCGv_i64 corresponds to the pointer-width type on the compile host. This means that such errors will always be

Re: [Qemu-devel] block bug: tray status is not updated (and/or guest ignores it)

2011-05-27 Thread Amit Shah
On (Fri) 27 May 2011 [17:04:30], Amit Shah wrote: On (Fri) 27 May 2011 [17:01:35], Amit Shah wrote: On (Thu) 26 May 2011 [15:29:29], Luiz Capitulino wrote: I'm testing with qemu.git (HEAD aa29141d84d), procedure: 1. Start a VM with: # qemu -hda disks/test.img -enable-kvm

Re: [Qemu-devel] [PATCH v5 01/25] scsi: add tracing of scsi requests

2011-05-27 Thread Paolo Bonzini
On 05/27/2011 10:32 AM, Stefan Hajnoczi wrote: Either you can eliminate an argument from this trace event or you could extend the record size (and bump the version header). The LBA argument isn't always present, so I'll split the event in two. I pushed the result to scsi.3 and I'll post the 3

[Qemu-devel] [PATCH v6 01/25] scsi: add tracing of scsi requests

2011-05-27 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Christoph Hellwig h...@lst.de Cc: Blue Swirl blauwir...@gmail.com --- hw/scsi-bus.c | 10 ++ trace-events |7 +++ 2 files changed, 17 insertions(+), 0 deletions(-) diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c index

[Qemu-devel] [PATCH v6 16/25] scsi: introduce scsi_req_continue

2011-05-27 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com Cc: Blue Swirl blauwir...@gmail.com --- hw/esp.c | 26 ++ hw/lsi53c895a.c | 22 -- hw/scsi-bus.c| 16 +--- hw/scsi.h|1 + hw/spapr_vscsi.c | 26

[Qemu-devel] [PATCH v6 03/25] scsi: introduce scsi_req_data

2011-05-27 Thread Paolo Bonzini
This abstracts calling the command_complete callback, reducing churn in the following patches. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Christoph Hellwig h...@lst.de Cc: Blue Swirl blauwir...@gmail.com --- hw/scsi-bus.c | 11 +++ hw/scsi-disk.c|8

Re: [Qemu-devel] Booting custom kernel in qemu

2011-05-27 Thread Amit Shah
On (Thu) 26 May 2011 [21:59:01], Apelete Seketeli wrote: Hello, I'm trying to boot a custom linux kernel in qemu, and I plan to contribute the necessary work to make it work (this is the first step I'm taking to add OS support in qemu). I'm totally new to qemu, and I haven't found enough

Re: [Qemu-devel] [RFC PATCH 3/6] scsi-generic: allow customization of the lun

2011-05-27 Thread Christoph Hellwig
On Wed, May 25, 2011 at 05:20:59PM +0200, Paolo Bonzini wrote: I agree. This case of INQUIRY is needed because (for simplicity and backwards compatibility) you can hang a scsi-disk or scsi-generic device directly off the HBA, without the intermediate pseudo-device that handles dispatching

Re: [Qemu-devel] [PATCH 05/18] ide: Turn debug messages into assertions

2011-05-27 Thread Luiz Capitulino
On Fri, 27 May 2011 08:39:05 +0200 Kevin Wolf kw...@redhat.com wrote: Am 26.05.2011 23:12, schrieb Luiz Capitulino: On Thu, 19 May 2011 14:33:19 +0200 Kevin Wolf kw...@redhat.com wrote: These printfs aren't really debug messages, but clearly indicate a bug if they ever become

Re: [Qemu-devel] [RFC PATCH 3/6] scsi-generic: allow customization of the lun

2011-05-27 Thread Paolo Bonzini
On 05/27/2011 03:04 PM, Christoph Hellwig wrote: Requiring this code in the scsi drivers is a really bad idea. Not only does it mean duplicating the implementation of REPORT LUNS and the illegal LUN version of INQUIRY in every scsi LUN handler and the target driver, but also an inconsitent

Re: [Qemu-devel] block bug: tray status is not updated (and/or guest ignores it)

2011-05-27 Thread Luiz Capitulino
On Fri, 27 May 2011 18:10:08 +0530 Amit Shah amit.s...@redhat.com wrote: On (Fri) 27 May 2011 [17:04:30], Amit Shah wrote: On (Fri) 27 May 2011 [17:01:35], Amit Shah wrote: On (Thu) 26 May 2011 [15:29:29], Luiz Capitulino wrote: I'm testing with qemu.git (HEAD aa29141d84d),

Re: [Qemu-devel] block bug: tray status is not updated (and/or guest ignores it)

2011-05-27 Thread Daniel P. Berrange
On Fri, May 27, 2011 at 10:39:35AM -0300, Luiz Capitulino wrote: On Fri, 27 May 2011 18:10:08 +0530 Amit Shah amit.s...@redhat.com wrote: On (Fri) 27 May 2011 [17:04:30], Amit Shah wrote: On (Fri) 27 May 2011 [17:01:35], Amit Shah wrote: On (Thu) 26 May 2011 [15:29:29], Luiz

Re: [Qemu-devel] [PATCH 0/3]: QMP: Introduce inject-nmi command

2011-05-27 Thread Luiz Capitulino
On Thu, 26 May 2011 22:23:10 +0300 Blue Swirl blauwir...@gmail.com wrote: On Thu, May 26, 2011 at 8:25 PM, Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Fri, 6 May 2011 18:36:31 +0300 Blue Swirl blauwir...@gmail.com wrote: On Fri, May 6,

Re: [Qemu-devel] Please help!

2011-05-27 Thread Lluís
Guan, Qiang writes: Where can I find the codes for monitor command log in_asm. This just sets the loglevel mask. I want to know how QEMU monitor capture the executed instruction in ASM in a simultaneous way rather than a bunch of Logs. Look for references to CPULOG_TB_IN_ASM, which is the

Re: [Qemu-devel] Multi heterogenous CPU archs for SoC sim?

2011-05-27 Thread Lluís
Blue Swirl writes: On Thu, May 26, 2011 at 11:07 PM, Lluís xscr...@gmx.net wrote: Nicely handling per-arch functions would be one of the benefits of using C++ in QEMU (I know, it's sufficient but not necessary). What were the conclusions regarding such a change? I don't think the

Re: [Qemu-devel] block bug: tray status is not updated (and/or guest ignores it)

2011-05-27 Thread Markus Armbruster
Amit Shah amit.s...@redhat.com writes: [...] What's weird though is 'eject' in the monitor makes the cdrom go away -- a subsequent mount in the guest results in a no medium error. I thought we had solved that, Markus? You fell into QEMU's let's overload names until everybody's hopelessly

Re: [Qemu-devel] block bug: tray status is not updated (and/or guest ignores it)

2011-05-27 Thread Markus Armbruster
Daniel P. Berrange berra...@redhat.com writes: On Fri, May 27, 2011 at 10:39:35AM -0300, Luiz Capitulino wrote: On Fri, 27 May 2011 18:10:08 +0530 Amit Shah amit.s...@redhat.com wrote: [...] What's weird though is 'eject' in the monitor makes the cdrom go away -- a subsequent mount in the

Re: [Qemu-devel] [PATCH 0/3]: QMP: Introduce inject-nmi command

2011-05-27 Thread Anthony Liguori
On 05/27/2011 09:04 AM, Luiz Capitulino wrote: On Thu, 26 May 2011 22:23:10 +0300 Blue Swirlblauwir...@gmail.com wrote: On Thu, May 26, 2011 at 8:25 PM, Markus Armbrusterarm...@redhat.com wrote: Luiz Capitulinolcapitul...@redhat.com writes: On Fri, 6 May 2011 18:36:31 +0300 Blue

Re: [Qemu-devel] [PATCH] target-i386: GPF on invalid MSRs

2011-05-27 Thread Alexander Graf
On 27.05.2011, at 17:13, Josh Triplett wrote: On Thu, May 26, 2011 at 11:12:12AM +0200, Alexander Graf wrote: On 26.05.2011, at 11:08, Josh Triplett wrote: qemu currently returns 0 for rdmsr on invalid MSRs, and ignores wrmsr on invalid MSRs. Real x86 processors GPF on invalid MSRs, which

Re: [Qemu-devel] [PATCH 5/6] Do constant folding for shift operations.

2011-05-27 Thread Jamie Lokier
Richard Henderson wrote: On 05/26/2011 01:25 PM, Blue Swirl wrote: I don't see the point. The C99 implementation defined escape hatch exists for weird cpus. Which we won't be supporting as a QEMU host. Maybe not, but a compiler with this property could arrive. For example, GCC

Re: [Qemu-devel] [PATCH 0/3]: QMP: Introduce inject-nmi command

2011-05-27 Thread Luiz Capitulino
On Fri, 27 May 2011 09:55:05 -0500 Anthony Liguori anth...@codemonkey.ws wrote: On 05/27/2011 09:04 AM, Luiz Capitulino wrote: On Thu, 26 May 2011 22:23:10 +0300 Blue Swirlblauwir...@gmail.com wrote: On Thu, May 26, 2011 at 8:25 PM, Markus Armbrusterarm...@redhat.com wrote: Luiz

Re: [Qemu-devel] [PATCH] target-i386: GPF on invalid MSRs

2011-05-27 Thread Josh Triplett
On Fri, May 27, 2011 at 05:16:56PM +0200, Alexander Graf wrote: On 27.05.2011, at 17:13, Josh Triplett wrote: On Thu, May 26, 2011 at 11:12:12AM +0200, Alexander Graf wrote: On 26.05.2011, at 11:08, Josh Triplett wrote: qemu currently returns 0 for rdmsr on invalid MSRs, and ignores

[Qemu-devel] [PATCH v2 2/2] [SPARC] Fix TA0_Shutdown feature

2011-05-27 Thread Julien Grall
Hello, Since the last patch, I have added a special helper for trap 0. It will be use when the TA0_Shutdown feature is enabled. Signed-off-by: Grall Julien julien.gr...@gmail.com --- target-sparc/helper.h|1 + target-sparc/op_helper.c | 14 ++ target-sparc/translate.c |

Re: [Qemu-devel] [PATCH 0/3]: QMP: Introduce inject-nmi command

2011-05-27 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: On Fri, 27 May 2011 09:55:05 -0500 Anthony Liguori anth...@codemonkey.ws wrote: On 05/27/2011 09:04 AM, Luiz Capitulino wrote: On Thu, 26 May 2011 22:23:10 +0300 Blue Swirlblauwir...@gmail.com wrote: I think I explained it many times,

Re: [Qemu-devel] [RFC] live snapshot, live merge, live block migration

2011-05-27 Thread Stefan Hajnoczi
On Mon, May 23, 2011 at 2:02 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Sun, May 22, 2011 at 10:52 AM, Dor Laor dl...@redhat.com wrote: On 05/20/2011 03:19 PM, Stefan Hajnoczi wrote: I'm interested in what the API for snapshots would look like. Specifically how does user software do the

[Qemu-devel] [PATCH v2 03/12] target-s390x: Add missing tcg_temp_free_i64() in gen_jcc()

2011-05-27 Thread Stefan Weil
Signed-off-by: Stefan Weil w...@mail.berlios.de --- target-s390x/translate.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/target-s390x/translate.c b/target-s390x/translate.c index 141a72f..6ec77ec 100644 --- a/target-s390x/translate.c +++ b/target-s390x/translate.c @@

[Qemu-devel] [PATCH v2 00/12] target-s390x: Several small fixes

2011-05-27 Thread Stefan Weil
This is an update of my last patch series. Modifications in v2: * Changed 01/12 to create more efficient code. * Modified subject lines of 03/12 up to 11/12 so there are no duplicates. Regards, Stefan W. [PATCH v2 01/12] target-s390x: Fix wrong argument in call of tcg_gen_shl_i64() [PATCH v2

[Qemu-devel] [PATCH v2 12/12] target-s390x: Add missing tcg_temp_free_i32()

2011-05-27 Thread Stefan Weil
Signed-off-by: Stefan Weil w...@mail.berlios.de --- target-s390x/translate.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/target-s390x/translate.c b/target-s390x/translate.c index 6664ab5..0269970 100644 --- a/target-s390x/translate.c +++ b/target-s390x/translate.c

[Qemu-devel] [PATCH v2 08/12] target-s390x: Add missing tcg_temp_free_i64() in disas_a5(), opc == 0x8

2011-05-27 Thread Stefan Weil
load_reg() needs a matching tcg_temp_free_i64(). Signed-off-by: Stefan Weil w...@mail.berlios.de --- target-s390x/translate.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/target-s390x/translate.c b/target-s390x/translate.c index 81b8c5b..692de6e 100644 ---

[Qemu-devel] [PATCH v2 01/12] target-s390x: Fix wrong argument in call of tcg_gen_shl_i64()

2011-05-27 Thread Stefan Weil
tcg_gen_shl_i64 needs a 3rd argument of type TCGv_i64. Set tmp4 so it can be used here. v2: Don't call tcg_const_i64() inside of the loop because it creates additional code. Signed-off-by: Stefan Weil w...@mail.berlios.de --- target-s390x/translate.c |4 ++-- 1 files changed, 2

[Qemu-devel] [PATCH v2 05/12] target-s390x: Add missing tcg_temp_free_i64() in disas_b2()

2011-05-27 Thread Stefan Weil
Signed-off-by: Stefan Weil w...@mail.berlios.de --- target-s390x/translate.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/target-s390x/translate.c b/target-s390x/translate.c index a11cb19..f3f42a9 100644 --- a/target-s390x/translate.c +++ b/target-s390x/translate.c @@

[Qemu-devel] [PATCH v2 09/12] target-s390x: Add missing tcg_temp_free_i64() in disas_a5(), opc == 0x9

2011-05-27 Thread Stefan Weil
load_reg() needs a matching tcg_temp_free_i64(). Signed-off-by: Stefan Weil w...@mail.berlios.de --- target-s390x/translate.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/target-s390x/translate.c b/target-s390x/translate.c index 692de6e..705fe2b 100644 ---

[Qemu-devel] [PATCH v2 06/12] target-s390x: Add missing tcg_temp_free_i64() in disas_s390_insn(), opc == 0x8e

2011-05-27 Thread Stefan Weil
Signed-off-by: Stefan Weil w...@mail.berlios.de --- target-s390x/translate.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/target-s390x/translate.c b/target-s390x/translate.c index f3f42a9..c5a3930 100644 --- a/target-s390x/translate.c +++ b/target-s390x/translate.c @@

[Qemu-devel] [PATCH v2 10/12] target-s390x: Add missing tcg_temp_free_i64() in disas_a5(), opc == 0xa

2011-05-27 Thread Stefan Weil
load_reg() needs a matching tcg_temp_free_i64(). Signed-off-by: Stefan Weil w...@mail.berlios.de --- target-s390x/translate.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/target-s390x/translate.c b/target-s390x/translate.c index 705fe2b..4f4b893 100644 ---

[Qemu-devel] [PATCH v2 07/12] target-s390x: Add missing tcg_temp_free_i64() in disas_s390_insn(), opc == 0x90

2011-05-27 Thread Stefan Weil
Signed-off-by: Stefan Weil w...@mail.berlios.de --- target-s390x/translate.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/target-s390x/translate.c b/target-s390x/translate.c index c5a3930..81b8c5b 100644 --- a/target-s390x/translate.c +++ b/target-s390x/translate.c @@

[Qemu-devel] [PATCH v2 02/12] target-s390x: Fix duplicate call of tcg_temp_new_i64

2011-05-27 Thread Stefan Weil
tmp2 = tcg_temp_new_i64() is already executed unconditionally, so there is no need to call it a second time for 64 bit hosts. Signed-off-by: Stefan Weil w...@mail.berlios.de --- target-s390x/translate.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 5/6] Do constant folding for shift operations.

2011-05-27 Thread Blue Swirl
On Fri, May 27, 2011 at 12:14 AM, Richard Henderson r...@twiddle.net wrote: On 05/26/2011 01:25 PM, Blue Swirl wrote: I don't see the point.  The C99 implementation defined escape hatch exists for weird cpus.  Which we won't be supporting as a QEMU host. Maybe not, but a compiler with this

[Qemu-devel] [PATCH v2 11/12] target-s390x: Add missing tcg_temp_free_i64() in disas_a5(), opc == 0xb

2011-05-27 Thread Stefan Weil
load_reg() needs a matching tcg_temp_free_i64(). Signed-off-by: Stefan Weil w...@mail.berlios.de --- target-s390x/translate.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/target-s390x/translate.c b/target-s390x/translate.c index 4f4b893..6664ab5 100644 ---

Re: [Qemu-devel] [RFC] live snapshot, live merge, live block migration

2011-05-27 Thread Jagane Sundar
On 5/27/2011 9:46 AM, Stefan Hajnoczi wrote: On Mon, May 23, 2011 at 2:02 PM, Stefan Hajnoczistefa...@gmail.com wrote: On Sun, May 22, 2011 at 10:52 AM, Dor Laordl...@redhat.com wrote: On 05/20/2011 03:19 PM, Stefan Hajnoczi wrote: I'm interested in what the API for snapshots would look

Re: [Qemu-devel] [PATCH 0/3]: QMP: Introduce inject-nmi command

2011-05-27 Thread Blue Swirl
On Fri, May 27, 2011 at 5:55 PM, Anthony Liguori anth...@codemonkey.ws wrote: On 05/27/2011 09:04 AM, Luiz Capitulino wrote: On Thu, 26 May 2011 22:23:10 +0300 Blue Swirlblauwir...@gmail.com  wrote: On Thu, May 26, 2011 at 8:25 PM, Markus Armbrusterarm...@redhat.com  wrote: Luiz

Re: [Qemu-devel] [PATCH v2 2/2] [SPARC] Fix TA0_Shutdown feature

2011-05-27 Thread Blue Swirl
On Fri, May 27, 2011 at 7:25 PM, Julien Grall julien.gr...@gmail.com wrote: Hello, Since the last patch, I have added a special helper for trap 0. It will be use when the TA0_Shutdown feature is enabled. This patch looks OK now. Signed-off-by: Grall Julien julien.gr...@gmail.com ---  

[Qemu-devel] [PATCH 0/6] Fix compilation issues under darwin

2011-05-27 Thread Alexandre Raymond
Hello everyone, The following series contains trivial patches to fix several minor issues encountered while compiling qemu under OSX 10.6.7. I used [./configure --disable-bsd-user --disable-darwin-user --enable-io-thread] to configure the build. Cheers, Alexandre Alexandre Raymond (6): Fix

[Qemu-devel] [PATCH 1/6] Fix incorrect check for fdatasync() in configure

2011-05-27 Thread Alexandre Raymond
For some reason, darwin provides a symbol for fdatasync(), but doesn't officially support it. The manpage for fdatasync on Linux states the following: On POSIX systems on which fdatasync() is available, _POSIX_SYNCHRONIZED_IO is defined in unistd.h to a value greater than 0. In fact,

[Qemu-devel] [PATCH 2/6] Cocoa: avoid displaying window when command-line contains '-h'

2011-05-27 Thread Alexandre Raymond
There was already a check in place to avoid displaying a window in certain modes such as vnc, nographic or curses. Add a check for '-h' to avoid displaying a window for a split- second before showing the usage information. Signed-off-by: Alexandre Raymond cerb...@gmail.com --- ui/cocoa.m |3

[Qemu-devel] [PATCH 5/6] Remove warning in printf due to type mismatch

2011-05-27 Thread Alexandre Raymond
8 qemu/target-lm32/translate.c: In function ‘gen_intermediate_code_internal’: qemu/target-lm32/translate.c:1135: warning: format ‘%zd’ expects type ‘signed size_t’, but argument 4 has type ‘int’ 8 Both gen_opc_ptr and gen_opc_buf are uint16_t *, so a simple '%d' should be able to

[Qemu-devel] [PATCH 3/6] Fix compilation warning due to incorrectly specified type

2011-05-27 Thread Alexandre Raymond
In audio/coreaudio.c, a variable named str was assigned const char values, which resulted in the following warnings: -8- audio/coreaudio.c: In function ‘coreaudio_logstatus’: audio/coreaudio.c:59: warning: initialization discards qualifiers from pointer target type audio/coreaudio.c:63:

[Qemu-devel] [PATCH 4/6] Fix missing prototype under cocoa for qemu_main

2011-05-27 Thread Alexandre Raymond
The following error message was encountered when compiling with cocoa support because qemu_main did not have a prototype. -8- qemu/vl.c:2037: warning: no previous prototype for ‘qemu_main’ -8- Add its prototype in the COCOA ifdef, similar to what is done for SDL. Signed-off-by:

[Qemu-devel] [PATCH 6/6] Avoid compilation warning regarding kvm under darwin

2011-05-27 Thread Alexandre Raymond
8 qemu/target-s390x/helper.c:32:23: warning: linux/kvm.h: No such file or director 8 kvm.h, which is included right after this line, already includes linux/kvm.h with the proper CONFIG_KVM guard. Remove redundant include. Signed-off-by: Alexandre Raymond cerb...@gmail.com ---

Re: [Qemu-devel] [PATCH 1/2][SPARC] Improve sparc handling of ta

2011-05-27 Thread Blue Swirl
On Tue, May 17, 2011 at 6:32 PM, Julien Grall julien.gr...@gmail.com wrote: Improve sparc handling of ta Signed-off-by: Julien Grall julien.gr...@gmail.com ---  target-sparc/helper.h    |    1 +  target-sparc/op_helper.c |    6 ++  target-sparc/translate.c |    7 ---  3 files

Re: [Qemu-devel] [patch 1/7] add migration_active function

2011-05-27 Thread Kevin Wolf
Am 23.05.2011 23:31, schrieb Marcelo Tosatti: To query whether migration is active. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Index: qemu-block-copy/migration.c === --- qemu-block-copy.orig/migration.c +++

Re: [Qemu-devel] [PATCH 3/6] Fix compilation warning due to incorrectly specified type

2011-05-27 Thread Stefan Weil
Am 27.05.2011 19:22, schrieb Alexandre Raymond: In audio/coreaudio.c, a variable named str was assigned const char values, which resulted in the following warnings: -8- audio/coreaudio.c: In function ‘coreaudio_logstatus’: audio/coreaudio.c:59: warning: initialization discards

Re: [Qemu-devel] [patch 2/7] Add blkmirror block driver

2011-05-27 Thread Kevin Wolf
Am 23.05.2011 23:31, schrieb Marcelo Tosatti: Mirrored writes are used by live block copy. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Index: qemu-block-copy/block/blkmirror.c === --- /dev/null +++

Re: [Qemu-devel] [PATCH 6/6] Avoid compilation warning regarding kvm under darwin

2011-05-27 Thread Stefan Weil
Am 27.05.2011 19:22, schrieb Alexandre Raymond: 8 qemu/target-s390x/helper.c:32:23: warning: linux/kvm.h: No such file or director 8 kvm.h, which is included right after this line, already includes linux/kvm.h with the proper CONFIG_KVM guard. Remove redundant include.

Re: [Qemu-devel] [PATCH 5/6] Remove warning in printf due to type mismatch

2011-05-27 Thread Stefan Weil
Am 27.05.2011 19:22, schrieb Alexandre Raymond: 8 qemu/target-lm32/translate.c: In function ‘gen_intermediate_code_internal’: qemu/target-lm32/translate.c:1135: warning: format ‘%zd’ expects type ‘signed size_t’, but argument 4 has type ‘int’ 8 Both gen_opc_ptr and

Re: [Qemu-devel] block bug: tray status is not updated (and/or guest ignores it)

2011-05-27 Thread Daniel P. Berrange
On Fri, May 27, 2011 at 04:35:24PM +0200, Markus Armbruster wrote: Daniel P. Berrange berra...@redhat.com writes: On Fri, May 27, 2011 at 10:39:35AM -0300, Luiz Capitulino wrote: On Fri, 27 May 2011 18:10:08 +0530 Amit Shah amit.s...@redhat.com wrote: [...] What's weird though is

Re: [Qemu-devel] [PATCH v3] virtio-9p: Use relative includes for files in hw

2011-05-27 Thread Stefan Weil
Am 29.04.2011 02:46, schrieb Peter Maydell: On 28 April 2011 21:49, Anthony Liguorianth...@codemonkey.ws wrote: On 04/28/2011 03:02 PM, Stefan Weil wrote: -$(addprefix 9pfs/, $(9pfs-nested-y)): CFLAGS += -I$(SRC_PATH)/hw/ Wouldn't it be more straight forward to just do

Re: [Qemu-devel] [PATCH] block/rbd: Remove unused local variable

2011-05-27 Thread Stefan Weil
Am 23.05.2011 12:26, schrieb Kevin Wolf: Am 23.05.2011 11:01, schrieb Christian Brunner: 2011/5/22 Stefan Weil w...@mail.berlios.de: Am 07.05.2011 22:15, schrieb Stefan Weil: cppcheck report: rbd.c:246: style: Variable 'snap' is assigned a value that is never used Remove snap and the

Re: [Qemu-devel] [PATCH 5/6] Remove warning in printf due to type mismatch

2011-05-27 Thread Markus Armbruster
Stefan Weil w...@mail.berlios.de writes: Am 27.05.2011 19:22, schrieb Alexandre Raymond: 8 qemu/target-lm32/translate.c: In function ‘gen_intermediate_code_internal’: qemu/target-lm32/translate.c:1135: warning: format ‘%zd’ expects type ‘signed size_t’, but argument 4 has type ‘int’

[Qemu-devel] [PATCH 0/3]: QMP: Introduce the BLOCK_MEDIA_EJECT event

2011-05-27 Thread Luiz Capitulino
The motivation for this event is that clients can get confused if removable media is ejected by the guest (or by a human user). You'll find detailed documentation in patch 2/3 and the actual implementation in patch 3/3. Thanks. QMP/qmp-events.txt | 18 ++ block.c|

[Qemu-devel] [PATCH 3/3] QMP: Introduce the BLOCK_MEDIA_EJECT event

2011-05-27 Thread Luiz Capitulino
Conforms to the event specification defined in the QMP/qmp-events.txt file. Please, note the following details: o The event should be emitted only by devices which support the eject operation, which currently are: CDROMs (IDE and SCSI) and floppies o Human monitor commands eject and

[Qemu-devel] [PATCH 1/3] block: Rename bdrv_mon_event()

2011-05-27 Thread Luiz Capitulino
Rename it to bdrv_error_mon_event() in order to better communicate its purpose. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- block.c |4 ++-- block.h |4 ++-- hw/ide/core.c |6 +++--- hw/scsi-disk.c |6 +++--- hw/virtio-blk.c |6 +++--- 5 files

[Qemu-devel] [PATCH 2/3] QMP: Add BLOCK_MEDIA_EJECT event documentation

2011-05-27 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- QMP/qmp-events.txt | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt index 0ce5d4e..d53c129 100644 --- a/QMP/qmp-events.txt +++ b/QMP/qmp-events.txt @@ -1,6

Re: [Qemu-devel] [PATCH 5/6] Do constant folding for shift operations.

2011-05-27 Thread Richard Henderson
On 05/27/2011 10:07 AM, Blue Swirl wrote: The C99 hook exists to efficiently support targets that don't have arithmetic shift operations. Honestly. So it would be impossible for a compiler developer to change the logic for shifts for some supported two's-complement logic CPUs (like x86)

Re: [Qemu-devel] [PULL 00/26] Alpha system emulation, v5

2011-05-27 Thread Richard Henderson
Ping? r~ On 05/23/2011 01:28 PM, Richard Henderson wrote: Changes from v4 - v5 * Claim official ownership of the Alpha port, rather than leave it as unmaintained. * Drop all the patches in hw/ for now. While they're necessary to actually make the port work, these are the

Re: [Qemu-devel] [PATCH 5/6] Remove warning in printf due to type mismatch

2011-05-27 Thread Stefan Weil
Am 27.05.2011 21:11, schrieb Markus Armbruster: Stefan Weil w...@mail.berlios.de writes: Am 27.05.2011 19:22, schrieb Alexandre Raymond: 8 qemu/target-lm32/translate.c: In function ‘gen_intermediate_code_internal’: qemu/target-lm32/translate.c:1135: warning: format ‘%zd’ expects type

Re: [Qemu-devel] [PATCH] block/rbd: Remove unused local variable

2011-05-27 Thread Christian Brunner
2011/5/27 Stefan Weil w...@mail.berlios.de: Am 23.05.2011 12:26, schrieb Kevin Wolf: Am 23.05.2011 11:01, schrieb Christian Brunner: 2011/5/22 Stefan Weil w...@mail.berlios.de: Am 07.05.2011 22:15, schrieb Stefan Weil: cppcheck report: rbd.c:246: style: Variable 'snap' is assigned a

Re: [Qemu-devel] [PATCH 5/6] Remove warning in printf due to type mismatch

2011-05-27 Thread Alexandre Raymond
Hi Stefan and Markus, Thanks for your feedback :) %td doesn't generate warnings on Linux nor on OSX. Alexandre On Fri, May 27, 2011 at 4:44 PM, Stefan Weil w...@mail.berlios.de wrote: Am 27.05.2011 21:11, schrieb Markus Armbruster: Stefan Weil w...@mail.berlios.de writes: Am 27.05.2011

Re: [Qemu-devel] [PATCH] xen: fix interrupt routing

2011-05-27 Thread Alexander Graf
On 26.05.2011, at 17:48, Stefano Stabellini wrote: xen: fix interrupt routing - remove i440FX-xen and i440fx_write_config_xen we don't need to intercept pci config writes to i440FX anymore; Why not? In which version? Did anything below change? What about compat code? Older hypervisor

Re: [Qemu-devel] [PATCH v2 0/5] xen mapcache fixes and improvements

2011-05-27 Thread Alexander Graf
On 19.05.2011, at 19:34, Stefano Stabellini wrote: Hi all, this patch series introduces a series of fixes and improvements to the xen mapcache in qemu. Changes compared to v1: - remove the two includes from xen-mapcache.h. Thanks, applied to xen-next. Alex

Re: [Qemu-devel] [PATCH v2 08/12] target-s390x: Add missing tcg_temp_free_i64() in disas_a5(), opc == 0x8

2011-05-27 Thread Alexander Graf
On 27.05.2011, at 19:03, Stefan Weil wrote: load_reg() needs a matching tcg_temp_free_i64(). Signed-off-by: Stefan Weil w...@mail.berlios.de --- target-s390x/translate.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/target-s390x/translate.c

[Qemu-devel] [PATCH] s390x: free tmp explicitly in every opcode for disas_a5()

2011-05-27 Thread Alexander Graf
The disas_a5() function provided a TCG tmp variable which was populated by the respective opcode implementations, but freed at the end of the function in generic code. That makes it really hard for code review, so let's move the freeing to the same scope as the actual allocation. Signed-off-by:

[Qemu-devel] [PATCH] PPC: install mpc8544ds.dtb

2011-05-27 Thread Alexander Graf
We don't install mpc8544ds.dtb, which means that -M mpc8544ds doesn't work when installed. Fix it by installing the file. Signed-off-by: Alexander Graf ag...@suse.de --- Makefile |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/Makefile b/Makefile index 2b0438c..b6466e7

[Qemu-devel] [PATCH] Fix segfault on screendump with -nographic

2011-05-27 Thread Alexander Graf
When running -nographic and calling screendump on the monitor, qemu segfaults. Fix the invalid pointer dereference by checking for NULL. Signed-off-by: Alexander Graf ag...@suse.de --- console.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/console.c b/console.c index

[Qemu-devel] [PATCH] PPC: fix mpc8544ds pci default devices

2011-05-27 Thread Alexander Graf
After the Qdev'ification of the MPC8544DS board and PCI bus, the internal PCI bus name changed from pci to pci.0. Reflect this change in the search for that bus. This patch enables networking on e500 guests again. Signed-off-by: Alexander Graf ag...@suse.de --- hw/ppce500_mpc8544ds.c |2 +-

[Qemu-devel] why QEMU re-disassembly an instruction

2011-05-27 Thread tran dung
Checking qemu.log (-d in_asm), I found a translation block have only 1 instruction (NEON instruction), and this instruction is re-disassembled in the next translation block. I can't understand why an instruction is disassembled but not executed (I guess). Please explain the reason and show me the

Re: [Qemu-devel] [PATCH] qemu-iotest: test 005, don't run on raw

2011-05-27 Thread Fam Zheng
But it says I can't create a 5000G raw image, this is the output of `./check 005` (with qemu-img version 0.14.50) IMGFMT-- raw IMGPROTO -- file PLATFORM -- Linux/i686 localhost 2.6.37-ARCH 005 - output mismatch (see 005.out.bad) --- 005.out 2011-05-28