Re: [Qemu-devel] [PATCH] usb-ehci: move device/vendor/class id to qdev

2011-06-14 Thread Michael S. Tsirkin
On Wed, Jun 15, 2011 at 08:32:50AM +0200, Gerd Hoffmann wrote: > On 06/14/11 19:40, Michael S. Tsirkin wrote: > >This is on top of my pci tree. > > Looks good. Wanna queue this up in your PCI tree, so all devices > are switched over at once when this is merged? > > cheers, > Gerd Guess so, ye

Re: [Qemu-devel] [PATCH 01/13] spice: Use cpu_register_physical_memory_log for dirty log enabling

2011-06-14 Thread Gerd Hoffmann
Hi, Note: The addtional vga_dirty_log_start for the primary interface looked stray. qxl_write_config enabled logging for all interfaces anyway. No. qxl_write_config is hooked for the primary only. case QXL_RAM_RANGE_INDEX: -cpu_register_physical_memory(addr, size, qxl->vga.v

Re: [Qemu-devel] High speed polling

2011-06-14 Thread Stefan Hajnoczi
On Tue, Jun 14, 2011 at 11:32 PM, Clay Andreasen wrote: > I have a network device simulation that I am connecting to multiple > instances of Qemu (nodes) via a shared memory queue.  It works pretty well > as > long as all of the nodes are initiating communication but when one node is > passive, it

Re: [Qemu-devel] [PATCH] usb-ehci: move device/vendor/class id to qdev

2011-06-14 Thread Gerd Hoffmann
On 06/14/11 19:40, Michael S. Tsirkin wrote: This is on top of my pci tree. Looks good. Wanna queue this up in your PCI tree, so all devices are switched over at once when this is merged? cheers, Gerd

Re: [Qemu-devel] [PATCH RFC] target-ppc: Correctly handle translation address when bus unit ID = 0x07F

2011-06-14 Thread Alexander Graf
On 14.06.2011, at 23:49, Andreas Färber wrote: > Am 13.06.2011 um 15:31 schrieb Alexander Graf: > >> On 13.06.2011, at 12:13, Andreas Färber wrote: >> >>> +/* Memory forced */ >>> +ctx->raddr = ((sr & 0xF) << 28) | (eaddr & 0x0FFF); >> >> This is exactly the same as

Re: [Qemu-devel] [PATCH 03/12] VMDK: probe for mono flat image

2011-06-14 Thread Stefan Hajnoczi
On Wed, Jun 15, 2011 at 6:45 AM, Fam Zheng wrote: >> Have you tried removing that comment line to see if VMware still >> recognizes the file? >> > > Yes, it recognizes iff the first option line (non-comment, non-empty) > is "version=1" or "version=2“. > > (An interesting thing that it is both spac

Re: [Qemu-devel] [PATCH 03/12] VMDK: probe for mono flat image

2011-06-14 Thread Fam Zheng
> Have you tried removing that comment line to see if VMware still > recognizes the file? > Yes, it recognizes iff the first option line (non-comment, non-empty) is "version=1" or "version=2“. (An interesting thing that it is both space sensitive and case sensitive) -- Best regards! Fam Zheng

Re: [Qemu-devel] [PATCH 03/12] VMDK: probe for mono flat image

2011-06-14 Thread Stefan Hajnoczi
On Wed, Jun 15, 2011 at 5:26 AM, Fam Zheng wrote: > On Tue, Jun 14, 2011 at 4:06 PM, Stefan Hajnoczi wrote: >> On Sat, Jun 04, 2011 at 08:40:50AM +0800, Fam Zheng wrote: >>> vmdk_probe for mono flat images. >>> >>> Signed-off-by: Fam Zheng >>> --- >>>  block/vmdk.c |   13 ++--- >>>  1 fi

[Qemu-devel] [PATCH] Fix signal handling of SIG_IPI when io-thread is enabled

2011-06-14 Thread Alexandre Raymond
Both the signal thread (via sigwait()) and the cpu thread (via a normal signal handler) were attempting to catch SIG_IPI. This resulted in random freezes under Darwin. This patch separates SIG_IPI from the rest of the signals handled by the signal thread, because it is independently caught by the

Re: [Qemu-devel] [RFC 23/23] 40p: Add an 8514/A graphics card

2011-06-14 Thread Roy Tam
Hi all, 2011/6/14 Andreas Färber : > The IBM E15 is equivalent to an S3 Vision864. > > Lacking S3 SDAC (86C716) support, the DAC indizes are translated > to greyscale colors. This works sufficiently to observe firmware > boot progress. > IMO we can generalize it as a generic S3 Vision864 and use

Re: [Qemu-devel] [PATCH 03/12] VMDK: probe for mono flat image

2011-06-14 Thread Fam Zheng
On Tue, Jun 14, 2011 at 4:06 PM, Stefan Hajnoczi wrote: > On Sat, Jun 04, 2011 at 08:40:50AM +0800, Fam Zheng wrote: >> vmdk_probe for mono flat images. >> >> Signed-off-by: Fam Zheng >> --- >>  block/vmdk.c |   13 ++--- >>  1 files changed, 10 insertions(+), 3 deletions(-) >> >> diff --g

[Qemu-devel] [PATCH] [virtio-9p] Fix couple functions doing "return on void functions"

2011-06-14 Thread Malahal Naineni
Signed-off-by: Malahal Naineni --- hw/9pfs/virtio-9p-local.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/9pfs/virtio-9p-local.c b/hw/9pfs/virtio-9p-local.c index 1b6c323..b6643fc 100644 --- a/hw/9pfs/virtio-9p-local.c +++ b/hw/9pfs/virtio-9p-local.c @@ -166,7 +

[Qemu-devel] [Bug 739785] Re: qemu-i386 user mode on ARMv5 host fails (bash: fork: Invalid argument)

2011-06-14 Thread moonman
Neither does it work for me: [root@Plugbox /]# cat /proc/cpu/alignment User: 293831 System: 1 Skipped:0 Half: 22200 Word: 271546 DWord: 1 Multi: 0 User faults:2 (fixup) [root@Plugbox /]# chroot /i386 [root@Plugbox /]# ls bash: for

[Qemu-devel] [PATCH] guest agent: fix for guest agent RPCs/commands

2011-06-14 Thread Michael Roth
One of my commits must've gotten lost while I was squashing patches. Please apply the attached patch to correct a build issue due to qmp_guest_file_open()'s implementation not matching the qapi-generated prototype. Patch 3 has been updated in the corresponding repo branch if you're pulling from

Re: [Qemu-devel] [PATCH 01/10] ppce500: move device/vendor/class id to qdev

2011-06-14 Thread Isaku Yamahata
On Tue, Jun 14, 2011 at 08:35:20PM +0300, Michael S. Tsirkin wrote: > Signed-off-by: Michael S. Tsirkin > --- > hw/ppce500_pci.c | 13 +++-- > 1 files changed, 3 insertions(+), 10 deletions(-) > > diff --git a/hw/ppce500_pci.c b/hw/ppce500_pci.c > index 069af96..fc11af4 100644 > --- a/

Re: [Qemu-devel] [PATCH 08/10] alpha: remove unused variable

2011-06-14 Thread Richard Henderson
On 06/14/2011 10:36 AM, Michael S. Tsirkin wrote: > Signed-off-by: Michael S. Tsirkin > --- > target-alpha/translate.c |7 ++- > 1 files changed, 6 insertions(+), 1 deletions(-) Acked-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 07/10] alpha/translate: remve unused variables

2011-06-14 Thread Richard Henderson
On 06/14/2011 10:36 AM, Michael S. Tsirkin wrote: > Signed-off-by: Michael S. Tsirkin > --- > target-alpha/translate.c |3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) Acked-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 05/10] wdt: remove unused variables

2011-06-14 Thread Isaku Yamahata
It seems that I overlooked the variable when pci id conversion. Acked-off-by: Isaku Yamahata On Tue, Jun 14, 2011 at 08:35:52PM +0300, Michael S. Tsirkin wrote: > Signed-off-by: Michael S. Tsirkin > --- > hw/wdt_i6300esb.c |3 --- > 1 files changed, 0 insertions(+), 3 deletions(-) > > di

[Qemu-devel] [PATCH 10/10] linux-user: remove unused variables

2011-06-14 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin --- linux-user/flatload.c | 10 ++ linux-user/linuxload.c | 25 + linux-user/main.c |6 +++--- linux-user/signal.c|5 - linux-user/syscall.c |6 -- 5 files changed, 10 insertions(+), 42 deletions

[Qemu-devel] [PATCH 08/10] alpha: remove unused variable

2011-06-14 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin --- target-alpha/translate.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/target-alpha/translate.c b/target-alpha/translate.c index 5d7454c..936760c 100644 --- a/target-alpha/translate.c +++ b/target-alpha/translate.c @@ -1661,7

[Qemu-devel] [PATCH 09/10] exec: remove unused variable

2011-06-14 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin --- exec.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/exec.c b/exec.c index 81808f4..b784f08 100644 --- a/exec.c +++ b/exec.c @@ -1207,12 +1207,16 @@ static inline void tb_alloc_page(TranslationBlock *tb,

[Qemu-devel] [PATCH 04/10] lsi53c895a: remove unused variables

2011-06-14 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin --- hw/lsi53c895a.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/hw/lsi53c895a.c b/hw/lsi53c895a.c index 3b75467..940b43a 100644 --- a/hw/lsi53c895a.c +++ b/hw/lsi53c895a.c @@ -889,7 +889,6 @@ static void lsi_do_msgout(LSIState *s)

[Qemu-devel] [PATCH 05/10] wdt: remove unused variables

2011-06-14 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin --- hw/wdt_i6300esb.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/hw/wdt_i6300esb.c b/hw/wdt_i6300esb.c index bd57fd3..53786ce 100644 --- a/hw/wdt_i6300esb.c +++ b/hw/wdt_i6300esb.c @@ -381,7 +381,6 @@ static const VMStateDescriptio

[Qemu-devel] [PATCH 02/10] usb-ehci: move device/vendor/class id to qdev

2011-06-14 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin --- hw/usb-ehci.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/hw/usb-ehci.c b/hw/usb-ehci.c index f63519e..4d6989a 100644 --- a/hw/usb-ehci.c +++ b/hw/usb-ehci.c @@ -1945,6 +1945,10 @@ static PCIDeviceInfo ehci_info = { .

[Qemu-devel] [PATCH 07/10] alpha/translate: remve unused variables

2011-06-14 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin --- target-alpha/translate.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/target-alpha/translate.c b/target-alpha/translate.c index ad6c2ca..5d7454c 100644 --- a/target-alpha/translate.c +++ b/target-alpha/translate.c @@ -1663,7 +166

[Qemu-devel] [PATCH 03/10] usb-ehci: remove unused variables

2011-06-14 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin --- hw/usb-ehci.c | 10 +- 1 files changed, 1 insertions(+), 9 deletions(-) diff --git a/hw/usb-ehci.c b/hw/usb-ehci.c index 4d6989a..c20ee22 100644 --- a/hw/usb-ehci.c +++ b/hw/usb-ehci.c @@ -523,11 +523,8 @@ static void ehci_detach(USBPort *port) st

[Qemu-devel] [PATCH 06/10] kvm: remove unused variables

2011-06-14 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin --- hw/virtio-pci.h |8 +--- target-i386/kvm.c |3 +-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/hw/virtio-pci.h b/hw/virtio-pci.h index a4b5fd3..b518917 100644 --- a/hw/virtio-pci.h +++ b/hw/virtio-pci.h @@ -37,7 +37,9 @@ typed

[Qemu-devel] [PATCH 00/10] qemu: remove set but unused variables

2011-06-14 Thread Michael S. Tsirkin
Switched to FC15 and qemu build with -Werror fails. The reason is that with gcc 4.6.0, -Werror makes the build fail on variables that are set but never used. XXX: In function ‘xxx’: XXX:XXX:XX: error: variable ‘xx’ set but not used [-Werror=unused-but-set-variable] The following patchset removes s

[Qemu-devel] [PATCH 01/10] ppce500: move device/vendor/class id to qdev

2011-06-14 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin --- hw/ppce500_pci.c | 13 +++-- 1 files changed, 3 insertions(+), 10 deletions(-) diff --git a/hw/ppce500_pci.c b/hw/ppce500_pci.c index 069af96..fc11af4 100644 --- a/hw/ppce500_pci.c +++ b/hw/ppce500_pci.c @@ -304,20 +304,13 @@ static int e500_pcihos

Re: [Qemu-devel] High speed polling

2011-06-14 Thread Mulyadi Santosa
Hi Clay. On Wed, Jun 15, 2011 at 05:32, Clay Andreasen wrote: > I have a network device simulation that I am connecting to multiple > instances of Qemu (nodes) via a shared memory queue.  It works pretty well > as > long as all of the nodes are initiating communication but when one node is >

[Qemu-devel] High speed polling

2011-06-14 Thread Clay Andreasen
I have a network device simulation that I am connecting to multiple instances of Qemu (nodes) via a shared memory queue. It works pretty well as long as all of the nodes are initiating communication but when one node is passive, it must poll to get packets. So far the fastest I have been able

Re: [Qemu-devel] [libvirt] [PATCH v2] Add support for fd: protocol

2011-06-14 Thread Eric Blake
On 06/14/2011 03:39 PM, Corey Bryant wrote: >> Incremental support is fine by me, but we'll need it sooner or later. > > Qemu currently opens the specified copy-on-write file, finds a backing > file name in the opened file's header, opens that backing file, and > repeats. > > So it seems that eit

Re: [Qemu-devel] [PATCH RFC] target-ppc: Correctly handle translation address when bus unit ID = 0x07F

2011-06-14 Thread Andreas Färber
Am 13.06.2011 um 15:31 schrieb Alexander Graf: On 13.06.2011, at 12:13, Andreas Färber wrote: +/* Memory forced */ +ctx->raddr = ((sr & 0xF) << 28) | (eaddr & 0x0FFF); This is exactly the same as ctx->raddr = eaddr, no? No, not that I see. The manual is explicit

Re: [Qemu-devel] [PATCH] for bug 754635: -d option outs wrong info about sections

2011-06-14 Thread Andreas Färber
Hi, Am 12.06.2011 um 15:14 schrieb ferux: Patch to correct log output about sections from: startend size prot 0001-00019000 9000 r-x 00019000-0007b000 00062000 rw- 0004-00041000 1000 --- 00041000-00041800 0800 rw- 00041800-0005d800 0001c000 r-x 0005d800-0005e800

Re: [Qemu-devel] [libvirt] [PATCH v2] Add support for fd: protocol

2011-06-14 Thread Corey Bryant
On 06/14/2011 04:18 PM, Eric Blake wrote: On 06/14/2011 01:55 PM, Corey Bryant wrote: >> So we would need something like -drive >> file=fd:4,format=qcow2,backing=fd:5 >> >> and since backing files can be nested, we'd need some way of specifying >> more than one level of backing file. Libv

[Qemu-devel] [PATCH v2] target-ppc: Handle memory-forced I/O controller access

2011-06-14 Thread Andreas Färber
From: Hervé Poussineau On at least the PowerPC 601, a direct-store (T=1) with bus unit ID 0x07F is special-cased as memory-forced I/O controller access. It is supposed to be checked immediately if T=1, bypassing all protection mechanisms and acting cache-inhibited and global. Signed-off-by: Herv

Re: [Qemu-devel] [PATCH] for bug 754635: -d option outs wrong info about sections

2011-06-14 Thread Richard Henderson
On 06/12/2011 06:14 AM, ferux wrote: > Patch to correct log output about sections from: > startend size prot > 0001-00019000 9000 r-x > 00019000-0007b000 00062000 rw- > 0004-00041000 1000 --- > 00041000-00041800 0800 rw- > 00041800-0005d800 0001c000 r-x > 0005d800-0

[Qemu-devel] [Bug 739785] Re: qemu-i386 user mode on ARMv5 host fails (bash: fork: Invalid argument)

2011-06-14 Thread Oleg
Hmm, it does not seem to work for me: [root@Plugbox cpu]# cat alignment User: 73412 System: 1 Skipped:0 Half: 5312 Word: 68091 DWord: 1 Multi: 0 User faults:2 (fixup) [root@Plugbox cpu]# cd /i386/ [root@Plugbox i386]# chroot . bas

Re: [Qemu-devel] [libvirt] [PATCH v2] Add support for fd: protocol

2011-06-14 Thread Eric Blake
On 06/14/2011 01:55 PM, Corey Bryant wrote: >> So we would need something like -drive >> file=fd:4,format=qcow2,backing=fd:5 >> >> and since backing files can be nested, we'd need some way of specifying >> more than one level of backing file. Libvirt already knows how to walk >> a chain of backing

[Qemu-devel] [PATCH v5 5/5] guest agent: Makefile, build qemu-ga

2011-06-14 Thread Michael Roth
This allows us to build qemu-ga with "make qemu-ga". It pulls in the qemu-tools deps, but does not currently build by default. This may change to avoid bitrot and help with host-side-only unit tests. Signed-off-by: Michael Roth --- Makefile | 22 +- configure |1 + 2 f

[Qemu-devel] [PATCH v5 3/5] guest agent: add guest agent RPCs/commands

2011-06-14 Thread Michael Roth
This adds the initial set of QMP/QAPI commands provided by the guest agent: guest-sync guest-ping guest-info guest-shutdown guest-file-open guest-file-read guest-file-write guest-file-seek guest-file-close guest-fsfreeze-freeze guest-fsfreeze-thaw guest-fsfreeze-status The input/output specificat

[Qemu-devel] [PATCH v5 4/5] guest agent: add guest agent commands schema file

2011-06-14 Thread Michael Roth
Signed-off-by: Michael Roth --- qapi-schema-guest.json | 202 1 files changed, 202 insertions(+), 0 deletions(-) create mode 100644 qapi-schema-guest.json diff --git a/qapi-schema-guest.json b/qapi-schema-guest.json new file mode 100644 index 0

[Qemu-devel] [PATCH v5 1/5] guest agent: command state class

2011-06-14 Thread Michael Roth
Signed-off-by: Michael Roth --- qga/guest-agent-command-state.c | 73 +++ qga/guest-agent-core.h | 25 + 2 files changed, 98 insertions(+), 0 deletions(-) create mode 100644 qga/guest-agent-command-state.c create mode 100644 qga/gues

[Qemu-devel] [QAPI+QGA 3/3] QEMU Guest Agent (virtagent) v5

2011-06-14 Thread Michael Roth
This is Set 3/3 of the QAPI+QGA patchsets. These patches apply on top of qapi-backport-set2-v3, and can also be obtained from: git://repo.or.cz/qemu/mdroth.git qapi-backport-set3-v5 (Set1+2 are a backport of some of the QAPI-related work from Anthony's glib tree. The main goal is to get the basi

[Qemu-devel] [PATCH v5 2/5] guest agent: qemu-ga daemon

2011-06-14 Thread Michael Roth
This is the actual guest daemon, it listens for requests over a virtio-serial/isa-serial/unix socket channel and routes them through to dispatch routines, and writes the results back to the channel in a manner similar to QMP. A shorthand invocation: qemu-ga -d Is equivalent to: qemu-ga -c v

[Qemu-devel] [PATCH, v2] vga: Fix type of lfb/map_addr/end.

2011-06-14 Thread Richard Henderson
These addresses have been passed through pci_to_cpu_addr, and thus need to be full target_phys_addr_t. Signed-off-by: Richard Henderson Cc: Jan Kiszka --- V1->V2: lfb_addr/end also widened to guest address width. hw/vga_int.h | 10 +- 1 files changed, 5 insertions(+), 5 del

Re: [Qemu-devel] [libvirt] [PATCH v2] Add support for fd: protocol

2011-06-14 Thread Corey Bryant
On 06/14/2011 12:13 PM, Eric Blake wrote: On 06/14/2011 07:31 AM, Corey Bryant wrote: > - Starting Qemu with a backing file What do you mean by this? Taking a guess: In the case of a qcow2 image with a backing file, does that mean that both the qcow2 image and it's backing file can both

Re: [Qemu-devel] [PATCH-v3 2/2] kvm: Fix unused-but-set-variable warning

2011-06-14 Thread Christophe Fergeau
On Sat, Jun 11, 2011 at 02:06:00PM +0100, Stefan Hajnoczi wrote: > On Sat, Jun 11, 2011 at 8:46 AM, Jan Kiszka wrote: > > Please skip this one. I'll post a patch fixing the issue that this > > warning revealed (lacking save/restore of FPU OP, IP and DP). > > Okay, dropped from trivial-patches in

Re: [Qemu-devel] [PATCH] vga: Fix type of map_addr/end.

2011-06-14 Thread Richard Henderson
On 06/14/2011 11:14 AM, Jan Kiszka wrote: > On 2011-06-14 19:44, Richard Henderson wrote: >> These addresses have been passed through pci_to_cpu_addr, >> and thus need to be full target_phys_addr_t. > > Basically correct, but you also need to change the types of > lfb_addr/end, no? Ah, yes, I see

[Qemu-devel] [PATCH 03/13] qed: replace is_write with flags field

2011-06-14 Thread Stefan Hajnoczi
Per-request attributes like read/write are currently implemented as bool fields in the QEDAIOCB struct. This becomes unwiedly as the number of attributes grows. For example, the qed_aio_setup() function would have to take multiple bool arguments and at call sites it would be hard to distinguish t

[Qemu-devel] [PATCH 02/13] block: add -drive copy-on-read=on|off

2011-06-14 Thread Stefan Hajnoczi
This patch adds the -drive copy-on-read=on|off command-line option: copy-on-read=on|off copy-on-read is "on" or "off" and enables whether to copy read backing file sectors into the image file. Copy-on-read avoids accessing the same backing file sectors repeatedly and is useful when the ba

[Qemu-devel] [PATCH 11/13] block: add -drive stream=on|off

2011-06-14 Thread Stefan Hajnoczi
This patch adds the -drive stream=on|off command-line option: stream=on|off stream is "on" or "off" and enables background copying of backing file contents into the image file until the backing file is no longer needed. Signed-off-by: Stefan Hajnoczi --- blockdev.c | 12 +

[Qemu-devel] [PATCH 08/13] qerror: add qerror_from_args() to create qerror objects

2011-06-14 Thread Stefan Hajnoczi
There is no convenient way to create a QError object without reporting it immediately. This patch adds the qerror_from_args() function to make it easy to create an error in qerror_report() style but without reporting it. Signed-off-by: Stefan Hajnoczi --- qerror.c | 21 +

[Qemu-devel] [PATCH 01/13] qemu-config: }, { -> }, { to please checkpatch.pl

2011-06-14 Thread Stefan Hajnoczi
The checkpatch.pl coding style checker complains that there should be a space after the comma in },{. Make it easy for others to change qemu-config.c in the future by complying with the coding style here. A follow-up patch adds new options to qemu-config.c and therefore benefits from this fix. S

[Qemu-devel] [PATCH 12/13] qed: intelligent streaming implementation

2011-06-14 Thread Stefan Hajnoczi
From: Anthony Liguori Signed-off-by: Anthony Liguori --- block/qed.c | 248 +++ block/qed.h |3 +- 2 files changed, 234 insertions(+), 17 deletions(-) diff --git a/block/qed.c b/block/qed.c index ffdbc2d..f9f7c94 100644 --- a/block/q

[Qemu-devel] [PATCH 04/13] qed: extract qed_start_allocating_write()

2011-06-14 Thread Stefan Hajnoczi
Copy-on-read requests are a form of allocating write and will need to be queued like other allocating writes. This patch extracts the request queuing code for allocating writes so that it can be reused for copy-on-read in a later patch. Signed-off-by: Stefan Hajnoczi --- block/qed.c | 32

[Qemu-devel] [PATCH 10/13] qmp: add QMP support for stream commands

2011-06-14 Thread Stefan Hajnoczi
From: Anthony Liguori For leaf images with copy-on-read semantics, the stream commands allow the user to populate local blocks by manually streaming them from the backing image. Once all blocks have been streamed, the dependency on the original backing image can be removed. Therefore, stream com

[Qemu-devel] [PATCH 13/13] trace: trace bdrv_aio_readv/writev error paths

2011-06-14 Thread Stefan Hajnoczi
It is useful to understand why an I/O request was failed. Add trace events for the error paths in bdrv_aio_readv() and bdrv_aio_writev(). Signed-off-by: Stefan Hajnoczi --- block.c | 24 +++- trace-events |7 +++ 2 files changed, 26 insertions(+), 5 deletions(

[Qemu-devel] [PATCH 07/13] qed: avoid deadlock on emulated synchronous I/O

2011-06-14 Thread Stefan Hajnoczi
The block layer emulates synchronous bdrv_read()/bdrv_write() for drivers that only provide the asynchronous interfaces. The emulation issues an asynchronous request inside a new "async context" and waits for that request to complete. If currently outstanding requests complete during this time, t

[Qemu-devel] [PATCH 05/13] qed: make qed_aio_write_alloc() reusable

2011-06-14 Thread Stefan Hajnoczi
Copy-on-read requests will share the allocating write code path. This requires making qed_aio_write_alloc() reusable outside of a write request. This patch ensures that iovec setup is performed in a common place before qed_aio_write_alloc() is called. Signed-off-by: Stefan Hajnoczi --- block/q

[Qemu-devel] [PATCH 00/13] QED image streaming

2011-06-14 Thread Stefan Hajnoczi
Overview This patch series adds image streaming support for QED image files. Other image formats can also be supported in the future. Image streaming populates the file in the background while the guest is running. This makes it possible to start the guest before its image file has bee

Re: [Qemu-devel] [PATCH] vga: Fix type of map_addr/end.

2011-06-14 Thread Jan Kiszka
On 2011-06-14 19:44, Richard Henderson wrote: > These addresses have been passed through pci_to_cpu_addr, > and thus need to be full target_phys_addr_t. Basically correct, but you also need to change the types of lfb_addr/end, no? > > Signed-off-by: Richard Henderson > Cc: Jan Kiszka > --- >

[Qemu-devel] [PATCH 09/13] block: add bdrv_aio_copy_backing()

2011-06-14 Thread Stefan Hajnoczi
From: Anthony Liguori Add the bdrv_aio_copy_backing() function to the BlockDriver interface. This function copies unallocated sectors from the backing file and can be used to implement image streaming. Signed-off-by: Anthony Liguori Signed-off-by: Stefan Hajnoczi --- block.c | 37 ++

[Qemu-devel] [PATCH 2/2] get_maintainer: update to match qemu tree

2011-06-14 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin --- scripts/get_maintainer.pl | 29 +++-- 1 files changed, 7 insertions(+), 22 deletions(-) diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl index d29a8d7..c52ae59 100755 --- a/scripts/get_maintainer.pl +++ b/scripts/g

[Qemu-devel] [PATCH 06/13] qed: add support for copy-on-read

2011-06-14 Thread Stefan Hajnoczi
From: Anthony Liguori This patch implements copy-on-read in QED. Once a read request reaches the copy-on-read state it adds itself to the allocating write queue in order to avoid race conditions with write requests. If an allocating write request manages to sneak in before the copy-on-read requ

Re: [Qemu-devel] [PATCH] xen: fix interrupt routing

2011-06-14 Thread Stefano Stabellini
On Tue, 14 Jun 2011, Jan Kiszka wrote: > On 2011-06-14 15:27, Stefano Stabellini wrote: > > On Tue, 14 Jun 2011, Alexander Graf wrote: > >>> static int i440fx_load_old(QEMUFile* f, void *opaque, int version_id) > >>> { > >>> PCII440FXState *d = opaque; > >>> @@ -267,8 +263,17 @@ s

[Qemu-devel] [PATCH] vga: Fix type of map_addr/end.

2011-06-14 Thread Richard Henderson
These addresses have been passed through pci_to_cpu_addr, and thus need to be full target_phys_addr_t. Signed-off-by: Richard Henderson Cc: Jan Kiszka --- hw/vga_int.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) Jan's recent patch series reminded me that I found a related pro

[Qemu-devel] [PATCH resend] ppce500: move device/vendor/class id to qdev

2011-06-14 Thread Michael S. Tsirkin
This is on top of my pci tree. Signed-off-by: Michael S. Tsirkin --- Resending, +qemu-devel. sorry about the noise. hw/ppce500_pci.c | 13 +++-- 1 files changed, 3 insertions(+), 10 deletions(-) diff --git a/hw/ppce500_pci.c b/hw/ppce500_pci.c index 069af96..fc11af4 100644 --- a/hw/

[Qemu-devel] [PATCH] usb-ehci: move device/vendor/class id to qdev

2011-06-14 Thread Michael S. Tsirkin
This is on top of my pci tree. Signed-off-by: Michael S. Tsirkin --- hw/usb-ehci.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/hw/usb-ehci.c b/hw/usb-ehci.c index f63519e..4d6989a 100644 --- a/hw/usb-ehci.c +++ b/hw/usb-ehci.c @@ -1945,6 +1945,10 @@ static PC

[Qemu-devel] [PATCH 10/13] Drop dirty log start/stop infrastructure

2011-06-14 Thread Jan Kiszka
No more users of vga_dirty_log_start/start, thus also no use anymore for the log_start/stop CPUPhysMemoryClient callbacks. Drop the whole infrastructure. CC: Anthony PERARD CC: Michael S. Tsirkin CC: Avi Kivity Signed-off-by: Jan Kiszka --- Avi, does this match your plans for a new memory API

Re: [Qemu-devel] [PATCH] smc91c111: qdevify reset

2011-06-14 Thread Peter Maydell
Ping? On 31 May 2011 17:48, Peter Maydell wrote: > From: Juha Riihimäki > > Register the smc91c111 reset function as a qdev reset function. > > Signed-off-by: Juha Riihimäki > Reviewed-by: Peter Maydell > --- >  hw/smc91c111.c |    9 - >  1 files changed, 4 insertions(+), 5 deletions(-

[Qemu-devel] [PATCH 0/2] get_maintainers script

2011-06-14 Thread Michael S. Tsirkin
I copied get_maintainers.pl from Linux, seems to work. Here it is, with minor tweaks Michael S. Tsirkin (2): get_maintainer.pl: copy utility from Linux get_maintainer: update to match qemu tree scripts/get_maintainer.pl | 2144 + 1 files changed, 2

[Qemu-devel] [PATCH 12/13] vga: Move vga_sync_dirty_bitmap

2011-06-14 Thread Jan Kiszka
We will need it earlier in the code. Signed-off-by: Jan Kiszka --- hw/vga.c | 37 ++--- 1 files changed, 18 insertions(+), 19 deletions(-) diff --git a/hw/vga.c b/hw/vga.c index ee0c68e..4208151 100644 --- a/hw/vga.c +++ b/hw/vga.c @@ -152,6 +152,24 @@ static v

[Qemu-devel] [PATCH 03/13] cirrus-vga: Drop redundant vga_dirty_log_start

2011-06-14 Thread Jan Kiszka
map_linear_vram requests logging via cpu_register_physical_memory_log now, and cirrus_pci_lfb_map does not leave anything to log behind. Signed-off-by: Jan Kiszka --- hw/cirrus_vga.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c ind

[Qemu-devel] [PATCH 09/13] vmware-vga: Use cpu_register_physical_memory_log for dirty log enabling

2011-06-14 Thread Jan Kiszka
This eliminates the last user of vga_dirty_log_start/start. CC: Andrzej Zaborowski Signed-off-by: Jan Kiszka --- hw/vmware_vga.c | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c index c20f154..7cb0c28 100644 --- a/hw/vmware_vg

[Qemu-devel] [PATCH 11/13] vga: Refactor lfb_vram_mapped to vga_mem_mapped

2011-06-14 Thread Jan Kiszka
Make it clearer that this flag indicates wether the legacy VGA memory region is mapped as RAM. And change its type to bool. Signed-off-by: Jan Kiszka --- hw/cirrus_vga.c | 10 -- hw/vga.c|4 ++-- hw/vga_int.h|2 +- 3 files changed, 7 insertions(+), 9 deletions(-) d

[Qemu-devel] [PATCH 02/13] vga-pci: Use cpu_register_physical_memory_log for dirty log enabling

2011-06-14 Thread Jan Kiszka
Signed-off-by: Jan Kiszka --- hw/vga-pci.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/vga-pci.c b/hw/vga-pci.c index ce9ec45..d7d904a 100644 --- a/hw/vga-pci.c +++ b/hw/vga-pci.c @@ -53,10 +53,10 @@ static void vga_map(PCIDevice *pci_dev, int region_num, P

[Qemu-devel] [PATCH 13/13] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-06-14 Thread Jan Kiszka
Most VGA memory access modes require MMIO handling as they demand weird logic to get a byte from or into the video RAM. However, there is one exception: chain 4 mode with all memory planes enabled for writing. This mode actually allows lineary mapping, which can then be combined with dirty logging

[Qemu-devel] [PATCH 01/13] spice: Use cpu_register_physical_memory_log for dirty log enabling

2011-06-14 Thread Jan Kiszka
Drop outdated dirty log disable/enable around PCI remapping and register the BAR for dirty logging via cpu_register_physical_memory_log. That allows to remove all vga_dirty_log_start/stop references from qxl. Note: The addtional vga_dirty_log_start for the primary interface looked stray. qxl_write

[Qemu-devel] [PATCH 07/13] vmware_vga: Do not enable dirty logging when in SVGA mode

2011-06-14 Thread Jan Kiszka
Just like on SVGA_REG_ENABLE changes, keep dirty logging off on PCI BAR remappings when SVGA mode is on. CC: Andrzej Zaborowski Signed-off-by: Jan Kiszka --- hw/vmware_vga.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c index 82e2a1

[Qemu-devel] [PATCH 05/13] vmware-vga: Remove dead DIRECT_VRAM mode

2011-06-14 Thread Jan Kiszka
The code was disabled since day 1 of vmware-vga, and now it does not even build anymore. Time for a cleanup. CC: Andrzej Zaborowski Signed-off-by: Jan Kiszka --- hw/vmware_vga.c | 168 ++ 1 files changed, 31 insertions(+), 137 deletions(-) d

[Qemu-devel] [PATCH 06/13] vmware-vga: Eliminate vga_dirty_log_restart

2011-06-14 Thread Jan Kiszka
Convert the last user of vga_dirty_log_restart to cpu_register_physical_memory_log and drop the service. CC: Andrzej Zaborowski Signed-off-by: Jan Kiszka --- hw/vga.c|6 -- hw/vga_int.h|1 - hw/vmware_vga.c |5 ++--- 3 files changed, 2 insertions(+), 10 deletions(-)

[Qemu-devel] [PATCH 00/13] vga: dirty log cleanup, more linear mapping

2011-06-14 Thread Jan Kiszka
A few optimizations and cleanups I came across when trying to speed up slow graphical grub unter non-cirrus vga. This series - eliminates log_start/stop CPUPhysMemoryClient callbacks - accelerates chain 4 vga mode under KVM - fixes reset of vmware-vga - cleans up vmware-vga a bit At least patc

[Qemu-devel] [PATCH 08/13] vmware-vga: Register reset service

2011-06-14 Thread Jan Kiszka
Fixes cold reset in vmware graphic modes. CC: Andrzej Zaborowski Signed-off-by: Jan Kiszka --- hw/vmware_vga.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c index 93b8811..c20f154 100644 --- a/hw/vmware_vga.c +++ b/hw/vmware_v

Re: [Qemu-devel] [PATCH v2] Fix signal handling when io-thread is disabled

2011-06-14 Thread Jan Kiszka
On 2011-06-14 16:05, Alexandre Raymond wrote: > Changes since v1: > - take pthread_sigmask() out of the ifdef as it is now common > to both parts. > > This fix effectively blocks, in the main thread, the signals handled > by signalfd or the compatibility signal thread. > > This way, such signals

[Qemu-devel] [PATCH 04/13] vmware-vga: Disable verbose mode

2011-06-14 Thread Jan Kiszka
Elimiates 'vmsvga_value_write: guest runs Linux.' messages from the console. CC: Andrzej Zaborowski Signed-off-by: Jan Kiszka --- hw/vmware_vga.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c index 4656767..76fe015 100644 --- a/hw/vm

[Qemu-devel] [PATCH 1/2] Allow silent system resets

2011-06-14 Thread Jan Kiszka
This allows qemu_system_reset to be issued silently for internal purposes, ie. without sending out a monitor event. Convert the system reset after startup to the silent mode. Signed-off-by: Jan Kiszka --- sysemu.h |5 - vl.c | 10 ++ xen-all.c |2 +- 3 files changed,

Re: [Qemu-devel] [Xen-devel] Re: [PATCH] xen: avoid tracking the region 0xa0000 - 0xbffff

2011-06-14 Thread Avi Kivity
On 06/14/2011 02:04 PM, Jan Kiszka wrote: BTW, if Xen is not able to track more than one dirty region, I think it's time to fix that limitation. At some point it may no longer be possible to work around it (who knows how the new memory API will look like in this regard). Since the memory API e

Re: [Qemu-devel] [PATCH] cirrus_vga: reset lfb_addr after a pci config write if the BAR is unmapped

2011-06-14 Thread Jan Kiszka
On 2011-06-14 15:54, Alexander Graf wrote: > On 06/03/2011 05:56 PM, stefano.stabell...@eu.citrix.com wrote: >> From: Stefano Stabellini >> >> If the cirrus_vga PCI BAR is unmapped than we should not only reset >> map_addr but also lfb_addr, otherwise we'll keep trying to map >> the old lfb_addr in

[Qemu-devel] [PATCH v2 2/2] Reset system before loadvm

2011-06-14 Thread Jan Kiszka
In case we load the vmstate during incoming migration, we start from a clean, default machine state as we went through system reset before. But if we load from a snapshot, the machine can be in any state. That can cause troubles if loading an older image which does not carry all state information t

Re: [Qemu-devel] [libvirt] [PATCH v2] Add support for fd: protocol

2011-06-14 Thread Eric Blake
On 06/14/2011 07:31 AM, Corey Bryant wrote: > This patch contains the Qemu code to support this solution. I would > like to solicit input from the libvirt community prior to starting > the libvirt patch. > > Currently, Qemu opens an image file in addition to performing the > necessary read and wri

Re: [Qemu-devel] [PATCH] CPU consumption optimization of 'qemu-img convert' using bdrv_is_allocated()

2011-06-14 Thread Stefan Hajnoczi
On Tue, Jun 14, 2011 at 8:43 AM, Dmitry Konishchev wrote: > On Mon, Jun 13, 2011 at 1:13 PM, Dmitry Konishchev > wrote: >> I haven't done this because in this case I have to pass too lot of >> local variables to this function. Just not sure that it'll look >> better. But if you mind I surely can

Re: [Qemu-devel] virtio scsi host draft specification, v3

2011-06-14 Thread Stefan Hajnoczi
On Tue, Jun 14, 2011 at 9:39 AM, Hannes Reinecke wrote: > On 06/10/2011 04:35 PM, Paolo Bonzini wrote: >>> >>> If requests are placed on arbitrary queues you'll inevitably run on >>> locking issues to ensure strict request ordering. >>> I would add here: >>> >>> If a device uses more than one queu

[Qemu-devel] [PATCH v2 3/3] ide: add TRIM support

2011-06-14 Thread Kevin Wolf
From: Christoph Hellwig Add support for TRIM sub function of the data set management command, and wire it up to the qemu discard infrastructure. Signed-off-by: Christoph Hellwig Signed-off-by: Kevin Wolf --- v2: - Fixed bdrv_discard call (takes sectors, not bytes) - Fixed TRIM restart after fa

Re: [Qemu-devel] [PATCH] Reset system before loadvm

2011-06-14 Thread Luiz Capitulino
On Tue, 14 Jun 2011 14:14:58 +0300 Avi Kivity wrote: > On 06/14/2011 01:56 PM, Jan Kiszka wrote: > > > > > > I believe it is not. But regardless, we shouldn't add more incorrect > > > behaviour. > > > > It depends on how the reset event is defined in QMP. As I see it, there > > is nothing stat

Re: [Qemu-devel] [PATCH] xen: fix interrupt routing

2011-06-14 Thread Jan Kiszka
On 2011-06-14 15:27, Stefano Stabellini wrote: > On Tue, 14 Jun 2011, Alexander Graf wrote: >>> static int i440fx_load_old(QEMUFile* f, void *opaque, int version_id) >>> { >>> PCII440FXState *d = opaque; >>> @@ -267,8 +263,17 @@ static PCIBus *i440fx_common_init(const char >>

[Qemu-devel] [PATCH 0/3] pc: enable -cpu host as default

2011-06-14 Thread Alexander Graf
As discussed during the community call, -cpu qemu64 breaks for a bunch of workloads, most prominently recent gcc versions thanks to libgmp. To work around this and to also give the user the best possible performance when running with default command line options, let's use -cpu host as default whe

Re: [Qemu-devel] virtio scsi host draft specification, v3

2011-06-14 Thread Hannes Reinecke
On 06/12/2011 09:51 AM, Michael S. Tsirkin wrote: On Fri, Jun 10, 2011 at 02:55:35PM +0200, Hannes Reinecke wrote: Device operation: request queues The driver queues requests to an arbitrary request queue, and they are used by the device on that same queue. Wh

[Qemu-devel] [PATCH 3/3] pc: use -cpu host as default for kvm

2011-06-14 Thread Alexander Graf
When running with KVM, people expect to get the best possible performance inside the VM. To really get this, the guest needs to know about the CPU features it can use. We have a CPU type that exports exactly this information to the guest, but hasn't been used much, as it wasn't the default. Set it

[Qemu-devel] [PATCH 2/3] pc: use old default cpu type for 0.14 and 0.15 compat machines

2011-06-14 Thread Alexander Graf
When running with the 0.14 or 0.15 machine types, use the old mechanism of determining the default CPU to choose, so that the guest sees the same default CPU when running qemu in compat mode. Signed-off-by: Alexander Graf --- hw/pc_piix.c | 16 1 files changed, 16 insertions(+

  1   2   >