Re: [Qemu-devel] [PATCH 03/12] VMDK: probe for mono flat image

2011-06-15 Thread Stefan Hajnoczi
On Wed, Jun 15, 2011 at 6:45 AM, Fam Zheng famc...@gmail.com wrote: Have you tried removing that comment line to see if VMware still recognizes the file? Yes, it recognizes iff the first option line (non-comment, non-empty) is version=1 or version=2“. (An interesting thing that it is both

Re: [Qemu-devel] [PATCH RFC] target-ppc: Correctly handle translation address when bus unit ID = 0x07F

2011-06-15 Thread Alexander Graf
On 14.06.2011, at 23:49, Andreas Färber wrote: Am 13.06.2011 um 15:31 schrieb Alexander Graf: On 13.06.2011, at 12:13, Andreas Färber wrote: +/* Memory forced */ +ctx-raddr = ((sr 0xF) 28) | (eaddr 0x0FFF); This is exactly the same as ctx-raddr = eaddr,

Re: [Qemu-devel] [PATCH] usb-ehci: move device/vendor/class id to qdev

2011-06-15 Thread Gerd Hoffmann
On 06/14/11 19:40, Michael S. Tsirkin wrote: This is on top of my pci tree. Looks good. Wanna queue this up in your PCI tree, so all devices are switched over at once when this is merged? cheers, Gerd

Re: [Qemu-devel] High speed polling

2011-06-15 Thread Stefan Hajnoczi
On Tue, Jun 14, 2011 at 11:32 PM, Clay Andreasen c...@cray.com wrote: I have a network device simulation that I am connecting to multiple instances of Qemu (nodes) via a shared memory queue.  It works pretty well as long as all of the nodes are initiating communication but when one node is

Re: [Qemu-devel] [PATCH 01/13] spice: Use cpu_register_physical_memory_log for dirty log enabling

2011-06-15 Thread Gerd Hoffmann
Hi, Note: The addtional vga_dirty_log_start for the primary interface looked stray. qxl_write_config enabled logging for all interfaces anyway. No. qxl_write_config is hooked for the primary only. case QXL_RAM_RANGE_INDEX: -cpu_register_physical_memory(addr, size,

Re: [Qemu-devel] [PATCH] usb-ehci: move device/vendor/class id to qdev

2011-06-15 Thread Michael S. Tsirkin
On Wed, Jun 15, 2011 at 08:32:50AM +0200, Gerd Hoffmann wrote: On 06/14/11 19:40, Michael S. Tsirkin wrote: This is on top of my pci tree. Looks good. Wanna queue this up in your PCI tree, so all devices are switched over at once when this is merged? cheers, Gerd Guess so, yes.

[Qemu-devel] [PATCH v2 01/13] spice: Use cpu_register_physical_memory_log for dirty log enabling

2011-06-15 Thread Jan Kiszka
Drop outdated dirty log disable/enable around PCI remapping and register the BAR for dirty logging via cpu_register_physical_memory_log. That allows to remove all vga_dirty_log_start/stop references from qxl. CC: Gerd Hoffmann kra...@redhat.com Signed-off-by: Jan Kiszka jan.kis...@siemens.com ---

Re: [Qemu-devel] [PATCH, v2] vga: Fix type of lfb/map_addr/end.

2011-06-15 Thread Jan Kiszka
On 2011-06-14 21:53, Richard Henderson wrote: These addresses have been passed through pci_to_cpu_addr, and thus need to be full target_phys_addr_t. Signed-off-by: Richard Henderson r...@twiddle.net Cc: Jan Kiszka jan.kis...@siemens.com --- V1-V2: lfb_addr/end also widened to

Re: [Qemu-devel] [PATCH] CPU consumption optimization of 'qemu-img convert' using bdrv_is_allocated()

2011-06-15 Thread Dmitry Konishchev
On Tue, Jun 14, 2011 at 7:58 PM, Stefan Hajnoczi stefa...@gmail.com wrote: Yes, please. OK, I'll do it as soon I'll find time for it. On Tue, Jun 14, 2011 at 7:58 PM, Stefan Hajnoczi stefa...@gmail.com wrote: For image files the block layer should be caching the device capacity (size)

Re: [Qemu-devel] [PATCH] Fix signal handling of SIG_IPI when io-thread is enabled

2011-06-15 Thread Jan Kiszka
On 2011-06-15 07:20, Alexandre Raymond wrote: Both the signal thread (via sigwait()) and the cpu thread (via a normal signal handler) were attempting to catch SIG_IPI. Why? Ahh, because of qemu_cpu_kick_self: raise(SIG_IPI)! That should generate a per-process SIG_IPI. And that may not only

[Qemu-devel] [PATCH v2] linux-user: Fix the computation of the requested heap size

2011-06-15 Thread Cédric VINCENT
There were several remaining bugs in the previous implementation of do_brk(): 1. the value of new_alloc_size was one page too large when the requested brk was aligned on a host page boundary. 2. no new pages should be (re-)allocated when the requested brk is in the range of

Re: [Qemu-devel] [PATCH v2] target-ppc: Handle memory-forced I/O controller access

2011-06-15 Thread Alexander Graf
On 14.06.2011, at 23:27, Andreas Färber wrote: From: Hervé Poussineau hpous...@reactos.org On at least the PowerPC 601, a direct-store (T=1) with bus unit ID 0x07F is special-cased as memory-forced I/O controller access. It is supposed to be checked immediately if T=1, bypassing all

Re: [Qemu-devel] [PATCH] xen: avoid tracking the region 0xa0000 - 0xbffff

2011-06-15 Thread Alexander Graf
On 14.06.2011, at 17:24, Stefano Stabellini wrote: On Tue, 14 Jun 2011, Alexander Graf wrote: On 14.06.2011, at 13:48, Stefano Stabellini wrote: On Tue, 14 Jun 2011, Alexander Graf wrote: On 03.06.2011, at 17:56, stefano.stabell...@eu.citrix.com stefano.stabell...@eu.citrix.com wrote:

Re: [Qemu-devel] [Xen-devel] Re: [PATCH] xen: fix interrupt routing

2011-06-15 Thread Alexander Graf
On 14.06.2011, at 15:27, Stefano Stabellini wrote: On Tue, 14 Jun 2011, Alexander Graf wrote: static int i440fx_load_old(QEMUFile* f, void *opaque, int version_id) { PCII440FXState *d = opaque; @@ -267,8 +263,17 @@ static PCIBus *i440fx_common_init(const char *device_name, d =

Re: [Qemu-devel] [PATCH] xen: fix interrupt routing

2011-06-15 Thread Alexander Graf
On 14.06.2011, at 20:18, Stefano Stabellini wrote: On Tue, 14 Jun 2011, Jan Kiszka wrote: On 2011-06-14 15:27, Stefano Stabellini wrote: On Tue, 14 Jun 2011, Alexander Graf wrote: static int i440fx_load_old(QEMUFile* f, void *opaque, int version_id) { PCII440FXState *d = opaque; @@

Re: [Qemu-devel] [PATCH] CPU consumption optimization of 'qemu-img convert' using bdrv_is_allocated()

2011-06-15 Thread Stefan Hajnoczi
On Wed, Jun 15, 2011 at 8:38 AM, Dmitry Konishchev konishc...@gmail.com wrote: On Tue, Jun 14, 2011 at 7:58 PM, Stefan Hajnoczi stefa...@gmail.com wrote: Yes, please. OK, I'll do it as soon I'll find time for it. On Tue, Jun 14, 2011 at 7:58 PM, Stefan Hajnoczi stefa...@gmail.com wrote:

Re: [Qemu-devel] [PATCH v2 01/13] spice: Use cpu_register_physical_memory_log for dirty log enabling

2011-06-15 Thread Gerd Hoffmann
On 06/15/11 09:23, Jan Kiszka wrote: Drop outdated dirty log disable/enable around PCI remapping and register the BAR for dirty logging via cpu_register_physical_memory_log. That allows to remove all vga_dirty_log_start/stop references from qxl. Acked-by: Gerd Hoffmann kra...@redhat.com

[Qemu-devel] [Bug 739785] Re: qemu-i386 user mode on ARMv5 host fails (bash: fork: Invalid argument)

2011-06-15 Thread moonman
I have to add that it's with kernel 2.6.39 and qemu 0.14.1 compiled from source [root@Plugbox ~]# uname -a Linux Plugbox 2.6.39-ARCH #1 PREEMPT Tue Jun 14 15:55:01 MDT 2011 armv5tel Feroceon 88FR131 rev 1 (v5l) Marvell SheevaPlug Reference Board GNU/Linux [root@Plugbox ~]#

[Qemu-devel] [Bug 739785] Re: qemu-i386 user mode on ARMv5 host fails (bash: fork: Invalid argument)

2011-06-15 Thread Ricardo Padilha
Same here. The workaround does not work on a DroboFS, since it was actually the default setting all along. root@DroboFS:~# cat /proc/cpu/alignment User: 74283231 System: 0 Skipped:0 Half: 0 Word: 74283231 DWord: 0 Multi: 0 User

Re: [Qemu-devel] [PATCH][uq/master] kvm: x86: Save/restore FPU OP, IP and DP

2011-06-15 Thread Avi Kivity
On 06/14/2011 09:10 AM, Jan Kiszka wrote: On 2011-06-13 10:45, Avi Kivity wrote: On 06/11/2011 12:23 PM, Jan Kiszka wrote: From: Jan Kiszkajan.kis...@siemens.com These FPU states are properly maintained by KVM but not yet by TCG. So far we unconditionally set them to 0 in the guest

[Qemu-devel] [Bug 739785] Re: qemu-i386 user mode on ARMv5 host fails (bash: fork: Invalid argument)

2011-06-15 Thread Peter Maydell
OK, that's pretty conclusive. My initial theory about what's going on here can't be right -- I'll investigate further. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/739785 Title: qemu-i386 user

Re: [Qemu-devel] [PATCH] CPU consumption optimization of 'qemu-img convert' using bdrv_is_allocated()

2011-06-15 Thread Dmitry Konishchev
On Wed, Jun 15, 2011 at 12:39 PM, Stefan Hajnoczi stefa...@gmail.com wrote: Why is bdrv_get_geometry() slow? Mmm.. Frankly, I haven't looked so deep, but it is going to be slow at least for raw images due to using lseek(). -- Dmitry Konishchev mailto:konishc...@gmail.com

[Qemu-devel] [PATCH] CPU consumption optimization of 'qemu-img convert' using bdrv_is_allocated()

2011-06-15 Thread Dmitry Konishchev
This patch optimizes 'qemu-img convert' operation for volumes which are almost fully unallocated. Here are the results of simple tests: We have a snapshot of a volume: $ qemu-img info snapshot.qcow2 image: snapshot.qcow2 file format: qcow2 virtual size: 5.0G (5372805120 bytes) disk size: 4.0G

Re: [Qemu-devel] [PATCH][uq/master] kvm: x86: Save/restore FPU OP, IP and DP

2011-06-15 Thread Jan Kiszka
On 2011-06-15 11:10, Avi Kivity wrote: On 06/14/2011 09:10 AM, Jan Kiszka wrote: On 2011-06-13 10:45, Avi Kivity wrote: On 06/11/2011 12:23 PM, Jan Kiszka wrote: From: Jan Kiszkajan.kis...@siemens.com These FPU states are properly maintained by KVM but not yet by TCG. So far we

[Qemu-devel] [PATCH] Allow nested qemu_bh_poll() after BH deletion

2011-06-15 Thread Kevin Wolf
Without this, qemu segfaults when a BH handler first deletes its BH and then calls another function which involves a nested qemu_bh_poll() call. This can be reproduced by generating an I/O error (e.g. with blkdebug) on an IDE device and using rerror/werror=stop to stop the VM. When continuing the

Re: [Qemu-devel] [PATCH][uq/master] kvm: x86: Save/restore FPU OP, IP and DP

2011-06-15 Thread Jan Kiszka
On 2011-06-15 12:20, Jan Kiszka wrote: On 2011-06-15 11:10, Avi Kivity wrote: On 06/14/2011 09:10 AM, Jan Kiszka wrote: On 2011-06-13 10:45, Avi Kivity wrote: On 06/11/2011 12:23 PM, Jan Kiszka wrote: From: Jan Kiszkajan.kis...@siemens.com These FPU states are properly maintained by KVM

Re: [Qemu-devel] [PATCH 00/13] QED image streaming

2011-06-15 Thread Philipp Hahn
Hello, hopefully just a quick question... On Tuesday 14 June 2011 20:18:18 Stefan Hajnoczi wrote: This patch series adds image streaming support for QED image files. Other image formats can also be supported in the future. Image streaming populates the file in the background while the guest

[Qemu-devel] [RFC] Specifying storage devices for live migration

2011-06-15 Thread Avishay Traeger
Hello all, Currently there is no way to choose storage devices to be migrated. There was some discussion about making the monitor API a bit more flexible, but the code was never written: http://lists.gnu.org/archive/html/qemu-devel/2009-11/msg01494.html So today users can choose only: 1) No

Re: [Qemu-devel] [PATCH][uq/master] kvm: x86: Save/restore FPU OP, IP and DP

2011-06-15 Thread Avi Kivity
On 06/15/2011 01:20 PM, Jan Kiszka wrote: So fopcode will usually be clear. OK. So if bit 2 of IA32_MISC_ENABLE MSR, we must save that fields. But if it's off, how to test for that other condition last non-transparent FP instruction ... had an unmasked exception from the host? We save

Re: [Qemu-devel] [PATCH][uq/master] kvm: x86: Save/restore FPU OP, IP and DP

2011-06-15 Thread Jan Kiszka
On 2011-06-15 13:26, Avi Kivity wrote: On 06/15/2011 01:20 PM, Jan Kiszka wrote: So fopcode will usually be clear. OK. So if bit 2 of IA32_MISC_ENABLE MSR, we must save that fields. But if it's off, how to test for that other condition last non-transparent FP instruction ... had an

Re: [Qemu-devel] [PATCH][uq/master] kvm: x86: Save/restore FPU OP, IP and DP

2011-06-15 Thread Avi Kivity
On 06/15/2011 02:32 PM, Jan Kiszka wrote: If it isn't zero, there's still a good chance fopcode will be zero (64-bit userspace, thread that hasn't used the fpu since the last context switch, last opcode happened to be zero). I do not yet find if fopcode is invalid, it is zero, just as IP

Re: [Qemu-devel] [PATCH][uq/master] kvm: x86: Save/restore FPU OP, IP and DP

2011-06-15 Thread Jan Kiszka
On 2011-06-15 13:33, Avi Kivity wrote: On 06/15/2011 02:32 PM, Jan Kiszka wrote: If it isn't zero, there's still a good chance fopcode will be zero (64-bit userspace, thread that hasn't used the fpu since the last context switch, last opcode happened to be zero). I do not yet find if

Re: [Qemu-devel] [PATCH] CPU consumption optimization of 'qemu-img convert' using bdrv_is_allocated()

2011-06-15 Thread Stefan Hajnoczi
On Wed, Jun 15, 2011 at 10:50 AM, Dmitry Konishchev konishc...@gmail.com wrote: On Wed, Jun 15, 2011 at 12:39 PM, Stefan Hajnoczi stefa...@gmail.com wrote: Why is bdrv_get_geometry() slow? Mmm.. Frankly, I haven't looked so deep, but it is going to be slow at least for raw images due to using

Re: [Qemu-devel] [PATCH] Allow nested qemu_bh_poll() after BH deletion

2011-06-15 Thread Stefan Hajnoczi
On Wed, Jun 15, 2011 at 11:33 AM, Kevin Wolf kw...@redhat.com wrote: Without this, qemu segfaults when a BH handler first deletes its BH and then calls another function which involves a nested qemu_bh_poll() call. This can be reproduced by generating an I/O error (e.g. with blkdebug) on an

Re: [Qemu-devel] [PATCH 00/13] QED image streaming

2011-06-15 Thread Stefan Hajnoczi
On Wed, Jun 15, 2011 at 11:46 AM, Philipp Hahn h...@univention.de wrote: On Tuesday 14 June 2011 20:18:18 Stefan Hajnoczi wrote: This patch series adds image streaming support for QED image files.  Other image formats can also be supported in the future. Image streaming populates the file in

[Qemu-devel] [PATCH v2 3/3] vdi: Avoid direct AIO callback

2011-06-15 Thread Kevin Wolf
bdrv_aio_* must not call the callback before returning to its caller. In vdi, this could happen in some error cases. This starts the real requests processing in a BH to avoid this situation. Signed-off-by: Kevin Wolf kw...@redhat.com --- v2: - Remove direct vdi_aio_read_cb() call block/vdi.c |

Re: [Qemu-devel] [RFC] Specifying storage devices for live migration

2011-06-15 Thread Stefan Hajnoczi
On Wed, Jun 15, 2011 at 12:06 PM, Avishay Traeger avis...@il.ibm.com wrote: Hello all, Currently there is no way to choose storage devices to be migrated.  There was some discussion about making the monitor API a bit more flexible, but the code was never written:

Re: [Qemu-devel] [PATCH] CPU consumption optimization of 'qemu-img convert' using bdrv_is_allocated()

2011-06-15 Thread Dmitry Konishchev
On Wed, Jun 15, 2011 at 4:02 PM, Stefan Hajnoczi stefa...@gmail.com wrote: We need to fully understand performance before applying optimizations on top.  Otherwise it is possible to paper over a problem while leaving the root cause unsolved.  Avoiding lseek(2) is very important, not just for

[Qemu-devel] [PATCH v2][uq/master] kvm: x86: Save/restore FPU OP, IP and DP

2011-06-15 Thread Jan Kiszka
These FPU states are properly maintained by KVM but not yet by TCG. So far we unconditionally set them to 0 in the guest which may cause state corruptions, though not with modern guests. To avoid breaking backward migration, use a conditional subsection that is only written if any of the three

Re: [Qemu-devel] [PATCH] CPU consumption optimization of 'qemu-img convert' using bdrv_is_allocated()

2011-06-15 Thread Stefan Hajnoczi
On Wed, Jun 15, 2011 at 2:14 PM, Dmitry Konishchev konishc...@gmail.com wrote: On Wed, Jun 15, 2011 at 4:02 PM, Stefan Hajnoczi stefa...@gmail.com wrote: We need to fully understand performance before applying optimizations on top.  Otherwise it is possible to paper over a problem while

Re: [Qemu-devel] [PATCH] error framework: Fix compilation for w32/w64

2011-06-15 Thread Luiz Capitulino
On Mon, 13 Jun 2011 23:01:53 +0200 Stefan Weil w...@mail.berlios.de wrote: The declaration of function error_set() should use macro GCC_FMT_ATTR instead of gcc's format printf attribute. For w32/w64, both declarations are different and GCC_FMT_ATTR is needed. Compilation for w64 even failed

[Qemu-devel] [PATCH v2] ide: Clear error_status after restarting flush

2011-06-15 Thread Kevin Wolf
Clearing the error status flag was missing for restarting flushes. Now that the error status is separate from the BM status register, we can simply set it to 0 after restarting the request. This ensures that we never forget to clear a bit. Signed-off-by: Kevin Wolf kw...@redhat.com ---

[Qemu-devel] [PATCH] qemu-img: Add cache command line option

2011-06-15 Thread Federico Simoncelli
qemu-img currently writes disk images using writeback and filling up the cache buffers which are then flushed by the kernel preventing other processes from accessing the storage. This is particularly bad in cluster environments where time-based algorithms might be in place and accessing the

Re: [Qemu-devel] [PATCH] CPU consumption optimization of 'qemu-img convert' using bdrv_is_allocated()

2011-06-15 Thread Dmitry Konishchev
On Wed, Jun 15, 2011 at 5:33 PM, Stefan Hajnoczi stefa...@gmail.com wrote: disable caching? Image geometry caching. I meant If I call bdrv_get_geometry() every time I need image geometry instead of obtaining it from bs_geometry variable. -- Дмитрий Конищев (Dmitry Konishchev)

Re: [Qemu-devel] [PATCH] CPU consumption optimization of 'qemu-img convert' using bdrv_is_allocated()

2011-06-15 Thread Stefan Hajnoczi
2011/6/15 Dmitry Konishchev konishc...@gmail.com: On Wed, Jun 15, 2011 at 5:33 PM, Stefan Hajnoczi stefa...@gmail.com wrote: disable caching? Image geometry caching. I meant If I call bdrv_get_geometry() every time I need image geometry instead of obtaining it from bs_geometry variable.

[Qemu-devel] [PATCHv2] qemu-img: Add cache command line option

2011-06-15 Thread Federico Simoncelli
qemu-img currently writes disk images using writeback and filling up the cache buffers which are then flushed by the kernel preventing other processes from accessing the storage. This is particularly bad in cluster environments where time-based algorithms might be in place and accessing the

[Qemu-devel] [PATCH 04/14] vdi: Avoid direct AIO callback

2011-06-15 Thread Kevin Wolf
bdrv_aio_* must not call the callback before returning to its caller. In vdi, this could happen in some error cases. This starts the real requests processing in a BH to avoid this situation. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/vdi.c | 41

[Qemu-devel] [PATCH 09/14] ide: Add forgotten VMSTATE_END_OF_LIST in subsection

2011-06-15 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com --- hw/ide/core.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index e5def8b..399b74c 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -1864,6 +1864,7 @@ const VMStateDescription

[Qemu-devel] [PATCH 06/14] qcow2: Fix in-flight list after qcow2_cache_put failure

2011-06-15 Thread Kevin Wolf
If qcow2_cache_put returns an error during cluster allocation and the allocation fails, it must be removed from the list of in-flight allocations. Otherwise we'd get a loop in the list when the ACB is used for the next allocation. Luckily, this qcow2_cache_put shouldn't fail anyway because the L2

[Qemu-devel] [PATCH 01/14] block/rbd: Remove unused local variable

2011-06-15 Thread Kevin Wolf
From: Stefan Weil w...@mail.berlios.de Variable 'snap' is assigned a value that is never used. Remove snap and the related code. Cc: Christian Brunner c...@muc.de Cc: Josh Durgin josh.dur...@dreamhost.com Cc: Kevin Wolf kw...@redhat.com Signed-off-by: Stefan Weil w...@mail.berlios.de

[Qemu-devel] [PATCH 02/14] qcow2: Avoid direct AIO callback

2011-06-15 Thread Kevin Wolf
bdrv_aio_* must not call the callback before returning to its caller. In qcow2, this could happen in some error cases. This starts the real requests processing in a BH to avoid this situation. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2.c | 39

[Qemu-devel] [PATCH 03/14] qcow: Avoid direct AIO callback

2011-06-15 Thread Kevin Wolf
bdrv_aio_* must not call the callback before returning to its caller. In qcow, this could happen in some error cases. This starts the real requests processing in a BH to avoid this situation. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow.c | 58

[Qemu-devel] [PATCH 05/14] Replaced tabs with spaces in block.h and block_int.h

2011-06-15 Thread Kevin Wolf
From: Devin Nakamura devin...@gmail.com Signed-off-by: Devin Nakamura devin...@gmail.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block.h |6 +++--- block_int.h |4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/block.h b/block.h index da7d39c..859d1d9

[Qemu-devel] [PULL 00/14] Block patches

2011-06-15 Thread Kevin Wolf
The following changes since commit 0b862cedf36d927818c50584ddd611b0370673df: configure: Detect and don't try to use older libcurl (2011-06-13 21:16:27 +0200) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Christoph Hellwig (3): make dma_bdrv_io

[Qemu-devel] [PATCH 08/14] ide: Fix ide_drive_pio_state_needed()

2011-06-15 Thread Kevin Wolf
When a failed PIO request caused the VM to stop, we still need to transfer the PIO state even though DRQ=0 at this point. Signed-off-by: Kevin Wolf kw...@redhat.com --- hw/ide/core.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index

[Qemu-devel] [PATCH 11/14] ide: allow other dma comands than read and write

2011-06-15 Thread Kevin Wolf
From: Christoph Hellwig h...@lst.de Replace the is_read flag with a dma_cmd flag to allow the dma and restart logic to handler other commands like TRIM. Signed-off-by: Christoph Hellwig h...@lst.de Signed-off-by: Kevin Wolf kw...@redhat.com --- hw/ide/core.c | 25 ++---

[Qemu-devel] [PATCH 07/14] ide: Split error status from status register

2011-06-15 Thread Kevin Wolf
When adding the werror=stop mode, some flags were added to s-status which are used to determine what kind of operation should be restarted when the VM is continued. Unfortunately, it turns out that s-status is in fact a device register and as such is visible to the guest (some of the abused bits

Re: [Qemu-devel] [PATCH] Fix signal handling of SIG_IPI when io-thread is enabled

2011-06-15 Thread Alexandre Raymond
Hi Jan, Why? Ahh, because of qemu_cpu_kick_self: raise(SIG_IPI)! That should generate a per-process SIG_IPI. And that may not only affect Darwin. Looks good. Actually, with io-thread enabled, it goes through qemu_cpu_kick_self() - qemu_cpu_kick_thread() - pthread_kill(..., SIG_IPI). I think

[Qemu-devel] [PATCH 13/14] ide: Clear error_status after restarting flush

2011-06-15 Thread Kevin Wolf
Clearing the error status flag was missing for restarting flushes. Now that the error status is separate from the BM status register, we can simply set it to 0 after restarting the request. This ensures that we never forget to clear a bit. Signed-off-by: Kevin Wolf kw...@redhat.com ---

[Qemu-devel] [PATCH 10/14] make dma_bdrv_io available to drivers

2011-06-15 Thread Kevin Wolf
From: Christoph Hellwig h...@lst.de Make dma_bdrv_io available for drivers, and pass an explicit I/O function instead of hardcoding bdrv_aio_readv/bdrv_aio_writev. This is required to implement non-READ/WRITE dma commands in the ide driver, e.g. the upcoming TRIM support. Signed-off-by:

Re: [Qemu-devel] [PULL 00/14] Block patches

2011-06-15 Thread Anthony Liguori
On 06/15/2011 09:02 AM, Kevin Wolf wrote: The following changes since commit 0b862cedf36d927818c50584ddd611b0370673df: configure: Detect and don't try to use older libcurl (2011-06-13 21:16:27 +0200) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony

[Qemu-devel] [PATCH 12/14] ide: add TRIM support

2011-06-15 Thread Kevin Wolf
From: Christoph Hellwig h...@lst.de Add support for TRIM sub function of the data set management command, and wire it up to the qemu discard infrastructure. Signed-off-by: Christoph Hellwig h...@lst.de Signed-off-by: Kevin Wolf kw...@redhat.com --- hw/ide/core.c | 97

[Qemu-devel] [PATCH 14/14] Allow nested qemu_bh_poll() after BH deletion

2011-06-15 Thread Kevin Wolf
Without this, qemu segfaults when a BH handler first deletes its BH and then calls another function which involves a nested qemu_bh_poll() call. This can be reproduced by generating an I/O error (e.g. with blkdebug) on an IDE device and using rerror/werror=stop to stop the VM. When continuing the

Re: [Qemu-devel] [PATCH 33/34] hw/usb-ohci.c: Implement remote wakeup

2011-06-15 Thread Peter Maydell
On 14 June 2011 12:05, Gerd Hoffmann kra...@redhat.com wrote: From: Peter Maydell peter.mayd...@linaro.org Implement the wakeup callback in the OHCI USBPortOps, so that when a downstream device wakes up it correctly causes the OHCI controller to come out of suspend. Just to let you know,

Re: [Qemu-devel] [PATCH 0/2] [PULL] qemu-kvm.git uq/master queue

2011-06-15 Thread Anthony Liguori
On 06/01/2011 12:31 PM, Marcelo Tosatti wrote: The following changes since commit 578c7b2ca8ee9e97fa8693b1a83d517e8e3f962e: audio: fix integer overflow expression (2011-06-01 00:14:07 +0400) Pulled. Thanks. Regards, Anthony Liguori are available in the git repository at:

Re: [Qemu-devel] [PATCH 1/2] Allow silent system resets

2011-06-15 Thread Luiz Capitulino
On Tue, 14 Jun 2011 18:29:43 +0200 Jan Kiszka jan.kis...@siemens.com wrote: This allows qemu_system_reset to be issued silently for internal purposes, ie. without sending out a monitor event. Convert the system reset after startup to the silent mode. Signed-off-by: Jan Kiszka

Re: [Qemu-devel] [PULL] libcacard libtoolized + usb-ccid fix

2011-06-15 Thread Anthony Liguori
On 05/31/2011 11:42 AM, Alon Levy wrote: Hi, This pull request includes the libcacard.la library target and a memory leak fix by Markus. Please pull. The following changes since commit b1d7d2b93a1d6b2d2848b616cc35acdf521c923c: Merge remote-tracking branch 'stefanha/trivial-patches' into

Re: [Qemu-devel] [PULL] usb patch queue

2011-06-15 Thread Anthony Liguori
On 06/14/2011 06:05 AM, Gerd Hoffmann wrote: Hi, The USB patch queue has been rebased, got a minor fix (wrong comment in patch #8, spotted by David Ahern) and three new patches. I'm just posting the three new patches to avoid spamming the list with 30 identical patches ... please pull,

Re: [Qemu-devel] [PATCH v3 04/21] qapi: add QAPI visitor core

2011-06-15 Thread Luiz Capitulino
On Mon, 13 Jun 2011 21:31:09 -0500 Michael Roth mdr...@linux.vnet.ibm.com wrote: Base definitions/includes for Visiter interface used by generated visiter/marshalling code. Includes a GenericList type. Our lists require an embedded element. Since these types are generated, if you want to

Re: [Qemu-devel] [RFC] Specifying storage devices for live migration

2011-06-15 Thread Avishay Traeger
Stefan Hajnoczi stefa...@gmail.com wrote on 15/06/2011 15:49:12: Hello all, Currently there is no way to choose storage devices to be migrated. There was some discussion about making the monitor API a bit more flexible, but the code was never written:

Re: [Qemu-devel] [PATCH v3 04/21] qapi: add QAPI visitor core

2011-06-15 Thread Michael Roth
On 06/15/2011 09:33 AM, Luiz Capitulino wrote: On Mon, 13 Jun 2011 21:31:09 -0500 Michael Rothmdr...@linux.vnet.ibm.com wrote: Base definitions/includes for Visiter interface used by generated visiter/marshalling code. Includes a GenericList type. Our lists require an embedded element. Since

Re: [Qemu-devel] [PATCH v3 05/21] qapi: add QMP input visitor

2011-06-15 Thread Luiz Capitulino
On Mon, 13 Jun 2011 21:31:10 -0500 Michael Roth mdr...@linux.vnet.ibm.com wrote: A type of Visiter class that is used to walk a qobject's structure and assign each entry to the corresponding native C type. Command marshaling function will use this to pull out QMP command parameters recieved

Re: [Qemu-devel] [RFC PATCH] virtio-9p: Use clone approach to fix TOCTOU vulnerability

2011-06-15 Thread Stefan Hajnoczi
On Tue, Jun 14, 2011 at 9:12 AM, M. Mohan Kumar mo...@in.ibm.com wrote: [RFC PATCH] virtio-9p: Use clone approach to fix TOCTOU vulnerability In passthrough security model, following a symbolic link in the server side could result in TOCTTOU vulnerability. Use clone system call to create a

Re: [Qemu-devel] [Xen-devel] Re: [PATCH] xen: fix interrupt routing

2011-06-15 Thread Stefano Stabellini
On Wed, 15 Jun 2011, Alexander Graf wrote: commit 973bb091a967fdec37a1bc8fe30d46a483d2903d Author: Stefano Stabellini stefano.stabell...@eu.citrix.com Date: Tue May 17 12:10:36 2011 + xen: fix interrupt routing - remove i440FX-xen and i440fx_write_config_xen we

Re: [Qemu-devel] [PATCH 10/10] linux-user: remove unused variables

2011-06-15 Thread Alexander Graf
On 14.06.2011, at 19:36, Michael S. Tsirkin wrote: Signed-off-by: Michael S. Tsirkin m...@redhat.com --- linux-user/flatload.c | 10 ++ linux-user/linuxload.c | 25 + linux-user/main.c |6 +++--- linux-user/signal.c|5 -

Re: [Qemu-devel] [PATCH 06/10] kvm: remove unused variables

2011-06-15 Thread Kevin Wolf
Am 14.06.2011 19:36, schrieb Michael S. Tsirkin: Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/virtio-pci.h |8 +--- target-i386/kvm.c |3 +-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/hw/virtio-pci.h b/hw/virtio-pci.h index a4b5fd3..b518917

Re: [Qemu-devel] [PATCH 03/10] usb-ehci: remove unused variables

2011-06-15 Thread Gerd Hoffmann
On 06/14/11 19:35, Michael S. Tsirkin wrote: Signed-off-by: Michael S. Tsirkinm...@redhat.com usb patch queue has a simliar fix already. I'd suggest to drop this to reduce merge conflicts. cheers, Gerd

Re: [Qemu-devel] [PATCH 06/10] kvm: remove unused variables

2011-06-15 Thread Michael S. Tsirkin
On Wed, Jun 15, 2011 at 09:38:39AM +0200, Kevin Wolf wrote: Am 14.06.2011 19:36, schrieb Michael S. Tsirkin: Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/virtio-pci.h |8 +--- target-i386/kvm.c |3 +-- 2 files changed, 6 insertions(+), 5 deletions(-) diff

Re: [Qemu-devel] [PATCH 06/10] kvm: remove unused variables

2011-06-15 Thread Chris Krumme
On 06/14/2011 12:36 PM, Michael S. Tsirkin wrote: Signed-off-by: Michael S. Tsirkinm...@redhat.com --- hw/virtio-pci.h |8 +--- target-i386/kvm.c |3 +-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/hw/virtio-pci.h b/hw/virtio-pci.h index a4b5fd3..b518917

Re: [Qemu-devel] [PATCH 10/10] linux-user: remove unused variables

2011-06-15 Thread Michael S. Tsirkin
On Wed, Jun 15, 2011 at 10:35:19AM +0200, Alexander Graf wrote: On 14.06.2011, at 19:36, Michael S. Tsirkin wrote: Signed-off-by: Michael S. Tsirkin m...@redhat.com --- linux-user/flatload.c | 10 ++ linux-user/linuxload.c | 25 + linux-user/main.c

Re: [Qemu-devel] [PATCH 04/10] lsi53c895a: remove unused variables

2011-06-15 Thread Stefan Hajnoczi
On Tue, Jun 14, 2011 at 08:35:44PM +0300, Michael S. Tsirkin wrote: Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/lsi53c895a.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) This one is already in the trivial-patches tree. Stefan

Re: [Qemu-devel] [patch 6/7] QEMU live block copy (update)

2011-06-15 Thread Marcelo Tosatti
On Tue, Jun 07, 2011 at 12:15:55PM +0200, Jiri Denemark wrote: On Mon, Jun 06, 2011 at 14:03:44 -0300, Marcelo Tosatti wrote: ... + return:[ +{device:ide1-hd0, +status:active, +info:{ + percentage:23, +} +},

Re: [Qemu-devel] [PATCH 10/10] linux-user: remove unused variables

2011-06-15 Thread Richard Henderson
On 06/15/2011 01:35 AM, Alexander Graf wrote: -abi_ulong arg5 = 0, arg6 = 0, arg7 = 0, arg8 = 0; +abi_ulong arg5 = 0, arg6 = 0; nb_args = mips_syscall_args[syscall_num]; sp_reg = env-active_tc.gpr[29]; switch

Re: [Qemu-devel] [PATCH] xen: avoid tracking the region 0xa0000 - 0xbffff

2011-06-15 Thread Stefano Stabellini
On Wed, 15 Jun 2011, Alexander Graf wrote: Please add a comment here, explaining that Xen can only handle a single dirty log region for now, and that we want the linear framebuffer to be that region. Also, please resend with proper patch headers and I'll pull it into the xen-next tree.

[Qemu-devel] [PATCH] xen: only track the linear framebuffer

2011-06-15 Thread Stefano Stabellini
Xen can only do dirty bit tracking for one memory region, so we should explicitly avoid trying to track anything but the vga vram region. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com diff --git a/xen-all.c b/xen-all.c index 9a5c3ec..fa1d2e1 100644 --- a/xen-all.c +++

[Qemu-devel] [PATCH 1/2] lsi: Fix unused-but-set-variable warning

2011-06-15 Thread Stefan Hajnoczi
From: Christophe Fergeau cferg...@redhat.com This warning is new in gcc 4.6. Signed-off-by: Christophe Fergeau cferg...@redhat.com Acked-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- hw/lsi53c895a.c |2 -- 1 files changed, 0

Re: [Qemu-devel] [RFC PATCH] virtio-9p: Use clone approach to fix TOCTOU vulnerability

2011-06-15 Thread Stefan Hajnoczi
On Tue, Jun 14, 2011 at 9:12 AM, M. Mohan Kumar mo...@in.ibm.com wrote: [RFC PATCH] virtio-9p: Use clone approach to fix TOCTOU vulnerability In passthrough security model, following a symbolic link in the server side could result in TOCTTOU vulnerability. Use clone system call to create a

[Qemu-devel] [RFC] qxl: set mm_time in vga update

2011-06-15 Thread Alon Levy
This fixes a problem where on windows 7 startup phase, before the qxl driver is loaded, the drawables are sufficiently large and video like to trigger a stream, but the lack of a filled mm time field triggers a warning in spice-gtk. --- ui/spice-display.c |5 + 1 files changed, 5

Re: [Qemu-devel] [Xen-devel] Re: [PATCH] xen: fix interrupt routing

2011-06-15 Thread Avi Kivity
On 06/15/2011 11:24 AM, Alexander Graf wrote: I'm actually not quite sure what exactly he's describing here. But if it's bypassing the bus logic, it's not a normal PCI device :). Sure, there are special case devices that also expose a PCI interface. But real PCI cards that you plug in onto

[Qemu-devel] [PATCH 2/2] Fix typo in cpus.c

2011-06-15 Thread Stefan Hajnoczi
From: Alexandre Raymond cerb...@gmail.com filed - failed Signed-off-by: Alexandre Raymond cerb...@gmail.com Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- cpus.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/cpus.c b/cpus.c index 1fc34b7..4ab76f0

[Qemu-devel] [patch 0/4] live block copy (v5)

2011-06-15 Thread Marcelo Tosatti
v5: - fix several leaks in block-copy and blkmirror - change progress status reporting - support migration - fix buffer overwrite bug in blkmirror v4: - add block-copy documentation - block-copy style fixes - fix blkmirror_cancel method - blkmirror style fixes - add escaping to blkmirror

[Qemu-devel] [PULL 0/2] Trivial patches for June 9 to June 15 2011

2011-06-15 Thread Stefan Hajnoczi
The following changes since commit 71f34ad05359d7fa97996562d904979281ddc7f5: Merge remote-tracking branch 'alon/pull-libcacard-1' into staging (2011-06-15 09:03:49 -0500) are available in the git repository at: ssh://repo.or.cz/srv/git/qemu/stefanha.git trivial-patches Alexandre Raymond

[Qemu-devel] [PATCH v2] xen: fix interrupt routing

2011-06-15 Thread Stefano Stabellini
Compared to the last version I only added a comment to the code. - remove i440FX-xen and i440fx_write_config_xen we don't need to intercept pci config writes to i440FX anymore; - introduce PIIX3-xen and piix3_write_config_xen we do need to intercept pci config write to the PCI-ISA bridge to

Re: [Qemu-devel] [RFC] Specifying storage devices for live migration

2011-06-15 Thread Marcelo Tosatti
On Wed, Jun 15, 2011 at 02:22:22PM -0300, Marcelo Tosatti wrote: On Wed, Jun 15, 2011 at 02:06:21PM +0300, Avishay Traeger wrote: Hello all, Currently there is no way to choose storage devices to be migrated. There was some discussion about making the monitor API a bit more flexible,

Re: [Qemu-devel] [Xen-devel] Re: [PATCH] xen: fix interrupt routing

2011-06-15 Thread Alexander Graf
Am 15.06.2011 um 18:34 schrieb Avi Kivity a...@redhat.com: On 06/15/2011 11:24 AM, Alexander Graf wrote: I'm actually not quite sure what exactly he's describing here. But if it's bypassing the bus logic, it's not a normal PCI device :). Sure, there are special case devices that also

Re: [Qemu-devel] [PATCH] Command line support for altering the log file location

2011-06-15 Thread Blue Swirl
Thanks, applied. On Wed, Jun 8, 2011 at 5:32 AM, Matthew Fernandez matthew.fernan...@gmail.com wrote: Add command line support for logging to a location other than /tmp/qemu.log. With logging enabled (command line option -d), the log is written to the hard-coded path /tmp/qemu.log. This patch

Re: [Qemu-devel] [RFC] Specifying storage devices for live migration

2011-06-15 Thread Marcelo Tosatti
On Wed, Jun 15, 2011 at 02:06:21PM +0300, Avishay Traeger wrote: Hello all, Currently there is no way to choose storage devices to be migrated. There was some discussion about making the monitor API a bit more flexible, but the code was never written:

Re: [Qemu-devel] [PATCH v3 05/21] qapi: add QMP input visitor

2011-06-15 Thread Luiz Capitulino
On Wed, 15 Jun 2011 11:56:03 -0500 Michael Roth mdr...@linux.vnet.ibm.com wrote: On 06/15/2011 11:11 AM, Luiz Capitulino wrote: On Mon, 13 Jun 2011 21:31:10 -0500 Michael Rothmdr...@linux.vnet.ibm.com wrote: snip +Visitor *qmp_input_get_visitor(QmpInputVisitor *v) +{ +

Re: [Qemu-devel] [PATCH v3 05/21] qapi: add QMP input visitor

2011-06-15 Thread Michael Roth
On 06/15/2011 11:11 AM, Luiz Capitulino wrote: On Mon, 13 Jun 2011 21:31:10 -0500 Michael Rothmdr...@linux.vnet.ibm.com wrote: snip +Visitor *qmp_input_get_visitor(QmpInputVisitor *v) +{ +returnv-visitor; +} + +void qmp_input_visitor_cleanup(QmpInputVisitor *v) +{ You're not

[Qemu-devel] [PATCH] Added legacy 9P2000 support back into QEMU

2011-06-15 Thread William K. Bittner
It was tested with v9fs in the guest by using: sudo mount -t 9p -o trans=virtio,version=9p2000 v_boot /pmnt Signed-off-by: William K. Bittner wkbit...@us.ibm.com diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c index b5fc52b..febfba2 100644 --- a/hw/9pfs/virtio-9p.c +++

  1   2   >