Re: [Qemu-devel] [PATCH 12/12] Add disk_size field to BlockDriverState structure

2011-06-20 Thread Stefan Hajnoczi
On Mon, Jun 20, 2011 at 6:37 AM, Fam Zheng famc...@gmail.com wrote: Is there any difference between bdrv_getlength and bdrv_get_allocated_file_size for bs-file? If not, I can simplify it by reusing it in two raw devices. Yes, the two functions are different: POSIX sparse files (files with

[Qemu-devel] [PATCH v3] linux-user: Define AT_RANDOM to support target stack protection mechanism.

2011-06-20 Thread Cédric VINCENT
From: Laurent ALFONSI laurent.alfo...@st.com Note that the support for the command-line argument requires: 1. add the new field uint8_t rand_bytes[16] to struct image_info since only the variable info lives both in main() and in create_elf_tables() 2. write a dedicated

Re: [Qemu-devel] [PATCH 1/3] kvm: ppc: booke206: use MMU API

2011-06-20 Thread Jan Kiszka
On 2011-06-18 01:28, Alexander Graf wrote: On 17.06.2011, at 22:39, Scott Wood wrote: Share the TLB array with KVM. This allows us to set the initial TLB both on initial boot and reset, is useful for debugging, and could eventually be used to support migration. Signed-off-by: Scott Wood

[Qemu-devel] KVM call agenda for June 21

2011-06-20 Thread Juan Quintela
Please send in any agenda items you are interested in covering. thanks, -juan

Re: [Qemu-devel] [PATCH 1/3] kvm: ppc: booke206: use MMU API

2011-06-20 Thread Avi Kivity
On 06/20/2011 10:41 AM, Jan Kiszka wrote: Those hopefully shouldn't be required anymore soon - when Jan's patches make it upstream. Jan, how's progress on that front? I can only forward this question: Avi, what are the plans for http://thread.gmane.org/gmane.comp.emulators.kvm.devel/73917?

Re: [Qemu-devel] [PATCH] Optimize screendump

2011-06-20 Thread Avi Kivity
On 06/19/2011 08:00 PM, Alexander Graf wrote: On 19.06.2011, at 18:04, Avi Kivity wrote: On 06/19/2011 06:53 PM, Andreas Färber wrote: Am 19.06.2011 um 17:46 schrieb Avi Kivity: On 06/19/2011 06:22 PM, Stefan Hajnoczi wrote: I wonder if this will break non-Linux platforms. Perhaps

[Qemu-devel] [PATCH v2] Optimize screendump

2011-06-20 Thread Avi Kivity
When running kvm-autotest, fputc() is often the second highest (sometimes #1) function showing up in a profile. This is due to fputc() locking the file for every byte written. Optimize by buffering a line's worth of pixels and writing that out in a single call. Signed-off-by: Avi Kivity

[Qemu-devel] [PATCH] Support logging xen-guest console

2011-06-20 Thread Chunyan Liu
Add code to support logging xen-domU console, as what xenconsoled does. Log info will be saved in /var/log/xen/console/guest-domUname.log. Signed-off-by: Chunyan Liu cy...@novell.com --- hw/xen_console.c | 63 ++ 1 files changed, 63

[Qemu-devel] [PULL] Xen Patch Queue

2011-06-20 Thread Alexander Graf
Hi Anthony, This is my current patch queue for Xen patches. Please pull. Alex The following changes since commit eb47d7c5d96060040931c42773ee07e61e547af9: Peter Maydell (1): hw/9118.c: Implement active-low interrupt support are available in the git repository at:

Re: [Qemu-devel] [PATCH 3/3] xen: implement unplug protocol in xen_platform

2011-06-20 Thread Michael S. Tsirkin
On Thu, Jun 16, 2011 at 05:05:19PM +0100, stefano.stabell...@eu.citrix.com wrote: From: Stefano Stabellini stefano.stabell...@eu.citrix.com The unplug protocol is necessary to support PV drivers in the guest: the drivers expect to be able to unplug emulated disks and nics before

Re: [Qemu-devel] [PATCH 2/3] pci: export pci_unplug_device

2011-06-20 Thread Michael S. Tsirkin
On Thu, Jun 16, 2011 at 05:05:18PM +0100, stefano.stabell...@eu.citrix.com wrote: From: Stefano Stabellini stefano.stabell...@eu.citrix.com pci_unplug_device is needed by the xen_platform device to perfom dynamic nic unplug. Signed-off-by: Stefano Stabellini

Re: [Qemu-devel] [PATCH 1/3] kvm: ppc: booke206: use MMU API

2011-06-20 Thread Jan Kiszka
On 2011-06-20 10:03, Avi Kivity wrote: On 06/20/2011 10:41 AM, Jan Kiszka wrote: Those hopefully shouldn't be required anymore soon - when Jan's patches make it upstream. Jan, how's progress on that front? I can only forward this question: Avi, what are the plans for

Re: [Qemu-devel] [PATCH 3/3] xen: implement unplug protocol in xen_platform

2011-06-20 Thread Kevin Wolf
Am 20.06.2011 10:28, schrieb Alexander Graf: On 16.06.2011, at 18:05, stefano.stabell...@eu.citrix.com stefano.stabell...@eu.citrix.com wrote: From: Stefano Stabellini stefano.stabell...@eu.citrix.com The unplug protocol is necessary to support PV drivers in the guest: the drivers

Re: [Qemu-devel] [PATCH] do not send packet to nic if the packet will be dropped by nic

2011-06-20 Thread Kevin Wolf
Am 17.06.2011 03:33, schrieb Wen Congyang: If !s-clock_enabled or !rtl8139_receiver_enabled(s), it means that the nic will drop all packets from host. So qemu will keep getting packets from host and wasting CPU on dropping packets. This seems worse than packets that should be dropped but

Re: [Qemu-devel] [PATCH 1/3] kvm: ppc: booke206: use MMU API

2011-06-20 Thread Avi Kivity
On 06/20/2011 11:47 AM, Jan Kiszka wrote: On 2011-06-20 10:03, Avi Kivity wrote: On 06/20/2011 10:41 AM, Jan Kiszka wrote: Those hopefully shouldn't be required anymore soon - when Jan's patches make it upstream. Jan, how's progress on that front? I can only forward this question: Avi,

[Qemu-devel] [PATCH] Support logging xen-guest console

2011-06-20 Thread Chunyan Liu
Add code to support logging xen-domU console, as what xenconsoled does. Log info will be saved in /var/log/xen/console/guest-domUname.log. Signed-off-by: Chunyan Liu cy...@novell.com --- hw/xen_console.c | 63 ++ 1 files changed, 63

Re: [Qemu-devel] [PATCH] vmstate: Add unmigratable flag

2011-06-20 Thread Jan Kiszka
On 2011-06-19 22:46, Cam Macdonell wrote: On Thu, Jun 9, 2011 at 2:39 PM, Jan Kiszka jan.kis...@web.de wrote: On 2011-06-09 22:00, Anthony Liguori wrote: On 06/09/2011 11:44 AM, Jan Kiszka wrote: A first step towards getting rid of register_device_unmigratable (ivshmem and lacking vmstate

[Qemu-devel] Extracting TCG

2011-06-20 Thread Mathieu SUEN
Hi All, TCG look very interesting for generating machine code. Is they a way to extract it as a stand alone library in other to use it in for JIT compiler? Thanks -- Mathieu

[Qemu-devel] [PATCH 08/11] cirrus_vga: reset lfb_addr after a pci config write if the BAR is unmapped

2011-06-20 Thread Alexander Graf
From: Stefano Stabellini stefano.stabell...@eu.citrix.com If the cirrus_vga PCI BAR is unmapped than we should not only reset map_addr but also lfb_addr, otherwise we'll keep trying to map the old lfb_addr in map_linear_vram. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com

[Qemu-devel] [PATCH 09/11] xen: only track the linear framebuffer

2011-06-20 Thread Alexander Graf
From: Stefano Stabellini stefano.stabell...@eu.citrix.com Xen can only do dirty bit tracking for one memory region, so we should explicitly avoid trying to track anything but the vga vram region. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Signed-off-by: Alexander Graf

[Qemu-devel] [PATCH 06/11] exec.c: refactor cpu_physical_memory_map

2011-06-20 Thread Alexander Graf
From: Stefano Stabellini stefano.stabell...@eu.citrix.com Introduce qemu_ram_ptr_length that takes an address and a size as parameters rather than just an address. Refactor cpu_physical_memory_map so that we call qemu_ram_ptr_length only once rather than calling qemu_get_ram_ptr one time per

[Qemu-devel] [PATCH 04/11] xen: remove qemu_map_cache_unlock

2011-06-20 Thread Alexander Graf
From: Stefano Stabellini stefano.stabell...@eu.citrix.com There is no need for qemu_map_cache_unlock, just use qemu_invalidate_entry instead. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Signed-off-by: Alexander Graf ag...@suse.de --- exec.c |2 +-

[Qemu-devel] [PATCH 01/11] xen: Add xc_domain_add_to_physmap to xen_interface.

2011-06-20 Thread Alexander Graf
From: Anthony PERARD anthony.per...@citrix.com This function will be used to support sync dirty bitmap. This come with a check against every Xen release, and special implementation for Xen version that doesn't have this specific call. This function will not be usable with Xen 3.3 because the

[Qemu-devel] [PATCH 10/11] xen: fix interrupt routing

2011-06-20 Thread Alexander Graf
From: Stefano Stabellini stefano.stabell...@eu.citrix.com Compared to the last version I only added a comment to the code. - remove i440FX-xen and i440fx_write_config_xen we don't need to intercept pci config writes to i440FX anymore; - introduce PIIX3-xen and piix3_write_config_xen we do need

[Qemu-devel] [PATCH 05/11] xen: remove xen_map_block and xen_unmap_block

2011-06-20 Thread Alexander Graf
From: Stefano Stabellini stefano.stabell...@eu.citrix.com Replace xen_map_block with qemu_map_cache with the appropriate locking and size parameters. Replace xen_unmap_block with qemu_invalidate_entry. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Signed-off-by: Alexander

[Qemu-devel] [PATCH] virtio-blk: Turn drive serial into a qdev property

2011-06-20 Thread Markus Armbruster
It needs to be a qdev property, because it belongs to the drive's guest part. Precedence: commit a0fef654 and 6ced55a5. Bonus: info qtree now shows the serial number. Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/s390-virtio-bus.c |4 +++- hw/s390-virtio-bus.h |1 +

[Qemu-devel] [PATCH 11/11] xen: Add the Xen platform pci device

2011-06-20 Thread Alexander Graf
From: Steven Smith ssm...@xensource.com Introduce a new emulated PCI device, specific to fully virtualized Xen guests. The device is necessary for PV on HVM drivers to work. Signed-off-by: Steven Smith ssm...@xensource.com Signed-off-by: Anthony PERARD anthony.per...@citrix.com Signed-off-by:

[Qemu-devel] [PATCH 03/11] xen: fix qemu_map_cache with size != MCACHE_BUCKET_SIZE

2011-06-20 Thread Alexander Graf
From: Stefano Stabellini stefano.stabell...@eu.citrix.com Fix the implementation of qemu_map_cache: correctly support size arguments different from 0 or MCACHE_BUCKET_SIZE. The new implementation supports locked mapcache entries with size multiple of MCACHE_BUCKET_SIZE. qemu_invalidate_entry can

Re: [Qemu-devel] [PATCH] do not send packet to nic if the packet will be dropped by nic

2011-06-20 Thread Wen Congyang
At 06/20/2011 05:10 PM, Kevin Wolf Write: Am 17.06.2011 03:33, schrieb Wen Congyang: If !s-clock_enabled or !rtl8139_receiver_enabled(s), it means that the nic will drop all packets from host. So qemu will keep getting packets from host and wasting CPU on dropping packets. This seems worse

[Qemu-devel] [PATCH 02/11] xen: Introduce VGA sync dirty bitmap support

2011-06-20 Thread Alexander Graf
From: Anthony PERARD anthony.per...@citrix.com This patch introduces phys memory client for Xen. Only sync dirty_bitmap and set_memory are actually implemented. migration_log will stay empty for the moment. Xen can only log one range for bit change, so only the range in the first call will be

[Qemu-devel] [PATCH 07/11] xen: mapcache performance improvements

2011-06-20 Thread Alexander Graf
From: Stefano Stabellini stefano.stabell...@eu.citrix.com Use qemu_invalidate_entry in cpu_physical_memory_unmap. Do not lock mapcache entries in qemu_get_ram_ptr if the address falls in the ramblock with offset == 0. We don't need to do that because the callers of qemu_get_ram_ptr either try to

Re: [Qemu-devel] [PATCH] do not send packet to nic if the packet will be dropped by nic

2011-06-20 Thread Kevin Wolf
Am 20.06.2011 11:40, schrieb Wen Congyang: At 06/20/2011 05:10 PM, Kevin Wolf Write: Am 17.06.2011 03:33, schrieb Wen Congyang: If !s-clock_enabled or !rtl8139_receiver_enabled(s), it means that the nic will drop all packets from host. So qemu will keep getting packets from host and wasting

[Qemu-devel] [PATCH 0/2] Suspend (S3) support

2011-06-20 Thread Alon Levy
The first patch is a slightly revised patch send before, introducing a print helper (qxl_mode_to_string) that is used by the second patch too, hence I'm sending them together. I've looked for additional places to use qxl_mode_to_string like Gerd asked before, found just one. The second patch is

Re: [Qemu-devel] [PATCH] do not send packet to nic if the packet will be dropped by nic

2011-06-20 Thread Michael S. Tsirkin
On Mon, Jun 20, 2011 at 11:52:20AM +0200, Kevin Wolf wrote: Am 20.06.2011 11:40, schrieb Wen Congyang: At 06/20/2011 05:10 PM, Kevin Wolf Write: Am 17.06.2011 03:33, schrieb Wen Congyang: If !s-clock_enabled or !rtl8139_receiver_enabled(s), it means that the nic will drop all packets from

[Qemu-devel] [PATCH 1/2] qxl: interface_get_command: fix reported mode

2011-06-20 Thread Alon Levy
report correct mode when in undefined mode. introduces qxl_mode_to_string, and uses it in another place that looks helpful (qxl_post_load) --- hw/qxl.c | 21 ++--- 1 files changed, 18 insertions(+), 3 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 1906e84..ca5c8b3 100644

Re: [Qemu-devel] [PATCH 0/9] AREG0 patches

2011-06-20 Thread Kevin Wolf
Am 19.06.2011 23:55, schrieb Andreas Färber: Am 19.06.2011 um 22:57 schrieb Blue Swirl: These and the stack frame patches can be found in git://repo.or.cz/qemu/blueswirl.git Blue Swirl (9): cpu_loop_exit: avoid using AREG0 sparc: fix coding style of the area to be moved sparc: move

[Qemu-devel] [PATCH 2/2] qxl: add QXL_IO_UPDATE_MEM for guest S3S4 support

2011-06-20 Thread Alon Levy
Add QXL_IO_UPDATE_MEM. Used to reduce vmexits from the guest when it resets the spice server state before going to sleep. The implementation requires an updated spice-server (0.8.2) with the new worker function update_mem. Cc: Yonit Halperin yhalp...@redhat.com --- hw/qxl.c | 26

[Qemu-devel] [PATCH v2 0/3] Let RTC follow backward jumps of host clock immediately

2011-06-20 Thread Jan Kiszka
Just noticed that this issue is still unfixed because my series was somehow forgotten. So I've rebased it over current master, refactored it to use the generic Notifier infrastructure and renamed it to clock reset notifier to avoid confusion with icount related warping. Please review / apply

[Qemu-devel] [PATCH v2 3/3] mc146818rtc: Handle host clock resets

2011-06-20 Thread Jan Kiszka
Make use of the new clock reset notifier to update the RTC whenever rtc_clock is the host clock and that happens to jump backward. This avoids that the RTC stalls for the period the host clock was set back. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- hw/mc146818rtc.c | 20

Re: [Qemu-devel] [PATCH 2/2] qxl: add QXL_IO_UPDATE_MEM for guest S3S4 support

2011-06-20 Thread Gerd Hoffmann
Hi, +case QXL_IO_UPDATE_MEM: +switch (val) { +case (QXL_UPDATE_MEM_RENDER_ALL): +d-ssd.worker-update_mem(d-ssd.worker); +break; What is the difference to one worker-stop() + worker-start() cycle? cheers, Gerd

[Qemu-devel] [PATCH v2 1/3] notifier: Pass data argument to callback

2011-06-20 Thread Jan Kiszka
This allows to pass additional information to the notifier callback which is useful if sender and receiver do not share any other distinct data structure. Will be used first for the clock reset notifier. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- hw/fw_cfg.c |2 +- input.c

[Qemu-devel] [PATCH v2 2/3] qemu-timer: Introduce clock reset notifier

2011-06-20 Thread Jan Kiszka
QEMU_CLOCK_HOST is based on the system time which may jump backward in case the admin or NTP adjusts it. RTC emulations and other device models can suffer in this case as timers will stall for the period the clock was tuned back. This adds a detection mechanism that checks on every host clock

Re: [Qemu-devel] [PATCH v2] Optimize screendump

2011-06-20 Thread Jan Kiszka
On 2011-06-20 10:12, Avi Kivity wrote: When running kvm-autotest, fputc() is often the second highest (sometimes #1) function showing up in a profile. This is due to fputc() locking the file for every byte written. Optimize by buffering a line's worth of pixels and writing that out in a

Re: [Qemu-devel] [PATCH 2/2] qxl: add QXL_IO_UPDATE_MEM for guest S3S4 support

2011-06-20 Thread Alon Levy
On Mon, Jun 20, 2011 at 02:13:36PM +0200, Gerd Hoffmann wrote: Hi, +case QXL_IO_UPDATE_MEM: +switch (val) { +case (QXL_UPDATE_MEM_RENDER_ALL): +d-ssd.worker-update_mem(d-ssd.worker); +break; What is the difference to one worker-stop() +

Re: [Qemu-devel] [PATCH 2/2] qxl: add QXL_IO_UPDATE_MEM for guest S3S4 support

2011-06-20 Thread Alon Levy
On Mon, Jun 20, 2011 at 02:13:36PM +0200, Gerd Hoffmann wrote: Hi, +case QXL_IO_UPDATE_MEM: +switch (val) { +case (QXL_UPDATE_MEM_RENDER_ALL): +d-ssd.worker-update_mem(d-ssd.worker); +break; What is the difference to one worker-stop() +

Re: [Qemu-devel] [PATCH v2] Add support for fd: protocol

2011-06-20 Thread Corey Bryant
On 06/18/2011 04:50 PM, Blue Swirl wrote: On Thu, Jun 16, 2011 at 5:48 PM, Corey Bryantbrynt...@us.ibm.com wrote: On 06/15/2011 03:12 PM, Blue Swirl wrote: On Tue, Jun 14, 2011 at 4:31 PM, Corey Bryantbrynt...@us.ibm.comwrote: sVirt provides SELinux MAC isolation for Qemu guest

Re: [Qemu-devel] [PATCH v2] Optimize screendump

2011-06-20 Thread Avi Kivity
On 06/20/2011 03:33 PM, Jan Kiszka wrote: --- a/hw/vga.c +++ b/hw/vga.c @@ -2349,15 +2349,19 @@ int ppm_save(const char *filename, struct DisplaySurface *ds) Unrelated to this patch, but why is this function located in vga.c and not in console.c? It's located in omap_lcdc.c as well.

[Qemu-devel] [PATCH 1/1] fix operator precedence

2011-06-20 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio fredd...@gmail.com --- cmd.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/cmd.c b/cmd.c index db2c9c4..ecca167 100644 --- a/cmd.c +++ b/cmd.c @@ -486,7 +486,7 @@ timestr( snprintf(ts, size, %u:%02u.%02u,

Re: [Qemu-devel] [PATCH v2] Add support for fd: protocol

2011-06-20 Thread Avi Kivity
On 06/14/2011 04:31 PM, Corey Bryant wrote: - Starting Qemu with a backing file For this we could tell qemu that a file named xyz is available via fd n, via an extension of the getfd command. For example (qemu) getfd path=/images/my-image.img (qemu) getfd path=/images/template.img

Re: [Qemu-devel] [PATCH v2] Add support for fd: protocol

2011-06-20 Thread Anthony Liguori
On 06/20/2011 08:40 AM, Avi Kivity wrote: On 06/14/2011 04:31 PM, Corey Bryant wrote: - Starting Qemu with a backing file For this we could tell qemu that a file named xyz is available via fd n, via an extension of the getfd command. For example (qemu) getfd path=/images/my-image.img

Re: [Qemu-devel] [PATCH 2/2] qxl: add QXL_IO_UPDATE_MEM for guest S3S4 support

2011-06-20 Thread Gerd Hoffmann
What is the difference to one worker-stop() + worker-start() cycle? ok, stop+start won't disconnect any clients either. But does stop render all waiting commands? I'll have to look, I don't know if it does. It does. This is what qemu uses to flush all spice server state to device memory

Re: [Qemu-devel] [PATCH v5 2/5] guest agent: qemu-ga daemon

2011-06-20 Thread Luiz Capitulino
On Sun, 19 Jun 2011 14:00:30 -0500 Michael Roth mdr...@linux.vnet.ibm.com wrote: On 06/17/2011 10:25 PM, Luiz Capitulino wrote: On Fri, 17 Jun 2011 16:25:32 -0500 Michael Rothmdr...@linux.vnet.ibm.com wrote: On 06/17/2011 03:13 PM, Luiz Capitulino wrote: On Fri, 17 Jun 2011 14:21:31

Re: [Qemu-devel] [V3 1/3] Enhance info block to display hostcache setting

2011-06-20 Thread Kevin Wolf
Am 17.06.2011 18:37, schrieb Supriya Kannery: Enhance info block to display hostcache setting for each block device. Example: (qemu) info block ide0-hd0: type=hd removable=0 file=../rhel6-32.qcow2 ro=0 drv=qcow2 encrypted=0 Enhanced to display hostcache setting: (qemu) info block

Re: [Qemu-devel] [V3 2/3] Error classes for file reopen and device insertion

2011-06-20 Thread Kevin Wolf
Am 17.06.2011 18:37, schrieb Supriya Kannery: New error classes defined for cases where device not inserted and file reopen failed. Signed-off-by: Supriya Kannery supri...@in.ibm.com This one has tabs, too. Kevin

Re: [Qemu-devel] [V2 3/3] Command block_set for dynamic block params change

2011-06-20 Thread Kevin Wolf
Am 17.06.2011 18:38, schrieb Supriya Kannery: New command block_set added for dynamically changing any of the block device parameters. For now, dynamic setting of hostcache params using this command is implemented. Other block device parameters, can be integrated in similar lines.

Re: [Qemu-devel] [PATCH] qemu-img: Add cache command line option

2011-06-20 Thread Kevin Wolf
Am 16.06.2011 16:43, schrieb Kevin Wolf: Am 16.06.2011 16:28, schrieb Christoph Hellwig: On Wed, Jun 15, 2011 at 09:46:10AM -0400, Federico Simoncelli wrote: qemu-img currently writes disk images using writeback and filling up the cache buffers which are then flushed by the kernel preventing

Re: [Qemu-devel] struct TimerState

2011-06-20 Thread Lluís
Nilay writes: I am trying to understand the structures that QEMU saves when do_savevm() is invoked. Can anyone explain to me the fields that are part of the TimerState structure in qemu-timer.c? If my meory does not fail me, its main task is to capture what is the time in the host whenever

Re: [Qemu-devel] [PATCH 2/2] qxl: add QXL_IO_UPDATE_MEM for guest S3S4 support

2011-06-20 Thread Alon Levy
On Mon, Jun 20, 2011 at 04:07:59PM +0200, Gerd Hoffmann wrote: What is the difference to one worker-stop() + worker-start() cycle? ok, stop+start won't disconnect any clients either. But does stop render all waiting commands? I'll have to look, I don't know if it does. It does. This

Re: [Qemu-devel] [PATCH RFC 0/3] basic support for composing sysbus devices

2011-06-20 Thread Paul Brook
Yeah, that's why I said, hard to do well. It makes it very hard to add new socket types. PCI, USB, IDE, SCSI, SBus, what else? APICBus? I2C? 8 socket types ought to be enough for anybody. Off the top of my head: AClink (audio), i2s (audio), SSI/SSP (synchonous serial), Firewire, rs232,

Re: [Qemu-devel] [PATCH v2] Optimize screendump

2011-06-20 Thread Stefan Hajnoczi
On Mon, Jun 20, 2011 at 9:12 AM, Avi Kivity a...@redhat.com wrote: When running kvm-autotest, fputc() is often the second highest (sometimes #1) function showing up in a profile.  This is due to fputc() locking the file for every byte written. Optimize by buffering a line's worth of pixels

Re: [Qemu-devel] [PATCH 2/2] qxl: add QXL_IO_UPDATE_MEM for guest S3S4 support

2011-06-20 Thread Alon Levy
On Mon, Jun 20, 2011 at 05:11:07PM +0200, Alon Levy wrote: On Mon, Jun 20, 2011 at 04:07:59PM +0200, Gerd Hoffmann wrote: What is the difference to one worker-stop() + worker-start() cycle? ok, stop+start won't disconnect any clients either. But does stop render all waiting commands?

Re: [Qemu-devel] [PATCH 0/2] Introduce panic hypercall

2011-06-20 Thread Avi Kivity
On 06/20/2011 06:38 PM, Daniel P. Berrange wrote: On Mon, Jun 20, 2011 at 06:31:23PM +0300, Avi Kivity wrote: On 06/20/2011 04:38 PM, Daniel Gollub wrote: Introduce panic hypercall to enable the crashing guest to notify the host. This enables the host to run some actions as soon a guest

Re: [Qemu-devel] [PATCH 2/2] qxl: add QXL_IO_UPDATE_MEM for guest S3S4 support

2011-06-20 Thread Gerd Hoffmann
On 06/20/11 17:11, Alon Levy wrote: On Mon, Jun 20, 2011 at 04:07:59PM +0200, Gerd Hoffmann wrote: What is the difference to one worker-stop() + worker-start() cycle? ok, stop+start won't disconnect any clients either. But does stop render all waiting commands? I'll have to look, I don't

Re: [Qemu-devel] [PATCH 0/2] Introduce panic hypercall

2011-06-20 Thread Jan Kiszka
On 2011-06-20 17:45, Avi Kivity wrote: This series does need to introduce a QMP event notification upon crash, so that the crash notification can be propagated to mgmt layers above QEMU. Yes. I think the best way to deal with that is to stop the VM on guest panic. There is already WIP to

[Qemu-devel] [PATCH 01/18] Don't translate pointer when in restore_sigcontext

2011-06-20 Thread riku . voipio
From: Mike McCormack mj.mccorm...@samsung.com Fixes crash in i386 when user emulation base address is non-zero. 21797 rt_sigreturn(8,1082124603,1,0,1082126048,1082126248)Exit reason and status: signal 11 Signed-off-by: Mike McCormack mj.mccorm...@samsung.com Signed-off-by: Riku Voipio

[Qemu-devel] [PATCH 06/18] m68k-semi.c: Use correct check for failure of do_brk()

2011-06-20 Thread riku . voipio
From: Peter Maydell peter.mayd...@linaro.org In the m68k semihosting implementation of HOSTED_INIT_SIM, use the correct check for whether do_brk() has failed -- it does not return -1 but the previous value of the break limit. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by:

[Qemu-devel] [PATCH 00/18] pending linux-user patches

2011-06-20 Thread riku . voipio
From: Riku Voipio riku.voi...@iki.fi Hi, All included patches except mine have already been on the list. These patches should be ready for pull, but giving last minute chance for people to object. The following changes since commit eb47d7c5d96060040931c42773ee07e61e547af9 hw/9118.c:

[Qemu-devel] [PATCH 02/18] linux-user: Fix the load of ELF files that have no useful symbol

2011-06-20 Thread riku . voipio
From: Cédric VINCENT cedric.vinc...@st.com This patch fixes a double free() due to realloc(syms, 0) in the loader when the ELF file has no useful symbol, as with the following example (compiled with sh4-linux-gcc -nostdlib): .text .align 1 .global _start _start: mov

[Qemu-devel] [PATCH 05/18] arm-semi.c: Use correct check for failure of do_brk()

2011-06-20 Thread riku . voipio
From: Peter Maydell peter.mayd...@linaro.org In the ARM semihosting implementation of SYS_HEAPINFO, use the correct check for whether do_brk() has failed -- it does not return -1 but the previous value of the break limit. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Riku

[Qemu-devel] [PATCH 12/18] linux-user: syscall should use sanitized arg1

2011-06-20 Thread riku . voipio
From: Juan Quintela quint...@redhat.com Looking at the other architectures, we should be using how not arg1. Signed-off-by: Juan Quintela quint...@redhat.com [peter.mayd...@linaro.org: remove unnecessary initialisation of how] Signed-off-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by:

[Qemu-devel] [PATCH 07/18] linux-user: Fix the computation of the requested heap size

2011-06-20 Thread riku . voipio
From: Cédric VINCENT cedric.vinc...@st.com There were two remaining bugs in the previous implementation of do_brk(): 1. the value of new_alloc_size was one page too large when the requested brk was aligned on a host page boundary. 2. no new pages should be (re-)allocated when the

[Qemu-devel] [PATCH 13/18] flatload: end_code was only used in a debug message

2011-06-20 Thread riku . voipio
From: Juan Quintela quint...@redhat.com Just unfold its definition in only use. Signed-off-by: Juan Quintela quint...@redhat.com [peter.mayd...@linaro.org: fixed typo in the debug code, added parentheses to fix precedence issue] Signed-off-by: Peter Maydell peter.mayd...@linaro.org

[Qemu-devel] [PATCH 04/18] linux-user: Don't use MAP_FIXED in do_brk()

2011-06-20 Thread riku . voipio
From: Peter Maydell peter.mayd...@linaro.org Since mmap() with MAP_FIXED will map over the top of existing mappings, it's a bad idea to use it to implement brk(), because brk() with a large size is likely to overwrite important things like qemu itself or the host libc. So we drop MAP_FIXED and

[Qemu-devel] [PATCH 08/18] linux-user: add pselect6 syscall support

2011-06-20 Thread riku . voipio
From: Mike Frysinger vap...@gentoo.org Some architectures (like Blackfin) only implement pselect6 (and skip select/newselect). So add support for it. Signed-off-by: Mike Frysinger vap...@gentoo.org Signed-off-by: Riku Voipio riku.voi...@iki.fi --- linux-user/syscall.c | 149

[Qemu-devel] [PATCH 11/18] syscall: really return ret code

2011-06-20 Thread riku . voipio
From: Juan Quintela quint...@redhat.com We assign ret with the error code, but then return 0 unconditionally. Signed-off-by: Juan Quintela quint...@redhat.com Signed-off-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Riku Voipio riku.voi...@iki.fi --- linux-user/syscall.c |8

[Qemu-devel] [PATCH 03/18] linux-user: Handle images where lowest vaddr is not page aligned

2011-06-20 Thread riku . voipio
From: Peter Maydell peter.mayd...@linaro.org Fix a bug in the linux-user ELF loader code where it was not correctly handling images where the lowest vaddr to be loaded was not page aligned. The problem was that the code to probe for a suitable guest base address was changing the 'loaddr' variable

[Qemu-devel] [PATCH 10/18] linuxload: id_change was a write only variable

2011-06-20 Thread riku . voipio
From: Juan Quintela quint...@redhat.com Signed-off-by: Juan Quintela quint...@redhat.com Signed-off-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Riku Voipio riku.voi...@iki.fi --- linux-user/linuxload.c | 25 + 1 files changed, 1 insertions(+), 24

[Qemu-devel] [PATCH 15/18] linux-user: Bump do_syscall() up to 8 syscall arguments

2011-06-20 Thread riku . voipio
From: Peter Maydell peter.mayd...@linaro.org On 32 bit MIPS a few syscalls have 7 arguments, and so to call them via NR_syscall the guest needs to be able to pass 8 arguments to do_syscall(). Raise the number of arguments do_syscall() takes accordingly. This fixes some gcc 4.6 compiler warnings

[Qemu-devel] [PATCHv4] qemu-img: Add cache command line option

2011-06-20 Thread Federico Simoncelli
qemu-img currently writes disk images using writeback and filling up the cache buffers which are then flushed by the kernel preventing other processes from accessing the storage. This is particularly bad in cluster environments where time-based algorithms might be in place and accessing the

[Qemu-devel] [PATCH 09/18] linux-user: Define AT_RANDOM to support target stack protection mechanism.

2011-06-20 Thread riku . voipio
From: Laurent ALFONSI laurent.alfo...@st.com Note that the support for the command-line argument requires: 1. add the new field uint8_t rand_bytes[16] to struct image_info since only the variable info lives both in main() and in create_elf_tables() 2. write a dedicated

[Qemu-devel] [PATCH 18/18] linux-user: Fix sync_file_range on 32bit mips

2011-06-20 Thread riku . voipio
From: Riku Voipio riku.voi...@iki.fi As noticed while looking at Bump do_syscall() up to 8 syscall arguments patch, sync_file_range uses a pad argument on 32bit mips. Deal with it by reading the correct arguments when on mips. Signed-off-by: Riku Voipio riku.voi...@iki.fi ---

[Qemu-devel] [PATCH 17/18] linux-user/signal.c: Remove unused fenab

2011-06-20 Thread riku . voipio
From: Peter Maydell peter.mayd...@linaro.org Remove fenab as it is only written, never used. Add a FIXME comment about the discrepancy between our behaviour and that of the Linux kernel for this routine. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Riku Voipio

[Qemu-devel] [PATCH 14/18] flatload: memp was a write-only variable

2011-06-20 Thread riku . voipio
From: Juan Quintela quint...@redhat.com Signed-off-by: Juan Quintela quint...@redhat.com Signed-off-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Riku Voipio riku.voi...@iki.fi --- linux-user/flatload.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v2] Add support for fd: protocol

2011-06-20 Thread Avi Kivity
On 06/20/2011 04:50 PM, Anthony Liguori wrote: On 06/20/2011 08:40 AM, Avi Kivity wrote: On 06/14/2011 04:31 PM, Corey Bryant wrote: - Starting Qemu with a backing file For this we could tell qemu that a file named xyz is available via fd n, via an extension of the getfd command. For

[Qemu-devel] [PATCH 16/18] linux-user/signal.c: Remove only-ever-set variable fpu_save_addr

2011-06-20 Thread riku . voipio
From: Peter Maydell peter.mayd...@linaro.org Move the access of fpu_save into the commented out skeleton code for restoring FPU registers on SPARC sigreturn, thus silencing a gcc 4.6 variable set but never used warning. (This doesn't affect the calculation of 'err' because in fact __get_user()

Re: [Qemu-devel] [PATCH 0/2] Introduce panic hypercall

2011-06-20 Thread Daniel Gollub
On Monday, June 20, 2011 05:45:36 pm Avi Kivity wrote: However, I'm not sure I see the gain. Most enterprisey guests already contain in-guest crash dumpers which provide more information than a qemu memory dump could, since they know exact load addresses etc. and are integrated

[Qemu-devel] unix domain socket communication with guests

2011-06-20 Thread Joel Uckelman
I'm trying to set up a unix domain socket with a guest on one end and the host on the other, where the server is running on and bound to the socket on the guest. I've been able to get the reverse, where the server is running on the host, this way: qemu-kvm -kernel kernel -initrd initrd -hda root

Re: [Qemu-devel] [PATCH 2/2] qxl: add QXL_IO_UPDATE_MEM for guest S3S4 support

2011-06-20 Thread Alon Levy
On Mon, Jun 20, 2011 at 05:50:32PM +0200, Gerd Hoffmann wrote: On 06/20/11 17:11, Alon Levy wrote: On Mon, Jun 20, 2011 at 04:07:59PM +0200, Gerd Hoffmann wrote: What is the difference to one worker-stop() + worker-start() cycle? ok, stop+start won't disconnect any clients either. But does

Re: [Qemu-devel] [PATCH 0/2] Introduce panic hypercall

2011-06-20 Thread Avi Kivity
On 06/20/2011 07:26 PM, Daniel Gollub wrote: I agree. But let's do this via a device, this way kvm need not be changed. Is a device reliable enough if the guest kernel crashes? Do you mean something like a hardware watchdog? I'm proposing a 1:1 equivalent. Instead of issuing a hypercall

Re: [Qemu-devel] [PATCH 1/1] fix operator precedence

2011-06-20 Thread Stefan Hajnoczi
On Mon, Jun 20, 2011 at 2:25 PM, Frediano Ziglio fredd...@gmail.com wrote: Signed-off-by: Frediano Ziglio fredd...@gmail.com ---  cmd.c |    6 +++---  1 files changed, 3 insertions(+), 3 deletions(-) Thanks for the patch! cmd.c:timestr() has tabs for indentation but your patch uses spaces.

Re: [Qemu-devel] High speed polling

2011-06-20 Thread Clay Andreasen
Thank you for your reply. I am still a novice with Qemu so pardon me if I don't make any sense. I tried --enable-io-thread. I get the error: cpus.o: In function `qemu_kvm_eat_signal': cpus.c:(.text+0x111a): undefined reference to `kvm_on_sigbus_vcpu' so I assume it requires KVM. I'm not using

Re: [Qemu-devel] [PATCH 0/2] Introduce panic hypercall

2011-06-20 Thread Avi Kivity
On 06/20/2011 08:13 PM, Jan Kiszka wrote: A watchdog has the advantage that is also detects lockups. In fact you could implement the panic device via the existing watchdogs. Simply program the timer for the minimum interval and *don't* service the interrupt. This would work for

Re: [Qemu-devel] [PATCH 0/2] Introduce panic hypercall

2011-06-20 Thread Jan Kiszka
On 2011-06-20 18:34, Avi Kivity wrote: Do ILO cards / IPMI support something like this? We could follow their lead in that case. The only two things which came to my mind are: * NMI (aka. ipmitool diag) - already available in qemu/kvm - but requires in-guest kexec/kdump *

Re: [Qemu-devel] [PATCH] Support logging xen-guest console

2011-06-20 Thread Stefano Stabellini
On Mon, 20 Jun 2011, Chunyan Liu wrote: Add code to support logging xen-domU console, as what xenconsoled does. Log info will be saved in /var/log/xen/console/guest-domUname.log. Signed-off-by: Chunyan Liu cy...@novell.com --- hw/xen_console.c | 63

Re: [Qemu-devel] [PATCH v2] Add support for fd: protocol

2011-06-20 Thread Anthony Liguori
On 06/20/2011 12:35 PM, Avi Kivity wrote: On 06/20/2011 04:50 PM, Anthony Liguori wrote: On 06/20/2011 08:40 AM, Avi Kivity wrote: On 06/14/2011 04:31 PM, Corey Bryant wrote: - Starting Qemu with a backing file For this we could tell qemu that a file named xyz is available via fd n, via an

Re: [Qemu-devel] [PATCH 00/12] [uq/master] Import linux headers and some cleanups

2011-06-20 Thread Marcelo Tosatti
On Wed, Jun 08, 2011 at 04:10:54PM +0200, Jan Kiszka wrote: Licensing of the virtio headers is no clarified. So we can finally resolve the clumbsy and constantly buggy #ifdef'ery around old KVM and virtio headers. Recent example: current qemu-kvm does not build against 2.6.32 headers. This

[Qemu-devel] REMINDER: Participation Requested: Survey about Open-Source Software Development

2011-06-20 Thread Jeffrey Carver
Hi, Apologies for any inconvenience and thank you to those who have already completed the survey. We will keep the survey open for another couple of weeks. But, we do hope you will consider responding to the email request below (sent 2 weeks ago). Thanks, Dr. Jeffrey Carver Assistant Professor

Re: [Qemu-devel] [PATCH 2/2] qxl: add QXL_IO_UPDATE_MEM for guest S3S4 support

2011-06-20 Thread Alon Levy
On Mon, Jun 20, 2011 at 06:32:30PM +0200, Alon Levy wrote: On Mon, Jun 20, 2011 at 05:50:32PM +0200, Gerd Hoffmann wrote: On 06/20/11 17:11, Alon Levy wrote: On Mon, Jun 20, 2011 at 04:07:59PM +0200, Gerd Hoffmann wrote: What is the difference to one worker-stop() + worker-start() cycle?

Re: [Qemu-devel] [PATCH 14/18] TCG/PPC: use TCG_REG_CALL_STACK instead of TCG_REG_R1

2011-06-20 Thread Blue Swirl
On Mon, Jun 20, 2011 at 1:14 AM, malc av1...@comtv.ru wrote: On Mon, 20 Jun 2011, Blue Swirl wrote: Use TCG_REG_CALL_STACK instead of TCG_REG_R1 etc. for consistency. You spell it TCG_REG_CALL_STACK in the subject/comment but REG_CALL_STACK in the patch, which suggest that it was never even

Re: [Qemu-devel] [PATCH RFC 0/3] basic support for composing sysbus devices

2011-06-20 Thread Blue Swirl
On Mon, Jun 20, 2011 at 6:23 PM, Paul Brook p...@codesourcery.com wrote: Yeah, that's why I said, hard to do well.  It makes it very hard to add new socket types. PCI, USB, IDE, SCSI, SBus, what else? APICBus? I2C? 8 socket types ought to be enough for anybody. Off the top of my head:

  1   2   >