Re: [Qemu-devel] [Qemu-trivial] [PATCH] Avoid double definitions of PRI*64

2011-06-24 Thread Stefan Weil
Am 24.06.2011 07:41, schrieb Stefan Hajnoczi: On Thu, Jun 23, 2011 at 3:32 PM, Stefan Weil w...@mail.berlios.de wrote: Am 23.06.2011 15:35, schrieb Stefan Hajnoczi: On Thu, Jun 23, 2011 at 10:15:58AM +0200, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com Recent mingw32 provide

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Avoid double definitions of PRI*64

2011-06-24 Thread Stefan Hajnoczi
On Fri, Jun 24, 2011 at 7:11 AM, Stefan Weil w...@mail.berlios.de wrote: Am 24.06.2011 07:41, schrieb Stefan Hajnoczi: On Thu, Jun 23, 2011 at 3:32 PM, Stefan Weil w...@mail.berlios.de wrote: Am 23.06.2011 15:35, schrieb Stefan Hajnoczi: On Thu, Jun 23, 2011 at 10:15:58AM +0200, Jan Kiszka

Re: [Qemu-devel] [PATCH] ahci: fix device detect emulation.

2011-06-24 Thread Gerd Hoffmann
On 06/23/11 15:59, Gerd Hoffmann wrote: AHCI specs say about the device detection field: Device Detection (DET): Indicates the interface device detection and Phy state. 0h - No device detected and Phy communication not established 1h - Device presence detected but Phy communication not

Re: [Qemu-devel] Actual TB code doesn't look like what was intended (TCG issue)?

2011-06-24 Thread Peter Maydell
On 24 June 2011 03:44, Max Filippov jcmvb...@gmail.com wrote: Please note how the current instruction in gdb differ from what was said in OUT. This lea corrupts stack pointer and the next callq generates segfault. Could please anyone familiar with TCG take a look at this, or suggest where I

Re: [Qemu-devel] Kemari status?

2011-06-24 Thread OHMURA Kei
2011/6/24 Christian Brunner c...@muc.de: Does anyone know what happened to kemari? Back in March it was on the list for a possible merge in qemu 0.15. In April the last update was sent to this list. After that everything remained silent. I think it's a really interesting project and I

Re: [Qemu-devel] Actual TB code doesn't look like what was intended (TCG issue)?

2011-06-24 Thread Laurent Desnogues
On Fri, Jun 24, 2011 at 4:44 AM, Max Filippov jcmvb...@gmail.com wrote: Hello guys. I'm running qemu on x86_64 host. It's clean build from git sources dated 2011.05.19, commit 1fddfba129f5435c80eda14e8bc23fdb888c7187 I have the following output from log trace,op,out_asm: Trace 0x4000a310

[Qemu-devel] [PATCH v2 00/12] Adding VMDK monolithic flat support

2011-06-24 Thread famcool
From: Fam Zheng famc...@gmail.com VMDK multiple file images can not be recognized for now. This patch series is adding monolithic flat support to it, that is the image type with two files, one text descriptor file and a plain data file. This type of image can be created in VMWare, with the

[Qemu-devel] [PATCH v2 02/12] VMDK: bugfix, align offset to cluster in get_whole_cluster

2011-06-24 Thread famcool
From: Fam Zheng famc...@gmail.com In get_whole_cluster, the offset is not aligned to cluster when reading from backing_hd. When the first write to child is not at the cluster boundary, wrong address data from parent is copied to child. Signed-off-by: Fam Zheng famc...@gmail.com --- block/vmdk.c

[Qemu-devel] [PATCH v2 08/12] VMDK: change get_cluster_offset return type

2011-06-24 Thread famcool
From: Fam Zheng famc...@gmail.com The return type of get_cluster_offset was an offset that use 0 to denote 'not allocated', this will be no longer true for flat extents, as we see flat extent file as a single huge cluster whose offset is 0 and length is the whole file length. So now we use int

[Qemu-devel] [PATCH v2 01/12] VMDK: introduce VmdkExtent

2011-06-24 Thread famcool
From: Fam Zheng famc...@gmail.com Introduced VmdkExtent array into BDRVVmdkState, enable holding multiple image extents for multiple file image support. Signed-off-by: Fam Zheng famc...@gmail.com --- block/vmdk.c | 321 -- 1 files

[Qemu-devel] [PATCH v2 07/12] VMDK: move 'static' cid_update flag to bs field

2011-06-24 Thread famcool
From: Fam Zheng famc...@gmail.com Cid_update is the flag for updating CID on first write after opening the image. This should be per image open rather than per program life cycle, so change it from static var of vmdk_write to a field in BDRVVmdkState. Signed-off-by: Fam Zheng famc...@gmail.com

[Qemu-devel] [PATCH v2 09/12] VMDK: open/read/write for monolithicFlat image

2011-06-24 Thread famcool
From: Fam Zheng famc...@gmail.com Parse vmdk decriptor file and open mono flat image. Read/write the flat extent. Signed-off-by: Fam Zheng famc...@gmail.com --- block/vmdk.c | 190 ++ 1 files changed, 177 insertions(+), 13 deletions(-)

[Qemu-devel] [PATCH v2 12/12] BlockDriver: add bdrv_get_allocated_file_size() operation

2011-06-24 Thread famcool
From: Fam Zheng famc...@gmail.com qemu-img.c wants to count allocated file size of image. Previously it counts a single bs-file by 'stat' or Window API. As VMDK introduces multiple file support, the operation becomes format specific with platform specific meanwhile. The functions are moved to

[Qemu-devel] [PATCH v2 10/12] VMDK: create different subformats

2011-06-24 Thread famcool
From: Fam Zheng famc...@gmail.com Add create option 'format', with enums: monolithicSparse monolithicFlat twoGbMaxExtentSparse twoGbMaxExtentFlat Each creates a subformat image file. The default is monolithiSparse. Signed-off-by: Fam Zheng famc...@gmail.com --- block/vmdk.c |

[Qemu-devel] [PATCH v2 05/12] VMDK: add field BDRVVmdkState.desc_offset

2011-06-24 Thread famcool
From: Fam Zheng famc...@gmail.com There are several occurrence of magic number 0x200 as the descriptor offset within mono sparse image file. This is not the case for images with separate descriptor file. So a field is added to BDRVVmdkState to hold the correct value. Signed-off-by: Fam Zheng

[Qemu-devel] [V11 06/15] virtio-9p: Create support in chroot environment

2011-06-24 Thread M. Mohan Kumar
From: M. Mohan Kumar mo...@in.ibm.com Add both chroot worker qemu side interfaces to create regular files in chroot environment Signed-off-by: M. Mohan Kumar mo...@in.ibm.com --- hw/9pfs/virtio-9p-chroot-worker.c | 36 hw/9pfs/virtio-9p-chroot.h|

[Qemu-devel] [V11 08/15] virtio-9p: Removing file or directory in chroot environment

2011-06-24 Thread M. Mohan Kumar
From: M. Mohan Kumar mo...@in.ibm.com Support for removing file or directory in chroot environment. Add interfaces to remove file/directory in chroot worker and qemu side. Signed-off-by: M. Mohan Kumar mo...@in.ibm.com --- hw/9pfs/virtio-9p-chroot-worker.c | 18 ++

[Qemu-devel] [PATCH v2 06/12] VMDK: flush multiple extents

2011-06-24 Thread famcool
From: Fam Zheng famc...@gmail.com Flush all the file that referenced by the image. Signed-off-by: Fam Zheng famc...@gmail.com --- block/vmdk.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index e1b94c2..41a18a1 100644 ---

[Qemu-devel] [V11 12/15] virtio-9p: chown in chroot environment

2011-06-24 Thread M. Mohan Kumar
From: M. Mohan Kumar mo...@in.ibm.com Add support to do chown in chroot process Signed-off-by: M. Mohan Kumar mo...@in.ibm.com --- hw/9pfs/virtio-9p-chroot-worker.c | 18 ++ hw/9pfs/virtio-9p-chroot.h|1 + hw/9pfs/virtio-9p-local.c |9 + 3 files

[Qemu-devel] [PATCH v2 11/12] VMDK: fix coding style

2011-06-24 Thread famcool
From: Fam Zheng famc...@gmail.com Conform coding style in vmdk.c to pass scripts/checkpatch.pl checks. Signed-off-by: Fam Zheng famc...@gmail.com --- block/vmdk.c | 79 +++-- 1 files changed, 48 insertions(+), 31 deletions(-) diff --git

[Qemu-devel] [V11 07/15] virtio-9p: Creating special files in chroot environment

2011-06-24 Thread M. Mohan Kumar
From: M. Mohan Kumar mo...@in.ibm.com Add both chroot worker and qemu side interfaces to create special files (directory, device nodes, links and symbolic links) Signed-off-by: M. Mohan Kumar mo...@in.ibm.com --- hw/9pfs/virtio-9p-chroot-worker.c | 52 +

[Qemu-devel] [V11 11/15] virtio-9p: chmod in chroot environment

2011-06-24 Thread M. Mohan Kumar
From: M. Mohan Kumar mo...@in.ibm.com Add support to do chmod operation in chroot process. Signed-off-by: M. Mohan Kumar mo...@in.ibm.com --- hw/9pfs/virtio-9p-chroot-worker.c | 18 ++ hw/9pfs/virtio-9p-chroot.h|1 + hw/9pfs/virtio-9p-local.c |5 +++--

[Qemu-devel] [V11 13/15] virtio-9p: stat in chroot environment

2011-06-24 Thread M. Mohan Kumar
From: M. Mohan Kumar mo...@in.ibm.com Signed-off-by: M. Mohan Kumar mo...@in.ibm.com --- hw/9pfs/virtio-9p-chroot-worker.c | 52 - hw/9pfs/virtio-9p-chroot.c| 59 - hw/9pfs/virtio-9p-chroot.h|3 ++

[Qemu-devel] [V11 01/15] Implement qemu_read_full

2011-06-24 Thread M. Mohan Kumar
From: M. Mohan Kumar mo...@in.ibm.com Signed-off-by: M. Mohan Kumar mo...@in.ibm.com --- osdep.c | 32 qemu-common.h |2 ++ 2 files changed, 34 insertions(+), 0 deletions(-) diff --git a/osdep.c b/osdep.c index 56e6963..5a4d670 100644 --- a/osdep.c

[Qemu-devel] [V11 00/15] virtio-9p: Use chroot to safely access files in passthrough security model

2011-06-24 Thread M. Mohan Kumar
In passthrough security model, following symbolic links in the server side could result in TOCTTOU vulnerabilities. (http://en.wikipedia.org/wiki/Time-of-check-to-time-of-use) This patchset resolves this issue by creating a dedicated process which chroots into the share path and all file object

[Qemu-devel] [V11 03/15] virtio-9p: Provide chroot worker side interfaces

2011-06-24 Thread M. Mohan Kumar
From: M. Mohan Kumar mo...@in.ibm.com Implement chroot worker side interfaces like sending the file descriptor to qemu process, reading the object request from socket etc. Also add chroot main function and other helper routines. Signed-off-by: M. Mohan Kumar mo...@in.ibm.com [mala...@us.ibm.com:

[Qemu-devel] [V11 15/15] virtio-9p: Chroot environment for other functions

2011-06-24 Thread M. Mohan Kumar
From: M. Mohan Kumar mo...@in.ibm.com Add chroot functionality for system calls that can operate on a file using relative directory file descriptor. Signed-off-by: M. Mohan Kumar mo...@in.ibm.com --- hw/9pfs/virtio-9p-local.c | 41 +++-- 1 files changed, 39

Re: [Qemu-devel] Image streaming and live block copy

2011-06-24 Thread Stefan Hajnoczi
On Sun, Jun 19, 2011 at 5:02 PM, Dor Laor dl...@redhat.com wrote: On 06/18/2011 12:17 PM, Stefan Hajnoczi wrote: On Sat, Jun 18, 2011 at 10:15 AM, Stefan Hajnoczistefa...@gmail.com  wrote: On Fri, Jun 17, 2011 at 1:31 PM, Marcelo Tosattimtosa...@redhat.com  wrote: On Thu, Jun 16, 2011 at

[Qemu-devel] [V11 02/15] virtio-9p: Enable CONFIG_THREAD if CONFIG_VIRTFS is enabled

2011-06-24 Thread M. Mohan Kumar
From: M. Mohan Kumar mo...@in.ibm.com 9p Chroot environment needs APIs defined in qemu-thread.c, so enable CONFIG_THREAD if virtfs is enabled Signed-off-by: M. Mohan Kumar mo...@in.ibm.com --- configure |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/configure

[Qemu-devel] [PATCH v2 04/12] VMDK: separate vmdk_open by format version

2011-06-24 Thread famcool
From: Fam Zheng famc...@gmail.com Separate vmdk_open by subformats to: * vmdk_open_vmdk3 * vmdk_open_vmdk4 Signed-off-by: Fam Zheng famc...@gmail.com --- block/vmdk.c | 225 ++ 1 files changed, 147 insertions(+), 78 deletions(-) diff

[Qemu-devel] [V11 14/15] virtio-9p: readlink in chroot environment

2011-06-24 Thread M. Mohan Kumar
From: M. Mohan Kumar mo...@in.ibm.com Signed-off-by: M. Mohan Kumar mo...@in.ibm.com --- hw/9pfs/virtio-9p-chroot-worker.c | 17 ++--- hw/9pfs/virtio-9p-chroot.h|1 + hw/9pfs/virtio-9p-local.c | 14 -- 3 files changed, 27 insertions(+), 5

Re: [Qemu-devel] Image streaming gives live block copy for free (and vice versa)

2011-06-24 Thread Stefan Hajnoczi
On Sun, Jun 19, 2011 at 5:12 PM, Dor Laor dl...@redhat.com wrote: On 06/17/2011 08:53 AM, Stefan Hajnoczi wrote: Perhaps someone has been saying this all along but I want to spell it out that image streaming and live block copy are equivalent in theory. I just realized this last night.  In

[Qemu-devel] [V11 10/15] virtio-9p: Move file post creation changes to none security model

2011-06-24 Thread M. Mohan Kumar
From: M. Mohan Kumar mo...@in.ibm.com After creating a file object, its permission and ownership details are updated as per 9p client's request for both passthrough and none security model. But with chrooted environment its not required for passthrough security model. Move all post file creation

[Qemu-devel] [PATCH v2 03/12] VMDK: probe for monolithicFlat images

2011-06-24 Thread famcool
From: Fam Zheng famc...@gmail.com Probe as the same behavior as VMware does. Recognize image as monolithicFlat descriptor file when the file is text and the first effective line (not '#' leaded comment or space line) is either 'version=1' or 'version=2'. No space or upper case charactors

[Qemu-devel] [V11 05/15] virtio-9p: Support for opening a file in chroot environment

2011-06-24 Thread M. Mohan Kumar
From: M. Mohan Kumar mo...@in.ibm.com This patch adds both chroot worker and qemu side support to open a file/ directory in the chroot environment Signed-off-by: M. Mohan Kumar mo...@in.ibm.com --- hw/9pfs/virtio-9p-chroot.c | 29 hw/9pfs/virtio-9p-chroot.h |2 +-

Re: [Qemu-devel] [PATCH v2 00/12] Adding VMDK monolithic flat support

2011-06-24 Thread Fam Zheng
On Fri, Jun 24, 2011 at 4:18 PM, famc...@gmail.com wrote: From: Fam Zheng famc...@gmail.com VMDK multiple file images can not be recognized for now. This patch series is adding monolithic flat support to it, that is the image type with two files, one text descriptor file and a plain data

Re: [Qemu-devel] Actual TB code doesn't look like what was intended (TCG issue)?

2011-06-24 Thread Laurent Desnogues
On Fri, Jun 24, 2011 at 10:35 AM, Max Filippov jcmvb...@gmail.com wrote: [...] Yes, I've noticed it (however, after I sent this mail). But (1) quoted OUT is the last OUT for this host address range in the log and (2) in gdb I set b tlb_fill if retaddr == 0x4000a369 and made some steps. You

[Qemu-devel] [V11 09/15] virtio-9p: Rename in chroot environment

2011-06-24 Thread M. Mohan Kumar
From: M. Mohan Kumar mo...@in.ibm.com Support renaming a file or directory in chroot envirnoment. Add interfaces for renaming in chroot worker and qemu side. Signed-off-by: M. Mohan Kumar mo...@in.ibm.com --- hw/9pfs/virtio-9p-chroot-worker.c | 17 + hw/9pfs/virtio-9p-chroot.h

Re: [Qemu-devel] Actual TB code doesn't look like what was intended (TCG issue)?

2011-06-24 Thread Max Filippov
Please note how the current instruction in gdb differ from what was said in OUT. This lea corrupts stack pointer and the next callq generates segfault. Could please anyone familiar with TCG take a look at this, or suggest where I should look myself? You don't say which target you're

Re: [Qemu-devel] [PATCH v2 03/12] VMDK: probe for monolithicFlat images

2011-06-24 Thread Stefan Hajnoczi
On Fri, Jun 24, 2011 at 9:18 AM, famc...@gmail.com wrote: +        const char *p = (const char *)buf; +        const char *end = p + buf_size; +        int version = 0; +        while (*p p end) { These short-circuit comparisions need to be the other way around. If p = end then p is

[Qemu-devel] [V11 04/15] virtio-9p: qemu interfaces for chroot environment

2011-06-24 Thread M. Mohan Kumar
From: M. Mohan Kumar mo...@in.ibm.com QEMU side interfaces to communicate with chroot worker process. Signed-off-by: M. Mohan Kumar mo...@in.ibm.com [mala...@us.ibm.com: Handle when qemu process can not receive fd because it already reached max fds] --- Makefile.objs |2 +-

Re: [Qemu-devel] Actual TB code doesn't look like what was intended (TCG issue)?

2011-06-24 Thread Max Filippov
Hello guys. I'm running qemu on x86_64 host. It's clean build from git sources dated 2011.05.19, commit 1fddfba129f5435c80eda14e8bc23fdb888c7187 I have the following output from log trace,op,out_asm: Trace 0x4000a310 [d0026c92] OP: 0xd0c0 movi_i32 tmp1,$0xfff4

Re: [Qemu-devel] [PATCH v2 06/12] VMDK: flush multiple extents

2011-06-24 Thread Stefan Hajnoczi
On Fri, Jun 24, 2011 at 9:18 AM, famc...@gmail.com wrote: From: Fam Zheng famc...@gmail.com Flush all the file that referenced by the image. Signed-off-by: Fam Zheng famc...@gmail.com ---  block/vmdk.c |    9 -  1 files changed, 8 insertions(+), 1 deletions(-) Please see my

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Fix compilation for non-POSIX system (w64)

2011-06-24 Thread Stefan Hajnoczi
On Thu, Jun 23, 2011 at 09:19:53PM +0200, Stefan Weil wrote: compatfd.h is only needed with CONFIG_POSIX. Compilation fails in compatfd.h for at least one non-POSIX systems (w64). Signed-off-by: Stefan Weil w...@mail.berlios.de --- cpus.c |2 ++ 1 files changed, 2 insertions(+), 0

Re: [Qemu-devel] Actual TB code doesn't look like what was intended (TCG issue)?

2011-06-24 Thread Max Filippov
Here are my rules of thumb for generating code where the code generated might change based on some bit of CPU state: When you are generating code, if the code you generate will change based on the contents of something in the CPUState struct, then the bit of CPUState you are looking at has

[Qemu-devel] [PATCH 03/13] usb-linux: track inflight iso urb count

2011-06-24 Thread Gerd Hoffmann
Track the number of iso urbs which are currently in flight. Log a message in case the count goes down to zero. Also warn in case many urbs are returned at the same time. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- usb-linux.c | 26 +- 1 files changed, 25

[Qemu-devel] [PATCH 02/13] usb-linux: make iso urb count contigurable

2011-06-24 Thread Gerd Hoffmann
Add a qdev property for the number of iso urbs which usb-linux keeps in flight, so it can be configured at runtime. Make it default to four (old hardcoded value used to be three). Signed-off-by: Gerd Hoffmann kra...@redhat.com --- usb-linux.c | 15 --- 1 files changed, 8

Re: [Qemu-devel] Actual TB code doesn't look like what was intended (TCG issue)?

2011-06-24 Thread Peter Maydell
On 24 June 2011 09:34, Max Filippov jcmvb...@gmail.com wrote: I thought it doesn't matter. It's target-xtensa that I've been developing Ah... My first guess is that the target's front end might have a bug where it wrongly bakes in assumptions about bits of the CPUState. QEMU will

[Qemu-devel] [PATCH 01/13] usb-linux: add get_endp()

2011-06-24 Thread Gerd Hoffmann
Add a helper function to get the endpoint data structure and put it into use. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- usb-linux.c | 39 +-- 1 files changed, 21 insertions(+), 18 deletions(-) diff --git a/usb-linux.c b/usb-linux.c index

[Qemu-devel] [PATCH 08/13] usb: Add a speedmask to devices

2011-06-24 Thread Gerd Hoffmann
From: Hans de Goede hdego...@redhat.com This is used to indicate at which speed[s] the device can operate, so that this can be checked to match the ports capabilities when it gets attached to a bus. Note that currently all usb1 emulated device claim to be fullspeed, this seems to not cause any

[Qemu-devel] [PATCH] w32: Remove redundant definitions of PRI*64

2011-06-24 Thread Stefan Weil
The PRI*64 macros are defined in MinGW's inttypes.h since 2002, so they are not needed in qemu-common.h (which includes inttypes.h). Signed-off-by: Stefan Weil w...@mail.berlios.de --- qemu-common.h |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/qemu-common.h

Re: [Qemu-devel] Actual TB code doesn't look like what was intended (TCG issue)?

2011-06-24 Thread Max Filippov
That should be the last block matching the address in the log output if you run *under gdb* with -d out_asm. This is the case. BTW you say this is a clean build, but as far as I could see it looks like your emulated target is not part of standard QEMU;  it seems to have a register named

[Qemu-devel] [PATCH 07/13] usb: Proper error propagation for usb_device_attach errors

2011-06-24 Thread Gerd Hoffmann
From: Hans de Goede hdego...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-bus.c | 25 + hw/usb-msd.c |5 +++-- usb-linux.c |6 +- 3 files changed, 21 insertions(+), 15 deletions(-) diff --git a/hw/usb-bus.c b/hw/usb-bus.c index

[Qemu-devel] [PATCH 13/13] usb: ignore USB_DT_DEBUG

2011-06-24 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-desc.c |4 hw/usb.h |1 + 2 files changed, 5 insertions(+), 0 deletions(-) diff --git a/hw/usb-desc.c b/hw/usb-desc.c index 0b9d351..bc6858f 100644 --- a/hw/usb-desc.c +++ b/hw/usb-desc.c @@ -385,6 +385,10 @@ int

[Qemu-devel] [PATCH 10/13] usb-bus: Don't allow speed mismatch while attaching devices

2011-06-24 Thread Gerd Hoffmann
From: Hans de Goede hdego...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-bus.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/hw/usb-bus.c b/hw/usb-bus.c index fc72018..2abce12 100644 --- a/hw/usb-bus.c +++ b/hw/usb-bus.c @@ -200,6 +200,11

Re: [Qemu-devel] Actual TB code doesn't look like what was intended (TCG issue)?

2011-06-24 Thread Peter Maydell
On 24 June 2011 11:08, Max Filippov jcmvb...@gmail.com wrote: Here are my rules of thumb for generating code where the code generated might change based on some bit of CPU state: When you are generating code, if the code you generate will change based on the contents of something in the

Re: [Qemu-devel] [PATCH v2 09/12] VMDK: open/read/write for monolithicFlat image

2011-06-24 Thread Stefan Hajnoczi
On Fri, Jun 24, 2011 at 9:18 AM, famc...@gmail.com wrote: From: Fam Zheng famc...@gmail.com Parse vmdk decriptor file and open mono flat image. Read/write the flat extent. Signed-off-by: Fam Zheng famc...@gmail.com ---  block/vmdk.c |  190

Re: [Qemu-devel] [PATCH 0/4] A few cleanups of qdev users

2011-06-24 Thread Markus Armbruster
Ping? Markus Armbruster arm...@redhat.com writes: Markus Armbruster (4): usb-ccid: Drop unused CCIDCardInfo callback print() virtio-serial: Clean up virtser_bus_dev_print() output virtio-serial: Turn props any virtio-serial-bus device must have into bus props ide: Turn

Re: [Qemu-devel] [Qemu-trivial] [PATCH] w32: Remove redundant definitions of PRI*64

2011-06-24 Thread Stefan Hajnoczi
On Fri, Jun 24, 2011 at 12:15:49PM +0200, Stefan Weil wrote: The PRI*64 macros are defined in MinGW's inttypes.h since 2002, so they are not needed in qemu-common.h (which includes inttypes.h). Signed-off-by: Stefan Weil w...@mail.berlios.de --- qemu-common.h |5 - 1 files

[Qemu-devel] [PULL] usb patch queue

2011-06-24 Thread Gerd Hoffmann
Hi, Here comes the USB patch queue. Nothing major, just a bunch of little fixes and improvements. please pull, Gerd The following changes since commit 48e2faf222cbf4abab7c8e4b3f44229ec98eae7f: net: Warn about -net nic options which were ignored (2011-06-22 07:18:39 -0500) are

Re: [Qemu-devel] unix domain socket communication with guests

2011-06-24 Thread Joel Uckelman
On Fri, Jun 24, 2011 at 4:54 AM, Amit Shah amit.s...@redhat.com wrote: I guess this means I need to get networking running on the guest so that it has a port visible to the host on which my server can listen. Is there a guide somewhere for doing that? I've not had any success in an afternoon

[Qemu-devel] [PATCH 04/13] ehci: add freq + maxframes properties

2011-06-24 Thread Gerd Hoffmann
Add properties for the wakeup rate and the max number of frames ehci will process at once. The wakeup rate defaults to 1000 which equals the usb frame rate. This can be reduced to make qemu wake up less often when ehci is active. In case the wakeup rate is reduced or the ehci timer is delayed

[Qemu-devel] [PATCH 06/13] usb-bus: Don't allow attaching a device to a bus with no free ports

2011-06-24 Thread Gerd Hoffmann
From: Hans de Goede hdego...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-bus.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/hw/usb-bus.c b/hw/usb-bus.c index 480956d..0a49921 100644 --- a/hw/usb-bus.c +++ b/hw/usb-bus.c @@ -181,6 +181,11

[Qemu-devel] [PATCH 09/13] usb-linux: allow compatible high speed devices to connect at fullspeed

2011-06-24 Thread Gerd Hoffmann
From: Hans de Goede hdego...@redhat.com Some usb2 highspeed devices, like usb-msd devices, work fine when redirected to a usb1 virtual controller. Allow this to avoid the new speedhecks causing regressions for users who do not enable the new experimental ehci code. Signed-off-by: Gerd Hoffmann

[Qemu-devel] [PATCH 11/13] hw/usb-ohci.c: Fix handling of remote wakeup corner cases

2011-06-24 Thread Gerd Hoffmann
From: Peter Maydell peter.mayd...@linaro.org Correct a number of minor errors in the OHCI wakeup implementation: * when the port is suspended but the controller is not, raise RHSC * when the controller is suspended but the port is not, raise RD * when the controller is suspended, move it to

Re: [Qemu-devel] [PATCH 06/11] exec.c: refactor cpu_physical_memory_map

2011-06-24 Thread Stefano Stabellini
On Thu, 23 Jun 2011, Peter Maydell wrote: On 23 June 2011 18:56, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: Thanks for the detailed explanation of the problem, I think I understand what I have to do to fix. However I would like to have a repro of the bug before sending any

[Qemu-devel] [PATCH 12/13] usb-storage: Turn drive serial into a qdev property usb-storage.serial

2011-06-24 Thread Gerd Hoffmann
From: Markus Armbruster arm...@redhat.com It needs to be a qdev property, because it belongs to the drive's guest part. Precedence: commit a0fef654 and 6ced55a5. Bonus: info qtree now shows the serial number. Signed-off-by: Markus Armbruster arm...@redhat.com Signed-off-by: Gerd Hoffmann

[Qemu-devel] [PATCH v2] qxl: set mm_time in vga update

2011-06-24 Thread Alon Levy
This fixes a problem where on windows 7 startup phase, before the qxl driver is loaded, the drawables are sufficiently large and video like to trigger a stream, but the lack of a filled mm time field triggers a warning in spice-gtk. --- ui/spice-display.c |5 + 1 files changed, 5

[Qemu-devel] [PATCH v2] qxl: interface_get_command: fix reported mode

2011-06-24 Thread Alon Levy
report correct mode when in undefined mode. introduces qxl_mode_to_string, and uses it in another place that looks helpful (qxl_post_load) --- hw/qxl.c | 23 --- 1 files changed, 20 insertions(+), 3 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index e45f33a..e2b07dd 100644

[Qemu-devel] [PATCH] qemu_ram_ptr_length: take ram_addr_t as arguments

2011-06-24 Thread stefano.stabellini
From: Stefano Stabellini stefano.stabell...@eu.citrix.com qemu_ram_ptr_length should take ram_addr_t as argument rather than target_phys_addr_t because is doing comparisons with RAMBlock addresses. cpu_physical_memory_map should create a ram_addr_t address to pass to qemu_ram_ptr_length from

[Qemu-devel] [PATCH v2] qxl-logger: add timestamp to command log

2011-06-24 Thread Alon Levy
--- hw/qxl-logger.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/hw/qxl-logger.c b/hw/qxl-logger.c index 76f43e6..74cadba 100644 --- a/hw/qxl-logger.c +++ b/hw/qxl-logger.c @@ -19,6 +19,7 @@ * along with this program; if not, see http://www.gnu.org/licenses/. */

[Qemu-devel] [PATCH v2] qxl: allow QXL_IO_LOG also in vga

2011-06-24 Thread Alon Levy
The driver may change us to vga mode and still issue a QXL_IO_LOG, which we can easily support. --- hw/qxl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 5266707..96f9c55 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1001,9 +1001,9 @@ static void

Re: [Qemu-devel] [PULL] usb patch queue

2011-06-24 Thread Hans de Goede
Hi, Entire series looks good to me, including my own patches ;) Ack series. Regards, Hans On 06/24/2011 12:59 PM, Gerd Hoffmann wrote: Hi, Here comes the USB patch queue. Nothing major, just a bunch of little fixes and improvements. please pull, Gerd The following changes since

[Qemu-devel] [PATCH v2] qxl: add io_port_to_string

2011-06-24 Thread Alon Levy
--- hw/qxl.c | 64 +- 1 files changed, 63 insertions(+), 1 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 3d5c823..b4bc376 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -350,6 +350,67 @@ static const char *qxl_mode_to_string(int mode)

[Qemu-devel] [PATCH v2] qxl: abort on panic instead of exit

2011-06-24 Thread Alon Levy
--- hw/qxl.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/qxl.h b/hw/qxl.h index 6dd38e6..584f02b 100644 --- a/hw/qxl.h +++ b/hw/qxl.h @@ -87,7 +87,7 @@ typedef struct PCIQXLDevice { #define PANIC_ON(x) if ((x)) { \ printf(%s: PANIC

[Qemu-devel] [PATCH v2] qxl: update and add debug prints

2011-06-24 Thread Alon Levy
--- hw/qxl.c | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 96f9c55..865e985 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -361,7 +361,7 @@ static int interface_get_command(QXLInstance *sin, struct QXLCommandExt *ext) switch

[Qemu-devel] [PATCH v2] qxl: update revision to QXL_REVISION_STABLE_V10

2011-06-24 Thread Alon Levy
also errors if provided revision is wrong. 0 is reserved for experimental revision, the other valid values are as before: 1 - V04 2 - V06 And the new 3 - V10 --- hw/qxl.c | 14 ++ 1 files changed, 10 insertions(+), 4 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index

[Qemu-devel] [PATCH v2] S3S4 support

2011-06-24 Thread Alon Levy
This is a rewrite of v1, doesn't use any new api, reuses stop+start+destroy_surfaces instead of the previously introduced update_mem spice server function. stop does a flush of all commands, updating all the surfaces, and with destroy surfaces the result is the same - everything has been pushed

[Qemu-devel] [PATCH v2] qxl: add dev id to guest prints

2011-06-24 Thread Alon Levy
--- hw/qxl.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 865e985..3d5c823 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1055,7 +1055,8 @@ static void ioport_write(void *opaque, uint32_t addr, uint32_t val) break; case QXL_IO_LOG:

[Qemu-devel] [PATCH 2/2] libcacard: replace copy_string with strndup

2011-06-24 Thread Christophe Fergeau
copy_string reimplements strndup, this commit removes it and replaces all copy_string uses with strndup. Signed-off-by: Christophe Fergeau cferg...@redhat.com --- libcacard/vcard_emul_nss.c | 23 ++- 1 files changed, 6 insertions(+), 17 deletions(-) diff --git

[Qemu-devel] [PATCH v2] qxl: add primary_created state, change mode lifetimes

2011-06-24 Thread Alon Levy
Currently we define the following relation between modes and primary surface existance: QXL_MODE_COMPAT QXL_MODE_NATIVE primary exists QXL_MODE_UNDEFINED QXL_MODE_VGA primary doesn't exist This, coupled with disallowing various IO's when not in QXL_MODE_NATIVE or COMPAT means that the

[Qemu-devel] [PATCH] xen_disk: cope with missing xenstore params node

2011-06-24 Thread stefano.stabellini
From: Stefano Stabellini stefano.stabell...@eu.citrix.com When disk is a cdrom and the drive is empty the params node in xenstore might be missing completely: cope with it instead of segfaulting. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com --- hw/xen_disk.c | 16

[Qemu-devel] [PATCH] xen_disk: treat aio as raw

2011-06-24 Thread stefano.stabellini
From: Stefano Stabellini stefano.stabell...@eu.citrix.com Sometimes the toolstack uses aio without an additional format identifier, in such cases use raw. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com --- hw/xen_disk.c |2 ++ 1 files changed, 2 insertions(+), 0

Re: [Qemu-devel] [PATCH 09/14] exec: last_first_tb was only used in !ONLY_USER case

2011-06-24 Thread Stefan Hajnoczi
On Thu, Jun 02, 2011 at 01:53:44PM +0200, Juan Quintela wrote: Once there, use a better variable name. Signed-off-by: Juan Quintela quint...@redhat.com --- exec.c | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) Thanks, applied to the trivial patches tree:

[Qemu-devel] [PATCH v2] qxl: add QXL_IO_FLUSH_{SURFACES, RELEASE} for guest S3S4 support

2011-06-24 Thread Alon Levy
Add two new IOs. QXL_IO_FLUSH_SURFACES - equivalent to update area for all surfaces, used to reduce vmexits from NumSurfaces to 1 on guest S3, S4 and resolution change (windows driver implementation is such that this is done on each of those occasions). QXL_IO_FLUSH_RELEASE - used to ensure

[Qemu-devel] [PATCH 0/2] xen: enable PV backends for HVM guests

2011-06-24 Thread Stefano Stabellini
Hi all, this small patch series enables console, disk and kbd backends for HVM guests, for the benefit of Linux and Windows PV on HVM drivers. Stefano Stabellini (2): xen: enable console and disk backend in HVM mode xen: add vkbd support for PV on HVM guests hw/xenfb.c | 19

[Qemu-devel] [PATCH 1/2] xen: enable console and disk backend in HVM mode

2011-06-24 Thread stefano.stabellini
From: Stefano Stabellini stefano.stabell...@eu.citrix.com Initialize the Xen console backend and the Xen disk backend even when running in HVM mode so that PV on HVM drivers can connect to them. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com --- xen-all.c |8 1

[Qemu-devel] [PATCH 2/2] xen: add vkbd support for PV on HVM guests

2011-06-24 Thread stefano.stabellini
From: Stefano Stabellini stefano.stabell...@eu.citrix.com Register the vkbd backend even when running as device emulator for HVM guests: it is useful because it doesn't need a frequent timer like usb. Check whether the XenInput DisplayState has been set in the initialise state, rather than the

Re: [Qemu-devel] [PATCH 2/2] libcacard: replace copy_string with strndup

2011-06-24 Thread Alon Levy
On Fri, Jun 24, 2011 at 04:37:40PM +0200, Christophe Fergeau wrote: copy_string reimplements strndup, this commit removes it and replaces all copy_string uses with strndup. Reviewed-by: Alon Levy al...@redhat.com Signed-off-by: Christophe Fergeau cferg...@redhat.com ---

Re: [Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in configure

2011-06-24 Thread Marc-Antoine Perennou
On 10 June 2011 09:14, Markus Armbruster arm...@redhat.com wrote: Peter Maydell peter.mayd...@linaro.org writes: On 9 June 2011 18:44, Andreas Färber andreas.faer...@web.de wrote: Am 09.06.2011 um 17:52 schrieb Marc-Antoine Perennou: Manually including stddef.h or replacing NULL by 0 or

Re: [Qemu-devel] [PATCH 2/2] xen: add vkbd support for PV on HVM guests

2011-06-24 Thread Peter Maydell
On 24 June 2011 15:54, stefano.stabell...@eu.citrix.com wrote: +    if (!in-c.ds) { +        char *vfb = xenstore_read_str(NULL, device/vfb); +        if (vfb == NULL) { +            /* there is no vfb, run vkbd on its own */ +            in-c.ds = get_displaystate(); +        } else { +  

[Qemu-devel] [PATCH 1/2] libcacard: fix soft=... parsing in vcard_emul_options

2011-06-24 Thread Christophe Fergeau
The previous parser had copy and paste errors when computing vname_length and type_params_length, name was used instead of respectively vname and type_params. This led to length that could be bigger than the input string, and to access out of the array bounds when trying to copy these strings.

[Qemu-devel] [PATCH] xen_console: fix memory leak

2011-06-24 Thread stefano.stabellini
From: Stefano Stabellini stefano.stabell...@eu.citrix.com con_init leaks the string type, fix it. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com --- hw/xen_console.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/xen_console.c

Re: [Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in configure

2011-06-24 Thread Stefan Hajnoczi
On Fri, Apr 29, 2011 at 05:59:19PM +0200, Marc-Antoine Perennou wrote: pulse/simple.h does not include stdlib.h We cannot use NULL since it may not be defined Use 0 instead Signed-off-by: Marc-Antoine Perennou marc-anto...@perennou.com --- configure |2 +- 1 files changed, 1

Re: [Qemu-devel] [PATCH 2/2] xen: add vkbd support for PV on HVM guests

2011-06-24 Thread Stefano Stabellini
On Fri, 24 Jun 2011, Peter Maydell wrote: On 24 June 2011 15:54, stefano.stabell...@eu.citrix.com wrote: +    if (!in-c.ds) { +        char *vfb = xenstore_read_str(NULL, device/vfb); +        if (vfb == NULL) { +            /* there is no vfb, run vkbd on its own */ +            

Re: [Qemu-devel] [PATCH] xen_disk: cope with missing xenstore params node

2011-06-24 Thread Stefano Stabellini
On Fri, 24 Jun 2011, Peter Maydell wrote: On 24 June 2011 15:50, stefano.stabell...@eu.citrix.com wrote:     /* read xenstore entries */     if (blkdev-params == NULL) {         blkdev-params = xenstore_read_be_str(blkdev-xendev, params); +        if (blkdev-params != NULL) +          

[Qemu-devel] [PATCH v2] xen_disk: cope with missing xenstore params node

2011-06-24 Thread stefano.stabellini
From: Stefano Stabellini stefano.stabell...@eu.citrix.com When disk is a cdrom and the drive is empty the params node in xenstore might be missing completely: cope with it instead of segfaulting. Updated in v2: - actually removed the strchr(blkdev-params, ':') that caused the segfault; - free

[Qemu-devel] [PATCH 07/13] blockdev: Put space after comma in error message

2011-06-24 Thread Stefan Hajnoczi
From: Markus Armbruster arm...@redhat.com Signed-off-by: Markus Armbruster arm...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- blockdev.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/blockdev.c b/blockdev.c index 1502575..7d579d6 100644

[Qemu-devel] [PULL 00/13] Trivial patches for June 16 to June 24 2011

2011-06-24 Thread Stefan Hajnoczi
(I currently do not have access to my stefa...@linux.vnet.ibm.com email address.) The following changes since commit 744d3644181ddb16ef5944a0f9217e46961c8c84: coreaudio: Fix OSStatus format specifier (2011-06-23 18:56:58 +0400) are available in the git repository at:

Re: [Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in configure

2011-06-24 Thread Stefan Hajnoczi
On Fri, Jun 24, 2011 at 2:31 PM, Marc-Antoine Perennou marc-anto...@perennou.com wrote: On 10 June 2011 09:14, Markus Armbruster arm...@redhat.com wrote: Peter Maydell peter.mayd...@linaro.org writes: On 9 June 2011 18:44, Andreas Färber andreas.faer...@web.de wrote: Am 09.06.2011 um 17:52

  1   2   >