Re: [Qemu-devel] Some uncertain about implementing stream optimized writing

2011-06-29 Thread Fam Zheng
No error report with writing (dd of=/dev/sda ...), but can't change data, (dd if=/dev/sda) dump unchanged. On Wed, Jun 29, 2011 at 1:47 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Wed, Jun 29, 2011 at 5:47 AM, Fam Zheng famc...@gmail.com wrote: Stream optimized VMDK image allocates

Re: [Qemu-devel] Query on the License of qemu

2011-06-29 Thread Amit Shah
On (Tue) 28 Jun 2011 [10:49:03], 박재민 wrote: Dear All, This is Jaemin Park, who delves into qemu. I have 2 questions about the license of qemu. Legal questions should go to lawyers, not developers. Amit

[Qemu-devel] Qemu performance

2011-06-29 Thread Lê Đức Tài
Hi, I have a question about performance of Qemu for powerpc. When I'm changing the CPU clock for taihu board from 33Mhz to 330Mhz by setting the PLL value, the performance of Guest OS is not increased. I use nbench to measure the guest performance. Is qemu always running as maximum performance?

Re: [Qemu-devel] KVM call agenda for June 28

2011-06-29 Thread Kevin Wolf
Am 28.06.2011 21:41, schrieb Marcelo Tosatti: On Tue, Jun 28, 2011 at 02:38:15PM +0100, Stefan Hajnoczi wrote: On Mon, Jun 27, 2011 at 3:32 PM, Juan Quintela quint...@redhat.com wrote: Please send in any agenda items you are interested in covering. Live block copy and image streaming: * The

Re: [Qemu-devel] Some uncertain about implementing stream optimized writing

2011-06-29 Thread Stefan Hajnoczi
On Wed, Jun 29, 2011 at 7:18 AM, Fam Zheng famc...@gmail.com wrote: No error report with writing (dd of=/dev/sda ...), but can't change data, (dd if=/dev/sda) dump unchanged. I suggest we return EIO on non-allocating writes. That way the user will know there is a problem with what they are

Re: [Qemu-devel] Some uncertain about implementing stream optimized writing

2011-06-29 Thread Kevin Wolf
Am 29.06.2011 06:47, schrieb Fam Zheng: Hi, I have implemented reading for sparse optimized and come to implement writing. It is a little complicated and I am not sure what is the best approach. Could you give me some advice? Here is the details: (pasted from http://warm.la/soc/?p=98)

Re: [Qemu-devel] virtio scsi host draft specification, v3

2011-06-29 Thread Paolo Bonzini
On 06/12/2011 09:51 AM, Michael S. Tsirkin wrote: If a device uses more than one queue it is the responsibility of the device to ensure strict request ordering. Maybe I misunderstand - how can this be the responsibility of the device if the device does not get the information about the

Re: [Qemu-devel] virtio scsi host draft specification, v3

2011-06-29 Thread Paolo Bonzini
On 06/14/2011 10:39 AM, Hannes Reinecke wrote: If, however, we decide to expose some details about the backend, we could be using the values from the backend directly. EG we could be forwarding the SCSI target port identifier here (if backed by real hardware) or creating our own SAS-type

Re: [Qemu-devel] [PATCH v2] qxl: add primary_created state, change mode lifetimes

2011-06-29 Thread Gerd Hoffmann
Hi, Shouldn't the mode change to QXL_MODE_UNDEFINED on DESTROY_SURFACES? (I can see it currently doesn't, but it seems like a mistake) No, that is the point - this patch makes the lifetime of QXL_MODE_NATIVE be the lifetime of the driver in the guest, kinda. we never unload the driver in

Re: [Qemu-devel] [PATCH 2/4] virtio-serial: Clean up virtser_bus_dev_print() output

2011-06-29 Thread Gerd Hoffmann
Hi, Erm, I'm not aware that my qdev bool patch got committed yet, so the question of how to parse/print bool properties (on/off vs. yes/no) is still undecided, no comments so far. It would be entirely possible to let the author decide that on a case-by-case basis by using different property

Re: [Qemu-devel] virtio scsi host draft specification, v3

2011-06-29 Thread Michael S. Tsirkin
On Wed, Jun 29, 2011 at 10:23:26AM +0200, Paolo Bonzini wrote: On 06/12/2011 09:51 AM, Michael S. Tsirkin wrote: If a device uses more than one queue it is the responsibility of the device to ensure strict request ordering. Maybe I misunderstand - how can this be the responsibility of

Re: [Qemu-devel] Some uncertain about implementing stream optimized writing

2011-06-29 Thread Fam Zheng
On Wed, Jun 29, 2011 at 4:15 PM, Kevin Wolf kw...@redhat.com wrote: Am 29.06.2011 06:47, schrieb Fam Zheng: Hi, I have implemented reading for sparse optimized and come to implement writing. It is a little complicated and I am not sure what is the best approach. Could you give me some

Re: [Qemu-devel] [PATCH 2/2] qxl: add QXL_IO_UPDATE_MEM for guest S3S4 support

2011-06-29 Thread Gerd Hoffmann
Hi, I think it will receive them after migration, since the command ring was stored. Our confusion here is because you think there is still seemless migration. Unfortunately it doesn't work right now, unless you plan to fix it the only form of migration right now is switch-host, and for

Re: [Qemu-devel] [PATCH v2] qxl: allow QXL_IO_LOG also in vga

2011-06-29 Thread Gerd Hoffmann
Hi, The driver may change us to vga mode and still issue a QXL_IO_LOG, which we can easily support. @@ -1001,9 +1001,9 @@ static void ioport_write(void *opaque, uint32_t addr, uint32_t val) -case QXL_IO_LOG: case QXL_IO_CREATE_PRIMARY_ASYNC: case QXL_IO_UPDATE_IRQ: +

Re: [Qemu-devel] [PATCH 2/2] qxl: add QXL_IO_UPDATE_MEM for guest S3S4 support

2011-06-29 Thread Alon Levy
On Wed, Jun 29, 2011 at 11:01:11AM +0200, Gerd Hoffmann wrote: Hi, I think it will receive them after migration, since the command ring was stored. Our confusion here is because you think there is still seemless migration. Unfortunately it doesn't work right now, unless you plan to fix

Re: [Qemu-devel] [PATCH v2] qxl: add primary_created state, change mode lifetimes

2011-06-29 Thread Alon Levy
On Wed, Jun 29, 2011 at 10:41:43AM +0200, Gerd Hoffmann wrote: Hi, Shouldn't the mode change to QXL_MODE_UNDEFINED on DESTROY_SURFACES? (I can see it currently doesn't, but it seems like a mistake) No, that is the point - this patch makes the lifetime of QXL_MODE_NATIVE be the lifetime

Re: [Qemu-devel] [PATCH 2/4] virtio-serial: Clean up virtser_bus_dev_print() output

2011-06-29 Thread Markus Armbruster
Gerd Hoffmann kra...@redhat.com writes: Hi, Erm, I'm not aware that my qdev bool patch got committed yet, so the question of how to parse/print bool properties (on/off vs. yes/no) is still undecided, no comments so far. It would be entirely possible to let the author decide that on a

Re: [Qemu-devel] [PATCH 2/4] virtio-serial: Clean up virtser_bus_dev_print() output

2011-06-29 Thread Markus Armbruster
Andreas Färber andreas.faer...@web.de writes: Am 19.05.2011 um 16:18 schrieb Markus Armbruster: Amit Shah amit.s...@redhat.com writes: On (Thu) 19 May 2011 [13:37:15], Markus Armbruster wrote: Old version looks like this in info qtree (last four lines): dev: virtconsole, id

Re: [Qemu-devel] virtio scsi host draft specification, v3

2011-06-29 Thread Stefan Hajnoczi
On Wed, Jun 29, 2011 at 9:33 AM, Paolo Bonzini pbonz...@redhat.com wrote: On 06/14/2011 10:39 AM, Hannes Reinecke wrote: If, however, we decide to expose some details about the backend, we could be using the values from the backend directly. EG we could be forwarding the SCSI target port

Re: [Qemu-devel] [PATCH] hw/usb-musb.c: Don't misuse usb_packet_complete()

2011-06-29 Thread Peter Maydell
Gerd: ping? thanks -- PMM On 14 June 2011 12:24, Peter Maydell peter.mayd...@linaro.org wrote: In musb_packet() handle final processing of non-asynchronous USB packets by directly calling musb_schedule_cb() rather than going through usb_packet_complete(). The latter will trigger an assertion

Re: [Qemu-devel] [PATCH v2] qxl: allow QXL_IO_LOG also in vga

2011-06-29 Thread Alon Levy
On Wed, Jun 29, 2011 at 11:22:05AM +0200, Gerd Hoffmann wrote: Hi, The driver may change us to vga mode and still issue a QXL_IO_LOG, which we can easily support. @@ -1001,9 +1001,9 @@ static void ioport_write(void *opaque, uint32_t addr, uint32_t val) -case QXL_IO_LOG:

Re: [Qemu-devel] [PATCH] hw/usb-musb.c: Don't misuse usb_packet_complete()

2011-06-29 Thread Gerd Hoffmann
On 06/29/11 11:43, Peter Maydell wrote: Gerd: ping? Oops, slipped through somehow. Picked into the usb queue now. cheers, Gerd

Re: [Qemu-devel] [PATCHv4] qemu-img: Add cache command line option

2011-06-29 Thread Kevin Wolf
Am 20.06.2011 18:48, schrieb Federico Simoncelli: qemu-img currently writes disk images using writeback and filling up the cache buffers which are then flushed by the kernel preventing other processes from accessing the storage. This is particularly bad in cluster environments where time-based

Re: [Qemu-devel] [PATCH v2] qxl: allow QXL_IO_LOG also in vga

2011-06-29 Thread Gerd Hoffmann
Hi, Yeah, my bad. I did something wierd, and missed this. I'll send a v3. Do you have other comments? I stopped looking after figuring stuff doesn't apply to master. Unrelated, but have you looked at the async patches that I sent, and yonit's comments? - (me) catch EINTR and EAGAIN in

Re: [Qemu-devel] KVM call agenda for June 28

2011-06-29 Thread Stefan Hajnoczi
On Wed, Jun 29, 2011 at 8:57 AM, Kevin Wolf kw...@redhat.com wrote: Am 28.06.2011 21:41, schrieb Marcelo Tosatti: stream -- 1) base - remote 2) base - remote - local 3) base - local local image is always valid. Requires backing file support. With the above, this restriction wouldn't

Re: [Qemu-devel] virtio scsi host draft specification, v3

2011-06-29 Thread Paolo Bonzini
On 06/29/2011 12:03 PM, Christoph Hellwig wrote: I agree here, in fact I misread Hannes's comment as if a driver uses more than one queue it is responsibility of the driver to ensure strict request ordering. If you send requests to different queues, you know that those requests are

Re: [Qemu-devel] virtio scsi host draft specification, v3

2011-06-29 Thread Hannes Reinecke
On 06/29/2011 12:07 PM, Christoph Hellwig wrote: On Wed, Jun 29, 2011 at 10:39:42AM +0100, Stefan Hajnoczi wrote: I think we're missing a level of addressing. We need the ability to talk to multiple target ports in order for list target ports to make sense. Right now there is one implicit

Re: [Qemu-devel] virtio scsi host draft specification, v3

2011-06-29 Thread Michael S. Tsirkin
On Wed, Jun 29, 2011 at 12:06:29PM +0200, Paolo Bonzini wrote: On 06/29/2011 12:03 PM, Christoph Hellwig wrote: I agree here, in fact I misread Hannes's comment as if a driver uses more than one queue it is responsibility of the driver to ensure strict request ordering. If you send

Re: [Qemu-devel] [PATCH 2/2] qxl: add QXL_IO_UPDATE_MEM for guest S3S4 support

2011-06-29 Thread Gerd Hoffmann
On 06/29/11 11:21, Alon Levy wrote: On Wed, Jun 29, 2011 at 11:01:11AM +0200, Gerd Hoffmann wrote: Hi, I think it will receive them after migration, since the command ring was stored. Our confusion here is because you think there is still seemless migration. Unfortunately it doesn't work

Re: [Qemu-devel] virtio scsi host draft specification, v3

2011-06-29 Thread Paolo Bonzini
On 06/29/2011 12:31 PM, Michael S. Tsirkin wrote: On Wed, Jun 29, 2011 at 12:06:29PM +0200, Paolo Bonzini wrote: On 06/29/2011 12:03 PM, Christoph Hellwig wrote: I agree here, in fact I misread Hannes's comment as if a driver uses more than one queue it is responsibility of the driver to

Re: [Qemu-devel] Qemu performance

2011-06-29 Thread Mulyadi Santosa
Hi... :) 2011/6/29 Lê Đức Tài letai_d...@yahoo.com.vn: Hi, I have a question about performance of Qemu for powerpc. When I'm changing the CPU clock for taihu board from 33Mhz to 330Mhz by setting the PLL value, the performance of Guest OS is not increased. I use nbench to measure the guest

Re: [Qemu-devel] virtio scsi host draft specification, v3

2011-06-29 Thread Christoph Hellwig
On Wed, Jun 29, 2011 at 12:23:38PM +0200, Hannes Reinecke wrote: The general idea here is that we can support NPIV. With NPIV we'll have several scsi_hosts, each of which is assigned a different set of LUNs by the array. With virtio we need to able to react on LUN remapping on the array side,

Re: [Qemu-devel] virtio scsi host draft specification, v3

2011-06-29 Thread Christoph Hellwig
On Wed, Jun 29, 2011 at 10:39:42AM +0100, Stefan Hajnoczi wrote: I think we're missing a level of addressing. We need the ability to talk to multiple target ports in order for list target ports to make sense. Right now there is one implicit target that handles all commands. That means there

Re: [Qemu-devel] virtio scsi host draft specification, v3

2011-06-29 Thread Christoph Hellwig
On Sun, Jun 12, 2011 at 10:51:41AM +0300, Michael S. Tsirkin wrote: For example, if the driver is crazy enough to put all write requests on one queue and all barriers on another one, how is the device supposed to ensure ordering? There is no such things as barriers in SCSI. The thing that

Re: [Qemu-devel] virtio scsi host draft specification, v3

2011-06-29 Thread Christoph Hellwig
On Wed, Jun 29, 2011 at 10:23:26AM +0200, Paolo Bonzini wrote: I agree here, in fact I misread Hannes's comment as if a driver uses more than one queue it is responsibility of the driver to ensure strict request ordering. If you send requests to different queues, you know that those requests

Re: [Qemu-devel] virtio scsi host draft specification, v3

2011-06-29 Thread Christoph Hellwig
On Tue, Jun 14, 2011 at 05:30:24PM +0200, Hannes Reinecke wrote: Which is exactly the problem I was referring to. When using more than one channel the request ordering _as seen by the initiator_ has to be preserved. This is quite hard to do from a device's perspective; it might be able to

[Qemu-devel] [PATCH v2] arm-semi: Provide access to CLI arguments passed through the -append option

2011-06-29 Thread Cédric VINCENT
This patch basically adapts the new semi-hosting command-line support -- introduced by Wolfgang Schildbach in the commit 2e8785ac -- for use in system-mode. Note that the arm_cmdline_len and host_cmdline_len variables were renamed respectively input_size and output_size because: * in C, the

Re: [Qemu-devel] [PATCH] pci_ids: tweak names to match linux/pci_ids.h

2011-06-29 Thread Alexander Graf
On 27.06.2011, at 14:21, Stefano Stabellini wrote: On Sun, 26 Jun 2011, Michael S. Tsirkin wrote: Sync xen names to ones used by linux. Add xen platform device id as well. Signed-off-by: Michael S. Tsirkin m...@redhat.com thanks for the patch, it is fine by me. Michael, which tree do

Re: [Qemu-devel] [PATCH 10/11] usb-uhci: Add support for being a companion controller

2011-06-29 Thread Gerd Hoffmann
Hi, +if (s-masterbus) { +USBPort *ports[NB_PORTS]; +for(i = 0; i NB_PORTS; i++) { +s-ports[i].port.ops =uhci_port_ops; +s-ports[i].port.opaque = s; +s-ports[i].port.index = i; +s-ports[i].port.speedmask = +

Re: [Qemu-devel] [PATCH] xen: move to new pci initializers

2011-06-29 Thread Alexander Graf
On 27.06.2011, at 14:21, Stefano Stabellini wrote: On Sun, 26 Jun 2011, Michael S. Tsirkin wrote: move ids to pci info structure Signed-off-by: Michael S. Tsirkin m...@redhat.com Untested. tested and working correctly, it is fine by me. Michael, which tree do you want this to go

[Qemu-devel] [PATCH v3] xen_console: support the new extended xenstore protocol

2011-06-29 Thread stefano.stabellini
From: Stefano Stabellini stefano.stabell...@eu.citrix.com Since CS 21994 on xen-unstable.hg and CS 466608f3a32e1f9808acdf832a5843af37e5fcec on qemu-xen-unstable.git, few changes have been introduced to the PV console xenstore protocol, as described by the document docs/misc/console.txt under

Re: [Qemu-devel] [PATCH 2/2] qxl: add QXL_IO_UPDATE_MEM for guest S3S4 support

2011-06-29 Thread Alon Levy
On Wed, Jun 29, 2011 at 12:25:00PM +0200, Gerd Hoffmann wrote: On 06/29/11 11:21, Alon Levy wrote: On Wed, Jun 29, 2011 at 11:01:11AM +0200, Gerd Hoffmann wrote: Hi, I think it will receive them after migration, since the command ring was stored. Our confusion here is because you think

[Qemu-devel] [PATCH] xen: introduce xen_change_state_handler

2011-06-29 Thread stefano.stabellini
From: Anthony PERARD anthony.per...@citrix.com Remove the call to xenstore_record_dm_state from xen_main_loop_prepare that is HVM specific. Add a new vm_change_state_handler shared between xen_pv and xen_hvm machines to record the VM state to xenstore. Signed-off-by: Anthony PERARD

Re: [Qemu-devel] [PATCH 10/11] usb-uhci: Add support for being a companion controller

2011-06-29 Thread Hans de Goede
Hi, On 06/29/2011 12:57 PM, Gerd Hoffmann wrote: Hi, + if (s-masterbus) { + USBPort *ports[NB_PORTS]; + for(i = 0; i NB_PORTS; i++) { + s-ports[i].port.ops =uhci_port_ops; + s-ports[i].port.opaque = s; + s-ports[i].port.index = i; + s-ports[i].port.speedmask = + USB_SPEED_MASK_LOW |

[Qemu-devel] [PATCHv3] async io: suggested fixes

2011-06-29 Thread Alon Levy
--- hw/qxl.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index a26fb2a..89e452e 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1178,6 +1178,7 @@ static void ioport_write(void *opaque, uint32_t addr, uint32_t val) case QXL_IO_MEMSLOT_ADD_ASYNC:

[Qemu-devel] [PATCHv3] async thread fix - handle EAGAIN/EINTR, remove fprintf

2011-06-29 Thread Alon Levy
--- hw/qxl.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 89e452e..3f84b0c 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1025,13 +1025,15 @@ static void *ioport_write_async(void *arg) while (true) { ret = read(d-aio_pipe[0], io,

[Qemu-devel] Default cache mode

2011-06-29 Thread Kevin Wolf
Hi, I think we have touched this topic before during some IRC discussions or somewhere deep in a mailing list thread, but I think it hasn't been discussed on the list. Our default cache mode of cache=writethrough is extremely conservative and provides absolute safety at the cost of performance,

[Qemu-devel] [PATCHv3] qxl-logger: add timestamp to command log

2011-06-29 Thread Alon Levy
--- hw/qxl-logger.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/hw/qxl-logger.c b/hw/qxl-logger.c index 76f43e6..74cadba 100644 --- a/hw/qxl-logger.c +++ b/hw/qxl-logger.c @@ -19,6 +19,7 @@ * along with this program; if not, see http://www.gnu.org/licenses/. */

[Qemu-devel] [PATCHv3] qxl: allow QXL_IO_LOG also in vga

2011-06-29 Thread Alon Levy
The driver may change us to vga mode and still issue a QXL_IO_LOG, which we can easily support. --- hw/qxl.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index a5827fb..d38e3c0 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1085,6 +1085,7 @@ static void

[Qemu-devel] [PATCHv3] qxl: add mode to debugprint on destroy primary

2011-06-29 Thread Alon Levy
--- hw/qxl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 49d7b10..a5827fb 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1167,7 +1167,7 @@ static void ioport_write(void *opaque, uint32_t addr, uint32_t val) } case

Re: [Qemu-devel] [PATCH v2] qxl: allow QXL_IO_LOG also in vga

2011-06-29 Thread Alon Levy
On Wed, Jun 29, 2011 at 12:02:30PM +0200, Gerd Hoffmann wrote: Hi, Yeah, my bad. I did something wierd, and missed this. I'll send a v3. Do you have other comments? I stopped looking after figuring stuff doesn't apply to master. Unrelated, but have you looked at the async patches

[Qemu-devel] [PATCHv3] qxl: update and add debug prints

2011-06-29 Thread Alon Levy
--- hw/qxl.c | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index d38e3c0..8895b14 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -444,7 +444,7 @@ static int interface_get_command(QXLInstance *sin, struct QXLCommandExt *ext) switch

[Qemu-devel] [PATCHv3] qxl: only disallow specific io's in vga mode

2011-06-29 Thread Alon Levy
Since the driver is still operation also after moving to UNDEFINED, i.e. by destroying primary in any way. --- hw/qxl.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index b794b2c..99a4708 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1150,8 +1150,9 @@

[Qemu-devel] [PATCHv3] qxl: update revision to QXL_REVISION_STABLE_V10

2011-06-29 Thread Alon Levy
also errors if provided revision is wrong. 0 is reserved for experimental revision, the other valid values are as before: 1 - V04 2 - V06 And the new 3 - V10 --- hw/qxl.c | 16 +--- 1 files changed, 9 insertions(+), 7 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index

[Qemu-devel] [PATCHv3] qxl: add QXL_IO_FLUSH_{SURFACES, RELEASE} for guest S3S4 support

2011-06-29 Thread Alon Levy
Add two new IOs. QXL_IO_FLUSH_SURFACES - equivalent to update area for all surfaces, used to reduce vmexits from NumSurfaces to 1 on guest S3, S4 and resolution change (windows driver implementation is such that this is done on each of those occasions). QXL_IO_FLUSH_RELEASE - used to ensure

[Qemu-devel] [PATCHv3] qxl S3S4 (suspend and hibernate) support

2011-06-29 Thread Alon Levy
Based on Gerd's tree: git://anongit.freedesktop.org/spice/qemu bz700134^ (i.e. without the last patch for latency measurement marked [debug]) Changes from v2: 1: patch uses V10 instead of 3. 2: handle EAGAIN/EINTR 3: fixes a deadlock because of usage of wlock for surface tracking. 4..end-2:

[Qemu-devel] [PATCHv3] qxl: move to UNDEFINED on DESTROY_ALL_SURFACES{, _ASYNC}

2011-06-29 Thread Alon Levy
--- hw/qxl.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index f158d45..b794b2c 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1245,6 +1245,7 @@ static void ioport_write(void *opaque, uint32_t addr, uint32_t val)

[Qemu-devel] [PATCHv3] qxl: use track_lock instead of wlock for guest_surfaces

2011-06-29 Thread Alon Levy
--- hw/qxl.c |7 +-- hw/qxl.h |2 ++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 3f84b0c..49d7b10 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -150,10 +150,12 @@ void qxl_spice_update_area(PCIQXLDevice *qxl, uint32_t surface_id, void

Re: [Qemu-devel] Default cache mode

2011-06-29 Thread Alexander Graf
On 29.06.2011, at 13:59, Kevin Wolf wrote: Hi, I think we have touched this topic before during some IRC discussions or somewhere deep in a mailing list thread, but I think it hasn't been discussed on the list. Our default cache mode of cache=writethrough is extremely conservative and

Re: [Qemu-devel] Default cache mode

2011-06-29 Thread Anthony Liguori
On 06/29/2011 06:59 AM, Kevin Wolf wrote: Hi, I think we have touched this topic before during some IRC discussions or somewhere deep in a mailing list thread, but I think it hasn't been discussed on the list. Our default cache mode of cache=writethrough is extremely conservative and provides

Re: [Qemu-devel] Default cache mode

2011-06-29 Thread Anthony Liguori
On 06/29/2011 06:59 AM, Kevin Wolf wrote: Hi, I think we have touched this topic before during some IRC discussions or somewhere deep in a mailing list thread, but I think it hasn't been discussed on the list. Our default cache mode of cache=writethrough is extremely conservative and provides

[Qemu-devel] [PATCHv3] qxl: abort on panic instead of exit

2011-06-29 Thread Alon Levy
--- hw/qxl.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/qxl.h b/hw/qxl.h index 7df594e..bf875a0 100644 --- a/hw/qxl.h +++ b/hw/qxl.h @@ -89,7 +89,7 @@ typedef struct PCIQXLDevice { #define PANIC_ON(x) if ((x)) { \ printf(%s: PANIC

Re: [Qemu-devel] Default cache mode

2011-06-29 Thread Anthony Liguori
On 06/29/2011 07:16 AM, Kevin Wolf wrote: Am 29.06.2011 14:06, schrieb Anthony Liguori: On 06/29/2011 06:59 AM, Kevin Wolf wrote: Hi, I think we have touched this topic before during some IRC discussions or somewhere deep in a mailing list thread, but I think it hasn't been discussed on the

Re: [Qemu-devel] Default cache mode

2011-06-29 Thread Kevin Wolf
Am 29.06.2011 14:06, schrieb Anthony Liguori: On 06/29/2011 06:59 AM, Kevin Wolf wrote: Hi, I think we have touched this topic before during some IRC discussions or somewhere deep in a mailing list thread, but I think it hasn't been discussed on the list. Our default cache mode of

[Qemu-devel] [PATCHv3] qxl: add dev id to guest prints

2011-06-29 Thread Alon Levy
--- hw/qxl.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 8895b14..22455af 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1136,7 +1136,8 @@ static void ioport_write(void *opaque, uint32_t addr, uint32_t val) break; case QXL_IO_LOG:

[Qemu-devel] [PATCHv3] qxl: add io_port_to_string

2011-06-29 Thread Alon Levy
--- hw/qxl.c | 64 +- 1 files changed, 63 insertions(+), 1 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 22455af..0ab8074 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -433,6 +433,67 @@ static const char *qxl_mode_to_string(int mode)

Re: [Qemu-devel] [PATCH 10/11] usb-uhci: Add support for being a companion controller

2011-06-29 Thread Gerd Hoffmann
Hi, I agree, but there is a reason why I went with a usb_bus_register_companion function instead of with a usb_bus_register_companion_port function, the uhci controller needs to know how many companion controllers it has (to report this in one of its registers). When we're registering ports 1

Re: [Qemu-devel] [PATCH] pci_ids: tweak names to match linux/pci_ids.h

2011-06-29 Thread Michael S. Tsirkin
On Wed, Jun 29, 2011 at 01:05:37PM +0200, Alexander Graf wrote: On 27.06.2011, at 14:21, Stefano Stabellini wrote: On Sun, 26 Jun 2011, Michael S. Tsirkin wrote: Sync xen names to ones used by linux. Add xen platform device id as well. Signed-off-by: Michael S. Tsirkin

Re: [Qemu-devel] [PATCH] Command line support for altering the log file location

2011-06-29 Thread Matthew Fernandez
On 29 June 2011 05:02, Edgar E. Iglesias edgar.igles...@gmail.com wrote: On Wed, Jun 08, 2011 at 12:32:40PM +1000, Matthew Fernandez wrote: Add command line support for logging to a location other than /tmp/qemu.log. With logging enabled (command line option -d), the log is written to the

Re: [Qemu-devel] [PATCHv3] qxl: add io_port_to_string

2011-06-29 Thread Gerd Hoffmann
Hi, -dprint(d, 1, %s: unexpected port 0x%x in vga mode\n, __FUNCTION__, io_port); +dprint(d, 1, %s: unexpected port 0x%x (%s) in vga mode\n, +__FUNCTION__, io_port, io_port_to_string(io_port)); Is this worth it? Should be a quite rare event ... cheers, Gerd

Re: [Qemu-devel] Default cache mode

2011-06-29 Thread Kevin Wolf
Am 29.06.2011 15:00, schrieb Avi Kivity: On 06/29/2011 02:59 PM, Kevin Wolf wrote: Hi, I think we have touched this topic before during some IRC discussions or somewhere deep in a mailing list thread, but I think it hasn't been discussed on the list. Our default cache mode of

Re: [Qemu-devel] [PATCH] xen: move to new pci initializers

2011-06-29 Thread Michael S. Tsirkin
On Wed, Jun 29, 2011 at 01:05:07PM +0200, Alexander Graf wrote: On 27.06.2011, at 14:21, Stefano Stabellini wrote: On Sun, 26 Jun 2011, Michael S. Tsirkin wrote: move ids to pci info structure Signed-off-by: Michael S. Tsirkin m...@redhat.com Untested. tested and working

Re: [Qemu-devel] Default cache mode

2011-06-29 Thread Anthony Liguori
On 06/29/2011 08:00 AM, Avi Kivity wrote: On 06/29/2011 02:59 PM, Kevin Wolf wrote: Hi, I think we have touched this topic before during some IRC discussions or somewhere deep in a mailing list thread, but I think it hasn't been discussed on the list. Our default cache mode of

Re: [Qemu-devel] [PATCHv3] qxl: move to UNDEFINED on DESTROY_ALL_SURFACES{, _ASYNC}

2011-06-29 Thread Gerd Hoffmann
Hi, +case QXL_IO_DESTROY_ALL_SURFACES_ASYNC: +d-mode = QXL_MODE_UNDEFINED; Should go to the async thread. cheers, Gerd

Re: [Qemu-devel] Default cache mode

2011-06-29 Thread Kevin Wolf
Am 29.06.2011 14:23, schrieb Anthony Liguori: On 06/29/2011 07:16 AM, Kevin Wolf wrote: Am 29.06.2011 14:06, schrieb Anthony Liguori: On 06/29/2011 06:59 AM, Kevin Wolf wrote: Hi, I think we have touched this topic before during some IRC discussions or somewhere deep in a mailing list

Re: [Qemu-devel] [PATCH] Add compat eventfd header

2011-06-29 Thread Alexander Graf
On 28.06.2011, at 17:35, Michael S. Tsirkin wrote: Support build on RHEL 5.X where we have syscall for eventfd but not userspace wrapper. (cherry-picked from commit 9e3269181e9bc56feb43bcd4e8ce0b82cd543e65 in qemu-kvm.git). Signed-off-by: Michael S. Tsirkin m...@redhat.com ---

Re: [Qemu-devel] [PATCH] Add compat eventfd header

2011-06-29 Thread Michael S. Tsirkin
On Wed, Jun 29, 2011 at 03:02:46PM +0200, Alexander Graf wrote: On 28.06.2011, at 17:35, Michael S. Tsirkin wrote: Support build on RHEL 5.X where we have syscall for eventfd but not userspace wrapper. (cherry-picked from commit 9e3269181e9bc56feb43bcd4e8ce0b82cd543e65 in

[Qemu-devel] [PATCH 1/3] linux-user: Add support for KD...LED ioctls

2011-06-29 Thread Cédric VINCENT
DirectFB-1.0 uses at least one of the four added ioctls, and the three others were added for completeness. This patch was validated with the program setleds and the following Makefile: SETLEDS_INIT = setleds -v -num -caps -scroll SETLEDS_TESTS = sh -c ' \ setleds -v +num +caps

Re: [Qemu-devel] [PATCHv3] (alon-local) symlink bios out of tree

2011-06-29 Thread Gerd Hoffmann
On 06/29/11 13:57, Alon Levy wrote: --- pc-bios/bios.bin| Bin 131072 - 26 bytes pc-bios/vgabios-qxl.bin | Bin 40448 - 41 bytes 2 files changed, 0 insertions(+), 0 deletions(-) mode change 100644 = 12 pc-bios/bios.bin mode change 100644 = 12 pc-bios/vgabios-qxl.bin

Re: [Qemu-devel] [PATCHv3] qxl: add QXL_IO_FLUSH_{SURFACES, RELEASE} for guest S3S4 support

2011-06-29 Thread Gerd Hoffmann
Hi, +case QXL_IO_FLUSH_SURFACES: +dprint(d, 1, QXL_IO_FLUSH_SURFACES (%d) entry (%s, s#=%d, res#=%d)\n, +val, qxl_mode_to_string(d-mode), d-guest_surfaces.count, +d-num_free_res); +qemu_spice_stop(d-ssd); +qemu_spice_start(d-ssd); +

Re: [Qemu-devel] [PATCHv3] qxl: abort on panic instead of exit

2011-06-29 Thread Gerd Hoffmann
On 06/29/11 13:57, Alon Levy wrote: --- hw/qxl.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/qxl.h b/hw/qxl.h index 7df594e..bf875a0 100644 --- a/hw/qxl.h +++ b/hw/qxl.h @@ -89,7 +89,7 @@ typedef struct PCIQXLDevice { #define PANIC_ON(x) if ((x)) {

[Qemu-devel] [PATCH 2/3] linux-user: Add support for more VT ioctls

2011-06-29 Thread Cédric VINCENT
DirectFB-1.0 uses at least two of the four added ioctls, and the two others were added for completeness. This patch was validated with the program vlock -all/-new. Signed-off-by: Cédric VINCENT cedric.vinc...@st.com Cc: Riku Voipio riku.voi...@iki.fi --- linux-user/ioctls.h|4

Re: [Qemu-devel] Default cache mode

2011-06-29 Thread Stefan Hajnoczi
On Wed, Jun 29, 2011 at 12:59 PM, Kevin Wolf kw...@redhat.com wrote: I'm not entirely sure if I should suggest writeback or none as the new default, but I think it could make sense to change it. I agree that cache=none is safe and fast with correct guests and local disks. It is beaten by

[Qemu-devel] qemu: hardware error: Failed to create USB device 'usb-tablet'

2011-06-29 Thread d...@ucore.info
Hi, I'm trying to get the tablet emulation for Qemu's VNC server to handle the mouse better. I'm using `qemu-system-arm` and everything is OK except for the mouse movement. After I add `-usb -usbdevie table` argument to `qemu-system-arm` invocation I get: qemu: hardware error: Failed to create

Re: [Qemu-devel] Default cache mode

2011-06-29 Thread Christoph Hellwig
On Wed, Jun 29, 2011 at 07:06:03AM -0500, Anthony Liguori wrote: But for the most part, we track bare metal fairly well in terms of block performance, no? only if using cache=none and fmt=raw on either a blockdevice or a fully preallocated (not fallocated) file on a modern filesystem.

Re: [Qemu-devel] [PATCH] Add compat eventfd header

2011-06-29 Thread Alexander Graf
On 29.06.2011, at 15:11, Michael S. Tsirkin wrote: On Wed, Jun 29, 2011 at 03:02:46PM +0200, Alexander Graf wrote: On 28.06.2011, at 17:35, Michael S. Tsirkin wrote: Support build on RHEL 5.X where we have syscall for eventfd but not userspace wrapper. (cherry-picked from commit

Re: [Qemu-devel] [PATCH] block/raw-posix: Linux compat-ioctl warning workaround

2011-06-29 Thread Kevin Wolf
Am 29.06.2011 15:36, schrieb Johannes Stezenbach: On Linux x86_64 host with 32bit userspace, running qemu or even just qemu-img create -f qcow2 some.img 1G causes a kernel warning: ioctl32(qemu-img:5296): Unknown cmd fd(3) cmd(5326){t:'S';sz:0} arg(7fff) on some.img

Re: [Qemu-devel] Default cache mode

2011-06-29 Thread Avi Kivity
On 06/29/2011 02:59 PM, Kevin Wolf wrote: Hi, I think we have touched this topic before during some IRC discussions or somewhere deep in a mailing list thread, but I think it hasn't been discussed on the list. Our default cache mode of cache=writethrough is extremely conservative and provides

Re: [Qemu-devel] Default cache mode

2011-06-29 Thread Christoph Hellwig
On Wed, Jun 29, 2011 at 02:32:34PM +0200, Kevin Wolf wrote: Christoph, it looks like we're back to your WCE patches then. Do you still work on them? The IDE patch is ready once the bdrv_reopen from the hostcache patches goes in. Virtio still needs to be redesigned to use a command instead of

Re: [Qemu-devel] Default cache mode

2011-06-29 Thread Avi Kivity
On 06/29/2011 04:05 PM, Anthony Liguori wrote: So long as -M old retains the old behaviour, I'm in favour. wce needs to be preserved but cache wouldn't need to be AFAICT. Right. -- error compiling committee.c: too many arguments to function

Re: [Qemu-devel] [PATCHv3] qxl: update and add debug prints

2011-06-29 Thread Gerd Hoffmann
Hi, -dprint(d, 1, %s: done\n, __FUNCTION__); +dprint(d, 1, %s: done (num_free_res %d, %p)\n, __FUNCTION__, +d-num_free_res, d-last_release); case QXL_IO_RESET: -dprint(d, 1, QXL_IO_RESET\n); +dprint(d, 1, QXL_IO_RESET %d (%p)\n, d-num_free_res, +

Re: [Qemu-devel] Default cache mode

2011-06-29 Thread Christoph Hellwig
On Wed, Jun 29, 2011 at 07:08:18AM -0500, Anthony Liguori wrote: As long as we advertise wce and wce can be toggled from the guest, I don't think the default is all that important. I think cache=on is the right default for most common use cases. What do you mean with cache=on? We have

Re: [Qemu-devel] Default cache mode

2011-06-29 Thread Anthony Liguori
On 06/29/2011 08:50 AM, Christoph Hellwig wrote: On Wed, Jun 29, 2011 at 07:23:31AM -0500, Anthony Liguori wrote: Which file system on the host? Any filesystem. Although extN and btrfs are particularly bad. At any rate, I'm a big fan of making wce tunable in the guest and then I think

[Qemu-devel] [PATCH 3/3] linux-user: Add support for even more FB ioctls

2011-06-29 Thread Cédric VINCENT
This patch was validated with programs from DirectFB-1.0 and WebKit/DirectFB. Signed-off-by: Cédric VINCENT cedric.vinc...@st.com Cc: Riku Voipio riku.voi...@iki.fi --- linux-user/ioctls.h|5 + linux-user/syscall_defs.h |5 + linux-user/syscall_types.h | 13

Re: [Qemu-devel] Default cache mode

2011-06-29 Thread Stefan Hajnoczi
On Wed, Jun 29, 2011 at 1:21 PM, Alexander Graf ag...@suse.de wrote: On 29.06.2011, at 13:59, Kevin Wolf wrote: I'm not entirely sure if I should suggest writeback or none as the new default, but I think it could make sense to change it. None as default would be a bad choice, as not all

Re: [Qemu-devel] [PATCHv3] qxl: abort on panic instead of exit

2011-06-29 Thread Alon Levy
On Wed, Jun 29, 2011 at 02:44:11PM +0200, Gerd Hoffmann wrote: On 06/29/11 13:57, Alon Levy wrote: --- hw/qxl.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/qxl.h b/hw/qxl.h index 7df594e..bf875a0 100644 --- a/hw/qxl.h +++ b/hw/qxl.h @@ -89,7 +89,7 @@

Re: [Qemu-devel] Default cache mode

2011-06-29 Thread Christoph Hellwig
On Wed, Jun 29, 2011 at 01:52:19PM +0100, Stefan Hajnoczi wrote: Whether it is safe to transition to cache=none or not depends on what broken guests are still widely deployed. Does CentOS 5 flush the disk cache? Unless you use ext3 it does. The same unfortunate story still applies to current

[Qemu-devel] linux-user: Add support for ioctls related to the frame-buffer/console

2011-06-29 Thread Cédric VINCENT
This patch series adds support for some ioctls related to the Linux frame-buffer/console. It was fully tested for the SH4 target and partially tested for the x86_64 and ARM targets, this latter fails the setleds tests (embedded within the first commit message) but it seems the problem doesn't

[Qemu-devel] Questions on DeviceState and Virtio infrastructure

2011-06-29 Thread Wei Liu
Hi, QEMU folks I know that I might have a bad title for this post, but I just don't have better idea for the title. I'm developing virtio support for Xen pv guest, hoping to reuse the virtio infrastructure in qemu, i.e. I'm planning to use qemu as virtio backend for Xen pv. And qemu can be run

Re: [Qemu-devel] [PATCHv3] qxl: update and add debug prints

2011-06-29 Thread Alon Levy
On Wed, Jun 29, 2011 at 03:01:30PM +0200, Gerd Hoffmann wrote: Hi, -dprint(d, 1, %s: done\n, __FUNCTION__); +dprint(d, 1, %s: done (num_free_res %d, %p)\n, __FUNCTION__, +d-num_free_res, d-last_release); case QXL_IO_RESET: -dprint(d, 1, QXL_IO_RESET\n); +

  1   2   >