Re: [Qemu-devel] [PATCH v5 09/12] VMDK: open/read/write for monolithicFlat image

2011-06-30 Thread Stefan Hajnoczi
On Thu, Jun 30, 2011 at 2:57 AM, Fam Zheng famc...@gmail.com wrote: On Wed, Jun 29, 2011 at 11:57 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Tue, Jun 28, 2011 at 2:32 AM, Fam Zheng famc...@gmail.com wrote: +        /* trim the quotation marks around */ +        if (fname[0] == '') { +  

[Qemu-devel] [PATCH V3] Support logging xen-guest console

2011-06-30 Thread Chunyan Liu
Add code to support logging xen-domU console, as what xenconsoled does. To enable logging, set environment variable XENCONSOLED_TRACE=guest and XENCONSOLED_LOGDIR=specified directory, log file will be saved in specified directory. Signed-off-by: Chunyan Liu cy...@novell.com --- hw/xen_console.c

Re: [Qemu-devel] [PATCH V2] Support logging xen-guest console

2011-06-30 Thread Chun Yan Liu
On Thursday, June 23, 2011 02:22:37 AM Anthony Liguori wrote: On 06/22/2011 02:26 AM, Chunyan Liu wrote: Add code to support logging xen-domU console, as what xenconsoled does. Log info will be saved in /var/log/xen/console/guest-domUname.log. It needs to be specified by command line.

Re: [Qemu-devel] qemu: hardware error: Failed to create USB device 'usb-tablet'

2011-06-30 Thread d...@ucore.info
On Wed, Jun 29, 2011 at 7:25 PM, Peter Maydell peter.mayd...@linaro.org wrote: Unfortunately there isn't a QEMU model of the ISP1761 USB controller which the Versatile Express uses, so that machine model doesn't have USB support. (versatilepb gets USB support via its PCI bus, but there is no

Re: [Qemu-devel] [PATCHv3] qxl: move to UNDEFINED on DESTROY_ALL_SURFACES{, _ASYNC}

2011-06-30 Thread Gerd Hoffmann
Hi, Maybe add a pending async flag to catch such occasions? Yes, good idea. cheers, Gerd

Re: [Qemu-devel] [PATCH V3] Support logging xen-guest console

2011-06-30 Thread Alexander Graf
On 30.06.2011, at 09:08, Chunyan Liu wrote: Add code to support logging xen-domU console, as what xenconsoled does. To enable logging, set environment variable XENCONSOLED_TRACE=guest and XENCONSOLED_LOGDIR=specified directory, log file will be saved in specified directory. So far, qemu

Re: [Qemu-devel] qemu: hardware error: Failed to create USB device 'usb-tablet'

2011-06-30 Thread Peter Maydell
On 30 June 2011 08:20, d...@ucore.info d...@ucore.info wrote: On Wed, Jun 29, 2011 at 7:25 PM, Peter Maydell peter.mayd...@linaro.org wrote: Unfortunately there isn't a QEMU model of the ISP1761 USB controller which the Versatile Express uses, so that machine model doesn't have USB support.

Re: [Qemu-devel] qemu: hardware error: Failed to create USB device 'usb-tablet'

2011-06-30 Thread Alexander Graf
On 30.06.2011, at 09:20, d...@ucore.info wrote: On Wed, Jun 29, 2011 at 7:25 PM, Peter Maydell peter.mayd...@linaro.org wrote: Unfortunately there isn't a QEMU model of the ISP1761 USB controller which the Versatile Express uses, so that machine model doesn't have USB support. (versatilepb

Re: [Qemu-devel] [PATCH v2] block/raw-posix: Linux compat-ioctl warning workaround

2011-06-30 Thread Kevin Wolf
Am 29.06.2011 16:25, schrieb Johannes Stezenbach: On Linux x86_64 host with 32bit userspace, running qemu or even just qemu-img create -f qcow2 some.img 1G causes a kernel warning: ioctl32(qemu-img:5296): Unknown cmd fd(3) cmd(5326){t:'S';sz:0} arg(7fff) on some.img

Re: [Qemu-devel] [PATCH V3] Support logging xen-guest console

2011-06-30 Thread Alexander Graf
On 30.06.2011, at 09:08, Chunyan Liu wrote: Add code to support logging xen-domU console, as what xenconsoled does. To enable logging, set environment variable XENCONSOLED_TRACE=guest and XENCONSOLED_LOGDIR=specified directory, log file will be saved in specified directory. In fact, this

Re: [Qemu-devel] [PATCH] Add e500 instructions dcblc, dcbtls and dcbtstl as no-op

2011-06-30 Thread Fabien Chouteau
On 28/06/2011 18:20, Scott Wood wrote: On Tue, 28 Jun 2011 10:17:39 +0200 Fabien Chouteau chout...@adacore.com wrote: On 27/06/2011 18:28, Scott Wood wrote: On Mon, 27 Jun 2011 15:15:55 +0200 Fabien Chouteau chout...@adacore.com wrote: +/* dcbtls */ +static void gen_dcbtls(DisasContext

Re: [Qemu-devel] Về: Qemu performance

2011-06-30 Thread Alexander Graf
On 30.06.2011, at 04:11, Lê Đức Tài letai_d...@yahoo.com.vn wrote: Thank for your answer. Beside nbench, I'm also using Dhrystone to measure the guest cpu performance. The performance does not much diffetence too. Is the emulated guest performance not depend on guest processor clock?

Re: [Qemu-devel] Questions on DeviceState and Virtio infrastructure

2011-06-30 Thread Alexander Graf
On 29.06.2011, at 15:59, Wei Liu l...@liuw.name wrote: Hi, QEMU folks I know that I might have a bad title for this post, but I just don't have better idea for the title. I'm developing virtio support for Xen pv guest, hoping to reuse the virtio infrastructure in qemu, i.e. I'm planning

Re: [Qemu-devel] qemu: hardware error: Failed to create USB device 'usb-tablet'

2011-06-30 Thread d...@ucore.info
On Thu, Jun 30, 2011 at 9:56 AM, Peter Maydell peter.mayd...@linaro.org wrote: You're probably thinking of the USB support in the OMAP3 beagle/overo models in qemu-linaro: different chip. I don't have any plans for vexpress USB support, I'm afraid. (We only have limited resources for qemu

Re: [Qemu-devel] [PATCH] Make SLIRP Ethernet packets size to 64 bytes minimuma

2011-06-30 Thread Fabien Chouteau
On 28/06/2011 15:15, Stefan Hajnoczi wrote: On Tue, Jun 28, 2011 at 10:08 AM, Fabien Chouteau chout...@adacore.com wrote: On 28/06/2011 10:34, Stefan Hajnoczi wrote: This patch doesn't hurt but we'd be just as well off without it. Did you do this to fix a bug? If so, then something else in

Re: [Qemu-devel] qemu: hardware error: Failed to create USB device 'usb-tablet'

2011-06-30 Thread d...@ucore.info
On Thu, Jun 30, 2011 at 10:01 AM, Alexander Graf ag...@suse.de wrote: For relative pointing devices, the guest does something called mouse acceleration where it tries to find out how quickly you're moving the mouse and set the pointer accordingly. Hence the coordinates the guest window

Re: [Qemu-devel] Questions on DeviceState and Virtio infrastructure

2011-06-30 Thread Wei Liu
On Thu, Jun 30, 2011 at 4:31 PM, Alexander Graf ag...@suse.de wrote: On 29.06.2011, at 15:59, Wei Liu l...@liuw.name wrote: Hi, QEMU folks I know that I might have a bad title for this post, but I just don't have better idea for the title. I'm developing virtio support for Xen pv guest,

Re: [Qemu-devel] [PULL 0/8] ARM patch queue

2011-06-30 Thread Peter Maydell
Ping? thanks -- PMM On 22 June 2011 18:33, Peter Maydell peter.mayd...@linaro.org wrote: This is a pull request for various ARM related patches which have been on the list for a while (mostly but not entirely mine). The performance counters patch had quite a bit of discussion when

Re: [Qemu-devel] [PATCH V3] Support logging xen-guest console

2011-06-30 Thread Chun Yan Liu
On Thursday, June 30, 2011 03:58:57 PM Alexander Graf wrote: On 30.06.2011, at 09:08, Chunyan Liu wrote: Add code to support logging xen-domU console, as what xenconsoled does. To enable logging, set environment variable XENCONSOLED_TRACE=guest and XENCONSOLED_LOGDIR=specified directory,

Re: [Qemu-devel] [PATCH resend] vl.c: Don't limit node count by smp count

2011-06-30 Thread Andre Przywara
On 06/30/2011 05:29 AM, Sasha Levin wrote: [I've sent this patch couple of months ago and noticed it didn't make it's way in - so I'm sending it again] It is possible to create CPU-less NUMA nodes, node amount shouldn't be limited by amount of CPUs. Tested-by: Michael

Re: [Qemu-devel] Questions on DeviceState and Virtio infrastructure

2011-06-30 Thread Stefano Stabellini
On Thu, 30 Jun 2011, Wei Liu wrote: On Thu, Jun 30, 2011 at 4:31 PM, Alexander Graf ag...@suse.de wrote: On 29.06.2011, at 15:59, Wei Liu l...@liuw.name wrote: Hi, QEMU folks I know that I might have a bad title for this post, but I just don't have better idea for the title. I'm

Re: [Qemu-devel] [PATCH 2/2] qxl: add QXL_IO_UPDATE_MEM for guest S3S4 support

2011-06-30 Thread Yonit Halperin
On 06/29/2011 02:38 PM, Alon Levy wrote: On Wed, Jun 29, 2011 at 12:25:00PM +0200, Gerd Hoffmann wrote: On 06/29/11 11:21, Alon Levy wrote: On Wed, Jun 29, 2011 at 11:01:11AM +0200, Gerd Hoffmann wrote: Hi, I think it will receive them after migration, since the command ring was stored.

Re: [Qemu-devel] [PATCH 2/2] qxl: add QXL_IO_UPDATE_MEM for guest S3S4 support

2011-06-30 Thread Gerd Hoffmann
Hi, Right - the whole ring assumes that the same side removes. of course we can add an IO for that (two - FREEZE and UNFREEZE). But I think this is the wrong approach. Instead, rendering all the commands, and dropping the wait for the client. Right now if we flush we do actually wait for the

Re: [Qemu-devel] [PATCH 10/11] usb-uhci: Add support for being a companion controller

2011-06-30 Thread Hans de Goede
Hi, On 06/29/2011 02:29 PM, Gerd Hoffmann wrote: Hi, I agree, but there is a reason why I went with a usb_bus_register_companion function instead of with a usb_bus_register_companion_port function, the uhci controller needs to know how many companion controllers it has (to report this in one

Re: [Qemu-devel] Questions on DeviceState and Virtio infrastructure

2011-06-30 Thread Alexander Graf
On 06/30/2011 12:21 PM, Stefano Stabellini wrote: On Thu, 30 Jun 2011, Wei Liu wrote: On Thu, Jun 30, 2011 at 4:31 PM, Alexander Grafag...@suse.de wrote: On 29.06.2011, at 15:59, Wei Liul...@liuw.name wrote: Hi, QEMU folks I know that I might have a bad title for this post, but I just

Re: [Qemu-devel] [PATCH V3] Support logging xen-guest console

2011-06-30 Thread Alexander Graf
On 06/30/2011 11:39 AM, Chun Yan Liu wrote: On Thursday, June 30, 2011 03:58:57 PM Alexander Graf wrote: On 30.06.2011, at 09:08, Chunyan Liu wrote: Add code to support logging xen-domU console, as what xenconsoled does. To enable logging, set environment variable XENCONSOLED_TRACE=guest and

Re: [Qemu-devel] [PATCH] hw/piix_pci.c: Fix PIIX3-xen to initialize ids

2011-06-30 Thread Alexander Graf
On 06/22/2011 05:58 PM, anthony.per...@citrix.com wrote: From: Anthony PERARDanthony.per...@citrix.com Signed-off-by: Anthony PERARDanthony.per...@citrix.com --- hw/piix_pci.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/piix_pci.c b/hw/piix_pci.c index

Re: [Qemu-devel] [PATCH 2/2] qxl: add QXL_IO_UPDATE_MEM for guest S3S4 support

2011-06-30 Thread Alon Levy
On Thu, Jun 30, 2011 at 12:46:59PM +0200, Gerd Hoffmann wrote: Hi, Right - the whole ring assumes that the same side removes. of course we can add an IO for that (two - FREEZE and UNFREEZE). But I think this is the wrong approach. Instead, rendering all the commands, and dropping the wait

Re: [Qemu-devel] [PATCH v3] xen: implement unplug protocol in xen_platform

2011-06-30 Thread Alexander Graf
On 06/28/2011 01:29 PM, stefano.stabell...@eu.citrix.com wrote: From: Stefano Stabellinistefano.stabell...@eu.citrix.com The unplug protocol is necessary to support PV drivers in the guest: the drivers expect to be able to unplug emulated disks and nics before initializing the Xen PV

Re: [Qemu-devel] [PATCH] xen_disk: treat aio as raw

2011-06-30 Thread Alexander Graf
On 06/24/2011 04:50 PM, stefano.stabell...@eu.citrix.com wrote: From: Stefano Stabellinistefano.stabell...@eu.citrix.com Sometimes the toolstack uses aio without an additional format identifier, in such cases use raw. Shouldn't this rather be a patch to the toolstack then? We do automatic

Re: [Qemu-devel] KVM call agenda for June 28

2011-06-30 Thread Stefan Hajnoczi
On Wed, Jun 29, 2011 at 4:41 PM, Marcelo Tosatti mtosa...@redhat.com wrote: On Wed, Jun 29, 2011 at 11:08:23AM +0100, Stefan Hajnoczi wrote: In the future we could add a 'base' argument to block_stream.  If base is specified then data contained in the base image will not be copied. This is a

Re: [Qemu-devel] [PATCH v3] xen: implement unplug protocol in xen_platform

2011-06-30 Thread Kevin Wolf
Am 28.06.2011 13:29, schrieb stefano.stabell...@eu.citrix.com: From: Stefano Stabellini stefano.stabell...@eu.citrix.com The unplug protocol is necessary to support PV drivers in the guest: the drivers expect to be able to unplug emulated disks and nics before initializing the Xen PV

Re: [Qemu-devel] [PATCH] xen: introduce xen_change_state_handler

2011-06-30 Thread Alexander Graf
On 06/29/2011 01:16 PM, stefano.stabell...@eu.citrix.com wrote: From: Anthony PERARDanthony.per...@citrix.com Remove the call to xenstore_record_dm_state from xen_main_loop_prepare that is HVM specific. Add a new vm_change_state_handler shared between xen_pv and xen_hvm machines to record the

Re: [Qemu-devel] [PATCH v3] xen: implement unplug protocol in xen_platform

2011-06-30 Thread Kevin Wolf
Am 30.06.2011 13:45, schrieb Alexander Graf: On 06/28/2011 01:29 PM, stefano.stabell...@eu.citrix.com wrote: From: Stefano Stabellinistefano.stabell...@eu.citrix.com The unplug protocol is necessary to support PV drivers in the guest: the drivers expect to be able to unplug emulated disks and

Re: [Qemu-devel] [PATCH 2/2] qxl: add QXL_IO_UPDATE_MEM for guest S3S4 support

2011-06-30 Thread Gerd Hoffmann
Hi, My thoughts exactly. Any reason to support the old non async messages if we do this? Yes. Backward compatibility. The only difference with this approach is that we will have to do the reads from the io thread of qemu, Hmm? Which reads? I'd add a completion callback to

Re: [Qemu-devel] [PATCH v3] xen: implement unplug protocol in xen_platform

2011-06-30 Thread Alexander Graf
On 06/30/2011 02:16 PM, Kevin Wolf wrote: Am 30.06.2011 13:45, schrieb Alexander Graf: On 06/28/2011 01:29 PM, stefano.stabell...@eu.citrix.com wrote: From: Stefano Stabellinistefano.stabell...@eu.citrix.com The unplug protocol is necessary to support PV drivers in the guest: the drivers

Re: [Qemu-devel] [PATCH v3] xen_console: support the new extended xenstore protocol

2011-06-30 Thread Alexander Graf
On 06/29/2011 01:12 PM, stefano.stabell...@eu.citrix.com wrote: From: Stefano Stabellinistefano.stabell...@eu.citrix.com Since CS 21994 on xen-unstable.hg and CS 466608f3a32e1f9808acdf832a5843af37e5fcec on qemu-xen-unstable.git, few changes have been introduced to the PV console xenstore

[Qemu-devel] Setting up PPC440 Virtex Image for Qemu

2011-06-30 Thread Suzuki Poulose
Hi, I am working on enabling the KEXEC on PPC440 chipsets. To debug my patches, I would like to use the Qemu. The only available PPC440 support in Qemu is for the ppc-virtex. (Thanks for adding the support). I was trying to use the default image provided at

Re: [Qemu-devel] KVM call agenda for June 28

2011-06-30 Thread Kevin Wolf
Am 30.06.2011 13:48, schrieb Stefan Hajnoczi: On Wed, Jun 29, 2011 at 4:41 PM, Marcelo Tosatti mtosa...@redhat.com wrote: On Wed, Jun 29, 2011 at 11:08:23AM +0100, Stefan Hajnoczi wrote: In the future we could add a 'base' argument to block_stream. If base is specified then data contained in

[Qemu-devel] [PATCH] checkpatch: don't error out on },{ lines

2011-06-30 Thread Alexander Graf
When having code like this: static PCIDeviceInfo piix_ide_info[] = { { .qdev.name= piix3-ide, .qdev.size= sizeof(PCIIDEState), .qdev.no_user = 1, .no_hotplug = 1, .init = pci_piix_ide_initfn,

Re: [Qemu-devel] KVM call agenda for June 28

2011-06-30 Thread Stefan Hajnoczi
On Wed, Jun 29, 2011 at 4:41 PM, Marcelo Tosatti mtosa...@redhat.com wrote: On Wed, Jun 29, 2011 at 11:08:23AM +0100, Stefan Hajnoczi wrote:  This can be used to merge data from an intermediate image without merging the base image.  When streaming completes the backing file will be set to the

Re: [Qemu-devel] Setting up PPC440 Virtex Image for Qemu

2011-06-30 Thread Edgar E. Iglesias
On Thu, Jun 30, 2011 at 05:45:23PM +0530, Suzuki Poulose wrote: Hi, I am working on enabling the KEXEC on PPC440 chipsets. To debug my patches, I would like to use the Qemu. The only available PPC440 support in Qemu is for the ppc-virtex. (Thanks for adding the support). I was trying to

Re: [Qemu-devel] Setting up PPC440 Virtex Image for Qemu

2011-06-30 Thread Suzuki Poulose
On 06/30/11 18:02, Edgar E. Iglesias wrote: On Thu, Jun 30, 2011 at 05:45:23PM +0530, Suzuki Poulose wrote: Hi, I am working on enabling the KEXEC on PPC440 chipsets. To debug my patches, I would like to use the Qemu. The only available PPC440 support in Qemu is for the ppc-virtex. (Thanks for

Re: [Qemu-devel] Setting up PPC440 Virtex Image for Qemu

2011-06-30 Thread Edgar E. Iglesias
On Thu, Jun 30, 2011 at 06:30:04PM +0530, Suzuki Poulose wrote: On 06/30/11 18:02, Edgar E. Iglesias wrote: On Thu, Jun 30, 2011 at 05:45:23PM +0530, Suzuki Poulose wrote: Hi, I am working on enabling the KEXEC on PPC440 chipsets. To debug my patches, I would like to use the Qemu. The

Re: [Qemu-devel] [PATCH 2/2] qxl: add QXL_IO_UPDATE_MEM for guest S3S4 support

2011-06-30 Thread Alon Levy
On Thu, Jun 30, 2011 at 02:12:52PM +0200, Gerd Hoffmann wrote: Hi, My thoughts exactly. Any reason to support the old non async messages if we do this? Yes. Backward compatibility. So at least deprecate it to be dropped later? I don't like that the code just gets bigger and bigger.

Re: [Qemu-devel] [PATCH] xen_disk: treat aio as raw

2011-06-30 Thread Kevin Wolf
Am 30.06.2011 13:47, schrieb Alexander Graf: On 06/24/2011 04:50 PM, stefano.stabell...@eu.citrix.com wrote: From: Stefano Stabellinistefano.stabell...@eu.citrix.com Sometimes the toolstack uses aio without an additional format identifier, in such cases use raw. Shouldn't this rather be a

Re: [Qemu-devel] [PATCH] checkpatch: don't error out on },{ lines

2011-06-30 Thread Stefan Hajnoczi
On Wed, Jun 29, 2011 at 7:09 AM, Alexander Graf ag...@suse.de wrote: When having code like this:    static PCIDeviceInfo piix_ide_info[] = {        {            .qdev.name    = piix3-ide,            .qdev.size    = sizeof(PCIIDEState),            .qdev.no_user = 1,            .no_hotplug  

Re: [Qemu-devel] [PATCH] xen_disk: treat aio as raw

2011-06-30 Thread Alexander Graf
On 06/30/2011 02:47 PM, Kevin Wolf wrote: Am 30.06.2011 13:47, schrieb Alexander Graf: On 06/24/2011 04:50 PM, stefano.stabell...@eu.citrix.com wrote: From: Stefano Stabellinistefano.stabell...@eu.citrix.com Sometimes the toolstack uses aio without an additional format identifier, in such

Re: [Qemu-devel] [PATCH 2/2] qxl: add QXL_IO_UPDATE_MEM for guest S3S4 support

2011-06-30 Thread Gerd Hoffmann
Hi, Yes. Backward compatibility. So at least deprecate it to be dropped later? I don't like that the code just gets bigger and bigger. Deprecate them is fine. I was thinking of a different solution - one in which the same READY messages are written, but read from a different place.

Re: [Qemu-devel] Questions on DeviceState and Virtio infrastructure

2011-06-30 Thread Stefano Stabellini
On Thu, 30 Jun 2011, Alexander Graf wrote: On 06/30/2011 12:21 PM, Stefano Stabellini wrote: On Thu, 30 Jun 2011, Wei Liu wrote: On Thu, Jun 30, 2011 at 4:31 PM, Alexander Grafag...@suse.de wrote: On 29.06.2011, at 15:59, Wei Liul...@liuw.name wrote: Hi, QEMU folks I know that I

Re: [Qemu-devel] KVM call agenda for June 28

2011-06-30 Thread Anthony Liguori
On 06/28/2011 08:48 AM, Avi Kivity wrote: On 06/28/2011 04:43 PM, Anthony Liguori wrote: FYI, I'm in an all-day meeting so I can't attend. Did you do something really bad? I named some variables with a leading underscore and now have to be re-educated. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH v3] xen: implement unplug protocol in xen_platform

2011-06-30 Thread Stefano Stabellini
On Thu, 30 Jun 2011, Kevin Wolf wrote: +static int pci_piix3_xen_ide_unplug(DeviceState *dev) +{ +PCIDevice *pci_dev; +PCIIDEState *pci_ide; +DriveInfo *di; +int i = 0; + +pci_dev = DO_UPCAST(PCIDevice, qdev, dev); +pci_ide = DO_UPCAST(PCIIDEState, dev,

Re: [Qemu-devel] [PATCH v3] xen_console: support the new extended xenstore protocol

2011-06-30 Thread Stefano Stabellini
On Thu, 30 Jun 2011, Alexander Graf wrote: On 06/29/2011 01:12 PM, stefano.stabell...@eu.citrix.com wrote: From: Stefano Stabellinistefano.stabell...@eu.citrix.com Since CS 21994 on xen-unstable.hg and CS 466608f3a32e1f9808acdf832a5843af37e5fcec on qemu-xen-unstable.git, few changes

Re: [Qemu-devel] [PATCH] xen_disk: treat aio as raw

2011-06-30 Thread Stefano Stabellini
On Thu, 30 Jun 2011, Alexander Graf wrote: On 06/30/2011 02:47 PM, Kevin Wolf wrote: Am 30.06.2011 13:47, schrieb Alexander Graf: On 06/24/2011 04:50 PM, stefano.stabell...@eu.citrix.com wrote: From: Stefano Stabellinistefano.stabell...@eu.citrix.com Sometimes the toolstack uses aio

Re: [Qemu-devel] [PATCH] xen: introduce xen_change_state_handler

2011-06-30 Thread Alexander Graf
On 06/30/2011 04:37 PM, Stefano Stabellini wrote: On Thu, 30 Jun 2011, Alexander Graf wrote: On 06/29/2011 01:16 PM, stefano.stabell...@eu.citrix.com wrote: From: Anthony PERARDanthony.per...@citrix.com Remove the call to xenstore_record_dm_state from xen_main_loop_prepare that is HVM

Re: [Qemu-devel] [PATCH v3] xen_console: support the new extended xenstore protocol

2011-06-30 Thread Alexander Graf
On 06/29/2011 01:12 PM, stefano.stabell...@eu.citrix.com wrote: From: Stefano Stabellinistefano.stabell...@eu.citrix.com Since CS 21994 on xen-unstable.hg and CS 466608f3a32e1f9808acdf832a5843af37e5fcec on qemu-xen-unstable.git, few changes have been introduced to the PV console xenstore

Re: [Qemu-devel] [PATCH] xen_disk: treat aio as raw

2011-06-30 Thread Alexander Graf
On 06/30/2011 04:20 PM, Stefano Stabellini wrote: On Thu, 30 Jun 2011, Alexander Graf wrote: On 06/30/2011 02:47 PM, Kevin Wolf wrote: Am 30.06.2011 13:47, schrieb Alexander Graf: On 06/24/2011 04:50 PM, stefano.stabell...@eu.citrix.com wrote: From: Stefano

Re: [Qemu-devel] KVM call agenda for June 28

2011-06-30 Thread Marcelo Tosatti
On Thu, Jun 30, 2011 at 01:54:09PM +0100, Stefan Hajnoczi wrote: On Wed, Jun 29, 2011 at 4:41 PM, Marcelo Tosatti mtosa...@redhat.com wrote: On Wed, Jun 29, 2011 at 11:08:23AM +0100, Stefan Hajnoczi wrote:  This can be used to merge data from an intermediate image without merging the base

Re: [Qemu-devel] Questions on DeviceState and Virtio infrastructure

2011-06-30 Thread Alexander Graf
On 06/30/2011 04:11 PM, Stefano Stabellini wrote: On Thu, 30 Jun 2011, Alexander Graf wrote: On 06/30/2011 12:21 PM, Stefano Stabellini wrote: On Thu, 30 Jun 2011, Wei Liu wrote: On Thu, Jun 30, 2011 at 4:31 PM, Alexander Grafag...@suse.de wrote: On 29.06.2011, at 15:59, Wei

Re: [Qemu-devel] [PATCH v2 0/3] Xen cleanups

2011-06-30 Thread Alexander Graf
On 06/21/2011 10:59 PM, Jan Kiszka wrote: Changes to v1: - rebase over xen-next which includes - dropping of xen_unmap_block uninlining (as it's gone) Thanks, applied to the xen-next branch. PS: Alex, there must be some patch(es) with style issues in your queue. Please avoid accepting

Re: [Qemu-devel] [PATCH] xen: introduce xen_change_state_handler

2011-06-30 Thread Stefano Stabellini
On Thu, 30 Jun 2011, Alexander Graf wrote: On 06/29/2011 01:16 PM, stefano.stabell...@eu.citrix.com wrote: From: Anthony PERARDanthony.per...@citrix.com Remove the call to xenstore_record_dm_state from xen_main_loop_prepare that is HVM specific. Add a new vm_change_state_handler shared

Re: [Qemu-devel] [PATCH v2] qemu_ram_ptr_length: take ram_addr_t as arguments

2011-06-30 Thread Alexander Graf
On 06/27/2011 07:26 PM, stefano.stabell...@eu.citrix.com wrote: From: Stefano Stabellinistefano.stabell...@eu.citrix.com qemu_ram_ptr_length should take ram_addr_t as argument rather than target_phys_addr_t because is doing comparisons with RAMBlock addresses. cpu_physical_memory_map should

Re: [Qemu-devel] [PATCH] xen_disk: treat aio as raw

2011-06-30 Thread Stefano Stabellini
On Thu, 30 Jun 2011, Alexander Graf wrote: On 06/30/2011 04:20 PM, Stefano Stabellini wrote: On Thu, 30 Jun 2011, Alexander Graf wrote: On 06/30/2011 02:47 PM, Kevin Wolf wrote: Am 30.06.2011 13:47, schrieb Alexander Graf: On 06/24/2011 04:50 PM, stefano.stabell...@eu.citrix.com wrote:

[Qemu-devel] [PATCH v2] xen_disk: treat aio as raw

2011-06-30 Thread stefano.stabellini
From: Stefano Stabellini stefano.stabell...@eu.citrix.com Sometimes the toolstack uses aio without an additional format identifier, in such cases use raw. Updated in v2: - fix code style. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com --- hw/xen_disk.c |3 +++ 1 files

Re: [Qemu-devel] [PATCH v2 2/2] xen: add vkbd support for PV on HVM guests

2011-06-30 Thread Alexander Graf
On 06/24/2011 06:36 PM, stefano.stabell...@eu.citrix.com wrote: From: Stefano Stabellinistefano.stabell...@eu.citrix.com Register the vkbd backend even when running as device emulator for HVM guests: it is useful because it doesn't need a frequent timer like usb. Check whether the XenInput

Re: [Qemu-devel] [PATCH 1/2] xen: enable console and disk backend in HVM mode

2011-06-30 Thread Alexander Graf
On 06/24/2011 04:54 PM, stefano.stabell...@eu.citrix.com wrote: From: Stefano Stabellinistefano.stabell...@eu.citrix.com Initialize the Xen console backend and the Xen disk backend even when running in HVM mode so that PV on HVM drivers can connect to them. Thanks, applied to xen-next branch.

Re: [Qemu-devel] [PATCH v3] xen_disk: cope with missing xenstore params node

2011-06-30 Thread Alexander Graf
On 06/27/2011 05:10 PM, stefano.stabell...@eu.citrix.com wrote: From: Stefano Stabellinistefano.stabell...@eu.citrix.com When disk is a cdrom and the drive is empty the params node in xenstore might be missing completely: cope with it instead of segfaulting. Updated in v2: - actually removed

Re: [Qemu-devel] [PATCH] xen: introduce xen_change_state_handler

2011-06-30 Thread Alexander Graf
On 06/29/2011 01:16 PM, stefano.stabell...@eu.citrix.com wrote: From: Anthony PERARDanthony.per...@citrix.com Remove the call to xenstore_record_dm_state from xen_main_loop_prepare that is HVM specific. Add a new vm_change_state_handler shared between xen_pv and xen_hvm machines to record the

[Qemu-devel] [RFC PATCH 2/4] add pc-0.14 machine

2011-06-30 Thread Paolo Bonzini
The new pc-0.15 machine will have a different migration format, so define the compatibility one right now. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/pc_piix.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/hw/pc_piix.c b/hw/pc_piix.c index

Re: [Qemu-devel] [Qemu-trivial] [PATCH] fix MinGW compilation when --enable-vnc-jpeg is specified

2011-06-30 Thread Paolo Bonzini
On 06/27/2011 07:22 PM, Stefan Weil wrote: Am 27.06.2011 07:56, schrieb Roy Tam: 2011/6/27 Stefan Weilw...@mail.berlios.de: Am 27.06.2011 04:37, schrieb TeLeMan: This patch breaks the compilation with --enable-vnc-png: CC ui/vnc-enc-tight.o In file included from /usr/include/png.h:518,

[Qemu-devel] [RFC PATCH 4/4] Partially revert savevm: fix corruption in vmstate_subsection_load().

2011-06-30 Thread Paolo Bonzini
This reverts the additional check in commit eb60260d (but not the assertions). The new format does not require the check, and with the old format it traded one kind of bogus failure for a different kind of silent failure. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- savevm.c |4

Re: [Qemu-devel] KVM call agenda for June 28

2011-06-30 Thread Kevin Wolf
Am 30.06.2011 16:36, schrieb Marcelo Tosatti: 4. Live block copy API and high-level control - the main code that adds the live block copy feature. Existing patches by Marcelo, can be restructured to use common core by Marcelo. Can use your proposed block_stream interface, with a

[Qemu-devel] [RFC PATCH 0/4] Fix subsection ambiguity in the migration format

2011-06-30 Thread Paolo Bonzini
With the current migration format, VMS_STRUCTs with subsections are ambiguous. The protocol cannot tell whether a 0x5 byte after the VMS_STRUCT is a subsection or part of the parent data stream. In the past QEMU assumed it was always a part of a subsection; after commit eb60260 (savevm: fix

[Qemu-devel] [PATCH V2] hw/piix_pci.c: Fix PIIX3-xen to initialize ids

2011-06-30 Thread Anthony PERARD
Signed-off-by: Anthony PERARD anthony.per...@citrix.com --- hw/piix_pci.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/piix_pci.c b/hw/piix_pci.c index 26ce904..71528f4 100644 --- a/hw/piix_pci.c +++ b/hw/piix_pci.c @@ -478,6 +478,9 @@ static PCIDeviceInfo

[Qemu-devel] [RFC PATCH 1/4] add support for machine models to specify their migration format

2011-06-30 Thread Paolo Bonzini
We need to provide a new migration format, and not break migration in old machine models. So add a migration_format field to QEMUMachine. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- cpu-common.h |3 --- hw/boards.h |1 + qemu-common.h |3 +++ savevm.c |7 +--

[Qemu-devel] [RFC PATCH 3/4] savevm: define new unambiguous migration format

2011-06-30 Thread Paolo Bonzini
With the current migration format, VMS_STRUCTs with subsections are ambiguous. The protocol cannot tell whether a 0x5 byte after the VMS_STRUCT is a subsection or part of the parent data stream. In the past QEMU assumed it was always a part of a subsection; after commit eb60260 (savevm: fix

Re: [Qemu-devel] [PATCH] [PowerPC][RFC] booke timers

2011-06-30 Thread Fabien Chouteau
On 28/06/2011 19:49, Scott Wood wrote: On Tue, 28 Jun 2011 15:35:00 +0200 Fabien Chouteau chout...@adacore.com wrote: On 27/06/2011 22:28, Scott Wood wrote: On Mon, 27 Jun 2011 18:14:06 +0200 Fabien Chouteau chout...@adacore.com wrote: While working on the emulation of the freescale p2010

[Qemu-devel] [PATCHv2] Add compat eventfd header

2011-06-30 Thread Michael S. Tsirkin
Support build on rhel 5.X where we have syscall for eventfd but not userspace wrapper. (cherry-picked from commit 9e3269181e9bc56feb43bcd4e8ce0b82cd543e65 in qemu-kvm.git). Signed-off-by: Michael S. Tsirkin m...@redhat.com --- Changes from v1: checkpatch fix address comments by agraf

Re: [Qemu-devel] [PATCHv2] Add compat eventfd header

2011-06-30 Thread Paolo Bonzini
On 06/30/2011 05:57 PM, Michael S. Tsirkin wrote: Support build on rhel 5.X where we have syscall for eventfd but not userspace wrapper. (cherry-picked from commit 9e3269181e9bc56feb43bcd4e8ce0b82cd543e65 in qemu-kvm.git). Signed-off-by: Michael S. Tsirkinm...@redhat.com --- Changes from

Re: [Qemu-devel] [PATCH v3] xen_console: support the new extended xenstore protocol

2011-06-30 Thread Stefano Stabellini
On Thu, 30 Jun 2011, Alexander Graf wrote: On 06/29/2011 01:12 PM, stefano.stabell...@eu.citrix.com wrote: From: Stefano Stabellinistefano.stabell...@eu.citrix.com Since CS 21994 on xen-unstable.hg and CS 466608f3a32e1f9808acdf832a5843af37e5fcec on qemu-xen-unstable.git, few changes

Re: [Qemu-devel] [PATCH] Add e500 instructions dcblc, dcbtls and dcbtstl as no-op

2011-06-30 Thread Scott Wood
On Thu, 30 Jun 2011 10:25:31 +0200 Fabien Chouteau chout...@adacore.com wrote: On 28/06/2011 18:20, Scott Wood wrote: On Tue, 28 Jun 2011 10:17:39 +0200 Fabien Chouteau chout...@adacore.com wrote: Why do you want to set this bit? Can't we consider that the instruction is always

Re: [Qemu-devel] [RFC PATCH 1/4] add support for machine models to specify their migration format

2011-06-30 Thread Michael S. Tsirkin
On Thu, Jun 30, 2011 at 05:46:14PM +0200, Paolo Bonzini wrote: We need to provide a new migration format, and not break migration in old machine models. So add a migration_format field to QEMUMachine. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Should not machine describe guest

[Qemu-devel] device assignment for embedded Power

2011-06-30 Thread Yoder Stuart-B08248
One feature we need for QEMU/KVM on embedded Power Architecture is the ability to do passthru assignment of SoC I/O devices and memory. An important use case in embedded is creating static partitions-- taking physical memory and I/O devices (non-PCI) and partitioning them between the host

[Qemu-devel] [PATCH v4] xen_console: support the new extended xenstore protocol

2011-06-30 Thread stefano.stabellini
From: Stefano Stabellini stefano.stabell...@eu.citrix.com Since CS 21994 on xen-unstable.hg and CS 466608f3a32e1f9808acdf832a5843af37e5fcec on qemu-xen-unstable.git, few changes have been introduced to the PV console xenstore protocol, as described by the document docs/misc/console.txt under

[Qemu-devel] cpu-exec.c: avoid AREG0 use breaks x86 emulation on x86-64

2011-06-30 Thread Jan Kiszka
Hi Blue, commit cea5f9a28f breaks here, just starting qemu without any parameters: Starting program: qemu-system-x86_64 [Thread debugging using libthread_db enabled] Program received signal SIGSEGV, Segmentation fault. 0x739ac770 in __sigsetjmp () from /lib64/libc.so.6 (gdb) bt #0

[Qemu-devel] [PATCH 0/3]: block: Small drive_init() improvements

2011-06-30 Thread Luiz Capitulino
Please, see individual patches for details. blockdev.c | 65 --- 1 files changed, 31 insertions(+), 34 deletions(-)

[Qemu-devel] [PATCH v5] xen_console: support the new extended xenstore protocol

2011-06-30 Thread stefano.stabellini
From: Stefano Stabellini stefano.stabell...@eu.citrix.com Since CS 21994 on xen-unstable.hg and CS 466608f3a32e1f9808acdf832a5843af37e5fcec on qemu-xen-unstable.git, few changes have been introduced to the PV console xenstore protocol, as described by the document docs/misc/console.txt under

[Qemu-devel] [PATCH 2/3] block: drive_init(): Simplify interface type setting

2011-06-30 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- blockdev.c | 11 --- 1 files changed, 4 insertions(+), 7 deletions(-) diff --git a/blockdev.c b/blockdev.c index 27bf68a..0a90ae8 100644 --- a/blockdev.c +++ b/blockdev.c @@ -241,13 +241,6 @@ DriveInfo *drive_init(QemuOpts

Re: [Qemu-devel] KVM call agenda for June 28

2011-06-30 Thread Marcelo Tosatti
On Thu, Jun 30, 2011 at 04:52:00PM +0200, Kevin Wolf wrote: Am 30.06.2011 16:36, schrieb Marcelo Tosatti: 4. Live block copy API and high-level control - the main code that adds the live block copy feature. Existing patches by Marcelo, can be restructured to use common core by Marcelo.

Re: [Qemu-devel] [PATCHv2] Add compat eventfd header

2011-06-30 Thread Peter Maydell
On 30 June 2011 16:57, Michael S. Tsirkin m...@redhat.com wrote: diff --git a/configure b/configure index 856b41e..6f7dd74 100755 --- a/configure +++ b/configure @@ -822,7 +822,6 @@ esac  [ -z $guest_base ] guest_base=$host_guest_base -  default_target_list=  # these targets are

Re: [Qemu-devel] [PATCH] [PowerPC][RFC] booke timers

2011-06-30 Thread Scott Wood
On Thu, 30 Jun 2011 17:51:10 +0200 Fabien Chouteau chout...@adacore.com wrote: On 28/06/2011 19:49, Scott Wood wrote: On Tue, 28 Jun 2011 15:35:00 +0200 Fabien Chouteau chout...@adacore.com wrote: On 27/06/2011 22:28, Scott Wood wrote: On Mon, 27 Jun 2011 18:14:06 +0200 Fabien

Re: [Qemu-devel] Questions on DeviceState and Virtio infrastructure

2011-06-30 Thread Stefano Stabellini
On Thu, 30 Jun 2011, Alexander Graf wrote: On 06/30/2011 04:11 PM, Stefano Stabellini wrote: On Thu, 30 Jun 2011, Alexander Graf wrote: On 06/30/2011 12:21 PM, Stefano Stabellini wrote: On Thu, 30 Jun 2011, Wei Liu wrote: On Thu, Jun 30, 2011 at 4:31 PM, Alexander Grafag...@suse.de

Re: [Qemu-devel] [PATCHv2] Add compat eventfd header

2011-06-30 Thread Michael S. Tsirkin
On Thu, Jun 30, 2011 at 06:27:13PM +0100, Peter Maydell wrote: On 30 June 2011 16:57, Michael S. Tsirkin m...@redhat.com wrote: diff --git a/configure b/configure index 856b41e..6f7dd74 100755 --- a/configure +++ b/configure @@ -822,7 +822,6 @@ esac  [ -z $guest_base ]

[Qemu-devel] [PATCH 1/3] block: drive_init(): Fix indentation

2011-06-30 Thread Luiz Capitulino
Some constructions in that function have broken indentation. Fix them. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- blockdev.c | 52 ++-- 1 files changed, 26 insertions(+), 26 deletions(-) diff --git a/blockdev.c b/blockdev.c index

[Qemu-devel] [PATCH 3/3] block: drive_init(): Improve CHS setting error message

2011-06-30 Thread Luiz Capitulino
The current media doesn't clearly say the error cause. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- blockdev.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/blockdev.c b/blockdev.c index 0a90ae8..2dbdd1b 100644 --- a/blockdev.c +++ b/blockdev.c @@ -311,7

Re: [Qemu-devel] [PATCH] e1000: Handle IO Port.

2011-06-30 Thread Anthony PERARD
On Mon, Jun 27, 2011 at 19:07, Peter Maydell peter.mayd...@linaro.org wrote: On 27 June 2011 17:34, Anthony PERARD anthony.per...@citrix.com wrote: @@ -83,6 +86,8 @@ typedef struct E1000State_st {     NICState *nic;     NICConf conf;     int mmio_index; +    int ioport_base; +    uint32_t

Re: [Qemu-devel] [PATCH 1/3] block: drive_init(): Fix indentation

2011-06-30 Thread Stefan Weil
Am 30.06.2011 20:33, schrieb Luiz Capitulino: Some constructions in that function have broken indentation. Fix them. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- blockdev.c | 52 ++-- 1 files changed, 26 insertions(+), 26 deletions(-)

[Qemu-devel] [PATCH V2] e1000: Handle IO Port.

2011-06-30 Thread Anthony PERARD
This patch introduces the two IOPorts on e1000, IOADDR and IODATA. The IOADDR is used to specify which register we want to access when we read or write on IODATA. This patch fixes some weird behavior that I see when I use e1000 with QEMU/Xen, the guest memory can be corrupted by this NIC because

Re: [Qemu-devel] [PATCH] e1000: Handle IO Port.

2011-06-30 Thread Anthony PERARD
On Tue, Jun 28, 2011 at 06:49, Paolo Bonzini pbonz...@redhat.com wrote: On 06/27/2011 08:07 PM, Peter Maydell wrote:  +    int ioport_base;  +    uint32_t ioport_reg[2]; I think ioport_reg[] needs to go in the VMStateDescription as well. I don't know enough about the PCI subsystem to know

Re: [Qemu-devel] [PATCH V2] e1000: Handle IO Port.

2011-06-30 Thread Peter Maydell
On 30 June 2011 20:28, Anthony PERARD anthony.per...@citrix.com wrote: @@ -202,6 +201,11 @@ rxbufsize(uint32_t v)  static void  set_ctrl(E1000State *s, int index, uint32_t val)  { +    DBGOUT(IO, set ctrl = %08x\n, val); +    if (val E1000_CTRL_RST) { +        s-mac_reg[CTRL] = val; +    

  1   2   >