Re: [Qemu-devel] buildbot failure in qemu on pci_x86_64_debian_5_0

2011-07-05 Thread Stefan Hajnoczi
On Tue, Jul 5, 2011 at 3:04 AM, q...@buildbot.b1-systems.de wrote: The Buildbot has detected a new failure on builder pci_x86_64_debian_5_0 while building qemu. Full details are available at:  http://buildbot.b1-systems.de/qemu/builders/pci_x86_64_debian_5_0/builds/24 Buildbot URL:

Re: [Qemu-devel] [PATCH 3/3] Avoid Wunsed-but-set warnings (or errors in case of Werror)

2011-07-05 Thread Markus Armbruster
Typo in subject: unsed. The warning is spelled unused-but-set-variable, the option -Wunused-but-set-variable. Raghavendra D Prabhu raghu.prabh...@gmail.com writes: In a few cases, variable attributed 'unused' has been added, in other cases unused variable has been either removed or commented

Re: [Qemu-devel] [PATCH 3/3] Avoid Wunsed-but-set warnings (or errors in case of Werror)

2011-07-05 Thread Peter Maydell
On 5 July 2011 07:15, Markus Armbruster arm...@redhat.com wrote: +    int fd, __attribute__((unused)) ret;      snprintf(reset_file, sizeof(reset_file),               /sys/bus/pci/devices/%04x:%02x:%02x.%01x/reset, What about (void)write() and do away with ret? If 'ret' has been used to

Re: [Qemu-devel] [PATCH 1/2] ide: Ignore reads during PIO in and writes during PIO out

2011-07-05 Thread Markus Armbruster
I got confused by PIO out until it dawned on me that it's from the device's point of view, i.e. out means device - cpu, not the CPU's out instruction. Both patches Reviewed-by: Markus Armbruster arm...@redhat.com

Re: [Qemu-devel] PCI: how handle multifunction / compound devices best?

2011-07-05 Thread Gerd Hoffmann
Hi, Device macros destroy the 1:1 relationship between -device and device tree nodes. Or rather what's left of it: we already have a device that expands into multiple devices, namely usb-storage. But it's an ad hoc hack, which has caused us some grief. Exactly thats why I don't feel like

Re: [Qemu-devel] [PATCH 3/3] Avoid Wunsed-but-set warnings (or errors in case of Werror)

2011-07-05 Thread Markus Armbruster
Peter Maydell peter.mayd...@linaro.org writes: On 5 July 2011 07:15, Markus Armbruster arm...@redhat.com wrote: +    int fd, __attribute__((unused)) ret;      snprintf(reset_file, sizeof(reset_file),               /sys/bus/pci/devices/%04x:%02x:%02x.%01x/reset, What about (void)write() and

Re: [Qemu-devel] KVM call agenda for June 28

2011-07-05 Thread Dor Laor
I tried to re-arrange all of the requirements and use cases using this wiki page: http://wiki.qemu.org/Features/LiveBlockMigration It would be the best to agree upon the most interesting use cases (while we make sure we cover future ones) and agree to them. The next step is to set the

Re: [Qemu-devel] [PATCH 3/3] Avoid Wunsed-but-set warnings (or errors in case of Werror)

2011-07-05 Thread Paolo Bonzini
On 07/05/2011 09:49 AM, Markus Armbruster wrote: If 'ret' has been used to silence compiler warnings about functions which have been declared with attribute __warn_unused_result__ (eg write() and various other libc functions) then (void)write() is insufficient -- gcc requires the

[Qemu-devel] [PATCH 1/3] linux-user:Support for MIPS64 user mode emulation in QEMU

2011-07-05 Thread khansa
From: Khansa Butt kha...@kics.edu.pk Signed-off-by: Khansa Butt kha...@kics.edu.pk --- configure |1 + default-configs/mips64-linux-user.mak |1 + linux-user/main.c | 21 +++-- linux-user/mips64/syscall.h |2

[Qemu-devel] [PATCH 0/3] MIPS64 user mode emulation in QEMU with Cavium specific instruction support

2011-07-05 Thread khansa
From: Khansa Butt kha...@kics.edu.pk This is the team work of Ehsan-ul-Haq, Abdul Qadeer, Abdul Waheed, Khansa Butt from HPCN Lab KICS UET Lahore. Cavium Networks's Octeon processors are based on MIPS64r2 We have Implemented 27 user mode Cavium specific instructions. Richard Henderson told

[Qemu-devel] [PATCH 2/3] target-mips:Adding Octeon cpu definitions

2011-07-05 Thread khansa
From: Khansa Butt kha...@kics.edu.pk Signed-off-by: Khansa Butt kha...@kics.edu.pk --- target-mips/mips-defs.h |2 ++ target-mips/translate.c |1 + target-mips/translate_init.c | 24 3 files changed, 27 insertions(+), 0 deletions(-) diff --git

[Qemu-devel] [PATCH 3/3] target-mips:Support for Cavium specific instructions

2011-07-05 Thread khansa
From: Ehsan-ul-Haq, Abdul Qadeer, Abdul Waheed, Khansa Butt kha...@kics.edu.pk Signed-off-by: Khansa Butt kha...@kics.edu.pk --- host-utils.c|1 + target-mips/cpu.h |7 + target-mips/helper.h|5 + target-mips/op_helper.c | 67 +++ target-mips/translate.c

Re: [Qemu-devel] [PATCH 2/3] Add fno-strict-overflow

2011-07-05 Thread Stefan Hajnoczi
On Tue, Jul 5, 2011 at 6:41 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Mon, Jul 4, 2011 at 11:38 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 4 July 2011 23:00, Raghavendra D Prabhu raghu.prabh...@gmail.com wrote: This is to avoid gcc optimizating out the comparison in assert,

[Qemu-devel] PATCH: fix qemu-mips[el]-static to work with debian squeeze/sid chroot

2011-07-05 Thread Wesley W. Terpstra
I also recently tried to get a mipsel debian/sid chroot running under my amd64/squeeze system. As posted by Lisandro earlier this month, it didn't work. ;-) There are several problems, the most glaring of which the attached patch fixes. I'll break down the changes: 1. Return -TARGET_ENOSYS

Re: [Qemu-devel] [V4 Patch 1/4 -Updated]Qemu: Enhance info block to display host cache setting

2011-07-05 Thread Supriya Kannery
Updated patch to display hostcache = 1/0 instead of true/false in monitor. --- Enhance info block to display hostcache setting for each block device. Example: (qemu) info block ide0-hd0: type=hd removable=0 file=../rhel6-32.qcow2

Re: [Qemu-devel] [V4 Patch 3/4]Qemu: Command block_set for dynamic block params change

2011-07-05 Thread Supriya Kannery
On 07/04/2011 05:59 PM, Stefan Hajnoczi wrote: On Mon, Jul 4, 2011 at 11:43 AM, Supriya Kannery supri...@linux.vnet.ibm.com wrote: { +.name = block_set, +.args_type = device:B,name:s,enable:b, +.params = device name enable, Perhaps: .args_type =

Re: [Qemu-devel] [V4 Patch 4/4 - Updated]Qemu: Add commandline -drive option 'hostcache'

2011-07-05 Thread Supriya Kannery
Updated patch to use qemu_opt_get_bool() instead of qemu_opt_get() to read 'hostcache' --- qemu command option 'hostcache' added to -drive for block devices. While starting a VM from qemu commandline, this option can be used for

[Qemu-devel] [PATCH 2/5] scsi: Add 'hba_private' to SCSIRequest

2011-07-05 Thread Hannes Reinecke
'tag' is just an abstraction to identify the command from the driver. So we should make that explicit by replacing 'tag' with a driver-defined pointer 'hba_private'. This saves the lookup for driver handling several commands in parallel. 'tag' is still being kept for tracing purposes.

[Qemu-devel] [PATCH 3/5] scsi-disk: Fixup debugging statement

2011-07-05 Thread Hannes Reinecke
A debugging statement wasn't converted to the new interface. Signed-off-by: Hannes Reinecke h...@suse.de --- hw/scsi-disk.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index c2a99fe..5804662 100644 --- a/hw/scsi-disk.c +++

[Qemu-devel] [PATCH 4/5] scsi-disk: Mask out serial number EVPD

2011-07-05 Thread Hannes Reinecke
If the serial number is not set we should mask it out in the list of supported VPD pages and mark it as not supported. Signed-off-by: Hannes Reinecke h...@suse.de --- hw/scsi-disk.c | 15 --- 1 files changed, 12 insertions(+), 3 deletions(-) diff --git a/hw/scsi-disk.c

[Qemu-devel] [PATCH 0/5][v6] Megasas HBA emulation

2011-07-05 Thread Hannes Reinecke
Hi all, as Alex Graf reminded me the driver needed some more bugfixing to be done. I've found some issues and also moved the megasas emulation over to the new trace infrastructure. Driver works for me now and a full installation of openSUSE-12.1 works perfectly. I've also included the fixes

Re: [Qemu-devel] [PATCH 4/5] scsi-disk: Mask out serial number EVPD

2011-07-05 Thread Paolo Bonzini
On 07/05/2011 01:03 PM, Hannes Reinecke wrote: If the serial number is not set we should mask it out in the list of supported VPD pages and mark it as not supported. Signed-off-by: Hannes Reineckeh...@suse.de --- hw/scsi-disk.c | 15 --- 1 files changed, 12 insertions(+), 3

[Qemu-devel] [PATCH 1/5] iov: Update parameter usage in iov_(to|from)_buf()

2011-07-05 Thread Hannes Reinecke
iov_to_buf() has an 'offset' parameter, iov_from_buf() hasn't. This patch adds the missing parameter to iov_from_buf(). It also renames the 'offset' parameter to 'iov_off' to emphasize it's the offset into the iovec and not the buffer. Signed-off-by: Hannes Reinecke h...@suse.de Acked-by:

Re: [Qemu-devel] [PATCH 3/5] scsi-disk: Fixup debugging statement

2011-07-05 Thread Paolo Bonzini
On 07/05/2011 01:03 PM, Hannes Reinecke wrote: A debugging statement wasn't converted to the new interface. Signed-off-by: Hannes Reineckeh...@suse.de --- hw/scsi-disk.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index

[Qemu-devel] [PATCH 2/2] virtio-console: Add some trace events

2011-07-05 Thread Amit Shah
Add some trace events for messages passed between the char layer and the virtio-serial bus. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/virtio-console.c |9 - trace-events|5 + 2 files changed, 13 insertions(+), 1 deletions(-) diff --git

[Qemu-devel] [PATCH v8 05/12] VMDK: add field BDRVVmdkState.desc_offset

2011-07-05 Thread Fam Zheng
There are several occurrence of magic number 0x200 as the descriptor offset within mono sparse image file. This is not the case for images with separate descriptor file. So a field is added to BDRVVmdkState to hold the correct value. Signed-off-by: Fam Zheng famc...@gmail.com --- block/vmdk.c |

[Qemu-devel] [PATCH 1/2] virtio-serial-bus: Add trace events

2011-07-05 Thread Amit Shah
Add some trace events for messages passed between the guest and host. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/virtio-serial-bus.c |7 +++ trace-events |6 ++ 2 files changed, 13 insertions(+), 0 deletions(-) diff --git a/hw/virtio-serial-bus.c

[Qemu-devel] [PATCH v8 07/12] VMDK: move 'static' cid_update flag to bs field

2011-07-05 Thread Fam Zheng
Cid_update is the flag for updating CID on first write after opening the image. This should be per image open rather than per program life cycle, so change it from static var of vmdk_write to a field in BDRVVmdkState. Signed-off-by: Fam Zheng famc...@gmail.com --- block/vmdk.c |6 +++--- 1

[Qemu-devel] [PATCH v8 00/12] Adding VMDK monolithic flat support

2011-07-05 Thread Fam Zheng
Chnages from v7: 03/12: remove deadloop in probing descriptor file. Fam Zheng (12): VMDK: introduce VmdkExtent VMDK: bugfix, align offset to cluster in get_whole_cluster VMDK: probe for monolithicFlat images VMDK: separate vmdk_open by format version VMDK: add field

[Qemu-devel] [PATCH v8 01/12] VMDK: introduce VmdkExtent

2011-07-05 Thread Fam Zheng
Introduced VmdkExtent array into BDRVVmdkState, enable holding multiple image extents for multiple file image support. Signed-off-by: Fam Zheng famc...@gmail.com --- block/vmdk.c | 348 +- 1 files changed, 246 insertions(+), 102

[Qemu-devel] [PATCH v8 10/12] VMDK: create different subformats

2011-07-05 Thread Fam Zheng
Add create option 'format', with enums: monolithicSparse monolithicFlat twoGbMaxExtentSparse twoGbMaxExtentFlat Each creates a subformat image file. The default is monolithiSparse. Signed-off-by: Fam Zheng famc...@gmail.com --- block/vmdk.c | 561

[Qemu-devel] [PATCH v8 09/12] VMDK: open/read/write for monolithicFlat image

2011-07-05 Thread Fam Zheng
Parse vmdk decriptor file and open mono flat image. Read/write the flat extent. Signed-off-by: Fam Zheng famc...@gmail.com --- block/vmdk.c | 172 +- 1 files changed, 159 insertions(+), 13 deletions(-) diff --git a/block/vmdk.c

[Qemu-devel] [PATCH v8 02/12] VMDK: bugfix, align offset to cluster in get_whole_cluster

2011-07-05 Thread Fam Zheng
In get_whole_cluster, the offset is not aligned to cluster when reading from backing_hd. When the first write to child is not at the cluster boundary, wrong address data from parent is copied to child. Signed-off-by: Fam Zheng famc...@gmail.com --- block/vmdk.c |8 +--- 1 files changed,

[Qemu-devel] [PATCH v8 11/12] VMDK: fix coding style

2011-07-05 Thread Fam Zheng
Conform coding style in vmdk.c to pass scripts/checkpatch.pl checks. Signed-off-by: Fam Zheng famc...@gmail.com --- block/vmdk.c | 79 +++-- 1 files changed, 48 insertions(+), 31 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index

[Qemu-devel] [PATCH v8 03/12] VMDK: probe for monolithicFlat images

2011-07-05 Thread Fam Zheng
Probe as the same behavior as VMware does. Recognize image as monolithicFlat descriptor file when the file is text and the first effective line (not '#' leaded comment or space line) is either 'version=1' or 'version=2'. No space or upper case charactors accepted. Signed-off-by: Fam Zheng

[Qemu-devel] [PATCH v8 04/12] VMDK: separate vmdk_open by format version

2011-07-05 Thread Fam Zheng
Separate vmdk_open by subformats to: * vmdk_open_vmdk3 * vmdk_open_vmdk4 Signed-off-by: Fam Zheng famc...@gmail.com --- block/vmdk.c | 178 - 1 files changed, 112 insertions(+), 66 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c

[Qemu-devel] [PATCH v8 06/12] VMDK: flush multiple extents

2011-07-05 Thread Fam Zheng
Flush all the file that referenced by the image. Signed-off-by: Fam Zheng famc...@gmail.com --- block/vmdk.c | 12 +++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 529ae90..f6d2986 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@

[Qemu-devel] [PATCH v8 08/12] VMDK: change get_cluster_offset return type

2011-07-05 Thread Fam Zheng
The return type of get_cluster_offset was an offset that use 0 to denote 'not allocated', this will be no longer true for flat extents, as we see flat extent file as a single huge cluster whose offset is 0 and length is the whole file length. So now we use int return value, 0 means success and

Re: [Qemu-devel] KVM call agenda for June 28

2011-07-05 Thread Stefan Hajnoczi
On Tue, Jul 5, 2011 at 9:01 AM, Dor Laor dl...@redhat.com wrote: I tried to re-arrange all of the requirements and use cases using this wiki page: http://wiki.qemu.org/Features/LiveBlockMigration It would be the best to agree upon the most interesting use cases (while we make sure we cover

[Qemu-devel] [PATCH v8 12/12] block: add bdrv_get_allocated_file_size() operation

2011-07-05 Thread Fam Zheng
qemu-img.c wants to count allocated file size of image. Previously it counts a single bs-file by 'stat' or Window API. As VMDK introduces multiple file support, the operation becomes format specific with platform specific meanwhile. The functions are moved to block/raw-{posix,win32}.c and

[Qemu-devel] [QAPI+QGA 2/3] QAPI code generation infrastructure v5

2011-07-05 Thread Michael Roth
This is Set 2/3 of the QAPI+QGA patchsets. These patches apply on top of master (set1 merged), and can also be obtained from: git://repo.or.cz/qemu/mdroth.git qapi-backport-set2-v5 (Set1+2 are a backport of some of the QAPI-related work from Anthony's glib tree. The main goal is to get the basic

Re: [Qemu-devel] [PATCH 0/5][v6] Megasas HBA emulation

2011-07-05 Thread Alexander Graf
On 07/05/2011 01:03 PM, Hannes Reinecke wrote: Hi all, as Alex Graf reminded me the driver needed some more bugfixing to be done. I've found some issues and also moved the megasas emulation over to the new trace infrastructure. Driver works for me now and a full installation of openSUSE-12.1

Re: [Qemu-devel] KVM call agenda for June 28

2011-07-05 Thread Marcelo Tosatti
On Tue, Jul 05, 2011 at 01:40:08PM +0100, Stefan Hajnoczi wrote: On Tue, Jul 5, 2011 at 9:01 AM, Dor Laor dl...@redhat.com wrote: I tried to re-arrange all of the requirements and use cases using this wiki page: http://wiki.qemu.org/Features/LiveBlockMigration It would be the best to

[Qemu-devel] [PATCH v5 02/18] qlist: add qlist_first()/qlist_next()

2011-07-05 Thread Michael Roth
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- qlist.h | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/qlist.h b/qlist.h index dbe7b92..d426bd4 100644 --- a/qlist.h +++ b/qlist.h @@ -16,6 +16,7 @@ #include qobject.h #include qemu-queue.h #include

[Qemu-devel] [PATCH v5 01/18] Add hard build dependency on glib

2011-07-05 Thread Michael Roth
From: Anthony Liguori aligu...@us.ibm.com GLib is an extremely common library that has a portable thread implementation along with tons of other goodies. GLib and GObject have a fantastic amount of infrastructure we can leverage in QEMU including an object oriented programming infrastructure.

[Qemu-devel] utimensat trouble on mips

2011-07-05 Thread Johannes Schauer
Hi, I am following up on threads started here [1] and here [2]. I'm not subscribed to qemu-devel so please dont forget to CC me. About a year ago, Kenneth Johansson reported [1], that trying to do a debian debootstrap using qemu user emulation will fail due to the following error: /bin/tar:

[Qemu-devel] [PATCH v5 03/18] qapi: add module init types for qapi

2011-07-05 Thread Michael Roth
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- module.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/module.h b/module.h index 9263f1c..ef66730 100644 --- a/module.h +++ b/module.h @@ -24,12 +24,14 @@ typedef enum { MODULE_INIT_BLOCK,

[Qemu-devel] [PATCH v5 04/18] qapi: add QAPI visitor core

2011-07-05 Thread Michael Roth
Base definitions/includes for Visiter interface used by generated visiter/marshalling code. Includes a GenericList type. Our lists require an embedded element. Since these types are generated, if you want to use them in a different type of data structure, there's no easy way to add another

[Qemu-devel] [PATCH v5 12/18] qapi: add qapi-types.py code generator

2011-07-05 Thread Michael Roth
This is the code generator for qapi types. It will generation the following files: $(prefix)qapi-types.h - C types corresponding to types defined in the schema you pass in $(prefix)qapi-types.c - Cleanup functions for the above C types The $(prefix) is used to as a

[Qemu-devel] [PATCH v5 06/18] qapi: add QMP output visitor

2011-07-05 Thread Michael Roth
Type of Visiter class that serves as the inverse of the input visitor: it takes a series of native C types and uses their values to construct a corresponding QObject. The command marshaling/dispatcher functions will use this to convert the output of QMP functions into a QObject that can be sent

[Qemu-devel] [PATCH v5 05/18] qapi: add QMP input visitor

2011-07-05 Thread Michael Roth
A type of Visiter class that is used to walk a qobject's structure and assign each entry to the corresponding native C type. Command marshaling function will use this to pull out QMP command parameters recieved over the wire and pass them as native arguments to the corresponding C functions.

[Qemu-devel] [PATCH v5 15/18] qapi: test schema used for unit tests

2011-07-05 Thread Michael Roth
This is how QMP commands/parameters/types would be defined. We use a subset of that functionality here to implement functions/types for unit testing. Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- qapi-schema-test.json | 22 ++ 1 files changed, 22 insertions(+),

[Qemu-devel] [PATCH v5 08/18] qapi: add QMP command registration/lookup functions

2011-07-05 Thread Michael Roth
Registration/lookup functions for that provide a lookup table for dispatching QMP commands. Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- Makefile.objs |1 + qapi/qmp-core.h | 40 qapi/qmp-registry.c | 40

[Qemu-devel] [PATCH v5 07/18] qapi: add QAPI dealloc visitor

2011-07-05 Thread Michael Roth
Type of Visitor class that can be passed into a qapi-generated C type's visitor function to free() any heap-allocated data types. Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- Makefile.objs |2 +- qapi/qapi-dealloc-visitor.c | 138

Re: [Qemu-devel] [PATCH 5/5] megasas: LSI Megaraid SAS emulation

2011-07-05 Thread Alexander Graf
On 07/05/2011 01:03 PM, Hannes Reinecke wrote: This patch adds an emulation for the LSI Megaraid SAS 8708EM2 HBA. Nice, so it does work for me this time :). Tested-by: Alexander Graf ag...@suse.de Alex

[Qemu-devel] [PATCH v5 09/18] qapi: add QMP dispatch functions

2011-07-05 Thread Michael Roth
Given an object recieved via QMP, this code uses the dispatch table provided by qmp_registry.c to call the corresponding marshalling/dispatch function and format return values/errors for delivery to the QMP. Currently only synchronous QMP functions are supported, but this will also be used for

[Qemu-devel] [PATCH v5 18/18] qapi: add QAPI code generation documentation

2011-07-05 Thread Michael Roth
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- docs/qapi-code-gen.txt | 316 1 files changed, 316 insertions(+), 0 deletions(-) create mode 100644 docs/qapi-code-gen.txt diff --git a/docs/qapi-code-gen.txt b/docs/qapi-code-gen.txt

Re: [Qemu-devel] Setting up PPC440 Virtex Image for Qemu

2011-07-05 Thread Suzuki Poulose
On 06/30/11 18:40, Edgar E. Iglesias wrote: On Thu, Jun 30, 2011 at 06:30:04PM +0530, Suzuki Poulose wrote: On 06/30/11 18:02, Edgar E. Iglesias wrote: On Thu, Jun 30, 2011 at 05:45:23PM +0530, Suzuki Poulose wrote: Hi, I am working on enabling the KEXEC on PPC440 chipsets. To debug my

[Qemu-devel] [PATCH v5 10/18] qapi: add ordereddict.py helper library

2011-07-05 Thread Michael Roth
We need this to parse dictionaries with schema ordering intact so that C prototypes can be generated deterministically. Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- scripts/ordereddict.py | 128 1 files changed, 128 insertions(+), 0

Re: [Qemu-devel] [PATCH 3/3] hw/omap_gpio.c: Convert to qdev

2011-07-05 Thread Peter Maydell
On 4 July 2011 23:39, andrzej zaborowski balr...@gmail.com wrote: Patch looks good overall, but for consistency we should rename functions which start with omap2_gpio_module_ to omap2_gpio_ if the state pointer passed is no longer the module pointer but instead the whole thing pointer.  But

[Qemu-devel] [PATCH v5 11/18] qapi: add qapi.py helper libraries

2011-07-05 Thread Michael Roth
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- scripts/qapi.py | 203 +++ 1 files changed, 203 insertions(+), 0 deletions(-) create mode 100644 scripts/qapi.py diff --git a/scripts/qapi.py b/scripts/qapi.py new file mode 100644

[Qemu-devel] [PATCH v6 1/4] guest agent: command state class

2011-07-05 Thread Michael Roth
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- Makefile|4 ++- configure |1 + qga/guest-agent-command-state.c | 73 +++ qga/guest-agent-core.h | 25 + 4 files changed,

[Qemu-devel] [PATCH v6 3/4] guest agent: add guest agent commands schema file

2011-07-05 Thread Michael Roth
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- qapi-schema-guest.json | 204 1 files changed, 204 insertions(+), 0 deletions(-) create mode 100644 qapi-schema-guest.json diff --git a/qapi-schema-guest.json b/qapi-schema-guest.json

[Qemu-devel] [PATCH v6 2/4] guest agent: qemu-ga daemon

2011-07-05 Thread Michael Roth
This is the actual guest daemon, it listens for requests over a virtio-serial/isa-serial/unix socket channel and routes them through to dispatch routines, and writes the results back to the channel in a manner similar to QMP. A shorthand invocation: qemu-ga -d Is equivalent to: qemu-ga -c

[Qemu-devel] [PATCH v5 13/18] qapi: add qapi-visit.py code generator

2011-07-05 Thread Michael Roth
This is the code generator for qapi visiter functions used to marshal/unmarshal/dealloc qapi types. It generates the following 2 files: $(prefix)qapi-visit.c: visiter function for a particular c type, used to automagically convert qobjects into the

[Qemu-devel] [PATCH v5 14/18] qapi: add qapi-commands.py code generator

2011-07-05 Thread Michael Roth
This is the code generator for qapi command marshaling/dispatch. Currently only generators for synchronous qapi/qmp functions are supported. This script generates the following files: $(prefix)qmp-marshal.c: command marshal/dispatch functions for each QMP command

Re: [Qemu-devel] [PATCH] pci: add standard bridge device

2011-07-05 Thread Isaku Yamahata
On Mon, Jul 04, 2011 at 12:43:59PM +0300, Michael S. Tsirkin wrote: +/* Mapping mandated by PCI-to-PCI Bridge architecture specification, + * revision 1.2 */ +/* Table 9-1: Interrupt Binding for Devices Behind a Bridge */ +static int pci_bridge_dev_map_irq_fn(PCIDevice *dev, int irq_num) +{

Re: [Qemu-devel] [PATCH 5/5] megasas: LSI Megaraid SAS emulation

2011-07-05 Thread Alexander Graf
On 07/05/2011 01:03 PM, Hannes Reinecke wrote: This patch adds an emulation for the LSI Megaraid SAS 8708EM2 HBA. Signed-off-by: Hannes Reineckeh...@suse.de --- Makefile.objs |1 + default-configs/pci.mak |1 + hw/megasas.c| 1950

[Qemu-devel] [QAPI+QGA 3/3] QEMU Guest Agent (virtagent) v6

2011-07-05 Thread Michael Roth
This is Set 3/3 of the QAPI+QGA patchsets. These patches apply on top of qapi-backport-set2-v5, and can also be obtained from: git://repo.or.cz/qemu/mdroth.git qapi-backport-set3-v6 (Set1+2 are a backport of some of the QAPI-related work from Anthony's glib tree. The main goal is to get the

[Qemu-devel] [PATCH v5 16/18] qapi: add test-visitor, tests for gen. visitor code

2011-07-05 Thread Michael Roth
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- Makefile | 18 +++- test-visitor.c | 305 2 files changed, 321 insertions(+), 2 deletions(-) create mode 100644 test-visitor.c diff --git a/Makefile b/Makefile index

Re: [Qemu-devel] KVM call agenda for June 28

2011-07-05 Thread Dor Laor
On 07/05/2011 03:58 PM, Marcelo Tosatti wrote: On Tue, Jul 05, 2011 at 01:40:08PM +0100, Stefan Hajnoczi wrote: On Tue, Jul 5, 2011 at 9:01 AM, Dor Laordl...@redhat.com wrote: I tried to re-arrange all of the requirements and use cases using this wiki page:

Re: [Qemu-devel] PATCH: fix qemu-mips[el]-static to work with debian squeeze/sid chroot

2011-07-05 Thread Peter Maydell
On 5 July 2011 11:08, Wesley W. Terpstra terps...@debian.org wrote: I also recently tried to get a mipsel debian/sid chroot running under my amd64/squeeze system. As posted by Lisandro earlier this month, it didn't work. ;-) There are several problems, the most glaring of which the attached

[Qemu-devel] [PATCH v5 17/18] qapi: add test-qmp-commands, tests for gen. marshalling/dispatch code

2011-07-05 Thread Michael Roth
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- Makefile|8 +++- test-qmp-commands.c | 113 +++ 2 files changed, 120 insertions(+), 1 deletions(-) create mode 100644 test-qmp-commands.c diff --git a/Makefile b/Makefile

[Qemu-devel] live block copy/stream/snapshot discussion

2011-07-05 Thread Dor Laor
Anthony advised to clone http://wiki.qemu.org/index.php?title=Features/LiveBlockMigrationFuture to the list in order to encourage discussion, so here it is: qemu is expected to support these features (some already

[Qemu-devel] [PATCH v6 4/4] guest agent: add guest agent RPCs/commands

2011-07-05 Thread Michael Roth
This adds the initial set of QMP/QAPI commands provided by the guest agent: guest-sync guest-ping guest-info guest-shutdown guest-file-open guest-file-read guest-file-write guest-file-seek guest-file-close guest-fsfreeze-freeze guest-fsfreeze-thaw guest-fsfreeze-status The input/output

Re: [Qemu-devel] utimensat trouble on mips

2011-07-05 Thread Peter Maydell
On 5 July 2011 13:07, Johannes Schauer j.scha...@email.de wrote: About a year ago, Kenneth Johansson reported [1], that trying to do a debian debootstrap using qemu user emulation will fail due to the following error: /bin/tar: ./postinst: Cannot utime: Level 2 not synchronized This is the

Re: [Qemu-devel] [PATCH 5/5] megasas: LSI Megaraid SAS emulation

2011-07-05 Thread Paolo Bonzini
On 07/05/2011 03:38 PM, Alexander Graf wrote: +if (is_sgl64) { +iov_pa = ldq_phys(pa); +} else { +iov_pa = ldl_phys(pa); These load data from memory in target endianness. Are you sure that's what you want? I'd expect this to be defined as little

Re: [Qemu-devel] [PATCH] pci: add standard bridge device

2011-07-05 Thread Michael S. Tsirkin
On Tue, Jul 05, 2011 at 10:29:36PM +0900, Isaku Yamahata wrote: On Mon, Jul 04, 2011 at 12:43:59PM +0300, Michael S. Tsirkin wrote: +/* Mapping mandated by PCI-to-PCI Bridge architecture specification, + * revision 1.2 */ +/* Table 9-1: Interrupt Binding for Devices Behind a Bridge */

Re: [Qemu-devel] KVM call agenda for June 28

2011-07-05 Thread Marcelo Tosatti
On Tue, Jul 05, 2011 at 04:39:06PM +0300, Dor Laor wrote: On 07/05/2011 03:58 PM, Marcelo Tosatti wrote: On Tue, Jul 05, 2011 at 01:40:08PM +0100, Stefan Hajnoczi wrote: On Tue, Jul 5, 2011 at 9:01 AM, Dor Laordl...@redhat.com wrote: I tried to re-arrange all of the requirements and use cases

Re: [Qemu-devel] KVM call agenda for June 28

2011-07-05 Thread Kevin Wolf
Am 05.07.2011 16:32, schrieb Marcelo Tosatti: On Tue, Jul 05, 2011 at 04:39:06PM +0300, Dor Laor wrote: On 07/05/2011 03:58 PM, Marcelo Tosatti wrote: On Tue, Jul 05, 2011 at 01:40:08PM +0100, Stefan Hajnoczi wrote: On Tue, Jul 5, 2011 at 9:01 AM, Dor Laordl...@redhat.com wrote: I tried to

Re: [Qemu-devel] [PATCH 5/5] megasas: LSI Megaraid SAS emulation

2011-07-05 Thread Alexander Graf
On 07/05/2011 03:59 PM, Paolo Bonzini wrote: On 07/05/2011 03:38 PM, Alexander Graf wrote: +if (is_sgl64) { +iov_pa = ldq_phys(pa); +} else { +iov_pa = ldl_phys(pa); These load data from memory in target endianness. Are you sure that's what you want? I'd

Re: [Qemu-devel] [PATCH] Make SLIRP Ethernet packets size to 64 bytes minimuma

2011-07-05 Thread Fabien Chouteau
On 30/06/2011 10:38, Fabien Chouteau wrote: On 28/06/2011 15:15, Stefan Hajnoczi wrote: On Tue, Jun 28, 2011 at 10:08 AM, Fabien Chouteau chout...@adacore.com wrote: On 28/06/2011 10:34, Stefan Hajnoczi wrote: This patch doesn't hurt but we'd be just as well off without it. Did you do this

[Qemu-devel] [PATCH 0/9] Don't use ld./st._phys in hw/

2011-07-05 Thread Alexander Graf
We have quite some code in hw/ that uses ld./st._phys functions in device emulation code. This is just pure wrong, as devices don't know about the CPU endianness (except for virtio), so they should instead use something endian specific. Unfortunately, there is no endian specific call to easily

Re: [Qemu-devel] KVM call agenda for June 28

2011-07-05 Thread Dor Laor
On 07/05/2011 05:32 PM, Marcelo Tosatti wrote: On Tue, Jul 05, 2011 at 04:39:06PM +0300, Dor Laor wrote: On 07/05/2011 03:58 PM, Marcelo Tosatti wrote: On Tue, Jul 05, 2011 at 01:40:08PM +0100, Stefan Hajnoczi wrote: On Tue, Jul 5, 2011 at 9:01 AM, Dor Laordl...@redhat.com wrote: I tried

[Qemu-devel] [PATCH 7/9] ppc405_uc: use specific endian ld/st_phys

2011-07-05 Thread Alexander Graf
Signed-off-by: Alexander Graf ag...@suse.de --- hw/ppc405_uc.c | 43 +++ 1 files changed, 23 insertions(+), 20 deletions(-) diff --git a/hw/ppc405_uc.c b/hw/ppc405_uc.c index 2ce79ee..06a053b 100644 --- a/hw/ppc405_uc.c +++ b/hw/ppc405_uc.c @@ -51,39

Re: [Qemu-devel] [PATCH 5/5] megasas: LSI Megaraid SAS emulation

2011-07-05 Thread Stefan Hajnoczi
On Tue, Jul 5, 2011 at 12:03 PM, Hannes Reinecke h...@suse.de wrote: +static void megasas_unmap_sgl(struct megasas_cmd_t *cmd) +{ +    uint16_t flags = le16_to_cpu(cmd-frame-header.flags); +    int i, is_write = (flags MFI_FRAME_DIR_WRITE) ? 1 : 0; + +    for (i = 0; i

[Qemu-devel] [PATCH 2/9] hpet: use specific endian ld/st_phys

2011-07-05 Thread Alexander Graf
Signed-off-by: Alexander Graf ag...@suse.de --- hw/hpet.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/hpet.c b/hw/hpet.c index ef9a2a0..4eda33d 100644 --- a/hw/hpet.c +++ b/hw/hpet.c @@ -192,7 +192,7 @@ static void update_irq(struct HPETTimer *timer, int set)

Re: [Qemu-devel] [PATCH V2] [PowerPC][RFC] booke timers

2011-07-05 Thread Scott Wood
On Mon, 4 Jul 2011 17:06:54 +0200 Fabien Chouteau chout...@adacore.com wrote: On 01/07/2011 22:22, Scott Wood wrote: On Fri, 1 Jul 2011 16:13:41 +0200 Fabien Chouteau chout...@adacore.com wrote: +static void booke_update_fixed_timer(CPUState *env, +

Re: [Qemu-devel] KVM call agenda for June 28

2011-07-05 Thread Marcelo Tosatti
On Tue, Jul 05, 2011 at 06:04:34PM +0300, Dor Laor wrote: On 07/05/2011 05:32 PM, Marcelo Tosatti wrote: On Tue, Jul 05, 2011 at 04:39:06PM +0300, Dor Laor wrote: On 07/05/2011 03:58 PM, Marcelo Tosatti wrote: On Tue, Jul 05, 2011 at 01:40:08PM +0100, Stefan Hajnoczi wrote: On Tue, Jul 5,

[Qemu-devel] [PATCH 1/9] exec: add endian specific phys ld/st functions

2011-07-05 Thread Alexander Graf
Device code some times needs to access physical memory and does that through the ld./st._phys functions. However, these are the exact same functions that the CPU uses to access memory, which means they will be endianness swapped depending on the target CPU. However, devices don't know about the

Re: [Qemu-devel] [PATCH 2/3] Add fno-strict-overflow

2011-07-05 Thread Raghavendra D Prabhu
* On Mon, Jul 04, 2011 at 11:38:30PM +0100, Peter Maydell peter.mayd...@linaro.org wrote: On 4 July 2011 23:00, Raghavendra D Prabhu raghu.prabh...@gmail.com wrote: This is to avoid gcc optimizating out the comparison in assert, due to assumption of signed overflow being undefined by default

[Qemu-devel] [PATCH 5/9] msix: use specific endian ld/st_phys

2011-07-05 Thread Alexander Graf
Signed-off-by: Alexander Graf ag...@suse.de --- hw/msix.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/msix.c b/hw/msix.c index 03d7bec..e67e700 100644 --- a/hw/msix.c +++ b/hw/msix.c @@ -359,7 +359,7 @@ void msix_notify(PCIDevice *dev, unsigned vector)

Re: [Qemu-devel] KVM call agenda for June 28

2011-07-05 Thread Stefan Hajnoczi
On Tue, Jul 5, 2011 at 3:32 PM, Marcelo Tosatti mtosa...@redhat.com wrote: On Tue, Jul 05, 2011 at 04:39:06PM +0300, Dor Laor wrote: On 07/05/2011 03:58 PM, Marcelo Tosatti wrote: On Tue, Jul 05, 2011 at 01:40:08PM +0100, Stefan Hajnoczi wrote: On Tue, Jul 5, 2011 at 9:01 AM, Dor

[Qemu-devel] [PATCH 8/9] s390-virtio: use specific endian ld/st_phys

2011-07-05 Thread Alexander Graf
Signed-off-by: Alexander Graf ag...@suse.de --- hw/s390-virtio-bus.c | 10 +- hw/s390-virtio.c |6 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/s390-virtio-bus.c b/hw/s390-virtio-bus.c index d4a12f7..dde6ba5 100644 --- a/hw/s390-virtio-bus.c +++

Re: [Qemu-devel] [PATCH V2] [PowerPC][RFC] booke timers

2011-07-05 Thread Fabien Chouteau
On 05/07/2011 18:02, Scott Wood wrote: On Mon, 4 Jul 2011 17:06:54 +0200 Fabien Chouteau chout...@adacore.com wrote: On 01/07/2011 22:22, Scott Wood wrote: On Fri, 1 Jul 2011 16:13:41 +0200 Fabien Chouteau chout...@adacore.com wrote: +static void booke_update_fixed_timer(CPUState

[Qemu-devel] [PATCH 09/12] xen_disk: treat aio as raw

2011-07-05 Thread Alexander Graf
From: Stefano Stabellini stefano.stabell...@eu.citrix.com Sometimes the toolstack uses aio without an additional format identifier, in such cases use raw. Updated in v2: - fix code style. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Signed-off-by: Alexander Graf

[Qemu-devel] [PATCH 4/9] msi: use specific endian ld/st_phys

2011-07-05 Thread Alexander Graf
Signed-off-by: Alexander Graf ag...@suse.de --- hw/msi.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/msi.c b/hw/msi.c index e8c5607..f214fcf 100644 --- a/hw/msi.c +++ b/hw/msi.c @@ -249,7 +249,7 @@ void msi_notify(PCIDevice *dev, unsigned int vector)

[Qemu-devel] [PATCH 08/12] qemu_ram_ptr_length: take ram_addr_t as arguments

2011-07-05 Thread Alexander Graf
From: Stefano Stabellini stefano.stabell...@eu.citrix.com qemu_ram_ptr_length should take ram_addr_t as argument rather than target_phys_addr_t because is doing comparisons with RAMBlock addresses. cpu_physical_memory_map should create a ram_addr_t address to pass to qemu_ram_ptr_length from

[Qemu-devel] [PATCH 06/12] xen: add vkbd support for PV on HVM guests

2011-07-05 Thread Alexander Graf
From: Stefano Stabellini stefano.stabell...@eu.citrix.com Register the vkbd backend even when running as device emulator for HVM guests: it is useful because it doesn't need a frequent timer like usb. Check whether the XenInput DisplayState has been set in the initialise state, rather than the

[Qemu-devel] [PATCH 04/12] xen: enable console and disk backend in HVM mode

2011-07-05 Thread Alexander Graf
From: Stefano Stabellini stefano.stabell...@eu.citrix.com Initialize the Xen console backend and the Xen disk backend even when running in HVM mode so that PV on HVM drivers can connect to them. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Signed-off-by: Alexander Graf

  1   2   >