Re: [Qemu-devel] [PATCH 6/6] scsi-disk: Check for supported commands

2011-07-27 Thread Markus Armbruster
Christoph Hellwig h...@lst.de writes: On Fri, Jul 22, 2011 at 04:51:17PM +0200, Hannes Reinecke wrote: Not every command is support for any device type. This patch adds a check for rejecting unsupported commands. Signed-off-by: Hannes Reinecke h...@suse.de This seems to conflic with

[Qemu-devel] [PATCH 0/1] qmp: fix typo for qmp-commands.hx

2011-07-27 Thread Zhi Yong Wu
In qmp-commands.hx, there exists a typo, and it will be fixed by this patch. Zhi Yong Wu (1): Fix typo for qmp-commands.hx. Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com qmp-commands.hx |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- 1.7.2.3

[Qemu-devel] [PATCH 1/1] Fix typo for qmp-commands.hx. Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com

2011-07-27 Thread Zhi Yong Wu
--- qmp-commands.hx |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qmp-commands.hx b/qmp-commands.hx index 92c5c3a..d7352ae 100644 --- a/qmp-commands.hx +++ b/qmp-commands.hx @@ -42,7 +42,7 @@ and we're going to establish a deprecation policy for badly defined

[Qemu-devel] [PATCH 1/2] balloon: Don't allow multiple balloon handler registrations

2011-07-27 Thread Amit Shah
Multiple balloon devices don't make sense; disallow more than one registration attempt to register handlers. Signed-off-by: Amit Shah amit.s...@redhat.com --- balloon.c | 11 +-- balloon.h |4 ++-- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/balloon.c

[Qemu-devel] [PATCH 2/2] virtio-balloon: Check if balloon registration failed

2011-07-27 Thread Amit Shah
Multiple balloon registrations are not allowed; check if the registration with the qemu balloon api succeeded. If not, fail the device init. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/virtio-balloon.c | 10 +- hw/virtio-pci.c |3 +++ 2 files changed, 12

Re: [Qemu-devel] [PATCH] virtio-serial-bus: replay guest_open on migration

2011-07-27 Thread Alon Levy
On Wed, Jul 27, 2011 at 07:45:25AM +0200, Markus Armbruster wrote: Alon Levy al...@redhat.com writes: Signed-off-by: Alon Levy al...@redhat.com --- hw/virtio-serial-bus.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/hw/virtio-serial-bus.c

Re: [Qemu-devel] [PATCH 1/1] Fix typo for qmp-commands.hx. Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com

2011-07-27 Thread Stefan Hajnoczi
On Wed, Jul 27, 2011 at 7:32 AM, Zhi Yong Wu wu...@linux.vnet.ibm.com wrote: ---  qmp-commands.hx |    2 +-  1 files changed, 1 insertions(+), 1 deletions(-) Thanks, merged into the trivial-patches tree: http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivial-patches A few tips on

Re: [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-07-27 Thread Kevin Wolf
Am 26.07.2011 18:57, schrieb Corey Bryant: Kevin, thanks for the input. On 07/26/2011 11:18 AM, Kevin Wolf wrote: Am 26.07.2011 14:51, schrieb Corey Bryant: sVirt provides SELinux MAC isolation for Qemu guest processes and their corresponding resources (image files). sVirt provides this

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Makefile: add missing deps on $(GENERATED_HEADERS)

2011-07-27 Thread Stefan Hajnoczi
On Tue, Jul 26, 2011 at 11:39:24AM -0500, Michael Roth wrote: This fixes a build issue with make -j6+ due to qapi-generated files being built before $(GENERATED_HEADERS) have been created. Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- Makefile |4 +++- 1 files changed, 3

Re: [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-07-27 Thread Daniel P. Berrange
On Wed, Jul 27, 2011 at 10:11:06AM +0200, Kevin Wolf wrote: Am 26.07.2011 18:57, schrieb Corey Bryant: diff --git a/block/cow.c b/block/cow.c index 4cf543c..e17f8e7 100644 --- a/block/cow.c +++ b/block/cow.c @@ -82,6 +82,11 @@ static int cow_open(BlockDriverState *bs, int flags)

[Qemu-devel] [PATCH 0/4] Fix virtio memleaks

2011-07-27 Thread Amit Shah
The memory allocated in virtio_common_init() wasn't being freed anywhere. Fix that. The balloon handler wasn't unregistering its savevm section, adding an exit handler fixes that as well. This patchset is on top of the two balloon series I've sent out yesterday and today. Amit Shah (4):

[Qemu-devel] [PATCH 1/4] virtio-balloon: Add exit handler, fix memleaks

2011-07-27 Thread Amit Shah
Add an exit handler that will free up RAM and unregister the savevm section after a virtio-balloon device is unplugged. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/virtio-balloon.c |9 + hw/virtio-pci.c | 11 ++- hw/virtio.h |1 + 3 files changed,

[Qemu-devel] [PATCH 2/4] virtio-blk: Fix memleak on exit

2011-07-27 Thread Amit Shah
Calling virtio_cleanup() will free up memory allocated in virtio_common_init(). Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/virtio-blk.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c index 6471ac8..836dbc3 100644 ---

[Qemu-devel] vt82686b query

2011-07-27 Thread Michael S. Tsirkin
Does one of you maintain the vt82686b emulation? I was doing an overview of pci devices and have some questions on it: vt82c686b_write_config - this seems to assume that config writes are done using single byte accesses. E.g. a two byte access at 0x84 will modify the register at offset 0x85 but

[Qemu-devel] [PATCH 4/4] virtio: Plug memleak by freeing vdev

2011-07-27 Thread Amit Shah
virtio_common_init() allocates RAM for the vdev struct (and any additional memory, depending on the size passed to the function). This memory wasn't being freed until now. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/virtio.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-)

[Qemu-devel] [PATCH 3/4] virtio-net: Fix potential use-after-free

2011-07-27 Thread Amit Shah
virtio_cleanup() will remove the VirtIONet struct that gets allocated via virtio_common_init(). Ensure we don't dereference the structure after calling the cleanup function. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/virtio-net.c |2 +- 1 files changed, 1 insertions(+), 1

Re: [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-07-27 Thread Kevin Wolf
Am 27.07.2011 10:22, schrieb Daniel P. Berrange: On Wed, Jul 27, 2011 at 10:11:06AM +0200, Kevin Wolf wrote: Am 26.07.2011 18:57, schrieb Corey Bryant: diff --git a/block/cow.c b/block/cow.c index 4cf543c..e17f8e7 100644 --- a/block/cow.c +++ b/block/cow.c @@ -82,6 +82,11 @@ static int

Re: [Qemu-devel] [PATCH 1/1] block/vpc.c: Detect too-large vpc file

2011-07-27 Thread Kevin Wolf
Am 26.07.2011 22:26, schrieb Serge E. Hallyn: Quoting Kevin Wolf (kw...@redhat.com): Am 26.07.2011 18:08, schrieb Serge E. Hallyn: Quoting Kevin Wolf (kw...@redhat.com): Am 25.07.2011 20:34, schrieb Serge E. Hallyn: VHD files technically can be up to 2Tb, but virtual pc is limited to 127G.

Re: [Qemu-devel] [PATCH 3/4] virtio-net: Fix potential use-after-free

2011-07-27 Thread Michael S. Tsirkin
On Wed, Jul 27, 2011 at 02:00:31PM +0530, Amit Shah wrote: virtio_cleanup() will remove the VirtIONet struct that gets allocated via virtio_common_init(). Ensure we don't dereference the structure after calling the cleanup function. Signed-off-by: Amit Shah amit.s...@redhat.com I see. It's

Re: [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-07-27 Thread Daniel P. Berrange
On Wed, Jul 27, 2011 at 10:36:25AM +0200, Kevin Wolf wrote: Am 27.07.2011 10:22, schrieb Daniel P. Berrange: On Wed, Jul 27, 2011 at 10:11:06AM +0200, Kevin Wolf wrote: Am 26.07.2011 18:57, schrieb Corey Bryant: diff --git a/block/cow.c b/block/cow.c index 4cf543c..e17f8e7 100644 ---

Re: [Qemu-devel] [PATCH 1/1] block/vpc.c: Detect too-large vpc file

2011-07-27 Thread Kevin Wolf
Am 26.07.2011 22:26, schrieb Serge E. Hallyn: Quoting Kevin Wolf (kw...@redhat.com): I think that footer-size contains the real size. Maybe we should do something like this: if (footer-size 65536 * 16 * 255 * 512) { bs-total_sectors = footer-size / 512; } else { bs-total_sectors =

Re: [Qemu-devel] [PATCH 3/4] virtio-net: Fix potential use-after-free

2011-07-27 Thread Amit Shah
On (Wed) 27 Jul 2011 [11:43:44], Michael S. Tsirkin wrote: On Wed, Jul 27, 2011 at 02:00:31PM +0530, Amit Shah wrote: virtio_cleanup() will remove the VirtIONet struct that gets allocated via virtio_common_init(). Ensure we don't dereference the structure after calling the cleanup

Re: [Qemu-devel] [PATCH 04/25] Add hard build dependency on glib

2011-07-27 Thread Benjamin Herrenschmidt
You're probably setting up your cross environment incorrectly which, unfortunately, is very common. The proper thing to do is to have GCC use a different system include directory and a different prefix. That will result in a directory where there are gcc binaries with normal names

Re: [Qemu-devel] [RFC][PATCH 0/21] QEMU Object Model

2011-07-27 Thread Paolo Bonzini
On 07/26/2011 09:23 PM, Anthony Liguori wrote: On 07/26/2011 01:26 PM, Paolo Bonzini wrote: On 07/26/2011 05:34 PM, Anthony Liguori wrote: You could just as well say that real life works like this: class PciSocket { PciBus *pci_bus; uint8_t *config; uint8_t *cmask; uint8_t *wmask; uint8_t

Re: [Qemu-devel] [PATCH 1/2] xen_mapcache: remove unused variable

2011-07-27 Thread Stefan Hajnoczi
On Mon, Jul 11, 2011 at 06:15:11PM +0200, Juan Quintela wrote: Signed-off-by: Juan Quintela quint...@redhat.com --- xen-mapcache.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) Since Stefano has acked it but it was not merged into qemu.git yet... Thanks, applied to the

Re: [Qemu-devel] [PATCH 2/4] virtio-blk: Fix memleak on exit

2011-07-27 Thread Kevin Wolf
Am 27.07.2011 10:30, schrieb Amit Shah: Calling virtio_cleanup() will free up memory allocated in virtio_common_init(). Signed-off-by: Amit Shah amit.s...@redhat.com Acked-by: Kevin Wolf kw...@redhat.com

Re: [Qemu-devel] [PATCH 2/2] virtio-balloon: Check if balloon registration failed

2011-07-27 Thread Michael S. Tsirkin
On Wed, Jul 27, 2011 at 12:31:08PM +0530, Amit Shah wrote: Multiple balloon registrations are not allowed; check if the registration with the qemu balloon api succeeded. If not, fail the device init. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/virtio-balloon.c | 10 +-

Re: [Qemu-devel] [PATCH 0/4] Fix virtio memleaks

2011-07-27 Thread Michael S. Tsirkin
On Wed, Jul 27, 2011 at 02:00:28PM +0530, Amit Shah wrote: The memory allocated in virtio_common_init() wasn't being freed anywhere. Fix that. The balloon handler wasn't unregistering its savevm section, adding an exit handler fixes that as well. This patchset is on top of the two

[Qemu-devel] [Bug 816860] [NEW] Guest machine freezes when NFS mount goes offline

2011-07-27 Thread Igor Blanco
Public bug reported: I have a virtual KVM machine that has 2 CDROM units with ISOs mounted from a NFS mount point. When NFS server goes offline the virtual machine blocks completely instead of throwing read errors for the CDROM device. Host: Proxmox VE 1.8-11 (Debian GNU/Linux 5.0) KVM

[Qemu-devel] [PATCH 7/7] xen_mapcache: remove unused variable

2011-07-27 Thread Stefan Hajnoczi
From: Juan Quintela quint...@redhat.com Signed-off-by: Juan Quintela quint...@redhat.com Acked-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- xen-mapcache.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff

[Qemu-devel] [PATCH 6/7] Makefile: add missing deps on $(GENERATED_HEADERS)

2011-07-27 Thread Stefan Hajnoczi
From: Michael Roth mdr...@linux.vnet.ibm.com This fixes a build issue with make -j6+ due to qapi-generated files being built before $(GENERATED_HEADERS) have been created. Tested-by: Stefan Berger stef...@linux.vnet.ibm.com Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com Signed-off-by:

Re: [Qemu-devel] [PATCH] virtio-serial-bus: replay guest_open on migration

2011-07-27 Thread Markus Armbruster
Alon Levy al...@redhat.com writes: On Wed, Jul 27, 2011 at 07:45:25AM +0200, Markus Armbruster wrote: Alon Levy al...@redhat.com writes: Signed-off-by: Alon Levy al...@redhat.com --- hw/virtio-serial-bus.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff

[Qemu-devel] [PATCH 0/6] Add various VMDK subformats support

2011-07-27 Thread Fam Zheng
Add subformats support for: twoGbMaxExtentFlat twoGbMaxExtentSparse streamOptimized Fam Zheng (6): VMDK: enable twoGbMaxExtentFlat VMDK: add twoGbMaxExtentSparse support VMDK: separate vmdk_read_extent/vmdk_write_extent VMDK: Opening compressed extent. VMDK: read/write

[Qemu-devel] [PATCH 1/6] VMDK: enable twoGbMaxExtentFlat

2011-07-27 Thread Fam Zheng
Enable the createType 'twoGbMaxExtentFlat'. The supporting code is already in. Signed-off-by: Fam Zheng famc...@gmail.com --- block/vmdk.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 37478d2..9e6c67a 100644 --- a/block/vmdk.c +++

[Qemu-devel] [PATCH 2/6] VMDK: add twoGbMaxExtentSparse support

2011-07-27 Thread Fam Zheng
Add twoGbMaxExtentSparse support. Only opening code is changed. Signed-off-by: Fam Zheng famc...@gmail.com --- block/vmdk.c | 124 -- 1 files changed, 77 insertions(+), 47 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index

[Qemu-devel] [PATCH 3/6] VMDK: separate vmdk_read_extent/vmdk_write_extent

2011-07-27 Thread Fam Zheng
Factor out read/write extent code, since there will be more things to take care of once reading/writing compressed clusters is introduced. Signed-off-by: Fam Zheng famc...@gmail.com --- block/vmdk.c | 54 +- 1 files changed, 45 insertions(+),

[Qemu-devel] [PATCH 4/6] VMDK: Opening compressed extent.

2011-07-27 Thread Fam Zheng
Added flags field for compressed/streamOptimized extents, open and save image configuration. Signed-off-by: Fam Zheng famc...@gmail.com --- block/vmdk.c | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 0d989f6..5f1638e

[Qemu-devel] [PATCH 5/6] VMDK: read/write compressed extent

2011-07-27 Thread Fam Zheng
Add support for reading/writing compressed extent. Signed-off-by: Fam Zheng famc...@gmail.com --- block/vmdk.c | 115 -- 1 files changed, 103 insertions(+), 12 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 5f1638e..4799aa5

[Qemu-devel] [PATCH 6/6] VMDK: creating streamOptimized subformat

2011-07-27 Thread Fam Zheng
Creating streamOptimized subformat. Added subformat option 'streamOptimized', to create a image with compression enabled and each cluster with a GrainMarker. Signed-off-by: Fam Zheng famc...@gmail.com --- block/vmdk.c | 18 -- 1 files changed, 12 insertions(+), 6 deletions(-)

Re: [Qemu-devel] [PATCH 1/2] pflash: Support read-only mode

2011-07-27 Thread Jan Kiszka
On 2011-07-25 23:34, Jordan Justen wrote: Read-only mode is indicated by bdrv_is_read_only When read-only mode is enabled, no changes will be made to the flash image in memory, and no bdrv_write calls will be made. Signed-off-by: Jordan Justen jordan.l.jus...@intel.com Cc: Jan Kiszka

[Qemu-devel] [PATCH 1/7] vhost build fix for i386

2011-07-27 Thread Stefan Hajnoczi
From: Wolfgang Mauerer wolfgang.maue...@siemens.com vhost.c uses __sync_fetch_and_and(), which is only available for -march=i486 and above (see https://bugzilla.redhat.com/show_bug.cgi?id=624279). Signed-off-by: Wolfgang Mauerer wolfgang.maue...@siemens.com Signed-off-by: Stefan Hajnoczi

[Qemu-devel] [PATCH 5/7] qmp: fix efect - effect typo in qmp-commands.hx

2011-07-27 Thread Stefan Hajnoczi
From: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- qmp-commands.hx |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qmp-commands.hx b/qmp-commands.hx index

Re: [Qemu-devel] [PATCH 2/2] virtio-balloon: Check if balloon registration failed

2011-07-27 Thread Amit Shah
On (Wed) 27 Jul 2011 [12:06:32], Michael S. Tsirkin wrote: On Wed, Jul 27, 2011 at 12:31:08PM +0530, Amit Shah wrote: Multiple balloon registrations are not allowed; check if the registration with the qemu balloon api succeeded. If not, fail the device init. Signed-off-by: Amit Shah

[Qemu-devel] [PATCH 4/7] Makefile: fix out-of-tree builds

2011-07-27 Thread Stefan Hajnoczi
From: Alexandre Raymond cerb...@gmail.com This patch fixes a minor bugs which prevented QEMU from being built out of tree. Signed-off-by: Alexandre Raymond cerb...@gmail.com Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- Makefile |2 +- 1 files changed, 1 insertions(+), 1

Re: [Qemu-devel] [PATCH] user: Restore debug usage message for '-d ?' in user mode emulation

2011-07-27 Thread Peter Maydell
Oops, I forgot to cc Justin when I said should also go into 0.15... -- PMM On 25 July 2011 09:43, Peter Maydell peter.mayd...@linaro.org wrote: Ping? Since this is a regression in our command line handling I think it should also go into 0.15... thanks -- PMM On 18 July 2011 11:44, Peter

[Qemu-devel] [STABLE v2] virtio-serial-bus: replay guest_open on migration

2011-07-27 Thread Alon Levy
When migrating a host with with a spice agent running the mouse becomes non operational after the migration. This is rhbz #725965. The problem is that after migration spice doesn't know the guest agent is open. Spice is just a char dev here. And a chardev cannot query it's device, the device has

[Qemu-devel] [PATCH 2/7] Makefile: Minor cscope fixups

2011-07-27 Thread Stefan Hajnoczi
From: Alexandre Raymond cerb...@gmail.com Create cscope symbols for assembly files in addition to .c/.h files. Create cscope database with full path instead of relative path so cscope can be used with CSCOPE_DB in any directory. Signed-off-by: Alexandre Raymond cerb...@gmail.com Signed-off-by:

Re: [Qemu-devel] [PATCH v8 0/5] Coroutines for better asynchronous programming

2011-07-27 Thread Aneesh Kumar K.V
On Tue, 26 Jul 2011 10:21:12 +0100, Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: QEMU is event-driven and suffers when blocking operations are performed because VM execution may be stopped until the operation completes. Therefore many operations that could block are performed

[Qemu-devel] [PATCH] HMP: Remove the duplicated info info kvm in hmp-commands.hx.

2011-07-27 Thread Zhi Yong Wu
Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- hmp-commands.hx |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index aceba74..3498f0f 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -1324,8 +1324,6 @@ show virtual to

[Qemu-devel] [PATCH 3/7] slirp: Fix unusual comments in unused code

2011-07-27 Thread Stefan Hajnoczi
From: Stefan Weil w...@mail.berlios.de cppcheck detected two rather strange comments which were not correctly written as C comments. They did not cause any harm because they were framed by #ifdef notdef ... #endif, so they were never compiled. Fix them nevertheless (we could also remove the

Re: [Qemu-devel] [PATCH v8 0/5] Coroutines for better asynchronous programming

2011-07-27 Thread Kevin Wolf
Am 27.07.2011 11:45, schrieb Aneesh Kumar K.V: On Tue, 26 Jul 2011 10:21:12 +0100, Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: QEMU is event-driven and suffers when blocking operations are performed because VM execution may be stopped until the operation completes. Therefore many

[Qemu-devel] [PULL 0/7] Trivial patches for June 25 to July 27 2011

2011-07-27 Thread Stefan Hajnoczi
The following changes since commit c886edfb851c0c590d4e77f058f2ec8ed95ad1b5: Let users select their pythons (2011-07-25 16:50:12 +) are available in the git repository at: ssh://repo.or.cz/srv/git/qemu/stefanha.git trivial-patches Alexandre Raymond (2): Makefile: Minor cscope

[Qemu-devel] [PATCH v7] showing a splash picture when start

2011-07-27 Thread Wayne Xia
From: wayne xiaw...@linux.vnet.ibm.com Added options to let qemu transfer two configuration files to bios: bootsplash.bmp and etc/boot-menu-wait, which could be specified by command -boot splash=P,splash-time=T P is jpg/bmp file name or an absolute path, T have a max value of 0x, unit

Re: [Qemu-devel] [PATCH v6] showing a splash picture when start

2011-07-27 Thread Wayne Xia
Thanks, following is my comments. On 07/10/2011 05:09 AM, Wayne Xia wrote: Added options to let qemu transfer two configuration files to bios: bootsplash.bmp and etc/boot-menu-wait, which could be specified by command -boot splash=P,splash-time=T P is jpg/bmp file name or an absolute path, T

Re: [Qemu-devel] [PATCH 2/2] [SLIRP] Delayed IP packets

2011-07-27 Thread Fabien Chouteau
On 27/07/2011 11:30, Jan Kiszka wrote: On 2011-07-26 18:21, Fabien Chouteau wrote: In the current implementation, if Slirp tries to send an IP packet to a client with an unknown hardware address, the packet is simply dropped and an ARP request is sent (if_encap in slirp/slirp.c). This

Re: [Qemu-devel] [PATCH 0/4] Fix virtio memleaks

2011-07-27 Thread Amit Shah
On (Wed) 27 Jul 2011 [12:08:52], Michael S. Tsirkin wrote: On Wed, Jul 27, 2011 at 02:00:28PM +0530, Amit Shah wrote: The memory allocated in virtio_common_init() wasn't being freed anywhere. Fix that. The balloon handler wasn't unregistering its savevm section, adding an exit handler

Re: [Qemu-devel] [PATCH v2 1/1] The codes V2 for QEMU disk I/O limits.

2011-07-27 Thread Zhi Yong Wu
On Wed, Jul 27, 2011 at 3:26 AM, Marcelo Tosatti mtosa...@redhat.com wrote: On Tue, Jul 26, 2011 at 04:59:06PM +0800, Zhi Yong Wu wrote: Welcome to give me your comments, thanks. Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com ---  Makefile.objs     |    2 +-  block.c           |  288

Re: [Qemu-devel] [PATCH] virtio-serial-bus: replay guest_open on migration

2011-07-27 Thread Amit Shah
On (Wed) 27 Jul 2011 [10:07:56], Alon Levy wrote: On Wed, Jul 27, 2011 at 07:45:25AM +0200, Markus Armbruster wrote: Alon Levy al...@redhat.com writes: Signed-off-by: Alon Levy al...@redhat.com --- hw/virtio-serial-bus.c |8 +++- 1 files changed, 7 insertions(+), 1

Re: [Qemu-devel] [PATCH 2/2] [SLIRP] Delayed IP packets

2011-07-27 Thread Jan Kiszka
On 2011-07-27 12:14, Fabien Chouteau wrote: On 27/07/2011 11:30, Jan Kiszka wrote: On 2011-07-26 18:21, Fabien Chouteau wrote: In the current implementation, if Slirp tries to send an IP packet to a client with an unknown hardware address, the packet is simply dropped and an ARP request is

Re: [Qemu-devel] [PATCH 1/2] [SLIRP] Simple ARP table

2011-07-27 Thread Jan Kiszka
On 2011-07-26 18:21, Fabien Chouteau wrote: This patch adds a simple ARP table in Slirp and also adds handling of gratuitous ARP requests. Signed-off-by: Fabien Chouteau chout...@adacore.com --- Makefile.objs |2 +- slirp/arp_table.c | 61

Re: [Qemu-devel] [PATCH] virtio-serial-bus: replay guest_open on migration

2011-07-27 Thread Alon Levy
On Wed, Jul 27, 2011 at 03:50:11PM +0530, Amit Shah wrote: On (Wed) 27 Jul 2011 [10:07:56], Alon Levy wrote: On Wed, Jul 27, 2011 at 07:45:25AM +0200, Markus Armbruster wrote: Alon Levy al...@redhat.com writes: Signed-off-by: Alon Levy al...@redhat.com ---

[Qemu-devel] [V5 Patch 1/4]Qemu: Enhance info block to display host cache setting

2011-07-27 Thread Supriya Kannery
Enhance info block to display hostcache setting for each block device. Example: (qemu) info block ide0-hd0: type=hd removable=0 file=../rhel6-32.qcow2 ro=0 drv=qcow2 encrypted=0 Enhanced to display hostcache setting: (qemu) info block ide0-hd0: type=hd removable=0 hostcache=true

[Qemu-devel] [V5 Patch 2/4]Qemu: qerrors for file reopen, data sync and cmd syntax

2011-07-27 Thread Supriya Kannery
New error classes defined for file reopen failure, data sync error and incorrect command syntax Signed-off-by: Supriya Kannery supri...@in.ibm.com --- qerror.c | 12 qerror.h |8 2 files changed, 20 insertions(+) Index: qemu/qerror.c

[Qemu-devel] [V5 Patch 3/4]Qemu: Command block_set for dynamic block params change

2011-07-27 Thread Supriya Kannery
New command block_set added for dynamically changing any of the block device parameters. For now, dynamic setting of hostcache params using this command is implemented. Other block device parameter changes, can be integrated in similar lines. Signed-off-by: Supriya Kannery supri...@in.ibm.com

[Qemu-devel] [V5 Patch 4/4]Qemu: Add commandline -drive option 'hostcache'

2011-07-27 Thread Supriya Kannery
qemu command option 'hostcache' added to -drive for block devices. While starting a VM from qemu commandline, this option can be used for setting host cache usage for block data access. It is not allowed to specify both 'hostcache' and 'cache' options in the same commandline. User has to

[Qemu-devel] [V5 Patch 0/4]Qemu: Set host cache from cmdline and monitor

2011-07-27 Thread Supriya Kannery
Currently cache setting of a block device cannot be changed without restarting a running VM. Following patchset is for enabling dynamic change of host cache setting for block devices through qemu monitor. Code changes are based on patches from Christoph Hellwig and Prerna Saxena. This

Re: [Qemu-devel] [PATCH] Fix configure display for non-Linux OS's and the KVM / vhost-net features to show no

2011-07-27 Thread Jan Kiszka
On 2011-07-27 05:11, Brad wrote: diff --git a/configure b/configure index dc9a1fe..ef8a4c8 100755 --- a/configure +++ b/configure @@ -113,7 +113,6 @@ curl= curses= docs= fdt= -kvm= nptl= sdl= vnc=yes @@ -129,9 +128,10 @@ xen= xen_ctrl_version= linux_aio= attr= -vhost_net=

Re: [Qemu-devel] [PATCH v8 0/5] Coroutines for better asynchronous programming

2011-07-27 Thread Aneesh Kumar K.V
On Wed, 27 Jul 2011 15:15:20 +0530, Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com wrote: On Tue, 26 Jul 2011 10:21:12 +0100, Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: QEMU is event-driven and suffers when blocking operations are performed because VM execution may be stopped

Re: [Qemu-devel] [PATCH v8 0/5] Coroutines for better asynchronous programming

2011-07-27 Thread Aneesh Kumar K.V
On Wed, 27 Jul 2011 12:03:57 +0200, Kevin Wolf kw...@redhat.com wrote: Am 27.07.2011 11:45, schrieb Aneesh Kumar K.V: On Tue, 26 Jul 2011 10:21:12 +0100, Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: QEMU is event-driven and suffers when blocking operations are performed because

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Fix configure display for non-Linux OS's and the KVM / vhost-net features to show no

2011-07-27 Thread Stefan Hajnoczi
On Wed, Jul 27, 2011 at 12:24 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2011-07-27 05:11, Brad wrote: diff --git a/configure b/configure index dc9a1fe..ef8a4c8 100755 --- a/configure +++ b/configure @@ -113,7 +113,6 @@ curl=  curses=  docs=  fdt= -kvm=  nptl=  sdl=  vnc=yes @@

Re: [Qemu-devel] [PATCH] HMP: Remove the duplicated info info kvm in hmp-commands.hx.

2011-07-27 Thread Stefan Hajnoczi
On Wed, Jul 27, 2011 at 10:48 AM, Zhi Yong Wu wu...@linux.vnet.ibm.com wrote: Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com ---  hmp-commands.hx |    2 --  1 files changed, 0 insertions(+), 2 deletions(-) Thanks, will add to the next trivial-patches pull request. Stefan

[Qemu-devel] [PATCH 1/1] balloon: Ignore negative balloon values

2011-07-27 Thread Amit Shah
Negative balloon values don't make sense, ignore them. Reported-by: Mike Cao b...@redhat.com Signed-off-by: Amit Shah amit.s...@redhat.com --- I'm not sure if error_report is the right thing to use or should a new qerror_report() be used. Luiz, comments? balloon.c |8 +++- 1 files

[Qemu-devel] [ANNOUNCE] xen-stable-0.15 qemu branch

2011-07-27 Thread Stefano Stabellini
Hi all, you might have noticed that there is a number of Xen patches to Qemu floating around and it is difficul to keep track of them for both Qemu and Xen maintainers. For this reason I have setup a git branch to collect them all in a single place:

Re: [Qemu-devel] [Bug 816860] [NEW] Guest machine freezes when NFS mount goes offline

2011-07-27 Thread Stefan Hajnoczi
On Wed, Jul 27, 2011 at 10:09 AM, Igor Blanco 816...@bugs.launchpad.net wrote: Public bug reported: I have a virtual KVM machine that has 2 CDROM units with ISOs mounted from a NFS mount point. When NFS server goes offline the virtual machine blocks completely instead of throwing read errors

Re: [Qemu-devel] [PATCH] virtio-serial-bus: replay guest_open on migration

2011-07-27 Thread Amit Shah
On (Wed) 27 Jul 2011 [14:09:45], Alon Levy wrote: Also, we'll be lying that a guest opened, since a guest was opened much earlier, before migration. Nothing has changed as far as the guest is concerned, this is just some host-side tracking that has to be done post-migrate, which belongs

Re: [Qemu-devel] [PATCH v8 0/5] Coroutines for better asynchronous programming

2011-07-27 Thread Kevin Wolf
Am 27.07.2011 13:39, schrieb Aneesh Kumar K.V: Can you review the patch that add CoRWlock ? http://article.gmane.org/gmane.comp.emulators.qemu/105402 Message-id:1307382497-3737-2-git-send-email-aneesh.ku...@linux.vnet.ibm.com commit 8c787d8b81aca1f4f7be45adb67b9e1a6dde7f1f Author: Aneesh

Re: [Qemu-devel] [PATCH v5 01/18] Add hard build dependency on glib

2011-07-27 Thread Kenneth Salerno
--- On Tue, 7/26/11, Kenneth Salerno kennethsale...@yahoo.com wrote: From: Kenneth Salerno kennethsale...@yahoo.com Subject: Re: [Qemu-devel] [PATCH v5 01/18] Add hard build dependency on glib To: qemu-devel@nongnu.org Date: Tuesday, July 26, 2011, 10:02 AM From:     Michael Roth Subject:  

Re: [Qemu-devel] [PATCH] virtio-serial-bus: replay guest_open on migration

2011-07-27 Thread Alon Levy
On Wed, Jul 27, 2011 at 05:35:28PM +0530, Amit Shah wrote: On (Wed) 27 Jul 2011 [14:09:45], Alon Levy wrote: Also, we'll be lying that a guest opened, since a guest was opened much earlier, before migration. Nothing has changed as far as the guest is concerned, this is just some

[Qemu-devel] Block layer roadmap

2011-07-27 Thread Stefan Hajnoczi
Hi, Here is a list of block layer and storage changes that have been discussed. It is useful to have a roadmap of changes in order to avoid duplication, allow more developers to contribute, and to communicate the direction of storage in QEMU. I suggest we first do a braindump of all changes that

Re: [Qemu-devel] [PATCH RESEND v3] xen: implement unplug protocol in xen_platform

2011-07-27 Thread Alexander Graf
On 07/18/2011 06:07 PM, stefano.stabell...@eu.citrix.com wrote: From: Stefano Stabellinistefano.stabell...@eu.citrix.com The unplug protocol is necessary to support PV drivers in the guest: the drivers expect to be able to unplug emulated disks and nics before initializing the Xen PV

Re: [Qemu-devel] [RFC][PATCH 0/21] QEMU Object Model

2011-07-27 Thread Anthony Liguori
On 07/27/2011 03:55 AM, Paolo Bonzini wrote: Yes, this looks nice (modulo s/Rtl8139/Rtl8139 */). But it is not that much more flexible than qdev 1.0. You're right that for the case of two parents above we were looking at a contrived example. The Goldfish platform provides a more interesting

Re: [Qemu-devel] Block layer roadmap

2011-07-27 Thread Anthony Liguori
On 07/27/2011 07:37 AM, Stefan Hajnoczi wrote: Hi, Here is a list of block layer and storage changes that have been discussed. It is useful to have a roadmap of changes in order to avoid duplication, allow more developers to contribute, and to communicate the direction of storage in QEMU.

Re: [Qemu-devel] [PATCH V2 3/3] vl.c: Check the asked ram_size later.

2011-07-27 Thread Alexander Graf
On 07/20/2011 08:17 PM, Anthony PERARD wrote: As a Xen guest can have more than 2GB of RAM on a 32bit host, we move the conditions after than we now if we run one Xen or not. Signed-off-by: Anthony PERARDanthony.per...@citrix.com --- vl.c | 14 -- 1 files changed, 8

Re: [Qemu-devel] [PATCH RESEND v3] xen: implement unplug protocol in xen_platform

2011-07-27 Thread Kevin Wolf
Am 27.07.2011 14:44, schrieb Alexander Graf: On 07/18/2011 06:07 PM, stefano.stabell...@eu.citrix.com wrote: From: Stefano Stabellinistefano.stabell...@eu.citrix.com The unplug protocol is necessary to support PV drivers in the guest: the drivers expect to be able to unplug emulated disks and

Re: [Qemu-devel] [PATCH 1/2] [SLIRP] Simple ARP table

2011-07-27 Thread Fabien Chouteau
On 27/07/2011 12:49, Jan Kiszka wrote: On 2011-07-26 18:21, Fabien Chouteau wrote: This patch adds a simple ARP table in Slirp and also adds handling of gratuitous ARP requests. Signed-off-by: Fabien Chouteau chout...@adacore.com --- Makefile.objs |2 +- slirp/arp_table.c | 61

Re: [Qemu-devel] [PATCH V2 0/3] Enable QEMU to handle more than 2GB with Xen.

2011-07-27 Thread Alexander Graf
On 07/20/2011 08:17 PM, Anthony PERARD wrote: Hi all, Update on this series: - Use a RAM address of 64bits only on 64bits targets when Xen is enable. - Add some comment on the memory registration done for Xen. Xen is not limited by the QEMU's virtual address space for the allocation of

Re: [Qemu-devel] [PATCH v2 1/1] The codes V2 for QEMU disk I/O limits.

2011-07-27 Thread Stefan Hajnoczi
On Wed, Jul 27, 2011 at 11:17 AM, Zhi Yong Wu zwu.ker...@gmail.com wrote: On Wed, Jul 27, 2011 at 3:26 AM, Marcelo Tosatti mtosa...@redhat.com wrote: On Tue, Jul 26, 2011 at 04:59:06PM +0800, Zhi Yong Wu wrote: Welcome to give me your comments, thanks. Signed-off-by: Zhi Yong Wu

Re: [Qemu-devel] [V5 Patch 3/4]Qemu: Command block_set for dynamic block params change

2011-07-27 Thread Anthony Liguori
On 07/27/2011 06:30 AM, Supriya Kannery wrote: New command block_set added for dynamically changing any of the block device parameters. For now, dynamic setting of hostcache params using this command is implemented. Other block device parameter changes, can be integrated in similar lines.

Re: [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-07-27 Thread Corey Bryant
On 07/27/2011 04:43 AM, Daniel P. Berrange wrote: On Wed, Jul 27, 2011 at 10:36:25AM +0200, Kevin Wolf wrote: Am 27.07.2011 10:22, schrieb Daniel P. Berrange: On Wed, Jul 27, 2011 at 10:11:06AM +0200, Kevin Wolf wrote: Am 26.07.2011 18:57, schrieb Corey Bryant: diff --git a/block/cow.c

Re: [Qemu-devel] [PATCH 04/25] Add hard build dependency on glib

2011-07-27 Thread Yoder Stuart-B08248
-Original Message- From: Anthony Liguori [mailto:aligu...@us.ibm.com] Sent: Tuesday, July 26, 2011 5:10 PM To: Yoder Stuart-B08248 Cc: qemu-devel@nongnu.org Subject: Re: [PATCH 04/25] Add hard build dependency on glib On 07/26/2011 04:51 PM, Yoder Stuart-B08248 wrote: I am

Re: [Qemu-devel] qemu crashes on Mac OS X

2011-07-27 Thread Damjan Marion
Hi Alexandre, I tried your patch and it works OK. Then I tried without it and seems that it also works ok. It might be 2 reasons: - I upgraded to Mac OS X 10.7 Lion - Something changed in qemu master branch I dont remember what was exact version I used when I reported this problem. Thanks,

[Qemu-devel] [PULL 0/7] ARM patch queue (for master)

2011-07-27 Thread Peter Maydell
This is a pull request for various outstanding ARM related patches; they've been on the list for a week or so. Some of these are bug fixes which I want to get into 0.15; I'm going to do a parallel pullreq for the 0.15 patches. Thanks -- PMM The following changes since commit

[Qemu-devel] [PATCH 7/7] target-arm: Don't print debug messages for various UNDEF cases

2011-07-27 Thread Peter Maydell
Remove some stray printfs for cases which don't generally happen (some VFP UNDEF cases, reads and writes to unknown cp14 registers); we should simply generate an UNDEF when the instruction is executed. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-arm/translate.c |6 --

Re: [Qemu-devel] [PATCH RESEND v3] xen: implement unplug protocol in xen_platform

2011-07-27 Thread Alexander Graf
On 07/27/2011 02:58 PM, Kevin Wolf wrote: Am 27.07.2011 14:44, schrieb Alexander Graf: On 07/18/2011 06:07 PM, stefano.stabell...@eu.citrix.com wrote: From: Stefano Stabellinistefano.stabell...@eu.citrix.com The unplug protocol is necessary to support PV drivers in the guest: the drivers

[Qemu-devel] [PATCH 5/9] xen: make xen_enabled even more clever

2011-07-27 Thread Alexander Graf
When using xen_enabled() we're currently only checking if xen is enabled at all during the build. But what if you want to build multiple targets out of which only one can potentially run xen code? That means that for generic code we'll still have to fall back to the variable and potentially slow

[Qemu-devel] [PATCH 6/9] cpu-common: Have a ram_addr_t of uint64 with Xen.

2011-07-27 Thread Alexander Graf
From: Anthony PERARD anthony.per...@citrix.com In Xen case, memory can be bigger than the host memory. that mean a 32bits host (and QEMU) should be able to handle a RAM address of 64bits. Signed-off-by: Anthony PERARD anthony.per...@citrix.com Signed-off-by: Alexander Graf ag...@suse.de ---

[Qemu-devel] [PATCH 1/9] xen: introduce xen_change_state_handler

2011-07-27 Thread Alexander Graf
From: Anthony PERARD anthony.per...@citrix.com Remove the call to xenstore_record_dm_state from xen_main_loop_prepare that is HVM specific. Add a new vm_change_state_handler shared between xen_pv and xen_hvm machines to record the VM state to xenstore. Signed-off-by: Anthony PERARD

[Qemu-devel] [PATCH 8/9] vl.c: Check the asked ram_size later.

2011-07-27 Thread Alexander Graf
From: Anthony PERARD anthony.per...@citrix.com As a Xen guest can have more than 2GB of RAM on a 32bit host, we move the conditions after than we now if we run one Xen or not. [agraf] separate xen branch from ram_size check Signed-off-by: Anthony PERARD anthony.per...@citrix.com Signed-off-by:

[Qemu-devel] [PATCH 2/9] xen: Fix xen_enabled().

2011-07-27 Thread Alexander Graf
From: Anthony PERARD anthony.per...@citrix.com Use the host CONFIG_ define instead of the target one. Signed-off-by: Anthony PERARD anthony.per...@citrix.com Acked-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Alexander Graf ag...@suse.de --- hw/xen.h |2 +- 1 files changed, 1

Re: [Qemu-devel] [PATCH 04/25] Add hard build dependency on glib

2011-07-27 Thread David Gibson
On Wed, Jul 27, 2011 at 06:54:09PM +1000, Benjamin Herrenschmidt wrote: You're probably setting up your cross environment incorrectly which, unfortunately, is very common. The proper thing to do is to have GCC use a different system include directory and a different prefix. That

  1   2   3   >