[Qemu-devel] [PATCH v2 0/5] balloon: fix memleaks, invalid arguments, unplug

2011-07-28 Thread Amit Shah
Hello, This series is on top of the other balloon series for which I sent a pull request on Tuesday. This series fixes memleak on exit, unregisters the savevm section on unplug, disallows negative values as ballooning targets and doesn't allow multiple balloon device registrations. v2 contains

[Qemu-devel] [PATCH v2 2/5] virtio-balloon: Check if balloon registration failed

2011-07-28 Thread Amit Shah
Multiple balloon registrations are not allowed; check if the registration with the qemu balloon api succeeded. If not, fail the device init. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/virtio-balloon.c |9 - hw/virtio-pci.c |3 +++ 2 files changed, 11 insertions(+),

Re: [Qemu-devel] [PATCH v2 4/5] virtio-balloon: Add exit handler, fix memleaks

2011-07-28 Thread Amit Shah
On (Thu) 28 Jul 2011 [11:47:15], Amit Shah wrote: Add an exit handler that will free up RAM and unregister the savevm section after a virtio-balloon device is unplugged. This commit message should be changed; I'll do that in the pull request I send out. Amit

[Qemu-devel] [PATCH v2 5/5] virtio-balloon: Unregister savevm section on device unplug

2011-07-28 Thread Amit Shah
Migrating after unplugging a virtio-balloon device resulted in an error message on the destination: Unknown savevm section or instance ':00:04.0/virtio-balloon' 0 load of migration failed Fix this by unregistering the section on device unplug. Signed-off-by: Amit Shah amit.s...@redhat.com

[Qemu-devel] [PATCH v2 3/5] balloon: Ignore negative balloon values

2011-07-28 Thread Amit Shah
Negative balloon values don't make sense, ignore them. Reported-by: Mike Cao b...@redhat.com Signed-off-by: Amit Shah amit.s...@redhat.com --- balloon.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/balloon.c b/balloon.c index 5200565..f56fdc1 100644 ---

[Qemu-devel] [PATCH v2 4/5] virtio-balloon: Add exit handler, fix memleaks

2011-07-28 Thread Amit Shah
Add an exit handler that will free up RAM and unregister the savevm section after a virtio-balloon device is unplugged. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/virtio-balloon.c |5 + hw/virtio-pci.c | 11 ++- hw/virtio.h |1 + 3 files changed, 16

[Qemu-devel] [PATCH v2 1/5] balloon: Don't allow multiple balloon handler registrations

2011-07-28 Thread Amit Shah
Multiple balloon devices don't make sense; disallow more than one registration attempt to register handlers. Signed-off-by: Amit Shah amit.s...@redhat.com --- balloon.c | 12 ++-- balloon.h |4 ++-- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/balloon.c

[Qemu-devel] [Bug 524447] Re: virsh save is very slow

2011-07-28 Thread Michael Tokarev
I see activity around this bug is going on and on, but I don't understand -- is the talk about this patch -- http://anonscm.debian.org/gitweb/?p=collab-maint/qemu-kvm.git;a=commit;h=7e32b4ca0ea280a2e8f4d9ace1a15d5e633d9a95 ? -- You received this bug notification because you are a member of

Re: [Qemu-devel] [RFC] Introduce vm_stop_permanent()

2011-07-28 Thread Avi Kivity
On 07/28/2011 12:44 AM, Blue Swirl wrote: On Wed, Jul 27, 2011 at 9:42 PM, Luiz Capitulinolcapitul...@redhat.com wrote: This function should be used when the VM is not supposed to resume execution (eg. by issuing 'cont' monitor command). Today, we allow the user to resume execution even

Re: [Qemu-devel] [PATCH v2] pci: Common overflow prevention

2011-07-28 Thread Isaku Yamahata
This might be a bit late comment... On Fri, Jul 22, 2011 at 11:05:01AM +0200, Jan Kiszka wrote: diff --git a/hw/pci_host.c b/hw/pci_host.c index 728e2d4..bfdc321 100644 --- a/hw/pci_host.c +++ b/hw/pci_host.c @@ -47,17 +47,33 @@ static inline PCIDevice *pci_dev_find_by_addr(PCIBus *bus,

Re: [Qemu-devel] [PATCH v2 3/5] balloon: Ignore negative balloon values

2011-07-28 Thread Markus Armbruster
Amit Shah amit.s...@redhat.com writes: Negative balloon values don't make sense, ignore them. Actually, they aren't ignored, they're rejected.

Re: [Qemu-devel] [PATCH v2 4/5] virtio-balloon: Add exit handler, fix memleaks

2011-07-28 Thread Markus Armbruster
Amit Shah amit.s...@redhat.com writes: Add an exit handler that will free up RAM and unregister the savevm section after a virtio-balloon device is unplugged. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/virtio-balloon.c |5 + hw/virtio-pci.c | 11 ++-

Re: [Qemu-devel] [RFC][PATCH 0/21] QEMU Object Model

2011-07-28 Thread Paolo Bonzini
On 07/27/2011 10:01 PM, Anthony Liguori wrote: That's milkymist, not GoldFish. Oh, Goldfish is fake. It's not real hardware. The enumerator device is not a real device. It's weird because it's imaginary and was designed specifically within QEMU. It's not a good example for discussing

Re: [Qemu-devel] [PATCH v2 4/5] virtio-balloon: Add exit handler, fix memleaks

2011-07-28 Thread Markus Armbruster
Amit Shah amit.s...@redhat.com writes: On (Thu) 28 Jul 2011 [11:47:15], Amit Shah wrote: Add an exit handler that will free up RAM and unregister the savevm section after a virtio-balloon device is unplugged. This commit message should be changed; I'll do that in the pull request I send

[Qemu-devel] [PATCH 0/8] qcow2 cleanup for coroutine-block branch

2011-07-28 Thread Frediano Ziglio
This is a collection of patches that remove QCowAIOCB, useless with coroutines. It apply to Kevin coroutine-block branch. I leave all step I did to remove the structure, feel free to collapse some of them. I tested with iotests and got no changes (026 fails like coroutine-block branch). Frediano

[Qemu-devel] [PATCH 1/8] qcow2: removed unused fields

2011-07-28 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio fredd...@gmail.com --- block/qcow2.c | 10 +++--- 1 files changed, 3 insertions(+), 7 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index edc068e..5c454bb 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -381,11 +381,8 @@ typedef struct QCowAIOCB

[Qemu-devel] [PATCH 2/8] qcow2: removed cur_nr_sectors field in QCowAIOCB

2011-07-28 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio fredd...@gmail.com --- block/qcow2.c | 98 + 1 files changed, 43 insertions(+), 55 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 5c454bb..0cf4465 100644 --- a/block/qcow2.c +++

[Qemu-devel] [PATCH 3/8] qcow2: remove l2meta from QCowAIOCB

2011-07-28 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio fredd...@gmail.com --- block/qcow2.c | 15 --- 1 files changed, 8 insertions(+), 7 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 0cf4465..adf31ce 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -381,7 +381,6 @@ typedef struct

[Qemu-devel] [PATCH 8/8] qcow2: remove memory leak

2011-07-28 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio fredd...@gmail.com --- block/qcow2.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 6073568..aed8da7 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -492,6 +492,7 @@ fail:

Re: [Qemu-devel] [PATCH 1/2] linux aio: support flush operation

2011-07-28 Thread Kevin Wolf
Am 27.07.2011 21:57, schrieb Christoph Hellwig: On Wed, Jul 27, 2011 at 09:52:51PM +0200, Frediano Ziglio wrote: Also I notice that combining XFS, Linux AIO, O_DIRECT and O_DSYNC give impressive performance but currently there is no way to specify all that flags together cause nocache enable

Re: [Qemu-devel] [PATCH v2 5/5] virtio-balloon: Unregister savevm section on device unplug

2011-07-28 Thread Markus Armbruster
Amit Shah amit.s...@redhat.com writes: Migrating after unplugging a virtio-balloon device resulted in an error message on the destination: Unknown savevm section or instance ':00:04.0/virtio-balloon' 0 load of migration failed Fix this by unregistering the section on device unplug.

Re: [Qemu-devel] [PATCH v2 0/5] balloon: fix memleaks, invalid arguments, unplug

2011-07-28 Thread Markus Armbruster
Amit Shah amit.s...@redhat.com writes: Hello, This series is on top of the other balloon series for which I sent a pull request on Tuesday. This series fixes memleak on exit, unregisters the savevm section on unplug, disallows negative values as ballooning targets and doesn't allow

[Qemu-devel] [PATCH 7/8] qcow2: removed QCowAIOCB entirely

2011-07-28 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio fredd...@gmail.com --- block/qcow2.c | 207 ++--- 1 files changed, 80 insertions(+), 127 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index dfb969e..6073568 100644 --- a/block/qcow2.c +++

[Qemu-devel] [PATCH 4/8] qcow2: remove cluster_offset from QCowAIOCB

2011-07-28 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio fredd...@gmail.com --- block/qcow2.c | 22 +++--- 1 files changed, 11 insertions(+), 11 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index adf31ce..446946e 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -378,7 +378,6 @@ typedef

Re: [Qemu-devel] RFC: moving fsfreeze support from the userland guest agent to the guest kernel

2011-07-28 Thread Andrea Arcangeli
On Thu, Jul 28, 2011 at 11:53:50AM +0900, Fernando Luis Vázquez Cao wrote: On Wed, 2011-07-27 at 17:24 +0200, Andrea Arcangeli wrote: making sure no lib is calling any I/O function to be able to defreeze the filesystems later, making sure the oom killer or a wrong kill -9 $RANDOM isn't

[Qemu-devel] Volume key in qcow3?

2011-07-28 Thread Frediano Ziglio
Hi, I noted that AES encryption using qcow2 just use the password given as as key (and also truncating it to 16 bytes == 128 bits). This is prone to brute force attacks and is not also easy to change password (you have to decrypt and encrypt again the entire image). LUKS and EncFS use another

Re: [Qemu-devel] [PATCH 00/55] Block layer cleanup fixes

2011-07-28 Thread Kevin Wolf
Am 20.07.2011 18:23, schrieb Markus Armbruster: This patch series looks bigger than it is. All the patches are small and hopefully easy to review. Objectives: * Push BlockDriverState members locked, tray_open, media_changed into device models, where they belong. * BlockDriverState

[Qemu-devel] [PATCH 5/8] qcow2: remove common from QCowAIOCB

2011-07-28 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio fredd...@gmail.com --- block/qcow2.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 446946e..c7445cc 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -373,7 +373,7 @@ int

Re: [Qemu-devel] [PATCH v5] Add support for Zipit Z2 machine

2011-07-28 Thread Vasily Khoruzhick
On Monday 11 July 2011 18:26:37 Vasily Khoruzhick wrote: On Wednesday 06 July 2011 16:52:49 Vasily Khoruzhick wrote: Zipit Z2 is small PXA270 based handheld. Ping? One more ping.

Re: [Qemu-devel] [PATCH v2 1/1] The codes V2 for QEMU disk I/O limits.

2011-07-28 Thread Stefan Hajnoczi
On Thu, Jul 28, 2011 at 6:43 AM, Zhi Yong Wu zwu.ker...@gmail.com wrote: On Wed, Jul 27, 2011 at 8:58 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Wed, Jul 27, 2011 at 11:17 AM, Zhi Yong Wu zwu.ker...@gmail.com wrote: On Wed, Jul 27, 2011 at 3:26 AM, Marcelo Tosatti mtosa...@redhat.com

[Qemu-devel] [PATCH 6/8] qcow2: reindent and use while before the big jump

2011-07-28 Thread Frediano Ziglio
prepare to remove read/write callbacks Signed-off-by: Frediano Ziglio fredd...@gmail.com --- block/qcow2.c | 272 - 1 files changed, 135 insertions(+), 137 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index c7445cc..dfb969e

Re: [Qemu-devel] [PATCH v2 1/1] The codes V2 for QEMU disk I/O limits.

2011-07-28 Thread Stefan Hajnoczi
On Thu, Jul 28, 2011 at 9:20 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Thu, Jul 28, 2011 at 6:43 AM, Zhi Yong Wu zwu.ker...@gmail.com wrote: On Wed, Jul 27, 2011 at 8:58 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Wed, Jul 27, 2011 at 11:17 AM, Zhi Yong Wu zwu.ker...@gmail.com

Re: [Qemu-devel] [PATCH v2] pci: Common overflow prevention

2011-07-28 Thread Michael S. Tsirkin
On Thu, Jul 28, 2011 at 04:23:24PM +0900, Isaku Yamahata wrote: This might be a bit late comment... On Fri, Jul 22, 2011 at 11:05:01AM +0200, Jan Kiszka wrote: diff --git a/hw/pci_host.c b/hw/pci_host.c index 728e2d4..bfdc321 100644 --- a/hw/pci_host.c +++ b/hw/pci_host.c @@ -47,17

Re: [Qemu-devel] [PATCH] add QEMU_LD_PREFIX environment variable

2011-07-28 Thread Riku Voipio
On Sat, Jul 23, 2011 at 07:47:49AM +0200, josch wrote: This could be avoided by setting the proposed environment variable QEMU_LD_PREFIX to the just created debian rootfs. As mentioned earlier, the usage of the -L option is not possible in this scenario because qemu-user is only implicitly

Re: [Qemu-devel] [PATCH v2 0/5] balloon: fix memleaks, invalid arguments, unplug

2011-07-28 Thread Michael S. Tsirkin
On Thu, Jul 28, 2011 at 11:47:11AM +0530, Amit Shah wrote: Hello, This series is on top of the other balloon series for which I sent a pull request on Tuesday. This series fixes memleak on exit, unregisters the savevm section on unplug, disallows negative values as ballooning targets and

Re: [Qemu-devel] [PATCH v2 1/1] The codes V2 for QEMU disk I/O limits.

2011-07-28 Thread Zhi Yong Wu
On Thu, Jul 28, 2011 at 4:25 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Thu, Jul 28, 2011 at 9:20 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Thu, Jul 28, 2011 at 6:43 AM, Zhi Yong Wu zwu.ker...@gmail.com wrote: On Wed, Jul 27, 2011 at 8:58 PM, Stefan Hajnoczi stefa...@gmail.com

Re: [Qemu-devel] RFC: moving fsfreeze support from the userland guest agent to the guest kernel

2011-07-28 Thread Jes Sorensen
On 07/27/11 18:40, Andrea Arcangeli wrote: Another thing to note is that snapshotting is not necessarily something that should be completely transparent to the guest. One of the planned future features for the guest agent (mentioned in the snapshot wiki, and a common use case that I've

Re: [Qemu-devel] RFC: moving fsfreeze support from the userland guest agent to the guest kernel

2011-07-28 Thread Jes Sorensen
On 07/27/11 20:36, Christoph Hellwig wrote: Initiating the freeze from kernelspace doesn't make much sense. With virtio we could add in-band freeze request to the protocol, and although that would be a major change in that way virtio-blk works right now it's at least doable. But all other

Re: [Qemu-devel] [V5 Patch 3/4]Qemu: Command block_set for dynamic block params change

2011-07-28 Thread Stefan Hajnoczi
On Wed, Jul 27, 2011 at 5:02 PM, Anthony Liguori anth...@codemonkey.ws wrote: On 07/27/2011 09:31 AM, Stefan Hajnoczi wrote: On Wed, Jul 27, 2011 at 1:58 PM, Anthony Liguorianth...@codemonkey.ws  wrote: Index: qemu/hmp-commands.hx

Re: [Qemu-devel] [PATCH 00/55] Block layer cleanup fixes

2011-07-28 Thread Amit Shah
On (Wed) 20 Jul 2011 [18:23:34], Markus Armbruster wrote: This patch series looks bigger than it is. All the patches are small and hopefully easy to review. Nice series! ACK the entire series (barring the non-qdev users connecting to bdrv and scsi patches, which I didn't quite follow).

Re: [Qemu-devel] [PATCH v2 3/5] balloon: Ignore negative balloon values

2011-07-28 Thread Amit Shah
On (Thu) 28 Jul 2011 [09:31:53], Markus Armbruster wrote: Amit Shah amit.s...@redhat.com writes: Negative balloon values don't make sense, ignore them. Actually, they aren't ignored, they're rejected. Will update commit log. Amit

Re: [Qemu-devel] [PATCH v2 4/5] virtio-balloon: Add exit handler, fix memleaks

2011-07-28 Thread Amit Shah
On (Thu) 28 Jul 2011 [09:39:40], Markus Armbruster wrote: Amit Shah amit.s...@redhat.com writes: On (Thu) 28 Jul 2011 [11:47:15], Amit Shah wrote: Add an exit handler that will free up RAM and unregister the savevm section after a virtio-balloon device is unplugged. This commit

Re: [Qemu-devel] [PATCH v2 5/5] virtio-balloon: Unregister savevm section on device unplug

2011-07-28 Thread Amit Shah
On (Thu) 28 Jul 2011 [09:45:44], Markus Armbruster wrote: Amit Shah amit.s...@redhat.com writes: Migrating after unplugging a virtio-balloon device resulted in an error message on the destination: Unknown savevm section or instance ':00:04.0/virtio-balloon' 0 load of migration

[Qemu-devel] [PULL v2][ALSO STABLE] balloon: multiple fixes and cleanups

2011-07-28 Thread Amit Shah
Hello, This new pull request carries the first 7 patches from the earlier pull request that cleaned up balloon code and fixed a use-after-free segfault on issuing 'balloon 0'. This series adds 5 more patches that fix: - a memleak on unplug, - migration after unplug, - negative balloon values

Re: [Qemu-devel] [V5 Patch 3/4]Qemu: Command block_set for dynamic block params change

2011-07-28 Thread Supriya Kannery
On 07/27/2011 09:32 PM, Anthony Liguori wrote: On 07/27/2011 09:31 AM, Stefan Hajnoczi wrote: On Wed, Jul 27, 2011 at 1:58 PM, Anthony Liguorianth...@codemonkey.ws wrote: Index: qemu/hmp-commands.hx === ---

Re: [Qemu-devel] Block layer roadmap

2011-07-28 Thread Kevin Wolf
Am 27.07.2011 14:37, schrieb Stefan Hajnoczi: Hi, Here is a list of block layer and storage changes that have been discussed. It is useful to have a roadmap of changes in order to avoid duplication, allow more developers to contribute, and to communicate the direction of storage in QEMU.

[Qemu-devel] [PATCH 0.16 v3 0/3] make endian-independent unaligned memory access functions available to libhw

2011-07-28 Thread Paolo Bonzini
Functions like ldl_be_p and ldl_le_p are currently used only as building blocks for {ld,st}XX_p. As such, they are in cpu-all.h even though they have absolutely no dependency on the target. In order to make them globally available, this series moves them to bswap.h instead. An interesting part

[Qemu-devel] [PATCH 0.16 v3 1/3] move WORDS_ALIGNED to qemu-common.h

2011-07-28 Thread Paolo Bonzini
This is not a CPU interface, and a configure test would not be too precise. So just add it to qemu-common.h. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- cpu-common.h |4 qemu-common.h |4 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/cpu-common.h

[Qemu-devel] [PATCH 0.16 v3 2/3] softfloat: change default nan definitions to variables

2011-07-28 Thread Paolo Bonzini
Most definitions in softfloat.h are really target-independent, but the file is not because it includes definitions of the default NaN values. Change those to variables to allow including softfloat.h from files that are not compiled per-target. By making them const, the compiler is allowed to

[Qemu-devel] [PATCH 0.16 v3 3/3] move unaligned memory access functions to bswap.h

2011-07-28 Thread Paolo Bonzini
This is just code movement, and moving the fpu/ include path from target-dependent to target-independent Make variables. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- Makefile.hw |2 +- bswap.h | 474 +++ configure |3

Re: [Qemu-devel] [V5 Patch 3/4]Qemu: Command block_set for dynamic block params change

2011-07-28 Thread Kevin Wolf
Am 27.07.2011 16:51, schrieb Stefan Hajnoczi: 2011/7/27 Michael Tokarev m...@tls.msk.ru: 27.07.2011 15:30, Supriya Kannery wrote: New command block_set added for dynamically changing any of the block device parameters. For now, dynamic setting of hostcache params using this command is

Re: [Qemu-devel] [V5 Patch 1/4]Qemu: Enhance info block to display host cache setting

2011-07-28 Thread Supriya Kannery
On 07/27/2011 07:49 PM, Stefan Hajnoczi wrote: On Wed, Jul 27, 2011 at 12:30 PM, Supriya Kannery supri...@linux.vnet.ibm.com wrote: Enhance info block to display hostcache setting for each block device. Example: (qemu) info block ide0-hd0: type=hd removable=0 file=../rhel6-32.qcow2 ro=0

Re: [Qemu-devel] [PATCH] fix disabling interrupts in sun4u

2011-07-28 Thread tsnsaito
Hi, At Mon, 25 Jul 2011 19:22:38 +0200, Artyom Tarasenko wrote: clear interrupt request if the interrupt priority CPU pil clear hardware interrupt request if interrupts are disabled Not directly related to the fix, but I'd like to note a problem of hw/sun4u.c interrupt code: The interrupt

Re: [Qemu-devel] Block layer roadmap

2011-07-28 Thread Stefan Hajnoczi
On Wed, Jul 27, 2011 at 1:37 PM, Stefan Hajnoczi stefa...@gmail.com wrote: =Changes where I am not aware of firm plans= qcow2 online resize * Handle snapshots * Support shrinking qed online resize * Support shrinking

[Qemu-devel] [PATCH v3 1/2] The command line support for QEMU disk I/O limits

2011-07-28 Thread Zhi Yong Wu
Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- Makefile.objs |2 +- blockdev.c | 22 ++ qemu-config.c | 24 qemu-option.c | 17 + qemu-option.h |1 + qemu-options.hx |1 + 6 files changed, 66

[Qemu-devel] [PATCH v3 2/2] The implement of block queue, block timer, and I/O throttling algorithm

2011-07-28 Thread Zhi Yong Wu
Note: 1.) When bps/iops limits are specified to a small value such as 511 bytes/s, this VM will hang up. We are considering how to handle this senario. 2.) When dd command is issued in guest, if its option bs is set to a large value such as bs=1024K, the result speed will slightly bigger

[Qemu-devel] [PATCH v3 0/2] The intro for QEMU disk I/O limits

2011-07-28 Thread Zhi Yong Wu
The main goal of the patch is to effectively cap the disk I/O speed or counts of one single VM.It is only one draft, so it unavoidably has some drawbacks, if you catch them, please let me know. The patch will mainly introduce one block I/O throttling algorithm, one timer and one block queue

Re: [Qemu-devel] [PATCH v2 5/5] virtio-balloon: Unregister savevm section on device unplug

2011-07-28 Thread Michael S. Tsirkin
On Thu, Jul 28, 2011 at 09:45:44AM +0200, Markus Armbruster wrote: I hate the virtio pointer thicket. The problem is that each device is both a virtio pci device and a virtio net device. -- MST

Re: [Qemu-devel] [PATCH] add QEMU_LD_PREFIX environment variable

2011-07-28 Thread Johannes Schauer
Hi, On Thu, Jul 28, 2011 at 11:41:09AM +0300, Riku Voipio wrote: On Sat, Jul 23, 2011 at 07:47:49AM +0200, josch wrote: This could be avoided by setting the proposed environment variable QEMU_LD_PREFIX to the just created debian rootfs. As mentioned earlier, the usage of the -L option

Re: [Qemu-devel] [PATCH] fix disabling interrupts in sun4u

2011-07-28 Thread Artyom Tarasenko
Hi, On Thu, Jul 28, 2011 at 12:31 PM, tsnsa...@gmail.com wrote: Hi, At Mon, 25 Jul 2011 19:22:38 +0200, Artyom Tarasenko wrote: clear interrupt request if the interrupt priority CPU pil clear hardware interrupt request if interrupts are disabled Not directly related to the fix, but I'd

[Qemu-devel] [PATCH] libcacard: use INSTALL_DATA for data

2011-07-28 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- libcacard/Makefile |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/libcacard/Makefile b/libcacard/Makefile index 15205b5..33c1302 100644 --- a/libcacard/Makefile +++ b/libcacard/Makefile @@ -56,9 +56,8 @@

Re: [Qemu-devel] [PATCH] fix disabling interrupts in sun4u

2011-07-28 Thread tsnsaito
At Thu, 28 Jul 2011 13:51:08 +0200, Artyom Tarasenko wrote: On Thu, Jul 28, 2011 at 12:31 PM, tsnsa...@gmail.com wrote: Hi, At Mon, 25 Jul 2011 19:22:38 +0200, Artyom Tarasenko wrote: clear interrupt request if the interrupt priority CPU pil clear hardware interrupt request if

Re: [Qemu-devel] Block layer roadmap

2011-07-28 Thread Christoph Hellwig
On Thu, Jul 28, 2011 at 12:05:43PM +0200, Kevin Wolf wrote: Another item that just came up on IRC again: Allow guests to toggle WCE, so that we finally can get rid of the cache=writethrough default. We should definitely get this done before 1.0. Guest toggling is nice and cool, but the real

Re: [Qemu-devel] Block layer roadmap

2011-07-28 Thread Christoph Hellwig
On Wed, Jul 27, 2011 at 01:37:31PM +0100, Stefan Hajnoczi wrote: Coroutines in the block layer [Kevin] * Programming model to simplify block drivers without blocking QEMU threads Can anyone explain what the whole point of this is? It really just is a bit of syntactic sugar for the current

Re: [Qemu-devel] [PATCH] fix disabling interrupts in sun4u

2011-07-28 Thread Tsuneo Saito
2011/7/28 tsnsa...@gmail.com: At Thu, 28 Jul 2011 13:51:08 +0200, Artyom Tarasenko wrote: On Thu, Jul 28, 2011 at 12:31 PM,  tsnsa...@gmail.com wrote: Hi, At Mon, 25 Jul 2011 19:22:38 +0200, Artyom Tarasenko wrote: clear interrupt request if the interrupt priority CPU pil

Re: [Qemu-devel] Block layer roadmap

2011-07-28 Thread Frediano Ziglio
2011/7/28 Christoph Hellwig h...@lst.de: On Wed, Jul 27, 2011 at 01:37:31PM +0100, Stefan Hajnoczi wrote: Coroutines in the block layer [Kevin]  * Programming model to simplify block drivers without blocking QEMU threads Can anyone explain what the whole point of this is?  It really just is

Re: [Qemu-devel] [PATCH 1/2] linux aio: support flush operation

2011-07-28 Thread Christoph Hellwig
On Thu, Jul 28, 2011 at 09:47:05AM +0200, Kevin Wolf wrote: Indeed. This has come up a few times, and actually is a mostly trivial task. Maybe we should give up waiting for -blockdev and separate cache mode settings and allow a nocache-writethrough or similar mode now? It's going to be

Re: [Qemu-devel] Block layer roadmap

2011-07-28 Thread Christoph Hellwig
On Thu, Jul 28, 2011 at 02:15:38PM +0200, Frediano Ziglio wrote: This has nothing (or few) to do with threads. Instead of splitting functions in callbacks at every synchronous function it allow to write more readable code. Thanks for repeating my statement that it doesn't fix the real thing

Re: [Qemu-devel] [PATCH v2 5/5] virtio-balloon: Unregister savevm section on device unplug

2011-07-28 Thread Markus Armbruster
Michael S. Tsirkin m...@redhat.com writes: On Thu, Jul 28, 2011 at 09:45:44AM +0200, Markus Armbruster wrote: I hate the virtio pointer thicket. The problem is that each device is both a virtio pci device and a virtio net device. In my possibly naive opinion, virtio-FOO-pci is a PCI device,

Re: [Qemu-devel] Block layer roadmap

2011-07-28 Thread Kevin Wolf
Am 28.07.2011 14:08, schrieb Christoph Hellwig: On Thu, Jul 28, 2011 at 12:05:43PM +0200, Kevin Wolf wrote: Another item that just came up on IRC again: Allow guests to toggle WCE, so that we finally can get rid of the cache=writethrough default. We should definitely get this done before 1.0.

Re: [Qemu-devel] [PATCH v2 5/5] virtio-balloon: Unregister savevm section on device unplug

2011-07-28 Thread Michael S. Tsirkin
On Thu, Jul 28, 2011 at 02:21:32PM +0200, Markus Armbruster wrote: Michael S. Tsirkin m...@redhat.com writes: On Thu, Jul 28, 2011 at 09:45:44AM +0200, Markus Armbruster wrote: I hate the virtio pointer thicket. The problem is that each device is both a virtio pci device and a virtio

Re: [Qemu-devel] Block layer roadmap

2011-07-28 Thread Kevin Wolf
Am 28.07.2011 14:09, schrieb Christoph Hellwig: On Wed, Jul 27, 2011 at 01:37:31PM +0100, Stefan Hajnoczi wrote: Coroutines in the block layer [Kevin] * Programming model to simplify block drivers without blocking QEMU threads Can anyone explain what the whole point of this is? It really

Re: [Qemu-devel] [PATCH 1/2] linux aio: support flush operation

2011-07-28 Thread Kevin Wolf
Am 28.07.2011 14:15, schrieb Christoph Hellwig: Christoph, on another note: Can we rely on Linux AIO never returning short writes except on EOF? Currently we return -EINVAL in this case, so short reads I meant, of course. I hope it's true or we wouldn't return the correct error code. More

Re: [Qemu-devel] [RFC][PATCH 0/21] QEMU Object Model

2011-07-28 Thread Anthony Liguori
On 07/28/2011 02:36 AM, Paolo Bonzini wrote: On 07/27/2011 10:01 PM, Anthony Liguori wrote: That's milkymist, not GoldFish. Oh, Goldfish is fake. It's not real hardware. The enumerator device is not a real device. It's weird because it's imaginary and was designed specifically within

Re: [Qemu-devel] [V5 Patch 3/4]Qemu: Command block_set for dynamic block params change

2011-07-28 Thread Anthony Liguori
On 07/28/2011 05:13 AM, Supriya Kannery wrote: On 07/27/2011 09:32 PM, Anthony Liguori wrote: On 07/27/2011 09:31 AM, Stefan Hajnoczi wrote: On Wed, Jul 27, 2011 at 1:58 PM, Anthony Liguorianth...@codemonkey.ws wrote: Index: qemu/hmp-commands.hx

Re: [Qemu-devel] [PATCH v2] pci: Common overflow prevention

2011-07-28 Thread Isaku Yamahata
On Thu, Jul 28, 2011 at 11:40:21AM +0300, Michael S. Tsirkin wrote: On Thu, Jul 28, 2011 at 04:23:24PM +0900, Isaku Yamahata wrote: This might be a bit late comment... On Fri, Jul 22, 2011 at 11:05:01AM +0200, Jan Kiszka wrote: diff --git a/hw/pci_host.c b/hw/pci_host.c index

Re: [Qemu-devel] [PATCH] fix disabling interrupts in sun4u

2011-07-28 Thread Artyom Tarasenko
On Thu, Jul 28, 2011 at 2:03 PM, tsnsa...@gmail.com wrote: At Thu, 28 Jul 2011 13:51:08 +0200, Artyom Tarasenko wrote: On Thu, Jul 28, 2011 at 12:31 PM,  tsnsa...@gmail.com wrote: Hi, At Mon, 25 Jul 2011 19:22:38 +0200, Artyom Tarasenko wrote: clear interrupt request if the

Re: [Qemu-devel] Block layer roadmap

2011-07-28 Thread Anthony Liguori
On 07/28/2011 07:09 AM, Christoph Hellwig wrote: On Wed, Jul 27, 2011 at 01:37:31PM +0100, Stefan Hajnoczi wrote: Coroutines in the block layer [Kevin] * Programming model to simplify block drivers without blocking QEMU threads Can anyone explain what the whole point of this is? It really

Re: [Qemu-devel] Block layer roadmap

2011-07-28 Thread Stefan Hajnoczi
On Thu, Jul 28, 2011 at 1:35 PM, Kevin Wolf kw...@redhat.com wrote: Am 28.07.2011 14:09, schrieb Christoph Hellwig: On Wed, Jul 27, 2011 at 01:37:31PM +0100, Stefan Hajnoczi wrote: Coroutines in the block layer [Kevin]  * Programming model to simplify block drivers without blocking QEMU

Re: [Qemu-devel] [PATCH] fix disabling interrupts in sun4u

2011-07-28 Thread Artyom Tarasenko
On Thu, Jul 28, 2011 at 2:10 PM, Tsuneo Saito tsnsa...@gmail.com wrote: 2011/7/28 tsnsa...@gmail.com: At Thu, 28 Jul 2011 13:51:08 +0200, Artyom Tarasenko wrote: On Thu, Jul 28, 2011 at 12:31 PM,  tsnsa...@gmail.com wrote: Hi, At Mon, 25 Jul 2011 19:22:38 +0200, Artyom Tarasenko

Re: [Qemu-devel] Block layer roadmap

2011-07-28 Thread Kevin Wolf
Am 28.07.2011 14:54, schrieb Stefan Hajnoczi: On Thu, Jul 28, 2011 at 1:35 PM, Kevin Wolf kw...@redhat.com wrote: Am 28.07.2011 14:09, schrieb Christoph Hellwig: On Wed, Jul 27, 2011 at 01:37:31PM +0100, Stefan Hajnoczi wrote: Coroutines in the block layer [Kevin] * Programming model to

Re: [Qemu-devel] [V5 Patch 3/4]Qemu: Command block_set for dynamic block params change

2011-07-28 Thread Stefan Hajnoczi
On Thu, Jul 28, 2011 at 11:23 AM, Kevin Wolf kw...@redhat.com wrote: Am 27.07.2011 16:51, schrieb Stefan Hajnoczi: 2011/7/27 Michael Tokarev m...@tls.msk.ru: 27.07.2011 15:30, Supriya Kannery wrote: New command block_set added for dynamically changing any of the block device parameters. For

Re: [Qemu-devel] Block layer roadmap

2011-07-28 Thread Stefan Hajnoczi
On Thu, Jul 28, 2011 at 2:10 PM, Kevin Wolf kw...@redhat.com wrote: Am 28.07.2011 14:54, schrieb Stefan Hajnoczi: On Thu, Jul 28, 2011 at 1:35 PM, Kevin Wolf kw...@redhat.com wrote: Am 28.07.2011 14:09, schrieb Christoph Hellwig: On Wed, Jul 27, 2011 at 01:37:31PM +0100, Stefan Hajnoczi wrote:

Re: [Qemu-devel] [V5 Patch 3/4]Qemu: Command block_set for dynamic block params change

2011-07-28 Thread Kevin Wolf
Am 28.07.2011 15:10, schrieb Stefan Hajnoczi: On Thu, Jul 28, 2011 at 11:23 AM, Kevin Wolf kw...@redhat.com wrote: Am 27.07.2011 16:51, schrieb Stefan Hajnoczi: I'll think about this some more, there are a couple of solutions like keeping only the file descriptor around, introducing a flush

[Qemu-devel] [PATCH RESEND 2/3] Move the xenfb pointer handler to the connected method

2011-07-28 Thread stefano.stabellini
From: John Haxby john.ha...@oracle.com Ensure that we read request-abs-pointer after the frontend has written it. This means that we will correctly set up an ansolute or relative pointer handler correctly. Signed-off-by: John Haxby john.ha...@oracle.com Acked-by: Stefano Stabellini

[Qemu-devel] [PATCH RESEND 1/3] Introduce a new 'connected' xendev op called when Connected.

2011-07-28 Thread stefano.stabellini
From: John Haxby john.ha...@oracle.com Rename the existing xendev 'connect' op to 'initialised' and introduce a new 'connected' op. This new op, if defined, is called when the backend is connected. Note that since there is no state transition this may be called more than once. Signed-off-by:

[Qemu-devel] [PATCH RESEND 3/3] xen: use uint64_t instead of target_ulong in cpu_ioreq_move

2011-07-28 Thread stefano.stabellini
From: Stefano Stabellini stefano.stabell...@eu.citrix.com cpu_ioreq_move might move 8 bytes at a time so we must make sure that the temporary variable can hold 8 bytes. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com --- xen-all.c |2 +- 1 files changed, 1 insertions(+),

Re: [Qemu-devel] [RFC] Introduce vm_stop_permanent()

2011-07-28 Thread Luiz Capitulino
On Thu, 28 Jul 2011 10:23:22 +0300 Avi Kivity a...@redhat.com wrote: On 07/28/2011 12:44 AM, Blue Swirl wrote: On Wed, Jul 27, 2011 at 9:42 PM, Luiz Capitulinolcapitul...@redhat.com wrote: This function should be used when the VM is not supposed to resume execution (eg. by issuing

Re: [Qemu-devel] [RFC] Introduce vm_stop_permanent()

2011-07-28 Thread Avi Kivity
On 07/28/2011 04:31 PM, Luiz Capitulino wrote: On Thu, 28 Jul 2011 10:23:22 +0300 Avi Kivitya...@redhat.com wrote: On 07/28/2011 12:44 AM, Blue Swirl wrote: On Wed, Jul 27, 2011 at 9:42 PM, Luiz Capitulinolcapitul...@redhat.com wrote: This function should be used when the VM is

[Qemu-devel] [PATCH 0/4] Set of patches for chrooted environment

2011-07-28 Thread Laurent Vivier
This set of patches helps to use qemu-linux-user in a chrooted environment. It mostly allows to define the default cpu model as we can't use '-cpu' argument. The last one defines enviromnent variables to be able to use log file and gdb server ('-d' and '-g' arguments). NOTE: I saw some

[Qemu-devel] [PATCH 2/4] linux-user: specify the cpu model during configure

2011-07-28 Thread Laurent Vivier
This patch allows to set the default cpu model for a given architecture, for instance: configure --target-list=m68k-linux-user --m68k-default-cpu=m68040 Signed-off-by: Laurent Vivier laur...@vivier.eu --- configure |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git

[Qemu-devel] [PATCH 3/4] linux-user,m68k: display default cpu

2011-07-28 Thread Laurent Vivier
Signed-off-by: Laurent Vivier laur...@vivier.eu --- target-m68k/helper.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/target-m68k/helper.c b/target-m68k/helper.c index a936fe7..f5d33cd 100644 --- a/target-m68k/helper.c +++ b/target-m68k/helper.c @@ -57,6 +57,11 @@

[Qemu-devel] [PATCH 4/4] linux-user: define new environment variables

2011-07-28 Thread Laurent Vivier
QEMU_GDB=port allows to define gdb server port to wait on. QEMU_DEBUG=options allows to activate log file (like -d options) Signed-off-by: Laurent Vivier laur...@vivier.eu --- linux-user/main.c | 11 --- qemu-doc.texi |4 2 files changed, 12 insertions(+), 3 deletions(-)

[Qemu-devel] [PATCH 1/4] linux-user: define default cpu model in configure instead of linux-user/main.c

2011-07-28 Thread Laurent Vivier
Signed-off-by: Laurent Vivier laur...@vivier.eu --- configure | 15 +++ linux-user/main.c | 34 +- 2 files changed, 16 insertions(+), 33 deletions(-) diff --git a/configure b/configure index fb8819b..c74a5f9 100755 --- a/configure +++

Re: [Qemu-devel] [PATCH] fix disabling interrupts in sun4u

2011-07-28 Thread tsnsaito
At Thu, 28 Jul 2011 14:50:57 +0200, Artyom Tarasenko wrote: On Thu, Jul 28, 2011 at 2:03 PM, tsnsa...@gmail.com wrote: At Thu, 28 Jul 2011 13:51:08 +0200, Artyom Tarasenko wrote: On Thu, Jul 28, 2011 at 12:31 PM,  tsnsa...@gmail.com wrote: Hi, At Mon, 25 Jul 2011 19:22:38 +0200,

[Qemu-devel] [PATCH] [RFC] qcow2: group refcount updates during cow

2011-07-28 Thread Frediano Ziglio
Well, I think this is the first real improve patch. Is more a RFC than a patch. Yes, some lines are terrible! It collapses refcount decrement during cow. From a first check time executing 015 test passed from about 600 seconds to 70. This at least prove that refcount updates counts! Some doubt: 1-

Re: [Qemu-devel] [RFC][PATCH 0/21] QEMU Object Model

2011-07-28 Thread Paolo Bonzini
On 07/28/2011 02:46 PM, Anthony Liguori wrote: There are plenty of PV interfaces implemented by QEMU. Would you say the same of virtio? Virtio was designed to look like real hardware. I would say that trying to fit XenStore into QOM would not be a good exercise. No doubt about that. :)

Re: [Qemu-devel] [PATCH 00/12] bugfix and qdevify NAND and ONENAND devices

2011-07-28 Thread Peter Maydell
Ping on this one too, since I'm nearly ready with the next chunk of patches (18 patches fixing bugs and adding NAND support to omap_gpmc) and they obviously depend on this set. -- PMM On 15 July 2011 15:58, Peter Maydell peter.mayd...@linaro.org wrote: This patchseries is more goodies from the

Re: [Qemu-devel] [RFC][PATCH 0/21] QEMU Object Model

2011-07-28 Thread Anthony Liguori
On 07/28/2011 08:50 AM, Paolo Bonzini wrote: On 07/28/2011 02:46 PM, Anthony Liguori wrote: There are plenty of PV interfaces implemented by QEMU. Would you say the same of virtio? Virtio was designed to look like real hardware. I would say that trying to fit XenStore into QOM would not be

[Qemu-devel] [Bug 524447] Re: virsh save is very slow

2011-07-28 Thread Jeff Snider
Michael: Yes, that is the correct patch. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/524447 Title: virsh save is very slow Status in libvirt virtualization API: Unknown Status in QEMU: Fix

  1   2   >