Re: [Qemu-devel] [RFC][PATCH 0/21] QEMU Object Model

2011-07-29 Thread Paolo Bonzini
On 07/28/2011 07:59 PM, Anthony Liguori wrote: Just define an interface that returns a struct then. It's no more complicated than that. Ok, so we're debating whether to: 1) add an interface returning a pointer to an internal struct; 2) include in the internal struct a pointer-to-function

Re: [Qemu-devel] [PATCH 18/55] scsi-disk: Reject CD-specific SCSI commands to disks

2011-07-29 Thread Markus Armbruster
Markus Armbruster arm...@redhat.com writes: Christoph Hellwig h...@lst.de writes: On Wed, Jul 20, 2011 at 06:23:52PM +0200, Markus Armbruster wrote: Use a table to declare which drive kinds accept each command. Limit READ_CAPACITY, READ_TOC, GET_CONFIGURATION to SCSI_CD, as per SPC-4.

Re: [Qemu-devel] Volume key in qcow3?

2011-07-29 Thread Frediano Ziglio
2011/7/28 Kevin Wolf kw...@redhat.com: Am 28.07.2011 10:05, schrieb Frediano Ziglio: Hi,   I noted that AES encryption using qcow2 just use the password given as as key (and also truncating it to 16 bytes == 128 bits). This is prone to brute force attacks and is not also easy to change

Re: [Qemu-devel] Odd code in cpus.c

2011-07-29 Thread Jan Kiszka
On 2011-07-29 10:34, Frediano Ziglio wrote: I don't know that much this code however qemu_kvm_init_cpu_signals seems a bit strange and duplicate to me, in cpus.c static void qemu_kvm_init_cpu_signals(CPUState *env) { int r; sigset_t set; struct sigaction sigact;

Re: [Qemu-devel] Odd code in cpus.c

2011-07-29 Thread Paolo Bonzini
On 07/29/2011 10:49 AM, Jan Kiszka wrote: which seems to set kvm signal twice with same values (taking into account that in kvm_set_signal_mask the set is copied before the call to kvm_vcpu_ioctl). Indeed. Harmless fortunately. I suspect the duplicate bits in the #ifdef CONFIG_IOTHREAD

Re: [Qemu-devel] [PATCH 49/55] block: Declare qemu_blockalign() in block.h, not block_int.h

2011-07-29 Thread Markus Armbruster
Christoph Hellwig h...@lst.de writes: On Wed, Jul 20, 2011 at 06:24:23PM +0200, Markus Armbruster wrote: Device models should be able to use it without an unclean include of block_int.h. Hmm. We already do proper read-modify-write cycles for actual data transfers, so killing the buffer

Re: [Qemu-devel] Volume key in qcow3?

2011-07-29 Thread Kevin Wolf
Am 29.07.2011 10:47, schrieb Frediano Ziglio: 2011/7/28 Kevin Wolf kw...@redhat.com: Am 28.07.2011 10:05, schrieb Frediano Ziglio: Hi, I noted that AES encryption using qcow2 just use the password given as as key (and also truncating it to 16 bytes == 128 bits). This is prone to brute

Re: [Qemu-devel] [PATCH 0/3] small trivial patches

2011-07-29 Thread Stefan Hajnoczi
On Wed, Jul 27, 2011 at 7:11 PM, Frediano Ziglio fredd...@gmail.com wrote: Minor fixes and improves Frediano Ziglio (3):  block: removed unused function  block: typo fix  aio: always check paio_init result  block.c           |   13 -  block.h           |    2 --  

Re: [Qemu-devel] [PATCH] [RFC] qcow2: group refcount updates during cow

2011-07-29 Thread Kevin Wolf
Am 28.07.2011 16:15, schrieb Kevin Wolf: Am 28.07.2011 15:50, schrieb Frediano Ziglio: Well, I think this is the first real improve patch. Is more a RFC than a patch. Yes, some lines are terrible! It collapses refcount decrement during cow. From a first check time executing 015 test passed

Re: [Qemu-devel] [PATCH 2/2] Makefile: delete config.log in distclean

2011-07-29 Thread Stefan Hajnoczi
On Mon, Jul 25, 2011 at 11:56:02PM -0400, Alexandre Raymond wrote: Distclean should remove anything created by the configure script. Signed-off-by: Alexandre Raymond cerb...@gmail.com --- Makefile |1 + 1 files changed, 1 insertions(+), 0 deletions(-) Thanks, applied to the trivial

[Qemu-devel] [Bug 802588] Re: Latest GIT version fails to compile on Linux - setjmp.h problem

2011-07-29 Thread Yongjie Ren
this issue got fixed. It doesn't exist in qemu-kvm.git fda19064e889d4419dd3dc69ca8e6e7a1535fdf5 ** Changed in: qemu Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/2] Makefile: distclean should clean all possible targets

2011-07-29 Thread Paolo Bonzini
On 07/27/2011 04:42 PM, Michael Roth wrote: Delete all files in the current directory (or created by this makefile) that are created by configuring or building the program. If you have unpacked the source and built the program without creating any other files, ‘make distclean’ should leave only

Re: [Qemu-devel] Block layer roadmap

2011-07-29 Thread Stefan Hajnoczi
Frediano suggested: Enhanced volume key in qcow3 * luks-like key scheme that allows changing passphrase without re-encrypting image data

Re: [Qemu-devel] [PATCH -V2] coroutine: Add CoRwlock support

2011-07-29 Thread Kevin Wolf
Am 27.07.2011 18:21, schrieb Aneesh Kumar K.V: Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- qemu-coroutine-lock.c | 44 qemu-coroutine.h | 12 2 files changed, 56 insertions(+), 0 deletions(-) Looks

Re: [Qemu-devel] Bug#632192: [PATCH] add QEMU_LD_PREFIX environment variable

2011-07-29 Thread Vagrant Cascadian
On Thu, Jul 28, 2011 at 11:41:09AM +0300, Riku Voipio wrote: On Sat, Jul 23, 2011 at 07:47:49AM +0200, josch wrote: This could be avoided by setting the proposed environment variable QEMU_LD_PREFIX to the just created debian rootfs. As mentioned earlier, the usage of the -L option is not

Re: [Qemu-devel] [PATCH v8 0/5] Coroutines for better asynchronous programming

2011-07-29 Thread Stefan Hajnoczi
On Tue, Jul 26, 2011 at 10:21 AM, Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: QEMU is event-driven and suffers when blocking operations are performed because VM execution may be stopped until the operation completes.  Therefore many operations that could block are performed

Re: [Qemu-devel] [PATCH 2/2] pc: Support system flash memory with pflash

2011-07-29 Thread Anthony Liguori
On 07/25/2011 04:34 PM, Jordan Justen wrote: If a pflash image is found, then it is used for the system firmware image. If a pflash image is not initially found, then a read-only pflash device is created using the -bios filename. Signed-off-by: Jordan Justenjordan.l.jus...@intel.com Cc:

Re: [Qemu-devel] [RFC PATCH 1/4] add support for machine models to specify their migration format

2011-07-29 Thread Anthony Liguori
On 06/30/2011 10:46 AM, Paolo Bonzini wrote: We need to provide a new migration format, and not break migration in old machine models. So add a migration_format field to QEMUMachine. Signed-off-by: Paolo Bonzinipbonz...@redhat.com --- cpu-common.h |3 --- hw/boards.h |1 +

Re: [Qemu-devel] [PATCH 49/55] block: Declare qemu_blockalign() in block.h, not block_int.h

2011-07-29 Thread Christoph Hellwig
On Fri, Jul 29, 2011 at 10:56:07AM +0200, Markus Armbruster wrote: Hmm. We already do proper read-modify-write cycles for actual data transfers, so killing the buffer inside SD sounds like the better idea. qemu_blockalign really should be used only for block-layer internal allocations.

Re: [Qemu-devel] [RFC PATCH 3/4] savevm: define new unambiguous migration format

2011-07-29 Thread Anthony Liguori
On 06/30/2011 10:46 AM, Paolo Bonzini wrote: With the current migration format, VMS_STRUCTs with subsections are ambiguous. The protocol cannot tell whether a 0x5 byte after the VMS_STRUCT is a subsection or part of the parent data stream. In the past QEMU assumed it was always a part of a

Re: [Qemu-devel] [RFC PATCH 0/4] Fix subsection ambiguity in the migration format

2011-07-29 Thread Anthony Liguori
On 07/25/2011 04:10 PM, Paolo Bonzini wrote: On Thu, Jun 30, 2011 at 17:46, Paolo Bonzinipbonz...@redhat.com wrote: I have now tested this series (exactly as sent) both by examining manually the differences between the two formats on the same guest state, and by a mix of saves/restores (new on

Re: [Qemu-devel] [PATCH 05/10] qcow2: Use coroutines

2011-07-29 Thread Stefan Hajnoczi
On Tue, Jul 26, 2011 at 12:49 PM, Kevin Wolf kw...@redhat.com wrote: Signed-off-by: Kevin Wolf kw...@redhat.com ---  block/qcow2-cluster.c |   26 +++---  block/qcow2.c         |  240 ++---  block/qcow2.h         |    5 +-  3 files changed, 102

Re: [Qemu-devel] [PATCH 0/3] small trivial patches

2011-07-29 Thread Kevin Wolf
Am 27.07.2011 20:11, schrieb Frediano Ziglio: Minor fixes and improves Frediano Ziglio (3): block: removed unused function block: typo fix aio: always check paio_init result block.c | 13 - block.h |2 -- block/raw-posix.c | 13

Re: [Qemu-devel] [RFC PATCH 0/4] Fix subsection ambiguity in the migration format

2011-07-29 Thread Kevin Wolf
Am 26.07.2011 14:37, schrieb Anthony Liguori: On 07/26/2011 07:07 AM, Juan Quintela wrote: Anthony Liguorianth...@codemonkey.ws wrote: == What we need == We need to decompose migration into three different problems: 1) serializing device state 2) transforming the device model in order to

Re: [Qemu-devel] [PATCH v2 00/23] Memory API, batch 1

2011-07-29 Thread Anthony Liguori
On 07/26/2011 06:25 AM, Avi Kivity wrote: This patchset contains the core of the memory API, with one device (usb-ohci) coverted for reference. The API is currently implemented on top of the old ram_addr_t/cpu_register_physical_memory() API, but the plan is to make it standalone later. The

Re: [Qemu-devel] [PATCH v7] showing a splash picture when start

2011-07-29 Thread Anthony Liguori
On 07/27/2011 05:04 AM, Wayne Xia wrote: From: waynexiaw...@linux.vnet.ibm.com Added options to let qemu transfer two configuration files to bios: bootsplash.bmp and etc/boot-menu-wait, which could be specified by command -boot splash=P,splash-time=T P is jpg/bmp file name or an

Re: [Qemu-devel] [PATCH 0.16 v3 0/3] make endian-independent unaligned memory access functions available to libhw

2011-07-29 Thread Anthony Liguori
On 07/28/2011 05:10 AM, Paolo Bonzini wrote: Functions like ldl_be_p and ldl_le_p are currently used only as building blocks for {ld,st}XX_p. As such, they are in cpu-all.h even though they have absolutely no dependency on the target. In order to make them globally available, this series moves

Re: [Qemu-devel] [PATCH 1/2] linux aio: support flush operation

2011-07-29 Thread Christoph Hellwig
On Thu, Jul 28, 2011 at 02:41:02PM +0200, Kevin Wolf wrote: More or less. There's one corner case for all Linux I/O, and that is only writes up to INT_MAX are supported, and larger writes (and reads) get truncated to it. It's pretty nasty, but Linux has been vocally opposed to fixing

Re: [Qemu-devel] [PATCH -V2] coroutine: Add CoRwlock support

2011-07-29 Thread Aneesh Kumar K.V
On Fri, 29 Jul 2011 14:53:14 +0200, Kevin Wolf kw...@redhat.com wrote: Am 27.07.2011 18:21, schrieb Aneesh Kumar K.V: Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- qemu-coroutine-lock.c | 44 qemu-coroutine.h |

Re: [Qemu-devel] [RFC PATCH 0/4] Fix subsection ambiguity in the migration format

2011-07-29 Thread Anthony Liguori
On 07/29/2011 09:03 AM, Kevin Wolf wrote: Am 26.07.2011 14:37, schrieb Anthony Liguori: Hrm, I'm not sure I agree with these conclusions. Management tools should do their best job to create two compatible device models. Given two compatible device models, there *may* be differences in the

Re: [Qemu-devel] [PATCH] lm832x: Take DeviceState pointer in lm832x_key_event()

2011-07-29 Thread Anthony Liguori
On 07/28/2011 09:47 AM, Peter Maydell wrote: Since lm832x has been qdev'ified, its users will generally have a DeviceState pointer rather than an i2c_slave pointer, so adjust lm832x_key_event's prototype to suit. This allows the n810 (its only user) to actually pass a correct pointer to it

Re: [Qemu-devel] [RFC PATCH 1/4] add support for machine models to specify their migration format

2011-07-29 Thread Paolo Bonzini
On 07/29/2011 03:08 PM, Anthony Liguori wrote: Please avoid this gcc extension as it's relatively obscure. But in addition, why would use you 0 as the new format instead of QEMU_VM_FILE_VERSION + 1? 0 is the default. If a machine doesn't specify a format, it gets the newest one

Re: [Qemu-devel] [RFC PATCH 3/4] savevm: define new unambiguous migration format

2011-07-29 Thread Paolo Bonzini
On 07/29/2011 03:12 PM, Anthony Liguori wrote: Please introduce a macro so this code is readable. Ok. We have other machines that support migration in other archs too. Those machine types are not versioned, so they will automatically switch to the newest version. Paolo

Re: [Qemu-devel] [PATCH v2] multiboot: Fix bss segment support

2011-07-29 Thread Anthony Liguori
On 07/24/2011 10:55 AM, Göran Weinholt wrote: Multiboot images can specify a bss segment. The boot loader must clear the memory of the bss and ensure that no modules or structures are allocated inside it. Several fields are provided in the Multiboot header that were previously not used properly.

Re: [Qemu-devel] [PATCH] monitor: fix build breakage with --disable-vnc

2011-07-29 Thread Anthony Liguori
On 07/25/2011 03:29 AM, TeLeMan wrote: The breakage was introduced by the commit 13661089810d3e59931f3e80d7cb541b99af7071 Signed-off-by: TeLeMangele...@gmail.com Applied. Thanks. Regards, Anthony Liguori --- monitor.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff

Re: [Qemu-devel] [PATCH] Fix last sector write on sd card

2011-07-29 Thread Anthony Liguori
On 07/25/2011 07:21 AM, Dr. David Alan Gilbert wrote: When writing the last sector of an SD card using WRITE_MULTIPLE_BLOCK QEmu throws an error saying that we've run off the end, and leaves itself in the wrong state. Tested on ARM Vexpress model. Signed-off-by: Dr. David Alan

Re: [Qemu-devel] [PATCH resend] Add missing trace call to oslib-posix.c:qemu_vmalloc()

2011-07-29 Thread Anthony Liguori
On 07/25/2011 10:13 AM, jes.soren...@redhat.com wrote: From: Jes Sorensenjes.soren...@redhat.com Signed-off-by: Jes Sorensenjes.soren...@redhat.com Applied. Thanks. Regards, Anthony Liguori --- oslib-posix.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git

Re: [Qemu-devel] [PATCH] Allow to leave type on default in -machine

2011-07-29 Thread Anthony Liguori
On 07/25/2011 11:11 AM, Jan Kiszka wrote: On 2011-07-25 13:48, Jan Kiszka wrote: On 2011-07-25 13:39, Markus Armbruster wrote: Jan Kiszkajan.kis...@siemens.com writes: On 2011-07-25 12:45, Richard W.M. Jones wrote: On Mon, Jul 25, 2011 at 12:33:01PM +0200, Jan Kiszka wrote: On 2011-07-25

Re: [Qemu-devel] [PATCH] CODING_STYLE: explicitly allow braceless 'else if'

2011-07-29 Thread Anthony Liguori
On 07/25/2011 10:55 AM, Avi Kivity wrote: It's already allowed by the example; there are about 1800 instances in the tree; and disallowing it would lead to if (a) { ... } else { if (b) { ... } else { if (c) { ...

Re: [Qemu-devel] [PATCH] configure: add --disable-zlib-test

2011-07-29 Thread Anthony Liguori
On 07/26/2011 04:30 AM, Alon Levy wrote: This is required for building libcacard which doesn't itself require zlib without bringing in this requirement to the build environment. Signed-off-by: Alon Levyal...@redhat.com Applied. Thanks. Regards, Anthony Liguori --- I'd like this to go

Re: [Qemu-devel] [PATCH] Fix a compilation error in xen-mapcache.c

2011-07-29 Thread Anthony Liguori
On 07/26/2011 09:33 AM, Stefan Berger wrote: This patch fixes a compilation error in xen-mapcache.c . /home/stefanb/qemu/qemu-git/xen-mapcache.c: In function ‘xen_ram_addr_from_mapcache’: /home/stefanb/qemu/qemu-git/xen-mapcache.c:240:42: error: variable ‘pentry’ set but not used

Re: [Qemu-devel] [PATCH] lm832x: Take DeviceState pointer in lm832x_key_event()

2011-07-29 Thread Peter Maydell
On 29 July 2011 15:31, Anthony Liguori anth...@codemonkey.ws wrote: On 07/28/2011 09:47 AM, Peter Maydell wrote: Since lm832x has been qdev'ified, its users will generally have a DeviceState pointer rather than an i2c_slave pointer, so adjust lm832x_key_event's prototype to suit. This

Re: [Qemu-devel] [RFC PATCH 0/4] Fix subsection ambiguity in the migration format

2011-07-29 Thread Paolo Bonzini
On 07/29/2011 03:14 PM, Anthony Liguori wrote: I really hate the idea of changing the migration format moments before the release. So do I, but that's life. Since subsections are optional, can't we take the offending subsections, remove them, bump the section version numbers and make the

[Qemu-devel] [PATCH] MAINTAINERS: add entry for Xen

2011-07-29 Thread stefano.stabellini
From: Stefano Stabellini stefano.stabell...@eu.citrix.com Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com --- MAINTAINERS | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 6115e4e..273a6a7 100644 ---

Re: [Qemu-devel] [RFC PATCH 0/4] Fix subsection ambiguity in the migration format

2011-07-29 Thread Kevin Wolf
Am 29.07.2011 16:28, schrieb Anthony Liguori: On 07/29/2011 09:03 AM, Kevin Wolf wrote: Am 26.07.2011 14:37, schrieb Anthony Liguori: Hrm, I'm not sure I agree with these conclusions. Management tools should do their best job to create two compatible device models. Given two compatible

Re: [Qemu-devel] [PATCH -V2] coroutine: Add CoRwlock support

2011-07-29 Thread Kevin Wolf
Am 29.07.2011 16:24, schrieb Aneesh Kumar K.V: On Fri, 29 Jul 2011 14:53:14 +0200, Kevin Wolf kw...@redhat.com wrote: Am 27.07.2011 18:21, schrieb Aneesh Kumar K.V: Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- qemu-coroutine-lock.c | 44

Re: [Qemu-devel] [PATCH 1/2] linux aio: support flush operation

2011-07-29 Thread Stefan Hajnoczi
On Thu, Jul 28, 2011 at 1:15 PM, Christoph Hellwig h...@lst.de wrote: On Thu, Jul 28, 2011 at 09:47:05AM +0200, Kevin Wolf wrote: Indeed.  This has come up a few times, and actually is a mostly trivial task.  Maybe we should give up waiting for -blockdev and separate cache mode settings and

[Qemu-devel] [PATCH v2 0.15 1/4] add support for machine models to specify their migration format

2011-07-29 Thread Paolo Bonzini
We need to provide a new migration format, and not break migration in old machine models. So add a migration_format field to QEMUMachine. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- cpu-common.h |3 --- hw/boards.h |1 + qemu-common.h |3 +++ savevm.c | 16

[Qemu-devel] [PATCH v2 0.15 0/4] Fix subsection ambiguity in the migration format

2011-07-29 Thread Paolo Bonzini
With the current migration format, VMS_STRUCTs with subsections are ambiguous. The protocol cannot tell whether a 0x5 byte after the VMS_STRUCT is a subsection or part of the parent data stream. In the past QEMU assumed it was always a part of a subsection; after commit eb60260 (savevm: fix

[Qemu-devel] [PATCH v2 0.15 3/4] savevm: define new unambiguous migration format

2011-07-29 Thread Paolo Bonzini
With the current migration format, VMS_STRUCTs with subsections are ambiguous. The protocol cannot tell whether a 0x5 byte after the VMS_STRUCT is a subsection or part of the parent data stream. In the past QEMU assumed it was always a part of a subsection; after commit eb60260 (savevm: fix

[Qemu-devel] [PATCH v2 0.15 4/4] Partially revert savevm: fix corruption in vmstate_subsection_load().

2011-07-29 Thread Paolo Bonzini
This reverts the additional check in commit eb60260d (but not the assertions). The new format does not require the check, and with the old format it traded one kind of bogus failure for a different kind of silent failure. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- savevm.c |4

[Qemu-devel] [PATCH 10/15] hw/nand: Writing to NAND can only clear bits

2011-07-29 Thread Peter Maydell
Writing to a NAND device cannot set bits, it can only clear them; implement this rather than simply copying the data. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/nand.c | 17 + 1 files changed, 13 insertions(+), 4 deletions(-) diff --git a/hw/nand.c

[Qemu-devel] [PATCH 14/15] onenand: Ignore zero writes to boot command space

2011-07-29 Thread Peter Maydell
From: Juha Riihimäki juha.riihim...@nokia.com Ignore zero writes to the boot command space; Linux will issue these in the powerdown/reset sequence. Signed-off-by: Juha Riihimäki juha.riihim...@nokia.com [Riku Voipio: Fixes and restructuring patchset] Signed-off-by: Riku Voipio riku.voi...@iki.fi

[Qemu-devel] [PATCH 06/15] hw/nand: Pass block device state to init function

2011-07-29 Thread Peter Maydell
Pass the BlockDeviceState to the nand_init() function rather than having it look it up via drive_get() itself. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/axis_dev88.c |6 +- hw/flash.h |2 +- hw/nand.c |8 ++-- hw/spitz.c |4 +++-

[Qemu-devel] [PATCH 04/15] hw/omap_gpio.c: Convert to qdev

2011-07-29 Thread Peter Maydell
From: Juha Riihimäki juha.riihim...@nokia.com Convert the OMAP GPIO module to qdev. Signed-off-by: Juha Riihimäki juha.riihim...@nokia.com [Riku Voipio: Fixes and restructuring patchset] Signed-off-by: Riku Voipio riku.voi...@iki.fi [Peter Maydell: More fixes and cleanups for upstream

[Qemu-devel] [PATCH 07/15] hw/nand: Support large NAND devices

2011-07-29 Thread Peter Maydell
From: Juha Riihimäki juha.riihim...@nokia.com Add support for NAND devices of over 1Gb. Signed-off-by: Juha Riihimäki juha.riihim...@nokia.com [Riku Voipio: Fixes and restructuring patchset] Signed-off-by: Riku Voipio riku.voi...@iki.fi [Peter Maydell: More fixes and cleanups for upstream

Re: [Qemu-devel] [PATCH] MAINTAINERS: add entry for Xen

2011-07-29 Thread Alexander Graf
Am 29.07.2011 um 17:05 schrieb stefano.stabell...@eu.citrix.com: From: Stefano Stabellini stefano.stabell...@eu.citrix.com Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Acked-by: Alexander Graf ag...@suse.de :) Alex --- MAINTAINERS | 10 ++ 1 files

[Qemu-devel] [PATCH 15/15] hw/onenand: program actions can only clear bits

2011-07-29 Thread Peter Maydell
From: Juha Riihimäki juha.riihim...@nokia.com The program actions onenand_prog_main() and onenand_prog_spare() can only set bits. This implies a rewrite of onenand_erase() to not use the program functions, since erase does need to set bits. Signed-off-by: Juha Riihimäki juha.riihim...@nokia.com

Re: [Qemu-devel] [PULL] non-migratable devices

2011-07-29 Thread Anthony Liguori
On 07/20/2011 05:09 AM, Gerd Hoffmann wrote: Hi, This patch series adds an easy way to tag devices as non-migratable and puts it into use for ahci, ehci and a number of usb devices. Pulled. Thanks. Regards, Anthony Liguori cheers, Gerd The following changes since commit

Re: [Qemu-devel] [PULL] libcacard AFE support and bug fixes

2011-07-29 Thread Anthony Liguori
On 07/22/2011 10:08 AM, Alon Levy wrote: Hi, Please pull fixes for AFE smart cards, cleanup and missing frees by Robert Relyea and Christophe Fergeau. Thanks. The following changes since commit d1afc48b7cfdb4490f322d5d82a2aae6d545ec06: SPARC64: implement addtional MMU faults related to

Re: [Qemu-devel] [PULL v2] Trivial patches for June 25 to July 27 2011

2011-07-29 Thread Anthony Liguori
On 07/27/2011 10:14 AM, Stefan Hajnoczi wrote: Quick update: I have dropped the superfluous Makefile: fix out-of-tree builds patch. The following changes since commit c886edfb851c0c590d4e77f058f2ec8ed95ad1b5: Let users select their pythons (2011-07-25 16:50:12 +) are available in the

Re: [Qemu-devel] [PULL 0/9] xen patch queue 2011-07-26

2011-07-29 Thread Anthony Liguori
On 07/27/2011 08:30 AM, Alexander Graf wrote: Hi Anthony, This is my current patch queue for xen. Please pull. Alex The following changes since commit c886edfb851c0c590d4e77f058f2ec8ed95ad1b5: Blue Swirl (1): Let users select their pythons are available in the git repository at:

Re: [Qemu-devel] [PATCH 5/9] usb storage: first migration support bits.

2011-07-29 Thread Paolo Bonzini
On 07/20/2011 12:09 PM, Gerd Hoffmann wrote: Tag vmstate as unmigratable for the time being, to be removed when mgration support is finished. I'm going to handle this at the SCSI level by canceling all transactions on pre-load. Expect patches next week. Paolo

Re: [Qemu-devel] [PATCH 6/9] usb-wacom doesn't support migration

2011-07-29 Thread Paolo Bonzini
On 07/20/2011 12:09 PM, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmannkra...@redhat.com --- hw/usb-wacom.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/usb-wacom.c b/hw/usb-wacom.c index 9d348e1..d76ee97 100644 --- a/hw/usb-wacom.c +++ b/hw/usb-wacom.c

[Qemu-devel] [PATCH 03/15] hw/omap_clk: Add the clock for the OMAP2430-specific fifth GPIO module

2011-07-29 Thread Peter Maydell
The OMAP2430 has a fifth GPIO module which earlier OMAP2 models lack; add the clock definition for it. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/omap_clk.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/hw/omap_clk.c b/hw/omap_clk.c index

[Qemu-devel] [PATCH 13/15] onenand: Handle various ID fields separately

2011-07-29 Thread Peter Maydell
From: Juha Riihimäki juha.riihim...@nokia.com Handle the manufacturer, device and version IDs separately rather than smooshing them all together into a single uint32_t. Note that the ID registers are actually 16 bit, even though typically the top bits are 0 and the Read Identification Data

[Qemu-devel] [PATCH 11/15] hw/nand: qdevify

2011-07-29 Thread Peter Maydell
From: Juha Riihimäki juha.riihim...@nokia.com Qdevify the NAND device. Signed-off-by: Juha Riihimäki juha.riihim...@nokia.com [Riku Voipio: Fixes and restructuring patchset] Signed-off-by: Riku Voipio riku.voi...@iki.fi [Peter Maydell: More fixes and cleanups for upstream submission]

[Qemu-devel] [PATCH 08/15] hw/nand: Support devices wider than 8 bits

2011-07-29 Thread Peter Maydell
From: Juha Riihimäki juha.riihim...@nokia.com Support NAND devices which are wider than 8 bits. Signed-off-by: Juha Riihimäki juha.riihim...@nokia.com [Riku Voipio: Fixes and restructuring patchset] Signed-off-by: Riku Voipio riku.voi...@iki.fi [Peter Maydell: More fixes and cleanups for

[Qemu-devel] [PULL 00/15] omap patches (gpio, nand, onenand, lm832x)

2011-07-29 Thread Peter Maydell
This pull request gathers up my recent omap patches: * omap-gpio qdevification * nand bugfixes and qdevification * onenand bugfixes * fix crash bug in n810/lm832x when key is pressed I have omitted patch 11/12 from the nand/onenand patchset (http://patchwork.ozlabs.org/patch/104841/

[Qemu-devel] [PATCH v2 0.15 2/4] add pc-0.14 machine

2011-07-29 Thread Paolo Bonzini
The new pc-0.15 machine will have a different migration format, so define the compatibility one right now. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/pc_piix.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/hw/pc_piix.c b/hw/pc_piix.c index

[Qemu-devel] [PATCH 01/15] hw/omap_l4.c: Add helper function omap_l4_region_base

2011-07-29 Thread Peter Maydell
From: Juha Riihimäki juha.riihim...@nokia.com Add helper function omap_l4_region_base() to return the base address of a particular region of an L4 target agent. Signed-off-by: Juha Riihimäki juha.riihim...@nokia.com [Riku Voipio: Fixes and restructuring patchset] Signed-off-by: Riku Voipio

[Qemu-devel] [PATCH 05/15] lm832x: Take DeviceState pointer in lm832x_key_event()

2011-07-29 Thread Peter Maydell
Since lm832x has been qdev'ified, its users will generally have a DeviceState pointer rather than an i2c_slave pointer, so adjust lm832x_key_event's prototype to suit. This allows the n810 (its only user) to actually pass a correct pointer to it rather than NULL. The effect is that we no longer

[Qemu-devel] [PATCH 12/15] onenand: Pass BlockDriverState to init function

2011-07-29 Thread Peter Maydell
Pass the BlockDriverState to the onenand init function so it doesn't need to look up the drive itself. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/flash.h |3 ++- hw/nseries.c | 10 ++ hw/onenand.c | 14 -- 3 files changed, 16 insertions(+), 11

[Qemu-devel] [PATCH 09/15] hw/nand: Support multiple reads following READ STATUS

2011-07-29 Thread Peter Maydell
From: Juha Riihimäki juha.riihim...@nokia.com After receiving READ STATUS command all subsequent IO reads should return the status register value until another command is issued. Signed-off-by: Juha Riihimäki juha.riihim...@nokia.com [Riku Voipio: Fixes and restructuring patchset] Signed-off-by:

[Qemu-devel] [PATCH 02/15] hw/omap_gpio.c: Don't complain about some writes to r/o registers

2011-07-29 Thread Peter Maydell
Don't complain about some writes to r/o OMAP2 GPIO registers, because the kernel will do them anyway. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/omap_gpio.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/omap_gpio.c b/hw/omap_gpio.c index

Re: [Qemu-devel] [PATCH V2 1/2] [SLIRP] Simple ARP table

2011-07-29 Thread Jan Kiszka
On 2011-07-29 18:25, Fabien Chouteau wrote: This patch adds a simple ARP table in Slirp and also adds handling of gratuitous ARP requests. Signed-off-by: Fabien Chouteau chout...@adacore.com --- Makefile.objs |2 +- slirp/arp_table.c | 50

Re: [Qemu-devel] [PATCH V2 2/2] [SLIRP] Delayed IP packets

2011-07-29 Thread Jan Kiszka
On 2011-07-29 18:25, Fabien Chouteau wrote: In the current implementation, if Slirp tries to send an IP packet to a client with an unknown hardware address, the packet is simply dropped and an ARP request is sent (if_encap in slirp/slirp.c). With this patch, Slirp will send the ARP request,

Re: [Qemu-devel] [libvirt] How to connect to the running VM

2011-07-29 Thread bala suru
Hi, Let me tell clearly , i'm trying to manage VMs using opennebula toolkit , I downloaded the ttylinux image from opennebula site , the Image I downloaded was already created from kvm by opennebula community , so I can use it to deploy on kvm. link for this is -

[Qemu-devel] [PATCH] Fix gcc-4.6 compiler error

2011-07-29 Thread Stefan Weil
Commit 3d3b8303c6f83b9b245bc774af530a6403cc4ce6 breaks builds with gcc-4.6: hw/fw_cfg.c: In function ‘probe_splashfile’: hw/fw_cfg.c:66:9: error: variable ‘fop_ret’ set but not used [-Werror=unused-but-set-variable] hw/fw_cfg.c: In function ‘fw_cfg_bootsplash’: hw/fw_cfg.c:130:9: error: variable

[Qemu-devel] [PATCH] tcg/arm: Fix compiler error caused by unused function

2011-07-29 Thread Stefan Weil
Function tcg_out_addi is obviously unused and causes a compiler error (tested with cross compilation on x86 Debian Linux): tcg/arm/tcg-target.c:1824: error: ‘tcg_out_addi’ defined but not used Don't remove it because it might be useful in the future, but declare it inline. This fixes the

[Qemu-devel] [PATCH] configure: Fix bad shell expression for non-Linux hosts

2011-07-29 Thread Stefan Weil
With vhost_net= (most non-Linux hosts), configure prints an error message: test: 2551: =: unexpected operator Fix this and similar code by adding the missing . Cc: Wolfgang Mauerer wolfgang.maue...@siemens.com Cc: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Signed-off-by: Stefan Weil

[Qemu-devel] [RFC PATCH v2 0/3] separate thread for VM migration

2011-07-29 Thread Umesh Deshpande
Following patch deals with VCPU and iothread starvation during the migration of a guest. Currently the iothread is responsible for performing the guest migration. It holds qemu_mutex during the migration and doesn't allow VCPU to enter the qemu mode and delays its return to the guest. The guest

[Qemu-devel] [RFC PATCH v2 1/3] separate thread for VM migration

2011-07-29 Thread Umesh Deshpande
This patch creates a separate thread for the guest migration on the source side. Signed-off-by: Umesh Deshpande udesh...@redhat.com --- buffered_file.c | 28 - buffered_file.h |4 +++ migration.c | 59 +++---

[Qemu-devel] [RFC PATCH v2 2/3] fine grained qemu_mutex locking for migration

2011-07-29 Thread Umesh Deshpande
In the migration thread, qemu_mutex is released during the most time consuming part. i.e. during is_dup_page which identifies the uniform data pages and during the put_buffer. qemu_mutex is also released while blocking on select to wait for the descriptor to become ready for writes.

[Qemu-devel] [RFC PATCH v2 3/3] Per memslot dirty bitmap

2011-07-29 Thread Umesh Deshpande
This patch creates a separate dirty bitmap for each slot. Currently dirty bitmap is created for addresses ranging from 0 to the end address of the last memory slot. Since the memslots are not necessarily contiguous, current bitmap might contain empty region or holes that doesn't represent any VM

Re: [Qemu-devel] [RFC PATCH 0/4] Fix subsection ambiguity in the migration format

2011-07-29 Thread Anthony Liguori
On 07/29/2011 10:18 AM, Kevin Wolf wrote: Am 29.07.2011 16:28, schrieb Anthony Liguori: The one change for backends is that if we migrate a device in way so that it can say I need the block backend with the ID 'foo', then we can at least make sure that the backend actually exists and is usable.

[Qemu-devel] [PATCH] Fix forcing multicast msgs to loopback on OpenBSD.

2011-07-29 Thread Brad
Fix forcing multicast msgs to loopback on OpenBSD. e.g. $ sudo qemu -m 128 -no-fd-bootchk \ -hda virtual.img -boot n -nographic \ -net nic,vlan=0,model=rtl8139,macaddr=52:54:00:12:34:03 \ -net user -tftp /usr/src/sys/arch/i386/compile/TEST -bootp pxeboot \ -net

Re: [Qemu-devel] [PATCH] Fix gcc-4.6 compiler error

2011-07-29 Thread Peter Maydell
On 29 July 2011 20:30, Stefan Weil w...@mail.berlios.de wrote: Commit 3d3b8303c6f83b9b245bc774af530a6403cc4ce6 breaks builds with gcc-4.6: hw/fw_cfg.c: In function ‘probe_splashfile’: hw/fw_cfg.c:66:9: error: variable ‘fop_ret’ set but not used [-Werror=unused-but-set-variable]

[Qemu-devel] [ANNOUNCE] QEMU 0.15.0-rc1 Release

2011-07-29 Thread Anthony Liguori
Hi, On behalf of the entire QEMU team, I'm please to announce the release of QEMU 0.15.0-rc1. This is the second release candidate for the 0.15.0 release. There are numerous ways you can help participate in the 0.15.0 release. There is a testing coordination wiki page located at:

Re: [Qemu-devel] [PATCH 44/55] spitz tosa: Simplify drive is suitable for microdrive test

2011-07-29 Thread andrzej zaborowski
On 20 July 2011 18:24, Markus Armbruster arm...@redhat.com wrote: We try the drive defined with -drive if=ide,index=0 (or equivalent sugar).  We use it only if (dinfo bdrv_is_inserted(dinfo-bdrv) !bdrv_is_removable(dinfo-bdrv)).  This is a convoluted way to test for drive media can't be

Re: [Qemu-devel] [PATCH 1/6] VMDK: enable twoGbMaxExtentFlat

2011-07-29 Thread Fam Zheng
Enable the createType 'twoGbMaxExtentFlat'. The supporting code is already in. Signed-off-by: Fam Zheng famc...@gmail.com --- block/vmdk.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 37478d2..e22a893 100644 --- a/block/vmdk.c +++

Re: [Qemu-devel] [PATCH v5] Add support for Zipit Z2 machine

2011-07-29 Thread andrzej zaborowski
On 6 July 2011 15:52, Vasily Khoruzhick anars...@gmail.com wrote: Zipit Z2 is small PXA270 based handheld. Thanks, I pushed this version. Cheers

Re: [Qemu-devel] [PATCH 15/15] hw/onenand: program actions can only clear bits

2011-07-29 Thread andrzej zaborowski
On 29 July 2011 17:35, Peter Maydell peter.mayd...@linaro.org wrote: From: Juha Riihimäki juha.riihim...@nokia.com The program actions onenand_prog_main() and onenand_prog_spare() can only set bits. This implies a rewrite of onenand_erase() to not use the program functions, since erase does

[Qemu-devel] [PATCH] Add support for finding libpng via pkg-config

2011-07-29 Thread Brad
Add support for finding libpng via pkg-config. Signed-off-by: Brad Smith b...@comstyle.com --- configure |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 4012d15..25aa75f 100755 --- a/configure +++ b/configure @@ -1519,11 +1519,17 @@ int

Re: [Qemu-devel] [PATCH 2/7] sd: fix card size checking on R/W accesses

2011-07-29 Thread andrzej zaborowski
Hi Vincent, On 26 July 2011 01:19, Vincent Palatin vpala...@chromium.org wrote: We need to check that we are not crossing the boundaries of the card for the current access not for the next one which might not happen. Signed-off-by: Vincent Palatin vpala...@chromium.org ---  hw/sd.c |   22

Re: [Qemu-devel] [PATCH v2] usb-hid: Fix 0/0 position for Windows in tablet mode

2011-07-29 Thread andrzej zaborowski
On 13 July 2011 23:05, Andreas Färber andreas.faer...@web.de wrote: Am 12.07.2011 um 09:47 schrieb Jan Kiszka: On 2011-07-04 20:15, andrzej zaborowski wrote: On 26 June 2011 11:11, Jan Kiszka jan.kis...@web.de wrote: On 2011-06-25 15:10, Andreas Färber wrote: Am 25.06.2011 um 14:55

Re: [Qemu-devel] [PATCH] user: Restore debug usage message for '-d ?' in user mode emulation

2011-07-29 Thread andrzej zaborowski
On 18 July 2011 12:44, Peter Maydell peter.mayd...@linaro.org wrote: The code which prints the debug usage message on '-d ?' for *-user has to come before the check for not enough arguments, so that qemu-foo -d ? prints the list of possible debug log items rather than the generic usage