[Qemu-devel] Question about posixaio thread number.

2011-08-03 Thread Gui Jianfeng
Hi Anthony, I started a guest with cache=none and aio=threads When i did some io tests in Guest say dd like dd if=/dev/zero oflag=direct of=/mnt/sdb1/date.img bs=4k count=262114 qemu will start one or several threads to perform IO requests. It seems qemu makes use of its own posixaio. I'm

Re: [Qemu-devel] [PATCH] remove cross prefix from pkg-config command

2011-08-03 Thread Paolo Bonzini
On 08/02/2011 11:01 PM, Stefan Weil wrote: I run cross builds for arm, mips, powerpc and mingw. All of them use the cross prefix. When running make, I neither want to specify a special PATH nor a PKG_CONFIG_PATH. All I need is something like make -C bin/arm (each cross target has its own

Re: [Qemu-devel] [PATCH] migration: remove subsections in fdc and rtl8139 and bump versions

2011-08-03 Thread Paolo Bonzini
On 08/03/2011 02:12 AM, Anthony Liguori wrote: Paolo's proposed changes make newer QEMUs use a new protocol. It's still possible to read the older protocol. This means that you can't migrate new to old, but can migrate old to new. Not really true, with my series you can migrate new to old if

Re: [Qemu-devel] modelling omap_gpmc with the hierarchical memory API

2011-08-03 Thread Avi Kivity
On 08/03/2011 05:33 AM, Anthony Liguori wrote: On 08/02/2011 04:29 PM, Avi Kivity wrote: On 08/03/2011 12:06 AM, Anthony Liguori wrote: The qdev level should be the common base that makes sense for *all* qdev devices. IRQ management does not belong in DeviceState because what you do for a

[Qemu-devel] Question about posixaio thread number.

2011-08-03 Thread Gui Jianfeng
Hi Anthony, I started a guest with cache=none and aio=threads When i did some io tests in Guest say dd like dd if=/dev/zero oflag=direct of=/mnt/sdb1/date.img bs=4k count=262114 qemu will start one or several threads to perform IO requests. It seems qemu makes use of its own posixaio. I'm

Re: [Qemu-devel] Question about posixaio thread number.

2011-08-03 Thread Stefan Hajnoczi
On Wed, Aug 3, 2011 at 6:19 AM, Gui Jianfeng guijianf...@cn.fujitsu.com wrote: When i did some io tests in Guest say dd like dd if=/dev/zero oflag=direct of=/mnt/sdb1/date.img bs=4k count=262114 qemu will start one or several threads to perform IO requests. It seems qemu makes use of its own

Re: [Qemu-devel] [PATCH] do not call monitor_resume() from migrate_fd_put_buffer() error path

2011-08-03 Thread Michael Tokarev
So, can we decide on this somehow? I don't see a code path where we don't call monitor_resume at the end, so the intermediate monitor_resume can be dropped. This way we fix real bug. If there will be other problem from that, it can be fixed later - this will mean that code path is found...

[Qemu-devel] [Patch] virtio: security patch

2011-08-03 Thread Supriya Kannery
For security purpose, convert 'int i' to 'unsigned int i' in virtio functions, so that range of index is restricted to positive value. Signed-off-by: Supriya Kannery (supri...@linux.vnet.ibm.com) --- hw/virtio.c | 27 +-- hw/virtio.h |3 ++- 2 files changed, 19

Re: [Qemu-devel] QEMU 0.15.0-rc2 delayed to 08/03/11

2011-08-03 Thread Michael Walle
I want -rc2 to be the final build so I'm delaying -rc3 until tomorrow so we can sort out how to handle this migration issue. Ok, one more try :) Anthony, could you please commit the following small patch to the 0.15 branch: http://lists.nongnu.org/archive/html/qemu-devel/2011-07/msg02183.html

Re: [Qemu-devel] [PATCH 44/55] spitz tosa: Simplify drive is suitable for microdrive test

2011-08-03 Thread Markus Armbruster
Peter Maydell peter.mayd...@linaro.org writes: On 1 August 2011 13:33, Markus Armbruster arm...@redhat.com wrote: andrzej zaborowski balr...@gmail.com writes: On 20 July 2011 18:24, Markus Armbruster arm...@redhat.com wrote: We try the drive defined with -drive if=ide,index=0 (or equivalent

[Qemu-devel] ethlite mac on virtex board

2011-08-03 Thread Lê Đức Tài
Hi Edgar, I have a problem with Ethernet Lite on Virtex board as following. Could you help me? Thank you! [Modify device tree - linux-2.6.37] diff --git a/arch/powerpc/boot/dts/virtex440-ml507.dts b/arch/powerpc/boot/dts/virtex440-ml507.dts index 9cf6081..acc8406 100644 ---

Re: [Qemu-devel] [PULL] pci, virtio, net

2011-08-03 Thread Markus Armbruster
Michael S. Tsirkin m...@redhat.com writes: The following changes since commit d1afc48b7cfdb4490f322d5d82a2aae6d545ec06: SPARC64: implement addtional MMU faults related to nonfaulting load (2011-07-21 20:02:22 +) are available in the git repository at:

Re: [Qemu-devel] [PULL] pci, virtio, net

2011-08-03 Thread Michael S. Tsirkin
On Wed, Aug 03, 2011 at 10:15:03AM +0200, Markus Armbruster wrote: Michael S. Tsirkin m...@redhat.com writes: The following changes since commit d1afc48b7cfdb4490f322d5d82a2aae6d545ec06: SPARC64: implement addtional MMU faults related to nonfaulting load (2011-07-21 20:02:22 +)

Re: [Qemu-devel] [PATCH] memory: use signed arithmetic

2011-08-03 Thread Avi Kivity
On 08/03/2011 01:15 AM, Richard Henderson wrote: On 08/02/2011 03:06 PM, Avi Kivity wrote: I don't think there's any cpu which has a real 64-bit physical address space? Don't they all truncate it? I don't know. You're right that x86_64 does, at 48 bits. The alpha system I'm trying to

Re: [Qemu-devel] [PATCH] migration: remove subsections in fdc and rtl8139 and bump versions (v2)

2011-08-03 Thread Kevin Wolf
Am 03.08.2011 02:18, schrieb Anthony Liguori: As Paolo points out, the migration protocol is ambiguous when using subsections today. That means that even if we preserve subsections and change the protocol accordingly, the old protocol w/subsections is still ambiguous. Remove subsection

[Qemu-devel] [PATCH 00/16] SCSI sense and target request overhaul

2011-08-03 Thread Paolo Bonzini
This is a pretty important step in the modernization and improvement of the SCSI backends, and a prerequisite for pretty much everything that is on the table: migration, addressing, improved CD-ROM support, hotplug. The series touches two main parts: 1) sense data. Autosense is made a

[Qemu-devel] [PATCH 02/16] vscsi: always use get_sense

2011-08-03 Thread Paolo Bonzini
vscsi supports autosensing by providing sense data directly in the response. When get_sense was added, the older state machine approach that sent REQUEST SENSE commands separately was left in place. Remove it, all existing SCSIDevices do support autosensing and the next patches will make the

[Qemu-devel] [PATCH 12/16] scsi: move handling of REQUEST SENSE to common code

2011-08-03 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi-bus.c | 12 ++-- hw/scsi-disk.c|9 ++--- hw/scsi-generic.c | 16 3 files changed, 12 insertions(+), 25 deletions(-) diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c index 139f6a6..fbb9801 100644

[Qemu-devel] [PATCH v2] memory: use signed arithmetic

2011-08-03 Thread Avi Kivity
When trying to map an alias of a ram region, where the alias starts at address A and we map it into address B, and A B, we had an arithmetic underflow. Because we use unsigned arithmetic, the underflow converted into a large number which failed addrrange_intersects() tests. The concrete example

Re: [Qemu-devel] [Patch] virtio: security patch

2011-08-03 Thread Stefan Hajnoczi
On Wed, Aug 3, 2011 at 8:56 AM, Supriya Kannery supri...@linux.vnet.ibm.com wrote: For security purpose, convert  'int i' to 'unsigned int i' in virtio functions, so that range of index is restricted to positive value. Signed-off-by: Supriya Kannery (supri...@linux.vnet.ibm.com) ---  

Re: [Qemu-devel] [PATCH] migration: remove subsections in fdc and rtl8139 and bump versions

2011-08-03 Thread Juan Quintela
Anthony Liguori aligu...@us.ibm.com wrote: On 08/02/2011 06:25 PM, Juan Quintela wrote: Anthony Liguorialigu...@us.ibm.com wrote: As Paolo points out, the migration protocol is ambiguous when using subsections today. That means that even if we preserve subsections and change the protocol

Re: [Qemu-devel] qemu-kvm aborts - vhost_dev_unassign_memory: Assertion `to = 0' failed.

2011-08-03 Thread Avi Kivity
On 08/01/2011 08:44 PM, David Ahern wrote: qemu-kvm.git as of: commit dacdc4b10bafbb21120e1c24a9665444768ef999 Merge: 7b69d4f 0af4922 Author: Avi Kivitya...@redhat.com Date: Sun Jul 31 11:42:26 2011 +0300 Merge branch 'upstream-merge' into next is aborting with the error: qemu-kvm:

Re: [Qemu-devel] [Request for Help] QEMU 0.15.0 change log

2011-08-03 Thread Philipp Hahn
Hello, On Monday 25 July 2011 16:18:07 Anthony Liguori wrote: Hands down, 0.14.0 had the best change log of any QEMU release. A large part of the success of the change log was how many people participated in creating it. I'd love for us to go even further with 0.15.0. I've created a

Re: [Qemu-devel] modelling omap_gpmc with the hierarchical memory API

2011-08-03 Thread Peter Maydell
On 3 August 2011 03:25, Anthony Liguori anth...@codemonkey.ws wrote: On 08/02/2011 04:28 PM, Peter Maydell wrote: Typically in the latter case the device we're talking to will also provide some gpio or irq signals, which will be routed in a totally different direction having nothing to do with

[Qemu-devel] [PATCH 11/16] scsi: move handling of REPORT LUNS and invalid LUNs to common code

2011-08-03 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi-bus.c | 175 - hw/scsi-defs.h|3 + hw/scsi-disk.c| 21 -- hw/scsi-generic.c |7 -- 4 files changed, 177 insertions(+), 29 deletions(-) diff --git

Re: [Qemu-devel] [PATCH V4 1/2] [SLIRP] Simple ARP table

2011-08-03 Thread Jan Kiszka
On 2011-08-02 15:19, Fabien Chouteau wrote: This patch adds a simple ARP table in Slirp and also adds handling of gratuitous ARP requests. Signed-off-by: Fabien Chouteau chout...@adacore.com --- Makefile.objs |2 +- slirp/arp_table.c | 71

[Qemu-devel] [PATCH 04/16] scsi: move sense handling to generic code

2011-08-03 Thread Paolo Bonzini
With this patch, sense data is stored in the generic data structures for SCSI devices and requests. The SCSI layer takes care of storing sense data in the SCSIDevice for the subsequent REQUEST SENSE command. At the same time, get_sense is removed and scsi_req_get_sense can use an entirely

[Qemu-devel] [PATCH 10/16] scsi: move request parsing to common code

2011-08-03 Thread Paolo Bonzini
Also introduce the first occurrence of independent SCSIReqOps, to handle invalid commands in common code. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi-bus.c | 53 ++--- hw/scsi-disk.c|5 - hw/scsi-generic.c |9

Re: [Qemu-devel] modelling omap_gpmc with the hierarchical memory API

2011-08-03 Thread Avi Kivity
On 08/03/2011 12:10 PM, Peter Maydell wrote: [*] I did convince myself that you do want a sysbus bus on each chip select, because in theory in the hardware you could put an external address decoder on the gpmc_a[] bus and hang multiple devices off one chipselect. So that's a sysbus, really.

[Qemu-devel] [PATCH 08/16] scsi: introduce SCSICommand

2011-08-03 Thread Paolo Bonzini
This struct is currently unnamed. Give it a name and use it explicitly to decouple (some parts of) CDB parsing from SCSIRequest. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi-bus.c | 95 + hw/scsi.h | 17 ++

Re: [Qemu-devel] qemu-kvm aborts - vhost_dev_unassign_memory: Assertion `to = 0' failed.

2011-08-03 Thread Wen Congyang
At 08/03/2011 05:01 PM, Avi Kivity Write: On 08/01/2011 08:44 PM, David Ahern wrote: qemu-kvm.git as of: commit dacdc4b10bafbb21120e1c24a9665444768ef999 Merge: 7b69d4f 0af4922 Author: Avi Kivitya...@redhat.com Date: Sun Jul 31 11:42:26 2011 +0300 Merge branch 'upstream-merge' into

[Qemu-devel] [PATCH 15/16] scsi: report unit attention on reset

2011-08-03 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi-bus.c |3 ++- hw/scsi-disk.c|4 ++-- hw/scsi-generic.c |4 ++-- hw/scsi.h |2 +- 4 files changed, 7 insertions(+), 6 deletions(-) diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c index a5bb517..f6fb4f0 100644

[Qemu-devel] [PATCH 07/16] scsi: pass cdb already to scsi_req_new

2011-08-03 Thread Paolo Bonzini
Right now the CDB is not passed to the SCSIBus until scsi_req_enqueue. Passing it to scsi_req_new will let scsi_req_new dispatch common requests through different reqops. Moving the memcpy to scsi_req_new is a hack that will go away as soon as scsi_req_new will also take care of the parsing.

[Qemu-devel] [PATCH 06/16] scsi: move request-related callbacks from SCSIDeviceInfo to SCSIReqOps

2011-08-03 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi-bus.c | 20 ++-- hw/scsi-disk.c| 24 ++-- hw/scsi-generic.c | 12 ++-- hw/scsi.h | 13 +++-- 4 files changed, 29 insertions(+), 40 deletions(-) diff --git

[Qemu-devel] [PATCH 13/16] scsi: add a bunch more common sense codes

2011-08-03 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi-bus.c | 30 ++ hw/scsi.h | 12 2 files changed, 42 insertions(+), 0 deletions(-) diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c index fbb9801..0e2e4cd 100644 --- a/hw/scsi-bus.c +++

[Qemu-devel] [PATCH 01/16] scsi-disk: no need to call scsi_req_data on a short read

2011-08-03 Thread Paolo Bonzini
In fact, if the HBA's transfer_data callback goes on with scsi_req_continue the request will be completed successfully instead of showing a failure. It can even cause a segmentation fault. An easy way to trigger it is eject -f cd during installation (during media test if the installer does

[Qemu-devel] [PATCH 03/16] scsi: pass status when completing

2011-08-03 Thread Paolo Bonzini
A small improvement in the SCSI request API. Pass the status at the time the request is completed, so that we can assert that no request is completed twice. This would have detected the problem fixed in the previous patch. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi-bus.c

[Qemu-devel] [PATCH 14/16] scsi: add support for unit attention conditions

2011-08-03 Thread Paolo Bonzini
Unit attention conditions override any sense data the device already has. Their signaling and clearing is handled entirely by the SCSIBus code, and they are completely transparent to the SCSIDevices. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi-bus.c | 93

Re: [Qemu-devel] [PATCH] Revert qxl: set mm_time in vga update

2011-08-03 Thread Gerd Hoffmann
On 08/01/11 12:21, Alon Levy wrote: This reverts commit 22795174a37e02200944c0d093d518e832650686. Without this patch the windows logo animation during boot time was correct, with it it jumps backwards and forwards erratically. Looking at how the x11 qxl driver generates mm_time I see it just

[Qemu-devel] [PATCH 05/16] scsi: introduce SCSIReqOps

2011-08-03 Thread Paolo Bonzini
This will let allow requests to be dispatched through different callbacks, either common or per-device. This patch adjusts the API, the next one will move members to SCSIReqOps. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi-bus.c |5 +++-- hw/scsi-disk.c| 30

[Qemu-devel] [PATCH 09/16] scsi: push lun field to SCSIDevice

2011-08-03 Thread Paolo Bonzini
This will let SCSIBus detect requests sent to an invalid LUN, and handle them itself. However, there will be still support for only one LUN per target Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi-bus.c |1 + hw/scsi-generic.c |5 + hw/scsi.h |1 + 3

[Qemu-devel] [PATCH 16/16] scsi: add special traces for common commands

2011-08-03 Thread Paolo Bonzini
Can be useful when debugging the device scan phase. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi-bus.c | 17 + trace-events |4 2 files changed, 21 insertions(+), 0 deletions(-) diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c index f6fb4f0..143c7eb 100644

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Correctly assign PCI domain numbers

2011-08-03 Thread Stefan Hajnoczi
On Mon, Aug 01, 2011 at 01:10:38PM +0300, Michael S. Tsirkin wrote: On Mon, Aug 01, 2011 at 04:51:02PM +1000, David Gibson wrote: qemu already almost supports PCI domains; that is, several entirely independent PCI host bridges on the same machine. However, a bug in pci_bus_new_inplace()

[Qemu-devel] [PATCH 3/3] Makefile: delete config.log in distclean

2011-08-03 Thread Stefan Hajnoczi
From: Alexandre Raymond cerb...@gmail.com Distclean should remove anything created by the configure script. Signed-off-by: Alexandre Raymond cerb...@gmail.com Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- Makefile |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Correctly assign PCI domain numbers

2011-08-03 Thread Michael S. Tsirkin
On Wed, Aug 03, 2011 at 11:13:15AM +0100, Stefan Hajnoczi wrote: On Mon, Aug 01, 2011 at 01:10:38PM +0300, Michael S. Tsirkin wrote: On Mon, Aug 01, 2011 at 04:51:02PM +1000, David Gibson wrote: qemu already almost supports PCI domains; that is, several entirely independent PCI host

[Qemu-devel] [PATCH 02/11] spice: add qemu_spice_display_init_common

2011-08-03 Thread Gerd Hoffmann
Factor out SimpleSpiceDisplay initialization into qemu_spice_display_init_common() and call it from both qxl.c (for vga mode) and spice-display.c Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/qxl.c |7 +-- ui/spice-display.c | 17 +++-- ui/spice-display.h

[Qemu-devel] [PULL] spice: async i/o for qxl

2011-08-03 Thread Gerd Hoffmann
Hi, This spice/qxl pull fixes (for the most part) a design flaw in the qxl device interface. Some write operations to qxl I/O ports are blocking, i.e. they wait for the spice server finish some work, then return to the guest. Which adds noticable latencies. This patch series adds non-blocking

[Qemu-devel] [PATCH 08/11] qxl: only disallow specific io's in vga mode

2011-08-03 Thread Gerd Hoffmann
From: Alon Levy al...@redhat.com Since the driver is still in operation even after moving to UNDEFINED, i.e. by destroying primary in any way. Signed-off-by: Alon Levy al...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/qxl.c |3 ++- 1 files changed, 2 insertions(+), 1

[Qemu-devel] [PATCH 07/11] qxl: make qxl_guest_bug take variable arguments

2011-08-03 Thread Gerd Hoffmann
From: Alon Levy al...@redhat.com Signed-off-by: Alon Levy al...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/qxl.c |9 +++-- hw/qxl.h |2 +- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 28c8b5d..c50eaf9 100644 ---

[Qemu-devel] [PATCH 01/11] spice: add worker wrapper functions.

2011-08-03 Thread Gerd Hoffmann
Add wrapper functions for all spice worker calls. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/qxl-render.c|4 +- hw/qxl.c | 32 +- ui/spice-display.c | 95 --- ui/spice-display.h | 22

[Qemu-devel] [PATCH 10/11] qxl: add QXL_IO_FLUSH_{SURFACES, RELEASE} for guest S3S4 support

2011-08-03 Thread Gerd Hoffmann
From: Alon Levy al...@redhat.com Add two new IOs. QXL_IO_FLUSH_SURFACES - equivalent to update area for all surfaces, used to reduce vmexits from NumSurfaces to 1 on guest S3, S4 and resolution change (windows driver implementation is such that this is done on each of those occasions).

[Qemu-devel] [PATCH 11/11] qxl: bump pci rev

2011-08-03 Thread Gerd Hoffmann
Inform guest drivers about the new features I/O commands we have now (async commands, S3 support) if building with newer spice, i.e. if SPICE_INTERFACE_QXL_MINOR = 1. sneaked in some 81+ column line spliting. Signed-off-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Alon Levy

Re: [Qemu-devel] [PATCH V4 1/2] [SLIRP] Simple ARP table

2011-08-03 Thread Fabien Chouteau
On 03/08/2011 11:13, Jan Kiszka wrote: On 2011-08-02 15:19, Fabien Chouteau wrote: This patch adds a simple ARP table in Slirp and also adds handling of gratuitous ARP requests. ... Looks good now and work here as well. Great! One last thing (I swear): We need a proper license header for

[Qemu-devel] [PATCH V5 1/2] [SLIRP] Simple ARP table

2011-08-03 Thread Fabien Chouteau
This patch adds a simple ARP table in Slirp and also adds handling of gratuitous ARP requests. Signed-off-by: Fabien Chouteau chout...@adacore.com --- Makefile.objs |2 +- slirp/arp_table.c | 95 + slirp/bootp.c | 21 +++

[Qemu-devel] [PATCH 05/11] qxl: add io_port_to_string

2011-08-03 Thread Gerd Hoffmann
From: Alon Levy al...@redhat.com Signed-off-by: Alon Levy al...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/qxl.c | 40 +++- 1 files changed, 39 insertions(+), 1 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 416bd48..6e66021

[Qemu-devel] [PATCH 09/11] qxl: async io support using new spice api

2011-08-03 Thread Gerd Hoffmann
From: Alon Levy al...@redhat.com Some of the QXL port i/o commands are waiting for the spice server to complete certain actions. Add async versions for these commands, so we don't block the vcpu while the spice server processses the command. Instead the qxl device will raise an IRQ when done.

[Qemu-devel] [PATCH 04/11] qxl: fix surface tracking locking

2011-08-03 Thread Gerd Hoffmann
Surface tracking needs proper locking since it is used from vcpu and spice worker threads, add it. Also reset the surface counter when zapping all surfaces. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/qxl.c | 13 - hw/qxl.h |2 ++ 2 files changed, 14 insertions(+), 1

[Qemu-devel] [PATCH 03/11] spice/qxl: move worker wrappers

2011-08-03 Thread Gerd Hoffmann
Move the wrapper functions which are used by qxl only to qxl.c. Rename them from qemu_spice_* to qxl_spice_*. Also pass in a qxl state pointer instead of a SimpleSpiceDisplay pointer. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/qxl-render.c|4 +- hw/qxl.c | 67

[Qemu-devel] [PATCH 06/11] qxl: error handling fixes and cleanups.

2011-08-03 Thread Gerd Hoffmann
Add qxl_guest_bug() function which is supposed to be called in case sanity checks of guest requests fail. It raises an error IRQ and logs a message in case guest debugging is enabled. Make PANIC_ON() abort instead of exit. That macro should be used for qemu bugs only, any guest-triggerable

[Qemu-devel] [PATCH 1/3] slirp: Take maintainer token

2011-08-03 Thread Jan Kiszka
Anthony asked me to pick up the maintenance of this subsystem, and I agreed. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- MAINTAINERS |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 6115e4e..7cbcd7e 100644 --- a/MAINTAINERS +++

[Qemu-devel] [PATCH 3/3] Delayed IP packets

2011-08-03 Thread Jan Kiszka
From: Fabien Chouteau chout...@adacore.com In the current implementation, if Slirp tries to send an IP packet to a client with an unknown hardware address, the packet is simply dropped and an ARP request is sent (if_encap in slirp/slirp.c). With this patch, Slirp will send the ARP request,

[Qemu-devel] [PATCH 0/3] [PULL] slirp: ARP table improvements

2011-08-03 Thread Jan Kiszka
The following changes since commit 927d721777e73339f73719f36eaf400ab641366c: microblaze: Add missing call to qemu_init_vcpu. (2011-07-31 06:40:13 +0200) are available in the git repository at: git://git.kiszka.org/qemu.git queues/slirp Anthony asked me to look after slirp patches, and I

[Qemu-devel] [PATCH 2/3] Simple ARP table

2011-08-03 Thread Jan Kiszka
From: Fabien Chouteau chout...@adacore.com This patch adds a simple ARP table in Slirp and also adds handling of gratuitous ARP requests. Signed-off-by: Fabien Chouteau chout...@adacore.com Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- Makefile.objs |2 +- slirp/arp_table.c |

Re: [Qemu-devel] qemu-kvm aborts - vhost_dev_unassign_memory: Assertion `to = 0' failed.

2011-08-03 Thread Avi Kivity
On 08/01/2011 08:44 PM, David Ahern wrote: qemu-kvm.git as of: commit dacdc4b10bafbb21120e1c24a9665444768ef999 Merge: 7b69d4f 0af4922 Author: Avi Kivitya...@redhat.com Date: Sun Jul 31 11:42:26 2011 +0300 Merge branch 'upstream-merge' into next is aborting with the error: qemu-kvm:

Re: [Qemu-devel] [PATCH] memory: use signed arithmetic

2011-08-03 Thread Benjamin Herrenschmidt
On Wed, 2011-08-03 at 11:26 +0300, Avi Kivity wrote: On 08/03/2011 01:15 AM, Richard Henderson wrote: On 08/02/2011 03:06 PM, Avi Kivity wrote: I don't think there's any cpu which has a real 64-bit physical address space? Don't they all truncate it? I don't know. You're right that

[Qemu-devel] [PATCH v2 01/38] pci: add API to get a BAR's mapped address

2011-08-03 Thread Avi Kivity
This is a hack, for devices that have a back-channel to read this address back outside the normal configuration mechanisms, such as VMware svga. Reviewed-by: Richard Henderson r...@twiddle.net Signed-off-by: Avi Kivity a...@redhat.com --- hw/pci.c |5 + hw/pci.h |1 + 2 files

[Qemu-devel] [PATCH v2 00/38] Memory API, batch 2: PCI devices

2011-08-03 Thread Avi Kivity
This is a mostly mindless conversion of all QEMU PCI devices to the memory API. After this patchset is applied, it is no longer possible to create a PCI device using the old API. An immediate benefit is that PCI BARs that overlap each other are now handled correctly: currently, the sequence

[Qemu-devel] [PATCH v2 13/38] ac97: convert to memory API

2011-08-03 Thread Avi Kivity
fixes BAR sizing as well. Reviewed-by: Richard Henderson r...@twiddle.net Signed-off-by: Avi Kivity a...@redhat.com --- hw/ac97.c | 88 +++- 1 files changed, 51 insertions(+), 37 deletions(-) diff --git a/hw/ac97.c b/hw/ac97.c index

[Qemu-devel] [PATCH v2 21/38] intel-hda: convert to memory API

2011-08-03 Thread Avi Kivity
Reviewed-by: Richard Henderson r...@twiddle.net Signed-off-by: Avi Kivity a...@redhat.com --- hw/intel-hda.c | 35 +++ 1 files changed, 19 insertions(+), 16 deletions(-) diff --git a/hw/intel-hda.c b/hw/intel-hda.c index 5a2bc3a..1e4c71e 100644 ---

[Qemu-devel] [PATCH v2 24/38] ne2000: convert to memory API

2011-08-03 Thread Avi Kivity
Reviewed-by: Richard Henderson r...@twiddle.net Signed-off-by: Avi Kivity a...@redhat.com --- hw/ne2000-isa.c | 14 +++--- hw/ne2000.c | 77 +- hw/ne2000.h |8 + 3 files changed, 59 insertions(+), 40 deletions(-) diff

[Qemu-devel] [PATCH v2 32/38] msix: convert to memory API

2011-08-03 Thread Avi Kivity
The msix table is defined as a subregion, to allow for a BAR that mixes device specific regions with the msix table. Reviewed-by: Richard Henderson r...@twiddle.net Signed-off-by: Avi Kivity a...@redhat.com --- hw/ivshmem.c| 11 + hw/msix.c | 64

[Qemu-devel] [PATCH v2 17/38] ide: convert to memory API

2011-08-03 Thread Avi Kivity
Reviewed-by: Richard Henderson r...@twiddle.net Signed-off-by: Avi Kivity a...@redhat.com --- hw/ide/cmd646.c | 208 +++ hw/ide/pci.c| 25 --- hw/ide/pci.h| 19 - hw/ide/piix.c | 64 + hw/ide/via.c|

[Qemu-devel] [PATCH v2 27/38] isa-mmio: concert to memory API

2011-08-03 Thread Avi Kivity
Reviewed-by: Richard Henderson r...@twiddle.net Signed-off-by: Avi Kivity a...@redhat.com --- hw/isa.h |2 ++ hw/isa_mmio.c | 30 +++--- 2 files changed, 17 insertions(+), 15 deletions(-) diff --git a/hw/isa.h b/hw/isa.h index d2b6126..f1f2181 100644 ---

Re: [Qemu-devel] [PATCH 44/55] spitz tosa: Simplify drive is suitable for microdrive test

2011-08-03 Thread andrzej zaborowski
On 3 August 2011 10:12, Markus Armbruster arm...@redhat.com wrote: Peter Maydell peter.mayd...@linaro.org writes: On 1 August 2011 13:33, Markus Armbruster arm...@redhat.com wrote: andrzej zaborowski balr...@gmail.com writes: On 20 July 2011 18:24, Markus Armbruster arm...@redhat.com wrote:

Re: [Qemu-devel] [PATCH] Avoid allocating TCG resources in non-TCG mode

2011-08-03 Thread Anthony PERARD
On Tue, Aug 2, 2011 at 15:10, Jan Kiszka jan.kis...@siemens.com wrote: Do not allocate TCG-only resources like the translation buffer when running over KVM or XEN. Saves a few bytes in the qemu address space and is also conceptually cleaner. Signed-off-by: Jan Kiszka jan.kis...@siemens.com

Re: [Qemu-devel] qemu-kvm aborts - vhost_dev_unassign_memory: Assertion `to = 0' failed.

2011-08-03 Thread Michael S. Tsirkin
On Wed, Aug 03, 2011 at 02:48:05PM +0300, Avi Kivity wrote: On 08/01/2011 08:44 PM, David Ahern wrote: qemu-kvm.git as of: commit dacdc4b10bafbb21120e1c24a9665444768ef999 Merge: 7b69d4f 0af4922 Author: Avi Kivitya...@redhat.com Date: Sun Jul 31 11:42:26 2011 +0300 Merge branch

[Qemu-devel] Stellaris RCC2 Support

2011-08-03 Thread Engin AYDOGAN
Based on the work http://patchwork.ozlabs.org/patch/31469/ , here's the patch for HEAD. From f91c8fb57b599b59f603b2fd9c81c6f9d7e3aad6 Mon Sep 17 00:00:00 2001 From: Engin AYDOGAN en...@bzzzt.biz Date: Wed, 3 Aug 2011 00:36:47 -0700 Subject: [PATCH] Stellaris RCC2 support Signed-off-by: Engin

[Qemu-devel] [PATCH] monitor: HMP: fix consecutive integer expression parsing

2011-08-03 Thread Alon Levy
Currently a command that takes two consecutive integer operations, like client_migrate_info, will be incorrectly parsed by the human monitor if the second expression begins with a minus ('-') or plus ('+') sign: client_migrate_info protocol hostname port tls-port client_migrate_info spice

[Qemu-devel] [PATCH v2 07/38] vga: simplify vga window mmio access functions

2011-08-03 Thread Avi Kivity
Make use of the memory API's ability to satisfy multi-byte accesses via multiple single-byte accesses. We have to keep vga_mem_{read,write}b() since they're used by cirrus. Reviewed-by: Richard Henderson r...@twiddle.net Signed-off-by: Avi Kivity a...@redhat.com --- hw/cirrus_vga.c |4 +-

Re: [Qemu-devel] [SeaBIOS] SeaBIOS error with Juniper FreeBSD kernel

2011-08-03 Thread Bjørn Mork
Kevin O'Connor ke...@koconnor.net writes: On Tue, Aug 02, 2011 at 11:33:09AM +0200, Bjørn Mork wrote: Kevin O'Connor ke...@koconnor.net writes: Also, it's possible the code could try to use the f-segment if there are less than say 16 cpus and use high memory when more cpus are present.

[Qemu-devel] [PATCH v2 22/38] lsi53c895a: convert to memory API

2011-08-03 Thread Avi Kivity
An optimization that fast-pathed DMA reads from the SCRIPTS memory was removed int the process. Likely it breaks with iommus anyway. Reviewed-by: Richard Henderson r...@twiddle.net Signed-off-by: Avi Kivity a...@redhat.com --- hw/lsi53c895a.c | 258

[Qemu-devel] [PATCH v2 25/38] pcnet: convert to memory API

2011-08-03 Thread Avi Kivity
Also related chips. Reviewed-by: Richard Henderson r...@twiddle.net Signed-off-by: Avi Kivity a...@redhat.com --- hw/lance.c | 31 ++- hw/pcnet-pci.c | 74 +-- hw/pcnet.h |4 ++- 3 files changed, 61

[Qemu-devel] [PATCH v2 08/38] cirrus: simplify linear framebuffer access functions

2011-08-03 Thread Avi Kivity
Make use of the memory API's ability to satisfy multi-byte accesses via multiple single-byte accesses. Reviewed-by: Richard Henderson r...@twiddle.net Signed-off-by: Avi Kivity a...@redhat.com --- hw/cirrus_vga.c | 74 ++- 1 files changed, 8

[Qemu-devel] [PATCH v2 11/38] pci: allow I/O BARs to be registered with pci_register_bar_region()

2011-08-03 Thread Avi Kivity
Reviewed-by: Richard Henderson r...@twiddle.net Signed-off-by: Avi Kivity a...@redhat.com --- hw/pci.c | 43 +++ hw/pci.h |1 + hw/pci_internals.h |3 ++- 3 files changed, 26 insertions(+), 21 deletions(-) diff --git

Re: [Qemu-devel] qemu-kvm aborts - vhost_dev_unassign_memory: Assertion `to = 0' failed.

2011-08-03 Thread Michael S. Tsirkin
On Mon, Aug 01, 2011 at 11:44:23AM -0600, David Ahern wrote: qemu-kvm.git as of: commit dacdc4b10bafbb21120e1c24a9665444768ef999 Merge: 7b69d4f 0af4922 Author: Avi Kivity a...@redhat.com Date: Sun Jul 31 11:42:26 2011 +0300 Merge branch 'upstream-merge' into next is aborting

[Qemu-devel] [PATCH v2 34/38] pci: convert pci rom to memory API

2011-08-03 Thread Avi Kivity
Reviewed-by: Richard Henderson r...@twiddle.net Signed-off-by: Avi Kivity a...@redhat.com --- hw/pci.c | 20 +++- hw/pci.h |3 ++- 2 files changed, 9 insertions(+), 14 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 6aca1af..481eb7e 100644 --- a/hw/pci.c +++ b/hw/pci.c

[Qemu-devel] [PATCH v2 08/45] ide: Reject ATA commands specific to drive kinds

2011-08-03 Thread Markus Armbruster
ACS-2 Table B.2 explicitly prohibits ATAPI devices from implementing WIN_RECAL, WIN_READ_EXT, WIN_READDMA_EXT, WIN_READ_NATIVE_MAX, WIN_MULTREAD_EXT, WIN_WRITE, WIN_WRITE_ONCE, WIN_WRITE_EXT, WIN_WRITEDMA_EXT, WIN_MULTWRITE_EXT, WIN_WRITE_VERIFY, WIN_VERIFY, WIN_VERIFY_ONCE, WIN_VERIFY_EXT,

[Qemu-devel] [PATCH v2 16/45] scsi-disk: Track tray locked state

2011-08-03 Thread Markus Armbruster
We already track it in BlockDriverState. Just like tray open/close state, we should track it in the device models instead, because it's device state. Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/scsi-disk.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git

[Qemu-devel] [PATCH v2 03/45] block: Split change_cb() into change_media_cb(), resize_cb()

2011-08-03 Thread Markus Armbruster
Multiplexing callbacks complicates matters needlessly. Signed-off-by: Markus Armbruster arm...@redhat.com --- block.c | 23 +++ block.h | 12 +++- block_int.h |3 --- hw/ide/core.c |8 ++-- hw/sd.c |8 ++--

[Qemu-devel] [PATCH v2 04/45] ide: Update command code definitions as per ACS-2 Table B.2

2011-08-03 Thread Markus Armbruster
Drop WIN_SRST, it has the same value as WIN_DEVICE_RESET. Drop unused WIN_RESTORE, it has the same value as WIN_RECAL. Drop codes that are not implemented and long obsolete: WIN_READ_LONG, WIN_READ_LONG_ONCE, WIN_WRITE_LONG, WIN_WRITE_LONG_ONCE, WIN_FORMAT (all obsolete since ATA4),

[Qemu-devel] [PATCH v2 28/38] sun4u: convert to memory API

2011-08-03 Thread Avi Kivity
fixes memory leak on repeated BAR map/unmap Reviewed-by: Richard Henderson r...@twiddle.net Signed-off-by: Avi Kivity a...@redhat.com --- hw/sun4u.c | 55 +-- 1 files changed, 25 insertions(+), 30 deletions(-) diff --git a/hw/sun4u.c

[Qemu-devel] [PATCH v2 24/45] scsi-disk: Avoid physical/virtual tray state mismatch

2011-08-03 Thread Markus Armbruster
When scsi-cd is backed by a physical drive, we want the physical tray match the virtual one. To that end, we call bdrv_eject() on guest's load/eject, and bdrv_lock_medium() on guest's prevent/allow removal. But we don't set the initial state on device model init. Fix that. While there, also

Re: [Qemu-devel] [PATCH] lm32: softusb: claim to support full speed

2011-08-03 Thread Gerd Hoffmann
On 07/21/11 20:52, Michael Walle wrote: The QEMU keyboard and mouse reports themselves as full speed devices, though they are actually low speed devices. Until this is fixed, claim that we are supporting full speed devices. Signed-off-by: Michael Wallemich...@walle.cc For both master+stable:

[Qemu-devel] [PATCH v2 00/45] Block layer cleanup fixes

2011-08-03 Thread Markus Armbruster
This patch series looks bigger than it is. All the patches are small and hopefully easy to review. Objectives: * Push BlockDriverState members locked, tray_open, media_changed into device models, where they belong. * BlockDriverState member removable is a confusing mess, replace it. *

Re: [Qemu-devel] [PATCH] do not call monitor_resume() from migrate_fd_put_buffer() error path

2011-08-03 Thread Jan Kiszka
On 2011-08-03 09:38, Michael Tokarev wrote: So, can we decide on this somehow? I don't see a code path where we don't call monitor_resume at the end, so the intermediate monitor_resume can be dropped. This way we fix real bug. If there will be other problem from that, it can be fixed later

[Qemu-devel] [PATCH v2 19/45] block: Rename bdrv_set_locked() to bdrv_lock_medium()

2011-08-03 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- block.c |8 block.h |2 +- block/raw-posix.c |8 block/raw.c |6 +++--- block_int.h |2 +- hw/ide/atapi.c|2 +- hw/scsi-disk.c|2 +- trace-events |

[Qemu-devel] [PATCH v2 28/45] block/raw: Fix to forward method bdrv_media_changed()

2011-08-03 Thread Markus Armbruster
Block driver raw forwards most methods to the underlying block driver. However, it doesn't implement method bdrv_media_changed(). Makes bdrv_media_changed() always return -ENOTSUP. I believe -fda /dev/fd0 gives you raw over host_floppy, and disk change detection (fdc register 7 bit 7) is broken.

[Qemu-devel] [PATCH v2 43/45] nbd: Clean up use of block_int.h

2011-08-03 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- block/nbd.c |1 + nbd.c |1 + nbd.h |2 -- 3 files changed, 2 insertions(+), 2 deletions(-) diff --git a/block/nbd.c b/block/nbd.c index 7a52f62..2e365ac 100644 --- a/block/nbd.c +++ b/block/nbd.c @@ -28,6 +28,7 @@

[Qemu-devel] [PATCH v2 18/45] block: Drop medium lock tracking, ask device models instead

2011-08-03 Thread Markus Armbruster
Requires new BlockDevOps member is_medium_locked(). Implement for IDE and SCSI CD-ROMs. Signed-off-by: Markus Armbruster arm...@redhat.com --- block.c| 16 +--- block.h|8 +++- block_int.h|1 - blockdev.c |2 +- hw/ide/core.c |6 ++

[Qemu-devel] [PATCH v2 23/45] scsi-disk: Fix START_STOP to fail when it can't eject

2011-08-03 Thread Markus Armbruster
Don't fail when tray is already open. Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/scsi-bus.c | 10 ++ hw/scsi-disk.c | 15 +++ hw/scsi.h |4 3 files changed, 25 insertions(+), 4 deletions(-) diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c index

  1   2   3   >