Re: [Qemu-devel] [PATCH] pci: add standard bridge device

2011-09-07 Thread Wen Congyang
At 09/07/2011 07:52 PM, Michael S. Tsirkin Write: > On Wed, Sep 07, 2011 at 12:39:09PM +0800, Wen Congyang wrote: >> At 09/06/2011 03:45 PM, Avi Kivity Write: >>> On 09/06/2011 06:06 AM, Wen Congyang wrote: > Use the uio driver - > http://docs.blackfin.uclinux.org/kernel/generated/uio-how

[Qemu-devel] [PATCH v2] Fix X86 CPU topology in KVM mode

2011-09-07 Thread bharata . rao
From: Bharata B Rao apic id returned to guest kernel in ebx for cpuid(function=1) depends on CPUX86State->cpuid_apic_id which gets populated after the cpuid information is cached in the host kernel. This results in broken CPU topology in guest. Fix this by setting cpuid_apic_id before cpuid info

Re: [Qemu-devel] [PATCH 1/2] qemu-img: async write to block device when converting image

2011-09-07 Thread Sage Weil
On Wed, 7 Sep 2011, Yehuda Sadeh wrote: > In order to improve image conversion process, instead of synchronously > writing the destingation image, we keep a window of async writes. > > Signed-off-by: Yehuda Sadeh Small fix below: > --- > qemu-img.c | 28 +++- > 1 file

[Qemu-devel] buildbot failure in qemu on pci_x86_64_debian_6_0

2011-09-07 Thread qemu
The Buildbot has detected a new failure on builder pci_x86_64_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/pci_x86_64_debian_6_0/builds/24 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki Build Rea

[Qemu-devel] buildbot failure in qemu on pci_i386_debian_6_0

2011-09-07 Thread qemu
The Buildbot has detected a new failure on builder pci_i386_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/pci_i386_debian_6_0/builds/24 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki Build Reason:

[Qemu-devel] configure: Detect predefined compiler symbols for ARM and HPPA

2011-09-07 Thread Brad
configure: Detect predefined compiler symbols for ARM and HPPA To be able to detect some ARM / HPPA based architectures such as with OpenBSD/(armish / zaurus) or OpenBSD/hppa. Signed-off-by: Brad Smith --- configure |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git

Re: [Qemu-devel] [PATCH V8 08/14] Introduce file lock for the block layer

2011-09-07 Thread Stefan Berger
On 09/07/2011 02:49 PM, Michael S. Tsirkin wrote: On Wed, Sep 07, 2011 at 12:08:22PM -0400, Stefan Berger wrote: On 09/07/2011 11:16 AM, Michael S. Tsirkin wrote: So it's a bug in the code then? From what I saw, yes. Migration is not complete until the passwords had been entered. Though the

Re: [Qemu-devel] [RFC PATCH V1 00/14] Dynamic machine model creation from device trees

2011-09-07 Thread John Williams
On Fri, Sep 2, 2011 at 12:45 PM, John Williams wrote: > On Fri, Aug 26, 2011 at 7:17 AM, Anthony Liguori wrote: > >> On 08/25/2011 03:20 PM, Edgar E. Iglesias wrote: >> >>> On Thu, Aug 25, 2011 at 02:54:13PM -0500, Anthony Liguori wrote: >>> On 08/25/2011 02:10 PM, Edgar E. Iglesias wrote: >>

Re: [Qemu-devel] [PATCH V8 10/14] Encrypt state blobs using AES CBC encryption

2011-09-07 Thread Stefan Berger
On 09/07/2011 02:55 PM, Michael S. Tsirkin wrote: On Thu, Sep 01, 2011 at 10:23:51PM -0400, Stefan Berger wrote: An additional 'layer' for reading and writing the blobs to the underlying block storage is added. This layer encrypts the blobs for writing if a key is available. Similarly it decrypt

[Qemu-devel] [PATCH 1/2] build: fix missing trace dep on GENERATED_HEADERS

2011-09-07 Thread Michael Roth
fc764105 added an include for qemu-common.h to trace/control.h, which made all users of this header file dependent on GENERATED_HEADERS. Since it's used by pretty much all the trace backends now, make trace-obj-y dependent on GENERATED_HEADERS. Signed-off-by: Michael Roth --- Makefile.objs |

[Qemu-devel] [PATCH 2/2] build: fix race with creating qapi-generated

2011-09-07 Thread Michael Roth
Since qapi-generated/ is a global QEMU include path, we need to make sure it is created before anything is compiled, so do this in the configure phase rather than via the Makefile. Signed-off-by: Michael Roth --- configure |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a

Re: [Qemu-devel] [PATCH 00/15] Convert commands to QAPI (batch 1) (v2)

2011-09-07 Thread Michael Roth
On 09/07/2011 05:24 PM, Anthony Liguori wrote: On 09/07/2011 05:04 PM, Alexander Graf wrote: On 08.09.2011, at 00:03, Anthony Liguori wrote: On 09/07/2011 04:56 PM, Alexander Graf wrote: On 02.09.2011, at 19:34, Anthony Liguori wrote: This is my attempt to jump-start the QAPI switch over.

[Qemu-devel] [PATCH 1/2] qemu-img: async write to block device when converting image

2011-09-07 Thread Yehuda Sadeh
In order to improve image conversion process, instead of synchronously writing the destingation image, we keep a window of async writes. Signed-off-by: Yehuda Sadeh --- qemu-img.c | 28 +++- 1 files changed, 23 insertions(+), 5 deletions(-) diff --git a/qemu-img.c b/qe

[Qemu-devel] [PATCH 2/2] qemu-img: don't skip writing small holes

2011-09-07 Thread Yehuda Sadeh
When doing convert, we check that the sectors that are written are not empty. When holes are small, and interleaved with data it can lead to a significant performance issue. Signed-off-by: Yehuda Sadeh --- qemu-img.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/q

[Qemu-devel] [PATCH 0/2] improve qemu-img conversion performance

2011-09-07 Thread Yehuda Sadeh
The following set of patches improve the qemu-img conversion process performance. When using a higher latency backend, small writes have a severe impact on the time it takes to do image conversion. We switch to using async writes, and we avoid splitting writes due to holes when the holes are small

Re: [Qemu-devel] [PATCH 00/15] Convert commands to QAPI (batch 1) (v2)

2011-09-07 Thread Anthony Liguori
On 09/07/2011 05:04 PM, Alexander Graf wrote: On 08.09.2011, at 00:03, Anthony Liguori wrote: On 09/07/2011 04:56 PM, Alexander Graf wrote: On 02.09.2011, at 19:34, Anthony Liguori wrote: This is my attempt to jump-start the QAPI switch over. All of the hard work is already done in my qap

Re: [Qemu-devel] [PATCH 00/15] Convert commands to QAPI (batch 1) (v2)

2011-09-07 Thread Alexander Graf
On 08.09.2011, at 00:03, Anthony Liguori wrote: > On 09/07/2011 04:56 PM, Alexander Graf wrote: >> >> On 02.09.2011, at 19:34, Anthony Liguori wrote: >> >>> This is my attempt to jump-start the QAPI switch over. All of the hard work >>> is already done in my qapi branch, we just need to start

Re: [Qemu-devel] [PATCH 00/15] Convert commands to QAPI (batch 1) (v2)

2011-09-07 Thread Anthony Liguori
On 09/07/2011 04:56 PM, Alexander Graf wrote: On 02.09.2011, at 19:34, Anthony Liguori wrote: This is my attempt to jump-start the QAPI switch over. All of the hard work is already done in my qapi branch, we just need to start merging stuff. To simplify the merge process, I've introduced a n

Re: [Qemu-devel] [PATCH 00/15] Convert commands to QAPI (batch 1) (v2)

2011-09-07 Thread Alexander Graf
On 02.09.2011, at 19:34, Anthony Liguori wrote: > This is my attempt to jump-start the QAPI switch over. All of the hard work > is already done in my qapi branch, we just need to start merging stuff. > > To simplify the merge process, I've introduced a new mode to the code > generator > that l

Re: [Qemu-devel] [PATCH] Only build with -g CFLAGS/LDFLAGS if using --enable-debug and add --optflags.

2011-09-07 Thread Stefan Weil
Am 06.09.2011 18:30, schrieb Brad: - Original message - On 09/06/11 10:02, Brad wrote: Only build with -g CFLAGS/LDFLAGS if using --enable-debug. Add --optflags to allow overriding the default optimization level added to CFLAGS. This is a first draft of coming up with a patch I could p

[Qemu-devel] [Bug 568614] Re: x86_64 host curses interface: spacing/garbling

2011-09-07 Thread Nino Wagensonner
a it worked, just tried it with latest stable 0.15 git !!! finally you are my hero! =) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/568614 Title: x86_64 host curses interface: spacing/garbling

[Qemu-devel] [Bug 568614] Re: x86_64 host curses interface: spacing/garbling

2011-09-07 Thread Devin J. Pohly
Alright, I've sent a patch to qemu-devel. Let's see what happens now... -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/568614 Title: x86_64 host curses interface: spacing/garbling Status in QEMU:

Re: [Qemu-devel] [RESEND][PATCH] booke timers

2011-09-07 Thread Alexander Graf
On 07.09.2011, at 16:41, Fabien Chouteau wrote: > On 06/09/2011 21:33, Alexander Graf wrote: >> >> >> Am 01.09.2011 um 10:20 schrieb Fabien Chouteau : >> >>> While working on the emulation of the freescale p2010 (e500v2) I realized >>> that >>> there's no implementation of booke's timers feat

Re: [Qemu-devel] [RFC PATCH 0/5] VFIO-NG group/device/iommu framework

2011-09-07 Thread Alexander Graf
On 01.09.2011, at 21:50, Alex Williamson wrote: > Trying to move beyond talking about how VFIO should work to > re-writing the code. This is pre-alpha, known broken, will > probably crash your system but it illustrates some of how > I see groups, devices, and iommus interacting. This is just >

Re: [Qemu-devel] broken screendump for text mode?

2011-09-07 Thread Andriy Gapon
on 30/08/2011 19:50 Andriy Gapon said the following: > > I use Qemu 0.15.0 (via a FreeBSD qemu-devel-0.15.0 port) and observe the > following > problem with the screendump command. > > Environment: > - qemu started with a standard vga adapter emulation (not sure if this > important) > - SDL int

[Qemu-devel] [PATCH] curses: fix garbling when chtype != long

2011-09-07 Thread Devin J. Pohly
From: "Devin J. Pohly" Qemu currently assumes that chtype is typedef'd to unsigned long, but this is not necessarily the case (ncurses, for instance, can configure this at build-time). This patch uses the predefined chtype if qemu is configured for curses support and falls back to unsigned long

Re: [Qemu-devel] [PATCH] Only build with -g CFLAGS/LDFLAGS if using --enable-debug and add --optflags.

2011-09-07 Thread Blue Swirl
On Wed, Sep 7, 2011 at 10:54 AM, Juan Quintela wrote: > Brad wrote: >> - Original message - >>> On 09/06/11 10:02, Brad wrote: >>> > Only build with -g CFLAGS/LDFLAGS if using --enable-debug. >>> > Add --optflags to allow overriding the default optimization >>> > level added to CFLAGS. >>

Re: [Qemu-devel] [PATCH -V2] iohandler: update qemu_fd_set_handler to work with null call back arg

2011-09-07 Thread Aneesh Kumar K.V
On Wed, 07 Sep 2011 13:44:39 -0500, Anthony Liguori wrote: > On 09/07/2011 07:30 AM, Aneesh Kumar K.V wrote: > > Many users of qemu_fd_set_handler including VirtFS use NULL call back arg. > > Update fd_trampoline and qemu_fd_set_handler to work with NULL call back arg > > > > Signed-off-by: Aneesh

Re: [Qemu-devel] target_phys_addr_t vs ram_addr_t

2011-09-07 Thread Sinha, Ani
Thanks guys for the explanations. I'd try and add some comments to the code explaining the apis once I have a better understanding of the code. Right now I am still digesting the undocumented apis. ani On Sep 3, 2011, at 6:14 AM, Peter Maydell wrote: > On 3 September 2011 12:26, Blue Swirl wr

Re: [Qemu-devel] [PATCH 11/31] block/raw: Fix to forward method bdrv_media_changed()

2011-09-07 Thread Blue Swirl
On Tue, Sep 6, 2011 at 3:39 PM, Kevin Wolf wrote: > From: Markus Armbruster > > Block driver "raw" forwards most methods to the underlying block > driver.  However, it doesn't implement method bdrv_media_changed(). > Makes bdrv_media_changed() always return -ENOTSUP. > > I believe -fda /dev/fd0 g

Re: [Qemu-devel] [PATCH 1/2] trace: allow trace events with string arguments

2011-09-07 Thread Blue Swirl
On Tue, Sep 6, 2011 at 2:24 PM, Stefan Hajnoczi wrote: > On Mon, Sep 05, 2011 at 07:45:36PM +, Blue Swirl wrote: >> On Mon, Sep 5, 2011 at 3:37 PM, Stefan Hajnoczi >> wrote: >> > String arguments are useful for producing human-readable traces without >> > post-processing (e.g. stderr backend)

Re: [Qemu-devel] [PATCH] [SPARC] Gdbstub: Fix back-trace on SPARC32

2011-09-07 Thread Blue Swirl
On Tue, Sep 6, 2011 at 10:38 AM, Fabien Chouteau wrote: > On 05/09/2011 21:22, Blue Swirl wrote: >> On Mon, Sep 5, 2011 at 9:33 AM, Fabien Chouteau wrote: >>> On 03/09/2011 11:25, Blue Swirl wrote: On Thu, Sep 1, 2011 at 2:17 PM, Fabien Chouteau wrote: > Gdb expects all registers

Re: [Qemu-devel] [RFC PATCH 4/5] VFIO: Add PCI device support

2011-09-07 Thread Konrad Rzeszutek Wilk
On Thu, Sep 01, 2011 at 01:50:50PM -0600, Alex Williamson wrote: > Signed-off-by: Alex Williamson > --- > > drivers/vfio/Kconfig|7 ++ > drivers/vfio/Makefile |1 > drivers/vfio/vfio_main.c| 10 +++ > drivers/vfio/vfio_pci.c | 124 >

Re: [Qemu-devel] [PATCH V8 10/14] Encrypt state blobs using AES CBC encryption

2011-09-07 Thread Michael S. Tsirkin
On Thu, Sep 01, 2011 at 10:23:51PM -0400, Stefan Berger wrote: > >>An additional 'layer' for reading and writing the blobs to the underlying > >>block storage is added. This layer encrypts the blobs for writing if a key > >>is > >>available. Similarly it decrypts the blobs after reading. So a cou

[Qemu-devel] [Bug 568614] Re: x86_64 host curses interface: spacing/garbling

2011-09-07 Thread Nino Wagensonner
no I don't believe it was your fault I couldn't get the code compile even without your patch... man this sucks... i had hoped it would be upstream with 0.15 but I might have to try to compile it by myself again thanks ;) -- You received this bug notification because you are a member of qemu- de

Re: [Qemu-devel] [PATCH V8 08/14] Introduce file lock for the block layer

2011-09-07 Thread Michael S. Tsirkin
On Wed, Sep 07, 2011 at 12:08:22PM -0400, Stefan Berger wrote: > On 09/07/2011 11:16 AM, Michael S. Tsirkin wrote: > >On Wed, Sep 07, 2011 at 11:06:42AM -0400, Stefan Berger wrote: > >>On 09/07/2011 10:35 AM, Michael S. Tsirkin wrote: > >>>On Wed, Sep 07, 2011 at 10:25:08AM -0400, Stefan Berger wro

[Qemu-devel] [PATCH] iohandlers: fix issue with qemu_set_fd_handler()

2011-09-07 Thread Anthony Liguori
As spotted by Aneesh, some users pass a NULL opaque so we need to be more aggressive in checking whether a user means to unregister. Also fix a double free caused by tag not being reset to zero after delete. Signed-off-by: Anthony Liguori --- iohandler.c |7 ++- 1 files changed, 2 inser

Re: [Qemu-devel] [PATCH -V2] iohandler: update qemu_fd_set_handler to work with null call back arg

2011-09-07 Thread Anthony Liguori
On 09/07/2011 07:30 AM, Aneesh Kumar K.V wrote: Many users of qemu_fd_set_handler including VirtFS use NULL call back arg. Update fd_trampoline and qemu_fd_set_handler to work with NULL call back arg Signed-off-by: Aneesh Kumar K.V --- Changes from V1: Add support for dropping event source

Re: [Qemu-devel] [PATCH] KVM: emulate lapic tsc deadline timer for hvm

2011-09-07 Thread Liu, Jinsong
Avi Kivity wrote: > On 09/07/2011 07:45 PM, Liu, Jinsong wrote: >> Avi Kivity wrote: --- a/arch/x86/include/asm/msr-index.h +++ b/arch/x86/include/asm/msr-index.h @@ -229,6 +229,8 @@ #define MSR_IA32_APICBASE_ENABLE(1<<11) #define MSR_IA32_APICBASE_BA

Re: [Qemu-devel] [PATCH] KVM: emulate lapic tsc deadline timer for hvm

2011-09-07 Thread Avi Kivity
On 09/07/2011 07:45 PM, Liu, Jinsong wrote: Avi Kivity wrote: >> >> --- a/arch/x86/include/asm/msr-index.h >> +++ b/arch/x86/include/asm/msr-index.h >> @@ -229,6 +229,8 @@ >>#define MSR_IA32_APICBASE_ENABLE(1<<11) >>#define MSR_IA32_APICBASE_BASE (0xf<<12) >> >> +

Re: [Qemu-devel] [PATCH] KVM: emulate lapic tsc deadline timer for hvm

2011-09-07 Thread Liu, Jinsong
Avi Kivity wrote: >> >> --- a/arch/x86/include/asm/msr-index.h >> +++ b/arch/x86/include/asm/msr-index.h >> @@ -229,6 +229,8 @@ >> #define MSR_IA32_APICBASE_ENABLE (1<<11) >> #define MSR_IA32_APICBASE_BASE (0xf<<12) >> >> +#define MSR_IA32_TSCDEADLINE0x06

[Qemu-devel] [PATCH 3/3] rbd: fix leak in qemu_rbd_open failure paths

2011-09-07 Thread Sage Weil
Fix leak of s->snap in failure path. Simplify error paths for the whole function. Reported-by: Stefan Hajnoczi Signed-off-by: Sage Weil --- block/rbd.c | 28 +--- 1 files changed, 13 insertions(+), 15 deletions(-) diff --git a/block/rbd.c b/block/rbd.c index 2763092.

[Qemu-devel] [PATCH 2/3] rbd: clean up, fix style

2011-09-07 Thread Sage Weil
No assignment in condition. Remove duplicate ret > 0 check. Signed-off-by: Sage Weil --- block/rbd.c | 17 - 1 files changed, 8 insertions(+), 9 deletions(-) diff --git a/block/rbd.c b/block/rbd.c index 6135fc1..2763092 100644 --- a/block/rbd.c +++ b/block/rbd.c @@ -391,15 +3

[Qemu-devel] [PATCH 1/3] rbd: allow client id to be specified in config string

2011-09-07 Thread Sage Weil
Allow the client id to be specified in the config string via 'id=' so that users can control who they authenticate as. Currently they are stuck with the default ('admin'). This is necessary for anyone using authentication in their environment. Signed-off-by: Sage Weil --- block/rbd.c | 52 ++

[Qemu-devel] Suspicious code in qcow2.

2011-09-07 Thread Frediano Ziglio
Actually it does not cause problems but this code order seems a bit wrong to me (block/qcow2-cluster.c) QLIST_INSERT_HEAD(&s->cluster_allocs, m, next_in_flight); /* allocate a new cluster */ cluster_offset = qcow2_alloc_clusters(bs, nb_clusters * s->cluster_size); if (cluster_of

Re: [Qemu-devel] [PATCH V8 08/14] Introduce file lock for the block layer

2011-09-07 Thread Stefan Berger
On 09/07/2011 11:16 AM, Michael S. Tsirkin wrote: On Wed, Sep 07, 2011 at 11:06:42AM -0400, Stefan Berger wrote: On 09/07/2011 10:35 AM, Michael S. Tsirkin wrote: On Wed, Sep 07, 2011 at 10:25:08AM -0400, Stefan Berger wrote: On 09/07/2011 10:10 AM, Michael S. Tsirkin wrote: On Wed, Sep 07, 2

Re: [Qemu-devel] TCG sar UB (fwd)

2011-09-07 Thread malc
On Sun, 4 Sep 2011, malc wrote: > On Sun, 4 Sep 2011, Richard Henderson wrote: > > > On 09/03/2011 03:47 PM, malc wrote: > > > Doesn't make much sense to me, guest clearly asked for 0 and not -1, > > > besides -1 violates TCG's sar constraints and PPC obliges by emiting > > > illegal instruction

[Qemu-devel] [PATCH v2] vns/tls: don't use depricated gnutls functions

2011-09-07 Thread Gerd Hoffmann
Avoid using deprecated gnutls functions with recent gnutls versions. Fixes build failure on Fedora 16. Keep the old way for compatibility with old installations such as RHEL-5 (gnutls 1.4.x). Based on a patch from Raghavendra D Prabhu Signed-off-by: Gerd Hoffmann --- ui/vnc-tls.c | 68 +

Re: [Qemu-devel] [PATCH v3 14/27] block: Rename bdrv_set_locked() to bdrv_lock_medium()

2011-09-07 Thread Kevin Wolf
Am 06.09.2011 18:58, schrieb Markus Armbruster: > While there, make the locked parameter bool. > > Signed-off-by: Markus Armbruster > --- > block.c |8 > block.h |2 +- > block/raw-posix.c |8 > block/raw.c |6 +++--- > block_int.h

[Qemu-devel] [PATCH 3/5] dma-helpers: rewrite completion/cancellation

2011-09-07 Thread Paolo Bonzini
This fixes various problems with completion/cancellation: * If DMA encounters a bounce buffer conflict, and the DMA operation is canceled before the bottom half fires, bad things happen. * memory is not unmapped after cancellation, again causing problems when doing DMA to I/O areas * cancellatio

Re: [Qemu-devel] [PATCH v3 02/27] ide: Use a table to declare which drive kinds accept each command

2011-09-07 Thread Kevin Wolf
Am 06.09.2011 18:58, schrieb Markus Armbruster: > No functional change. > > It would be nice to have handler functions in the table, like commit > e1a064f9 did for ATAPI. Left for another day. > > Signed-off-by: Markus Armbruster > --- > hw/ide/core.c | 105 +++

[Qemu-devel] [PATCH 1/5] dma-helpers: rename is_write to to_dev

2011-09-07 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- dma-helpers.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/dma-helpers.c b/dma-helpers.c index 4610ea0..ca97e14 100644 --- a/dma-helpers.c +++ b/dma-helpers.c @@ -42,7 +42,7 @@ typedef struct { BlockDriverAIOCB *acb;

Re: [Qemu-devel] [RFC PATCH 3/5] VFIO: Base framework for new VFIO driver

2011-09-07 Thread Konrad Rzeszutek Wilk
> +static long vfio_iommu_unl_ioctl(struct file *filep, > + unsigned int cmd, unsigned long arg) > +{ > + struct vfio_iommu *viommu = filep->private_data; > + struct vfio_dma_map dm; > + int ret = -ENOSYS; > + > + switch (cmd) { > + case VFIO_IOMMU_M

Re: [Qemu-devel] [PATCH 2/2] main: switch qemu_set_fd_handler to g_io_add_watch

2011-09-07 Thread Paolo Bonzini
On 09/07/2011 04:53 PM, Anthony Liguori wrote: Long term, we use GIOChannels for everything, assuming that's possible at all. More realistically, we could rewrite socket handling on Windows so that we can use g_poll instead of select (don't wait for me doing that). I assume switching to GIO wo

Re: [Qemu-devel] [PATCH] qcow2: removed unused depends_on field

2011-09-07 Thread Kevin Wolf
Am 07.09.2011 16:19, schrieb Frediano Ziglio: > Signed-off-by: Frediano Ziglio > --- > block/qcow2-cluster.c |3 +-- > block/qcow2.h |1 - > 2 files changed, 1 insertions(+), 3 deletions(-) Thanks, applied to the block branch. Kevin

[Qemu-devel] [PATCH 2/5] dma-helpers: allow including from target-independent code

2011-09-07 Thread Paolo Bonzini
Target-independent code cannot construct sglists, but it can take them from the outside as a black box. Allow this. Signed-off-by: Paolo Bonzini --- dma.h |8 ++-- qemu-common.h |1 + 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/dma.h b/dma.h index a6db5ba.

[Qemu-devel] [PATCH 4/5] scsi-disk: commonize iovec creation between reads and writes

2011-09-07 Thread Paolo Bonzini
Also, consistently use qiov.size instead of iov.iov_len. Signed-off-by: Paolo Bonzini --- hw/scsi-disk.c | 42 ++ 1 files changed, 18 insertions(+), 24 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index 9724d0f..d0ac31e 100644 --- a/hw/scsi

[Qemu-devel] [PATCH 5/5] scsi-disk: lazily allocate bounce buffer

2011-09-07 Thread Paolo Bonzini
It will not be needed for reads and writes if the HBA provides a sglist. In addition, this lets scsi-disk refuse commands with an excessive allocation length, as well as limit memory on usual well-behaved guests. Signed-off-by: Paolo Bonzini --- hw/scsi-disk.c | 44

[Qemu-devel] [PATCH 0/5] block: preparatory patches for scatter/gather support

2011-09-07 Thread Paolo Bonzini
These patches are preparatory work for supporting scatter/gather in the SCSI subsystem. Since there would be no HBA actually using it, I am just posting the cleanups, and the fix for CVE-2011-3346 (buffer overflow in the handling of READ CAPACITY 16) that comes for free with the last patch. Paolo

Re: [Qemu-devel] [PATCH V8 08/14] Introduce file lock for the block layer

2011-09-07 Thread Michael S. Tsirkin
On Wed, Sep 07, 2011 at 11:06:42AM -0400, Stefan Berger wrote: > On 09/07/2011 10:35 AM, Michael S. Tsirkin wrote: > >On Wed, Sep 07, 2011 at 10:25:08AM -0400, Stefan Berger wrote: > >>On 09/07/2011 10:10 AM, Michael S. Tsirkin wrote: > >>>On Wed, Sep 07, 2011 at 09:56:52AM -0400, Stefan Berger wro

Re: [Qemu-devel] [PATCH 3/3] vns/tls: don't use depricated gnutls functions

2011-09-07 Thread Stefan Weil
See inline comments below. Am 07.09.2011 15:02, schrieb Gerd Hoffmann: Avoid using depricated gnutls functions with recent gnutls versions. deprecated? Fixes build failure on Fedora 16. Keep the old way for compatibility with old installations such as RHEL-5 (gnutls 1.4.x). Based on a patch

Re: [Qemu-devel] [PATCH V8 08/14] Introduce file lock for the block layer

2011-09-07 Thread Stefan Berger
On 09/07/2011 10:35 AM, Michael S. Tsirkin wrote: On Wed, Sep 07, 2011 at 10:25:08AM -0400, Stefan Berger wrote: On 09/07/2011 10:10 AM, Michael S. Tsirkin wrote: On Wed, Sep 07, 2011 at 09:56:52AM -0400, Stefan Berger wrote: On 09/07/2011 09:16 AM, Michael S. Tsirkin wrote: On Wed, Sep 07, 2

Re: [Qemu-devel] [PATCH 2/2] main: switch qemu_set_fd_handler to g_io_add_watch

2011-09-07 Thread Anthony Liguori
On 09/07/2011 09:40 AM, Paolo Bonzini wrote: On 09/07/2011 02:42 PM, Anthony Liguori wrote: On 09/07/2011 02:03 AM, Paolo Bonzini wrote: On 09/06/2011 05:59 PM, Anthony Liguori wrote: So it should be possible to add a new Source type that just selects on a file descriptor and avoid GIOChannels

Re: [Qemu-devel] [RESEND][PATCH] booke timers

2011-09-07 Thread Fabien Chouteau
On 06/09/2011 21:33, Alexander Graf wrote: > > > Am 01.09.2011 um 10:20 schrieb Fabien Chouteau : > >> While working on the emulation of the freescale p2010 (e500v2) I realized >> that >> there's no implementation of booke's timers features. Currently mpc8544 uses >> ppc_emb (ppc_emb_timers_ini

Re: [Qemu-devel] [PATCH 2/2] main: switch qemu_set_fd_handler to g_io_add_watch

2011-09-07 Thread Paolo Bonzini
On 09/07/2011 02:42 PM, Anthony Liguori wrote: On 09/07/2011 02:03 AM, Paolo Bonzini wrote: On 09/06/2011 05:59 PM, Anthony Liguori wrote: So it should be possible to add a new Source type that just selects on a file descriptor and avoid GIOChannels? I think you still have the problem that gl

Re: [Qemu-devel] [PATCH V8 08/14] Introduce file lock for the block layer

2011-09-07 Thread Michael S. Tsirkin
On Wed, Sep 07, 2011 at 10:25:08AM -0400, Stefan Berger wrote: > On 09/07/2011 10:10 AM, Michael S. Tsirkin wrote: > >On Wed, Sep 07, 2011 at 09:56:52AM -0400, Stefan Berger wrote: > >>On 09/07/2011 09:16 AM, Michael S. Tsirkin wrote: > >>>On Wed, Sep 07, 2011 at 09:06:05AM -0400, Stefan Berger wro

Re: [Qemu-devel] [PATCH V8 08/14] Introduce file lock for the block layer

2011-09-07 Thread Stefan Berger
On 09/07/2011 10:10 AM, Michael S. Tsirkin wrote: On Wed, Sep 07, 2011 at 09:56:52AM -0400, Stefan Berger wrote: On 09/07/2011 09:16 AM, Michael S. Tsirkin wrote: On Wed, Sep 07, 2011 at 09:06:05AM -0400, Stefan Berger wrote: First: There are two ways to encrypt the data. One comes with the Q

[Qemu-devel] [PATCH] qcow2: removed unused depends_on field

2011-09-07 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- block/qcow2-cluster.c |3 +-- block/qcow2.h |1 - 2 files changed, 1 insertions(+), 3 deletions(-) diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c index e06be64..113db8b 100644 --- a/block/qcow2-cluster.c +++ b/block/qcow2-cluster.c

Re: [Qemu-devel] [PATCH V8 08/14] Introduce file lock for the block layer

2011-09-07 Thread Michael S. Tsirkin
On Wed, Sep 07, 2011 at 09:56:52AM -0400, Stefan Berger wrote: > On 09/07/2011 09:16 AM, Michael S. Tsirkin wrote: > >On Wed, Sep 07, 2011 at 09:06:05AM -0400, Stefan Berger wrote: > First: There are two ways to encrypt the data. > > One comes with the QCoW2 type of image and it comes

Re: [Qemu-devel] [PATCH V8 14/14] Allow to provide inital TPM state

2011-09-07 Thread Michael S. Tsirkin
On Wed, Sep 07, 2011 at 09:51:00AM -0400, Stefan Berger wrote: > On 09/07/2011 07:23 AM, Michael S. Tsirkin wrote: > >On Tue, Sep 06, 2011 at 10:45:34PM -0400, Stefan Berger wrote: > >>On 09/04/2011 12:38 PM, Michael S. Tsirkin wrote: > >>>On Thu, Sep 01, 2011 at 11:00:56PM -0400, Stefan Berger wro

Re: [Qemu-devel] [PATCH V8 08/14] Introduce file lock for the block layer

2011-09-07 Thread Stefan Berger
On 09/07/2011 09:16 AM, Michael S. Tsirkin wrote: On Wed, Sep 07, 2011 at 09:06:05AM -0400, Stefan Berger wrote: First: There are two ways to encrypt the data. One comes with the QCoW2 type of image and it comes for free. Set the encryption flag when creating the QCoW2 file and one has to provi

Re: [Qemu-devel] [PATCH V8 14/14] Allow to provide inital TPM state

2011-09-07 Thread Stefan Berger
On 09/07/2011 07:23 AM, Michael S. Tsirkin wrote: On Tue, Sep 06, 2011 at 10:45:34PM -0400, Stefan Berger wrote: On 09/04/2011 12:38 PM, Michael S. Tsirkin wrote: On Thu, Sep 01, 2011 at 11:00:56PM -0400, Stefan Berger wrote: initstate_fd= initstate_base64=on/off (or base64/bin if you really e

Re: [Qemu-devel] [PATCH 0/6] Device state visualization reloaded

2011-09-07 Thread Michael S. Tsirkin
On Wed, Sep 07, 2011 at 08:23:10AM -0500, Anthony Liguori wrote: > On 09/07/2011 08:17 AM, Michael S. Tsirkin wrote: > >On Wed, Sep 07, 2011 at 03:13:00PM +0200, Jan Kiszka wrote: > >>On 2011-09-07 15:06, Michael S. Tsirkin wrote: > >>>But if the command is not for users at all, if it's > >>>for qe

Re: [Qemu-devel] [PATCH 0/6] Device state visualization reloaded

2011-09-07 Thread Jan Kiszka
On 2011-09-07 15:23, Anthony Liguori wrote: > On 09/07/2011 08:17 AM, Michael S. Tsirkin wrote: >> On Wed, Sep 07, 2011 at 03:13:00PM +0200, Jan Kiszka wrote: >>> On 2011-09-07 15:06, Michael S. Tsirkin wrote: But if the command is not for users at all, if it's for qemu debugging, then ex

Re: [Qemu-devel] [FIX] X86 CPU topology broken in KVM mode

2011-09-07 Thread Anthony Liguori
On 09/07/2011 08:24 AM, Bharata B Rao wrote: On Wed, Sep 7, 2011 at 6:29 PM, Anthony Liguori wrote: On 09/06/2011 11:21 PM, Bharata B Rao wrote: Hi, Please post patches as top-level threads with [PATCH] in the subject. I posted a new thread and hence it has appeared as a top-level thread.

Re: [Qemu-devel] [FIX] X86 CPU topology broken in KVM mode

2011-09-07 Thread Bharata B Rao
On Wed, Sep 7, 2011 at 6:29 PM, Anthony Liguori wrote: > On 09/06/2011 11:21 PM, Bharata B Rao wrote: >> >> Hi, >> > Please post patches as top-level threads with [PATCH] in the subject. I posted a new thread and hence it has appeared as a top-level thread. This was a fix and hence used [FIX], b

Re: [Qemu-devel] [PATCH 0/6] Device state visualization reloaded

2011-09-07 Thread Anthony Liguori
On 09/07/2011 08:17 AM, Michael S. Tsirkin wrote: On Wed, Sep 07, 2011 at 03:13:00PM +0200, Jan Kiszka wrote: On 2011-09-07 15:06, Michael S. Tsirkin wrote: But if the command is not for users at all, if it's for qemu debugging, then exposing internals is a very logical thing. Only problem is

Re: [Qemu-devel] [PATCH V8 08/14] Introduce file lock for the block layer

2011-09-07 Thread Michael S. Tsirkin
On Wed, Sep 07, 2011 at 09:06:05AM -0400, Stefan Berger wrote: > >>First: There are two ways to encrypt the data. > >> > >>One comes with the QCoW2 type of image and it comes for free. Set > >>the encryption flag when creating the QCoW2 file and one has to > >>provide a key to access the QCoW2. I f

Re: [Qemu-devel] [PATCH 0/6] Device state visualization reloaded

2011-09-07 Thread Michael S. Tsirkin
On Wed, Sep 07, 2011 at 03:13:00PM +0200, Jan Kiszka wrote: > On 2011-09-07 15:06, Michael S. Tsirkin wrote: > > But if the command is not for users at all, if it's > > for qemu debugging, then exposing internals is a very > > logical thing. Only problem is - we must make it very very clear > > wh

Re: [Qemu-devel] [PATCH 0/6] Device state visualization reloaded

2011-09-07 Thread Jan Kiszka
On 2011-09-07 15:06, Michael S. Tsirkin wrote: > But if the command is not for users at all, if it's > for qemu debugging, then exposing internals is a very > logical thing. Only problem is - we must make it very very clear > which commands are for qemu debugging. This command it also for users,

Re: [Qemu-devel] [PATCH V8 08/14] Introduce file lock for the block layer

2011-09-07 Thread Stefan Berger
On 09/07/2011 07:18 AM, Michael S. Tsirkin wrote: On Tue, Sep 06, 2011 at 07:55:48PM -0400, Stefan Berger wrote: On 09/04/2011 03:32 PM, Michael S. Tsirkin wrote: On Thu, Sep 01, 2011 at 09:53:40PM -0400, Stefan Berger wrote: Generally, what all other devices do is perform validation as the la

Re: [Qemu-devel] [PATCH 0/6] Device state visualization reloaded

2011-09-07 Thread Michael S. Tsirkin
On Wed, Sep 07, 2011 at 11:37:20AM +0200, Kevin Wolf wrote: > Am 06.09.2011 19:05, schrieb Michael S. Tsirkin: > > On Tue, Sep 06, 2011 at 11:28:09AM -0500, Anthony Liguori wrote: > >> On 09/06/2011 11:09 AM, Michael S. Tsirkin wrote: > >>> On Tue, Sep 06, 2011 at 10:51:26AM -0500, Anthony Liguori

[Qemu-devel] [PATCH 3/3] vns/tls: don't use depricated gnutls functions

2011-09-07 Thread Gerd Hoffmann
Avoid using depricated gnutls functions with recent gnutls versions. Fixes build failure on Fedora 16. Keep the old way for compatibility with old installations such as RHEL-5 (gnutls 1.4.x). Based on a patch from Raghavendra D Prabhu Signed-off-by: Gerd Hoffmann --- ui/vnc-tls.c | 62 +

[Qemu-devel] [PATCH 1/3] Don't use g_thread_get_initialized.

2011-09-07 Thread Gerd Hoffmann
Initialize glib threads unconditionally in main() instead of using g_thread_get_initialized in the 9p code. Fixes a build failure on RHEL-5, which ships glib 2.12. g_thread_get_initialized was added in 2.20. Signed-off-by: Gerd Hoffmann --- hw/9pfs/virtio-9p-coth.c |4 vl.c

[Qemu-devel] [PATCH 0/3] Fix build failures.

2011-09-07 Thread Gerd Hoffmann
Hi, This patch series fixes a bunch of build failures. please apply, Gerd Gerd Hoffmann (3): Don't use g_thread_get_initialized. Use hex instead of binary. vns/tls: don't use depricated gnutls functions hw/9pfs/virtio-9p-coth.c |4 --- target-unicore32/translate.c | 16

[Qemu-devel] [PATCH 2/3] Use hex instead of binary.

2011-09-07 Thread Gerd Hoffmann
Older gcc versions don't understand 0b, use hex representation instead. Fixes build failure on RHEL-5. Signed-off-by: Gerd Hoffmann --- target-unicore32/translate.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/target-unicore32/translate.c b/target-unic

Re: [Qemu-devel] [FIX] X86 CPU topology broken in KVM mode

2011-09-07 Thread Anthony Liguori
On 09/06/2011 11:21 PM, Bharata B Rao wrote: Hi, Sometime back I posted a patch for fixing x86 CPU topology ( http://lists.gnu.org/archive/html/qemu-devel/2011-08/msg02022.html). Here is the next version of the fix which addresses all but one comment received during that post. - Fixed code styl

Re: [Qemu-devel] [PATCH 2/2] main: switch qemu_set_fd_handler to g_io_add_watch

2011-09-07 Thread Avi Kivity
On 09/04/2011 06:01 PM, Anthony Liguori wrote: On 09/04/2011 09:03 AM, Avi Kivity wrote: On 08/22/2011 04:12 PM, Anthony Liguori wrote: This patch changes qemu_set_fd_handler to be implemented in terms of g_io_add_watch(). The semantics are a bit different so some glue is required. qemu_set_fd

[Qemu-devel] [PATCH v8 4/4] qmp/hmp: add block_set_io_throttle

2011-09-07 Thread Zhi Yong Wu
The patch introduce one new command block_set_io_throttle; For its usage syntax, if you have better idea, pls let me know. Signed-off-by: Zhi Yong Wu --- block.c | 26 +++- blockdev.c | 69 +++ blockdev.h

[Qemu-devel] [PATCH v8 3/4] block: add block timer and throttling algorithm

2011-09-07 Thread Zhi Yong Wu
Note: 1.) When bps/iops limits are specified to a small value such as 511 bytes/s, this VM will hang up. We are considering how to handle this senario. 2.) When "dd" command is issued in guest, if its option bs is set to a large value such as "bs=1024K", the result speed will slightly b

Re: [Qemu-devel] [PATCH 2/2] main: switch qemu_set_fd_handler to g_io_add_watch

2011-09-07 Thread Anthony Liguori
On 09/07/2011 02:03 AM, Paolo Bonzini wrote: On 09/06/2011 05:59 PM, Anthony Liguori wrote: So it should be possible to add a new Source type that just selects on a file descriptor and avoid GIOChannels? I think you still have the problem that glib on Windows waits for HANDLEs, not file descri

[Qemu-devel] [PATCH v8 2/4] block: add the command line support

2011-09-07 Thread Zhi Yong Wu
Signed-off-by: Zhi Yong Wu --- block.c | 59 +++ block.h |5 block_int.h |3 ++ blockdev.c | 29 +++ qemu-config.c | 24 ++ qemu-options.hx |1 + 6 fil

[Qemu-devel] [PATCH v8 1/4] block: add the block queue support

2011-09-07 Thread Zhi Yong Wu
Signed-off-by: Zhi Yong Wu --- Makefile.objs |2 +- block/blk-queue.c | 184 + block/blk-queue.h | 59 + block_int.h | 27 4 files changed, 271 insertions(+), 1 deletions(-) create mode 100644 block/b

Re: [Qemu-devel] [PATCH] s390: remove boot image detection to fix boot with newer kernels

2011-09-07 Thread Alexander Graf
On 07.09.2011, at 14:33, Christian Borntraeger wrote: > On 07/09/11 13:56, Alexander Graf wrote: >> >> On 06.09.2011, at 13:41, Christian Borntraeger wrote: >> >>> Alex, >>> >>> Newer kernels will not always have a 0dd0 (basr 13,0) at address 0x1. >>> (e.g. current linux-next). We must not

[Qemu-devel] [PATCH v8 0/4] The intro of QEMU block I/O throttling

2011-09-07 Thread Zhi Yong Wu
The main goal of the patch is to effectively cap the disk I/O speed or counts of one single VM.It is only one draft, so it unavoidably has some drawbacks, if you catch them, please let me know. The patch will mainly introduce one block I/O throttling algorithm, one timer and one block queue for

Re: [Qemu-devel] [PATCH] s390: remove boot image detection to fix boot with newer kernels

2011-09-07 Thread Christian Borntraeger
On 07/09/11 13:56, Alexander Graf wrote: > > On 06.09.2011, at 13:41, Christian Borntraeger wrote: > >> Alex, >> >> Newer kernels will not always have a 0dd0 (basr 13,0) at address 0x1. >> (e.g. current linux-next). We must not rely on specific code at certain >> addresses, so lets just remov

[Qemu-devel] [PATCH -V2] iohandler: update qemu_fd_set_handler to work with null call back arg

2011-09-07 Thread Aneesh Kumar K.V
Many users of qemu_fd_set_handler including VirtFS use NULL call back arg. Update fd_trampoline and qemu_fd_set_handler to work with NULL call back arg Signed-off-by: Aneesh Kumar K.V --- Changes from V1: Add support for dropping event source iohandler.c | 31 +-

Re: [Qemu-devel] [PATCH] ppc: move ADB stuff from ppc_mac.h to adb.h

2011-09-07 Thread Alexander Graf
On 07.09.2011, at 14:13, Laurent Vivier wrote: > Hi, > > > Le 7 septembre 2011 à 14:05, Alexander Graf a écrit : > > > > > On 04.09.2011, at 20:41, Laurent Vivier wrote: > > > > > Allow to use ADB in non-ppc macintosh > > > > What exactly do you need this for? Not saying I'm opposed to

Re: [Qemu-devel] [PATCH] ppc: move ADB stuff from ppc_mac.h to adb.h

2011-09-07 Thread Laurent Vivier
Hi,   Le 7 septembre 2011 à 14:05, Alexander Graf a écrit : > > On 04.09.2011, at 20:41, Laurent Vivier wrote: > > > Allow to use ADB in non-ppc macintosh > > What exactly do you need this for? Not saying I'm opposed to the change - it > looks reasonable to have adb export its own interfaces u

Re: [Qemu-devel] [PATCH] ppc: move ADB stuff from ppc_mac.h to adb.h

2011-09-07 Thread Alexander Graf
On 04.09.2011, at 20:41, Laurent Vivier wrote: > Allow to use ADB in non-ppc macintosh What exactly do you need this for? Not saying I'm opposed to the change - it looks reasonable to have adb export its own interfaces using its own header - but I'd like to understand where you're heading here

  1   2   >