Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-12 Thread Alexander Graf
On 12.09.2011, at 22:21, Blue Swirl wrote: > On Mon, Sep 12, 2011 at 3:20 PM, Alexander Graf wrote: >> Jan Kiszka wrote: >>> Most VGA memory access modes require MMIO handling as they demand weird >>> logic to get a byte from or into the video RAM. However, there is one >>> exception: chain 4 mo

Re: [Qemu-devel] About hotplug multifunction

2011-09-12 Thread Gleb Natapov
On Tue, Sep 13, 2011 at 02:57:20PM +0900, Isaku Yamahata wrote: > On Sun, Sep 11, 2011 at 12:05:17PM +0300, Michael S. Tsirkin wrote: > > On Sat, Sep 10, 2011 at 02:43:11AM +0900, Isaku Yamahata wrote: > > > pci/pcie hot plug needs clean up for multifunction hotplug in long term. > > > Only single

Re: [Qemu-devel] Question on kvm_clock working ...

2011-09-12 Thread Philipp Hahn
Hello Al, I just debugged a kvmclock bug, so I claim to have some knowledge in this area now, but please take my answer with a grain of doubt. On Monday 12 September 2011 15:21:25 al pat wrote: > Still seeking your guidance on this. Appreciate any pointers you may have. You have to distiguish b

Re: [Qemu-devel] [PATCH V12 00/15] virtio-9p: chroot environment for passthrough security model

2011-09-12 Thread M. Mohan Kumar
> I agree, regardless of libvirt's needs, p9fs needs to be secure for any > non-root user using QEMU. As non-root I should be able todo > > $ qemu -virtfs $HOME/shared > > and have strong confidence that symlink attacks can't be used by the > guest to access other locations nuder $HOME. > > >

Re: [Qemu-devel] unable to access the serial port on the Vm

2011-09-12 Thread bala suru
Hi, Thanks a lot , it resolved my problem .. I could get the data inside VM . regards Bala On Tue, Sep 13, 2011 at 10:53 AM, Stefan Hajnoczi wrote: > On Tue, Sep 13, 2011 at 5:59 AM, bala suru wrote: > > Yes, I'm connecting a USB to serial device to the host (ubuntu 11.04) and > I > > want that

Re: [Qemu-devel] About hotplug multifunction

2011-09-12 Thread Isaku Yamahata
On Sun, Sep 11, 2011 at 12:05:17PM +0300, Michael S. Tsirkin wrote: > On Sat, Sep 10, 2011 at 02:43:11AM +0900, Isaku Yamahata wrote: > > pci/pcie hot plug needs clean up for multifunction hotplug in long term. > > Only single function device case works. Multifunction case is broken > > somwehat.

Re: [Qemu-devel] unable to access the serial port on the Vm

2011-09-12 Thread Stefan Hajnoczi
On Tue, Sep 13, 2011 at 5:59 AM, bala suru wrote: > Yes, I'm connecting a USB to serial device to the host (ubuntu 11.04) and I > want that serial port on my VM . > I tried the solution you have suggested but still same problem , can  not > see the virtual serial port (ttyACM0) on VM but I could s

Re: [Qemu-devel] unable to access the serial port on the Vm

2011-09-12 Thread bala suru
Yes, I'm connecting a USB to serial device to the host (ubuntu 11.04) and I want that serial port on my VM . I tried the solution you have suggested but still same problem , can not see the virtual serial port (ttyACM0) on VM but I could see on the HOST . The following is the line I have tried .

[Qemu-devel] [Bug 848571] [NEW] qemu does not generate a qemu-kvm.stp tapset file

2011-09-12 Thread William Cohen
Public bug reported: To make the systemtap probing easier to use qemu generates qemu*.stp files with aliases for various events for each of the executables. The installer places these files in /usr/share/systemtap/tapset/. These files are generated by the tracetool. However, the /usr/bin/qemu-kvm

[Qemu-devel] buildbot failure in qemu on trivial-patches_i386_debian_6_0

2011-09-12 Thread qemu
The Buildbot has detected a new failure on builder trivial-patches_i386_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/trivial-patches_i386_debian_6_0/builds/29 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Bui

Re: [Qemu-devel] [PATCH v8 3/4] block: add block timer and throttling algorithm

2011-09-12 Thread Zhi Yong Wu
On Fri, Sep 9, 2011 at 10:44 PM, Marcelo Tosatti wrote: > On Thu, Sep 08, 2011 at 06:11:07PM +0800, Zhi Yong Wu wrote: >> Note: >>      1.) When bps/iops limits are specified to a small value such as 511 >> bytes/s, this VM will hang up. We are considering how to handle this senario. > > You can

Re: [Qemu-devel] Why qemu write/rw speed is so low?

2011-09-12 Thread Zhi Yong Wu
This is real log when fio issued with bs=128K and bps=100(block I/O throttling): 8,201 0.0 24332 A WS 79958528 + 256 <- (253,2) 71830016 8,002 0.00912 24332 A WS 80984576 + 256 <- (8,2) 79958528 8,203 0.01778 24332 Q W

Re: [Qemu-devel] Why qemu write/rw speed is so low?

2011-09-12 Thread Zhi Yong Wu
On Fri, Sep 9, 2011 at 6:38 PM, Stefan Hajnoczi wrote: > On Fri, Sep 09, 2011 at 05:44:36PM +0800, Zhi Yong Wu wrote: >> Today, i did some basical I/O testing, and suddenly found that qemu write >> and rw speed is so low now, my qemu binary is built on commit >> 344eecf6995f4a0ad1d887cec922f6806

Re: [Qemu-devel] [PATCH] support add-cow file format

2011-09-12 Thread Donald
于Mon 12 Sep 2011 03:59:07 PM CST,Kevin Wolf写到: Am 10.09.2011 02:54, schrieb Dong Xu Wang: 于Fri 09 Sep 2011 10:27:26 PM CST,Kevin Wolf写到: Am 09.09.2011 07:48, schrieb Dong Xu Wang: As raw file format does not support backing_file and copy on write feature, so I add COW to it to support backing_

Re: [Qemu-devel] [PATCH v2 09/12] sheepdog: move coroutine send/recv function to generic code

2011-09-12 Thread MORITA Kazutaka
At Fri, 9 Sep 2011 10:11:38 +0200, Paolo Bonzini wrote: > > Outside coroutines, avoid busy waiting on EAGAIN by temporarily > making the socket blocking. > > The API of qemu_recvv/qemu_sendv is slightly different from > do_readv/do_writev because they do not handle coroutines. It > returns the

Re: [Qemu-devel] [PATCH V8 03/14] Add persistent state handling to TPM TIS frontend driver

2011-09-12 Thread Stefan Berger
On 09/12/2011 05:16 PM, Paul Moore wrote: On Sunday, September 11, 2011 12:45:05 PM Stefan Berger wrote: On 09/09/2011 05:13 PM, Paul Moore wrote: On Wednesday, August 31, 2011 10:35:54 AM Stefan Berger wrote: Index: qemu-git/hw/tpm_tis.c ===

Re: [Qemu-devel] [PATCH V8 03/14] Add persistent state handling to TPM TIS frontend driver

2011-09-12 Thread Paul Moore
On Sunday, September 11, 2011 12:45:05 PM Stefan Berger wrote: > On 09/09/2011 05:13 PM, Paul Moore wrote: > > On Wednesday, August 31, 2011 10:35:54 AM Stefan Berger wrote: > >> Index: qemu-git/hw/tpm_tis.c > >> === > >> --- qemu-git.

Re: [Qemu-devel] qemu virtIO blocking operation - question

2011-09-12 Thread Sinha, Ani
On Sep 11, 2011, at 6:34 AM, Stefan Hajnoczi wrote: > > You may find these posts I wrote helpful, they explain vcpu threads and > the I/O thread: > http://blog.vmsplice.net/2011/03/qemu-internals-big-picture-overview.html > http://blog.vmsplice.net/2011/03/qemu-internals-overall-architecture-and.

Re: [Qemu-devel] [PATCH] PPC: Fix via-cuda memory registration

2011-09-12 Thread Anthony Liguori
On 09/12/2011 08:53 AM, Avi Kivity wrote: On 09/12/2011 04:46 PM, Lucas Meneghel Rodrigues wrote: On 09/12/2011 06:07 AM, Avi Kivity wrote: On 09/11/2011 02:38 PM, Alexander Graf wrote: Am 11.09.2011 um 12:41 schrieb Avi Kivity: > On 09/08/2011 07:54 PM, Alexander Graf wrote: >> PS: Please te

Re: [Qemu-devel] [PATCH] Remove blanks before \n in output strings

2011-09-12 Thread Peter Maydell
On 12 September 2011 21:33, Stefan Weil wrote: > Those blanks violate the coding conventions, see > scripts/checkpatch.pl. I can see doing this if there are any cases of actual output-to-users here, but for debug printfs, it scarcely seems worth the effort. I'm not arguing against this particular

Re: [Qemu-devel] [PATCH] PPC: Fix via-cuda memory registration

2011-09-12 Thread Peter Maydell
On 12 September 2011 14:53, Avi Kivity wrote: > Another option is, now that the binary name 'qemu' is available for general > use, make it possible to invoke everything with just one binary: > >  qemu -system -target mips ... Sounds reasonable, but we should probably make sure this (and more sign

[Qemu-devel] [PATCH] Remove blanks before \n in output strings

2011-09-12 Thread Stefan Weil
Those blanks violate the coding conventions, see scripts/checkpatch.pl. Blanks missing after colons in the changed lines were added. This patch does not try to fix tabs, long lines and other problems in the changed lines, therefore checkpatch.pl reports many violations. Signed-off-by: Stefan Wei

Re: [Qemu-devel] [Qemu-ppc] [PATCH 7/9] openpic: avoid a warning from clang analyzer

2011-09-12 Thread Blue Swirl
On Mon, Sep 12, 2011 at 5:12 PM, Scott Wood wrote: > On 09/04/2011 10:52 AM, Blue Swirl wrote: >> Avoid this warning by clang analyzer by defining a default case: >> /src/qemu/hw/openpic.c:477:5: warning: Undefined or garbage value >> returned to caller >>     return retval; >> >> Signed-off-by: B

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-12 Thread Blue Swirl
On Mon, Sep 12, 2011 at 3:20 PM, Alexander Graf wrote: > Jan Kiszka wrote: >> Most VGA memory access modes require MMIO handling as they demand weird >> logic to get a byte from or into the video RAM. However, there is one >> exception: chain 4 mode with all memory planes enabled for writing. This

Re: [Qemu-devel] [PATCH] PPC: Fix via-cuda memory registration

2011-09-12 Thread Lucas Meneghel Rodrigues
On 09/12/2011 10:53 AM, Avi Kivity wrote: On 09/12/2011 04:46 PM, Lucas Meneghel Rodrigues wrote: Yes, that would also work, having different variants with different qemu and qemu-img paths. Those binaries would have to be already pre-built, but then we miss the ability autotest has of building

Re: [Qemu-devel] [PATCH] PPC: Fix via-cuda memory registration

2011-09-12 Thread Blue Swirl
On Mon, Sep 12, 2011 at 1:53 PM, Avi Kivity wrote: > On 09/12/2011 04:46 PM, Lucas Meneghel Rodrigues wrote: >> >> On 09/12/2011 06:07 AM, Avi Kivity wrote: >>> >>> On 09/11/2011 02:38 PM, Alexander Graf wrote: Am 11.09.2011 um 12:41 schrieb Avi Kivity: > On 09/08/2011 07:54 PM

Re: [Qemu-devel] [PATCH] memory: simple memory tree printer

2011-09-12 Thread Blue Swirl
On Mon, Sep 12, 2011 at 10:53 AM, Avi Kivity wrote: > On 09/12/2011 01:37 PM, Gerd Hoffmann wrote: >>> >>> I/O >>> io addr off size 1 >>> -e1000-io addr c000 off size 40 >>> -piix-bmdma-container addr c040 off 0

Re: [Qemu-devel] [PATCH 11/15] Sparc: avoid AREG0 for CWP and PSTATE helpers

2011-09-12 Thread Blue Swirl
On Mon, Sep 12, 2011 at 8:29 AM, Stuart Brady wrote: > On Sun, Sep 11, 2011 at 01:31:03PM +, Blue Swirl wrote: >> Make CWP and PSTATE helpers take a parameter for CPUState instead >> of relying on global env. Move the functions to helper.c, remove >> wrapper functions. >> >> Signed-off-by: Blu

Re: [Qemu-devel] [PATCH 00/15] Sparc AREG0 conversion

2011-09-12 Thread Blue Swirl
On Mon, Sep 12, 2011 at 8:13 AM, Paolo Bonzini wrote: > On 09/12/2011 10:01 AM, Richard Henderson wrote: >> >> > >  After this patch set, only load and store op helpers remain in >> > >  op_helper.c. I have some patches for those but they need more >> > > thought. >> > >> >  Have you benchmarked i

Re: [Qemu-devel] Re-playable trace!

2011-09-12 Thread Blue Swirl
On Sun, Sep 11, 2011 at 11:22 PM, shbi shb wrote: > Hi, > > Is it possible to get a re-playable trace (memory snapshot) in Qemu? Do you > have any idea for adding this functionality to Qemu? > I need to get a trace of execution in the guest OS, do some modification on > the trace and run it again.

Re: [Qemu-devel] qemu virtIO blocking operation - question

2011-09-12 Thread Sinha, Ani
On Sep 11, 2011, at 6:34 AM, Stefan Hajnoczi wrote: > On Fri, Sep 09, 2011 at 07:45:17PM -0500, Sinha, Ani wrote: >> So I am writing a virtIO driver for a device that supports blocking calls >> like poll() etc. Now the front end paravirtualized driver mirrors the >> request to the backend "host

Re: [Qemu-devel] unable to access the serial port on the Vm

2011-09-12 Thread Stefan Hajnoczi
On Mon, Sep 12, 2011 at 12:35 PM, bala suru wrote: > But I need to connect a some USB device which will create a virtual > serialport called /dev/ttyACM0, I cloud not see this on the Vm running .. > > This XML format I used > RAW = [ type = "kvm", >   data = " path=\"/dev/pts/5\"/> tty=\"/

[Qemu-devel] [Bug 818673] Re: virtio: trying to map MMIO memory

2011-09-12 Thread Rick Vernam
ping... I understand that Vadim must be very busy that he can't look at this - I can relate. But is there really only one person in all of Qemu and/or Spice who can be addressed to look into this? So that I can plan around the viability of Qemu for my users, I need to know if the technologies I

Re: [Qemu-devel] [Qemu-ppc] [RESEND][PATCH] booke timers

2011-09-12 Thread Scott Wood
On 09/09/2011 09:58 AM, Alexander Graf wrote: > On 09.09.2011, at 16:22, Fabien Chouteau wrote: >> if the interrupt is already set and you clear TCR.DIE, the interrupt has to >> remain set. The only way to unset an interrupt is to clear the corresponding >> bit in TSR (currently in store_booke_tsr)

Re: [Qemu-devel] [PATCH] tcg/arm: Remove unused tcg_out_addi()

2011-09-12 Thread Peter Maydell
On 12 September 2011 18:04, Stefan Weil wrote: > Am 12.09.2011 12:03, schrieb Peter Maydell: >> Remove the unused function tcg_out_addi() from the ARM TCG backend; >> this fixes a compilation failure on ARM hosts with newer gcc. > Are you sure that those functions will never be needed again? > If

Re: [Qemu-devel] [Qemu-ppc] [PATCH 7/9] openpic: avoid a warning from clang analyzer

2011-09-12 Thread Scott Wood
On 09/04/2011 10:52 AM, Blue Swirl wrote: > Avoid this warning by clang analyzer by defining a default case: > /src/qemu/hw/openpic.c:477:5: warning: Undefined or garbage value > returned to caller > return retval; > > Signed-off-by: Blue Swirl > --- > hw/openpic.c |1 + > 1 files change

Re: [Qemu-devel] [PATCH] tcg/arm: Remove unused tcg_out_addi()

2011-09-12 Thread Stefan Weil
Am 12.09.2011 12:03, schrieb Peter Maydell: Remove the unused function tcg_out_addi() from the ARM TCG backend; this fixes a compilation failure on ARM hosts with newer gcc. Signed-off-by: Peter Maydell --- A previous patch from Richard Henderson for this compile failure: http://patchwork.ozlab

Re: [Qemu-devel] [PATCH] pci: Remove unused mem_base from PCIBus

2011-09-12 Thread Michael S. Tsirkin
On Mon, Sep 12, 2011 at 03:17:53PM +0200, Jan Kiszka wrote: > Obsoleted by f64e02b6cc. > > Signed-off-by: Jan Kiszka thanks, applied > --- > hw/pci_internals.h |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/hw/pci_internals.h b/hw/pci_internals.h > index c7fd23d

[Qemu-devel] [Bug 814222] Re: kvm cannot use vhd files over 127GB

2011-09-12 Thread Launchpad Bug Tracker
This bug was fixed in the package qemu-kvm - 0.14.1+noroms-0ubuntu5 --- qemu-kvm (0.14.1+noroms-0ubuntu5) oneiric; urgency=low * debian/patches/vpc.patch: detect vpc files which are too big (LP: #814222) -- Serge HallynMon, 12 Sep 2011 11:28:36 -0500 ** Changed in: qemu-kv

Re: [Qemu-devel] [PATCH V12 00/15] virtio-9p: chroot environment for passthrough security model

2011-09-12 Thread Daniel P. Berrange
On Tue, Sep 06, 2011 at 03:48:22PM +0100, Stefan Hajnoczi wrote: > On Mon, Sep 05, 2011 at 09:48:21PM +0530, M. Mohan Kumar wrote: > > Qemu need to be invoked by root user for using virtfs with passthrough > > security model (i.e to use chroot() syscall). > > > > Question is: Is running qemu by ro

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-12 Thread Jan Kiszka
On 2011-09-12 17:49, Jan Kiszka wrote: > On 2011-09-12 17:45, Andreas Färber wrote: >> Am 12.09.2011 17:33, schrieb Jan Kiszka: >>> On 2011-09-12 17:20, Alexander Graf wrote: Jan Kiszka wrote: > Most VGA memory access modes require MMIO handling as they demand weird > logic to get a by

Re: [Qemu-devel] [PATCH V12 00/15] virtio-9p: chroot environment for passthrough security model

2011-09-12 Thread M. Mohan Kumar
On Tuesday, September 06, 2011 08:18:22 PM Stefan Hajnoczi wrote: > A virtfs feature that needs root therefore needs to be in a separate > process. Either QEMU needs to fork or virtfs could use a separate > daemon binary. > > You have already implemented the fork approach in the chroot

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-12 Thread Jan Kiszka
On 2011-09-12 17:45, Andreas Färber wrote: > Am 12.09.2011 17:33, schrieb Jan Kiszka: >> On 2011-09-12 17:20, Alexander Graf wrote: >>> Jan Kiszka wrote: Most VGA memory access modes require MMIO handling as they demand weird logic to get a byte from or into the video RAM. However, there

[Qemu-devel] [PATCH 22/35] block: Clean up remaining users of "removable"

2011-09-12 Thread Kevin Wolf
From: Markus Armbruster BlockDriverState member removable is a confused mess. It is true when an ide-cd, scsi-cd or floppy qdev is attached, or when the BlockDriverState was created with -drive if={floppy,sd} or -drive if={ide,scsi,xen,none},media=cdrom ("created removable"), except when an ide-

[Qemu-devel] [PATCH 24/35] block: Show whether the virtual tray is open in info block

2011-09-12 Thread Kevin Wolf
From: Markus Armbruster Need to ask the device, so this requires new BlockDevOps member is_tray_open(). Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- block.c | 18 -- block.h |6 ++ hw/ide/core.c |6 ++ hw/scsi-disk.c |

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-12 Thread Andreas Färber
Am 12.09.2011 17:33, schrieb Jan Kiszka: > On 2011-09-12 17:20, Alexander Graf wrote: >> Jan Kiszka wrote: >>> Most VGA memory access modes require MMIO handling as they demand weird >>> logic to get a byte from or into the video RAM. However, there is one >>> exception: chain 4 mode with all memor

[Qemu-devel] [PATCH 01/35] qcow2: removed unused depends_on field

2011-09-12 Thread Kevin Wolf
From: Frediano Ziglio Signed-off-by: Frediano Ziglio Signed-off-by: Kevin Wolf --- block/qcow2-cluster.c |3 +-- block/qcow2.h |1 - 2 files changed, 1 insertions(+), 3 deletions(-) diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c index e06be64..113db8b 100644 --- a/

[Qemu-devel] [PATCH 27/35] block: New bdrv_set_buffer_alignment()

2011-09-12 Thread Kevin Wolf
From: Markus Armbruster Device models should be able to set it without an unclean include of block_int.h. Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- block.c |6 -- block.h |1 + hw/ide/core.c |2 +- hw/scsi-disk.c |2 +- hw/virtio-blk

[Qemu-devel] [PATCH 1/1] qemu-img: async write to block device when converting image

2011-09-12 Thread Yehuda Sadeh
In order to improve image conversion process, instead of synchronously writing the destingation image, we keep a window of async writes. Signed-off-by: Yehuda Sadeh --- qemu-img.c | 47 +++ 1 files changed, 43 insertions(+), 4 deletions(-) diff --gi

[Qemu-devel] [PATCH 05/35] ide/atapi: Clean up misleading name in cmd_start_stop_unit()

2011-09-12 Thread Kevin Wolf
From: Markus Armbruster "eject" is misleading; it means "eject" when start is clear, but "load" when start is set. Rename to loej, because that's how MMC-5 calls it, in section 6.40. Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- hw/ide/atapi.c |8 1 files change

[Qemu-devel] [PATCH 29/35] nbd: Clean up use of block_int.h

2011-09-12 Thread Kevin Wolf
From: Markus Armbruster Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- block/nbd.c |1 + nbd.c |1 + nbd.h |2 -- 3 files changed, 2 insertions(+), 2 deletions(-) diff --git a/block/nbd.c b/block/nbd.c index 55cb2fd..70edd81 100644 --- a/block/nbd.c +++

[Qemu-devel] [PATCH 18/35] rbd: fix leak in qemu_rbd_open failure paths

2011-09-12 Thread Kevin Wolf
From: Sage Weil Fix leak of s->snap in failure path. Simplify error paths for the whole function. Reported-by: Stefan Hajnoczi Signed-off-by: Sage Weil Reviewed-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block/rbd.c | 28 +--- 1 files changed, 13 insertions

[Qemu-devel] [PATCH 03/35] ide: Use a table to declare which drive kinds accept each command

2011-09-12 Thread Kevin Wolf
From: Markus Armbruster No functional change. It would be nice to have handler functions in the table, like commit e1a064f9 did for ATAPI. Left for another day. Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- hw/ide/core.c | 105 +++---

[Qemu-devel] [PATCH 11/35] ide/atapi: Track tray locked state

2011-09-12 Thread Kevin Wolf
From: Markus Armbruster We already track it in BlockDriverState. Just like tray open/close state, we should track it in the device models instead, because it's device state. Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- hw/ide/atapi.c|4 +++- hw/ide/internal.h |1

[Qemu-devel] [PATCH 17/35] rbd: clean up, fix style

2011-09-12 Thread Kevin Wolf
From: Sage Weil No assignment in condition. Remove duplicate ret > 0 check. Signed-off-by: Sage Weil Reviewed-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block/rbd.c | 17 - 1 files changed, 8 insertions(+), 9 deletions(-) diff --git a/block/rbd.c b/block/rbd.c inde

[Qemu-devel] [PATCH 33/35] ahci: Remove unused struct member

2011-09-12 Thread Kevin Wolf
From: Stefan Weil Member variable is_read is written, but never read (contrary to its name). Remove it. Kevin Wolf Signed-off-by: Stefan Weil Signed-off-by: Kevin Wolf --- hw/ide/ahci.c |2 -- hw/ide/ahci.h |1 - 2 files changed, 0 insertions(+), 3 deletions(-) diff --git a/hw/ide/a

[Qemu-devel] [PATCH 16/35] rbd: allow client id to be specified in config string

2011-09-12 Thread Kevin Wolf
From: Sage Weil Allow the client id to be specified in the config string via 'id=' so that users can control who they authenticate as. Currently they are stuck with the default ('admin'). This is necessary for anyone using authentication in their environment. Signed-off-by: Sage Weil Reviewed

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-12 Thread Jan Kiszka
On 2011-09-12 17:20, Alexander Graf wrote: > Jan Kiszka wrote: >> Most VGA memory access modes require MMIO handling as they demand weird >> logic to get a byte from or into the video RAM. However, there is one >> exception: chain 4 mode with all memory planes enabled for writing. This >> mode actu

[Qemu-devel] [PATCH 21/35] ide/atapi: Preserve tray state on migration

2011-09-12 Thread Kevin Wolf
From: Markus Armbruster Use a subsection, so that migration to older version still works, provided the tray is closed and unlocked. Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- hw/ide/core.c | 32 1 files changed, 32 insertions(+), 0 deleti

[Qemu-devel] Using the qemu tracepoints with SystemTap

2011-09-12 Thread William Cohen
Hi All, The RHEL-6 version of qemu-kvm makes the tracepoints available to SystemTap. I have been working on useful examples for the SystemTap tracepoints in qemu. There doesn't seem to be a great number of examples showing the utility of the tracepoints in diagnosing problems. However, I came a

[Qemu-devel] [PATCH 02/35] ide: Fix ATA command READ to set ATAPI signature for CD-ROM

2011-09-12 Thread Kevin Wolf
From: Markus Armbruster Must set the ATAPI device signature, see ATA4 8.27.5.2 Outputs for PACKET Command feature set devices, and ACS-2 7.36.6 Outputs for PACKET feature set devices. Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- hw/ide/core.c |4 +++- 1 files changed, 3

[Qemu-devel] [PATCH 06/35] ide/atapi: Track tray open/close state

2011-09-12 Thread Kevin Wolf
From: Markus Armbruster We already track it in BlockDriverState since commit 4be9762a. As discussed in that commit's message, we should track it in the device device models instead, because it's device state. Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- hw/ide/atapi.c|

[Qemu-devel] [PATCH 23/35] block: Drop BlockDriverState member removable

2011-09-12 Thread Kevin Wolf
From: Markus Armbruster It's a confused mess (see previous commit). No users remain. Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- block.c |8 block.h |1 - block_int.h |1 - blockdev.c|5 - hw/fdc.c |

[Qemu-devel] [PATCH 32/35] qcow2: initialize metadata before inserting in cluster_allocs

2011-09-12 Thread Kevin Wolf
From: Frediano Ziglio QCow2Meta structure was inserted into list before many fields are initialized. Currently is not a problem cause all occur in a lock but if qcow2_alloc_clusters would in a future unlock this lock some issues could arise. Initializing fields before inserting fix the problem.

[Qemu-devel] [PATCH 10/35] block: Drop tray status tracking, no longer used

2011-09-12 Thread Kevin Wolf
From: Markus Armbruster Commit 4be9762a is now completely redone. Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- block.c |1 - block_int.h |1 - 2 files changed, 0 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c index 6fe8add..8c86251 100644 --- a/blo

Re: [Qemu-devel] [PATCH v3 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

2011-09-12 Thread Alexander Graf
Jan Kiszka wrote: > Most VGA memory access modes require MMIO handling as they demand weird > logic to get a byte from or into the video RAM. However, there is one > exception: chain 4 mode with all memory planes enabled for writing. This > mode actually allows lineary mapping, which can then be co

[Qemu-devel] [PATCH 09/35] block: Revert entanglement of bdrv_is_inserted() with tray status

2011-09-12 Thread Kevin Wolf
From: Markus Armbruster Commit 4be9762a changed bdrv_is_inserted() to fail when the tray is open. Unfortunately, there are two different kinds of users, with conflicting needs. 1. Device models using bdrv_eject(), currently ide-cd and scsi-cd. They expect bdrv_is_inserted() to reflect the tray

[Qemu-devel] [PATCH 04/35] ide: Reject ATA commands specific to drive kinds

2011-09-12 Thread Kevin Wolf
From: Markus Armbruster ACS-2 Table B.2 explicitly prohibits ATAPI devices from implementing WIN_RECAL, WIN_READ_EXT, WIN_READDMA_EXT, WIN_READ_NATIVE_MAX, WIN_MULTREAD_EXT, WIN_WRITE, WIN_WRITE_ONCE, WIN_WRITE_EXT, WIN_WRITEDMA_EXT, WIN_MULTWRITE_EXT, WIN_WRITE_VERIFY, WIN_VERIFY, WIN_VERIFY_ONC

[Qemu-devel] [PATCH 13/35] block: Leave enforcing tray lock to device models

2011-09-12 Thread Kevin Wolf
From: Markus Armbruster The device model knows best when to accept the guest's eject command. No need to detour through the block layer. bdrv_eject() can't fail anymore. Make it void. Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- block.c|7 +-- block.h

Re: [Qemu-devel] [PATCH 0/2] versatile: cleanups to remove use of sysbus_mmio_init_cb2

2011-09-12 Thread Peter Maydell
Ping? On 1 September 2011 18:36, Peter Maydell wrote: > A couple of patches which do some cleanup work to versatile > devices following the recent MemoryRegion conversion. These > both remove uses of sysbus_mmio_init_cb2(), which strikes me > as kind of ugly and worth avoiding. (After these two p

[Qemu-devel] [PATCH 07/35] scsi-disk: Factor out scsi_disk_emulate_start_stop()

2011-09-12 Thread Kevin Wolf
From: Markus Armbruster Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- hw/scsi-disk.c | 17 + 1 files changed, 13 insertions(+), 4 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index 9724d0f..c8ad2e7 100644 --- a/hw/scsi-disk.c +++ b/hw/scsi-disk.

Re: [Qemu-devel] [PATCH 02/12] nbd: sync API definitions with upstream

2011-09-12 Thread Paolo Bonzini
On 09/12/2011 04:15 PM, Kevin Wolf wrote: > Signed-off-by: Paolo Bonzini > --- >nbd.c |2 ++ >nbd.h | 11 ++- >2 files changed, 12 insertions(+), 1 deletions(-) Which upstream? I can't find any NBD version that defines a command/flag for TRIM. Upstream userspace maint

[Qemu-devel] [PATCH 4/6] qed: add qed_bdrv_get_mapping()

2011-09-12 Thread Devin Nakamura
Signed-off-by: Devin Nakamura --- block/qed.c | 29 + 1 files changed, 29 insertions(+), 0 deletions(-) diff --git a/block/qed.c b/block/qed.c index 93827db..4cde2fd 100644 --- a/block/qed.c +++ b/block/qed.c @@ -1512,6 +1512,34 @@ static int bdrv_qed_open_convers

[Qemu-devel] [PATCH 2/6] qed: add bdrv_qed_get_conversion_options()

2011-09-12 Thread Devin Nakamura
Signed-off-by: Devin Nakamura --- block/qed.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/block/qed.c b/block/qed.c index 624e261..16320f5 100644 --- a/block/qed.c +++ b/block/qed.c @@ -1444,6 +1444,18 @@ static int bdrv_qed_check(BlockDriverState *bs,

[Qemu-devel] [PATCH 4/6] qed: add qed_bdrv_get_mapping()

2011-09-12 Thread Devin Nakamura
Signed-off-by: Devin Nakamura --- block/qed.c | 29 + 1 files changed, 29 insertions(+), 0 deletions(-) diff --git a/block/qed.c b/block/qed.c index 93827db..4cde2fd 100644 --- a/block/qed.c +++ b/block/qed.c @@ -1512,6 +1512,34 @@ static int bdrv_qed_open_convers

[Qemu-devel] [PATCH 5/6] qed: add bdrv_qed_map()

2011-09-12 Thread Devin Nakamura
Signed-off-by: Devin Nakamura --- block/qed.c | 47 +++ 1 files changed, 47 insertions(+), 0 deletions(-) diff --git a/block/qed.c b/block/qed.c index 4cde2fd..341cf9d 100644 --- a/block/qed.c +++ b/block/qed.c @@ -1540,6 +1540,52 @@ static int bdrv

[Qemu-devel] [PATCH 6/6] qed: add bdrv_qed_copy_header()

2011-09-12 Thread Devin Nakamura
Signed-off-by: Devin Nakamura --- block/qed.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/block/qed.c b/block/qed.c index 341cf9d..caecdff 100644 --- a/block/qed.c +++ b/block/qed.c @@ -1586,6 +1586,20 @@ static int bdrv_qed_map(BlockDriverState *bs, u

[Qemu-devel] [PATCH 2/6] qed: add bdrv_qed_get_conversion_options()

2011-09-12 Thread Devin Nakamura
Signed-off-by: Devin Nakamura --- block/qed.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/block/qed.c b/block/qed.c index 624e261..16320f5 100644 --- a/block/qed.c +++ b/block/qed.c @@ -1444,6 +1444,18 @@ static int bdrv_qed_check(BlockDriverState *bs,

[Qemu-devel] [PATCH 30/35] block: New change_media_cb() parameter load

2011-09-12 Thread Kevin Wolf
From: Markus Armbruster To let device models distinguish between eject and load. Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- block.c| 12 ++-- block.h|3 ++- hw/fdc.c |2 +- hw/ide/core.c |2 +- hw/scsi-disk.c |2 +- hw/sd.c

[Qemu-devel] [PATCH 14/35] block: Drop medium lock tracking, ask device models instead

2011-09-12 Thread Kevin Wolf
From: Markus Armbruster Requires new BlockDevOps member is_medium_locked(). Implement for IDE and SCSI CD-ROMs. Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- block.c| 16 +--- block.h|7 ++- block_int.h|1 - blockdev.c |2

[Qemu-devel] [PATCH 26/35] hw: Trim superfluous #include "block_int.h"

2011-09-12 Thread Kevin Wolf
From: Markus Armbruster Including it in device models is unclean, including it without a reason adds insult to injury. Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- hw/fdc.c|1 - hw/ide/cmd646.c |1 - hw/ide/ich.c|1 - hw/ide/isa.c|

[Qemu-devel] [PATCH 25/35] block: Move BlockConf & friends from block_int.h to block.h

2011-09-12 Thread Kevin Wolf
From: Markus Armbruster It's convenience stuff for block device models, so block.h isn't the ideal home either, but better than block_int.h. Permits moving some #include "block_int.h" from device model .h into .c. Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- block.h

[Qemu-devel] [PATCH 34/35] qcow2: align cluster_data to block to improve performance using O_DIRECT

2011-09-12 Thread Kevin Wolf
From: Frediano Ziglio Signed-off-by: Frediano Ziglio Signed-off-by: Kevin Wolf --- block/qcow2.c | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 8aed310..510ff68 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -237,7 +

[Qemu-devel] [PATCH 3/6] qed: add open_conversion_target()

2011-09-12 Thread Devin Nakamura
Signed-off-by: Devin Nakamura --- block/qed.c | 57 + 1 files changed, 57 insertions(+), 0 deletions(-) diff --git a/block/qed.c b/block/qed.c index 16320f5..93827db 100644 --- a/block/qed.c +++ b/block/qed.c @@ -1456,6 +1456,62 @@ stati

[Qemu-devel] [PATCH 1/6] qed: add qed_find_cluster_sync()

2011-09-12 Thread Devin Nakamura
Signed-off-by: Devin Nakamura --- block/qed-cluster.c | 33 + block/qed.h |4 2 files changed, 37 insertions(+), 0 deletions(-) diff --git a/block/qed-cluster.c b/block/qed-cluster.c index f64b2af..6e68ba7 100644 --- a/block/qed-cluster.c +++ b

[Qemu-devel] [PATCH 0/6] QED block conversion

2011-09-12 Thread Devin Nakamura
This patch series adds support for block conversion to the qed driver. This depends on my precivious block conversion api series Devin Nakamura (6): qed: add qed_find_cluster_sync() qed: add bdrv_qed_get_conversion_options() qed: add open_conversion_target() qed: add qed_bdrv_get_mapping()

[Qemu-devel] [PATCH 19/35] ide/atapi: Don't fail eject when tray is already open

2011-09-12 Thread Kevin Wolf
From: Markus Armbruster MMC-5 6.40.2.6 specifies that START STOP UNIT succeeds when the drive already has the requested state. cmd_start_stop_unit() fails when asked to eject while the tray is open and locked. Fix that. Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- hw/ide/a

[Qemu-devel] [PATCH v2] hw/integratorcp: Fix bugs in writes to CM_CTRL system register

2011-09-12 Thread Peter Maydell
Fix a number of bugs in the implementation of writes to the CM_CTRL system register: * write to cm_ctrl, not cm_init ! * an '&' vs '^' typo meant we would write the inverse of the bits * handling the LED via printf() meant we spew lots of output to stdout when Linux uses the LED as a heartbea

[Qemu-devel] [PATCH 08/35] scsi-disk: Track tray open/close state

2011-09-12 Thread Kevin Wolf
From: Markus Armbruster We already track it in BlockDriverState since commit 4be9762a. As discussed in that commit's message, we should track it in the device device models instead, because it's device state. Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- hw/scsi-disk.c |

Re: [Qemu-devel] [PATCH 1/1] qemu-img: async write to block device when converting image

2011-09-12 Thread Yehuda Sadeh Weinraub
Note that I assumed qemu-img runs in a single context (like qemu), and there are no concurrency issues. If that's not the case, the callback, error handling need to be fixed. Yehuda On Mon, Sep 12, 2011 at 7:26 AM, Yehuda Sadeh wrote: > In order to improve image conversion process, instead of sy

[Qemu-devel] [PATCH 35/35] qcow2: fix range check

2011-09-12 Thread Kevin Wolf
From: Frediano Ziglio QCowL2Meta::offset is not cluster aligned but only sector aligned however nb_clusters count cluster from cluster start. This fix range check. Note that old code have no corruption issues related to this check cause it only cause intersection to occur when shouldn't. Signed-

[Qemu-devel] [PATCH 31/35] ide/atapi scsi-disk: Make monitor eject -f, then change work

2011-09-12 Thread Kevin Wolf
From: Markus Armbruster change fails while the tray is locked by the guest. eject -f forces it open and removes any media. Unfortunately, the tray closes again instantly. Since the lock remains as it is, there is no way to insert another medium unless the guest voluntarily unlocks. Fix by lea

[Qemu-devel] [PATCH 20/35] scsi-disk: Fix START_STOP to fail when it can't eject

2011-09-12 Thread Kevin Wolf
From: Markus Armbruster Don't fail when tray is already open. Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- hw/scsi-bus.c | 10 ++ hw/scsi-disk.c | 15 +++ hw/scsi.h |4 3 files changed, 25 insertions(+), 4 deletions(-) diff --git a/hw/

[Qemu-devel] [PATCH 15/35] block: Rename bdrv_set_locked() to bdrv_lock_medium()

2011-09-12 Thread Kevin Wolf
From: Markus Armbruster While there, make the locked parameter bool. Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- block.c |8 block.h |2 +- block/raw-posix.c |8 block/raw.c |6 +++--- block_int.h |2 +-

[Qemu-devel] [PATCH 28/35] block: Reset buffer alignment on detach

2011-09-12 Thread Kevin Wolf
From: Markus Armbruster BlockDriverState member buffer_alignment is initially 512. The device model may set them, with bdrv_set_buffer_alignment(). If the device model gets detached (hot unplug), the device's alignment is left behind. Only okay because device hot unplug automatically destroys

[Qemu-devel] [PATCH 12/35] scsi-disk: Track tray locked state

2011-09-12 Thread Kevin Wolf
From: Markus Armbruster We already track it in BlockDriverState. Just like tray open/close state, we should track it in the device models instead, because it's device state. Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- hw/scsi-disk.c |4 +++- 1 files changed, 3 insertio

[Qemu-devel] [PULL 00/35] Block patches

2011-09-12 Thread Kevin Wolf
The following changes since commit 44520db10b1b92f272348ab7028e7afc68ac3edf: Gdbstub: Fix back-trace on SPARC32 (2011-09-10 18:12:35 +) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Frediano Ziglio (4): qcow2: removed unused depends_on field

Re: [Qemu-devel] [PATCH 02/12] nbd: sync API definitions with upstream

2011-09-12 Thread Kevin Wolf
Am 08.09.2011 17:24, schrieb Paolo Bonzini: > Signed-off-by: Paolo Bonzini > --- > nbd.c |2 ++ > nbd.h | 11 ++- > 2 files changed, 12 insertions(+), 1 deletions(-) Which upstream? I can't find any NBD version that defines a command/flag for TRIM. Kevin

Re: [Qemu-devel] [PATCH] PPC: Fix via-cuda memory registration

2011-09-12 Thread Avi Kivity
On 09/12/2011 04:46 PM, Lucas Meneghel Rodrigues wrote: On 09/12/2011 06:07 AM, Avi Kivity wrote: On 09/11/2011 02:38 PM, Alexander Graf wrote: Am 11.09.2011 um 12:41 schrieb Avi Kivity: > On 09/08/2011 07:54 PM, Alexander Graf wrote: >> PS: Please test your patches. This one could have been f

Re: [Qemu-devel] [PATCH] PPC: Fix via-cuda memory registration

2011-09-12 Thread Lucas Meneghel Rodrigues
On 09/12/2011 06:07 AM, Avi Kivity wrote: On 09/11/2011 02:38 PM, Alexander Graf wrote: Am 11.09.2011 um 12:41 schrieb Avi Kivity: > On 09/08/2011 07:54 PM, Alexander Graf wrote: >> PS: Please test your patches. This one could have been found with an invocation >> as simple as "qemu-system-ppc"

  1   2   >