Re: [Qemu-devel] [PATCH 2/2] LAPIC: make lapic support cpu hotplug

2011-10-05 Thread Jan Kiszka
On 2011-10-06 03:13, liu ping fan wrote: > On Wed, Oct 5, 2011 at 7:01 PM, Jan Kiszka wrote: >> On 2011-10-05 12:26, liu ping fan wrote: > And make the creation of apic as part of cpu initialization, so > apic's state has been ready, before setting kvm_apic. There is no kvm-api

Re: [Qemu-devel] balloon drivers missing in virtio-win-1.1.16.vfd

2011-10-05 Thread Andrew Cathrow
- Original Message - > From: "Onkar N Mahajan" > To: k...@vger.kernel.org, qemu-devel@nongnu.org > Sent: Thursday, September 29, 2011 6:03:26 AM > Subject: balloon drivers missing in virtio-win-1.1.16.vfd > > virtio_balloon drivers are missing in the virtio-win floppy disk > image > fo

[Qemu-devel] buildbot failure in qemu on block_x86_64_debian_6_0

2011-10-05 Thread qemu
The Buildbot has detected a new failure on builder block_x86_64_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/block_x86_64_debian_6_0/builds/52 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki Build

[Qemu-devel] buildbot failure in qemu on block_i386_debian_6_0

2011-10-05 Thread qemu
The Buildbot has detected a new failure on builder block_i386_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/block_i386_debian_6_0/builds/52 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki Build Rea

Re: [Qemu-devel] [PATCH 2/2] LAPIC: make lapic support cpu hotplug

2011-10-05 Thread Anthony Liguori
On 10/05/2011 08:13 PM, liu ping fan wrote: On Wed, Oct 5, 2011 at 7:01 PM, Jan Kiszka wrote: On 2011-10-05 12:26, liu ping fan wrote: > And make the creation of apic as part of cpu initialization, so apic's state has been ready, before setting kvm_apic. There is no kvm-apic upstream yet

Re: [Qemu-devel] [PATCH 2/2] LAPIC: make lapic support cpu hotplug

2011-10-05 Thread liu ping fan
On Wed, Oct 5, 2011 at 7:01 PM, Jan Kiszka wrote: > On 2011-10-05 12:26, liu ping fan wrote: >>>  > And make the creation of apic as part of cpu initialization, so apic's state has been ready, before setting kvm_apic. >>> >>> There is no kvm-apic upstream yet, so it's hard to judge why we nee

[Qemu-devel] Info

2011-10-05 Thread Viviana Cocci
Buongiorno sono Viviana Vorrei semplicemente invitarvi ad iscrivervi al nostro gruppo facebook per condividere pareri su musica e artisti, stringere nuove amicizie tramite la nostra Hyde Radio Il Gruppo e’ accessibile dal sito Hyde Radio . com Grazie per la cortese attenzione, un

Re: [Qemu-devel] [PATCH] ppc64: Fix linker script

2011-10-05 Thread Alexander Graf
On 04.10.2011, at 17:35, Richard Henderson wrote: > On 10/04/2011 08:14 AM, Andreas Färber wrote: >> Since commit 8733f609 (Fix linker scripts) linking on Linux/ppc64 fails: > > It occurs to me to wonder if we ought to simply auto-detect the presence > of the -Ttext-segment ADDR option. If that

Re: [Qemu-devel] [PATCH 17/23] migration: make sure we always have a migration state

2011-10-05 Thread Juan Quintela
Anthony Liguori wrote: > On 10/04/2011 09:49 AM, Juan Quintela wrote: >> Anthony Liguori wrote: >>> On 09/23/2011 07:57 AM, Juan Quintela wrote: [ much more stuff ] >> It avoids s==NULL checks, > > In favor of s->state == MIG_STATE_NONE. > >> and it also avoids having to have new >> variables (

Re: [Qemu-devel] [PATCH 04/11] migration: return real error code

2011-10-05 Thread Juan Quintela
Anthony Liguori wrote: > On 10/04/2011 01:35 PM, Juan Quintela wrote: >> Anthony Liguori wrote: >>> On 09/23/2011 07:50 AM, Juan Quintela wrote: make functions propaget errno, instead of just using -EIO. Signed-off-by: Juan Quintela >>> >>> qemu_file_has_error() implies a boolean r

Re: [Qemu-devel] [PATCH 17/23] migration: make sure we always have a migration state

2011-10-05 Thread Anthony Liguori
On 10/04/2011 09:49 AM, Juan Quintela wrote: Anthony Liguori wrote: On 09/23/2011 07:57 AM, Juan Quintela wrote: This cleans up a lot the code as we don't have to check anymore if the variable is NULL or not. We don't make it static, because when we integrate fault tolerance, we can have seve

Re: [Qemu-devel] [PATCH 04/11] migration: return real error code

2011-10-05 Thread Anthony Liguori
On 10/04/2011 01:35 PM, Juan Quintela wrote: Anthony Liguori wrote: On 09/23/2011 07:50 AM, Juan Quintela wrote: make functions propaget errno, instead of just using -EIO. Signed-off-by: Juan Quintela qemu_file_has_error() implies a boolean response. Wouldn't qemu_file_get_error() make mor

Re: [Qemu-devel] [PATCH 4/4] Revert "savevm: fix corruption in vmstate_subsection_load()."

2011-10-05 Thread Anthony Liguori
On 10/04/2011 09:38 AM, Juan Quintela wrote: This reverts commit eb60260de0b050a5e8ab725e84d377d0b44c43ae. Conflicts: savevm.c We changed qemu_peek_byte() prototype, just fixed the rejects. Signed-off-by: Juan Quintela Reviewed-by: Anthony Liguori Regards, Anthony Liguori ---

Re: [Qemu-devel] [PATCH 3/4] savevm: improve subsections detection on load

2011-10-05 Thread Anthony Liguori
On 10/04/2011 09:38 AM, Juan Quintela wrote: We add qemu_peek_buffer, that is identical to qemu_get_buffer, just that it don't update f->buf_index. We add a paramenter to qemu_peek_byte() to be able to peek more than one byte. Once this is done, to see if we have a subsection we look: - 1st byt

Re: [Qemu-devel] [PATCH 2/4] savevm: some coding style cleanups

2011-10-05 Thread Anthony Liguori
On 10/04/2011 09:38 AM, Juan Quintela wrote: This patch will make moving code on next patches and having checkpatch happy easier. Signed-off-by: Juan Quintela Reviewed-by: Anthony Liguori Regards, Anthony Liguori --- savevm.c | 21 ++--- 1 files changed, 14 insertions

Re: [Qemu-devel] [PATCH 1/4] savevm: teach qemu_fill_buffer to do partial refills

2011-10-05 Thread Anthony Liguori
On 10/04/2011 09:38 AM, Juan Quintela wrote: We will need on next patch to be able to lookahead on next patch Signed-off-by: Juan Quintela Reviewed-by: Anthony Liguori Regards, Anthony Liguori --- savevm.c | 14 +++--- 1 files changed, 11 insertions(+), 3 deletions(-) diff -

Re: [Qemu-devel] [PATCH] runstate: do not discard runstate changes when paused

2011-10-05 Thread Luiz Capitulino
On Wed, 5 Oct 2011 15:49:42 -0300 Luiz Capitulino wrote: > On Wed, 05 Oct 2011 20:02:04 +0200 > Avi Kivity wrote: > > > On 10/05/2011 07:39 PM, Luiz Capitulino wrote: > > > On Wed, 05 Oct 2011 19:23:21 +0200 > > > Avi Kivity wrote: > > > > > > > On 10/05/2011 07:02 PM, Luiz Capitulino wrote:

Re: [Qemu-devel] [PATCH] runstate: do not discard runstate changes when paused

2011-10-05 Thread Luiz Capitulino
On Wed, 05 Oct 2011 20:02:04 +0200 Avi Kivity wrote: > On 10/05/2011 07:39 PM, Luiz Capitulino wrote: > > On Wed, 05 Oct 2011 19:23:21 +0200 > > Avi Kivity wrote: > > > > > On 10/05/2011 07:02 PM, Luiz Capitulino wrote: > > > > On Wed, 05 Oct 2011 18:37:51 +0200 > > > > Avi Kivity wrote:

Re: [Qemu-devel] [PATCH] runstate: do not discard runstate changes when paused

2011-10-05 Thread Jan Kiszka
On 2011-10-05 19:12, Avi Kivity wrote: > On 10/05/2011 06:49 PM, Jan Kiszka wrote: >> On 2011-10-05 18:37, Avi Kivity wrote: >> > On 10/05/2011 06:31 PM, Jan Kiszka wrote: >> >> >> >> >> > >> >> > vm_start() should be symmetric with vm_stop(). That is, if a >> piece of >> >> > code wants

Re: [Qemu-devel] [PATCH] runstate: do not discard runstate changes when paused

2011-10-05 Thread Avi Kivity
On 10/05/2011 07:39 PM, Luiz Capitulino wrote: On Wed, 05 Oct 2011 19:23:21 +0200 Avi Kivity wrote: > On 10/05/2011 07:02 PM, Luiz Capitulino wrote: > > On Wed, 05 Oct 2011 18:37:51 +0200 > > Avi Kivity wrote: > > > > > On 10/05/2011 06:31 PM, Jan Kiszka wrote: > > > > >> > >

Re: [Qemu-devel] [PATCH] runstate: do not discard runstate changes when paused

2011-10-05 Thread Luiz Capitulino
On Wed, 05 Oct 2011 19:23:21 +0200 Avi Kivity wrote: > On 10/05/2011 07:02 PM, Luiz Capitulino wrote: > > On Wed, 05 Oct 2011 18:37:51 +0200 > > Avi Kivity wrote: > > > > > On 10/05/2011 06:31 PM, Jan Kiszka wrote: > > > > >> > > > > > > > > > > vm_start() should be symmetric with vm_st

Re: [Qemu-devel] [PATCH] runstate: do not discard runstate changes when paused

2011-10-05 Thread Avi Kivity
On 10/05/2011 07:02 PM, Luiz Capitulino wrote: On Wed, 05 Oct 2011 18:37:51 +0200 Avi Kivity wrote: > On 10/05/2011 06:31 PM, Jan Kiszka wrote: > > >> > > > > > > vm_start() should be symmetric with vm_stop(). That is, if a piece of > > > code wants to execute with vcpus stopped,

Re: [Qemu-devel] [PATCH] KVM: emulate lapic tsc deadline timer for guest

2011-10-05 Thread Liu, Jinsong
Marcelo Tosatti wrote: > On Sun, Sep 25, 2011 at 10:47:46PM +0800, Liu, Jinsong wrote: >> Marcelo Tosatti wrote: >>> On Fri, Sep 23, 2011 at 04:25:51PM +0800, Liu, Jinsong wrote: Marcelo Tosatti wrote: > On Thu, Sep 22, 2011 at 04:55:52PM +0800, Liu, Jinsong wrote: >>> From 4d5b83aba40

Re: [Qemu-devel] [PATCH] runstate: do not discard runstate changes when paused

2011-10-05 Thread Avi Kivity
On 10/05/2011 06:49 PM, Jan Kiszka wrote: On 2011-10-05 18:37, Avi Kivity wrote: > On 10/05/2011 06:31 PM, Jan Kiszka wrote: >> >> >> > >> > vm_start() should be symmetric with vm_stop(). That is, if a piece of >> > code wants to execute with vcpus stopped, it should just run inside a >

Re: [Qemu-devel] [PATCH] runstate: do not discard runstate changes when paused

2011-10-05 Thread Luiz Capitulino
On Wed, 05 Oct 2011 18:37:51 +0200 Avi Kivity wrote: > On 10/05/2011 06:31 PM, Jan Kiszka wrote: > > >> > > > > > > vm_start() should be symmetric with vm_stop(). That is, if a piece of > > > code wants to execute with vcpus stopped, it should just run inside a > > > stop/start pair. > > > >

Re: [Qemu-devel] [PATCH] runstate: do not discard runstate changes when paused

2011-10-05 Thread Jan Kiszka
On 2011-10-05 18:37, Avi Kivity wrote: > On 10/05/2011 06:31 PM, Jan Kiszka wrote: >> >> >> > >> > vm_start() should be symmetric with vm_stop(). That is, if a piece of >> > code wants to execute with vcpus stopped, it should just run inside a >> > stop/start pair. >> > >> > The only confusion

Re: [Qemu-devel] [PATCH] runstate: do not discard runstate changes when paused

2011-10-05 Thread Avi Kivity
On 10/05/2011 06:31 PM, Jan Kiszka wrote: >> > > vm_start() should be symmetric with vm_stop(). That is, if a piece of > code wants to execute with vcpus stopped, it should just run inside a > stop/start pair. > > The only confusion can come from the user, if he sees multiple stop > events

Re: [Qemu-devel] [PATCH] runstate: do not discard runstate changes when paused

2011-10-05 Thread Jan Kiszka
On 2011-10-05 17:43, Avi Kivity wrote: > On 10/05/2011 04:37 PM, Luiz Capitulino wrote: >> Now, we have three options to fix this but I don't know which one to >> choose: >> >> 1. We could just add the transition RSTATE_PAUSED -> >> RSTATE_POST_MIGRATE >> as valid. Not sure this is a good t

Re: [Qemu-devel] [PATCH] qed: fix use-after-free during l2 cache commit

2011-10-05 Thread Anthony Liguori
On 09/30/2011 05:39 AM, Stefan Hajnoczi wrote: QED's metadata caching strategy allows two parallel requests to race for metadata lookup. The first one to complete will populate the metadata cache and the second one will drop the data it just read in favor of the cached data. There is a use-afte

[Qemu-devel] [PATCH 0/6] block: do request processing in a coroutine

2011-10-05 Thread Stefan Hajnoczi
Block layer features like dirty block tracing, I/O throttling, and live block copy are forced to duplicate code due to the three different interfaces: synchronous, asynchronous, and coroutines. Since there are bdrv_read(), bdrv_aio_readv(), and bdrv_co_readv() interfaces for read (and similar for

[Qemu-devel] [PATCH 6/6] block: switch bdrv_aio_writev() to coroutines

2011-10-05 Thread Stefan Hajnoczi
More sync, aio, and coroutine unification. Make bdrv_aio_writev() go through coroutine request processing. Remove the dirty block callback mechanism which was needed only for aio processing and can be done more naturally in coroutine context. Signed-off-by: Stefan Hajnoczi --- block.c | 66 +

[Qemu-devel] [PATCH 5/6] block: mark blocks dirty on coroutine write completion

2011-10-05 Thread Stefan Hajnoczi
The aio write operation marks blocks dirty when the write operation completes. The coroutine write operation marks blocks dirty before issuing the write operation. It seems safest to mark the block dirty when the operation completes so that anything tracking dirty blocks will not act before the c

[Qemu-devel] [PATCH 3/6] block: switch bdrv_read()/bdrv_write() to coroutines

2011-10-05 Thread Stefan Hajnoczi
The bdrv_read()/bdrv_write() functions call .bdrv_read()/.bdrv_write(). They should go through bdrv_co_do_readv() and bdrv_co_do_writev() instead in order to unify request processing code across sync, aio, and coroutine interfaces. This is also an important step towards removing BlockDriverState .

[Qemu-devel] [PATCH 1/6] block: directly invoke .bdrv_aio_*() in bdrv_co_io_em()

2011-10-05 Thread Stefan Hajnoczi
We will unify block layer request processing across sync, aio, and coroutines and this means a .bdrv_co_*() emulation function should not call back into the public interface. There's no need here, just call .bdrv_aio_*() directly. The gory details: bdrv_co_io_em() cannot call back into the public

[Qemu-devel] [PATCH 2/6] block: split out bdrv_co_do_readv() and bdrv_co_do_writev()

2011-10-05 Thread Stefan Hajnoczi
The public interface for I/O in coroutine context is bdrv_co_readv() and bdrv_co_writev(). Split out the request processing code into bdrv_co_do_readv() and bdrv_co_writev() so that it can be called internally when we refactor all request processing to use coroutines. Signed-off-by: Stefan Hajnoc

[Qemu-devel] [PATCH 4/6] block: switch bdrv_aio_readv() to coroutines

2011-10-05 Thread Stefan Hajnoczi
More sync, aio, and coroutine unification. Make bdrv_aio_readv() go through coroutine request processing. Signed-off-by: Stefan Hajnoczi --- block.c | 48 +++- 1 files changed, 35 insertions(+), 13 deletions(-) diff --git a/block.c b/block.c index

Re: [Qemu-devel] [PATCH] runstate: do not discard runstate changes when paused

2011-10-05 Thread Avi Kivity
On 10/05/2011 05:43 PM, Avi Kivity wrote: On 10/05/2011 04:37 PM, Luiz Capitulino wrote: Now, we have three options to fix this but I don't know which one to choose: 1. We could just add the transition RSTATE_PAUSED -> RSTATE_POST_MIGRATE as valid. Not sure this is a good thing to do

Re: [Qemu-devel] [PATCH] runstate: do not discard runstate changes when paused

2011-10-05 Thread Avi Kivity
On 10/05/2011 04:37 PM, Luiz Capitulino wrote: Now, we have three options to fix this but I don't know which one to choose: 1. We could just add the transition RSTATE_PAUSED -> RSTATE_POST_MIGRATE as valid. Not sure this is a good thing to do though, as it seems a silly workaround f

Re: [Qemu-devel] [RFC] New Migration Protocol using Visitor Interface

2011-10-05 Thread Michael S. Tsirkin
On Wed, Oct 05, 2011 at 07:54:21AM -0500, Anthony Liguori wrote: > On 10/04/2011 09:05 PM, Stefan Berger wrote: > >On 10/03/2011 09:43 AM, Anthony Liguori wrote: > >>On 10/03/2011 08:24 AM, Michael S. Tsirkin wrote: > >>>On Mon, Oct 03, 2011 at 07:51:00AM -0500, Anthony Liguori wrote: > >Here a

Re: [Qemu-devel] [PATCH 19/23] migration: Export a function that tells if the migration has finished correctly

2011-10-05 Thread Anthony Liguori
On 10/05/2011 07:24 AM, Juan Quintela wrote: Anthony Liguori wrote: On 09/23/2011 07:57 AM, Juan Quintela wrote: This will allows us to hide the status values. --- a/ui/spice-core.c +++ b/ui/spice-core.c @@ -447,9 +447,7 @@ void do_info_spice(Monitor *mon, QObject **ret_data) static void

[Qemu-devel] [PULL 00/26]: QMP queue

2011-10-05 Thread Luiz Capitulino
Anthony, This pull request contains only the first round of QAPI conversions series. I had to rebase it but the changes are rather simple. The changes (since d11cf8cc80d946dfc9a23597cd9a0bb1c487cfa7) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp

[Qemu-devel] [PATCH 14/26] qapi: Convert query-version

2011-10-05 Thread Luiz Capitulino
Signed-off-by: Anthony Liguori Signed-off-by: Luiz Capitulino --- hmp.c| 13 + hmp.h|1 + monitor.c| 46 +++--- qapi-schema.json | 37 + qmp-commands.hx |6 +

[Qemu-devel] [PATCH 06/26] qapi: dealloc visitor, fix premature free and iteration logic

2011-10-05 Thread Luiz Capitulino
From: Michael Roth Currently we do 3 things wrong: 1) The list iterator, in practice, is used in a manner where the pointer we pass in is the same as the pointer we assign the output to from visit_next_list(). This causes an infinite loop where we keep freeing the same structures. 2) We attempt

[Qemu-devel] [PATCH 23/26] qapi: Convert quit

2011-10-05 Thread Luiz Capitulino
Signed-off-by: Anthony Liguori Signed-off-by: Luiz Capitulino --- hmp-commands.hx |2 +- hmp.c|6 ++ hmp.h|1 + monitor.c| 12 qapi-schema.json | 11 +++ qmp-commands.hx |5 + qmp.c|6 ++ 7 fil

[Qemu-devel] [PATCH 22/26] qapi: Convert query-commands

2011-10-05 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- monitor.c| 40 +++- qapi-schema.json | 23 +++ qmp-commands.hx |6 ++ 3 files changed, 44 insertions(+), 25 deletions(-) diff --git a/monitor.c b/monitor.c index 86a0dad..0c90506 10064

[Qemu-devel] [PATCH 04/26] qapi: use middle mode in QMP server

2011-10-05 Thread Luiz Capitulino
From: Anthony Liguori Use the new middle mode within the existing QMP server. Signed-off-by: Anthony Liguori Signed-off-by: Luiz Capitulino --- Makefile | 12 Makefile.objs|2 ++ Makefile.target |6 +++--- monitor.c|9 - qapi-schema.json

[Qemu-devel] [PATCH 15/26] qapi: Convert query-kvm

2011-10-05 Thread Luiz Capitulino
Signed-off-by: Anthony Liguori Signed-off-by: Luiz Capitulino --- hmp.c| 16 hmp.h|1 + monitor.c| 36 +--- qapi-schema.json | 25 + qmp-commands.hx |6 ++ qmp.c

[Qemu-devel] [PATCH 20/26] qapi: Convert query-uuid

2011-10-05 Thread Luiz Capitulino
Signed-off-by: Anthony Liguori Signed-off-by: Luiz Capitulino --- hmp.c|8 hmp.h|1 + monitor.c| 28 +--- qapi-schema.json | 24 qmp-commands.hx |6 ++ qmp.c| 15 +

[Qemu-devel] [PATCH 26/26] qapi: Convert system_powerdown

2011-10-05 Thread Luiz Capitulino
Signed-off-by: Anthony Liguori Signed-off-by: Luiz Capitulino --- hmp-commands.hx |3 +-- hmp.c|5 + hmp.h|1 + qapi-schema.json | 14 ++ qmp.c|5 + 5 files changed, 26 insertions(+), 2 deletions(-) diff --git a/hmp-comm

[Qemu-devel] [PATCH 13/26] qapi: convert query-name

2011-10-05 Thread Luiz Capitulino
From: Anthony Liguori A simple example conversion 'info name'. This also adds the new files for QMP and HMP. Signed-off-by: Anthony Liguori Signed-off-by: Luiz Capitulino --- Makefile.objs|1 + hmp.c| 26 ++ hmp.h| 22 ++

[Qemu-devel] [PATCH 11/26] qapi: Don't use c_var() on enum strings

2011-10-05 Thread Luiz Capitulino
Otherwise if we have something like 'foo-bar' in the schema, it will be generated as 'foo_bar' in the string lookup table. c_var() is good for C variables, but not for enum strings. Signed-off-by: Luiz Capitulino --- scripts/qapi-types.py |2 +- 1 files changed, 1 insertions(+), 1 deletions

Re: [Qemu-devel] [PATCH] runstate: do not discard runstate changes when paused

2011-10-05 Thread Luiz Capitulino
On Tue, 4 Oct 2011 14:04:45 +0200 Paolo Bonzini wrote: > Trying to migrate a paused machine fails. The reason is that > the RSTATE_PRE_MIGRATE is reached with vm_stop, and this > transition is eaten when the vm is already paused. This patch > fixes the problem by always going through runstate_

[Qemu-devel] [PATCH 21/26] qapi: Convert query-chardev

2011-10-05 Thread Luiz Capitulino
Reviewed-by: Michael Roth Tested-by: Michael Roth Signed-off-by: Anthony Liguori Signed-off-by: Luiz Capitulino --- hmp.c| 13 + hmp.h|1 + monitor.c| 11 +-- qapi-schema.json | 26 ++ qemu-char.c | 35

[Qemu-devel] [PATCH 10/26] qapi: modify visitor code generation for list iteration

2011-10-05 Thread Luiz Capitulino
From: Michael Roth Modify logic such that we never assign values to the list head argument to progress through the list on subsequent iterations, instead rely only on having our return value passed back in as an argument on the next call. Also update QMP I/O visitors and test cases accordingly, a

[Qemu-devel] [PATCH 05/26] qapi: fixup command generation for functions that return list types

2011-10-05 Thread Luiz Capitulino
From: Anthony Liguori Signed-off-by: Anthony Liguori Signed-off-by: Luiz Capitulino --- scripts/qapi-commands.py | 23 +++ 1 files changed, 15 insertions(+), 8 deletions(-) diff --git a/scripts/qapi-commands.py b/scripts/qapi-commands.py index 2776804..c947ba4 100644 ---

[Qemu-devel] [PATCH 08/26] qapi: add test cases for generated free functions

2011-10-05 Thread Luiz Capitulino
From: Michael Roth Signed-off-by: Michael Roth Signed-off-by: Luiz Capitulino --- test-qmp-commands.c | 29 + 1 files changed, 29 insertions(+), 0 deletions(-) diff --git a/test-qmp-commands.c b/test-qmp-commands.c index f142cc6..fa5a7bd 100644 --- a/test-qmp-com

Re: [Qemu-devel] segfault on current HEAD, qemu-system-arm

2011-10-05 Thread Peter Maydell
On 2 October 2011 19:44, Blue Swirl wrote: > Bah, bug in bccd9ec5f098668576342c83d90d6d6833d61d33, > target-arm/op_helper.c missed this change unlike all other targets: > diff --git a/target-arm/op_helper.c b/target-arm/op_helper.c > index ab9c923..1892b35 100644 > --- a/target-arm/op_helper.c > +

[Qemu-devel] [PATCH 12/26] qapi: Automatically generate a _MAX value for enums

2011-10-05 Thread Luiz Capitulino
It's the last value in the enum and is very useful for the C implementation. Signed-off-by: Luiz Capitulino --- scripts/qapi-types.py |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py index 3bacc0c..f64d84c 100644 --- a/scr

[Qemu-devel] [PATCH 09/26] qapi: dealloc visitor, support freeing of nested lists

2011-10-05 Thread Luiz Capitulino
From: Michael Roth Previously our logic for keeping track of when we're visiting the head of a list was done via a global bool. This can be overwritten if dealing with nested lists, so use stack entries to track this instead. Reviewed-by: Anthony Liguori Signed-off-by: Michael Roth Signed-off-

[Qemu-devel] [PATCH 24/26] qapi: Convert stop

2011-10-05 Thread Luiz Capitulino
Signed-off-by: Anthony Liguori Signed-off-by: Luiz Capitulino --- hmp-commands.hx |3 +-- hmp.c|5 + hmp.h|1 + monitor.c|9 - qapi-schema.json | 12 qmp-commands.hx |5 + qmp.c|5 + 7 files

[Qemu-devel] [PATCH 19/26] qapi: Convert query-status

2011-10-05 Thread Luiz Capitulino
Please, note that the RunState type as defined in sysemu.h and its runstate_as_string() function are being dropped in favor of the RunState type generated by the QAPI. Signed-off-by: Anthony Liguori Signed-off-by: Luiz Capitulino --- hmp.c| 19 +++ hmp.h|

[Qemu-devel] [PATCH 07/26] qapi: generate qapi_free_* functions for *List types

2011-10-05 Thread Luiz Capitulino
From: Michael Roth Reviewed-by: Anthony Liguori Signed-off-by: Michael Roth Signed-off-by: Luiz Capitulino --- scripts/qapi-types.py |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py index fc0f7af..4797a70 100644 --- a/scri

[Qemu-devel] [PATCH 03/26] qapi: add code generation support for middle mode

2011-10-05 Thread Luiz Capitulino
From: Anthony Liguori To get the ball rolling merging QAPI, this patch introduces a "middle mode" to the code generator. In middle mode, the code generator generates marshalling functions that are compatible with the current QMP server. We absolutely need to replace the current QMP server in or

[Qemu-devel] [PATCH 25/26] qapi: Convert system_reset

2011-10-05 Thread Luiz Capitulino
Signed-off-by: Anthony Liguori Signed-off-by: Luiz Capitulino --- hmp-commands.hx |3 +-- hmp.c|5 + hmp.h|1 + monitor.c| 10 -- qapi-schema.json |9 + qmp-commands.hx |5 + qmp.c|4 7 files cha

[Qemu-devel] [PATCH 17/26] RunState: Drop the RSTATE_NO_STATE value

2011-10-05 Thread Luiz Capitulino
The QAPI framework won't generate it, so we need to get rid of it. In order to do that, this commit makes RSTATE_PRE_LAUNCH the initial state and change qemu_vmstop_requested() to use RSTATE_MAX. Signed-off-by: Luiz Capitulino --- sysemu.h |1 - vl.c | 19 +++ 2 files

[Qemu-devel] [PATCH 18/26] RunState: Rename enum values as generated by the QAPI

2011-10-05 Thread Luiz Capitulino
Next commit will convert the query-status command to use the RunState type as generated by the QAPI. In order to "transparently" replace the current enum by the QAPI one, we have to make some changes to some enum values. As the changes are simple renames, I'll do them in one shot. The changes are

Re: [Qemu-devel] QEMU + ARMMP11Core combination does not work

2011-10-05 Thread Peter Maydell
On 4 October 2011 06:07, TusharK wrote: > I tried executing QEMU (realview-smp ARM11MPCore) with Linux kernel 2.6.39.3, > but it failed. Kernel itself is not getting decompressed. > I am executing below command. > > qemu-system-arm -M realview-eb-mpcore -cpu arm11mpcore -kernel > arch/arm/boot/z

[Qemu-devel] [PATCH 16/26] vl: Change qemu_vmstop_requested() to return a bool

2011-10-05 Thread Luiz Capitulino
The stop reason is returned in the RunState argument. This is a preparation for a future commit which will convert the query-status command to the QAPI. Signed-off-by: Luiz Capitulino --- vl.c | 16 ++-- 1 files changed, 10 insertions(+), 6 deletions(-) diff --git a/vl.c b/vl.c in

[Qemu-devel] [PATCH 02/26] qerror: add qerror_report_err()

2011-10-05 Thread Luiz Capitulino
From: Anthony Liguori This provides a bridge between Error (new error mechanism) and QError (old error mechanism). Errors can be propagated whereas QError cannot. The minor evilness avoids layering violations. Since QError should go away RSN, it seems like a reasonable hack. Signed-off-by: An

[Qemu-devel] [PATCH 01/26] error: let error_is_type take a NULL error

2011-10-05 Thread Luiz Capitulino
From: Anthony Liguori Reported-by: Luiz Capitulino Signed-off-by: Anthony Liguori Signed-off-by: Luiz Capitulino --- error.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/error.c b/error.c index b802752..68c0039 100644 --- a/error.c +++ b/error.c @@ -97,6 +97,10

Re: [Qemu-devel] [RFC] New Migration Protocol using Visitor Interface

2011-10-05 Thread Anthony Liguori
On 10/04/2011 09:05 PM, Stefan Berger wrote: On 10/03/2011 09:43 AM, Anthony Liguori wrote: On 10/03/2011 08:24 AM, Michael S. Tsirkin wrote: On Mon, Oct 03, 2011 at 07:51:00AM -0500, Anthony Liguori wrote: Here are some suggestions: - Let's make the protocol be BER directly. As a first step,

Re: [Qemu-devel] [RFC] New Migration Protocol using Visitor Interface

2011-10-05 Thread Anthony Liguori
On 10/05/2011 06:28 AM, Michael S. Tsirkin wrote: On Mon, Oct 03, 2011 at 10:00:48AM -0500, Anthony Liguori wrote: Yes, it's easy to quantify. I think the following gives us the offset before and after, so the difference is the size we seek, right? OK, Orit (Cc'd) did some research - this is a

Re: [Qemu-devel] [PATCH 19/23] migration: Export a function that tells if the migration has finished correctly

2011-10-05 Thread Juan Quintela
Anthony Liguori wrote: > On 09/23/2011 07:57 AM, Juan Quintela wrote: >> This will allows us to hide the status values. >> >> --- a/ui/spice-core.c >> +++ b/ui/spice-core.c >> @@ -447,9 +447,7 @@ void do_info_spice(Monitor *mon, QObject **ret_data) >> >> static void migration_state_notifier(Noti

Re: [Qemu-devel] QEMU + ARMMP11Core combination does not work

2011-10-05 Thread TusharK
Hello, I am not getting any reply on this query. I do not know how should I use this combination and really stuck because of this. Can somebody from QEMU devel quickly provide me help in this regard? I do not know what is taking time to answer this query. Let me know if anything is needed from

Re: [Qemu-devel] [PATCH RFC V1 11/11] config/make: Introduce --enable-xen-pci-passthrough, built it.

2011-10-05 Thread Stefano Stabellini
On Tue, 4 Oct 2011, Anthony PERARD wrote: > Signed-off-by: Anthony PERARD > --- > Makefile.target |7 +++ > configure | 21 + > 2 files changed, 28 insertions(+), 0 deletions(-) > > diff --git a/Makefile.target b/Makefile.target > index f708453..b5fbc18 100644

Re: [Qemu-devel] [PATCH RFC V1 10/11] Introduce Xen PCI Passthrough, MSI (3/3)

2011-10-05 Thread Stefano Stabellini
On Tue, 4 Oct 2011, Anthony PERARD wrote: > Signed-off-by: Anthony PERARD You should set the original author of this patch correctly and add his signed-off-by. Remember to run the patch through checkpatch.pl. > --- > hw/xen_pci_passthrough_msi.c | 674 > +++

Re: [Qemu-devel] [PATCH RFC V1 08/11] Introduce Xen PCI Passthrough, qdevice (1/3)

2011-10-05 Thread Stefano Stabellini
On Tue, 4 Oct 2011, Anthony PERARD wrote: > Signed-off-by: Anthony PERARD You should set the original author correctly and add his signed-off-by. Remeber to run the patch through checkpatch.pl. > --- > hw/xen_pci_passthrough.c | 763 > ++ > hw/xen_p

Re: [Qemu-devel] [PATCH RFC V1 07/11] host-pci-device: Add host_pci_find_ext_cap_offset

2011-10-05 Thread Stefano Stabellini
On Tue, 4 Oct 2011, Anthony PERARD wrote: > Signed-off-by: Anthony PERARD any reason why we shouldn't merge this patch with patch #1? > --- > hw/host-pci-device.c | 31 +++ > hw/host-pci-device.h |2 ++ > 2 files changed, 33 insertions(+), 0 deletions(-) > >

Re: [Qemu-devel] [PATCH 2/2] LAPIC: make lapic support cpu hotplug

2011-10-05 Thread Jan Kiszka
On 2011-10-05 12:26, liu ping fan wrote: >> > And make the creation of apic as part of cpu initialization, so >>> apic's state has been ready, before setting kvm_apic. >> >> There is no kvm-apic upstream yet, so it's hard to judge why we need >> this here. If we do, this has to be a separate patch

Re: [Qemu-devel] [PATCH 2/2] LAPIC: make lapic support cpu hotplug

2011-10-05 Thread liu ping fan
On Wed, Oct 5, 2011 at 12:43 AM, Jan Kiszka wrote: > On 2011-10-04 13:13, pingf...@linux.vnet.com wrote: > > From: Liu Ping Fan > > > > Separate apic from qbus to icc bus which supports hotplug feature. > > Modeling the ICC bus looks like a step in the right direction. The > IOAPIC could be atta

Re: [Qemu-devel] [PATCH 2/2] LAPIC: make lapic support cpu hotplug

2011-10-05 Thread liu ping fan
On Tue, Oct 4, 2011 at 8:58 PM, Anthony Liguori wrote: > On 10/04/2011 06:13 AM, pingf...@linux.vnet.com wrote: > >> From: Liu Ping Fan >> > >> >> Separate apic from qbus to icc bus which supports hotplug feature. >> And make the creation of apic as part of cpu initialization, so >> apic's state h

Re: [Qemu-devel] [PATCH] Make cpu_single_env thread local (Linux only for now)

2011-10-05 Thread Paolo Bonzini
On 10/05/2011 09:52 AM, Jan Kiszka wrote: Yeah, it probably makes sense to build the abstractions around __thread so that - one day - we can drop the legacy wrappers. Just do not prepend "tls__" in the gcc model Actually I did that on purpose so that people would not forget get_tls. :) (ther

[Qemu-devel] [PATCH 7/7] linux-user: Remove unused code

2011-10-05 Thread Stefan Hajnoczi
From: Stefan Weil The code is unused since 8 years, so remove it. Signed-off-by: Stefan Weil Signed-off-by: Stefan Hajnoczi --- linux-user/signal.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/linux-user/signal.c b/linux-user/signal.c index 89276eb..40c5eb18 10

[Qemu-devel] [PATCH 4/7] lsi: Fix tag reference in debug print

2011-10-05 Thread Stefan Hajnoczi
From: Jan Kiszka Signed-off-by: Jan Kiszka Signed-off-by: Stefan Hajnoczi --- hw/lsi53c895a.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/lsi53c895a.c b/hw/lsi53c895a.c index 75a03a7..e077ec0 100644 --- a/hw/lsi53c895a.c +++ b/hw/lsi53c895a.c @@ -697,7 +697,7 @

[Qemu-devel] [PATCH 3/7] gt64xxx.c: remove reference to non-existing ISD_handle field

2011-10-05 Thread Stefan Hajnoczi
From: Antony Pavlov The commit fc2bf44972349b078d8310466c3866615500e67f removed ISD_handle field from struct GT64120State, so remove the field from DPRINTF too. Signed-off-by: Antony Pavlov Signed-off-by: Stefan Hajnoczi --- hw/gt64xxx.c |5 +++-- 1 files changed, 3 insertions(+), 2 delet

[Qemu-devel] [PATCH 6/7] Fix mismatching allocation and deallocation

2011-10-05 Thread Stefan Hajnoczi
From: Stefan Weil This error was reported by cppcheck. Signed-off-by: Stefan Weil Signed-off-by: Stefan Hajnoczi --- console.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/console.c b/console.c index 6dfcc47..e43de92 100644 --- a/console.c +++ b/console.c @@ -1538

[Qemu-devel] [PATCH 5/7] target-arm: Fix typo

2011-10-05 Thread Stefan Hajnoczi
From: Andreas Färber The command line option is called -kernel, not -kenrel. Cc: Paul Brook Reviewed-by: Peter Maydell Signed-off-by: Andreas Färber Signed-off-by: Stefan Hajnoczi --- target-arm/helper.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-arm/he

[Qemu-devel] [PATCH 2/7] gt64xxx.c: fix length modifier in DPRINTF format string

2011-10-05 Thread Stefan Hajnoczi
From: Antony Pavlov The commit fc2bf44972349b078d8310466c3866615500e67f changed the type of val argument of the function gt64120_writel() from uint32_t to uint64_t, so we need to change the corresponding length modifier from "%x" to "%" PRIx64. Signed-off-by: Antony Pavlov Signed-off-by: Stefan

[Qemu-devel] [PATCH 1/7] makefile: extract tools-obj-y

2011-10-05 Thread Stefan Hajnoczi
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- Makefile |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index 6ed3194..5723108 100644 --- a/Makefile +++ b/Makefile @@ -145,11 +145,12 @@ endif qemu-img.o:

[Qemu-devel] [PULL 0/7] Trivial patches for September 22 to October 5 2011

2011-10-05 Thread Stefan Hajnoczi
The following changes since commit d11cf8cc80d946dfc9a23597cd9a0bb1c487cfa7: etrax-dma: Remove bogus if statement (2011-10-03 10:20:13 +0200) are available in the git repository at: ssh://repo.or.cz/srv/git/qemu/stefanha.git trivial-patches Andreas Färber (1): target-arm: Fix typo Ant

[Qemu-devel] [PATCH v3 08/15] block: add bdrv_co_discard and bdrv_aio_discard support

2011-10-05 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- block.c | 140 - block.h |3 + block_int.h |9 +++- trace-events |1 + 4 files changed, 148 insertions(+), 5 deletions(-) diff --git a/block.c b/block.c index f4b9089..7853982 100644

[Qemu-devel] [PATCH v3 14/15] nbd: split requests

2011-10-05 Thread Paolo Bonzini
qemu-nbd has a limit of slightly less than 1M per request. Work around this in the nbd block driver. Signed-off-by: Paolo Bonzini --- block/nbd.c | 52 ++-- 1 files changed, 46 insertions(+), 6 deletions(-) diff --git a/block/nbd.c b/block/nbd.

[Qemu-devel] [PATCH v3 02/15] add socket_set_block

2011-10-05 Thread Paolo Bonzini
Cc: MORITA Kazutaka Signed-off-by: Paolo Bonzini --- oslib-posix.c |7 +++ oslib-win32.c |6 ++ qemu_socket.h |1 + 3 files changed, 14 insertions(+), 0 deletions(-) diff --git a/oslib-posix.c b/oslib-posix.c index a304fb0..dbc8ee8 100644 --- a/oslib-posix.c +++ b/oslib-posi

[Qemu-devel] [PATCH v3 03/15] add qemu_send_full and qemu_recv_full

2011-10-05 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- osdep.c | 67 + qemu-common.h |4 +++ 2 files changed, 71 insertions(+), 0 deletions(-) diff --git a/osdep.c b/osdep.c index 56e6963..718a25d 100644 --- a/osdep.c +++ b/osdep.c @@ -166,3 +166,70

[Qemu-devel] [PATCH 1/6] vvfat: fix out of bounds array_get usage

2011-10-05 Thread Paolo Bonzini
When reading the address of the first free entry, you cannot use array_get without first marking all entries as occupied. This is visible if you change the sectors per cluster on a floppy from 2 to 1. Signed-off-by: Paolo Bonzini --- block/vvfat.c |1 + 1 files changed, 1 insertions(+), 0 d

[Qemu-devel] [PATCH v3 13/15] nbd: switch to asynchronous operation

2011-10-05 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- block/nbd.c | 218 +++ nbd.c |8 ++ 2 files changed, 152 insertions(+), 74 deletions(-) diff --git a/block/nbd.c b/block/nbd.c index 35c15c8..90c4f2f 100644 --- a/block/nbd.c +++ b/block/nbd.c @@

[Qemu-devel] [PATCH 2/6] vvfat: do not fail if the disk has spare sectors

2011-10-05 Thread Paolo Bonzini
If the number of "faked sectors" + the number of sectors that are part of a cluster does not sum up to the total number of sectors, qemu-img convert fails. Read these spare sectors as all zeros. Signed-off-by: Paolo Bonzini --- block/vvfat.c |4 ++-- 1 files changed, 2 insertions(+), 2 dele

[Qemu-devel] [PATCH v3 04/15] sheepdog: move coroutine send/recv function to generic code

2011-10-05 Thread Paolo Bonzini
Outside coroutines, avoid busy waiting on EAGAIN by temporarily making the socket blocking. The API of qemu_recvv/qemu_sendv is slightly different from do_readv/do_writev because they do not handle coroutines. It returns the number of bytes written before encountering an EAGAIN. The specificity

Re: [Qemu-devel] [PATCH 1/2] linux-user: Remove unused code

2011-10-05 Thread Stefan Hajnoczi
On Mon, Oct 03, 2011 at 10:43:19PM +0200, Stefan Weil wrote: > The code is unused since 8 years, so remove it. > > Signed-off-by: Stefan Weil > --- > linux-user/signal.c |5 + > 1 files changed, 1 insertions(+), 4 deletions(-) Thanks, applied to the trivial patches tree: http://repo.or.

[Qemu-devel] [PATCH 3/6] vvfat: need to use first_sectors_number to distinguish fdd/hdd

2011-10-05 Thread Paolo Bonzini
This is consistent with what "real" floppies have, so file(1) now actually recognizes the VVFAT image as a 1.44 MB floppy. Signed-off-by: Paolo Bonzini --- block/vvfat.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/block/vvfat.c b/block/vvfat.c index bc2dd4c..eb916

  1   2   >