[Qemu-devel] [PATCH] exec-all: Fix void pointer arithmetic

2011-10-23 Thread Stefan Weil
Adding an offset to a void pointer works with gcc but is not allowed by the current C standards. With -pedantic, gcc complains: exec-all.h:344: error: pointer of type ‘void *’ used in arithmetic Fix this, and also replace (unsigned int) by (uintptr_t) in the same statement. Signed-off-by:

Re: [Qemu-devel] [Spice-devel] Possible SPICE/QEMU deadlock on fast client reconnect

2011-10-23 Thread Yonit Halperin
Hi, Sounds like https://bugzilla.redhat.com/show_bug.cgi?id=746950 and https://bugs.freedesktop.org/show_bug.cgi?id=41858 Alon's patch: http://lists.freedesktop.org/archives/spice-devel/2011-September /005369.html Should solve it. Cheers, Yonit. On 10/21/2011 05:26 PM, Daniel P. Berrange

Re: [Qemu-devel] [PATCH 3/4] loader: Add rom_add_file_buf for adding roms from a buffer

2011-10-23 Thread Blue Swirl
On Tue, Oct 18, 2011 at 21:17, Jordan Justen jljus...@gmail.com wrote: On Tue, Oct 18, 2011 at 11:05, Blue Swirl blauwir...@gmail.com wrote: On Mon, Oct 17, 2011 at 7:16 PM, Jordan Justen jordan.l.jus...@intel.com wrote: rom_add_file_buf is similar to rom_add_file, except the rom's contents

Re: [Qemu-devel] [PATCH 06/21] target-sparc: Extract common code for floating-point operations.

2011-10-23 Thread Blue Swirl
On Tue, Oct 18, 2011 at 22:21, Richard Henderson r...@twiddle.net wrote: On 10/18/2011 01:24 PM, Blue Swirl wrote:  #ifdef TARGET_SPARC64 -float64 helper_fabsd(CPUState *env, float64 src) +float64 helper_fabsd(float64 src) This probably should go to previous patch. Sure. +/* Turn off the

Re: [Qemu-devel] [PATCH 00/26] AREG0 conversion

2011-10-23 Thread Blue Swirl
On Wed, Oct 19, 2011 at 17:25, Richard Henderson r...@twiddle.net wrote: On 10/09/2011 12:20 PM, Blue Swirl wrote: I didn't bother to attach the patches, if someone wants to try, the patch set can be found here:        git://repo.or.cz/qemu/blueswirl.git        

Re: [Qemu-devel] [PATCH 1/1] Introduce a new bus ICC to connect APIC

2011-10-23 Thread Blue Swirl
On Wed, Oct 19, 2011 at 01:55, pingf...@linux.vnet.ibm.com wrote: From: Liu Ping Fan pingf...@linux.vnet.ibm.com Introduce a new structure CPUS as the controller of ICC (INTERRUPT CONTROLLER COMMUNICATIONS), and new bus ICC to hold APIC,instead of sysbus. So we can support APIC hot-plug

Re: [Qemu-devel] [PATCH] gdbstub: Fix memory leak

2011-10-23 Thread Blue Swirl
On Thu, Oct 20, 2011 at 08:10, Stuart Brady s...@zubnet.me.uk wrote: On Wed, Oct 19, 2011 at 01:59:04AM +0100, Stuart Brady wrote: On Tue, Oct 18, 2011 at 06:18:11PM +, Blue Swirl wrote: Cool. Please include the spatch with the commit message. Thanks, will do! Okay, submitted. This

Re: [Qemu-devel] [PATCH v2 1/4] Add basic version of bridge helper

2011-10-23 Thread Blue Swirl
On Fri, Oct 21, 2011 at 15:07, Corey Bryant cor...@linux.vnet.ibm.com wrote: This patch adds a helper that can be used to create a tap device attached to a bridge device.  Since this helper is minimal in what it does, it can be given CAP_NET_ADMIN which allows qemu to avoid running as root

Re: [Qemu-devel] [PATCH v2 2/4] Add access control support to qemu bridge helper

2011-10-23 Thread Blue Swirl
On Fri, Oct 21, 2011 at 15:07, Corey Bryant cor...@linux.vnet.ibm.com wrote: We go to great lengths to restrict ourselves to just cap_net_admin as an OS enforced security mechanism.  However, we further restrict what we allow users to do to simply adding a tap device to a bridge interface by

Re: [Qemu-devel] [PATCH v2 3/4] Add cap reduction support to enable use as SUID

2011-10-23 Thread Blue Swirl
On Fri, Oct 21, 2011 at 15:07, Corey Bryant cor...@linux.vnet.ibm.com wrote: The ideal way to use qemu-bridge-helper is to give it an fscap of using:  setcap cap_net_admin=ep qemu-bridge-helper Unfortunately, most distros still do not have a mechanism to package files with fscaps applied.  

Re: [Qemu-devel] [PATCH 5/5] Convert remaining calls to g_malloc(sizeof(type)) to g_new()

2011-10-23 Thread Blue Swirl
On Fri, Oct 21, 2011 at 00:26, Stuart Brady s...@zubnet.me.uk wrote: On Thu, Oct 20, 2011 at 11:05:33AM +0200, Paolo Bonzini wrote: On 10/20/2011 10:03 AM, Stuart Brady wrote: Coccinelle did not match these when matching assignments involving an expression corresponding to the type used for

Re: [Qemu-devel] build with trace enabled is broken by the commit c572f23a3e7180dbeab5e86583e43ea2afed6271 hw/9pfs: Introduce tracing for 9p pdu handlers

2011-10-23 Thread Jan Kiszka
On 2011-10-21 17:10, Aneesh Kumar K.V wrote: On Thu, 20 Oct 2011 23:20:54 +0400, Max Filippov jcmvb...@gmail.com wrote: Hi. Current git head build with trace enabled is broken by the commit c572f23a3e7180dbeab5e86583e43ea2afed6271 hw/9pfs: Introduce tracing for 9p pdu handlers. Error

Re: [Qemu-devel] [PATCH 0/2] block: Write out internal caches even with cache=unsafe

2011-10-23 Thread Paolo Bonzini
On 10/22/2011 05:07 PM, Alexander Graf wrote: On 21.10.2011, at 11:44, Paolo Bonzini wrote: On 10/21/2011 07:08 PM, Kevin Wolf wrote: Avi complained that not even writing out qcow2's cache on bdrv_flush() made cache=unsafe too unsafe to be useful. He's got a point. Why? cache=unsafe is

[Qemu-devel] [PATCH 2/2] libcacard/vscclient: fix error paths for socket creation

2011-10-23 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- libcacard/vscclient.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c index 2191f60..e317a25 100644 --- a/libcacard/vscclient.c +++ b/libcacard/vscclient.c @@ -357,6 +357,7

[Qemu-devel] [PATCH 0/2] libcacard coverity found fixes

2011-10-23 Thread Alon Levy
Two fixes, the first means memory for a vcard applet was never freed, the second fixes vscclient handling of errors when opening it's socket. Alon Levy (2): libcacard/cac: fix typo in cac_delete_pki_applet_private libcacard/vscclient: fix error paths for socket creation libcacard/cac.c

[Qemu-devel] [PATCH 1/2] libcacard/cac: fix typo in cac_delete_pki_applet_private

2011-10-23 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- libcacard/cac.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/libcacard/cac.c b/libcacard/cac.c index f4b0b1b..927a4ca 100644 --- a/libcacard/cac.c +++ b/libcacard/cac.c @@ -266,7 +266,8 @@ static void

[Qemu-devel] [PATCH] qxl: reset update_surface

2011-10-23 Thread Alon Levy
update init_qxl_ram to reset update_surface to 0. This fixes one case of breakage when installing an old driver in a vm that had a new driver installed. The newer driver would know about surface creation and would change update_surface to !=0, then a reset would happen, all surfaces are destroyed,

Re: [Qemu-devel] [PATCH v3] add add-cow file format

2011-10-23 Thread shu ming
On 2011-10-13 0:23, Dong Xu Wang wrote: Add add-cow file format Signed-off-by: Dong Xu Wangwdon...@linux.vnet.ibm.com --- Makefile.objs |1 + block.c|2 +- block.h|1 + block/add-cow.c| 412

[Qemu-devel] [PATCH RFC v2 0/2] Initial support for Microsoft Hyper-V.

2011-10-23 Thread Vadim Rozenfeld
With the following series of patches we are starting to implement some basic Microsoft Hyper-V Enlightenment functionality. This series is mostly about adding support for relaxed timing, spinlock, and virtual apic. For more Hyper-V related information please see: Hypervisor Functional

[Qemu-devel] [PATCH 2/2] [PATCH RFC v2 2/2] hyper-v: initialize Hyper-V CPUID leaves.

2011-10-23 Thread Vadim Rozenfeld
--- target-i386/kvm.c | 73 +++- 1 files changed, 71 insertions(+), 2 deletions(-) diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 82fec8c..c061e3b 100644 --- a/target-i386/kvm.c +++ b/target-i386/kvm.c @@ -29,6 +29,7 @@ #include

[Qemu-devel] [PATCH 1/2] [PATCH RFC v2 1/2] hyper-v: introduce Hyper-V support infrastructure.

2011-10-23 Thread Vadim Rozenfeld
--- Makefile.target |2 + target-i386/cpuid.c | 14 ++ target-i386/hyperv.c | 65 ++ target-i386/hyperv.h | 37 4 files changed, 118 insertions(+), 0 deletions(-) create mode 100644

Re: [Qemu-devel] [PATCH 1/1] Introduce a new bus ICC to connect APIC

2011-10-23 Thread Jan Kiszka
On 2011-10-23 14:40, Blue Swirl wrote: I'm not sure that a full bus is needed for now, even if it could match real HW better, since the memory API already provides the separation needed. Perhaps this would be needed later to make IRQs per-CPU also, or to put IOAPIC also to the bus? The ICC

Re: [Qemu-devel] [PATCH 1/1] Introduce a new bus ICC to connect APIC

2011-10-23 Thread Blue Swirl
On Sun, Oct 23, 2011 at 15:45, Jan Kiszka jan.kis...@web.de wrote: On 2011-10-23 14:40, Blue Swirl wrote: I'm not sure that a full bus is needed for now, even if it could match real HW better, since the memory API already provides the separation needed. Perhaps this would be needed later to

Re: [Qemu-devel] [PATCH 1/1] Introduce a new bus ICC to connect APIC

2011-10-23 Thread Jan Kiszka
On 2011-10-23 17:54, Blue Swirl wrote: On Sun, Oct 23, 2011 at 15:45, Jan Kiszka jan.kis...@web.de wrote: On 2011-10-23 14:40, Blue Swirl wrote: I'm not sure that a full bus is needed for now, even if it could match real HW better, since the memory API already provides the separation needed.

Re: [Qemu-devel] [Spice-devel] Possible SPICE/QEMU deadlock on fast client reconnect

2011-10-23 Thread Alon Levy
On Sun, Oct 23, 2011 at 09:37:59AM +0200, Yonit Halperin wrote: Hi, Sounds like https://bugzilla.redhat.com/show_bug.cgi?id=746950 and https://bugs.freedesktop.org/show_bug.cgi?id=41858 Alon's patch: http://lists.freedesktop.org/archives/spice-devel/2011-September /005369.html Should

Re: [Qemu-devel] [PATCH] pci_bridge: fix typo

2011-10-23 Thread Blue Swirl
On Sun, Oct 16, 2011 at 15:11, Avi Kivity a...@redhat.com wrote: On 10/16/2011 04:44 PM, Blue Swirl wrote: Signed-off-by: Blue Swirl blauwir...@gmail.com ---  hw/pci_bridge.c |    2 +-  1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/pci_bridge.c b/hw/pci_bridge.c index

Re: [Qemu-devel] [PATCH V5] Add stdio char device on windows

2011-10-23 Thread Blue Swirl
Thanks, applied. On Thu, Oct 6, 2011 at 14:37, Fabien Chouteau chout...@adacore.com wrote: Simple implementation of an stdio char device on Windows. Signed-off-by: Fabien Chouteau chout...@adacore.com ---  qemu-char.c |  227 ++-  1

[Qemu-devel] Help: Email archive search broken

2011-10-23 Thread Juan Pineda
Hello, Search within the qemu-devel Email archives appears broken. Articles are returned, but it seems only up to around June 2011. For example, the following query searching for dvd:

Re: [Qemu-devel] [Qemu-ppc] [PATCH] PPC: Fail configure when libfdt is not available

2011-10-23 Thread David Gibson
On Fri, Oct 21, 2011 at 09:34:22AM +0200, Paolo Bonzini wrote: On 10/20/2011 08:35 PM, Gerd Hoffmann wrote: Hi, If there are build problems with libfdt on any platform let me know about them. I would like it to build clean as widely as possible, but I don't have that great a

Re: [Qemu-devel] [Question] dump memory when host pci device is used by guest

2011-10-23 Thread Wen Congyang
At 10/21/2011 09:02 PM, Dave Anderson Write: - Original Message - At 10/21/2011 03:11 PM, Jan Kiszka Write: On 2011-10-20 12:03, Wen Congyang wrote: At 10/20/2011 05:41 PM, Jan Kiszka Write: On 2011-10-20 03:22, Wen Congyang wrote: I didn't read full story but 'crash' is used for

[Qemu-devel] [PATCH] ppc: Fix up usermode only builds

2011-10-23 Thread David Gibson
The recent usage of MemoryRegion in kvm_ppc.h breaks builds with CONFIG_USER_ONLY=y. This patch fixes it. Signed-off-by: David Gibson da...@gibson.dropbear.id.au --- target-ppc/kvm_ppc.h |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/target-ppc/kvm_ppc.h

Re: [Qemu-devel] [PATCH] ppc: Fix up usermode only builds

2011-10-23 Thread Alexander Graf
On 23.10.2011, at 20:25, David Gibson da...@gibson.dropbear.id.au wrote: The recent usage of MemoryRegion in kvm_ppc.h breaks builds with CONFIG_USER_ONLY=y. This patch fixes it. Signed-off-by: David Gibson da...@gibson.dropbear.id.au Ouch. Thanks a lot for the fix! Alex ---

Re: [Qemu-devel] [RFC v2 PATCH 5/4 PATCH] virtio-net: send gratuitous packet when needed

2011-10-23 Thread Rusty Russell
On Sat, 22 Oct 2011 13:43:11 +0800, Jason Wang jasow...@redhat.com wrote: This make let virtio-net driver can send gratituous packet by a new config bit - VIRTIO_NET_S_ANNOUNCE in each config update interrupt. When this bit is set by backend, the driver would schedule a workqueue to send

Re: [Qemu-devel] [RFC v2 PATCH 5/4 PATCH] virtio-net: send gratuitous packet when needed

2011-10-23 Thread Michael S. Tsirkin
On Mon, Oct 24, 2011 at 02:54:59PM +1030, Rusty Russell wrote: On Sat, 22 Oct 2011 13:43:11 +0800, Jason Wang jasow...@redhat.com wrote: This make let virtio-net driver can send gratituous packet by a new config bit - VIRTIO_NET_S_ANNOUNCE in each config update interrupt. When this bit is

Re: [Qemu-devel] [Qemu-ppc] [PATCH] pseries: Correct vmx/dfp handling in both KVM and TCG cases

2011-10-23 Thread David Gibson
On Thu, Oct 20, 2011 at 11:49:40PM -0700, Alexander Graf wrote: On 20.10.2011, at 22:06, David Gibson wrote: On Thu, Oct 20, 2011 at 07:40:00PM -0700, Alexander Graf wrote: On 20.10.2011, at 17:41, David Gibson da...@gibson.dropbear.id.au wrote: On Thu, Oct 20, 2011 at 10:12:51AM -0700,